);
+ driver_unregister(uio_gpio_driver);
+}
+
+module_init(uio_gpio_init);
+module_exit(uio_gpio_exit);
+
+MODULE_LICENSE(GPL);
The header says this is GPL v2. So you should use GPL v2 here, too.
Best regards
Uwe
--
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc
Hello,
On Tue, Jul 13, 2010 at 09:07:41AM +0200, Uwe Kleine-König wrote:
Hi
On Mon, Jul 12, 2010 at 01:50:47PM -0600, Grant Likely wrote:
On Mon, Jul 12, 2010 at 1:34 PM, Linus Torvalds
torva...@linux-foundation.org wrote:
On Mon, Jul 12, 2010 at 12:17 PM, Nicolas Pitre n
usb_gadget_driver can go away.
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
Cc: Michal Nazarewicz m.nazarew...@samsung.com
Cc: Greg Kroah-Hartman gre...@suse.de
---
Hello,
there is an alternative patch in Greg's tree [1], but IMHO mine is
better as it doesn't need __ref.
Thoughts
Hello Michał,
On Fri, Jul 30, 2010 at 05:16:46PM +0200, Michał Nazarewicz wrote:
On Fri, 30 Jul 2010 16:49:14 +0200, Uwe Kleine-König
u.kleine-koe...@pengutronix.de wrote:
This is like usb_gadget_register_driver with the only difference that it
gets the bind function as parameter instead
. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
On Fri, Jul 30, 2010 at 06:08:23PM +0200, Michał Nazarewicz wrote:
On Fri, 30 Jul 2010 17:26:02 +0200, Uwe Kleine-König
u.kleine-koe...@pengutronix.de wrote:
On Fri, Jul 30, 2010 at 05:16:46PM +0200, Michał Nazarewicz wrote:
On Fri, 30 Jul 2010 16:49:14 +0200, Uwe Kleine-König
u.kleine-koe
__init printer_bind()
All callers are fixed.
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
Cc: Michał Nazarewicz m.nazarew...@samsung.com
Cc: David Brownell davi...@pacbell.net
Cc: Julia Lawall ju...@diku.dk
Cc: Greg Kroah-Hartman gre...@suse.de
---
Hello,
now that Michał seems
it up
locally here for now. Greg, just tell me when/if you need a fixed
patch.
That would be like what is done in the patch for
drivers/usb/gadget/fsl_udc_core.c below
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions
From: Arnd Bergmann a...@arndb.de
[ukl: split Arnd's patch by driver]
Signed-off-by: Arnd Bergmann a...@arndb.de
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
drivers/macintosh/mediabay.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
From: Arnd Bergmann a...@arndb.de
[ukl: split Arnd's patch by driver]
Signed-off-by: Arnd Bergmann a...@arndb.de
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
drivers/i2c/busses/i2c-mpc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
' qualifier from pointer target type [enabled by default]
Signed-off-by: Arnd Bergmann a...@arndb.de
[ukl: split Arnd's patch by driver and add changelog]
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
drivers/watchdog/mpc8xxx_wdt.c |2 +-
1 file changed, 1 insertion(+), 1
[enabled by default]
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
drivers/macintosh/mediabay.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/macintosh/mediabay.c b/drivers/macintosh/mediabay.c
index 831d751..54bf584 100644
--- a/drivers/macintosh
From: Arnd Bergmann a...@arndb.de
This cast is unneeded since *of_device_id.data became const.
[ukl: split Arnd's patch by driver and add changelog]
Signed-off-by: Arnd Bergmann a...@arndb.de
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
arch/powerpc/sysdev/fsl_msi.c
[-Werror]
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
arch/powerpc/sysdev/fsl_msi.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c
index 6e097de..a40acd6 100644
--- a/arch/powerpc/sysdev
[enabled by default]
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
drivers/gpio/gpio-mpc8xxx.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
index 5a1817e..9ae29cc 100644
--- a/drivers/gpio/gpio
pointer target type [enabled by default]
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
arch/powerpc/platforms/cell/celleb_pci.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/cell/celleb_pci.c
b/arch/powerpc/platforms/cell
[enabled by default]
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
drivers/i2c/busses/i2c-mpc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
index b76731e..775062c 100644
--- a/drivers/i2c/busses
type [-Werror]
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
arch/powerpc/platforms/83xx/suspend.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/83xx/suspend.c
b/arch/powerpc/platforms/83xx/suspend.c
index 1a04671..1d769a2 100644
the driver isn't holding.
Fixes: bb74d9a4a87b (fs_enet: use the new fixed PHY helpers)
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale
The ucc_geth_probe function assigns to ug_info-tbi_node and
ug_info-phy_node a value returned by of_parse_phandle which returns a
new reference. Put this reference again in the error path of
ucc_geth_probe and when removing the device.
Signed-off-by: Uwe Kleine-König u.kleine-koe
the driver isn't holding. Fix that by getting a
reference to the MAC.
Fixes: 87009814cdbb (ucc_geth: use the new fixed PHY helpers)
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
drivers/net/ethernet/freescale/ucc_geth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
)
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
drivers/net/ethernet/freescale/ucc_geth.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c
b/drivers/net/ethernet/freescale/ucc_geth.c
index a22ff770f9e5
On Thu, Aug 07, 2014 at 11:48:24PM +0200, Uwe Kleine-König wrote:
The ucc_geth_probe function assigns to ug_info-tbi_node and
ug_info-phy_node a value returned by of_parse_phandle which returns a
new reference. Put this reference again in the error path of
ucc_geth_probe and when removing
My series to fix the reference counting of dt nodes introduced a build
failure. Fix it.
Fixes: fa310789a488 (net: ucc_geth: drop acquired references in probe error
path and remove)
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
Hello,
I found a powerpc toolchain now, so
net: ucc_geth: drop acquired references in probe error
path and remove.
From the context, it appears that the variable is named ug_info.
Cc: Uwe Kleine-König u.kleine-koe...@pengutronix.de
Signed-off-by: Guenter Roeck li...@roeck-us.net
---
Only seen in -next.
My patch was only sent just
Hello Guenter,
On Sun, Aug 10, 2014 at 11:42:41AM -0700, Guenter Roeck wrote:
On 08/10/2014 11:36 AM, Uwe Kleine-König wrote:
On Sun, Aug 10, 2014 at 09:19:14AM -0700, Guenter Roeck wrote:
powerpc:mpc83xx_defconfig and other builds fail with
drivers/net/ethernet/freescale/ucc_geth.c
the __init annotation at the right
position where necessary.
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
Hello,
I don't know how arch/powerpc is maintained. So please tell me if I
should split this patch further.
I manually checked that all const annotations are OK, and the 0day
/mach/esdhc.h in this
patch as advertised in the subject?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
___
Linuxppc-dev mailing
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo
)
{
...
Does this help?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
+ V7M_SCB_CPUID);
}
from arch/arm/include/asm/cputype.h. The V7M_SCB_CPUID register never
changes, but there is no way gcc can deduce that.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http
make savedefconfig
mv defconfig arch/arm/configs/mx27_defconfig
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
___
Linuxppc-dev mailing list
Hello,
On Sat, Mar 26, 2011 at 06:11:29PM +1100, Stephen Rothwell wrote:
Uwe Kleine-König reported:
while working on an defconfig (arm/mx27) I noticed that just updating
it[1] results in removing CONFIG_EEPROM_AT24=y. The reason is that
since commit
.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org
would
be nice. Something like:
The BT_L2CAP and BT_SCO configs are bool since
6427451 (Bluetooth: Merge L2CAP and SCO modules into
bluetooth.ko)
. So change all defconfigs from =m to =y.
Other than that
Acked-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
Best
-rc2.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https
Hello Gabriel
On Wed, Apr 13, 2011 at 12:31:44PM +0200, Gabriel Paubert wrote:
On Wed, Apr 13, 2011 at 10:59:14AM +0200, Andreas Schwab wrote:
Uwe Kleine-König u.kleine-koe...@pengutronix.de writes:
$ git name-rev --refs=refs/tags/v2.6\*
69a07f0b117a40fcc1a479358d8e1f41793617f2
Hello,
On Wed, Sep 05, 2012 at 12:40:17PM +1000, Benjamin Herrenschmidt wrote:
On Mon, 2012-07-23 at 11:13 +0200, Uwe Kleine-König wrote:
This prepares *of_device_id.data becoming const. Without this change
the following warning would occur:
drivers/macintosh/mediabay.c: In function
On Wed, Sep 05, 2012 at 07:23:43PM +1000, Benjamin Herrenschmidt wrote:
On Wed, 2012-09-05 at 10:02 +0200, Uwe Kleine-König wrote:
Hello,
On Wed, Sep 05, 2012 at 12:40:17PM +1000, Benjamin Herrenschmidt wrote:
On Mon, 2012-07-23 at 11:13 +0200, Uwe Kleine-König wrote:
This prepares
machines.
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
Hello,
got the parameters for git-send-email wrong and forgot to send this to the
powerpc folks.
Best regards
Uwe
arch/powerpc/boot/dts/fsl/mpc8536si-post.dtsi | 2 +-
arch/powerpc/boot/dts/fsl/mpc8572si-post.dtsi | 2 +-
2
supporting MPC5121 this patch introduces a cpp
macro to select the right struct that defines the register layout.
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
arch/powerpc/include/asm/mpc52xx_psc.h | 5 ++-
drivers/spi/spi-mpc512x-psc.c | 70
On Tue, Jul 14, 2015 at 10:54:42AM +0100, Mark Brown wrote:
On Tue, Jul 14, 2015 at 11:19:56AM +0200, Uwe Kleine-König wrote:
static const struct of_device_id mpc512x_psc_spi_of_match[] = {
- { .compatible = fsl,mpc5121-psc-spi, },
+ { .compatible = fsl,mpc5121-psc-spi, .data = (void
The drivers support MPC5125 additionally to MPC5121, and there is an spi
mode that is also supported. Additionally some minor corrections are
done.
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
Hello,
I sent a patch adding mpc5125 support to the mpc512x driver and Mark
These were introduced in commit 25ae3a0739c6 ([POWERPC] mpc512x: Add
MPC512x PSC support to MPC52xx psc driver) and never used. Moreover
according to the datasheet[1] MEMERROR is bit 25 (0x40) and ORERR is
bit 27 (0x10).
[1] MPC5125RM Rev. 2; 11/2009
Signed-off-by: Uwe Kleine-König u.kleine-koe
configurations.
Fixes: 8bf960985dfc (spi: mpc512x-psc: add support for Freescale MPC5125)
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
Hello,
didn't check why my config doesn't throw this warning, but I could reproduce
and fix it with the .config and toolchain as suggested
Hello,
On Tue, Jul 21, 2015 at 09:21:13AM +0200, Uwe Kleine-König wrote:
> These were introduced in commit 25ae3a0739c6 ("[POWERPC] mpc512x: Add
> MPC512x PSC support to MPC52xx psc driver") and never used. Moreover
> according to the datasheet[1] MEMERROR is bit 25 (0x40) an
Hello Wolfram,
On Tue, Aug 09, 2016 at 01:36:17PM +0200, Wolfram Sang wrote:
> The core will do this for us now.
Would be nice to point out the relevant commit that changed the core in
the commit log.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-Kö
regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
Hello Peter,
On Wed, May 16, 2018 at 09:16:47AM +0200, Peter Rosin wrote:
> Acked-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de> [emf32 and imx]
s/emf/efm/
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux
other patches in this series, but assuming that
they are similar in spirit, the same question applies for them.
Do I miss anything?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
On Fri, Nov 27, 2020 at 09:35:39AM +0100, Geert Uytterhoeven wrote:
> Hi Uwe,
>
> On Thu, Nov 26, 2020 at 6:03 PM Uwe Kleine-König
> wrote:
> > The remove callback is only called for devices that were probed
> > successfully before. As the matching probe function can
-by: Geert Uytterhoeven
> Signed-off-by: Leonard Goehrs
Reviewed-by: Uwe Kleine-König
Thanks for picking this up.
Best regards and have a nice week-end,
Uwe Kleine-König
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions
ps3_system_bus_driver::remove return void, too. All users
already unconditionally return 0, this commit makes it obvious that
returning an error code is a bad idea and ensures future users behave
accordingly.
Signed-off-by: Uwe Kleine-König
---
arch/powerpc/include/asm/ps3.h | 4
The remove callback is only called for devices that were probed
successfully before. As the matching probe function cannot complete
without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to
check this here.
Signed-off-by: Uwe Kleine-König
---
sound/ppc/snd_ps3.c | 2 --
1 f
callback.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | https://www.pengutronix.de/ |
signature.asc
Description: PGP signature
Hello Michael,
On Sat, Nov 28, 2020 at 09:48:30AM +0100, Takashi Iwai wrote:
> On Thu, 26 Nov 2020 17:59:50 +0100,
> Uwe Kleine-König wrote:
> >
> > The driver core ignores the return value of struct device_driver::remove
> > because there is only little that can b
Hello Dany,
On Tue, Jan 19, 2021 at 10:14:25AM -0800, Dany Madden wrote:
> On 2021-01-17 02:12, Uwe Kleine-König wrote:
> > while working on some cleanup I stumbled over a problem in the ibmvnic's
> > remove callback. Since commit
> >
> > 7d7195a026ba (&quo
store(>state_lock, flags);
> - return -EBUSY;
> - }
> -
> adapter->state = VNIC_REMOVING;
> spin_unlock_irqrestore(>state_lock, flags);
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | https://www.pengutronix.de/ |
signature.asc
Description: PGP signature
If vcc_probe() succeeded dev_set_drvdata() is called with a non-NULL
value, and if vcc_probe() failed vcc_remove() isn't called.
So there is no way dev_get_drvdata() can return NULL in vcc_remove() and
the check can just go away.
Signed-off-by: Uwe Kleine-König
---
drivers/tty/vcc.c | 3 ---
1
onsidering,
Uwe Kleine-König
Uwe Kleine-König (3):
tty: hvcs: Drop unnecessary if block
tty: vcc: Drop unnecessary if block
tty: vcc: Drop impossible to hit WARN_ON
drivers/tty/hvc/hvcs.c | 3 ---
drivers/tty/vcc.c | 10 ++
2 files changed, 2 insertions(+), 11 deletions(-)
--
2.29.2
If hvcs_probe() succeeded dev_set_drvdata() is called with a non-NULL
value, and if hvcs_probe() failed hvcs_remove() isn't called.
So there is no way dev_get_drvdata() can return NULL in hvcs_remove() and
the check can just go away.
Signed-off-by: Uwe Kleine-König
---
drivers/tty/hvc/hvcs.c
vcc_get() returns the port that has provided port->index. As the port that
is about to be removed isn't removed yet this trivially will find this
port. So simplify the call to not assign an identical value to the port
pointer and drop the warning that is never hit.
Signed-off-by: Uwe Kleine-Kö
arch/powerpc/platforms/pseries/vio.c) records the
return value and passes it on. But the driver core doesn't care for
the return value (see __device_release_driver() in drivers/base/dd.c
calling dev->bus->remove()).
--
Pengutronix e.K. | Uwe Kleine-Kö
Hello Sukadev,
On 1/28/21 8:07 PM, Sukadev Bhattiprolu wrote:
Slightly off-topic, should ndo_stop() also return a void? Its return value
seems to be mostly ignored and [...]
I don't know enough about the network stack to tell. Probably it's a
good idea to start a separate thread for this and
without a
remove callback vio_cmo_bus_remove(viodev) wasn't called. As the device
core still considers the device unbound after vio_bus_remove() returns
calling this unconditionally is the consistent behaviour which is
implemented here.
Signed-off-by: Uwe Kleine-König
---
Hello,
note
On Tue, Jul 06, 2021 at 01:17:37PM +0200, Cornelia Huck wrote:
> On Tue, Jul 06 2021, Cornelia Huck wrote:
>
> > On Tue, Jul 06 2021, Uwe Kleine-König
> > wrote:
> >
> >> The driver core ignores the return value of this callback because there
> >&
-off-by: Uwe Kleine-König
---
Hello,
this patch depends on "PCI: endpoint: Make struct pci_epf_driver::remove
return void" that is not yet applied, see
https://lore.kernel.org/r/20210223090757.57604-1-u.kleine-koe...@pengutronix.de.
I tested it using allmodconfig on amd64 and arm, but
On Wed, Jul 07, 2021 at 10:08:53PM -0400, Sven Van Asbroeck wrote:
> On Tue, Jul 6, 2021 at 11:50 AM Uwe Kleine-König
> wrote:
> >
> > drivers/staging/fieldbus/anybuss/host.c | 4 +---
>
> Awesome !
>
> Acked-by: Sven Van Asbroeck
I note that as an Ack for pat
ps virtio_rpmsg_ops = {
though it's not obvious for me that the last hunk is sensible. (OTOH the
return code is ignored anyhow as rpmsg_dev_remove() is the only caller.
Best regards and thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | https://www.pengutronix.de/ |
signature.asc
Description: PGP signature
Hello,
v1 was acked by some more after I stopped looking in my mailbox while
preparing v2:
On Tue, Jul 06, 2021 at 05:48:03PM +0200, Uwe Kleine-König wrote:
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disa
1-u.kleine-koe...@pengutronix.de.
Best regards
Uwe
Uwe Kleine-König (4):
s390/cio: Make struct css_driver::remove return void
s390/ccwgroup: Drop if with an always false condition
s390/scm: Make struct scm_driver::remove return void
bus: Make remove callback return void
arch/arm/commo
Krogerus (For ulpi and typec)
Acked-by: Samuel Iglesias Gonsálvez (For ipack)
Reviewed-by: Tom Rix (For fpga)
Acked-by: Geoff Levand (For ps3)
Signed-off-by: Uwe Kleine-König
---
arch/arm/common/locomo.c | 3 +--
arch/arm/common/sa.c | 4 +---
arch/arm/mach
Hello,
On 3/2/21 3:09 AM, Michael Ellerman wrote:
Stephen Rothwell writes:
Hi all,
After merging the powerpc-fixes tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/net/ethernet/ibm/ibmvnic.c:5399:13: error: conflicting types for
'ibmvnic_remove'
5399 |
-by: Greg Kroah-Hartman
Signed-off-by: Uwe Kleine-König
---
Hello,
I dropped the sparc specific files (i.e. all that Michael Ellerman
didn't characterize as powerpc specific and verified that they are
indeed sparc-only).
The commit log is adapted accordingly.
Best regards
Uwe
arch/powerpc/include/asm
t's easy to resolve.
Other than that:
Acked-by: Uwe Kleine-König
Best regards
Uwe
> 1 file changed, 25 deletions(-)
>
> diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c
> index c90848919644..0b89d878a108 100644
> --- a/drivers/tty/hvc/hvcs.c
> +++ b/drivers/
Kroah-Hartman
Signed-off-by: Uwe Kleine-König
---
Hello,
v1 (sent with Message-Id: 20210127215010.99954-1-...@kleine-koenig.org>
had an back then unfulfilled precondition for a patch to
drivers/net/ethernet/ibm/ibmvnic.c. That patch already got into v5.11 as
5e9eff5dfa46 "ibmvnic: devic
-by: Benjamin Tissoires (For hid)
Acked-by: Thorsten Scherer (For siox)
Acked-by: Sven Van Asbroeck (For anybuss)
Acked-by: Ulf Hansson (For MMC)
Signed-off-by: Uwe Kleine-König
---
arch/arm/common/locomo.c | 3 +--
arch/arm/common/sa.c | 4 +---
arch/arm/mach-rpc
-driver.c
sound/ac97/bus.c
Best regards
Uwe
Uwe Kleine-König (5):
PCI: endpoint: Make struct pci_epf_driver::remove return void
s390/cio: Make struct css_driver::remove return void
s390/ccwgroup: Drop if with an always false condition
s390/scm: Make struct scm_driver::remove return void
bus
for that, this should be fixed now.
Best regards
Uwe
Changes since v2:
- Add several acks/review tags
- Include patch #1 explicitly
- rebase to v5.14-rc1, build test on amd64, arm64 and s390 using
allmodconfig
Uwe Kleine-König (5):
PCI: endpoint: Make struct pci_epf_driver::remove return void
s390
-by: Benjamin Tissoires (For hid)
Acked-by: Thorsten Scherer (For siox)
Acked-by: Sven Van Asbroeck (For anybuss)
Acked-by: Ulf Hansson (For MMC)
Signed-off-by: Uwe Kleine-König
---
arch/arm/common/locomo.c | 3 +--
arch/arm/common/sa.c | 4 +---
arch/arm/mach-rpc
struct pci_dev.
Signed-off-by: Uwe Kleine-König
---
drivers/pci/pci-driver.c | 4
include/linux/pci.h | 3 +--
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
index 740d5bf5d411..5d950eb476e2 100644
--- a/drivers/pci/pci
ing pci_dev::dev->driver.
Signed-off-by: Uwe Kleine-König
---
include/linux/pci.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 540b377ca8f6..778f3b5e6f23 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -887,6 +887,7 @@ struct pci_
This prepares removing the driver member of struct pci_dev which holds the
same information than struct pci_dev::dev->driver.
Signed-off-by: Uwe Kleine-König
---
arch/powerpc/include/asm/ppc-pci.h| 3 +-
arch/powerpc/kernel/eeh_driver.c | 12 ---
arch/x86/eve
is introduced abstracting access to struct pci_dev->driver. All users
are then converted to use this and in the last patch the macro is
changed to make use of struct pci_dev::dev->driver to get rid of the
duplicated tracking.
Best regards
Uwe
Uwe Kleine-König (6):
PCI: Simplify pci_device_
On Fri, Aug 06, 2021 at 04:24:52PM -0500, Bjorn Helgaas wrote:
> On Fri, Aug 06, 2021 at 08:46:23AM +0200, Uwe Kleine-König wrote:
> > On Thu, Aug 05, 2021 at 06:42:34PM -0500, Bjorn Helgaas wrote:
>
> > > I looked at all the bus_type.probe() methods, it looks like pci_dev
Hello Bjorn,
On Thu, Aug 05, 2021 at 06:42:34PM -0500, Bjorn Helgaas wrote:
> On Tue, Aug 03, 2021 at 12:01:44PM +0200, Uwe Kleine-König wrote:
> > Hello,
> >
> > changes since v1
> > (https://lore.kernel.org/linux-pci/20210729203740.1377045-1-u.kleine-koe...@peng
struct pci_dev::driver contains (apart from a constant offset) the same
data as struct pci_dev::dev->driver. Replace all remaining users of the
former pointer by the latter to allow removing the former.
Signed-off-by: Uwe Kleine-König
---
arch/powerpc/kernel/eeh_driver.c | 10 -
a
driver.
Signed-off-by: Uwe Kleine-König
---
arch/powerpc/include/asm/ppc-pci.h | 7 ++-
drivers/bcma/host_pci.c | 7 ---
drivers/crypto/hisilicon/qm.c| 2 +-
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 2 +-
d
This prepares removing the driver member of struct pci_dev which holds the
same information than struct pci_dev::dev->driver.
Signed-off-by: Uwe Kleine-König
---
arch/powerpc/include/asm/ppc-pci.h| 3 +-
arch/powerpc/kernel/eeh_driver.c | 12 ---
arch/x86/eve
tch
introducing the wrapper. Patch 4 could be split by maintainer tree or
squashed into patch 3 completely.
Best regards
Uwe
Uwe Kleine-König (5):
PCI: Simplify pci_device_remove()
PCI: Drop useless check from pci_device_probe()
PCI: Provide wrapper to access a pci_dev's bound driver
PCI: Adapt all c
Hello Boris,
On Fri, Jul 30, 2021 at 04:37:31PM -0400, Boris Ostrovsky wrote:
> On 7/29/21 4:37 PM, Uwe Kleine-König wrote:
> > --- a/drivers/pci/xen-pcifront.c
> > +++ b/drivers/pci/xen-pcifront.c
> > @@ -599,12 +599,12 @@ static pci_ers_result_t pcifront_common
Hi Andy,
On Fri, Jul 30, 2021 at 11:06:20AM +0300, Andy Shevchenko wrote:
> On Thu, Jul 29, 2021 at 10:37:35PM +0200, Uwe Kleine-König wrote:
> > struct pci_dev tracks the bound pci driver twice. This series is about
> > removing this duplication.
> >
> > The first tw
From: Uwe Kleine-König
Hello,
Today the following is always true for a struct pci_dev *pdev:
pdev->driver ==
pdev->dev.driver ? to_pci_driver(pdev->dev.driver) : NULL
This series is about getting rid of struct pci_dev::driver. The first
three patches are u
looks fine to me. (One could wonder if it's sensible to fall
back to the device name if the driver has no nice name, but this isn't
new with my change.)
> > + name = dev_driver_string(>dev);
> > + if (*name == '\0')
> > + name = dev_name(>dev);
> > +
>
> More of this weirdness.
I admit it's not pretty. Would it help to use !strcmp(name, "")
instead of *name == '\0'? Any other constructive suggestion?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | https://www.pengutronix.de/ |
signature.asc
Description: PGP signature
On Tue, Oct 12, 2021 at 06:32:12PM -0500, Bjorn Helgaas wrote:
> On Mon, Oct 04, 2021 at 02:59:24PM +0200, Uwe Kleine-König wrote:
> > Hello,
> >
> > this is v6 of the quest to drop the "driver" member from struct pci_dev
> > which tracks the same data (apart
Hello,
On Wed, Oct 13, 2021 at 05:54:28AM -0500, Bjorn Helgaas wrote:
> On Wed, Oct 13, 2021 at 10:51:31AM +0200, Uwe Kleine-König wrote:
> > On Tue, Oct 12, 2021 at 06:32:12PM -0500, Bjorn Helgaas wrote:
> > > diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/g
Up to now mcu_gpiochip_remove() returns zero unconditionally. Make it
return void instead which makes it easier to see in the callers that
there is no error to handle.
Also the return value of i2c remove callbacks is ignored anyway.
Signed-off-by: Uwe Kleine-König
---
arch/powerpc/platforms
On Tue, Sep 28, 2021 at 12:01:28PM +0200, Simon Horman wrote:
> On Mon, Sep 27, 2021 at 10:43:22PM +0200, Uwe Kleine-König wrote:
> > From: Uwe Kleine-König
> >
> > struct pci_dev::driver holds (apart from a constant offset) the same
> > data as struct pci_dev:
1 - 100 of 293 matches
Mail list logo
