Re: [Patch V6 2/6] irqchip: xilinx: Clean up irqdomain argument and read/write

Hi, On 11/01/2016 11:05 AM, Zubair Lutfullah Kakakhel wrote: Hi, Thanks for the review. On 10/31/2016 07:51 PM, Thomas Gleixner wrote: On Mon, 31 Oct 2016, Zubair Lutfullah Kakakhel wrote: The drivers read/write function handling is a bit quirky. Can you please explain in more detail

Re: [Patch v5 04/12] irqchip: xilinx: Add support for parent intc

Hi, Thanks for the review. Some comments in-line. On 10/21/2016 10:48 AM, Marc Zyngier wrote: On 17/10/16 17:52, Zubair Lutfullah Kakakhel wrote: The MIPS based xilfpga platform has the following IRQ structure Peripherals --> xilinx_intcontroller -> mips_cpu_int controller Add s

[Patch v7 7/7] powerpc/virtex: Use generic xilinx irqchip driver

The Xilinx interrupt controller driver is now available in drivers/irqchip. Switch to using that driver. Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> Acked-by: Michael Ellerman <m...@ellerman.id.au> (powerpc) --- V6 - V7 Rebase to v4.9-rc5 V5 ->

[Patch v7 0/7] microblaze/PowerPC: Move irq-xilinx to irqchip

ps V2 -> V3 Cleanup the interrupt controller driver a bit based on feedback Rebase to v4.8-rc4 V1 -> V2 Resubmitting without truncating the diff output for file moves Removed accidental local mac address entry Individual logs have more detail Zubair Lutfullah Kakakhel (7): microblaze: irqchip

[Patch v7 6/7] irqchip: xilinx: Try to fall back if xlnx, kind-of-intr not provided

The powerpc dts file does not have the xlnx,kind-of-intr property. Instead of erroring out, give a warning instead. And attempt to continue to probe the interrupt controller while assuming kind-of-intr is 0x0 as a fall back. Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.

[Patch v7 2/7] irqchip: xilinx: clean up print messages

Remove __func__ and prefix irq-xilinx in various debug prints Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> --- V6 -> V7 New patch This diff was squashed into another patch. Split it up for cleanliness --- drivers/irqchip/irq-xilinx-intc.c | 18 +

[Patch v7 1/7] microblaze: irqchip: Move intc driver to irqchip

The Xilinx AXI Interrupt Controller IP block is used by the MIPS based xilfpga platform and a few PowerPC based platforms. Move the interrupt controller code out of arch/microblaze so that it can be used by everyone Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com>

[Patch v7 4/7] irqchip: xilinx: Rename get_irq to xintc_get_irq

Now that the driver is generic and used by multiple archs, get_irq is too generic. Rename get_irq to xintc_get_irq to avoid any conflicts Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> --- V6 -> V7 Rebase to v4.9-rc5 V5 -> V6 Removed __func__ in printk Rebase

[Patch v7 5/7] irqchip: xilinx: Add support for parent intc

The MIPS based xilfpga platform has the following IRQ structure Peripherals --> xilinx_intcontroller -> mips_cpu_int controller Add support for the driver to chain the irq handler Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> --- V6 -> V7 Rebase to v4.

[Patch v7 3/7] irqchip: xilinx: restructure and use jump label api

Add a global structure to house various variables. And cleanup read/write handling by using jump label api. Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> --- V6 -> V7 Restructure and use jump label api Better commit log V5 -> V6 Removed __func__ from p

Re: [Patch v7 0/7] microblaze/PowerPC: Move irq-xilinx to irqchip

Hi, On 11/22/2016 10:55 AM, Marc Zyngier wrote: On 14/11/16 12:13, Zubair Lutfullah Kakakhel wrote: Hi, This patch series moves the Xilinx interrupt controller driver out of arch/microblaze to drivers/irqchip and then cleans it up a bit. And then removes another implementation of the driver

Re: [Patch v7 3/7] irqchip: xilinx: restructure and use jump label api

Hi, On 11/15/2016 12:49 PM, Michal Simek wrote: On 14.11.2016 13:13, Zubair Lutfullah Kakakhel wrote: Add a global structure to house various variables. And cleanup read/write handling by using jump label api. Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.

Re: [Patch v7 6/7] irqchip: xilinx: Try to fall back if xlnx,kind-of-intr not provided

Hi, On 11/18/2016 01:29 PM, Thomas Gleixner wrote: On Mon, 14 Nov 2016, Zubair Lutfullah Kakakhel wrote: The powerpc dts file does not have the xlnx,kind-of-intr property. Instead of erroring out, give a warning instead. And attempt to continue to probe the interrupt controller while assuming

Re: [Patch v7 6/7] irqchip: xilinx: Try to fall back if xlnx,kind-of-intr not provided

Hi, On 11/21/2016 02:17 PM, Marc Zyngier wrote: On 21/11/16 14:05, Zubair Lutfullah Kakakhel wrote: Hi, On 11/18/2016 01:29 PM, Thomas Gleixner wrote: On Mon, 14 Nov 2016, Zubair Lutfullah Kakakhel wrote: The powerpc dts file does not have the xlnx,kind-of-intr property. Instead

Re: [Patch V6 2/6] irqchip: xilinx: Clean up irqdomain argument and read/write

Hi, Thanks for the review. On 10/31/2016 07:51 PM, Thomas Gleixner wrote: On Mon, 31 Oct 2016, Zubair Lutfullah Kakakhel wrote: The drivers read/write function handling is a bit quirky. Can you please explain in more detail what's quirky and why it should be done differently

[Patch V6 0/6] microblaze/PowerPC: Move irq-xilinx

; V3 Cleanup the interrupt controller driver a bit based on feedback Rebase to v4.8-rc4 V1 -> V2 Resubmitting without truncating the diff output for file moves Removed accidental local mac address entry Individual logs have more detail Zubair Lutfullah Kakakhel (6): microblaze: irqchip: Move intc dr

[Patch V6 4/6] irqchip: xilinx: Add support for parent intc

The MIPS based xilfpga platform has the following IRQ structure Peripherals --> xilinx_intcontroller -> mips_cpu_int controller Add support for the driver to chain the irq handler Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> --- V5 -> V6 Use ch

[Patch V6 5/6] irqchip: xilinx: Try to fall back if xlnx, kind-of-intr not provided

The powerpc dts file upstream does not have the xlnx,kind-of-intr property. Instead of erroring out, give a warning instead. And attempt to continue to probe the interrupt controller while assuming kind-of-intr is 0x0 as a fall back. Signed-off-by: Zubair Lutfullah Kakakhel <zubair.ka

[Patch V6 1/6] microblaze: irqchip: Move intc driver to irqchip

The Xilinx AXI Interrupt Controller IP block is used by the MIPS based xilfpga platform and a few PowerPC based platforms. Move the interrupt controller code out of arch/microblaze so that it can be used by everyone Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com>

[Patch V6 2/6] irqchip: xilinx: Clean up irqdomain argument and read/write

The drivers read/write function handling is a bit quirky. And the irqmask is passed directly to the handler. Add a new irqchip struct to pass to the handler and cleanup read/write handling. Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> --- V5 -> V6 Removed __fu

[Patch V6 6/6] powerpc/virtex: Use generic xilinx irqchip driver

The Xilinx interrupt controller driver is now available in drivers/irqchip. Switch to using that driver. Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> Acked-by: Michael Ellerman <m...@ellerman.id.au> (powerpc) --- V5 -> V6 Added Acked-by Micheal Ellerma

[Patch V6 3/6] irqchip: xilinx: Rename get_irq to xintc_get_irq

Now that the driver is generic and used by multiple archs, get_irq is too generic. Rename get_irq to xintc_get_irq to avoid any conflicts Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> --- V5 -> V6 Removed __func__ in printk Rebase to v4.9-rc3 V4 -> V5 Reb

[Patch v5 04/12] irqchip: xilinx: Add support for parent intc

The MIPS based xilfpga platform has the following IRQ structure Peripherals --> xilinx_intcontroller -> mips_cpu_int controller Add support for the driver to chain the irq handler Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> --- V4 -> V5 Rebased to v

[Patch v5 00/12] microblaze/MIPS/PowerPC: Xilinx intc

ontroller driver a bit based on feedback Rebase to v4.8-rc4 V1 -> V2 Resubmitting without truncating the diff output for file moves Removed accidental local mac address entry Individual logs have more detail Zubair Lutfullah Kakakhel (12): microblaze: irqchip: Move intc driver to irqchip irq

[Patch v5 02/12] irqchip: xilinx: Clean up irqdomain argument and read/write

The drivers read/write function handling is a bit quirky. And the irqmask is passed directly to the handler. Add a new irqchip struct to pass to the handler and cleanup read/write handling. Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> --- V4 -> V5 Rebased to

[Patch v5 03/12] irqchip: xilinx: Rename get_irq to xintc_get_irq

Now that the driver is generic and used by multiple archs, get_irq is too generic. Rename get_irq to xintc_get_irq to avoid any conflicts Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> --- V4 -> V5 Rebased to v4.9-rc1 Use __func__ in pr_err V3 -> V4 New patc

[Patch v5 01/12] microblaze: irqchip: Move intc driver to irqchip

The Xilinx AXI Interrupt Controller IP block is used by the MIPS based xilfpga platform and a few PowerPC based platforms. Move the interrupt controller code out of arch/microblaze so that it can be used by everyone Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com>

[Patch v5 09/12] MIPS: xilfpga: Update DT node and specify uart irq

Update the DT node with the UART irq Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> --- V3 -> V4 No change V2 -> V3 No change V1 -> V2 No change --- arch/mips/boot/dts/xilfpga/nexys4ddr.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arc

[Patch v5 11/12] MIPS: xilfpga: Add DT node for AXI emaclite

The xilfpga platform has a Xilinx AXI emaclite block. Add the DT node to use it. Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> --- V3 -> V4 No change V2 -> V3 No change V1 -> V2 Removed accidental local-mac-address entry --- arch/mips/boot/dts/xilfpg

[Patch v5 08/12] MIPS: xilfpga: Use Xilinx Interrupt Controller

IRQs from peripherals such as i2c/uart/ethernet come via the AXI Interrupt controller. Select it in Kconfig for xilfpga and add the DT node Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> --- V4 -> V5 Rebase to v4.9-rc1 Renamed XILINX_AXI_INTC to XILINX_INTC

[Patch v5 06/12] powerpc/virtex: Use generic xilinx irqchip driver

The Xilinx interrupt controller driver is now available in drivers/irqchip. Switch to using that driver. Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> --- V5 New patch Tested on virtex440-ml507 using qemu --- arch/powerpc/include/asm/xilinx_intc.h | 2 +- arch/p

[Patch v5 05/12] irqchip: xilinx: Try to fall back if xlnx, kind-of-intr not provided

The powerpc dts file upstream does not have the xlnx,kind-of-intr property. Instead of erroring out, give a warning instead. And attempt to continue to probe the interrupt controller while assuming kind-of-intr is 0x0 as a fall back. Signed-off-by: Zubair Lutfullah Kakakhel <zubair.ka

[Patch v5 07/12] MIPS: xilfpga: Use irqchip instead of the legacy way

This prepares the code use the Xilinx Interrupt Controller driver now available in drivers/irqchip Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> --- V4 -> V5 Better commit message V3 -> V4 Corrected commit message. Was irq-xilinx.c. Now irq-axi-intc.c V2 -&g

[Patch v5 10/12] MIPS: xilfpga: Add DT node for AXI I2C

The xilfpga platform has an AXI I2C Bus master with a temperature sensor connected to it. Add the device tree node to use them. Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> --- V3 -> V4 changed compatible string from "adt7420" to "adi,adt7420&

[Patch v5 12/12] MIPS: xilfpga: Update defconfig

Update defconfig to enable emaclite, i2c, temp sensor found on the xilfpga platform Signed-off-by: Zubair Lutfullah Kakakhel <zubair.kakak...@imgtec.com> --- V3 -> V4 No change V2 -> V3 No change V1 -> V2 No change --- arch/mips/configs/xilfpga