Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-06-30 Thread Ahmed S. Darwish
4452.3675847-5-a.darw...@linutronix.de I did not add a message though to get in-sync with the IRQ macros above. Thanks, -- Ahmed S. Darwish Linutronix GmbH

Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-06-23 Thread Ahmed S. Darwish
On Tue, Jun 23, 2020 at 05:24:50PM +0200, Peter Zijlstra wrote: > On Tue, Jun 23, 2020 at 05:00:31PM +0200, Ahmed S. Darwish wrote: > > On Tue, Jun 23, 2020 at 10:36:52AM +0200, Peter Zijlstra wrote: > > ... > > > -#define lockdep_ass

Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables

2020-06-23 Thread Ahmed S. Darwish
\ > + WARN_ON_ONCE(debug_locks && !this_cpu_read(hardirqs_enabled)); \ > +} while (0) > Can we add a small comment on top of lockdep_off(), stating that lockdep IRQ tracking will still be kept after a lockdep_off call? thanks, -- Ahmed S. Darwish Linutronix GmbH