Re: [PATCH] powerpc: platforms: 52xx: Fix a resource leak in an error handling path

2022-01-29 Thread Anatolij Gustschin
On Sat, 29 Jan 2022 08:16:04 +0100 Christophe JAILLET christophe.jail...@wanadoo.fr wrote: >The error handling path of mpc52xx_lpbfifo_probe() and a request_irq() is >not balanced by a corresponding free_irq(). > >Add the missing call, as already done in the remove function. > >Fixes:

Re: [PATCH] powerpc/mpc512x: dts: fix PSC node warnings

2021-10-14 Thread Anatolij Gustschin
On Thu, 14 Oct 2021 07:33:26 -0500 Rob Herring robh...@kernel.org wrote: ... >> +++ b/arch/powerpc/boot/dts/ac14xx.dts >> @@ -301,13 +301,21 @@ >> fsl,tx-fifo-size = <512>; >> }; >> >> + /delete-node/ psc@11400; >> + /delete-node/

[PATCH v2] powerpc/mpc512x: dts: fix PSC node warnings

2021-10-14 Thread Anatolij Gustschin
' mpc5121.dtsi:457.13-466.5: Warning (spi_bus_bridge): /soc@8000/psc@11900: node name for SPI buses should be 'spi' Signed-off-by: Anatolij Gustschin --- Changes in v2: - extract PSC nodes to files which can be included separately and extended as needed arch/powerpc/boot/dts/ac14xx.dts

Re: [RFC PATCH] powerpc: dts: Remove MPC5xxx platforms

2021-10-14 Thread Anatolij Gustschin
hose hanging around, but they came with Open >> Firmware rather than relying on the dts files that ship with the >> kernel. >> >> Grant Likely was the original maintainer for MPC52xx until 2011, >> Anatolij Gustschin is still listed as maintainer since then but hasn't

Re: linux-next: build warnings in Linus' tree

2021-10-14 Thread Anatolij Gustschin
On Thu, 14 Oct 2021 10:44:46 +0200 Arnd Bergmann a...@arndb.de wrote: >On Thu, Oct 14, 2021 at 12:12 AM Anatolij Gustschin wrote: >> On Tue, 12 Oct 2021 16:39:56 +0200 >> Arnd Bergmann a...@arndb.de wrote: >> ... >> >Grant Likely was the original maintainer for MP

[PATCH] powerpc/mpc512x: dts: fix PSC node warnings

2021-10-14 Thread Anatolij Gustschin
(spi_bus_bridge): /soc@8000/psc@11900: node name for SPI buses should be 'spi' Signed-off-by: Anatolij Gustschin --- arch/powerpc/boot/dts/ac14xx.dts | 17 +++-- arch/powerpc/boot/dts/pdm360ng.dts | 11 ++- 2 files changed, 25 insertions(+), 3 deletions(-) diff --git

[PATCH] dmaengine: bestcomm: fix system boot lockups

2021-10-14 Thread Anatolij Gustschin
C5200") Cc: sta...@vger.kernel.org # v5.14+ Signed-off-by: Anatolij Gustschin --- drivers/dma/bestcomm/ata.c | 2 +- drivers/dma/bestcomm/bestcomm.c | 22 +++--- drivers/dma/bestcomm/fec.c | 4 ++-- drivers/dma/bestcomm/gen_bd.c | 4 ++-- 4 files changed, 16

[PATCH] powerpc/5200: dts: fix psc node warning

2021-10-13 Thread Anatolij Gustschin
Fix build warning: Warning (spi_bus_bridge): /soc5200@f000/psc@2000: node name for SPI buses should be 'spi' Signed-off-by: Anatolij Gustschin --- arch/powerpc/boot/dts/motionpro.dts | 4 arch/powerpc/boot/dts/o2d.dtsi | 6 +- 2 files changed, 9 insertions(+), 1 deletion

Re: linux-next: build warnings in Linus' tree

2021-10-13 Thread Anatolij Gustschin
On Wed, 13 Oct 2021 17:17:25 -0500 Rob Herring robh...@kernel.org wrote: ... >In general, you shouldn't need to be changing the drivers. Can you >tell me which warnings need driver changes? ethernet and mdio drivers share registers, so they use same unit-address:

Re: linux-next: build warnings in Linus' tree

2021-10-13 Thread Anatolij Gustschin
Hi Arnd, Rob, On Tue, 12 Oct 2021 16:39:56 +0200 Arnd Bergmann a...@arndb.de wrote: ... >Grant Likely was the original maintainer for MPC52xx until 2011, >Anatolij Gustschin is still listed as maintainer since then but hasn't >been active in it for a while either. Anatolij can probably b

[PATCH 1/4] powerpc/5200: dts: add missing pci ranges

2021-10-13 Thread Anatolij Gustschin
Add ranges property to fix build warnings: Warning (pci_bridge): /pci@fd00: missing ranges for PCI bridge (or not a bridge) Signed-off-by: Anatolij Gustschin --- arch/powerpc/boot/dts/mpc5200b.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/boot/dts

[PATCH 4/4] powerpc/5200: dts: fix localbus node warnings

2021-10-13 Thread Anatolij Gustschin
Signed-off-by: Anatolij Gustschin --- arch/powerpc/boot/dts/a3m071.dts| 12 +- arch/powerpc/boot/dts/a4m072.dts| 20 - arch/powerpc/boot/dts/charon.dts| 14 ++-- arch/powerpc/boot/dts/cm5200.dts| 7 -- arch/powerpc/boot/dts/digsy_mt

[PATCH 3/4] powerpc/5200: dts: fix memory node unit name

2021-10-13 Thread Anatolij Gustschin
Fixes build warnings: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name Signed-off-by: Anatolij Gustschin --- arch/powerpc/boot/dts/charon.dts| 2 +- arch/powerpc/boot/dts/digsy_mtc.dts | 2 +- arch/powerpc/boot/dts/lite5200.dts | 2 +- arch

[PATCH 0/4] Update mpc5200 dts files to fix warnings

2021-10-13 Thread Anatolij Gustschin
This series fixes localbus, memory and pci node build warnings. It was tested with current linux-next on digsy_mtc and tqm5200 boards. Anatolij Gustschin (4): powerpc/5200: dts: add missing pci ranges powerpc/5200: dts: fix pci ranges warnings powerpc/5200: dts: fix memory node unit name

[PATCH 2/4] powerpc/5200: dts: fix pci ranges warnings

2021-10-13 Thread Anatolij Gustschin
Fix ranges property warnings: pci@fd00:ranges: 'oneOf' conditional failed, one must be fixed: Signed-off-by: Anatolij Gustschin --- arch/powerpc/boot/dts/a4m072.dts| 6 +++--- arch/powerpc/boot/dts/charon.dts| 6 +++--- arch/powerpc/boot/dts/digsy_mtc.dts | 6 +++--- arch/powerpc

Re: [PATCH 6/8] powerpc: Update MPC5XXX MAINTAINERS entry

2020-02-29 Thread Anatolij Gustschin
On Tue, 25 Feb 2020 10:31:44 +1100 Michael Ellerman m...@ellerman.id.au wrote: >It's several years since the last commit from Anatolij, so mark >MPC5XXX as "Odd Fixes" rather than "Maintained". > >Also the git link no longer works so remove it. > >Cc: Anato

Re: [PATCH 3/3] powerpc/5200: dts: digsy_mtc.dts: fix rv3029 compatible

2017-09-15 Thread Anatolij Gustschin
On Fri, 15 Sep 2017 04:00:04 +0200 Alexandre Belloni alexandre.bell...@free-electrons.com wrote: >The proper compatible for rv3029 is microcrystal,rv3029. > >Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> Acked-by: Anatolij Gustschin <ag...@denx.de>

Re: [PATCH] powerpc: dts: use #include "..." to include local DT

2017-06-13 Thread Anatolij Gustschin
> >Fix them to remove -I$(srctree)/arch/$(SRCARCH)/boot/dts path from >dtc_cpp_flags. > >Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> Tested-by: Anatolij Gustschin <ag...@denx.de>

Re: [PATCH] powerpc: dts: use #include "..." to include local DT

2017-06-13 Thread Anatolij Gustschin
On Tue, 13 Jun 2017 20:21:45 +1000 Michael Ellerman m...@ellerman.id.au wrote: >Masahiro Yamada writes: ... >> Ping. >> I am not 100% sure who is responsible for this, >> but somebody, could take a look at this patch, please? > >Have you tested it actually works?

Re: arch/powerpc/platforms/512x/clock-commonclk.c:824: wrong % specifier ?

2016-06-27 Thread Anatolij Gustschin
On Mon, 27 Jun 2016 08:59:42 +0100 David Binderman linuxdev.baldr...@gmail.com wrote: ... >linux-4.7-rc5/arch/powerpc/platforms/512x/clock-commonclk.c:824]: >(warning) %d in format string (no. 1) requires 'int' but the argument >type is 'size_t {aka unsigned long}'. mpc512x is 32-bit arch, size_t

Pull request: powerpc/mpc5xxx next

2015-11-04 Thread Anatolij Gustschin
Highlights include a driver for MPC512x LocalPlus Bus FIFO with its device tree binding documentation, mpc512x device tree updates and some minor fixes. These patches have already been queued for linux-next for a while. The following changes since commit

Re: [PATCH] powerpc: Introduce the use of the managed version of kzalloc

2015-10-22 Thread Anatolij Gustschin
On Tue, 27 May 2014 01:51:31 +0530 Himangi Saraogi wrote: ... > > Signed-off-by: Himangi Saraogi > Acked-by: Julia Lawall > --- > Not compile tested > arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 6 ++ > 1 file changed, 2

Re: [PATCH] powerpc: mpc512x: drop bogus and unused psc register bit definitions

2015-10-22 Thread Anatolij Gustschin
On Tue, 21 Jul 2015 09:21:13 +0200 Uwe Kleine-König wrote: > These were introduced in commit 25ae3a0739c6 ("[POWERPC] mpc512x: Add > MPC512x PSC support to MPC52xx psc driver") and never used. Moreover > according to the datasheet[1] MEMERROR is bit 25 (0x40) and

Re: [PATCH v4 2/2] powerpc/512x: add a device tree binding for LocalPlus Bus FIFO

2015-10-22 Thread Anatolij Gustschin
On Mon, 12 Oct 2015 00:08:02 +0300 Alexander Popov wrote: > Add a device tree binding for Freescale MPC512x LocalPlus Bus FIFO and > introduce the document describing that binding. > > Signed-off-by: Alexander Popov > --- >

Re: [PATCH v4 1/2] powerpc/512x: add LocalPlus Bus FIFO device driver

2015-10-22 Thread Anatolij Gustschin
On Mon, 12 Oct 2015 00:08:01 +0300 Alexander Popov wrote: > This driver for Freescale MPC512x LocalPlus Bus FIFO (called SCLPC > in the Reference Manual) allows Direct Memory Access transfers > between RAM and peripheral devices on LocalPlus Bus. > > Signed-off-by:

Re: [RESEND PATCH 1/2] powerpc: platforms: mpc52xx_lpbfifo: Fix module autoload for OF platform driver

2015-10-22 Thread Anatolij Gustschin
On Tue, 20 Oct 2015 16:04:12 +0100 Luis de Bethencourt wrote: > From: Luis de Bethencourt > > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by:

Re: Please pull 'next' branch of 5xxx tree

2014-01-29 Thread Anatolij Gustschin
Hi Ben ! On Wed, 29 Jan 2014 18:46:09 +1100 Benjamin Herrenschmidt b...@kernel.crashing.org wrote: ... Hrm, I get a merge conflicts with spi-mpc512x-psc.c, please check that I fixed it up properly in powerpc-next and let me know. your fix is correct. Thanks, Anatolij

Re: Please pull 'next' branch of 5xxx tree

2014-01-27 Thread Anatolij Gustschin
Hi Ben ! On Wed, 15 Jan 2014 22:18:59 +0100 Anatolij Gustschin ag...@denx.de wrote: Hi Ben ! please pull mpc5xxx patches for v3.14: Ping. Switch mpc512x to the common clock framework and adapt mpc512x drivers to use the new clock driver. Old PPC_CLOCK code is removed entirely since

Re: Pull request: scottwood/linux.git

2014-01-27 Thread Anatolij Gustschin
Hi Ben ! On Fri, 17 Jan 2014 19:22:36 -0600 Scott Wood scottw...@freescale.com wrote: This contains a fix for a chroma_defconfig build break that was introduced by e6500 tablewalk support, and a device tree binding patch that missed the previous pull request due to some last-minute polishing.

Re: Please pull 'next' branch of 5xxx tree

2014-01-27 Thread Anatolij Gustschin
On Tue, 28 Jan 2014 17:00:14 +1100 Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Tue, 2014-01-28 at 06:46 +0100, Anatolij Gustschin wrote: Hi Ben ! On Wed, 15 Jan 2014 22:18:59 +0100 Anatolij Gustschin ag...@denx.de wrote: Hi Ben ! please pull mpc5xxx patches

Please pull 'next' branch of 5xxx tree

2014-01-15 Thread Anatolij Gustschin
Hi Ben ! please pull mpc5xxx patches for v3.14: Switch mpc512x to the common clock framework and adapt mpc512x drivers to use the new clock driver. Old PPC_CLOCK code is removed entirely since there are no users any more. All these patches have been in linux-next for more then two weeks now.

Please pull 'merge' branch of 5xxx tree

2013-12-28 Thread Anatolij Gustschin
Hi Ben ! Please pull two DTS fixes for MPC5125 tower board. Without them the v3.13-rcX kernels do not boot. Thanks, Anatolij The following changes since commit 803c2d2f84da9dc2619449994af34d27148ab20d: powerpc/powernv: Fix OPAL LPC access in Little Endian (2013-12-13 15:55:15 +1100) are

Re: [PATCH v2] powerpc/512x: dts: disable MPC5125 usb module

2013-12-20 Thread Anatolij Gustschin
On Fri, 20 Dec 2013 10:16:22 +0100 Matteo Facchinetti matteo.facchine...@sirius-es.it wrote: At the moment the USB controller's pin muxing is not setup correctly and causes a kernel panic upon system startup, so disable the USB1 device tree node in the MPC5125 tower board dts file. The USB

Re: [PATCH v1 0/4] powerpc/512x: update COMMON_CLK support for MPC5125

2013-12-18 Thread Anatolij Gustschin
On Tue, 10 Dec 2013 14:11:33 +0100 Gerhard Sittig g...@denx.de wrote: ... Gerhard Sittig (4): powerpc/512x: clk: minor comment updates powerpc/512x: clk: enforce even SDHC divider values powerpc/512x: clk: support MPC5121/5123/5125 SoC variants powerpc/512x: dts: add MPC5125 clock

Re: [PATCH v1 1/1] powerpc/512x: dts: remove misplaced IRQ spec from 'soc' node (5125)

2013-12-18 Thread Anatolij Gustschin
and resolution of 'interrupts' specs for peripherals gets misled (tries to use the 'soc' as the interrupt parent which fails), emits 'no irq domain found' WARN() messages and breaks the boot process [ best viewed with 'git diff -U5' to have DT node names in the context ] Cc: Anatolij Gustschin ag

[PATCH] powerpc/52xx: re-enable bestcomm driver in defconfigs

2013-12-09 Thread Anatolij Gustschin
The bestcomm driver has been moved to drivers/dma, so to select this driver by default additionally CONFIG_DMADEVICES has to be enabled. Currently it is not enabled in the config despite existing CONFIG_PPC_BESTCOMM=y in the config files. Fix it. Signed-off-by: Anatolij Gustschin ag...@denx.de

Please pull 'merge' branch of 5xxx tree

2013-12-09 Thread Anatolij Gustschin
Hi Ben ! Please pull a device tree fix for v3.13. The booting on mpc512x is broken since v3.13-rc1, this patch repairs it. Thanks, Anatolij The following changes since commit 721cb59e9d95eb7f47ec73711ed35ef85e1ea1ca: powerpc/windfarm: Fix XServe G5 fan control Makefile issue (2013-11-27

Re: [PATCH v6 02/17] dts: mpc512x: introduce dt-bindings/clock/ header

2013-12-07 Thread Anatolij Gustschin
On Sat, 30 Nov 2013 23:51:22 +0100 Gerhard Sittig g...@denx.de wrote: introduce a dt-bindings/ header file for MPC512x clocks, providing symbolic identifiers for those SoC clocks which clients will reference from their device tree nodes Cc: Rob Herring rob.herr...@calxeda.com Cc: Pawel

Re: [PATCH v6 03/17] dts: mpc512x: add clock related device tree specs

2013-12-07 Thread Anatolij Gustschin
On Sat, 30 Nov 2013 23:51:23 +0100 Gerhard Sittig g...@denx.de wrote: this addresses the clock driver aka provider's side of clocks - introduce a 'clocks' subtree with an 'osc' node for the crystal or oscillator SoC input (fixed frequency) - the 'clock@f00' clock-control-module node

Re: [PATCH v6 04/17] clk: mpc512x: introduce COMMON_CLK for MPC512x (disabled)

2013-12-07 Thread Anatolij Gustschin
lack an oscillator node (backwards compat), the REF clock is then derived from the IPS bus frequency and multiplier values fetched from hardware Cc: Mike Turquette mturque...@linaro.org Cc: Anatolij Gustschin ag...@denx.de Cc: linux-arm-ker...@lists.infradead.org Cc: linuxppc-dev

Re: [PATCH v6 05/17] clk: mpc512x: add backwards compat to the CCF code

2013-12-07 Thread Anatolij Gustschin
On Sat, 30 Nov 2013 23:51:25 +0100 Gerhard Sittig g...@denx.de wrote: extend the recently added COMMON_CLK platform support for MPC512x such that it works with incomplete device tree data which lacks clock specs Cc: Mike Turquette mturque...@linaro.org Cc: Anatolij Gustschin ag...@denx.de

Re: [PATCH v6 06/17] dts: mpc512x: add clock specs for client lookups

2013-12-07 Thread Anatolij Gustschin
On Sat, 30 Nov 2013 23:51:26 +0100 Gerhard Sittig g...@denx.de wrote: this addresses the client side of device tree based clock lookups add clock specifiers to the mbx, nfc, mscan, sdhc, i2c, axe, diu, viu, mdio, fec, usb, pata, psc, psc fifo, and pci nodes in the shared mpc5121.dtsi

Re: [PATCH v6 07/17] clk: mpc5xxx: switch to COMMON_CLK, retire PPC_CLOCK

2013-12-07 Thread Anatolij Gustschin
such that multiplatform kernels (the combination of 512x and 52xx within one executable) keep working Cc: Mike Turquette mturque...@linaro.org Cc: Anatolij Gustschin ag...@denx.de Cc: linux-arm-ker...@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Gerhard Sittig g...@denx.de

Re: [PATCH v6 08/17] spi: mpc512x: adjust to OF based clock lookup

2013-12-07 Thread Anatolij Gustschin
On Sat, 30 Nov 2013 23:51:28 +0100 Gerhard Sittig g...@denx.de wrote: after device tree based clock lookup became available, the peripheral driver need no longer construct clock names which include the PSC index, remove the psc%d_mclk template and unconditionally use 'mclk' acquire and

Re: [PATCH v6 09/17] serial: mpc512x: adjust for OF based clock lookup

2013-12-07 Thread Anatolij Gustschin
On Sat, 30 Nov 2013 23:51:29 +0100 Gerhard Sittig g...@denx.de wrote: after device tree based clock lookup became available, the peripheral driver need no longer construct clock names which include the PSC index, remove the psc%d_mclk template and unconditionally use 'mclk' acquire and

Re: [PATCH v6 10/17] serial: mpc512x: setup the PSC FIFO clock as well

2013-12-07 Thread Anatolij Gustschin
On Sat, 30 Nov 2013 23:51:30 +0100 Gerhard Sittig g...@denx.de wrote: prepare and enable the FIFO clock upon PSC FIFO initialization, check for and propagage errors when enabling the PSC FIFO clock, disable and unprepare the FIFO clock upon PSC FIFO uninitialization devm_{get,put}_clk()

Re: [PATCH v6 11/17] USB: fsl-mph-dr-of: adjust for OF based clock lookup

2013-12-07 Thread Anatolij Gustschin
On Sat, 30 Nov 2013 23:51:31 +0100 Gerhard Sittig g...@denx.de wrote: after device tree based clock lookup became available, the peripheral driver need no longer construct clock names which include the component index -- remove the usb%d_clk template, always use ipg instead Cc: Greg

Re: [PATCH v6 12/17] mtd: mpc5121_nfc: adjust for OF based clock lookup

2013-12-07 Thread Anatolij Gustschin
On Sat, 30 Nov 2013 23:51:32 +0100 Gerhard Sittig g...@denx.de wrote: after device tree based clock lookup became available, the NAND flash driver need no longer use the previous global nfc_clk name, but should use the ipg clock name specific to the OF node Cc: David Woodhouse

Re: [PATCH v6 13/17] [media] fsl-viu: adjust for OF based clock lookup

2013-12-07 Thread Anatolij Gustschin
On Sat, 30 Nov 2013 23:51:33 +0100 Gerhard Sittig g...@denx.de wrote: after device tree based clock lookup became available, the VIU driver need no longer use the previous global viu_clk name, but should use the ipg clock name specific to the OF node Cc: Mauro Carvalho Chehab

Re: [PATCH v6 14/17] net: can: mscan: adjust to common clock support for mpc512x

2013-12-07 Thread Anatolij Gustschin
On Sat, 30 Nov 2013 23:51:34 +0100 Gerhard Sittig g...@denx.de wrote: implement a .get_clock() callback for the MPC512x platform which uses the common clock infrastructure (eliminating direct access to the clock control registers from within the CAN network driver), and provide the

Re: [PATCH v6 15/17] net: can: mscan: remove non-CCF code for MPC512x

2013-12-07 Thread Anatolij Gustschin
On Sat, 30 Nov 2013 23:51:35 +0100 Gerhard Sittig g...@denx.de wrote: transition to the common clock framework has completed and the PPC_CLOCK is no longer available for the MPC512x platform, remove the now obsolete code path of the mpc5xxx mscan driver which accessed clock control module

Re: [PATCH v6 16/17] powerpc/mpc512x: improve DIU related clock setup

2013-12-07 Thread Anatolij Gustschin
for successful operation in the presence of an outdated device tree which lacks clock specs Cc: Anatolij Gustschin ag...@denx.de Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/platforms/512x/mpc512x_shared.c | 169 ++ 1 file

Re: [PATCH v6 17/17] clk: mpc512x: remove migration support workarounds

2013-12-07 Thread Anatolij Gustschin
initialized, thus the clock provider isn't available then Cc: Mike Turquette mturque...@linaro.org Cc: Anatolij Gustschin ag...@denx.de Cc: linux-arm-ker...@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/platforms/512x/clock

Re: [PATCH v1 1/1] powerpc/512x: dts: remove misplaced IRQ spec from 'soc' node

2013-12-03 Thread Anatolij Gustschin
@8000 ! mpc5121-rtc 8a00.rtc: mpc5121_rtc_probe: could not request irq: 0 mpc5121-rtc: probe of 8a00.rtc failed with error -22 ... [ best viewed with 'git diff -U5' to have DT node names in the context ] Cc: Anatolij Gustschin ag...@denx.de Cc: linuxppc-dev@lists.ozlabs.org

Re: [PATCH v2] powerpc/gpio: Fix the wrong GPIO input data on MPC8572/MPC8536

2013-11-29 Thread Anatolij Gustschin
-data) mpc8xxx_gpio2mask(gpio); + val = in_be32(mm-regs + GPIO_DAT) ~out_mask; + out_shadow = mpc8xxx_gc-data out_mask; + + return (val | out_shadow) mpc8xxx_gpio2mask(gpio); } static int mpc8xxx_gpio_get(struct gpio_chip *gc, unsigned int gpio) Acked-by: Anatolij Gustschin

Re: [PATCH] powerpc/gpio: Fix the wrong GPIO input data on MPC8572/MPC8536

2013-11-19 Thread Anatolij Gustschin
On Fri, 15 Nov 2013 15:16:29 +0800 Liu Gang gang@freescale.com wrote: For MPC8572/MPC8536, the status of GPIOs defined as output cannot be determined by reading GPDAT register, so the code use shadow data register instead. But if the input pins are asserted high, they will always read

Re: Problem reading and programming memory location...

2013-11-19 Thread Anatolij Gustschin
Hi Lorenzo, On Tue, 19 Nov 2013 11:20:24 +0100 neorf3k neor...@gmail.com wrote: Hello Anatolij, this is our code, used at University, but again it doesn’t work… How i told, the only information we have about that reg are: Chip select 4 specification: Lp_cs4 bus size: 8 bit bus

Re: Problem reading and programming memory location...

2013-11-16 Thread Anatolij Gustschin
Hi Lorenzo, see my comments below. On Fri, 15 Nov 2013 17:27:30 +0100 neorf3k neor...@gmail.com wrote: Hello again, I’ve tried this code, but we are not able to change cs4 reg value… what could be? — #define MALab_DEVICE_NAME MALab #define MPC5xxx_MM_CS4_START (MBAR_BASE + 0x0024)

Re: Problem reading and programming memory location...

2013-11-13 Thread Anatolij Gustschin
On Wed, 13 Nov 2013 14:48:24 +0100 neorf3k neor...@gmail.com wrote: Yes, that is a device on the lpb via an fpga. We have tried to configure the chip select 4 configuration register at address MBAR + 0x0310, and it seems to be ok. what do you mean with “chip select parameters”? I meant the

Re: Problem reading and programming memory location...

2013-11-12 Thread Anatolij Gustschin
On Tue, 12 Nov 2013 20:23:20 +0100 neorf3k neor...@gmail.com wrote: we have tried to read and program an 8bit register with 32bit address. we have mapped it with: ioremap, kmalloc etc… and then using: outb, iowrite8 etc.. but when we write to it, the value doesn’t change… with other memory

Please pull 'next' branch of 5xxx tree

2013-11-03 Thread Anatolij Gustschin
changes up to 7e198197ec878c720af4dc35c49c0c6a99b83f9f: powerpc/mpc512x: remove unnecessary #if (2013-10-30 22:56:10 +0100) Anatolij Gustschin (1): powerpc/52xx: fix build breakage for MPC5200 LPBFIFO module Brian Norris (1

Re: [PATCH RFC v5 1/5] dma: mpc512x: reorder mpc8308 specific instructions

2013-11-01 Thread Anatolij Gustschin
a13xp0p0...@gmail.com --- drivers/dma/mpc512x_dma.c | 42 +- 1 file changed, 25 insertions(+), 17 deletions(-) Acked-by: Anatolij Gustschin ag...@denx.de diff --git a/drivers/dma/mpc512x_dma.c b/drivers/dma/mpc512x_dma.c index 2fe4353..f41639f 100644

Re: [PATCH v2] powerpc/mpc512x: remove unnecessary #if

2013-10-30 Thread Anatolij Gustschin
On Fri, 11 Oct 2013 10:37:38 -0700 Brian Norris computersforpe...@gmail.com wrote: Several functions are only ever referenced locally, so make them static. Of those functions, many of them are protected by an #if. However, the code which can compile fine in either case. Now that (1) the

[PATCH] powerpc/52xx: fix build breakage for MPC5200 LPBFIFO module

2013-10-16 Thread Anatolij Gustschin
The MPC5200 LPBFIFO driver requires the bestcomm module to be enabled, otherwise building will fail. Fix it. Cc: sta...@vger.kernel.org # 3.10+ Reported-by: Wolfgang Denk w...@denx.de Signed-off-by: Anatolij Gustschin ag...@denx.de --- arch/powerpc/platforms/52xx/Kconfig | 2 +- 1 file changed

Re: [v1] powerpc/mpc512x: silence build warning upon disabled DIU

2013-10-10 Thread Anatolij Gustschin
Hi, On Wed, 9 Oct 2013 12:29:31 -0700 Brian Norris computersforpe...@gmail.com wrote: ... +#else +void __init mpc512x_setup_diu(void) { /* EMPTY */ } +void __init mpc512x_init_diu(void) { /* EMPTY */ } #endif void __init mpc512x_init_IRQ(void) I see an alternative solution:

Re: [v1] powerpc/mpc512x: silence build warning upon disabled DIU

2013-10-10 Thread Anatolij Gustschin
Hello, On Thu, 10 Oct 2013 11:23:55 -0700 Brian Norris computersforpe...@gmail.com wrote: ... making mpc512x_setup_diu(), mpc512x_release_bootmem(), mpc512x_valid_monitor_port() and void mpc512x_set_pixel_clock() should be okay. And mpc512x_init_diu()? yes, it can be static, too.

Re: [PATCH v1] powerpc/mpc512x: silence build warning upon disabled DIU

2013-10-08 Thread Anatolij Gustschin
On Fri, 27 Sep 2013 17:28:38 +0200 Gerhard Sittig g...@denx.de wrote: a disabled Kconfig option results in a reference to a not implemented routine when the IS_ENABLED() macro is used for both conditional implementation of the routine as well as a C language source code test at the call site

Re: [PATCH] Kind of revert powerpc: 52xx: provide a default in mpc52xx_irqhost_map()

2013-10-08 Thread Anatolij Gustschin
the printout) needs revert, too. We want to know WHICH critical irq failed, not which level it had. Signed-off-by: Wolfram Sang w...@the-dreams.de Cc: Sebastian Andrzej Siewior bige...@linutronix.de Cc: Anatolij Gustschin ag...@denx.de applied, thanks

Re: Please pull 'next' branch of 5xxx tree

2013-09-09 Thread Anatolij Gustschin
On Thu, 05 Sep 2013 16:50:48 +1000 Benjamin Herrenschmidt b...@kernel.crashing.org wrote: ... Thanks. BTW. Next time, any chance you can base this off the same point in Linus tree where my next branch is based ? Or base of my next branch :-) Okay, I will base of your next branch. Thanks,

Please pull 'next' branch of 5xxx tree

2013-09-03 Thread Anatolij Gustschin
Hi Ben ! Please pull mpc5xxx patches for v3.12. There are cleanups for some mpc5121 specific drivers and DTS files in preparation to switch mpc5121 clock support to a clock driver based on common clock framework. Additionally Sebastian fixed the mpc52xx PIC driver so that it builds when using

Re: [PATCH v4 04/31] mtd: mpc5121_nfc: cleanup clock API use

2013-08-23 Thread Anatolij Gustschin
On Tue, 6 Aug 2013 22:43:44 +0200 Gerhard Sittig g...@denx.de wrote: use devm_clk_get() for automatic put after device close, check for and propagate errors when enabling clocks, need to prepare clocks before they can get enabled, adjust error code paths to correctly balance get/put and

Re: [PATCH v4 05/31] [media] fsl-viu: cleanup clock API use

2013-08-23 Thread Anatolij Gustschin
On Tue, 6 Aug 2013 22:43:45 +0200 Gerhard Sittig g...@denx.de wrote: use devm_clk_get() for automatic put after device close, check for and propagate errors when enabling clocks, need to prepare clocks before they can get enabled, adjust code paths to correctly balance get/put and

Re: [PATCH v4 12/31] powerpc: mpc512x: array decl for MCLK registers in CCM

2013-08-23 Thread Anatolij Gustschin
On Tue, 6 Aug 2013 22:43:52 +0200 Gerhard Sittig g...@denx.de wrote: reword the clock control module's registers declaration such that the MCLK related registers form an array and get indexed by PSC controller or CAN controller component number this change is in preparation to COMMON_CLK

Re: [PATCH v3 13/31] clk: wrap I/O access for improved portability

2013-08-23 Thread Anatolij Gustschin
On Fri, 02 Aug 2013 15:30:00 -0700 Mike Turquette mturque...@linaro.org wrote: Quoting Gerhard Sittig (2013-07-22 05:14:40) the common clock drivers were motivated/initiated by ARM development and apparently assume little endian peripherals wrap register/peripherals access in the common

Re: [PATCH v4 14/31] dts: mpc512x: prepare for preprocessor support

2013-08-23 Thread Anatolij Gustschin
On Tue, 6 Aug 2013 22:43:54 +0200 Gerhard Sittig g...@denx.de wrote: prepare C preprocessor support when processing MPC512x DTS files - switch from DTS syntax to CPP syntax for include specs - create a symlink such that DTS processing can reference includes Signed-off-by: Gerhard Sittig

Re: [PATCH v4 01/31] spi: mpc512x: cleanup clock API use

2013-08-21 Thread Anatolij Gustschin
On Tue, 6 Aug 2013 22:43:41 +0200 Gerhard Sittig g...@denx.de wrote: cleanup the MPC512x SoC's SPI master's use of the clock API - get, prepare, and enable the MCLK during probe; disable, unprepare and put the MCLK upon remove; hold a reference to the clock over the period of use -

Re: [PATCH v4 02/31] serial: mpc512x: cleanup clock API use

2013-08-21 Thread Anatolij Gustschin
On Tue, 6 Aug 2013 22:43:42 +0200 Gerhard Sittig g...@denx.de wrote: cleanup the clock API use of the UART driver which is shared among the MPC512x and the MPC5200 platforms - get, prepare, and enable the MCLK during port allocation; disable, unprepare and put the MCLK upon port release;

Re: [PATCH v4 01/31] spi: mpc512x: cleanup clock API use

2013-08-21 Thread Anatolij Gustschin
On Wed, 21 Aug 2013 20:48:17 +0100 Mark Brown broo...@kernel.org wrote: On Wed, Aug 21, 2013 at 09:22:58PM +0200, Anatolij Gustschin wrote: Mark, are you going to apply this patch? Or should I queue it in my mpc5xxx tree (I'd like to get your Acked-by then)? Has this series settled down

Re: [PATCH v4 03/31] USB: fsl-mph-dr-of: cleanup clock API use

2013-08-21 Thread Anatolij Gustschin
On Tue, 6 Aug 2013 22:43:43 +0200 Gerhard Sittig g...@denx.de wrote: use devm_get_clk() for automatic put upon device close, check for and propagate errors when enabling clocks, must prepare clocks before they can get enabled, unprepare after disable Signed-off-by: Gerhard Sittig

Re: [PATCH] powerpc: 52xx: provide a default in mpc52xx_irqhost_map()

2013-08-12 Thread Anatolij Gustschin
On Mon, 12 Aug 2013 16:17:53 +0200 Sebastian Andrzej Siewior bige...@linutronix.de wrote: My gcc-4.3.5 fails to compile due to: |cc1: warnings being treated as errors |arch/powerpc/platforms/52xx/mpc52xx_pic.c: In function ‘mpc52xx_irqhost_map’:

Re: [PATCH v4 09/31] powerpc/fsl-pci: improve clock API use

2013-08-08 Thread Anatolij Gustschin
On Tue, 6 Aug 2013 22:43:49 +0200 Gerhard Sittig g...@denx.de wrote: ... diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c index 46ac1dd..549ff08 100644 --- a/arch/powerpc/sysdev/fsl_pci.c +++ b/arch/powerpc/sysdev/fsl_pci.c ... + clk = devm_clk_get(pdev-dev,

Re: Failure to detect PCI card

2013-08-06 Thread Anatolij Gustschin
On Mon, 5 Aug 2013 16:14:29 -0700 Peter LaDow pet...@gocougs.wsu.edu wrote: ... Perhaps it is a BIOS option ROM like you suggested earlier. The 3c90xC reference manual I found (http://people.freebsd.org/~wpaul/3Com/3c90xc.pdf) mentions an option ROM (and there is an Atmel part stuffed). I

Re: Failure to detect PCI card

2013-08-05 Thread Anatolij Gustschin
On Mon, 5 Aug 2013 10:58:01 -0700 Peter LaDow pet...@gocougs.wsu.edu wrote: I have a PCI card (a Netgear FA331, vendor:device 100b:0020) that is failing to be detected by our PPC platform. This device works just fine in a PC, and other cards work just fine in the same PCI slot (we have an

Re: Please pull 'next' branch of 5xxx tree

2013-07-02 Thread Anatolij Gustschin
On Tue, 02 Jul 2013 17:46:01 +1000 Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Tue, 2013-07-02 at 00:36 +0200, Anatolij Gustschin wrote: Hi Ben ! Please pull mpc5xxx patches for v3.11. There are small cleanups and fixes for mpc512x common code, mpc512x_defconfig updates

Re: Please pull 'next' branch of 5xxx tree

2013-07-02 Thread Anatolij Gustschin
On Tue, 02 Jul 2013 20:29:02 +1000 Benjamin Herrenschmidt b...@kernel.crashing.org wrote: ... The server should be up, a recent test pull succeeded here. Could you please try again? Just a fluke indeed, works now. Pulled pushed. Thanks! Cheers, Anatolij

Re: [PATCH] powerpc/mpc512x: update defconfig

2013-07-01 Thread Anatolij Gustschin
On Sun, 30 Jun 2013 18:23:00 +0200 Gerhard Sittig g...@denx.de wrote: ... In hindsight, I'd prefer to reword the subject to something more specific, unless it's too late for this now. I suggest: [PATCH] powerpc/mpc512x: commit re-generated defconfig But if the patch is already queued

Please pull 'next' branch of 5xxx tree

2013-07-01 Thread Anatolij Gustschin
) Anatolij Gustschin (1): powerpc/mpc512x: enable USB support in defconfig Gerhard Sittig (3): powerpc/mpc512x: move common code to shared.c file powerpc/mpc512x: initialize board restart earlier powerpc/mpc512x: commit re-generated

[PATCH] powerpc/mpc512x: update defconfig

2013-06-25 Thread Anatolij Gustschin
From: Gerhard Sittig g...@denx.de This patch does not change the content, it merely re-orders configuration items and drops explicit options which already apply as the default. Signed-off-by: Gerhard Sittig g...@denx.de Signed-off-by: Anatolij Gustschin ag...@denx.de --- arch/powerpc/configs

[PATCH] powerpc/mpc512x: enable USB support in defconfig

2013-06-25 Thread Anatolij Gustschin
Enable USB EHCI, mass storage and USB gadget support. Signed-off-by: Anatolij Gustschin ag...@denx.de --- arch/powerpc/configs/mpc512x_defconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/powerpc/configs/mpc512x_defconfig b/arch/powerpc/configs/mpc512x_defconfig index

Re: [PATCH v2 1/2] serial/mpc52xx_uart: prepare for adding MPC5125 PSC UART support

2013-05-24 Thread Anatolij Gustschin
On Wed, 17 Apr 2013 23:21:41 +0200 Anatolij Gustschin ag...@denx.de wrote: From: Matteo Facchinetti matteo.facchine...@sirius-es.it MPC5125 PSC controller has different register layout than MPC5121. To support MPC5125 PSC in this driver we have to provide further psc_ops functions for SoC

[PATCH RESEND v2 1/2] serial/mpc52xx_uart: prepare for adding MPC5125 PSC UART support

2013-05-24 Thread Anatolij Gustschin
Signed-off-by: Matteo Facchinetti matteo.facchine...@sirius-es.it Signed-off-by: Anatolij Gustschin ag...@denx.de --- Changes in v2: - split into two patches to simplify review - minor coding style changes - revise commit log drivers/tty/serial/mpc52xx_uart.c | 161

[PATCH RESEND v2 2/2] serial/mpc52xx_uart: add MPC5125 PSC support

2013-05-24 Thread Anatolij Gustschin
-by: Anatolij Gustschin ag...@denx.de --- Changes in v2: - split into two patches to simplify review - minor coding style changes - revise commit log arch/powerpc/include/asm/mpc52xx_psc.h | 49 +++ drivers/tty/serial/mpc52xx_uart.c | 241 2 files

Re: [PATCH v1 0/2] powerpc/mpc512x: improve common platform code

2013-05-21 Thread Anatolij Gustschin
Hi Gerhard, On Tue, 14 May 2013 16:40:52 +0200 Gerhard Sittig g...@denx.de wrote: ... Gerhard Sittig (2): powerpc/mpc512x: move common code to the shared.c file powerpc/mpc512x: initialize board restart earlier Applied both patches for -next. Thanks! Anatolij

Re: [PATCH 1/1] powerpc: mpc512x_dma: add support for data transfers between memory and i/o memory

2013-05-03 Thread Anatolij Gustschin
On Fri, 3 May 2013 10:28:02 +0400 Alexander Popov a13xp0p0...@gmail.com wrote: Hello Vinod, Thanks for the review. I will return with improved and tested version 2. Note that there is a patch for .device_prep_slave_sg() operation for this driver as part of this series:

Re: [PATCH 1/1] powerpc: mpc512x_dma: add support for data transfers between memory and i/o memory

2013-05-03 Thread Anatolij Gustschin
Hello Alexander, On Fri, 3 May 2013 14:43:23 +0400 Alexander Popov a13xp0p0...@gmail.com wrote: Hello Anatolij, Note that there is a patch for .device_prep_slave_sg() operation for this driver as part of this series: https://patchwork.kernel.org/patch/2368581/

Please pull 'next' branch of 5xxx tree

2013-04-29 Thread Anatolij Gustschin
:48:44 +0200) Anatolij Gustschin (2): powerpc/mpc512x: create SoC devices for more nodes powerpc/512x: add ifm ac14xx board Matteo Facchinetti (2): powerpc/512x: move mpc5121_generic platform to mpc512x_generic

Re: [PATCH 1/1] usb: ehci-fsl: set INCR8 mode only on MPC512x

2013-04-23 Thread Anatolij Gustschin
On Wed, 24 Apr 2013 10:55:10 +0800 Tiejun Chen tiejun.c...@windriver.com wrote: commit 761bbcb7, usb: ehci-fsl: set INCR8 mode for system bus interface on MPC512x, introduced to fix one MPC5121e (M36P) Errata by setting INCR8 mode for system bus interface on MPC512x, but we should make sure

[PATCH v2 2/2] serial/mpc52xx_uart: add MPC5125 PSC support

2013-04-17 Thread Anatolij Gustschin
-by: Anatolij Gustschin ag...@denx.de --- Changes in v2: - split into two patches to simplify review - minor coding style changes - revise commit log arch/powerpc/include/asm/mpc52xx_psc.h | 49 +++ drivers/tty/serial/mpc52xx_uart.c | 241 2 files

[PATCH v2 1/2] serial/mpc52xx_uart: prepare for adding MPC5125 PSC UART support

2013-04-17 Thread Anatolij Gustschin
Signed-off-by: Matteo Facchinetti matteo.facchine...@sirius-es.it Signed-off-by: Anatolij Gustschin ag...@denx.de --- Greg, with your Acked-by I can push these patches to my mpc5xxx tree. But it is fine with me if you prefer to apply them to tty tree. Thanks, Anatolij Changes in v2: - split

Re: [PATCH 2/3] serial/mpc52xx_uart: add PSC UART support for MPC5125 platforms.

2013-04-17 Thread Anatolij Gustschin
On Wed, 20 Mar 2013 18:41:53 +0100 Matteo Facchinetti matteo.facchine...@sirius-es.it wrote: MPC5125 PSC controller has different registers than MPC5121. This patch was originally created by Vladimir Ermakov https://lists.ozlabs.org/pipermail/linuxppc-dev/2011-March/088954.html

  1   2   3   4   >