Re: [PATCH] powerpc/fsl_booke/32: fix build with CONFIG_RANDOMIZE_BASE

2020-06-13 Thread Arseny Solokha
> Le 13/06/2020 à 18:28, Arseny Solokha a écrit : >> Building the current 5.8 kernel for a e500 machine with >> CONFIG_RANDOMIZE_BASE set yields the following failure: >> >>arch/powerpc/mm/nohash/kaslr_booke.c: In function 'kaslr_early_init': >>arch/powe

[PATCH] powerpc/fsl_booke/32: fix build with CONFIG_RANDOMIZE_BASE

2020-06-13 Thread Arseny Solokha
: 2b0e86cc5de6 ("powerpc/fsl_booke/32: implement KASLR infrastructure") Cc: sta...@vger.kernel.org Signed-off-by: Arseny Solokha --- arch/powerpc/mm/nohash/kaslr_booke.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/mm/nohash/kaslr_booke.c b/arch/powerpc/mm/nohash/kas

Re: [PATCH] powerpc: Wire up clone3 syscall

2019-07-23 Thread Arseny Solokha
Hi, may I also ask to provide ppc_clone3 symbol also for 32-bit powerpc? Otherwise Michael's patch breaks build for me: powerpc-e500v2-linux-gnuspe-ld: arch/powerpc/kernel/systbl.o: in function `sys_call_table': (.rodata+0x6cc): undefined reference to `ppc_clone3' make: ***

[PATCH v4 2/4] kvm/ppc/mpic: drop unused IRQ_testbit

2015-03-21 Thread Arseny Solokha
) makes use of it. v2: Added a brief explanation to each patch description of why removed functions are unused, as suggested by Michael Ellerman. Signed-off-by: Arseny Solokha asolo...@kb.kras.ru --- arch/powerpc/kvm/mpic.c | 5 - 1 file changed, 5 deletions(-) diff --git a/arch

Re: [PATCH v3 0/4] powerpc: trivial unused functions cleanup

2015-03-21 Thread Arseny Solokha
On Fri, 2015-03-20 at 11:55 +0700, Arseny Solokha wrote: And by the way, while revisiting the series I've noticed that though the patch 4/4 basically reverts [1], it leaves #define MPIC_GREG_GLOBAL_CONF_10x00030 in arch/powerpc/include/asm/mpic.h untouched. That define

[PATCH 2/4] kvm/ppc/mpic: drop unused IRQ_testbit

2015-03-19 Thread Arseny Solokha
Drop unused static procedure which doesn't have callers within its translation unit. It had been already removed independently in QEMU[1] from the OpenPIC implementation borrowed from the kernel. [1] https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg01812.html Signed-off-by: Arseny

[PATCH 1/4] powerpc/boot: drop planetcore_set_serial_speed

2015-03-19 Thread Arseny Solokha
Drop planetcore_set_serial_speed() which had no users since its inception in commit fec6047047fd ([POWERPC] bootwrapper: Add PlanetCore firmware support) in 2007. Signed-off-by: Arseny Solokha asolo...@kb.kras.ru --- arch/powerpc/boot/planetcore.c | 33 - arch

[PATCH 4/4] powerpc/mpic: remove unused functions

2015-03-19 Thread Arseny Solokha
/023867.html Signed-off-by: Arseny Solokha asolo...@kb.kras.ru Cc: Jia Hongtao hongtao@freescale.com --- arch/powerpc/include/asm/mpic.h | 11 --- arch/powerpc/sysdev/mpic.c | 25 - 2 files changed, 36 deletions(-) diff --git a/arch/powerpc/include/asm/mpic.h

[PATCH 3/4] powrepc/qe: drop unused ucc_slow_poll_transmitter_now

2015-03-19 Thread Arseny Solokha
Drop ucc_slow_poll_transmitter_now() which has no users since its inception in 2007 in commit 986585385131 ([POWERPC] Add QUICC Engine (QE) infrastructure). Signed-off-by: Arseny Solokha asolo...@kb.kras.ru --- arch/powerpc/include/asm/ucc_slow.h | 13 - arch/powerpc/sysdev/qe_lib

[PATCH v3 0/4] powerpc: trivial unused functions cleanup

2015-03-19 Thread Arseny Solokha
with MSI hardware errata) makes use of it. v2: Added a brief explanation to each patch description of why removed functions are unused, as suggested by Michael Ellerman. Arseny Solokha (4): powerpc/boot: drop planetcore_set_serial_speed kvm/ppc/mpic: drop unused IRQ_testbit powrepc

Re: [PATCH v3 0/4] powerpc: trivial unused functions cleanup

2015-03-19 Thread Arseny Solokha
On Fri, 2015-03-20 at 10:56 +0700, Arseny Solokha wrote: This series removes unused functions from powerpc tree that I've been able to discover. Two machines at hands, e300 and e500 based, boot and run without regressions on my workload with this series applied. The removed code seems also

Re: [PATCH 4/4] powerpc/mpic: remove unused functions

2015-02-26 Thread Arseny Solokha
@@ -1676,31 +1666,6 @@ void __init mpic_init(struct mpic *mpic) mpic_err_int_init(mpic, MPIC_FSL_ERR_INT); } -void __init mpic_set_clk_ratio(struct mpic *mpic, u32 clock_ratio) -{ - u32 v; - - v = mpic_read(mpic-gregs, MPIC_GREG_GLOBAL_CONF_1); - v =

[PATCH 1/4] powerpc/boot: drop planetcore_set_serial_speed

2015-02-24 Thread Arseny Solokha
Drop planetcore_set_serial_speed() which had no users since its inception in commit fec6047047fd ([POWERPC] bootwrapper: Add PlanetCore firmware support) in 2007. Signed-off-by: Arseny Solokha asolo...@kb.kras.ru --- arch/powerpc/boot/planetcore.c | 33 - arch

[PATCH 4/4] powerpc/mpic: remove unused functions

2015-02-24 Thread Arseny Solokha
exported. [1] https://lists.ozlabs.org/pipermail/linuxppc-dev/2006-June/023867.html Signed-off-by: Arseny Solokha asolo...@kb.kras.ru Cc: hongtao@freescale.com --- arch/powerpc/include/asm/mpic.h | 20 arch/powerpc/sysdev/mpic.c | 35

[PATCH 2/4] kvm/ppc/mpic: drop unused IRQ_testbit

2015-02-24 Thread Arseny Solokha
Drop unused static procedure which doesn't have callers within its translation unit. It had been already removed independently in QEMU[1] from the OpenPIC implementation borrowed from the kernel. [1] https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg01812.html Signed-off-by: Arseny

[PATCH 3/4] powrepc/qe: drop unused ucc_slow_poll_transmitter_now

2015-02-24 Thread Arseny Solokha
Drop ucc_slow_poll_transmitter_now() which has no users since its inception in 2007 in commit 986585385131 ([POWERPC] Add QUICC Engine (QE) infrastructure). Signed-off-by: Arseny Solokha asolo...@kb.kras.ru --- arch/powerpc/include/asm/ucc_slow.h | 13 - arch/powerpc/sysdev/qe_lib

[PATCH V2 0/4] powerpc: trivial unused functions cleanup

2015-02-24 Thread Arseny Solokha
in general. But I can't obviously express any strong point in support of the series, so it's completely OK to leave things as is. Arseny Solokha (4): powerpc/boot: drop planetcore_set_serial_speed kvm/ppc/mpic: drop unused IRQ_testbit powrepc/qe: drop unused ucc_slow_poll_transmitter_now

Re: [PATCH 4/4] powerpc/mpic: remove unused functions

2015-02-19 Thread Arseny Solokha
On Mon, 2015-02-16 at 17:56 +0700, Arseny Solokha wrote: Drop unused fsl_mpic_primary_get_version(), mpic_set_clk_ratio(), mpic_set_serial_int(). I'm always happy to remove unused code, but the interesting question is why are they unused? Please tell me in the changelog. To being able

Re: [PATCH 4/4] powerpc/mpic: remove unused functions

2015-02-19 Thread Arseny Solokha
If I just get a patch saying removed unused foo(), I have to go and dig and find out: - was it recently added and will be used soon? - is it ancient and never used, if so can we work out why, ie. feature X never landed so this code is no longer needed. - is it old code that *was*

[PATCH 0/4] powerpc: trivial unused functions cleanup

2015-02-16 Thread Arseny Solokha
This series removes unused functions from powerpc tree that I've been able to discover. Arseny Solokha (4): powerpc/boot: drop planetcore_set_serial_speed kvm/ppc/mpic: drop unused IRQ_testbit powrepc/qe: drop unused ucc_slow_poll_transmitter_now powerpc/mpic: remove unused functions

[PATCH 1/4] powerpc/boot: drop planetcore_set_serial_speed

2015-02-16 Thread Arseny Solokha
Drop planetcore_set_serial_speed() which had no users since its inception. Signed-off-by: Arseny Solokha asolo...@kb.kras.ru --- arch/powerpc/boot/planetcore.c | 33 - arch/powerpc/boot/planetcore.h | 3 --- 2 files changed, 36 deletions(-) diff --git a/arch

[PATCH 2/4] kvm/ppc/mpic: drop unused IRQ_testbit

2015-02-16 Thread Arseny Solokha
Drop unused static procedure which doesn't have callers within its translation unit. Signed-off-by: Arseny Solokha asolo...@kb.kras.ru Cc: Alexander Graf ag...@suse.de Cc: Gleb Natapov g...@kernel.org Cc: Paolo Bonzini pbonz...@redhat.com --- arch/powerpc/kvm/mpic.c | 5 - 1 file changed, 5

[PATCH 3/4] powrepc/qe: drop unused ucc_slow_poll_transmitter_now

2015-02-16 Thread Arseny Solokha
Drop ucc_slow_poll_transmitter_now() which has no users. Signed-off-by: Arseny Solokha asolo...@kb.kras.ru --- arch/powerpc/include/asm/ucc_slow.h | 13 - arch/powerpc/sysdev/qe_lib/ucc_slow.c | 5 - 2 files changed, 18 deletions(-) diff --git a/arch/powerpc/include/asm

[PATCH 4/4] powerpc/mpic: remove unused functions

2015-02-16 Thread Arseny Solokha
Drop unused fsl_mpic_primary_get_version(), mpic_set_clk_ratio(), mpic_set_serial_int(). Signed-off-by: Arseny Solokha asolo...@kb.kras.ru --- arch/powerpc/include/asm/mpic.h | 16 arch/powerpc/sysdev/mpic.c | 35 --- 2 files changed, 51

Re: [PATCH] powerpc/mm: bail out early when flushing TLB page

2015-02-01 Thread Arseny Solokha
On Fri, 2015-01-30 at 19:08 +0700, Arseny Solokha wrote: MMU_NO_CONTEXT is conditionally defined as 0 or (unsigned int)-1. However, in __flush_tlb_page() a corresponding variable is only tested for open coded 0, which can cause NULL pointer dereference if `mm' argument was legitimately passed

[PATCH] powerpc/mm: warn on flushing tlb page in kernel context

2015-02-01 Thread Arseny Solokha
Function __flush_tlb_page() must only be called for user contexts, so put in extra hardening to warn on calling it for kernel context. Signed-off-by: Arseny Solokha asolo...@kb.kras.ru --- arch/powerpc/mm/tlb_nohash.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] powerpc/mm: bail out early when flushing TLB page

2015-01-30 Thread Arseny Solokha
On Fri, 2015-01-30 at 19:08 +0700, Arseny Solokha wrote: MMU_NO_CONTEXT is conditionally defined as 0 or (unsigned int)-1. For nohash it is specifically -1. However, in __flush_tlb_page() a corresponding variable is only tested for open coded 0, which can cause NULL pointer dereference

[PATCH] powerpc/mm: bail out early when flushing TLB page

2015-01-30 Thread Arseny Solokha
, thus eliminate confusion between different values of MMU_NO_CONTEXT and avoid disabling and then re-enabling preemption unnecessarily. Signed-off-by: Arseny Solokha asolo...@kb.kras.ru --- arch/powerpc/mm/tlb_nohash.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch