e is much
> harder, and you easily make some mistakes here.
Hi Segher
Thanks for checking the patch and sharing review comments.
Ok, I am checking on this part.
>
> On Sat, Mar 09, 2024 at 12:55:12PM +0530, Athira Rajeev wrote:
>> To identify if the instruction has any memory refe
> On 09-Mar-2024, at 3:18 PM, Christophe Leroy
> wrote:
>
>
>
> Le 09/03/2024 à 08:25, Athira Rajeev a écrit :
>> Add powerpc instruction nmemonic table to associate load/store
>> instructions with move_ops. mov_ops is used to identify mem_type
>> to
> On 09-Mar-2024, at 3:24 PM, Christophe Leroy
> wrote:
>
>
>
> Le 09/03/2024 à 08:25, Athira Rajeev a écrit :
>> The function get_dwarf_regnum() returns a DWARF register number
>> from a register name string. This calls arch specific function
>> get_a
-off-by: Athira Rajeev
---
tools/perf/arch/powerpc/util/dwarf-regs.c | 29 +++
1 file changed, 29 insertions(+)
diff --git a/tools/perf/arch/powerpc/util/dwarf-regs.c
b/tools/perf/arch/powerpc/util/dwarf-regs.c
index 0c4f4caf53ac..d955e3e577ea 100644
--- a/tools/perf/arch
s offset from the given instruction,
arch->objdump.register_char is used. In case of powerpc, the register
char is "r" (since reg names are r0 to r31). Hence set register_char
as "r".
Signed-off-by: Athira Rajeev
---
tools/perf/util/annotate.c | 5 +
1 file changed,
.
Signed-off-by: Athira Rajeev
---
.../perf/arch/powerpc/annotate/instructions.c | 66 +++
1 file changed, 66 insertions(+)
diff --git a/tools/perf/arch/powerpc/annotate/instructions.c
b/tools/perf/arch/powerpc/annotate/instructions.c
index a3f423c27cae..07af4442be38 100644
.20% 0.00% struct sched_entity +0 (load.weight)
0.18% 0.00% struct cfs_rq
0.18% 0.00% struct cfs_rq +96 (curr)
Thanks
Athira
Athira Rajeev (3):
tools/perf/arch/powerpc: Add load/store in powerpc annotate
instructions for data type profling
tools/erf/util/anno
Hi All,
Please ignore this version. I made mistake in cover letter. I am re-posting the
correct version now.
Sorry for the confusion
Thanks
Athira
> On 09-Mar-2024, at 11:21 AM, Athira Rajeev
> wrote:
>
> Add powerpc instruction nmemonic table to associate load/store
&g
-off-by: Athira Rajeev
---
tools/perf/arch/powerpc/util/dwarf-regs.c | 29 +++
1 file changed, 29 insertions(+)
diff --git a/tools/perf/arch/powerpc/util/dwarf-regs.c
b/tools/perf/arch/powerpc/util/dwarf-regs.c
index 0c4f4caf53ac..d955e3e577ea 100644
--- a/tools/perf/arch
s offset from the given instruction,
arch->objdump.register_char is used. In case of powerpc, the register
char is "r" (since reg names are r0 to r31). Hence set register_char
as "r".
Signed-off-by: Athira Rajeev
---
tools/perf/util/annotate.c | 5 +
1 file changed,
.
Signed-off-by: Athira Rajeev
---
.../perf/arch/powerpc/annotate/instructions.c | 66 +++
1 file changed, 66 insertions(+)
diff --git a/tools/perf/arch/powerpc/annotate/instructions.c
b/tools/perf/arch/powerpc/annotate/instructions.c
index a3f423c27cae..07af4442be38 100644
struct sched_entity
0.20% 0.00% struct sched_entity +0 (load.weight)
0.18% 0.00% struct cfs_rq
0.18% 0.00% struct cfs_rq +96 (curr)
Thanks
Athira
Athira Rajeev (3):
tools/perf/arch/powerpc: Add load/store in powerpc annotate
instructions for data ty
> On 06-Dec-2023, at 3:20 AM, Arnaldo Carvalho de Melo wrote:
>
> Em Mon, Nov 27, 2023 at 11:12:57AM +, James Clark escreveu:
>> On 23/11/2023 16:02, Athira Rajeev wrote:
>>> --- a/tools/perf/Makefile.perf
>>> @@ -1134,6 +1152,7 @@ bpf-skel-clean:
>&
ers escreveu:
>>>> On Thu, Nov 23, 2023 at 8:01 AM Athira Rajeev
>>>> wrote:
>>>>>
>>>>> Running "perf list" on powerpc fails with segfault
>>>>> as below:
>>>>>
>>>>> ./perf list
>
> On 05-Dec-2023, at 1:42 AM, Ian Rogers wrote:
>
> On Thu, Nov 23, 2023 at 8:01 AM Athira Rajeev
> wrote:
>>
>> Running "perf list" on powerpc fails with segfault
>> as below:
>>
>> ./perf list
>> Segmentation fault (co
> On 29-Nov-2023, at 10:51 AM, Athira Rajeev
> wrote:
>
>
>
>> On 27-Nov-2023, at 5:32 PM, Disha Goel wrote:
>>
>> On 23/11/23 9:31 pm, Athira Rajeev wrote:
>>
>>> Running "perf list" on powerpc fails with segfault
>>&
> On 27-Nov-2023, at 5:32 PM, Disha Goel wrote:
>
> On 23/11/23 9:31 pm, Athira Rajeev wrote:
>
>> Running "perf list" on powerpc fails with segfault
>> as below:
>>
>>./perf list
>>Segmentation fault (core dumped)
>>
&g
caps/power10/libc.so.6)"
> test child finished with -1
> end
> probe libc's inet_pton & backtrace it with ping: FAILED!
Reviewed-by: Athira Rajeev
Thanks
Athira
>
> This test installs a probe on libc's inet_pton function, which will use
> uprobes and then use
> On 27-Nov-2023, at 8:21 PM, Arnaldo Carvalho de Melo wrote:
>
> Em Mon, Nov 27, 2023 at 11:12:57AM +, James Clark escreveu:
>> On 23/11/2023 16:02, Athira Rajeev wrote:
>>> Add rule in new Makefile "tests/Makefile.tests" for running
>>> shell
approach "shell command -v" is not
used here. In some of the distros(RHEL), command is available
as executable file (/usr/bin/command). But in some distros(SLES),
it is a shell builtin and not available as executable file.
Signed-off-by: Athira Rajeev
---
changelog:
v3 -> v4:
Addressed
M_DATA_FROM_L2MISS_DSRC and
PM_DATA_FROM_L3MISS_DSRC events. With the fix, perf list
works as expected.
Fixes: fc1435807533 ("perf vendor events power10: Update JSON/events")
Signed-off-by: Athira Rajeev
---
.../arch/powerpc/power10/datasource.json | 18 ++
1 file changed, 14 insertio
> On 23-Oct-2023, at 4:14 PM, James Clark wrote:
>
>
>
> On 13/10/2023 08:36, Athira Rajeev wrote:
>> Add rule in new Makefile "tests/Makefile.tests" for running
>> shellcheck on shell test scripts. This automates below shellcheck
>> into the
> On 07-Nov-2023, at 3:14 AM, Arnaldo Carvalho de Melo wrote:
>
> Em Thu, Oct 05, 2023 at 02:24:15PM +0530, Athira Rajeev escreveu:
>>> On 05-Oct-2023, at 1:50 PM, James Clark wrote:
>>> On 29/09/2023 05:11, Athira Rajeev wrote:
>>>> Running shellche
> On 13-Oct-2023, at 1:06 PM, Athira Rajeev wrote:
>
> Add rule in new Makefile "tests/Makefile.tests" for running
> shellcheck on shell test scripts. This automates below shellcheck
> into the build.
>
> $ for F in $(find tests/shell/ -perm -o=x -name '*.sh');
til/perf-in.o
LD perf-in.o
LINKperf
Signed-off-by: Athira Rajeev
---
changelog:
v2 -> v3:
Add option "NO_SHELLCHECK". This will allow to go ahead
with the build or disable shellcheck even though it is
known that some test is broken
v1 -> v2:
Version1 had shellcheck
/git/acme/linux.git
The version 1 patchset had fix patch for test_arm_coresight.sh.
Dropping that in V2 based on discussion here:
https://lore.kernel.org/linux-perf-users/f265857d-0d37-4878-908c-d20732f21...@linux.vnet.ibm.com/T/#u
Athira Rajeev (3):
tools/perf/tests Ignore the shellcheck SC2046
se
'{ cmd > file; } 2>&1' to clarify).
This shows shellcheck warning SC2069 where the redirection
order needs to be fixed. Use "cmd > /dev/null 2>&1" to fix
the redirection of perf record output
Fixes: 23b97c7ee963 ("perf test: Add test case for record side
;perf test lock_contention.sh: Skip test if not enough
CPUs")
Signed-off-by: Athira Rajeev
Reviewed-by: Kajol Jain
---
changelog:
v1 -> v2:
Add Reviewed-by from Kajol Jain
tools/perf/tests/shell/lock_contention.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/tests/s
to declare functions. Fix this by removing the
"function" keyword from ParanoidAndNotRoot function
Signed-off-by: Athira Rajeev
---
Changelog:
This is a new patch added in V2
tools/perf/tests/shell/stat_all_metricgroups.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
> On 12-Oct-2023, at 9:37 PM, Suzuki K Poulose wrote:
>
> Hi,
>
> On 12/10/2023 16:56, Athira Rajeev wrote:
>>> On 05-Oct-2023, at 3:06 PM, Suzuki K Poulose wrote:
>>>
>>> On 05/10/2023 06:02, Namhyung Kim wrote:
>>>> On
> On 05-Oct-2023, at 3:06 PM, Suzuki K Poulose wrote:
>
> On 05/10/2023 06:02, Namhyung Kim wrote:
>> On Thu, Sep 28, 2023 at 9:11 PM Athira Rajeev
>> wrote:
>>>
>>> Running shellcheck on tests/shell/test_arm_coresight.sh
>>> throws
> On 05-Oct-2023, at 9:15 PM, David Laight wrote:
>
> From: David Laight
>> Sent: 05 October 2023 11:16
> ...
>>> - cs_etm_path=$(find /sys/bus/event_source/devices/cs_etm/ -name cpu*
>>> -print -quit)
>>> + cs_etm_path=$(find /sys/bus/event_source/devices/cs_etm/ -name 'cpu*'
>>> -print
> On 09-Oct-2023, at 10:38 AM, Namhyung Kim wrote:
>
> Hello,
>
> Sorry for the late reply.
>
> On Thu, Oct 5, 2023 at 8:27 AM Athira Rajeev
> wrote:
>>
>>
>>
>>> On 29-Sep-2023, at 12:19 PM, Athira Rajeev
>>> wrote:
>>
;
Here cpuid field is used in "perf_pmu__find_events_table"
function as "strcmp_cpuid_str(map->cpuid, cpuid)". The
value for cpuid field is picked from mapfile.csv.
Fix the mapfile.csv and get_cpuid_str function to prefix
cpuid with 0x so that it gets correctly interpre
> On 29-Sep-2023, at 12:19 PM, Athira Rajeev
> wrote:
>
> Add rule in new Makefile "tests/Makefile.tests" for running
> shellcheck on shell test scripts. This automates below shellcheck
> into the build.
>
> $ for F in $(find tests/shell/ -perm -o
> On 05-Oct-2023, at 1:50 PM, James Clark wrote:
>
>
>
> On 29/09/2023 05:11, Athira Rajeev wrote:
>> Running shellcheck on tests/shell/test_arm_coresight.sh
>> throws below warnings:
>>
>> In tests/shell/test_arm_coresight.sh line 15:
>> cs_e
> On 05-Oct-2023, at 10:34 AM, Namhyung Kim wrote:
>
> On Thu, Sep 28, 2023 at 9:11 PM Athira Rajeev
> wrote:
>>
>> Running shellcheck on record_sideband.sh throws below
>> warning:
>>
>>In tests/shell/record_sideband.sh line 25:
>&
> On 03-Oct-2023, at 9:58 AM, Namhyung Kim wrote:
>
> Hello,
>
> On Thu, Sep 28, 2023 at 12:52 AM Athira Rajeev
> wrote:
>>
>> Update "struct dso" to include new member "text_end".
>> This new field will represent the offset f
> On 28-Sep-2023, at 9:24 AM, Namhyung Kim wrote:
>
> On Tue, Sep 26, 2023 at 9:29 PM Athira Rajeev
> wrote:
>>
>>
>>
>>> On 25-Sep-2023, at 1:34 PM, kajoljain wrote:
>>>
>>>
>>>
>>> On 9/7/23 22:45, Athir
> On 30-Sep-2023, at 11:23 AM, Namhyung Kim wrote:
>
> On Wed, Sep 27, 2023 at 11:17 AM Athira Rajeev
> wrote:
>>
>> Testcase "Parsing of all PMU events from sysfs" parse events for
>> all PMUs, and not just cpu. In case of powerpc, the PowerVM
>
ao
Signed-off-by: Naveen N Rao
Signed-off-by: Athira Rajeev
---
arch/powerpc/platforms/pseries/hvCall.S | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/pseries/hvCall.S
b/arch/powerpc/platforms/pseries/hvCall.S
index bae45b358a09..2addf2ea03f0 100644
--- a/ar
In the plpar_hcall trace code, currently we use r0
to store the ORed result of r4. But this value is not
used subsequently in the code. Hence remove this unused
save to r0 in plpar_hcall and plpar_hcall9
Suggested-by: Naveen N Rao
Signed-off-by: Athira Rajeev
---
arch/powerpc/platforms/pseries
RM) $(OUTPUT).config-detected
diff --git a/tools/perf/tests/Makefile.tests b/tools/perf/tests/Makefile.tests
new file mode 100644
index ..8011e99768a3
--- /dev/null
+++ b/tools/perf/tests/Makefile.tests
@@ -0,0 +1,24 @@
+# SPDX-License-Identifier: GPL-2.0
+# Athira Rajeev , 2023
+
+PROGS =
> On 27-Sep-2023, at 8:25 PM, Athira Rajeev wrote:
>
>
>
>> On 27-Sep-2023, at 5:45 AM, Namhyung Kim wrote:
>>
>> On Thu, Sep 14, 2023 at 10:40 PM Athira Rajeev
>> wrote:
>>>
>>> The testcase "Object code reading&q
> On 27-Sep-2023, at 9:55 AM, Athira Rajeev wrote:
>
>
>
>> On 27-Sep-2023, at 5:25 AM, Namhyung Kim wrote:
>>
>> On Thu, Sep 14, 2023 at 10:18 AM Athira Rajeev
>> wrote:
>>>
>>> Add rule in new Makefile "tests/Makef
se
'{ cmd > file; } 2>&1' to clarify).
This shows shellcheck warning SC2069 where the redirection
order needs to be fixed. Use { cmd > file; } 2>&1 to fix the
redirection of perf record output
Fixes: 23b97c7ee963 ("perf test: Add test case for record sideband events"
;perf test lock_contention.sh: Skip test if not enough
CPUs")
Signed-off-by: Athira Rajeev
---
tools/perf/tests/shell/lock_contention.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/tests/shell/lock_contention.sh
b/tools/perf/tests/shell/lock_contention.sh
index d5a191d3d0
well defined
This warning is observed after commit:
"commit bb350847965d ("perf test: Update cs_etm testcase for Arm ETE")"
Fixed this issue by using quoting 'cpu*' for SC2061 and
using "&&" in line number 20 for SC2166 warning
Fixes: bb350847965d (&
)
for ock_contention, record_sideband and test_arm_coresight testcases.
The changes are made on top of:
https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/log/?h=perf-tools-next
Athira Rajeev (3):
perf tests test_arm_coresight: Fix the shellcheck warning in latest
test_arm_coresight.sh
ot;, exploring an option of
having stubs range as part of the /proc/kallsyms, so that perf
report can resolve addresses in stubs range
However this patch uses text_end to skip the stub range for
Object code reading testcase.
Reported-by: Disha Goel
Signed-off-by: Athira Rajeev
Tested-by: Disha Go
m sample points to stub instructions.
To identify if the DSO is a kernel module, the new field
"is_kmod" is added to "struct dso".
Reported-by: Disha Goel
Signed-off-by: Athira Rajeev
---
Changelog:
v5:
This patch adds is_kmod field to dso to detect if
the dso is a kerne
falls out of text
section and within module end, added the new field "text_end" to
"struct dso".
Reported-by: Disha Goel
Signed-off-by: Athira Rajeev
Reviewed-by: Adrian Hunter
Reviewed-by: Kajol Jain
---
Changelog:
v2 -> v3:
Added Reviewed-by from Adrian
v1 ->
mialr instance with
"all PMU test".
Fix parse-events test to skip parametrized events since
it needs proper setup of the parameters.
Signed-off-by: Athira Rajeev
Tested-by: Ian Rogers
Tested-by: Sachin Sant
Reviewed-by: Kajol Jain
---
Changelog:
v2 -> v3:
Addressed review comment
> On 27-Sep-2023, at 5:45 AM, Namhyung Kim wrote:
>
> On Thu, Sep 14, 2023 at 10:40 PM Athira Rajeev
> wrote:
>>
>> The testcase "Object code reading" fails in somecases
>> for "fs_something" sub test as below:
>>
>>Reading
> On 27-Sep-2023, at 4:07 AM, Namhyung Kim wrote:
>
> Hello,
>
> On Mon, Sep 25, 2023 at 10:37 AM Arnaldo Carvalho de Melo
> wrote:
>>
>>
>>
>> On Wed, Sep 13, 2023, 7:40 AM Athira Rajeev
>> wrote:
>>>
>>>
> On 25-Sep-2023, at 1:34 PM, kajoljain wrote:
>
>
>
> On 9/7/23 22:45, Athira Rajeev wrote:
>> From: root
>>
>> shellcheck was run on perf tool shell scripts s a pre-requisite
>> to include a build option for shellcheck discussed here:
>> h
> On 27-Sep-2023, at 5:25 AM, Namhyung Kim wrote:
>
> On Thu, Sep 14, 2023 at 10:18 AM Athira Rajeev
> wrote:
>>
>> Add rule in new Makefile "tests/Makefile.tests" for running
>> shellcheck on shell test scripts. This automates below shellcheck
> On 27-Sep-2023, at 5:21 AM, Namhyung Kim wrote:
>
> Hello,
>
> On Thu, Sep 14, 2023 at 10:18 AM Athira Rajeev
> wrote:
>>
>> shellcheck tool can detect coding/formatting issues on
>> shell scripts. In perf directory "tests/shell", there are
> On 18-Sep-2023, at 7:42 PM, Reza Arbab wrote:
>
> On Thu, Sep 14, 2023 at 10:02:04PM +0530, Athira Rajeev wrote:
>> Add a function dt_find_by_name_before_addr() that returns the child node if
>> it matches till first occurrence at "@" of a given name, oth
> On 15-Sep-2023, at 8:00 PM, Reza Arbab wrote:
>
> Hi Athira,
>
> On Thu, Sep 14, 2023 at 10:02:04PM +0530, Athira Rajeev wrote:
>> +struct dt_node *dt_find_by_name_before_addr(struct dt_node *root, const
>> char *name)
>> +{
>> + struct dt_nod
> On 15-Sep-2023, at 10:56 AM, Adrian Hunter wrote:
>
> On 15/09/23 08:24, Athira Rajeev wrote:
>> The testcase "Object code reading" fails in somecases
>> for "fs_something" sub test as below:
>>
>>Reading object code for memory ad
falls out of text
section and within module end, added the new field "text_end" to
"struct dso".
Reported-by: Disha Goel
Signed-off-by: Athira Rajeev
Reviewed-by: Adrian Hunter
---
Changelog:
v2 -> v3:
Added Reviewed-by from Adrian
v1 -> v2:
Added text_end for bfd a
ot;, exploring an option of
having stubs range as part of the /proc/kallsyms, so that perf
report can resolve addresses in stubs range
However this patch uses text_end to skip the stub range for
Object code reading testcase.
Reported-by: Disha Goel
Signed-off-by: Athira Rajeev
Tested-by: Disha Goe
ot;, exploring an option of
having stubs range as part of the /proc/kallsyms, so that perf
report can resolve addresses in stubs range
However this patch uses text_end to skip the stub range for
Object code reading testcase.
Reported-by: Disha Goel
Signed-off-by: Athira Rajeev
Tested-by: D
falls out of text
section and within module end, added the new field "text_end" to
"struct dso".
Reported-by: Disha Goel
Signed-off-by: Athira Rajeev
Reviewed-by: Adrian Hunter
---
Changelog:
v2 -> v3:
Added Reviewed-by from Adrian
v1 -> v2:
Added text_end for bfd a
> On 14-Sep-2023, at 11:54 PM, Adrian Hunter wrote:
>
> On 7/09/23 19:45, Athira Rajeev wrote:
>> The testcase "Object code reading" fails in somecases
>> for "fs_something" sub test as below:
>>
>>Reading object code for memory ad
> On 14-Sep-2023, at 11:49 PM, Adrian Hunter wrote:
>
> On 7/09/23 19:45, Athira Rajeev wrote:
>> Update "struct dso" to include new member "text_end".
>> This new field will represent the offset for end of text
>> section for a dso. For
> On 14-Sep-2023, at 5:47 PM, Disha Goel wrote:
>
> On 07/09/23 10:15 pm, Athira Rajeev wrote:
>> The testcase "Object code reading" fails in somecases
>> for "fs_something" sub test as below:
>>
>> Reading object code for memory address:
> On 13-Sep-2023, at 1:06 AM, Arnaldo Carvalho de Melo wrote:
>
> Em Tue, Sep 12, 2023 at 07:00:00AM -0700, Ian Rogers escreveu:
>> On Mon, Sep 11, 2023 at 11:38 PM Athira Rajeev
>> wrote:
>>>
>>> Makefile.perf uses "CONFIG_*" checks in t
;SHLLCHECK_RUN" ensures that, every time during make, shellcheck
will be run only on modified files during subsequent invocations.
By this, if any newly added shell scripts or fixes in existing
scripts breaks coding/formatting style, it will get captured
during the perf build.
Signe
ture check to detect
presence of shellcheck. Add CONFIG_SHELLCHECK feature check in
the build to avoid not having shellcheck breaking the build.
Signed-off-by: Athira Rajeev
---
tools/build/Makefile.feature | 6 --
tools/build/feature/Makefile | 8 +++-
tools/perf/Makefile.config | 10 +++
Patch implements all these change to handle
nest_pmus_p10.
Signed-off-by: Athira Rajeev
---
Changelog:
v5 -> v6:
- Addressed review comment from Reza by using PPC_BIT
instead of PPC_BITMASK
v4 -> v5:
- Addressed review comment from Reza and renamed
dt_find_by_name_substr to dt_find_by_
cted result. Fix this
by using dt_find_by_name_before_addr. Also, update the char array
to use correct node names.
Signed-off-by: Athira Rajeev
---
Changelog:
v4 -> v5:
- Addressed review comment from Reza and renamed
dt_find_by_name_substr to dt_find_by_name_before_addr
v3 -> v4:
- Addressed review commen
rmat and if the
value of "addr" is not known, that node can't be matched with node
name or addr. Hence matching with substring as node name will return
the expected result. Patch adds dt_find_by_name_before_addr() function
and testcase for the same in core/test/run-device.c
Signed-of
> On 08-Sep-2023, at 7:48 PM, Athira Rajeev wrote:
>
>
>
>> On 08-Sep-2023, at 11:04 AM, Sachin Sant wrote:
>>
>>
>>
>>> On 07-Sep-2023, at 10:29 PM, Athira Rajeev
>>> wrote:
>>>
>>> Testcase "Parsing
> On 08-Sep-2023, at 7:47 PM, Athira Rajeev wrote:
>
>
>
>> On 08-Sep-2023, at 5:20 AM, Ian Rogers wrote:
>>
>> On Thu, Sep 7, 2023 at 10:17 AM Athira Rajeev
>> wrote:
>>>
>>> From: root
>>>
>>> shellcheck was
hecks. This will fix isues that
could arise when other "CONFIG_*" checks are added to Makefile.perf
in future as well.
Signed-off-by: Athira Rajeev
---
Changelog:
v2 -> v3:
Added -include since in some cases make clean or make
will fail when config is not included and if config-detect
> On 08-Sep-2023, at 9:45 PM, Ian Rogers wrote:
>
> On Fri, Sep 8, 2023 at 7:51 AM Athira Rajeev
> wrote:
>>
>> Makefile.perf uses "CONFIG_*" checks in the code. Example the config
>> for libtraceevent is used to set PYTHON_EXT_SRCS
>&
> On 10-Aug-2023, at 3:28 AM, Reza Arbab wrote:
>
> On Mon, Jul 17, 2023 at 08:54:31AM +0530, Athira Rajeev wrote:
>> @@ -408,14 +469,129 @@ static void disable_unavailable_units(struct dt_node
>> *dev)
>> avl_vec = (0xffULL) << 56;
>> }
>>
> On 10-Aug-2023, at 3:21 AM, Reza Arbab wrote:
>
> Hi Athira,
>
> I still have a couple of the same questions I asked in v4.
>
> On Mon, Jul 17, 2023 at 08:54:29AM +0530, Athira Rajeev wrote:
>> Add a function dt_find_by_name_before_addr() that returns the child
hecks. This will fix isues that
could arise when other "CONFIG_*" checks are added to Makefile.perf
in future as well.
Signed-off-by: Athira Rajeev
---
Changelog:
v1 -> v2:
Added $(OUTPUT) prefix to config-detected as pointed
out by Ian
tools/perf/Makefile.perf | 3 +++
1 file cha
> On 08-Sep-2023, at 11:04 AM, Sachin Sant wrote:
>
>
>
>> On 07-Sep-2023, at 10:29 PM, Athira Rajeev
>> wrote:
>>
>> Testcase "Parsing of all PMU events from sysfs" parse events for
>> all PMUs, and not just cpu. In case of powe
> On 08-Sep-2023, at 4:41 AM, Ian Rogers wrote:
>
> On Thu, Sep 7, 2023 at 10:19 AM Athira Rajeev
> wrote:
>>
>> Makefile.perf uses "CONFIG_*" checks in the code. Example the config
>> for libtraceevent is used to set PYTHON_EXT_SRCS
>&
> On 08-Sep-2023, at 5:20 AM, Ian Rogers wrote:
>
> On Thu, Sep 7, 2023 at 10:17 AM Athira Rajeev
> wrote:
>>
>> From: root
>>
>> shellcheck was run on perf tool shell scripts s a pre-requisite
>> to include a build option for shellcheck discus
hecks. This will fix isues that
could arise when other "CONFIG_*" checks are added to Makefile.perf
in future as well.
Signed-off-by: Athira Rajeev
---
tools/perf/Makefile.perf | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
in
ests/shell/ -perm -o=x -name '*.sh'); do shellcheck -S
warning $F; done
# echo $?
0
Athira Rajeev (3):
tests/shell: Fix shellcheck SC1090 to handle the location of sourced
files
tests/shell: Fix shellcheck issues in tests/shell/stat+shadow_stat.sh
tetscase
tests/shell: Fix shellchec
Here, DATD is exported from "lib/coresight.sh" and this
warning can be ignored. Use "shellcheck disable=" to ignore
this check.
Signed-off-by: Athira Rajeev
---
tools/perf/tests/shell/coresight/asm_pure_loop.sh| 1 +
tools/perf/tests/shell/coresight/memcpy_thread_16k_10.
is happens on shellcheck version "0.6.0". Fix shellcheck
warning for SC1090 using "shellcheck source="i option to mention
the location of sourced files.
Signed-off-by: Athira Rajeev
---
tools/perf/tests/shell/coresight/asm_pure_loop.sh| 3 +++
tools/perf/tests/shell/cor
it is
needed to parse through the output. commit used "_"
as a prefix for this throw away variable. But this
stil shows warning with shellcheck v0.6. Fix this
by only using "_" instead of prefix and variable name.
Signed-off-by: Athira Rajeev
---
tools/perf/tests/shell/sta
mialr instance with
"all PMU test".
Fix parse-events test to skip parametrized events since
it needs proper setup of the parameters.
Signed-off-by: Athira Rajeev
---
Changelog:
v1 -> v2:
Addressed review comments from Ian. Updated size of
pmu event name variable and changed bool nam
> On 18-Aug-2023, at 12:07 AM, Ian Rogers wrote:
>
> On Sun, Aug 6, 2023 at 9:50 PM Athira Rajeev
> wrote:
>>
>> Testcase "Parsing of all PMU events from sysfs" parse events for
>> all PMUs, and not just cpu. In case of powerpc, the PowerVM
>
falls out of text
section and within module end, added the new field "text_end" to
"struct dso".
Reported-by: Disha Goel
Signed-off-by: Athira Rajeev
---
Changelog:
v1 -> v2:
Added text_end for bfd also by updating dso__load_bfd_symbols
as suggested by Adrian.
tools/pe
ot;, exploring an option of
having stubs range as part of the /proc/kallsyms, so that perf
report can resolve addresses in stubs range
However this patch uses text_end to skip the stub range for
Object code reading testcase.
Reported-by: Disha Goel
Signed-off-by: Athira Rajeev
---
Changelog:
> On 18-Aug-2023, at 12:45 PM, Adrian Hunter wrote:
>
> On 17/08/23 20:18, Athira Rajeev wrote:
>> The testcase "Object code reading" fails in somecases
>> for "fs_something" sub test as below:
>>
>>Reading object code for memory ad
> On 18-Aug-2023, at 12:07 PM, Adrian Hunter wrote:
>
> On 17/08/23 20:18, Athira Rajeev wrote:
>> Update "struct dso" to include new member "text_end".
>> This new field will represent the offset for end of text
>> section for a dso. This v
> On 07-Aug-2023, at 11:07 AM, Sachin Sant wrote:
>
>
>
>> On 07-Aug-2023, at 10:22 AM, Athira Rajeev
>> wrote:
>>
>> The test "BPF prologue generation" fails as below:
>>
>> Writing event: p:perf_bpf_probe/func _text+10423200
> On 07-Aug-2023, at 11:40 AM, Sachin Sant wrote:
>
>
>
>> On 07-Aug-2023, at 10:20 AM, Athira Rajeev
>> wrote:
>>
>> Testcase "Parsing of all PMU events from sysfs" parse events for
>> all PMUs, and not just cpu. In case of powe
ot;, exploring an option of
having stubs range as part of the /proc/kallsyms, so that perf
report can resolve addresses in stubs range
However this patch uses text_end to skip the stub range for
Object code reading testcase.
Reported-by: Disha Goel
Signed-off-by: Athira Rajeev
---
tools/perf/tests/
h is allocated on module load and hence is not part of DSO offset.
To identify such address, which falls out of text
section and within module end, added the new field "text_end" to
"struct dso".
Reported-by: Disha Goel
Signed-off-by: Athira Rajeev
---
Changelog:
v1 -> v2:
ot;, exploring an option of
having stubs range as part of the /proc/kallsyms, so that perf
report can resolve addresses in stubs range
However this patch uses text_end to skip the stub range for
Object code reading testcase.
Signed-off-by: Athira Rajeev
---
tools/perf/tests/code-reading.c | 8 +++
1 - 100 of 700 matches
Mail list logo
