Re: [PATCH 5/5] mtd: powernv_flash: Use opal_async_wait_response_interruptible()

com> > --- > drivers/mtd/devices/powernv_flash.c | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) Seems OK: Acked-by: Brian Norris <computersforpe...@gmail.com>

Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

Hi, On Wed, Jun 29, 2016 at 02:53:03PM +, Raghav Dogra wrote: > > > > -Original Message- > > From: Leo Li [mailto:pku@gmail.com] > > Sent: Saturday, May 28, 2016 3:34 AM 1 month delay? So much for the rush... > > To: Brian Norris <computers

Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

Hi Leo, On Fri, May 27, 2016 at 10:44:01PM +0200, Boris Brezillon wrote: > On Fri, 27 May 2016 15:15:00 -0500 > Leo Li wrote: > > On Wed, May 25, 2016 at 3:34 PM, Boris Brezillon > > wrote: > > > On Wed, 25 May 2016 14:18:43 -0500 > > > Leo

Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

IFC" patch > >> > > >> > Changes for v2: rebased to resolve conflicts > >> > Applicable to git://git.infradead.org/l2-mtd.git > >> > > >> > This patch is dependent on "drivers/memory: Add deep sleep support for > >> &

Re: [PATCH] mtd/ifc: Add support for IFC controller version 2.0

On Thu, Feb 04, 2016 at 05:07:16PM -0600, Li Yang wrote: > On Wed, Feb 3, 2016 at 12:36 AM, Raghav Dogra wrote: > > The new IFC controller version 2.0 has a different memory map page. > > Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB. > > This patch

Re: [PATCH 3/3] mtd/ifc: Segregate IFC fcm and runtime registers

On Mon, Feb 01, 2016 at 01:41:45PM -0600, Li Yang wrote: > On Mon, Feb 1, 2016 at 4:46 AM, Raghav Dogra wrote: > > A general comment is that you should include the linux-mtd mailing > list and it's maintainers for this set of patches. Although the > MAINTAINERS file

[PATCH v2 2/2] cxl: use -Werror only with CONFIG_PPC_WERROR

! (Note that PPC_WERROR defaults to =y, so the common case compile should still be enforcing -Werror.) Fixes: d3d73f4b38a8 ("cxl: Compile with -Werror") Signed-off-by: Brian Norris <computersforpe...@gmail.com> --- v2: new in v2 drivers/misc/cxl/Makefile | 3 ++- 1 file changed, 2

[PATCH v2 1/2] cxl: fix build for GCC 4.6.x

y: Arnd Bergmann <a...@arndb.de> Signed-off-by: Brian Norris <computersforpe...@gmail.com> --- v2: don't remove -Werror drivers/misc/cxl/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/cxl/Makefile b/drivers/misc/cxl/Makefile index 6982f

Re: Build failure: -Wno-unused-const-variable DNE on old GCC

On Fri, Jan 08, 2016 at 09:51:35AM +1100, Daniel Axtens wrote: > > > Alternatively, remove the -Werror. We occasionally get people that add this > > flag to a Makefile, but it tends to cause more trouble whenever a new > > gcc version arrives. ^^ Your reasons below don't really address this

Re: Build failure: -Wno-unused-const-variable DNE on old GCC

On Fri, Jan 08, 2016 at 12:31:54PM +1100, Ian Munsie wrote: > Excerpts from Brian Norris's message of 2016-01-08 10:02:25 +1100: > > > - It forces cxl developers to a higher standard. cxl has already had > > >more than it's fair share of incredibly difficult to debug issues, > > >so any

[PATCH] misc: cxl: fix build for GCC 4.6.x

. Suggested-by: Michal Marek <mma...@suse.com> Signed-off-by: Brian Norris <computersforpe...@gmail.com> --- On Thu, Jan 07, 2016 at 12:18:26PM -0800, Brian Norris wrote: > On Thu, Jan 07, 2016 at 11:57:31AM -0800, Joe Perches wrote: > > On Thu, 2016-01-07 at 20:44 +0100, Michal

Re: [PATCH] mtd: nand: add FSL_SOC dependency to drivers using FSL_LBC

Hi Scott, On Thu, Jan 07, 2016 at 02:40:37PM -0600, Scott Wood wrote: > On Thu, 2016-01-07 at 12:34 -0800, Brian Norris wrote: > > On Thu, Jan 07, 2016 at 01:47:33PM -0600, Scott Wood wrote: > > > On Thu, 2016-01-07 at 11:21 -0800, Brian Norris wrote: > > > > I'v

Re: Build failure: -Wno-unused-const-variable DNE on old GCC

On Thu, Jan 07, 2016 at 11:57:31AM -0800, Joe Perches wrote: > On Thu, 2016-01-07 at 20:44 +0100, Michal Marek wrote: > > Dne 7.1.2016 v 20:37 Joe Perches napsal(a): > > > On Thu, 2016-01-07 at 10:54 -0800, Brian Norris wrote: > > > > I'm using a GCC 4.6.3 compiler

Re: [PATCH] mtd: nand: add FSL_SOC dependency to drivers using FSL_LBC

Hi Scott, On Thu, Jan 07, 2016 at 01:47:33PM -0600, Scott Wood wrote: > On Thu, 2016-01-07 at 11:21 -0800, Brian Norris wrote: > > I've managed to construct .config files (for ppc64) that come across > > this Kconfig warning: > > > > warning: (MPC83

Build failure: -Wno-unused-const-variable DNE on old GCC

Hi, I'm using a GCC 4.6.3 compiler for some compile tests, and I noticed that commit 2cd55c68c0a4 ("cxl: Fix build failure due to -Wunused-variable behaviour change") breaks my builds, because the -Wno-unused-const-variable doesn't exist on GCC 4.6.3. drivers/misc/cxl/base.c: At top level:

[PATCH] mtd: nand: add FSL_SOC dependency to drivers using FSL_LBC

T, they are only supported on PPC32 FSL SoCs anyway. Signed-off-by: Brian Norris <computersforpe...@gmail.com> Cc: Scott Wood <scottw...@freescale.com> --- drivers/mtd/nand/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nan

Re: [PATCH v5 RESEND] IFC: Change IO accessor based on endianness

On Thu, Aug 06, 2015 at 06:24:38PM -0500, Scott Wood wrote: On Thu, 2015-08-06 at 09:52 -0700, Brian Norris wrote: Who takes patches for drivers/memory/ again? I can take it via MTD if no one else steps up. There's no maintainer listed. IIRC, when we previously discussed the patch we

Re: [PATCH v5 RESEND] IFC: Change IO accessor based on endianness

...@freescale.com Signed-off-by: Scott Wood scottw...@freescale.com --- v5: I'm assuming it's the same as v4, but I didn't send v4, and this comes from a versionless [RESEND] that never made it to the mailing list, so bumping the version just in case. Acked-by: Brian Norris computersforpe...@gmail.com Who

Re: [PATCH] drivers/mtd: add powernv flash MTD abstraction driver

Hi Cyril, On Thu, May 21, 2015 at 04:12:52PM +1000, Cyril Bur wrote: One question though, On Wed, 2015-05-20 at 14:17 -0700, Brian Norris wrote: On Mon, May 04, 2015 at 04:42:19PM +1000, Cyril Bur wrote: Powerpc powernv platforms allow access to certain system flash devices through

Re: [PATCH] drivers/mtd: add powernv flash MTD abstraction driver

You might run this through checkpatch, as it caught several small things. On Mon, May 04, 2015 at 04:42:19PM +1000, Cyril Bur wrote: Powerpc powernv platforms allow access to certain system flash devices through a firmwarwe interface. This change adds an mtd driver for these flash devices.

Re: [PATCH 6/8] mtd: replace CONFIG_8xx by CONFIG_PPC_8xx

On Thu, Mar 12, 2015 at 04:24:04PM +0100, Christophe Leroy wrote: Two config options exist to define powerpc MPC8xx: * CONFIG_PPC_8xx * CONFIG_8xx In addition, CONFIG_PPC_8xx also defines CONFIG_CPM1 as communication co-processor arch/powerpc/platforms/Kconfig.cputype has contained the

Re: [PATCH 12/15] mtd: kconfig: replace PPC_OF with PPC

On Sat, Jan 31, 2015 at 09:47:42PM +0800, Kevin Hao wrote: The PPC_OF is a ppc specific option which is used to mean that the firmware device tree access functions are available. Since all the ppc platforms have a device tree, it is aways set to 'y' for ppc. So it makes no sense to keep a such

Re: roundup_pow_of_two() may not handle 64-bit integers

On Thu, May 15, 2014 at 04:03:09PM +0100, David Howells wrote: Brian Norris computersforpe...@gmail.com wrote: I'm looking to use roundup_pow_of_two() (actually, order_base_2()) from linux/log2.h, but it seems that it only supports 64-bit integers if your toolchain uses a 64-bit 'unsigned

roundup_pow_of_two() may not handle 64-bit integers

Hi, I'm looking to use roundup_pow_of_two() (actually, order_base_2()) from linux/log2.h, but it seems that it only supports 64-bit integers if your toolchain uses a 64-bit 'unsigned long' type. This is strange, considering that ilog2() is explicitly designed for 32-bit or 64-bit compatibility.

[PATCH v2 00/12] defconfigs: add MTD_SPI_NOR (new subsystem dependency for M25P80)

on 3.15-rc1. The SPI-NOR development code (in -next, queued for 3.16) is here: git://git.infradead.org/l2-mtd.git +spinor This defconfig series is available in the same repo at: git://git.infradead.org/l2-mtd.git +defconfigs Thanks, Brian Brian Norris (12): ARM: imx/mxs defconfigs: add

[PATCH v2 11/12] powerpc: defconfigs: add MTD_SPI_NOR (new dependency for M25P80)

These defconfigs contain the CONFIG_M25P80 symbol, which is now dependent on the MTD_SPI_NOR symbol. Add CONFIG_MTD_SPI_NOR to satisfy the new dependency. At the same time, drop the now-nonexistent CONFIG_MTD_CHAR symbol. Signed-off-by: Brian Norris computersforpe...@gmail.com Cc: Benjamin

Re: [PATCH 0/5] defconfigs: add MTD_SPI_NOR (dependency for M25P80)

Hi, On Thu, Apr 17, 2014 at 12:53:03PM +0200, Thierry Reding wrote: On Thu, Apr 17, 2014 at 12:21:44AM -0700, Brian Norris wrote: We are introducing a new SPI-NOR library/framework for MTD, to support various types of SPI-NOR flash controllers which require (or benefit from) intimate

[PATCH 0/5] defconfigs: add MTD_SPI_NOR (dependency for M25P80)

done done So I did a mixed approach, where I filtered most of the noise out of the diff. Brian Norris (5): ARM: defconfigs: add MTD_SPI_NOR (new dependency for M25P80) blackfin: defconfigs: add MTD_SPI_NOR (new dependency for M25P80) mips: defconfigs: add MTD_SPI_NOR

[PATCH 4/5] powerpc: defconfigs: add MTD_SPI_NOR (new dependency for M25P80)

These defconfigs contain the CONFIG_M25P80 symbol, which is now dependent on the MTD_SPI_NOR symbol. Add CONFIG_MTD_SPI_NOR to the relevant defconfigs. At the same time, drop the now-nonexistent CONFIG_MTD_CHAR symbol. Signed-off-by: Brian Norris computersforpe...@gmail.com Cc: Benjamin

Re: [PATCH] mtd: m25p80: Modify the name of mtd_info

On Fri, Mar 21, 2014 at 07:16:18PM +0800, Hou Zhiqiang wrote: To specify spi flash layouts by mtdparts=... in cmdline, we must give mtd_info a fixed name,because the cmdlinepart's parser will match the name of mtd_info given in cmdline. Now, if use DT, the mtd_info's name will be spi-dev-name.

Re: [v3] mtd: m25p80: Modify the name of mtd_info

On Sat, Mar 22, 2014 at 1:55 AM, Hou Zhiqiang b48...@freescale.com wrote: v3: Fix a bug, matching unsigned long long with %llx. v2: 1. Fix some code style issue. 2. Cast physical address to unsigned long long. I missed v2 and v3 and commented on v1 instead, sorry.

Re: [PATCH] mtd: m25p80: Make the name of mtd_info fixed

Hi Hou, On Thu, Jan 23, 2014 at 03:29:41AM +, b48...@freescale.com wrote: -Original Message- From: Brian Norris [mailto:computersforpe...@gmail.com] Sent: Thursday, January 23, 2014 10:12 AM To: Hou Zhiqiang-B48286 Cc: linux-...@lists.infradead.org; linuxppc-...@ozlabs.org

Re: [PATCH v2] mtd: m25p80: Make the name of mtd_info fixed

On Sun, Jan 26, 2014 at 02:16:43PM +0800, Hou Zhiqiang wrote: To give spi flash layout using mtdparts=... in cmdline, we must give mtd_info a fixed name,because the cmdlinepart's parser will match the name given in cmdline with the mtd_info. Now, if use OF node, mtd_info's name will be

Re: [PATCH] mtd: m25p80: Make the name of mtd_info fixed

Hi Hou, On Mon, Jan 06, 2014 at 02:34:29PM +0800, Hou Zhiqiang wrote: To give spi flash layout using mtdparts=... in cmdline, we must give mtd_info a fixed name,because the cmdlinepart's parser will match the name given in cmdline with the mtd_info. Now, if use OF node, mtd_info's name will

Re: [PATCH] mtd: m25p80: Add Power Management support

On Wed, Dec 11, 2013 at 04:19:30PM +0800, Hou Zhiqiang wrote: Add PM support using callback function suspend and resume in .driver of spi_driver. Signed-off-by: Hou Zhiqiang b48...@freescale.com --- drivers/mtd/devices/m25p80.c | 37 + 1 file changed,

Re: [PATCH v2] mtd: m25p80: Add Power Management support

On Thu, Dec 12, 2013 at 01:38:36PM +0800, Hou Zhiqiang wrote: Add PM support using callback function suspend and resume in .driver.pm of spi_driver. Signed-off-by: Hou Zhiqiang b48...@freescale.com --- v2: - Replace .driver.suspend and .driver.resume with .driver.pm - Use

[PATCH] powerpc/mpc512x: remove unnecessary #if

(CONFIG_FB_FSL_DIU))', the compiler can automatically remove the unneeded code, and we don't need the #if or the empty stub functions. Signed-off-by: Brian Norris computersforpe...@gmail.com --- Based off of Gerhard Sittig's patch: powerpc/mpc512x: silence build warning upon disabled DIU Compile

Re: [v1] powerpc/mpc512x: silence build warning upon disabled DIU

Hi, On Thu, Oct 10, 2013 at 12:37 PM, Anatolij Gustschin ag...@denx.de wrote: On Thu, 10 Oct 2013 11:23:55 -0700 Brian Norris computersforpe...@gmail.com wrote: Yes, we also have to remove CONFIG_FB_FSL_DIU ifdef in arch/powerpc/sysdev/fsl_soc.h and building should work then. Still want

Re: [PATCH] powerpc/mpc512x: remove unnecessary #if

Hi, I'm sorry, ignore this version. I left out a diff I meant to include. On Fri, Oct 11, 2013 at 10:32 AM, Brian Norris computersforpe...@gmail.com wrote: Several functions are only ever referenced locally, so make them static. Of those functions, many of them are protected by an #if. However

[PATCH v2] powerpc/mpc512x: remove unnecessary #if

(CONFIG_FB_FSL_DIU))', the compiler can automatically remove the unneeded code, and we don't need the #if or the empty stub functions. Signed-off-by: Brian Norris computersforpe...@gmail.com --- v2: left out a diff I was holding locally (to remove an #if/#endif completely). Sorry for the noise

Re: [v1] powerpc/mpc512x: silence build warning upon disabled DIU

Hello, On Thu, Oct 10, 2013 at 9:09 AM, Anatolij Gustschin ag...@denx.de wrote: On Wed, 9 Oct 2013 12:29:31 -0700 Brian Norris computersforpe...@gmail.com wrote: ... +#else +void __init mpc512x_setup_diu(void) { /* EMPTY */ } +void __init mpc512x_init_diu(void) { /* EMPTY */ } #endif

Re: [v1] powerpc/mpc512x: silence build warning upon disabled DIU

Hi all, (Please keep me on the CC list, as I'm not subscribed) On Fri, Sep 27, 2013 at 05:28:38PM +0200, Gerhard Sittig wrote: a disabled Kconfig option results in a reference to a not implemented routine when the IS_ENABLED() macro is used for both conditional implementation of the routine

Re: [upstream] mtd/ifc: fix ifc driver memory release issue

) at all. That's the whole point of the managed allocators (i.e., devm_kzalloc()). Try this patch instead. Totally untested here. From: Brian Norris computersforpe...@gmail.com Date: Thu, 28 Mar 2013 21:20:27 -0700 Subject: [PATCH] mtd: fsl_ifc_nand: remove incorrect kfree() The struct fsl_ifc_mtd

Re: [PATCH] mtd-utils: fix corrupt cleanmarker with flash_erase -j command

On Wed, Aug 17, 2011 at 12:39 AM, Artem Bityutskiy dedeki...@gmail.com wrote: I think the OOB mode should not be a global MTD device state. Each ioctl invocation should just specify the mode. I agree. This brings up some questions, though. See below. Brian's idea of having a completely new

Re: [PATCH] mtd-utils: fix corrupt cleanmarker with flash_erase -j command

On Tue, Aug 16, 2011 at 8:06 AM, Artem Bityutskiy dedeki...@gmail.com wrote: On Wed, 2011-08-03 at 13:50 +0800, b35...@freescale.com wrote: From: Liu Shuo b35...@freescale.com Flash_erase -j should fill discrete freeoob areas with required bytes of JFFS2 cleanmarker in