Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-06-02 Thread Chen Yuanquan-B41889
On 06/01/2013 09:58 PM, Guenter Roeck wrote: On Fri, May 31, 2013 at 03:44:07PM +1000, Benjamin Herrenschmidt wrote: On Thu, 2013-05-30 at 22:14 -0700, Guenter Roeck wrote: On Wed, May 29, 2013 at 05:30:41PM +0800, Chen Yuanquan-B41889 wrote: On 05/29/2013 01:35 AM, Guenter Roeck wrote

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-05-29 Thread Chen Yuanquan-B41889
On 05/29/2013 01:35 AM, Guenter Roeck wrote: bios_add_device(). Drop explicit calls to pcibios_setup_device(); this makes pcibios_setup_bus_devices() a noop function which could eve Yeah, it's more reasonable to do the irq and DMA related initialization in one code path for all devices.

Re: [PATCH] powerpc/pci: fix PCI-e devices rescan issue on powerpc platform

2013-04-23 Thread Chen Yuanquan-B41889
On 04/10/2013 05:08 PM, Chen Yuanquan-B41889 wrote: On 04/03/2013 12:08 PM, Chen Yuanquan-B41889 wrote: On 04/02/2013 11:10 PM, Benjamin Herrenschmidt wrote: On Tue, 2013-04-02 at 19:26 +0800, Yuanquan Chen wrote: So we move the DMA IRQ initialization code from pcibios_setup_devices

Re: [PATCH] powerpc/pci: fix PCI-e devices rescan issue on powerpc platform

2013-04-23 Thread Chen Yuanquan-B41889
On 04/23/2013 06:05 PM, Benjamin Herrenschmidt wrote: On Tue, 2013-04-23 at 17:26 +0800, Chen Yuanquan-B41889 wrote: There's no response from Ben. How do you think about this patch? What's your advice? Didn't Michael put your patch in -next while I was on vacation ? I'll check tomorrow

Re: [PATCH] powerpc/pci: fix PCI-e devices rescan issue on powerpc platform

2013-04-10 Thread Chen Yuanquan-B41889
On 04/03/2013 12:08 PM, Chen Yuanquan-B41889 wrote: On 04/02/2013 11:10 PM, Benjamin Herrenschmidt wrote: On Tue, 2013-04-02 at 19:26 +0800, Yuanquan Chen wrote: So we move the DMA IRQ initialization code from pcibios_setup_devices() and construct a new function pcibios_enable_device. We call

Re: [PATCH] powerpc/pci: fix PCI-e devices rescan issue on powerpc platform

2013-04-02 Thread Chen Yuanquan-B41889
On 04/02/2013 11:10 PM, Benjamin Herrenschmidt wrote: On Tue, 2013-04-02 at 19:26 +0800, Yuanquan Chen wrote: So we move the DMA IRQ initialization code from pcibios_setup_devices() and construct a new function pcibios_enable_device. We call this function in pcibios_enable_device, which will

Re: [linuxppc-release][PATCH] powerpc/pci-hotplug: fix init issue of rescanned pci device

2013-04-01 Thread Chen Yuanquan-B41889
On 12/08/2012 05:15 AM, Bjorn Helgaas wrote: On Thu, Dec 6, 2012 at 4:23 AM, Chen Yuanquan-B41889 b41...@freescale.com wrote: On 12/06/2012 05:30 AM, Bjorn Helgaas wrote: On Wed, Dec 5, 2012 at 2:29 AM, Chen Yuanquan-B41889 b41...@freescale.com wrote: On 12/05/2012 04:26 PM, Benjamin

[PATCH] Make PCIe hotplug work with Freescale PCIe controllers

2013-03-12 Thread Chen Yuanquan-B41889
-Original Message- From: Linuxppc-dev [mailto:linuxppc-dev-bounces+tie- fei.zang=freescale@lists.ozlabs.org] On Behalf Of Rojhalat Ibrahim Sent: Tuesday, March 12, 2013 5:23 PM To: Kumar Gala Cc: linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] Make PCIe hotplug work with

Re: [PATCH] Make PCIe hotplug work with Freescale PCIe controllers

2013-03-12 Thread Chen Yuanquan-B41889
On 03/12/2013 06:30 PM, Rojhalat Ibrahim wrote: On Tuesday 12 March 2013 18:12:20 Chen Yuanquan-B41889 wrote: -Original Message- From: Linuxppc-dev [mailto:linuxppc-dev-bounces+tie- fei.zang=freescale@lists.ozlabs.org] On Behalf Of Rojhalat Ibrahim Sent: Tuesday, March 12, 2013 5:23

Re: [linuxppc-release][PATCH] powerpc/pci-hotplug: fix init issue of rescanned pci device

2012-12-06 Thread Chen Yuanquan-B41889
On 12/06/2012 05:30 AM, Bjorn Helgaas wrote: On Wed, Dec 5, 2012 at 2:29 AM, Chen Yuanquan-B41889 b41...@freescale.com wrote: On 12/05/2012 04:26 PM, Benjamin Herrenschmidt wrote: On Wed, 2012-12-05 at 16:20 +0800, Chen Yuanquan-B41889 wrote: On 12/05/2012 03:17 PM, Benjamin Herrenschmidt

Re: [linuxppc-release][PATCH] powerpc/pci-hotplug: fix init issue of rescanned pci device

2012-12-05 Thread Chen Yuanquan-B41889
On 12/05/2012 03:17 PM, Benjamin Herrenschmidt wrote: On Wed, 2012-12-05 at 10:31 +0800, Yuanquan Chen wrote: On powerpc arch, some fixup work of PCI/PCI-e device is just done during the first scan at booting time. For the PCI/PCI-e device rescanned after linux OS booting up, the fixup work

Re: [linuxppc-release][PATCH] powerpc/pci-hotplug: fix init issue of rescanned pci device

2012-12-05 Thread Chen Yuanquan-B41889
On 12/05/2012 04:26 PM, Benjamin Herrenschmidt wrote: On Wed, 2012-12-05 at 16:20 +0800, Chen Yuanquan-B41889 wrote: On 12/05/2012 03:17 PM, Benjamin Herrenschmidt wrote: On Wed, 2012-12-05 at 10:31 +0800, Yuanquan Chen wrote: On powerpc arch, some fixup work of PCI/PCI-e device is just done

Re: [PATCH] powerpc/pci-hotplug: fix the rescanned pci device's dma_set_mask issue

2012-11-27 Thread Chen Yuanquan-B41889
On 11/25/2012 08:41 PM, Kumar Gala wrote: On Nov 22, 2012, at 10:29 PM, Yuanquan Chen wrote: On powerpc arch, dma_ops of rescanned pci device after system's booting up won't be initialized by system, so it will fail to execute the dma_set_mask in the device's driver. Initialize it to solve

Re: [PATCH] powerpc/pci-hotplug: fix the rescanned pci device's dma_set_mask issue

2012-11-25 Thread Chen Yuanquan-B41889
On 11/25/2012 08:41 PM, Kumar Gala wrote: On Nov 22, 2012, at 10:29 PM, Yuanquan Chen wrote: On powerpc arch, dma_ops of rescanned pci device after system's booting up won't be initialized by system, so it will fail to execute the dma_set_mask in the device's driver. Initialize it to solve