Re: [PATCH v2] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-05 Thread David Miller
From: Michael Ellerman Date: Tue, 5 Jan 2021 20:15:15 +1100 > Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() > into error") the ppc32_allmodconfig build fails with: > > ERROR: modpost: missing MODULE_LICENSE() in > drivers/net/ethernet/freescale/fs_enet/mii-fec.o >

Re: [PATCH net v3 0/2] ibmvnic: Bug fixes for queue descriptor processing

2020-12-01 Thread David Miller
From: Thomas Falcon Date: Tue, 1 Dec 2020 09:52:09 -0600 > This series resolves a few issues in the ibmvnic driver's > RX buffer and TX completion processing. The first patch > includes memory barriers to synchronize queue descriptor > reads. The second patch fixes a memory leak that could >

Re: [PATCH v4 net-next 0/2] Add Seville Ethernet switch to T1040RDB

2020-10-03 Thread David Miller
From: Vladimir Oltean Date: Fri, 2 Oct 2020 16:41:04 +0300 > Seville is a DSA switch that is embedded inside the T1040 SoC, and > supported by the mscc_seville DSA driver inside drivers/net/dsa/ocelot. > > This series adds this switch to the SoC's dtsi files and to the T1040RDB > board file. >

Re: [PATCH v3 devicetree 0/2] Add Seville Ethernet switch to T1040RDB

2020-10-01 Thread David Miller
From: Vladimir Oltean Date: Thu, 1 Oct 2020 16:20:11 +0300 > Seville is a DSA switch that is embedded inside the T1040 SoC, and > supported by the mscc_seville DSA driver inside drivers/net/dsa/ocelot. > > This series adds this switch to the SoC's dtsi files and to the T1040RDB > board file.

Re: [PATCH -next] ide: Fix symbol undeclared warnings

2020-09-17 Thread David Miller
From: Michael Ellerman Date: Thu, 17 Sep 2020 22:01:00 +1000 > Wang Wensheng writes: >> Build the object file with `C=2` and get the following warnings: >> make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu- >> make C=2 drivers/ide/pmac.o ARCH=powerpc64 >>

Re: [PATCH net] ibmvnic: update MAINTAINERS

2020-09-15 Thread David Miller
From: Dany Madden Date: Mon, 14 Sep 2020 20:35:35 -0400 > Update supporters for IBM Power SRIOV Virtual NIC Device Driver. > Thomas Falcon is moving on to other works. Dany Madden, Lijun Pan > and Sukadev Bhattiprolu are the current supporters. > > Signed-off-by: Dany Madden Applied.

Re: [PATCH v2 3/4] sparc64: remove mm_cpumask clearing to fix kthread_use_mm race

2020-09-15 Thread David Miller
From: Nicholas Piggin Date: Tue, 15 Sep 2020 13:24:07 +1000 > Excerpts from David Miller's message of September 15, 2020 5:59 am: >> From: Nicholas Piggin >> Date: Mon, 14 Sep 2020 14:52:18 +1000 >> >> ... >>> The basic fix for sparc64 is to remove its mm_cpumask clearing code. The >>>

Re: [PATCH v2 3/4] sparc64: remove mm_cpumask clearing to fix kthread_use_mm race

2020-09-14 Thread David Miller
From: Nicholas Piggin Date: Mon, 14 Sep 2020 14:52:18 +1000 ... > The basic fix for sparc64 is to remove its mm_cpumask clearing code. The > optimisation could be effectively restored by sending IPIs to mm_cpumask > members and having them remove themselves from mm_cpumask. This is more >

Re: [PATCH net-next] net/wan/fsl_ucc_hdlc: Add MODULE_DESCRIPTION

2020-08-31 Thread David Miller
From: YueHaibing Date: Sat, 29 Aug 2020 19:58:23 +0800 > Add missing MODULE_DESCRIPTION. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net v3] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset

2020-08-25 Thread David Miller
From: Dany Madden Date: Tue, 25 Aug 2020 13:26:41 -0400 > From: Mingming Cao > > At the time of do_rest, ibmvnic tries to re-initalize the tx_pools > and rx_pools to avoid re-allocating the long term buffer. However > there is a window inside do_reset that the tx_pools and > rx_pools were

Re: [PATCH net v2] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset

2020-08-25 Thread David Miller
From: Dany Madden Date: Tue, 25 Aug 2020 12:56:06 -0400 > @@ -2011,7 +2017,10 @@ static int do_reset(struct ibmvnic_adapter *adapter, > adapter->req_rx_add_entries_per_subcrq != > old_num_rx_slots || > adapter->req_tx_entries_per_subcrq != >

Re: [PATCH 17/29] fs_enet: Avoid comma separated statements

2020-08-25 Thread David Miller
From: Joe Perches Date: Mon, 24 Aug 2020 21:56:14 -0700 > Use semicolons and braces. > > Signed-off-by: Joe Perches Applied.

Re: [PATCH net-next v2 0/4] refactoring of ibmvnic code

2020-08-20 Thread David Miller
From: Lijun Pan Date: Wed, 19 Aug 2020 17:52:22 -0500 > This patch series refactor reset_init and init functions, > and make some other cosmetic changes to make the code > easier to read and debug. v2 removes __func__ and v1's 1/5. Series applied, thank you.

Re: [PATCH net-next 3/5] ibmvnic: improve ibmvnic_init and ibmvnic_reset_init

2020-08-19 Thread David Miller
From: Lijun Pan Date: Wed, 19 Aug 2020 00:35:10 -0500 > + if (rc) { > + dev_err(dev, "%s: Send crq init failed with error %d\n", > __func__, rc); > + return rc; Consistent with my feedback on patch #1, please get rid of this __func__ stuff. Thank you.

Re: [PATCH net-next 1/5] ibmvnic: print caller in several error messages

2020-08-19 Thread David Miller
From: Lijun Pan Date: Wed, 19 Aug 2020 00:35:08 -0500 > The error messages in the changed functions are exactly the same. > In order to differentiate them and make debugging easier, > we print the function names in the error messages. > > Signed-off-by: Lijun Pan I don't see any value in

Re: [PATCH net 0/5] refactoring of ibmvnic code

2020-08-14 Thread David Miller
From: Lijun Pan Date: Fri, 14 Aug 2020 02:59:16 -0500 > This patch series refactor reset_init and init functions, > improve the debugging messages, and make some other cosmetic changes > to make the code easier to read and debug. Cosmetic changes and cleanups are not appropriate at this time as

Re: [PATCH net] ibmvnic: Fix IRQ mapping disposal in error path

2020-07-29 Thread David Miller
From: Thomas Falcon Date: Wed, 29 Jul 2020 16:36:32 -0500 > RX queue IRQ mappings are disposed in both the TX IRQ and RX IRQ > error paths. Fix this and dispose of TX IRQ mappings correctly in > case of an error. > > Signed-off-by: Thomas Falcon Applied with Fixes: tag added and queued up for

Re: [PATCH net-next] net: fs_enet: remove redundant null check

2020-07-20 Thread David Miller
From: Zhang Changzhong Date: Mon, 20 Jul 2020 19:12:33 +0800 > Because clk_prepare_enable and clk_disable_unprepare already > checked NULL clock parameter, so the additional checks are > unnecessary, just remove them. > > Signed-off-by: Zhang Changzhong Applied.

Re: [PATCH net-next] ibmvnic: Increase driver logging

2020-07-15 Thread David Miller
From: Jakub Kicinski Date: Wed, 15 Jul 2020 17:06:32 -0700 > On Wed, 15 Jul 2020 18:51:55 -0500 Thomas Falcon wrote: >> free_netdev(netdev); >> dev_set_drvdata(>dev, NULL); >> +netdev_info(netdev, "VNIC client device has been successfully >> removed.\n"); > > A step too far,

Re: [PATCH v4 3/8] sparc64: Fix asm/percpu.h build error

2020-06-23 Thread David Miller
From: Peter Zijlstra Date: Tue, 23 Jun 2020 10:36:48 +0200 > In order to break a header dependency between lockdep and task_struct, > I need per-cpu stuff from lockdep. > > Signed-off-by: Peter Zijlstra (Intel) Acked-by: David S. Miller

Re: [PATCH net] ibmvnic: continue to init in CRQ reset returns H_CLOSED

2020-06-20 Thread David Miller
From: Dany Madden Date: Thu, 18 Jun 2020 15:24:13 -0400 > Continue the reset path when partner adapter is not ready or H_CLOSED is > returned from reset crq. This patch allows the CRQ init to proceed to > establish a valid CRQ for traffic to flow after reset. > > Signed-off-by: Dany Madden

Re: [PATCH net] ibmveth: Fix max MTU limit

2020-06-19 Thread David Miller
From: Thomas Falcon Date: Thu, 18 Jun 2020 10:43:46 -0500 > The max MTU limit defined for ibmveth is not accounting for > virtual ethernet buffer overhead, which is twenty-two additional > bytes set aside for the ethernet header and eight additional bytes > of an opaque handle reserved for use

Re: [PATCH net v2] ibmvnic: Harden device login requests

2020-06-15 Thread David Miller
From: Thomas Falcon Date: Mon, 15 Jun 2020 10:29:23 -0500 > The VNIC driver's "login" command sequence is the final step > in the driver's initialization process with device firmware, > confirming the available device queue resources to be utilized > by the driver. Under high system load,

Re: [PATCH net] ibmvnic: Flush existing work items before device removal

2020-06-12 Thread David Miller
From: Thomas Falcon Date: Fri, 12 Jun 2020 13:34:41 -0500 > Ensure that all scheduled work items have completed before continuing > with device removal and after further event scheduling has been > halted. This patch fixes a bug where a scheduled driver reset event > is processed following

Re: [PATCH net] ibmvnic: Harden device login requests

2020-06-12 Thread David Miller
From: Thomas Falcon Date: Fri, 12 Jun 2020 13:31:39 -0500 > @@ -841,13 +841,14 @@ static int ibmvnic_login(struct net_device *netdev) > { > struct ibmvnic_adapter *adapter = netdev_priv(netdev); > unsigned long timeout = msecs_to_jiffies(3); > + int retries = 10; > int

Re: [PATCH] net: ethernet: freescale: remove unneeded include for ucc_geth

2020-06-04 Thread David Miller
From: Valentin Longchamp Date: Wed, 3 Jun 2020 23:28:23 +0200 > net/sch_generic.h does not need to be included, remove it. > > Signed-off-by: Valentin Longchamp Applied.

Re: [PATCH net] drivers/net/ibmvnic: Update VNIC protocol version reporting

2020-05-29 Thread David Miller
From: Thomas Falcon Date: Thu, 28 May 2020 11:19:17 -0500 > VNIC protocol version is reported in big-endian format, but it > is not byteswapped before logging. Fix that, and remove version > comparison as only one protocol version exists at this time. > > Signed-off-by: Thomas Falcon Applied,

Re: [RFC][PATCH v3 1/5] sparc64: Fix asm/percpu.h build error

2020-05-29 Thread David Miller
From: Peter Zijlstra Date: Fri, 29 May 2020 23:35:51 +0200 > ../arch/sparc/include/asm/percpu_64.h:7:24: warning: call-clobbered register > used for global register variable > register unsigned long __local_per_cpu_offset asm("g5"); The "-ffixed-g5" option on the command line tells gcc that we

Re: [PATCH] net/ethernet/freescale: rework quiesce/activate for ucc_geth

2020-05-22 Thread David Miller
From: Valentin Longchamp Date: Wed, 20 May 2020 17:53:50 +0200 > ugeth_quiesce/activate are used to halt the controller when there is a > link change that requires to reconfigure the mac. > > The previous implementation called netif_device_detach(). This however > causes the initial activation

Re: [PATCH net] ibmvnic: Skip fatal error reset after passive init

2020-04-30 Thread David Miller
From: Juliet Kim Date: Thu, 30 Apr 2020 13:22:11 -0500 > During MTU change, the following events may happen. > Client-driven CRQ initialization fails due to partner’s CRQ closed, > causing client to enqueue a reset task for FATAL_ERROR. Then passive > (server-driven) CRQ initialization succeeds,

Re: [PATCH 00/37] net: manually convert files to ReST format - part 2

2020-04-30 Thread David Miller
From: Mauro Carvalho Chehab Date: Thu, 30 Apr 2020 18:03:55 +0200 > That's the second part of my work to convert the networking > text files into ReST. it is based on today's linux-next (next-20200430). > > The full series (including those ones) are at: > >

Re: [PATCH net v2] ibmvnic: Do not process device remove during device reset

2020-03-10 Thread David Miller
From: Juliet Kim Date: Tue, 10 Mar 2020 09:23:58 -0500 > The ibmvnic driver does not check the device state when the device > is removed. If the device is removed while a device reset is being > processed, the remove may free structures needed by the reset, > causing an oops. > > Fix this by

Re: [PATCH net] ibmvnic: Do not process device remove during device reset

2020-03-09 Thread David Miller
From: Juliet Kim Date: Mon, 9 Mar 2020 19:02:04 -0500 > diff --git a/drivers/net/ethernet/ibm/ibmvnic.c > b/drivers/net/ethernet/ibm/ibmvnic.c > index c75239d8820f..7ef1ae0d49bc 100644 > --- a/drivers/net/ethernet/ibm/ibmvnic.c > +++ b/drivers/net/ethernet/ibm/ibmvnic.c > @@ -2144,6 +2144,8 @@

Re: [PATCH net-next 00/23] Clean driver, module and FW versions

2020-03-03 Thread David Miller
From: Leon Romanovsky Date: Sun, 1 Mar 2020 16:44:33 +0200 > From: Leon Romanovsky > > Hi, > > This is second batch of the series which removes various static versions > in favour of globaly defined Linux kernel version. > > The first part with better cover letter can be found here >

Re: [PATCH net-next 00/23] Clean driver, module and FW versions

2020-03-01 Thread David Miller
From: Leon Romanovsky Date: Sun, 1 Mar 2020 16:44:33 +0200 > This is second batch of the series which removes various static versions > in favour of globaly defined Linux kernel version. This generally looks fine to me but I'll let it sit for a few days so that others can review.

Re: [PATCH][next] toshiba: Replace zero-length array with flexible-array member

2020-02-24 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 24 Feb 2020 10:32:52 -0600 > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced

Re: [PATCH v2 net-next] net: convert suitable drivers to use phy_do_ioctl_running

2020-01-23 Thread David Miller
From: Heiner Kallweit Date: Tue, 21 Jan 2020 22:09:33 +0100 > Convert suitable drivers to use new helper phy_do_ioctl_running. > > Signed-off-by: Heiner Kallweit > --- > v2: I forgot the netdev mailing list Applied to net-next.

Re: [PATCH] ide: remove set but not used variable 'hwif'

2020-01-20 Thread David Miller
From: Wang Hai Date: Sat, 26 Oct 2019 09:57:38 +0800 > Fix the following gcc warning: > > drivers/ide/pmac.c: In function pmac_ide_setup_device: > drivers/ide/pmac.c:1027:14: warning: variable hwif set but not used > [-Wunused-but-set-variable] > > Fixes: d58b0c39e32f ("powerpc/macio: Rework

Re: [PATCH] net/wan/fsl_ucc_hdlc: fix out of bounds write on array utdm_info

2020-01-15 Thread David Miller
From: Colin King Date: Tue, 14 Jan 2020 14:54:48 + > From: Colin Ian King > > Array utdm_info is declared as an array of MAX_HDLC_NUM (4) elements > however up to UCC_MAX_NUM (8) elements are potentially being written > to it. Currently we have an array out-of-bounds write error on the >

Re: [PATCH v6 00/49] QUICC Engine support on ARM, ARM64, PPC64

2019-12-02 Thread David Miller
From: Li Yang Date: Mon, 2 Dec 2019 16:56:39 -0600 > On Mon, Dec 2, 2019 at 2:14 AM Rasmus Villemoes > wrote: >> >> On 01/12/2019 17.10, Timur Tabi wrote: >> > On 11/28/19 8:55 AM, Rasmus Villemoes wrote: >> >> There have been several attempts in the past few years to allow >> >> building the

Re: [PATCH v6 44/49] net/wan/fsl_ucc_hdlc: avoid use of IS_ERR_VALUE()

2019-12-02 Thread David Miller
From: Leo Li Date: Mon, 2 Dec 2019 22:51:57 + > > >> -Original Message- >> From: Rasmus Villemoes >> Sent: Thursday, November 28, 2019 8:56 AM >> To: Qiang Zhao ; Leo Li ; >> Christophe Leroy >> Cc: linuxppc-dev@lists.ozlabs.org; linux-arm-ker...@lists.infradead.org; >>

Re: [PATCH net v2 0/4] ibmvnic: Harden device commands and queries

2019-11-26 Thread David Miller
From: Thomas Falcon Date: Mon, 25 Nov 2019 17:12:52 -0600 > This patch series fixes some shortcomings with the current > VNIC device command implementation. The first patch fixes > the initialization of driver completion structures used > for device commands. Additionally, all waits for device >

Re: [PATCH] drivers: net: Fix Kconfig indentation, continued

2019-11-21 Thread David Miller
From: Krzysztof Kozlowski Date: Thu, 21 Nov 2019 21:28:28 +0800 > Adjust indentation from spaces to tab (+optional two spaces) as in > coding style. This fixes various indentation mixups (seven spaces, > tab+one space, etc). > > Signed-off-by: Krzysztof Kozlowski Applied to net-next.

Re: [PATCH net/ibmvnic 0/2] Support both XIVE and XICS modes in ibmvnic

2019-11-20 Thread David Miller
From: Juliet Kim Date: Wed, 20 Nov 2019 10:50:02 -0500 > This series aims to support both XICS and XIVE with avoiding > a regression in behavior when a system runs in XICS mode. > > Patch 1 reverts commit 11d49ce9f7946dfed4dcf5dbde865c78058b50ab > (“net/ibmvnic: Fix EOI when running in XIVE

Re: [PATCH] net/ibmvnic: Fix EOI when running in XIVE mode.

2019-10-13 Thread David Miller
From: Cédric Le Goater Date: Fri, 11 Oct 2019 07:52:54 +0200 > pSeries machines on POWER9 processors can run with the XICS (legacy) > interrupt mode or with the XIVE exploitation interrupt mode. These > interrupt contollers have different interfaces for interrupt > management : XICS uses hcalls

Re: [PATCH v4 0/2] net/ibmvnic: serialization fixes

2019-09-25 Thread David Miller
From: Juliet Kim Date: Fri, 20 Sep 2019 16:11:21 -0400 > This series includes two fixes. The first improves reset code to allow > linkwatch_event to proceed during reset. The second ensures that no more > than one thread runs in reset at a time. > > v2: > - Separate change param reset from

Re: [PATCH] net/ibmvnic: Fix missing { in __ibmvnic_reset

2019-09-10 Thread David Miller
From: Michal Suchanek Date: Mon, 9 Sep 2019 22:44:51 +0200 > Commit 1c2977c09499 ("net/ibmvnic: free reset work of removed device from > queue") > adds a } without corresponding { causing build break. > > Fixes: 1c2977c09499 ("net/ibmvnic: free reset work of removed device from > queue") >

Re: [PATCH] net/ibmvnic: free reset work of removed device from queue

2019-09-07 Thread David Miller
From: Juliet Kim Date: Thu, 5 Sep 2019 17:30:01 -0400 > Commit 36f1031c51a2 ("ibmvnic: Do not process reset during or after > device removal") made the change to exit reset if the driver has been > removed, but does not free reset work items of the adapter from queue. > > Ensure all reset

Re: [PATCH v2 7/9] sparc64: numa: check the node id consistently for sparc64

2019-09-02 Thread David Miller
From: Yunsheng Lin Date: Mon, 2 Sep 2019 14:08:31 +0800 > The NUMA node id in sparc64 system is defined by DT semantics? Sometimes, and in other cases other methods are used to determine the NUMA node id.

Re: [PATCH v2 7/9] sparc64: numa: check the node id consistently for sparc64

2019-08-31 Thread David Miller
From: Yunsheng Lin Date: Sat, 31 Aug 2019 16:57:04 +0800 > Did you mean sparc64 system does not has ACPI, the device's node id will > not specified by ACPI, so the ACPI is unrelated here? Yes, sparc64 never has and never will have ACPI. This is also true for several other platforms where you

Re: [PATCH v2 7/9] sparc64: numa: check the node id consistently for sparc64

2019-08-31 Thread David Miller
From: Yunsheng Lin Date: Sat, 31 Aug 2019 13:58:21 +0800 > According to Section 6.2.14 from ACPI spec 6.3 [1], the setting > of proximity domain is optional, as below: What in the world does the ACPI spec have to do with sparc64 NUMA node ID checking?

Re: [PATCH net] ibmvnic: Do not process reset during or after device removal

2019-08-28 Thread David Miller
From: Thomas Falcon Date: Tue, 27 Aug 2019 11:10:04 -0500 > Currently, the ibmvnic driver will not schedule device resets > if the device is being removed, but does not check the device > state before the reset is actually processed. This leads to a race > where a reset is scheduled with a valid

Re: [PATCH 1/2] net/ibmvnic: unlock rtnl_lock in reset so linkwatch_event can run

2019-08-21 Thread David Miller
From: Juliet Kim Date: Tue, 20 Aug 2019 17:31:19 -0400 > Commit a5681e20b541 ("net/ibmnvic: Fix deadlock problem in reset") > made the change to hold the RTNL lock during a reset to avoid deadlock > but linkwatch_event is fired during the reset and needs the RTNL lock. > That keeps

Re: [PATCH net-next v2] ibmveth: Allow users to update reported speed and duplex

2019-08-09 Thread David Miller
From: Jakub Kicinski Date: Tue, 6 Aug 2019 15:15:24 -0700 > On Tue, 6 Aug 2019 11:23:08 -0500, Thomas Falcon wrote: >> Reported ethtool link settings for the ibmveth driver are currently >> hardcoded and no longer reflect the actual capabilities of supported >> hardware. There is no interface

Re: [PATCH net] net/ibmvnic: Report last valid speed and duplex values to ethtool

2019-07-02 Thread David Miller
From: Thomas Falcon Date: Thu, 27 Jun 2019 12:09:13 -0500 > This patch resolves an issue with sensitive bonding modes > that require valid speed and duplex settings to function > properly. Currently, the adapter will report that device > speed and duplex is unknown if the communication link >

Re: [PATCH] ps3_gelic: Use [] to denote a flexible array member

2019-06-18 Thread David Miller
From: Geert Uytterhoeven Date: Mon, 17 Jun 2019 13:50:44 +0200 > Flexible array members should be denoted using [] instead of [0], else > gcc will not warn when they are no longer at the end of a struct. > > Signed-off-by: Geert Uytterhoeven Applied to net-next, thanks.

Re: [PATCH net 0/3] ibmvnic: Fixes for device reset handling

2019-06-09 Thread David Miller
From: Thomas Falcon Date: Fri, 7 Jun 2019 16:03:52 -0500 > This series contains three unrelated fixes to issues seen during > device resets. The first patch fixes an error when the driver requests > to deactivate the link of an uninitialized device, resulting in a > failure to reset. Next, a

Re: RFC: switch the remaining architectures to use generic GUP v2

2019-06-01 Thread David Miller
From: Christoph Hellwig Date: Sat, 1 Jun 2019 09:49:43 +0200 > below is a series to switch mips, sh and sparc64 to use the generic > GUP code so that we only have one codebase to touch for further > improvements to this code. I don't have hardware for any of these > architectures, and

Re: [PATCH v3 0/6] Prerequisites for NXP LS104xA SMMU enablement

2019-05-30 Thread David Miller
From: laurentiu.tu...@nxp.com Date: Thu, 30 May 2019 17:19:45 +0300 > Depends on this pull request: > > http://lists.infradead.org/pipermail/linux-arm-kernel/2019-May/653554.html I'm not sure how you want me to handle this.

Re: [PATCH] net: ucc_geth - fix Oops when changing number of buffers in the ring

2019-05-05 Thread David Miller
From: Christophe Leroy Date: Fri, 3 May 2019 13:33:23 + (UTC) > When changing the number of buffers in the RX ring while the interface > is running, the following Oops is encountered due to the new number > of buffers being taken into account immediately while their allocation > is done

Re: [PATCH v3] dpaa_eth: fix SG frame cleanup

2019-05-05 Thread David Miller
From: laurentiu.tu...@nxp.com Date: Fri, 3 May 2019 16:03:11 +0300 > From: Laurentiu Tudor > > Fix issue with the entry indexing in the sg frame cleanup code being > off-by-1. This problem showed up when doing some basic iperf tests and > manifested in traffic coming to a halt. > >

Re: [PATCH v2 3/9] fsl/fman: backup and restore ICID registers

2019-04-27 Thread David Miller
From: laurentiu.tu...@nxp.com Date: Sat, 27 Apr 2019 10:10:25 +0300 > @@ -1914,7 +1936,10 @@ static int fman_reset(struct fman *fman) > static int fman_init(struct fman *fman) > { > struct fman_cfg *cfg = NULL; > - int err = 0, i, count; > + int err = 0, count; > +#ifdef

Re: [PATCH -next] ibmvnic: remove set but not used variable 'netdev'

2019-04-04 Thread David Miller
From: Yue Haibing Date: Wed, 3 Apr 2019 15:54:09 +0800 > From: YueHaibing > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/ibm/ibmvnic.c: In function '__ibmvnic_reset': > drivers/net/ethernet/ibm/ibmvnic.c:1971:21: warning: variable 'netdev' set > but not used

Re: [PATCH net-next] ibmveth: Make array ibmveth_stats static

2019-03-19 Thread David Miller
From: Yue Haibing Date: Tue, 19 Mar 2019 22:42:37 +0800 > From: YueHaibing > > Fix sparse warning: > drivers/net/ethernet/ibm/ibmveth.c:96:21: > warning: symbol 'ibmveth_stats' was not declared. Should it be static? > > Signed-off-by: YueHaibing Applied.

Re: [PATCH v5 4/4] hugetlb: allow to free gigantic pages regardless of the configuration

2019-03-06 Thread David Miller
From: Alexandre Ghiti Date: Wed, 6 Mar 2019 14:00:05 -0500 > On systems without CONTIG_ALLOC activated but that support gigantic pages, > boottime reserved gigantic pages can not be freed at all. This patch > simply enables the possibility to hand back those pages to memory > allocator. > >

Re: [PATCH v5 2/4] sparc: Advertise gigantic page support

2019-03-06 Thread David Miller
From: Alexandre Ghiti Date: Wed, 6 Mar 2019 14:00:03 -0500 > sparc actually supports gigantic pages and selecting > ARCH_HAS_GIGANTIC_PAGE allows it to allocate and free > gigantic pages at runtime. > > sparc allows configuration such as huge pages of 16GB, > pages of 8KB and MAX_ORDER = 13

Re: [PATCH][next] ptp_qoriq: don't pass a large struct by value but instead pass it by reference

2019-02-19 Thread David Miller
From: Colin King Date: Tue, 19 Feb 2019 14:21:20 + > From: Colin Ian King > > Passing the struct ptp_clock_info caps by parameter is passing over 130 bytes > of data by value on the stack. Optimize this by passing it by reference > instead. > Also shinks the object code size: > > Before:

Re: [PATCH net] net: fsl_ucc_hdlc: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles

2019-02-06 Thread David Miller
From: Yang Wei Date: Wed, 6 Feb 2019 00:14:51 +0800 > From: Yang Wei > > dev_consume_skb_irq() should be called in hdlc_tx_done() when skb > xmit done. It makes drop profiles(dropwatch, perf) more friendly. > > Signed-off-by: Yang Wei Applied.

Re: [PATCH] ucc_geth: Reset BQL queue when stopping device

2019-01-30 Thread David Miller
From: Mathias Thore Date: Mon, 28 Jan 2019 10:07:47 +0100 > After a timeout event caused by for example a broadcast storm, when > the MAC and PHY are reset, the BQL TX queue needs to be reset as > well. Otherwise, the device will exhibit severe performance issues > even after the storm has

Re: [PATCH] ucc_geth: Reset BQL queue when stopping device

2019-01-29 Thread David Miller
From: Mathias Thore Date: Tue, 29 Jan 2019 08:07:54 + > Is there a scenario where we are clearing the TX ring but don't want to reset > the BQL TX queue? > > I think it makes sense to keep it in ucc_geth_free_tx since the > reason it is needed isn't the timeout per se, but rather the >

Re: [PATCH 15/21] sparc: add checks for the return value of memblock_alloc*()

2019-01-16 Thread David Miller
From: Mike Rapoport Date: Wed, 16 Jan 2019 15:44:15 +0200 > Add panic() calls if memblock_alloc*() returns NULL. > > Most of the changes are simply addition of > > if(!ptr) > panic(); > > statements after the calls to memblock_alloc*() variants. > > Exceptions are

Re: [RESEND PATCH v5] soc/fsl/qe: fix err handling of ucc_of_parse_tdm

2019-01-04 Thread David Miller
From: Peng Hao Date: Thu, 3 Jan 2019 01:09:53 +0800 > From: Wen Yang > > Currently there are some issues with the ucc_of_parse_tdm function: > 1, a possible null pointer dereference in ucc_of_parse_tdm, > detected by the semantic patch deref_null.cocci, > with the following warning: >

Re: [PATCH v4] soc/fsl/qe: fix err handling of ucc_of_parse_tdm

2018-12-30 Thread David Miller
From: Peng Hao Date: Sat, 29 Dec 2018 16:47:32 +0800 > +static struct resource *ucc_get_resource_by_nodename(char *name) > +{ > + struct device_node *np; > + struct platform_device *pdev; > + > + np = of_find_compatible_node(NULL, NULL, name); > + if (!np) > + return

Re: [PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse_tdm

2018-12-28 Thread David Miller
From: Peng Hao Date: Wed, 26 Dec 2018 16:26:29 +0800 > diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c > index 839fa77..8ce4921f 100644 > --- a/drivers/net/wan/fsl_ucc_hdlc.c > +++ b/drivers/net/wan/fsl_ucc_hdlc.c > @@ -1057,6 +1057,27 @@ static const struct

Re: [PATCH] net/wan/fsl_ucc_hdlc: Avoid double free in ucc_hdlc_probe()

2018-12-27 Thread David Miller
From: Peng Hao Date: Wed, 26 Dec 2018 16:28:30 +0800 > From: Wen Yang > > This patch fixes potential double frees if register_hdlc_device() fails. > > Signed-off-by: Wen Yang > Reviewed-by: Peng Hao Applied.

Re: [PATCH] net/ibmvnic: Remove tests of member address

2018-12-14 Thread David Miller
From: Wen Yang Date: Tue, 11 Dec 2018 12:20:46 +0800 > The driver was checking for non-NULL address. > - adapter->napi[i] > > This is pointless as these will be always non-NULL, since the > 'dapter->napi' is allocated in init_napi(). > It is safe to get rid of useless checks for addresses to

Re: [PATCH net 0/2] net/ibmvnic: Fix reset work item locking bugs

2018-12-10 Thread David Miller
From: Thomas Falcon Date: Mon, 10 Dec 2018 15:22:21 -0600 > This patch set fixes issues with scheduling reset work items in > a tasklet context. Since ibmvnic_reset can called in an interrupt, > it should not use a mutex or allocate memory non-atomically. Series applied, thanks.

Re: [PATCH] tty: Use of_node_name_{eq,prefix} for node name comparisons

2018-12-05 Thread David Miller
From: Rob Herring Date: Wed, 5 Dec 2018 13:50:43 -0600 > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > For hvc, the code can also be simplified by using of_stdout pointer > instead of searching again

Re: [PATCH v2 16/20] sparc: perf/core: advertise PMU exclusion capability

2018-11-26 Thread David Miller
From: Andrew Murray Date: Mon, 26 Nov 2018 11:12:32 + > The SPARC PMU has the capability to exclude events based on context > - let's advertise that we support the PERF_PMU_CAP_EXCLUDE > capability to ensure that perf doesn't prevent us from handling > events where any exclusion flags are

Re: [PATCH v3 0/3] dpaa_eth: add ethtool coalesce control

2018-11-23 Thread David Miller
From: Madalin Bucur Date: Wed, 21 Nov 2018 13:41:06 +0200 > Add control of the DPAA portal interrupt coalescing settings from > ethtool. > > changes from v2: read ithresh from HW, set previous values on failure > changes from v1: added range checking for the QMan APIs Series applied.

Re: [PATCH net 0/2] ibmvnic: Fix queue and buffer accounting errors

2018-11-22 Thread David Miller
From: Thomas Falcon Date: Wed, 21 Nov 2018 11:17:57 -0600 > This series includes two small fixes. The first resolves a typo bug > in the code to clean up unused RX buffers during device queue removal. > The second ensures that device queue memory is updated to reflect new > supported queue ring

Re: [PATCH net] net/ibmnvic: Fix deadlock problem in reset

2018-11-19 Thread David Miller
From: Juliet Kim Date: Mon, 19 Nov 2018 15:59:22 -0600 > This patch changes to use rtnl_lock only during a reset to avoid > deadlock that could occur when a thread operating close is holding > rtnl_lock and waiting for reset_lock acquired by another thread, > which is waiting for rtnl_lock in

Re: [PATCH] net/ibmnvic: Fix deadlock problem in reset

2018-11-17 Thread David Miller
Your patch is completely corrupted by your email client. Please fix this. Then, email a test patch privately to yourself. Please do not post your patch to this mailing list again until you can successfully apply the test patch you email to yourself in the step above. Thank you.

Re: [PATCH net-next 0/6] Remove VLAN.CFI overload

2018-11-16 Thread David Miller
From: Alexei Starovoitov Date: Fri, 16 Nov 2018 19:51:55 -0800 > Michal, could you please explain the reasoning? By treating VLAN.CFI specially as "VLAN TAG PRESENT" we prevent the usage of certain VLAN ID encodings. So he's trying to get rid of VLAN_TAG_PRESENT completely and this was the

Re: [PATCH v2 2/2] dpaa_eth: add ethtool coalesce control

2018-11-16 Thread David Miller
From: Madalin Bucur Date: Tue, 13 Nov 2018 18:29:51 +0200 > + for_each_cpu(cpu, cpus) { > + portal = qman_get_affine_portal(cpu); > + res = qman_portal_set_iperiod(portal, period); > + if (res) > + return res; > + res =

Re: [PATCH net-next 0/6] Remove VLAN.CFI overload

2018-11-16 Thread David Miller
From: Michał Mirosław Date: Sat, 10 Nov 2018 19:58:29 +0100 > Fix BPF code/JITs to allow for separate VLAN_PRESENT flag > storage and finally move the flag to separate storage in skbuff. > > This is final step to make CLAN.CFI transparent to core Linux > networking stack. > > An #ifdef is

Re: [PATCH net-next 0/6] Remove VLAN.CFI overload

2018-11-10 Thread David Miller
From: Michał Mirosław Date: Sat, 10 Nov 2018 19:58:29 +0100 > Fix BPF code/JITs to allow for separate VLAN_PRESENT flag > storage and finally move the flag to separate storage in skbuff. > > This is final step to make CLAN.CFI transparent to core Linux > networking stack. > > An #ifdef is

Re: [PATCH] net/wan/fsl_ucc_hdlc: add BQL support

2018-11-07 Thread David Miller
From: Mathias Thore Date: Wed, 7 Nov 2018 09:09:45 +0100 > Add byte queue limits support in the fsl_ucc_hdlc driver. > > Signed-off-by: Mathias Thore Applied to net-next.

Re: [PATCH] net/wan/fsl_ucc_hdlc: add BQL support

2018-10-23 Thread David Miller
From: Mathias Thore Date: Tue, 23 Oct 2018 13:48:32 +0200 > Add byte queue limits support in the fsl_ucc_hdlc driver. > > Signed-off-by: Mathias Thore > --- > > Note that this patch is created relative to another patch that was > applied recently: net/wan/fsl_ucc_hdlc: error counters

Re: [PATCH] net/wan/fsl_ucc_hdlc: error counters

2018-10-22 Thread David Miller
From: Mathias Thore Date: Mon, 22 Oct 2018 14:55:50 +0200 > Extract error information from rx and tx buffer descriptors, > and update error counters. > > Signed-off-by: Mathias Thore Applied.

Re: linux-next: Tree for Oct 15

2018-10-15 Thread David Miller
From: Rob Herring Date: Mon, 15 Oct 2018 20:00:24 -0500 > David, Can you revert commit 0b9871a3a8cc. I'll have to find another approach. Ok.

Re: [PATCH v2 2/2] mm: speed up mremap by 500x on large regions

2018-10-12 Thread David Miller
From: Joel Fernandes Date: Fri, 12 Oct 2018 05:50:46 -0700 > If its an issue, then how do transparent huge pages work on Sparc? I don't > see the huge page code (move_huge_pages) during mremap doing anything special > for Sparc architecture when moving PMDs.. This is because all huge pages are

Re: [PATCH v2 2/2] mm: speed up mremap by 500x on large regions

2018-10-12 Thread David Miller
From: "Kirill A. Shutemov" Date: Fri, 12 Oct 2018 14:30:56 +0300 > I looked into the code more and noticed move_pte() helper called from > move_ptes(). It changes PTE entry to suite new address. > > It is only defined in non-trivial way on Sparc. I don't know much about > Sparc and it's hard

Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function

2018-09-20 Thread David Miller
From: YueHaibing Date: Thu, 20 Sep 2018 20:32:44 +0800 > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to

Re: [PATCH net-next] net: toshiba: fix return type of ndo_start_xmit function

2018-09-19 Thread David Miller
From: YueHaibing Date: Wed, 19 Sep 2018 18:23:39 +0800 > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to

Re: [PATCH net-next] net: ibm: fix return type of ndo_start_xmit function

2018-09-18 Thread David Miller
From: YueHaibing Date: Tue, 18 Sep 2018 14:35:47 +0800 > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to

Re: [PATCH net] powerpc: use big endian to hash len and proto in csum_ipv6_magic

2018-09-12 Thread David Miller
From: Xin Long Date: Sat, 8 Sep 2018 18:15:12 +0800 > The function csum_ipv6_magic doesn't convert len and proto to big > endian before doing ipv6 csum hash, which is not consistent with > RFC and other arches. > > Jianlin found it when ICMPv6 packets from other hosts were dropped > in the

Re: [PATCH 0/5] introduce setbits32/clrbits32/clrsetbits32/setbits64/clrbits64/clrsetbits64 functions

2018-09-07 Thread David Miller
If you are going to do this, please add for_each_set_bit64() and similar. For example, see: https://marc.info/?l=linux-netdev=153633391214025=2

Re: [PATCH v3 0/6] Ethernet over hdlc

2018-09-04 Thread David Miller
From: David Gounaris Date: Mon, 3 Sep 2018 14:47:24 +0200 > Here is what has been changed in v3 after the review comments from v2. > > v3-0001: corrected style problems > v3-0002: corrected style problems > v3-0003: corrected style problems > v3-0004: corrected style problems > v3-0005:

Re: [PATCH v2 3/6] net/wan/fsl_ucc_hdlc: Adding ARPHRD_ETHER

2018-08-31 Thread David Miller
From: David Gounaris Date: Wed, 29 Aug 2018 15:13:25 +0200 > @@ -513,6 +517,8 @@ static int hdlc_rx_done(struct ucc_hdlc_private *priv, > int rx_work_limit) > break; > > case ARPHRD_PPP: > + case ARPHRD_ETHER: > + Please

  1   2   3   4   5   6   7   8   9   10   >