Re: [PATCH] MAINTAINERS: Add Shengjiu to reviewer list of sound/soc/fsl

2020-07-02 Thread Fabio Estevam
On Thu, Jul 2, 2020 at 4:31 PM Nicolin Chen wrote: > > Add Shengjiu who's actively working on the latest fsl/nxp audio drivers. > > Signed-off-by: Nicolin Chen > Cc: Shengjiu Wang Reviewed-by: Fabio Estevam

Re: [PATCH v3] ASoC: fsl_asrc: Add an option to select internal ratio mode

2020-06-30 Thread Fabio Estevam
; distortion. > > Add function fsl_asrc_select_clk() to find proper clock source for > internal ratio mode, if the clock source is available then internal > ratio mode will be selected. > > With change, the ideal ratio mode is not the only option for user. > > Signed-off-by: Shengjiu Wang Reviewed-by: Fabio Estevam

Re: [PATCH] ASoC: fsl_asrc: Add an option to select internal ratio mode

2020-06-30 Thread Fabio Estevam
Hi Shengjiu, On Mon, Jun 29, 2020 at 11:10 AM Shengjiu Wang wrote: > +/** "/**" notation may confuse 'make htmldocs". Since this is a single line comment you could do: /* Select proper clock source for internal ratio mode */ > + * Select proper clock source for internal ratio mode > + */ >

Re: [PATCH 2/3] ASoC: dt-bindings: fsl_easrc: Add document for EASRC

2020-02-12 Thread Fabio Estevam
On Wed, Feb 12, 2020 at 1:35 AM Shengjiu Wang wrote: > > EASRC (Enhanced Asynchronous Sample Rate Converter) is a new > IP module found on i.MX815. i.MX815 in an internal terminology. Please avoid it on the commit log. > > Signed-off-by: Shengjiu Wang > --- >

Re: [PATCH v4 1/2] ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm & imx8qxp

2019-12-02 Thread Fabio Estevam
On Mon, Dec 2, 2019 at 8:56 AM Shengjiu Wang wrote: > - - compatible : Contains "fsl,imx35-asrc" or "fsl,imx53-asrc". > + - compatible : Contains "fsl,imx35-asrc", "fsl,imx53-asrc", > + "fsl,imx8qm-asrc", "fsl,imx8qxp-asrc" You missed the word "or" as

Re: [PATCH] ASoC: fsl_sai: add IRQF_SHARED

2019-11-29 Thread Fabio Estevam
Hi Michael, On Thu, Nov 28, 2019 at 7:38 PM Michael Walle wrote: > > The LS1028A SoC uses the same interrupt line for adjacent SAIs. Use > IRQF_SHARED to be able to use these SAIs simultaneously. On i.MX8M SAI5 and SAI6 share the same interrupt number too: Reviewed-by: Fabio Estevam Thanks

Re: [PATCH v2 00/21] Refine memblock API

2019-09-25 Thread Fabio Estevam
On Wed, Sep 25, 2019 at 9:17 AM Adam Ford wrote: > I tried cma=256M and noticed the cma dump at the beginning didn't > change. Do we need to setup a reserved-memory node like > imx6ul-ccimx6ulsom.dtsi did? I don't think so. Were you able to identify what was the exact commit that caused such

Re: [PATCH v2 00/21] Refine memblock API

2019-09-25 Thread Fabio Estevam
Hi Adam, On Wed, Sep 25, 2019 at 6:38 AM Adam Ford wrote: > I know it's rather late, but this patch broke the Etnaviv 3D graphics > in my i.MX6Q. > > When I try to use the 3D, it returns some errors and the dmesg log > shows some memory allocation errors too: > [3.682347] etnaviv etnaviv:

Re: [PATCH] ASoC: fsl_ssi: Fix clock control issue in master mode

2019-08-28 Thread Fabio Estevam
Hi Shengjiu, On Wed, Aug 28, 2019 at 2:21 AM Shengjiu Wang wrote: > > The test case is > arecord -Dhw:0 -d 10 -f S16_LE -r 48000 -c 2 temp.wav & > aplay -Dhw:0 -d 30 -f S16_LE -r 48000 -c 2 test.wav > > There will be error after end of arecord: > aplay: pcm_write:2051: write error: Input/output

Re: [PATCH 1/2] ASoC: mpc5200_dma: Fix invalid license ID

2019-04-14 Thread Fabio Estevam
On Sun, Apr 14, 2019 at 4:15 PM Andra Danciu wrote: > > As the file had no other license notice/reference, it falls under the > project license and therefore the proper SPDX id is: GPL-2.0-only > > Cc: Daniel Baluta > Fixes: 1edfc2485d8dc ("ASoC: mpc5200_dma: Switch to SPDX identifier") >

Re: [PATCH v4 3/4] ASoC: imx-audmix: fix object reference leaks in probe

2019-04-10 Thread Fabio Estevam
On Wed, Apr 10, 2019 at 8:06 AM Viorel Suman wrote: > > Release the reference to the underlying device taken > by of_find_device_by_node() call. > > Signed-off-by: Viorel Suman > Reported-by: Julia Lawall > Acked-by: Nicolin Chen Please provide a Fixes tag.

Re: [PATCH v4 2/4] ASoC: fsl_audmix: remove "model" attribute from DT document

2019-04-10 Thread Fabio Estevam
On Wed, Apr 10, 2019 at 8:06 AM Viorel Suman wrote: > > Remove "model" attribute from fsl_audmix DT document. Please provide the reasoning.

Re: [PATCH 02/20] ASoC: efika-audio-fabric.c: Switch to SPDX identifier

2019-04-05 Thread Fabio Estevam
On Fri, Apr 5, 2019 at 10:24 AM Mukesh Ojha wrote: > you mean all lines to start with //, does not it look to noisy to eyes ? Mark Brown's recommendation is to use // in all the initial block lines instead of only in the SPDX one.

Re: [PATCH 02/20] ASoC: efika-audio-fabric.c: Switch to SPDX identifier

2019-04-05 Thread Fabio Estevam
On Fri, Apr 5, 2019 at 9:47 AM Mukesh Ojha wrote: > Don't change entire thing with //. only above line with the license is > enough. > > Please apply this rule every patch of yours. Not really. This is the style preferred in this subsystem.

Re: [PATCH] ASoC: imx-pcm: Switch to SPDX identifier

2019-04-04 Thread Fabio Estevam
On Thu, Apr 4, 2019 at 9:07 AM Andra Danciu wrote: > > Adopt the SPDX license identifier headers to ease license compliance > management. > > Signed-off-by: Andra Danciu > --- > sound/soc/fsl/imx-pcm.h | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git

Re: [PATCH] ASoC: fsl_esai: fix channel swap issue when stream starts

2019-02-21 Thread Fabio Estevam
stable. > Signed-off-by: Shengjiu Wang Reviewed-by: Fabio Estevam Thanks

Re: [PATCH] ASoC: fsl_esai: fix register setting issue in RIGHT_J mode

2019-02-16 Thread Fabio Estevam
Hi Shengjiu, On Fri, Feb 15, 2019 at 9:04 AM S.j. Wang wrote: > > The ESAI_xCR_xWA is xCR's bit, not the xCCR's bit, driver set it to > wrong register, correct it. > > Signed-off-by: Shengjiu Wang Reviewed-by: Fabio Estevam Please add a Fixes tag and Cc stable. Also, it

Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: Change to use DEFINE_SHOW_ATTRIBUTE macro

2018-11-07 Thread Fabio Estevam
On Wed, Nov 7, 2018 at 4:57 PM Yangtao Li wrote: > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li Reviewed-by: Fabio Estevam

[PATCH] powerpc: cpm_gpio: Remove owner assignment from platform_driver

2018-05-04 Thread Fabio Estevam
From: Fabio Estevam <fabio.este...@nxp.com> Structure platform_driver does not need to set the owner field, as this will be populated by the driver core. Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> ---

Re: [alsa-devel] [PATCH] ASoC: fsl_esai: Fix divisor calculation failure at lower ratio

2018-04-10 Thread Fabio Estevam
> > Signed-off-by: Nicolin Chen <nicoleots...@gmail.com> > Cc: Marek Vasut <ma...@denx.de> Thanks for the fix: Reviewed-by: Fabio Estevam <fabio.este...@nxp.com>

Re: [alsa-devel] [PATCH] ASoC: fsl_esai: Fix divisor calculation failure at lower ratio

2018-04-08 Thread Fabio Estevam
Hi Nicolin, On Sun, Apr 8, 2018 at 8:57 PM, Nicolin Chen wrote: > When the desired ratio is less than 256, the savesub (tolerance) > in the calculation would become 0. This will then fail the loop- > search immediately without reporting any errors. > > But if the ratio is

Re: [alsa-devel] [PATCH] ASoC: fsl_esai: Add freq check in set_dai_sysclk()

2018-04-08 Thread Fabio Estevam
t; > So this patch adds a check to fix it. > > Signed-off-by: Nicolin Chen <nicoleots...@gmail.com> Reviewed-by: Fabio Estevam <fabio.este...@nxp.com>

[PATCH] soc/fsl/guts: Add a NULL check for devm_kasprintf()

2018-01-06 Thread Fabio Estevam
From: Fabio Estevam <fabio.este...@nxp.com> devm_kasprintf() may fail, so we should better add a NULL check and propagate an error on failure. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- drivers/soc/fsl/guts.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a

Re: [PATCH] powerpc/40x: acadia: Fix the 'interrupt-parent' property

2017-12-04 Thread Fabio Estevam
Hi Michael, On Mon, Dec 4, 2017 at 2:45 AM, Michael Ellerman wrote: > Will pick it up for 4.16. Just realized that there is already a fix for this in linux-next: commit 3d2d4339cc326c427638daa67e264dd455ee1899 Author: Geert Uytterhoeven Date:

Re: [PATCH] powerpc/40x: acadia: Fix the 'interrupt-parent' property

2017-12-01 Thread Fabio Estevam
Hi Michael, On Tue, Oct 17, 2017 at 11:01 AM, Fabio Estevam <fabio.este...@nxp.com> wrote: > 'interrupts-parent' property does not exist. Fix the typo. > > Fixes: 00f3ca740a9c26 ("powerpc/40x: AMCC PowerPC 405EZ Acadia DTS") > Signed-off-by: Fabio Estevam <fabio

[PATCH] powerpc/40x: acadia: Fix the 'interrupt-parent' property

2017-10-17 Thread Fabio Estevam
'interrupts-parent' property does not exist. Fix the typo. Fixes: 00f3ca740a9c26 ("powerpc/40x: AMCC PowerPC 405EZ Acadia DTS") Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- arch/powerpc/boot/dts/acadia.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq

2017-09-05 Thread Fabio Estevam
On Tue, Sep 5, 2017 at 6:13 PM, Łukasz Majewski wrote: > { > clock-frequency = <40>; > pinctrl-names = "default"; > pinctrl-0 = <_i2c1>; > status = "okay"; > > codec: tfa9879@6C { > #sound-dai-cells = <0>; >

Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq

2017-09-05 Thread Fabio Estevam
Hi Lukasz, On Tue, Sep 5, 2017 at 5:35 AM, Łukasz Majewski wrote: > Note: > [*] - I could workaround this problem by setting: > > system-clock-frequency = <0> in > > dailink_master: cpu { > sound-dai = <>; >

Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq

2017-09-03 Thread Fabio Estevam
ch just quits early if it detects change, which don't need to be > done. Thanks for the clarification. Reviewed-by: Fabio Estevam <fabio.este...@nxp.com>

Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq

2017-09-03 Thread Fabio Estevam
s properly taking care of the clock restriction? From: Lukasz Majewski <lu...@denx.de> Sent: Sunday, September 3, 2017 8:05:01 AM To: Timur Tabi; Nicolin Chen; Xiubo Li; Fabio Estevam; Liam Girdwood; Mark Brown; Jaroslav Kysela; Takashi Iwai Cc: alsa-de...@al

Re: [alsa-devel] [PATCH v3] ASoC: fsl_dma: remove dma_object path member

2017-08-29 Thread Fabio Estevam
On Tue, Aug 29, 2017 at 9:37 AM, Rob Herring <r...@kernel.org> wrote: > dma_object.path is unused, so rather than fix it to work with DT > full_name changes, just remove it. > > Signed-off-by: Rob Herring <r...@kernel.org> Reviewed-by: Fabio Estevam <fabio.este...@nxp.com>

Re: [PATCH] fsl/fman: add dependency on HAS_DMA

2017-06-26 Thread Fabio Estevam
On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur wrote: > A previous commit inserted a dependency on DMA API that requires > HAS_DMA to be added in Kconfig. It would be nice to specify the commit that caused this.

Re: [alsa-devel] [PATCH 1/1] ASoC: fsl_asrc: use dma_transfer_direction enum when calling dmaengine_prep_dma_cyclic

2017-01-15 Thread Fabio Estevam
dma_data_direction enum, which is the type expected by > dmaengine_prep_dma_cyclic(). > > Replace DMA_TO_DEVICE with DMA_MEM_TO_DEV and DMA_FROM_DEVICE with > DMA_DEV_TO_MEM to fix this type mismatch issue. > > Signed-off-by: Nicolas Iooss <nicolas.iooss_li...@m4x.org&g

Re: [alsa-devel] [PATCH] fsl_ssi: set fifo watermark to more reliable value

2017-01-03 Thread Fabio Estevam
optimized on the older > chips too, but I have not tested. > > Signed-off-by: Caleb Crome <ca...@crome.org> Reviewed-by: Fabio Estevam <fabio.este...@nxp.com>

Re: [alsa-devel] [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode

2016-12-28 Thread Fabio Estevam
On Wed, Dec 28, 2016 at 9:06 AM, Harisangam, Sharvari (S.) wrote: > Corrected the condition to check if ssi is configured for AC97 > mode. Other modes like dsp_a also satisfy the ANDing condition. > > Signed-off-by: Sharvari Harisangam

Re: [alsa-devel] Setting some clocks back to DUMMY fixes spdif output on imx6q wandboard rev B1

2016-08-31 Thread Fabio Estevam
On Wed, Aug 31, 2016 at 2:49 PM, Xavi Drudis Ferran wrote: > Thank you amd feel free to suggest more tests, but it is good enough > as it is for me. Ok, thanks for trying. So let's keep the SPDIF parent clock as is.

Re: [alsa-devel] Setting some clocks back to DUMMY fixes spdif output on imx6q wandboard rev B1

2016-08-31 Thread Fabio Estevam
Hi Xavi, On Wed, Aug 31, 2016 at 10:47 AM, Xavi Drudis Ferran wrote: > If it's easy for you to send it yourself, I would prefer so and I'm > grateful. If not, it'll be an exercise for me, no problem. I have just submitted the patch with you on Cc. If you could reply to it

Re: [alsa-devel] Setting some clocks back to DUMMY fixes spdif output on imx6q wandboard rev B1

2016-08-31 Thread Fabio Estevam
Xavi, On Wed, Aug 31, 2016 at 10:11 AM, Fabio Estevam <feste...@gmail.com> wrote: > Xavi, > > Care to send a formal patch with your change? If you prefer, I can send this change to the ARM kernel mailing list. Please let me know what you prefer. Thanks

Re: [alsa-devel] Setting some clocks back to DUMMY fixes spdif output on imx6q wandboard rev B1

2016-08-31 Thread Fabio Estevam
-- a/drivers/clk/imx/clk-imx6q.c +++ b/drivers/clk/imx/clk-imx6q.c @@ -623,7 +623,7 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node) pr_warn("failed to set up CLKO: %d\n", ret); /* Audio-related clocks configuration */ - clk_set_parent(clk[IMX6QDL_CLK_SPDIF_SEL], clk[IMX6QDL_CLK_PLL3_PFD3_454M]); + clk_set_parent(clk[IMX6QDL_CLK_SPDIF_SEL], clk[IMX6QDL_CLK_PLL4_AUDIO_DIV]); /* All existing boards with PCIe use LVDS1 */ if (IS_ENABLED(CONFIG_PCI_IMX6)) Regards, Fabio Estevam

Re: [PATCH 0/2] Support non-ssi cpu-dai for sgtl5000

2016-08-29 Thread Fabio Estevam
On Mon, Aug 29, 2016 at 7:51 AM, Winter Wang wrote: > These patches support sgtl5000 to be attached to other non-ssi cpu-dais like > SAI. Do we really need this? We can use SAI with sgtl5000 just fine via simple card. Take a look at:

Re: [alsa-devel] [PATCH v2 1/1] ASoC: fsl_ssi: add CCSR_SSI_SOR to volatile register list

2016-04-28 Thread Fabio Estevam
s that > require the channels to be in the right slots. > > Signed-off-by: Caleb Crome <ca...@crome.org> > Suggested-by: Arnaud Mouiche <arnaud.moui...@invoxia.com> Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> ___ Li

Re: [PATCH] ASoC: fsl_ssi: remove explicit register defaults

2016-02-01 Thread Fabio Estevam
On Mon, Feb 1, 2016 at 7:30 PM, Maciej S. Szmigiero wrote: > So can regcache initialization be changed to use register by register read > in case raw read fails? > > Since other option for drivers like SSI which are memory mapped and > don't offer ability to reset

Re: [PATCH] ASoC: fsl_ssi: remove explicit register defaults

2016-02-01 Thread Fabio Estevam
Hi Maciej, On Mon, Jan 18, 2016 at 5:07 PM, Maciej S. Szmigiero wrote: > There is no guarantee that on fsl_ssi module load > SSI registers will have their power-on-reset values. > > In fact, if the driver is reloaded the values in > registers will be whatever they

Re: [PATCH] ASoC: fsl_ssi: remove explicit register defaults

2016-02-01 Thread Fabio Estevam
Hi Maciej, On Mon, Feb 1, 2016 at 10:07 AM, Maciej S. Szmigiero wrote: > Is regmap patch from > http://www.spinics.net/lists/kernel/msg2161934.html > applied to the tested tree? Yes, linux-next 20160201 contains this patch.

Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults

2016-01-18 Thread Fabio Estevam
not give me any warnings: Tested-by: Fabio Estevam <fabio.este...@nxp.com> ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] ASoC: fsl_ssi: remove explicit register defaults

2016-01-18 Thread Fabio Estevam
gt; This fixes hard lockup on fsl_ssi module reload, > at least in AC'97 mode. > > Fixes: 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support > MEGA Fast") > > Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Tested-by: Fabio Estevam

Re: [alsa-devel] [PATCH 2/2] ASoC: fsl: select SND_SOC_FSL_SAI or SND_SOC_FSL_SSI depending on SoC type

2016-01-13 Thread Fabio Estevam
On Tue, Jan 12, 2016 at 4:13 PM, Lothar Waßmann wrote: > diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig > index 14dfdee..c128823 100644 > --- a/sound/soc/fsl/Kconfig > +++ b/sound/soc/fsl/Kconfig > @@ -258,7 +258,8 @@ config SND_SOC_IMX_SGTL5000 >

Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults

2016-01-11 Thread Fabio Estevam
Hi Maciej, On Sun, Dec 20, 2015 at 6:33 PM, Maciej S. Szmigiero wrote: > There is no guarantee that on fsl_ssi module load > SSI registers will have their power-on-reset values. > > In fact, if the driver is reloaded the values in > registers will be whatever they

Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults

2016-01-11 Thread Fabio Estevam
On Mon, Jan 11, 2016 at 10:04 AM, Fabio Estevam <feste...@gmail.com> wrote: > This patch causes the following issue in linux-next: > > [2.526984] [ cut here ] > [2.531632] WARNING: CPU: 1 PID: 1 at kernel/locking/lockdep.c:2755 > lockdep_t

Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults

2016-01-11 Thread Fabio Estevam
Hi Maciej, On Mon, Jan 11, 2016 at 11:57 AM, Maciej S. Szmigiero <m...@maciej.szmigiero.name> wrote: > Hi Fabio, > This will disable register cache so it isn't right. > Could you try REGCACHE_FLAT instead, please? Yes, with REGCACHE_FLAT I don't get the warning. Regards,

Re: [alsa-devel] [PATCH 1/3] ASoC: fsl_ssi: mark SACNT register volatile

2016-01-05 Thread Fabio Estevam
Timur, On Thu, Dec 24, 2015 at 2:12 PM, Timur Tabi wrote: > On Sun, Dec 20, 2015 at 2:30 PM, Maciej S. Szmigiero > wrote: >> SACNT register should be marked volatile since >> its WR and RD bits are cleared by SSI after >> completing the relevant

Re: [PATCH 2/3] ASoC: fsl_ssi: mark some registers precious

2015-12-23 Thread Fabio Estevam
On Sun, Dec 20, 2015 at 6:31 PM, Maciej S. Szmigiero <m...@maciej.szmigiero.name> wrote: > Mark some registers precious since their > reads have side effects (like clearing flags). > > Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Reviewed-by: F

Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults

2015-12-23 Thread Fabio Estevam
hatever they were set to previously. > > This fixes hard lockup on fsl_ssi module reload, > at least in AC'97 mode. > > Fixes: 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support > MEGA Fast") > > Signed-off-by: Maciej S. Szmigiero <m...@maci

Re: [PATCH 1/3] ASoC: fsl_ssi: mark SACNT register volatile

2015-12-23 Thread Fabio Estevam
xes: 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support > MEGA Fast") > > Signed-off-by: Maciej S. Szmigiero <m...@maciej.szmigiero.name> Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> ___ Linuxp

Re: [PATCH 1/6] ASoC: fsl_ssi: enable IPG clock during AC'97 reg access

2015-07-30 Thread Fabio Estevam
Hi Maciej, On Thu, Jul 30, 2015 at 11:33 AM, Maciej S. Szmigiero m...@maciej.szmigiero.name wrote: static unsigned short fsl_ssi_ac97_read(struct snd_ac97 *ac97, @@ -1151,6 +1160,14 @@ static unsigned short fsl_ssi_ac97_read(struct snd_ac97 *ac97, unsigned short val = -1;

Re: [alsa-devel] [PATCH 1/3] ASoC: fsl_esai: Add driver suspend and resume to support MEGA Fast

2015-07-06 Thread Fabio Estevam
On Mon, Jul 6, 2015 at 6:50 AM, Zidan Wang zidan.w...@freescale.com wrote: For i.MX6 SoloX, there is a mode of the SoC to shutdown all power source of modules during system suspend and resume procedure. Thus, SAI needs to save You meant ESAI, not SAI.

Re: [alsa-devel] [PATCH 2/3] ASoC: fsl_spdif: Add driver suspend and resume to support MEGA Fast

2015-07-06 Thread Fabio Estevam
On Mon, Jul 6, 2015 at 6:50 AM, Zidan Wang zidan.w...@freescale.com wrote: For i.MX6 SoloX, there is a mode of the SoC to shutdown all power source of modules during system suspend and resume procedure. Thus, SAI needs to save s/SAI/SPDIF ___

Re: [PATCH] ASoC: fsl_ssi: fix AC'97 mode

2015-06-27 Thread Fabio Estevam
Hi Maciej, On Sat, Jun 27, 2015 at 7:51 PM, Maciej S. Szmigiero m...@maciej.szmigiero.name wrote: Currently the AC'97 mode in fsl_ssi driver isn't functional. Thanks for the fix. I look forward to test it on my udoo board. This patch implements the following changes to make it work properly:

Re: [PATCH] ASoC: fsl_ssi: fix AC'97 mode

2015-06-27 Thread Fabio Estevam
On Sat, Jun 27, 2015 at 7:51 PM, Maciej S. Szmigiero m...@maciej.szmigiero.name wrote: + + ret = clk_prepare_enable(fsl_ac97_data-clk); + if (ret) { + pr_err(ac97 read clk_prepare_enable failed: %d\n, + ret); + return -1;

Re: [alsa-devel] [PATCH] ASoC: fsl_spdif: Don't try to round-up for clock divisor calculation

2015-05-25 Thread Fabio Estevam
though this change seems to make sense. I currently don't have access to a SPDIF receiver to test it. Regards, Fabio Estevam ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH 0/3] Add master mode, tmd and right-j mode support

2015-01-20 Thread Fabio Estevam
Hi Zidan, On Tue, Jan 20, 2015 at 10:21 AM, Zidan Wang zidan.w...@freescale.com wrote: Add sai master mode support. Add tdm slots support. Add Right-J mode support. Zidan Wang (3): SoC: fsl_sai: add sai master mode support ASoC: fsl_sai: Add support for tdm slots operation ASoC:

Re: PROBLEM: USB isochronous urb leak on EHCI driver

2015-01-05 Thread Fabio Estevam
On Mon, Jan 5, 2015 at 1:12 PM, Michael Tessier michael.tess...@axiontech.ca wrote: If sound is ok when using only 1 codec and becomes choppy when adding a second codec, then it means that this issue is still in the 3.x kernel. This answer will tell me if it is worth working on using a newer

Re: PROBLEM: USB isochronous urb leak on EHCI driver

2014-12-15 Thread Fabio Estevam
need this patch: http://www.spinics.net/lists/arm-kernel/msg385739.html Regards, Fabio Estevam ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping()

2014-12-01 Thread Fabio Estevam
On Mon, Dec 1, 2014 at 6:30 PM, Lars-Peter Clausen l...@metafoo.de wrote: On 12/01/2014 09:11 PM, Timur Tabi wrote: On 12/01/2014 02:01 PM, Arnd Bergmann wrote: Does this mean that fsl_ssi.c should not be calling irq_of_parse_and_map? How else should it get the IRQ? platform_get_irq()

Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping()

2014-12-01 Thread Fabio Estevam
On Mon, Dec 1, 2014 at 6:42 PM, Timur Tabi ti...@tabi.org wrote: Would the mapping continue to exist after the driver is unloaded? Can you try multiple loads/unloads and see if interrupts still work? I tried multiple loads/unloads and audio works fine with those changes. About the ssi irq we

Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: Set default slot number for common cases

2014-01-09 Thread Fabio Estevam
() any more. +*/ Incorrect style for multi-line comment. Regards, Fabio Estevam ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: Set default slot number for common cases

2014-01-09 Thread Fabio Estevam
/ the preferred style', so I thought it shouldn't be quite bother. Yes, net and drivers/net are different and checkpatch reports it accordingly. Regards, Fabio Estevam ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org

Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: Fixed wrong printf format identifier

2014-01-07 Thread Fabio Estevam
fengguang...@intel.com Signed-off-by: Alexander Shiyan shc_w...@mail.ru I have sent the same fix as well as I haven't seen your patch before I submitted mine. It is usually a good idea to specify in the commit log what was the commit that caused the warning. Regards, Fabio Estevam

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-13 Thread Fabio Estevam
On Mon, Aug 12, 2013 at 9:01 AM, Nicolin Chen b42...@freescale.com wrote: +Required properties: + + - compatible : Compatible list, contains fsl,chip-spdif. Using general Can't we just use fsl,fsl-spdif instead? + fsl,fsl-spdif will get the default SoC type -- imx6q-spdif. + I think this

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-13 Thread Fabio Estevam
On Tue, Aug 13, 2013 at 2:58 PM, Fabio Estevam feste...@gmail.com wrote: On Mon, Aug 12, 2013 at 9:01 AM, Nicolin Chen b42...@freescale.com wrote: +Required properties: + + - compatible : Compatible list, contains fsl,chip-spdif. Using general Can't we just use fsl,fsl-spdif instead

Re: [PATCH 2/2] of: use platform_device_add

2013-02-17 Thread Fabio Estevam
On Sun, Feb 17, 2013 at 4:43 AM, Shawn Guo shawn@linaro.org wrote: On Sun, Feb 17, 2013 at 11:03:35AM +0800, Shawn Guo wrote: On Fri, Jan 18, 2013 at 01:40:00AM +, Grant Likely wrote: This allows platform_device_add a chance to call insert_resource on all of the resources from OF. At

Re: [PATCH v6 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Fabio Estevam
On Thu, Jan 17, 2013 at 8:01 AM, Peter Chen peter.c...@freescale.com wrote: /* make sure USB_CLK is running at 60 MHz +/- 1000 Hz */ - if (!cpu_is_mx51()) { + if (!strcmp(pdev-id_entry-name, imx-udc-mx27)) {]] Shouldn't this be: if (!strcmp(pdev-id_entry-name,

Re: [PATCH v6 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Fabio Estevam
On Thu, Jan 17, 2013 at 9:25 AM, Lothar Waßmann l...@karo-electronics.de wrote: The equivalent of !cpu_is_mx51() would be strcmp(pdev-id_entry-name, imx-udc-mx51) (without the '!') meaning id_entry-name is different from imx-udc-mx51. Yes, agree. strcmp(pdev-id_entry-name, imx-udc-mx51) is

Re: [PATCH v2] usb: fsl_udc: errata - postpone freeing current dTD

2012-06-12 Thread Fabio Estevam
this further, not because of a bug - but a flu. Hope you get better soon. Regards, Fabio Estevam ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2] usb: fsl_udc: errata - postpone freeing current dTD

2012-06-10 Thread Fabio Estevam
Hi Christoph, On Mon, Jun 4, 2012 at 8:37 AM, Christoph Fritz chf.fr...@googlemail.com wrote: After that, I stumbled upon this dmesg: Freescale High-Speed USB SOC Device Controller driver (Apr 20, 2007) fsl-usb2-udc fsl-usb2-udc: clk_get(usb) failed fsl-usb2-udc: probe of fsl-usb2-udc