Re: [PATCH RFC v11 5/6] dma: mpc512x: add device tree binding document

2014-04-22 Thread Gerhard Sittig
On Fri, 2014-04-18 at 15:29 +0400, Alexander Popov wrote: 2014-04-17 0:44 GMT+04:00 Gerhard Sittig g...@denx.de: On Tue, 2014-04-15 at 14:54 +0400, Alexander Popov wrote: +- reg: Address and size of the DMA controller's register set +- interrupts: Interrupt for the DMA controller

Re: [PATCH RFC v11 5/6] dma: mpc512x: add device tree binding document

2014-04-16 Thread Gerhard Sittig
On Tue, 2014-04-15 at 14:54 +0400, Alexander Popov wrote: Introduce a device tree binding document for the MPC512x DMA controller Signed-off-by: Gerhard Sittig g...@denx.de Signed-off-by: Alexander Popov a13xp0p0...@gmail.com I'm not certain whether the attribution is right. Is the S-o-b

Re: cscope: issue with symlinks in tools/testing/selftests/powerpc/copyloops/

2014-04-08 Thread Gerhard Sittig
[ removed cscope-devel from Cc:, non-subscriber mails get blocked anyway ] On Mon, 2014-04-07 at 14:42 +0200, Gerhard Sittig wrote: On Mon, 2014-04-07 at 06:42 -0400, Neil Horman wrote: On Thu, Apr 03, 2014 at 03:16:15PM +0200, Yann Droneaud wrote: [ ... ] cscope reports

Re: cscope: issue with symlinks in tools/testing/selftests/powerpc/copyloops/

2014-04-07 Thread Gerhard Sittig
those filesystem entries. Would it be useful to not emit the warnings then? Or to silent those warnings when the user knows it's perfectly legal to skip those filesytem entries? Like what you can do with the ctags(1) command and its --links option. virtually yours Gerhard Sittig -- DENX Software

Re: [PATCH 2/3] dts: mpc512x: adjust clock specs for FEC nodes

2014-03-05 Thread Gerhard Sittig
On Wed, Mar 05, 2014 at 09:48 +0800, Shawn Guo wrote: On Mon, Mar 03, 2014 at 10:22:31AM +0100, Gerhard Sittig wrote: On Mon, Feb 24, 2014 at 11:25 +0100, Gerhard Sittig wrote: a recent FEC binding document update that was motivated by i.MX development revealed that ARM and PowerPC

Re: [PATCH 2/3] dts: mpc512x: adjust clock specs for FEC nodes

2014-03-03 Thread Gerhard Sittig
On Mon, Feb 24, 2014 at 11:25 +0100, Gerhard Sittig wrote: a recent FEC binding document update that was motivated by i.MX development revealed that ARM and PowerPC implementations in Linux did not agree on the clock names to use for the FEC nodes change clock names from per to ipg

[PATCH 1/3] fs_enet: update clock names to comply with FEC binding

2014-02-24 Thread Gerhard Sittig
compatibility with former device trees Signed-off-by: Gerhard Sittig g...@denx.de --- drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net

[PATCH 2/3] dts: mpc512x: adjust clock specs for FEC nodes

2014-02-24 Thread Gerhard Sittig
, the MPC512x CCF support provides full backwards compability, and keeps operating with device trees which lack clock specs or don't match in the names Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/boot/dts/mpc5121.dtsi |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 3/3] dt/bindings: fsl-fec: add per to clock properties

2014-02-24 Thread Gerhard Sittig
for ipg Signed-off-by: Gerhard Sittig g...@denx.de --- this patch depends on dt/bindings: fsl-fec: add clock properties by Shawn Guo which introduces the context of this patch the patch only is necessary if the MPC5121 .dtsi update (switch FEC nodes from per to ipg) won't make it for v3.14

Re: [PATCH RFC v7 1/6] dma: mpc512x: reorder mpc8308 specific instructions

2014-02-12 Thread Gerhard Sittig
improvement and straight forward, it can be taken regardless of the remainder of the series. (I guess this formerly stated judgement is what made Alexander derive Acked-By tags from.) virtually yours Gerhard Sittig -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235

Re: [PATCH RFC v7 2/6] dma: mpc512x: add support for peripheral transfers

2014-02-12 Thread Gerhard Sittig
; + +err_prep: + /* Put the descriptor back */ + spin_lock_irqsave(mchan-lock, iflags); + list_add_tail(mdesc-node, mchan-free); + spin_unlock_irqrestore(mchan-lock, iflags); + + return NULL; +} virtually yours Gerhard Sittig -- DENX Software Engineering GmbH, MD

Re: [PATCH RFC v7 4/6] dma: mpc512x: add device tree binding document

2014-02-12 Thread Gerhard Sittig
On Wed, Feb 12, 2014 at 17:25 +0400, Alexander Popov wrote: From: Gerhard Sittig g...@denx.de introduce a device tree binding document for the MPC512x DMA controller Signed-off-by: Gerhard Sittig g...@denx.de [ a13xp0p0...@gmail.com: turn this into a separate patch ] As stated

Re: [PATCH RFC v7 6/6] HACK mmc: mxcmmc: enable clocks for the MPC512x

2014-02-12 Thread Gerhard Sittig
COMMON_CLK support. virtually yours Gerhard Sittig -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de

Re: [PATCH RFC v7 0/6] MPC512x DMA slave s/g support, OF DMA lookup

2014-02-12 Thread Gerhard Sittig
(they already are drinking from the firehose). DT reviewers are foremost interested in bindings and policy and remaining OS agnostic, and leave mechanical .dts file updates to subsystem maintainers. virtually yours Gerhard Sittig -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel

Re: Please pull 'next' branch of 5xxx tree

2014-01-29 Thread Gerhard Sittig
and sched_getattr syscalls and everything looks good. Thank you! virtually yours Gerhard Sittig -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off

Re: [PATCH RFC v6 4/5] dma: mpc512x: register for device tree channel lookup

2014-01-16 Thread Gerhard Sittig
On Mon, Jan 13, 2014 at 12:17 +0400, Alexander Popov wrote: Thanks for your replies, Gerhard and Vinod. 2014/1/9 Vinod Koul vinod.k...@intel.com: On Wed, Jan 08, 2014 at 05:47:19PM +0100, Gerhard Sittig wrote: [ what is the semantics of DMA_PRIVATE capability flag? is documentation

Re: [PATCH RFC v6 4/5] dma: mpc512x: register for device tree channel lookup

2014-01-08 Thread Gerhard Sittig
Gerhard. Thanks for your review. 2013/12/26 Gerhard Sittig g...@denx.de: [ dropping devicetree, we're DMA specific here ] On Tue, Dec 24, 2013 at 16:06 +0400, Alexander Popov wrote: --- a/drivers/dma/mpc512x_dma.c +++ b/drivers/dma/mpc512x_dma.c [ ... ] @@ -950,6 +951,7 @@ static

Re: [PATCH RFC v6 4/5] dma: mpc512x: register for device tree channel lookup

2013-12-26 Thread Gerhard Sittig
. virtually yours Gerhard Sittig -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de

Re: [PATCH RFC v6 4/5] dma: mpc512x: register for device tree channel lookup

2013-12-26 Thread Gerhard Sittig
when looking for channels that can do mem-to-mem transfers). Please reason about this change some more, and explain what it does and why it's needed. Consider the fact that this driver handles both MPC5121 as well as MPC8308 hardware. virtually yours Gerhard Sittig -- DENX Software Engineering

Re: [PATCH] powerpc/512x: dts: disable MPC5125 usb module

2013-12-19 Thread Gerhard Sittig
in maintainability or completeness of information. So I suggest to pick your USB1 disabling for -next and 3.14 now, and to address the DTS cleanup and sharing later. virtually yours Gerhard Sittig -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr. 5

Re: [PATCH v1 0/4] powerpc/512x: update COMMON_CLK support for MPC5125

2013-12-12 Thread Gerhard Sittig
On Thu, Dec 12, 2013 at 17:12 +0100, Matteo Facchinetti wrote: On 10/12/2013 14:11, Gerhard Sittig wrote: this series improves the previously introduced common clock support for MPC512x such that SoC variants 5123 and 5125 get addressed appropriately (MPC5125 turned out to be rather

[PATCH v1 1/1] powerpc/512x: dts: remove misplaced IRQ spec from 'soc' node (5125)

2013-12-10 Thread Gerhard Sittig
-by: Gerhard Sittig g...@denx.de --- note that this is not a resend of the previous MPC5121 fix, but instead is a fix for MPC5125 along the same lines of the MPC5121 fix --- arch/powerpc/boot/dts/mpc5125twr.dts |1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/boot/dts

Re: [PATCH v1 1/1] powerpc/512x: dts: remove misplaced IRQ spec from 'soc' node

2013-12-10 Thread Gerhard Sittig
[ Cc: to Matteo as well ] On Tue, Dec 03, 2013 at 15:04 +0100, Anatolij Gustschin wrote: On Tue, 3 Dec 2013 11:56:52 +0100 Gerhard Sittig g...@denx.de wrote: the 'soc' node in the common .dtsi for MPC5121 has an '#interrupt-cells' property although this node is not an interrupt

Re: [PATCH v1 1/1] powerpc/512x: dts: remove misplaced IRQ spec from 'soc' node

2013-12-10 Thread Gerhard Sittig
On Tue, Dec 10, 2013 at 11:05 +0100, Gerhard Sittig wrote: FYI: I only noticed yesterday that MPC5125 suffers from the same issue, have sent 1386669068-2477-1-git-send-email-...@denx.de to fix that as well. Both patches may get squashed when going upstream. Don't have a dump at hand

Re: [PATCH v6 00/17] add COMMON_CLK support for PowerPC MPC512x

2013-12-10 Thread Gerhard Sittig
[ trimmed Cc: list to PowerPC and CCF ] On Sat, Nov 30, 2013 at 23:51 +0100, Gerhard Sittig wrote: this series introduces support for the common clock framework (CCF, COMMON_CLK Kconfig option) in the PowerPC based MPC512x platform, which brings device tree based clock lookup as well

[PATCH v1 2/4] powerpc/512x: clk: enforce even SDHC divider values

2013-12-10 Thread Gerhard Sittig
an excessive divider table) and satisfies the hardware's constraint of only supporting even divider values Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/platforms/512x/clock-commonclk.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/arch

[PATCH v1 4/4] powerpc/512x: dts: add MPC5125 clock specs

2013-12-10 Thread Gerhard Sittig
add clock related specs to the MPC5125 tower board DTS - add clock providers (crystal/oscillator, clock control module) - add consumers (the CAN, SDHC, I2C, DIU, FEC, USB, PSC peripherals) Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/boot/dts/mpc5125twr.dts | 53

[PATCH v1 3/4] powerpc/512x: clk: support MPC5121/5123/5125 SoC variants

2013-12-10 Thread Gerhard Sittig
and low periods of the clock) is not implemented, as there are no users and there is no common implementation which supports this kind of clock -- the new implementation would be unused and could not get verified, so it shall wait until there is demand Signed-off-by: Gerhard Sittig g...@denx.de

[PATCH v1 0/4] powerpc/512x: update COMMON_CLK support for MPC5125

2013-12-10 Thread Gerhard Sittig
tree as well as with a former device tree that lacks clock specs? Thank you! Setting CONFIG_COMMON_CLK_DEBUG=y in your .config and eyeballing /sys/kernel/debug/clk/clk_summary will help you. Gerhard Sittig (4): powerpc/512x: clk: minor comment updates powerpc/512x: clk: enforce even SDHC

[PATCH v1 1/4] powerpc/512x: clk: minor comment updates

2013-12-10 Thread Gerhard Sittig
adjust (expand on or move) a few comments, add markers for easier navigation around helpers Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/platforms/512x/clock-commonclk.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms

[PATCH v1 1/1] powerpc/512x: dts: remove misplaced IRQ spec from 'soc' node

2013-12-03 Thread Gerhard Sittig
-22 ... [ best viewed with 'git diff -U5' to have DT node names in the context ] Cc: Anatolij Gustschin ag...@denx.de Cc: linuxppc-dev@lists.ozlabs.org Cc: devicet...@vger.kernel.org Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/boot/dts/mpc5121.dtsi |1 - 1 file changed, 1

Re: [PATCH v6 02/17] dts: mpc512x: introduce dt-bindings/clock/ header

2013-12-02 Thread Gerhard Sittig
On Mon, Dec 02, 2013 at 09:46 +, Mark Rutland wrote: On Sat, Nov 30, 2013 at 10:51:22PM +, Gerhard Sittig wrote: introduce a dt-bindings/ header file for MPC512x clocks, providing symbolic identifiers for those SoC clocks which clients will reference from their device tree nodes

Re: [PATCH v6 08/17] spi: mpc512x: adjust to OF based clock lookup

2013-12-02 Thread Gerhard Sittig
On Mon, Dec 02, 2013 at 09:50 +, Mark Rutland wrote: On Sat, Nov 30, 2013 at 10:51:28PM +, Gerhard Sittig wrote: after device tree based clock lookup became available, the peripheral driver need no longer construct clock names which include the PSC index, remove the psc%d_mclk

[PATCH v6 01/17] powerpc/fsl-pci: improve clock API use

2013-11-30 Thread Gerhard Sittig
...@kernel.crashing.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/sysdev/fsl_pci.c | 52 + 1 file changed, 52 insertions(+) diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c index 4dfd61df8aba

[PATCH v6 02/17] dts: mpc512x: introduce dt-bindings/clock/ header

2013-11-30 Thread Gerhard Sittig
swar...@wwwdotorg.org Cc: Ian Campbell ian.campb...@citrix.com Cc: devicet...@vger.kernel.org Reviewed-by: Mike Turquette mturque...@linaro.org # for v3: w/o bdlc, PSC ipg Signed-off-by: Gerhard Sittig g...@denx.de --- include/dt-bindings/clock/mpc512x-clock.h | 69

[PATCH v6 00/17] add COMMON_CLK support for PowerPC MPC512x

2013-11-30 Thread Gerhard Sittig
directive with the removal of the clkdev registration call (13/24) initial v1 (2013-07-15) Gerhard Sittig (17): powerpc/fsl-pci: improve clock API use dts: mpc512x: introduce dt-bindings/clock/ header dts: mpc512x: add clock related device tree specs clk: mpc512x: introduce COMMON_CLK

[PATCH v6 05/17] clk: mpc512x: add backwards compat to the CCF code

2013-11-30 Thread Gerhard Sittig
Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/platforms/512x/clock-commonclk.c | 173 - 1 file changed, 172 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/512x/clock-commonclk.c b/arch/powerpc/platforms/512x/clock-commonclk.c index

[PATCH v6 04/17] clk: mpc512x: introduce COMMON_CLK for MPC512x (disabled)

2013-11-30 Thread Gerhard Sittig
and multiplier values fetched from hardware Cc: Mike Turquette mturque...@linaro.org Cc: Anatolij Gustschin ag...@denx.de Cc: linux-arm-ker...@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/platforms/512x/Makefile |4 +- arch

[PATCH v6 03/17] dts: mpc512x: add clock related device tree specs

2013-11-30 Thread Gerhard Sittig
ian.campb...@citrix.com Cc: linux-arm-ker...@lists.infradead.org Cc: devicet...@vger.kernel.org Reviewed-by: Mike Turquette mturque...@linaro.org # for v3, before osc Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/boot/dts/ac14xx.dts |7 +++ arch/powerpc/boot/dts/mpc5121.dtsi

[PATCH v6 06/17] dts: mpc512x: add clock specs for client lookups

2013-11-30 Thread Gerhard Sittig
Cc: Mark Rutland mark.rutl...@arm.com Cc: Stephen Warren swar...@wwwdotorg.org Cc: Ian Campbell ian.campb...@citrix.com Cc: devicet...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Mike Turquette mturque...@linaro.org # for v3: w/o bdlc, PSC ipg Signed-off-by: Gerhard Sittig g

[PATCH v6 09/17] serial: mpc512x: adjust for OF based clock lookup

2013-11-30 Thread Gerhard Sittig
gre...@linuxfoundation.org Cc: Jiri Slaby jsl...@suse.cz Cc: linux-ser...@vger.kernel.org Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org # for v4 Signed-off-by: Gerhard Sittig g...@denx.de --- Greg, the difference since v4 of this patch is that v4 took the 'mclk' and 'ipg' clock items

[PATCH v6 10/17] serial: mpc512x: setup the PSC FIFO clock as well

2013-11-30 Thread Gerhard Sittig
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Jiri Slaby jsl...@suse.cz Cc: linux-ser...@vger.kernel.org Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org # for v4 Signed-off-by: Gerhard Sittig g...@denx.de --- Greg, the addition since v4 is the clk_get_sys() call for the 'ipg' clock

[PATCH v6 07/17] clk: mpc5xxx: switch to COMMON_CLK, retire PPC_CLOCK

2013-11-30 Thread Gerhard Sittig
Turquette mturque...@linaro.org Cc: Anatolij Gustschin ag...@denx.de Cc: linux-arm-ker...@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/Kconfig |5 - arch/powerpc/include/asm/clk_interface.h | 20 - arch

[PATCH v6 08/17] spi: mpc512x: adjust to OF based clock lookup

2013-11-30 Thread Gerhard Sittig
...@kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Gerhard Sittig g...@denx.de --- drivers/spi/spi-mpc512x-psc.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c index 9602bbd8d7ea

[PATCH v6 11/17] USB: fsl-mph-dr-of: adjust for OF based clock lookup

2013-11-30 Thread Gerhard Sittig
-by: Gerhard Sittig g...@denx.de --- drivers/usb/host/fsl-mph-dr-of.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c index abd5050a4899..9162d1b6c0a3 100644 --- a/drivers/usb/host/fsl-mph-dr-of.c

[PATCH v6 12/17] mtd: mpc5121_nfc: adjust for OF based clock lookup

2013-11-30 Thread Gerhard Sittig
-...@lists.infradead.org Signed-off-by: Gerhard Sittig g...@denx.de --- drivers/mtd/nand/mpc5121_nfc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/mpc5121_nfc.c b/drivers/mtd/nand/mpc5121_nfc.c index 439bc3896418..779e60d12f89 100644 --- a/drivers/mtd/nand

[PATCH v6 14/17] net: can: mscan: adjust to common clock support for mpc512x

2013-11-30 Thread Gerhard Sittig
: Marc Kleine-Budde m...@pengutronix.de Cc: linux-...@vger.kernel.org Signed-off-by: Gerhard Sittig g...@denx.de --- drivers/net/can/mscan/mpc5xxx_can.c | 179 +++ 1 file changed, 179 insertions(+) diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can

[PATCH v6 13/17] [media] fsl-viu: adjust for OF based clock lookup

2013-11-30 Thread Gerhard Sittig
after device tree based clock lookup became available, the VIU driver need no longer use the previous global viu_clk name, but should use the ipg clock name specific to the OF node Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-me...@vger.kernel.org Signed-off-by: Gerhard Sittig g

[PATCH v6 15/17] net: can: mscan: remove non-CCF code for MPC512x

2013-11-30 Thread Gerhard Sittig
Kleine-Budde m...@pengutronix.de Cc: linux-...@vger.kernel.org Signed-off-by: Gerhard Sittig g...@denx.de --- drivers/net/can/mscan/mpc5xxx_can.c | 141 --- 1 file changed, 141 deletions(-) diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can/mscan

[PATCH v6 17/17] clk: mpc512x: remove migration support workarounds

2013-11-30 Thread Gerhard Sittig
...@linaro.org Cc: Anatolij Gustschin ag...@denx.de Cc: linux-arm-ker...@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/platforms/512x/clock-commonclk.c | 50 - 1 file changed, 16 insertions(+), 34 deletions

Re: [PATCH v5 08/17] spi: mpc512x: adjust to OF based clock lookup

2013-11-25 Thread Gerhard Sittig
On Mon, Nov 25, 2013 at 17:30 +, Mark Brown wrote: On Mon, Nov 18, 2013 at 12:06:08AM +0100, Gerhard Sittig wrote: after device tree based clock lookup became available, the peripheral driver need no longer construct clock names which include the PSC index, remove the psc%d_mclk

Re: [PATCH v5 00/17] add COMMON_CLK support for PowerPC MPC512x

2013-11-24 Thread Gerhard Sittig
On Mon, Nov 18, 2013 at 00:06 +0100, Gerhard Sittig wrote: the series is based on v3.12, but I'll rebase against v3.13-rc1 (when available) or any other subtree upon request Now that v3.13-rc1 is out, I noticed that the series no longer applies cleanly (minor context changes and conflicts

Re: [PATCH v5 01/17] powerpc/fsl-pci: improve clock API use

2013-11-21 Thread Gerhard Sittig
apply the same workaround as 512x ] On Tue, Nov 19, 2013 at 16:41 -0600, Scott Wood wrote: On Mon, 2013-11-18 at 00:06 +0100, Gerhard Sittig wrote: make the Freescale PCI driver get, prepare and enable the PCI clock during probe(); the clock gets put upon device shutdown by the devm approach

[PATCH v5 01/17] powerpc/fsl-pci: improve clock API use

2013-11-17 Thread Gerhard Sittig
...@kernel.crashing.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/sysdev/fsl_pci.c | 52 + 1 file changed, 52 insertions(+) diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c index ccfb50ddfe38

[PATCH v5 00/17] add COMMON_CLK support for PowerPC MPC512x

2013-11-17 Thread Gerhard Sittig
a reference to the PSC FIFO clock during use instead of looking up the clock again in the uninit() routine (14/24) - remove the clkdev.h header file inclusion directive with the removal of the clkdev registration call (13/24) Gerhard Sittig (17): powerpc/fsl-pci: improve clock API use dts

[PATCH v5 02/17] dts: mpc512x: introduce dt-bindings/clock/ header

2013-11-17 Thread Gerhard Sittig
swar...@wwwdotorg.org Cc: Ian Campbell ian.campb...@citrix.com Cc: devicet...@vger.kernel.org Reviewed-by: Mike Turquette mturque...@linaro.org # for v3: w/o bdlc, PSC ipg Signed-off-by: Gerhard Sittig g...@denx.de --- include/dt-bindings/clock/mpc512x-clock.h | 69

[PATCH v5 03/17] dts: mpc512x: add clock related device tree specs

2013-11-17 Thread Gerhard Sittig
ian.campb...@citrix.com Cc: linux-arm-ker...@lists.infradead.org Cc: devicet...@vger.kernel.org Reviewed-by: Mike Turquette mturque...@linaro.org # for v3, before osc Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/boot/dts/ac14xx.dts |7 +++ arch/powerpc/boot/dts/mpc5121.dtsi

[PATCH v5 04/17] clk: mpc512x: introduce COMMON_CLK for MPC512x (disabled)

2013-11-17 Thread Gerhard Sittig
and multiplier values fetched from hardware Cc: Mike Turquette mturque...@linaro.org Cc: Anatolij Gustschin ag...@denx.de Cc: linux-arm-ker...@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/platforms/512x/Makefile |4 +- arch

[PATCH v5 05/17] clk: mpc512x: add backwards compat to the CCF code

2013-11-17 Thread Gerhard Sittig
Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/platforms/512x/clock-commonclk.c | 173 - 1 file changed, 172 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/512x/clock-commonclk.c b/arch/powerpc/platforms/512x/clock-commonclk.c index

[PATCH v5 06/17] dts: mpc512x: add clock specs for client lookups

2013-11-17 Thread Gerhard Sittig
Cc: Mark Rutland mark.rutl...@arm.com Cc: Stephen Warren swar...@wwwdotorg.org Cc: Ian Campbell ian.campb...@citrix.com Cc: devicet...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Mike Turquette mturque...@linaro.org # for v3: w/o bdlc, PSC ipg Signed-off-by: Gerhard Sittig g

[PATCH v5 07/17] clk: mpc5xxx: switch to COMMON_CLK, retire PPC_CLOCK

2013-11-17 Thread Gerhard Sittig
: Anatolij Gustschin ag...@denx.de Cc: linux-arm-ker...@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/Kconfig |5 - arch/powerpc/kernel/Makefile |1 - arch/powerpc/kernel/clock.c | 82 arch

[PATCH v5 08/17] spi: mpc512x: adjust to OF based clock lookup

2013-11-17 Thread Gerhard Sittig
...@kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Gerhard Sittig g...@denx.de --- drivers/spi/spi-mpc512x-psc.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c index 6adf4e35816d

[PATCH v5 09/17] serial: mpc512x: adjust for OF based clock lookup

2013-11-17 Thread Gerhard Sittig
gre...@linuxfoundation.org Cc: Jiri Slaby jsl...@suse.cz Cc: linux-ser...@vger.kernel.org Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org # for v4 Signed-off-by: Gerhard Sittig g...@denx.de --- Greg, the difference between v4 and v5 of this patch is that v4 took the 'mclk' and 'ipg' clock

[PATCH v5 10/17] serial: mpc512x: setup the PSC FIFO clock as well

2013-11-17 Thread Gerhard Sittig
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Jiri Slaby jsl...@suse.cz Cc: linux-ser...@vger.kernel.org Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org # for v4 Signed-off-by: Gerhard Sittig g...@denx.de --- Greg, the addition since v4 is the clk_get_sys() call for the 'ipg' clock

[PATCH v5 12/17] mtd: mpc5121_nfc: adjust for OF based clock lookup

2013-11-17 Thread Gerhard Sittig
-...@lists.infradead.org Signed-off-by: Gerhard Sittig g...@denx.de --- drivers/mtd/nand/mpc5121_nfc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/mpc5121_nfc.c b/drivers/mtd/nand/mpc5121_nfc.c index 3c60a000b426..35a51a5aa537 100644 --- a/drivers/mtd/nand

[PATCH v5 11/17] USB: fsl-mph-dr-of: adjust for OF based clock lookup

2013-11-17 Thread Gerhard Sittig
-by: Gerhard Sittig g...@denx.de --- drivers/usb/host/fsl-mph-dr-of.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c index abd5050a4899..9162d1b6c0a3 100644 --- a/drivers/usb/host/fsl-mph-dr-of.c

[PATCH v5 14/17] net: can: mscan: adjust to common clock support for mpc512x

2013-11-17 Thread Gerhard Sittig
: Marc Kleine-Budde m...@pengutronix.de Cc: linux-...@vger.kernel.org Signed-off-by: Gerhard Sittig g...@denx.de --- drivers/net/can/mscan/mpc5xxx_can.c | 179 +++ 1 file changed, 179 insertions(+) diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can

[PATCH v5 13/17] [media] fsl-viu: adjust for OF based clock lookup

2013-11-17 Thread Gerhard Sittig
after device tree based clock lookup became available, the VIU driver need no longer use the previous global viu_clk name, but should use the ipg clock name specific to the OF node Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-me...@vger.kernel.org Signed-off-by: Gerhard Sittig g

[PATCH v5 15/17] net: can: mscan: remove non-CCF code for MPC512x

2013-11-17 Thread Gerhard Sittig
Kleine-Budde m...@pengutronix.de Cc: linux-...@vger.kernel.org Signed-off-by: Gerhard Sittig g...@denx.de --- drivers/net/can/mscan/mpc5xxx_can.c | 141 --- 1 file changed, 141 deletions(-) diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can/mscan

[PATCH v5 16/17] powerpc/mpc512x: improve DIU related clock setup

2013-11-17 Thread Gerhard Sittig
: Anatolij Gustschin ag...@denx.de Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/platforms/512x/mpc512x_shared.c | 169 ++ 1 file changed, 92 insertions(+), 77 deletions(-) diff --git a/arch/powerpc/platforms/512x/mpc512x_shared.c

[PATCH v5 17/17] clk: mpc512x: remove migration support workarounds

2013-11-17 Thread Gerhard Sittig
...@linaro.org Cc: Anatolij Gustschin ag...@denx.de Cc: linux-arm-ker...@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/platforms/512x/clock-commonclk.c | 50 - 1 file changed, 16 insertions(+), 34 deletions

Re: [PATCH RFC v5 2/5] dma: mpc512x: add support for peripheral transfers

2013-11-14 Thread Gerhard Sittig
On Tue, Nov 12, 2013 at 16:23 +0400, Alexander Popov wrote: 2013/11/12 Gerhard Sittig g...@denx.de: It would be nice to get a response to the feedback that you are given. It may be appropriate not to obey to the feedback, but at least it should get considered. Yes, I see. My

Re: [PATCH RFC v5 1/5] dma: mpc512x: reorder mpc8308 specific instructions

2013-11-11 Thread Gerhard Sittig
...@denx.de I feel that this patch has become stable and can be taken, regardless of the pending review of the other parts in the series. virtually yours Gerhard Sittig -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr. 5, D-82194

Re: [PATCH RFC v5 2/5] dma: mpc512x: add support for peripheral transfers

2013-11-11 Thread Gerhard Sittig
that you are given. It may be appropriate not to obey to the feedback, but at least it should get considered. Have you noticed the recent introduction of the dmaengine@vger ML? Make sure to include it upon the next submission. virtually yours Gerhard Sittig -- DENX Software Engineering GmbH

Re: [PATCH] powerpc/qe_lib: Share the qe_lib for the others architecture

2013-10-15 Thread Gerhard Sittig
(like: it's neither serial nor network exclusively, but can be either and potentially more). IIUC the question which Kumar Gala was asking is where to put code for the component which is neither a strict subset of any subsystem. Please correct me if I'm wrong. virtually yours Gerhard Sittig

Re: [PATCH RFC v2 0/5] MPC512x DMA slave s/g support, OF DMA lookup

2013-10-06 Thread Gerhard Sittig
On Thu, Oct 03, 2013 at 18:00 +0400, Alexander Popov wrote: v2013/7/14 Gerhard Sittig g...@denx.de: this series - introduces slave s/g support (that's support for DMA transfers which involve peripherals in contrast to mem-to-mem transfers) - adds device tree based lookup support

Re: [PATCH RFC v4 2/5] dma: mpc512x: add support for peripheral transfers

2013-10-06 Thread Gerhard Sittig
; + } + + spin_unlock_irqrestore(mchan-lock, flags); + + return 0; + default: + return -ENOSYS; + } + + return -EINVAL; +} + static int mpc_dma_probe(struct platform_device *op) { struct device_node *dn = op-dev.of_node; virtually yours Gerhard Sittig -- DENX

[PATCH v1] powerpc/mpc512x: silence build warning upon disabled DIU

2013-09-27 Thread Gerhard Sittig
-by: Gerhard Sittig g...@denx.de CC: sta...@vger.kernel.org # v3.11 --- arch/powerpc/platforms/512x/mpc512x_shared.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/powerpc/platforms/512x/mpc512x_shared.c b/arch/powerpc/platforms/512x/mpc512x_shared.c index a82a41b..1a7b1d0 100644

Re: [PATCH v4 09/31] powerpc/fsl-pci: improve clock API use

2013-08-28 Thread Gerhard Sittig
widening the series' scope after initial submission as well as a recent extension of test coverage after the scope has been widened. Thank you for your patience! On Tue, Aug 06, 2013 at 22:43 +0200, Gerhard Sittig wrote: make the Freescale PCI driver get, prepare and enable the PCI clock during

Re: [PATCH v4 00/31] add COMMON_CLK support for PowerPC MPC512x

2013-08-28 Thread Gerhard Sittig
] On Tue, Aug 06, 2013 at 22:43 +0200, Gerhard Sittig wrote: this series - fixes several drivers that are used in the MPC512x platform (UART, SPI, ethernet, PCI, USB, CAN, NAND flash, video capture) in how they handle clocks (appropriately acquire and setup them, hold references during

Re: [PATCH v4 09/31] powerpc/fsl-pci: improve clock API use

2013-08-28 Thread Gerhard Sittig
On Wed, Aug 28, 2013 at 14:08 +0200, Gerhard Sittig wrote: [ re-created the Cc: list, this is about the PCI clock exclusively ] I just noticed by coincidence that the message which I received back from the linuxppc-dev ML appeared to have dropped Benjamin Herrenschmidt and Kumar Gala from

Re: [PATCH v4 09/31] powerpc/fsl-pci: improve clock API use

2013-08-12 Thread Gerhard Sittig
On Thu, Aug 08, 2013 at 22:12 +0200, Anatolij Gustschin wrote: On Tue, 6 Aug 2013 22:43:49 +0200 Gerhard Sittig g...@denx.de wrote: ... diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c index 46ac1dd..549ff08 100644 --- a/arch/powerpc/sysdev/fsl_pci.c +++ b

Re: [PATCH v4 00/31] add COMMON_CLK support for PowerPC MPC512x

2013-08-08 Thread Gerhard Sittig
On Wed, Aug 07, 2013 at 10:40 -0500, Kumar Gala wrote: On Aug 6, 2013, at 3:43 PM, Gerhard Sittig wrote: this series - fixes several drivers that are used in the MPC512x platform (UART, SPI, ethernet, PCI, USB, CAN, NAND flash, video capture) in how they handle clocks (appropriately

Re: [PATCH v4 11/31] net: can: mscan: improve clock API use

2013-08-08 Thread Gerhard Sittig
On Wed, Aug 07, 2013 at 09:28 +0200, Marc Kleine-Budde wrote: On 08/06/2013 10:43 PM, Gerhard Sittig wrote: [ ... ] diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c index e6b4095..4f998f5 100644 --- a/drivers/net/can/mscan/mscan.c +++ b/drivers/net/can/mscan

Re: [PATCH v4 00/31] add COMMON_CLK support for PowerPC MPC512x

2013-08-07 Thread Gerhard Sittig
[ no change in content, but order shuffling for better application ] On Tue, Aug 06, 2013 at 23:31 +0200, Gerhard Sittig wrote: [ this is an overview on how to split the series if necessary ] On Tue, Aug 06, 2013 at 22:43 +0200, Gerhard Sittig wrote: this series - fixes several

[PATCH v4 00/31] add COMMON_CLK support for PowerPC MPC512x

2013-08-06 Thread Gerhard Sittig
call (13/24) Gerhard Sittig (31): spi: mpc512x: cleanup clock API use serial: mpc512x: cleanup clock API use USB: fsl-mph-dr-of: cleanup clock API use mtd: mpc5121_nfc: cleanup clock API use [media] fsl-viu: cleanup clock API use i2c: mpc: cleanup clock API use fs_enet: silence a build

[PATCH v4 01/31] spi: mpc512x: cleanup clock API use

2013-08-06 Thread Gerhard Sittig
(bitrate) determination to reduce redundancy as well as to not exceed the maximum text line length - stick with the PPC_CLOCK 'psc%d_mclk' name for clock lookup, only switch to a fixed string later after device tree based clock lookup will have become available Signed-off-by: Gerhard Sittig g

[PATCH v4 02/31] serial: mpc512x: cleanup clock API use

2013-08-06 Thread Gerhard Sittig
of the above remains a NOP for the MPC5200 platform (no callbacks are provided on that platform) - implementation note: the clock gets enabled upon allocation already just in case the clock is not only required for bitrate generation but for register access as well Signed-off-by: Gerhard Sittig

[PATCH v4 04/31] mtd: mpc5121_nfc: cleanup clock API use

2013-08-06 Thread Gerhard Sittig
use devm_clk_get() for automatic put after device close, check for and propagate errors when enabling clocks, need to prepare clocks before they can get enabled, adjust error code paths to correctly balance get/put and prepare/unprepare and enable/disable calls Signed-off-by: Gerhard Sittig g

[PATCH v4 03/31] USB: fsl-mph-dr-of: cleanup clock API use

2013-08-06 Thread Gerhard Sittig
use devm_get_clk() for automatic put upon device close, check for and propagate errors when enabling clocks, must prepare clocks before they can get enabled, unprepare after disable Signed-off-by: Gerhard Sittig g...@denx.de --- drivers/usb/host/fsl-mph-dr-of.c | 16 +--- 1 file

[PATCH v4 05/31] [media] fsl-viu: cleanup clock API use

2013-08-06 Thread Gerhard Sittig
use devm_clk_get() for automatic put after device close, check for and propagate errors when enabling clocks, need to prepare clocks before they can get enabled, adjust code paths to correctly balance get/put and prepare/unprepare and enable/disable calls Signed-off-by: Gerhard Sittig g

[PATCH v4 06/31] i2c: mpc: cleanup clock API use

2013-08-06 Thread Gerhard Sittig
in this implementation as not all platforms may provide clock specs in their device tree, but enable errors for specified clocks are considered fatal Signed-off-by: Gerhard Sittig g...@denx.de --- drivers/i2c/busses/i2c-mpc.c | 24 1 file changed, 24 insertions(+) diff --git

[PATCH v4 07/31] fs_enet: silence a build warning (unused variable)

2013-08-06 Thread Gerhard Sittig
Signed-off-by: Gerhard Sittig g...@denx.de --- drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c index 8de53a1..c04eb3a 100644

[PATCH v4 08/31] fs_enet: cleanup clock API use

2013-08-06 Thread Gerhard Sittig
in their device tree; failure to enable specified clocks is fatal Signed-off-by: Gerhard Sittig g...@denx.de --- .../net/ethernet/freescale/fs_enet/fs_enet-main.c | 20 include/linux/fs_enet_pd.h |3 +++ 2 files changed, 23 insertions(+) diff --git

[PATCH v4 09/31] powerpc/fsl-pci: improve clock API use

2013-08-06 Thread Gerhard Sittig
appears to not have a remove() routine, so no reference to the clock is kept during use, and the clock isn't released (the devm approach will put the clock, but it won't get disabled or unprepared) Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/sysdev/fsl_pci.c | 22

[PATCH v4 10/31] net: can: mscan: add a comment on reg to idx mapping

2013-08-06 Thread Gerhard Sittig
add a comment about the magic of deriving an MSCAN component index from the peripheral's physical address / register offset Signed-off-by: Gerhard Sittig g...@denx.de --- drivers/net/can/mscan/mpc5xxx_can.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net

[PATCH v4 11/31] net: can: mscan: improve clock API use

2013-08-06 Thread Gerhard Sittig
, such that subroutines in the setup sequence may access those data structures as well to track their resource acquisition since clock allocation remains optional, the release callback as well as the enable/disable calls in open/close are optional as well Signed-off-by: Gerhard Sittig g...@denx.de --- drivers

[PATCH v4 12/31] powerpc: mpc512x: array decl for MCLK registers in CCM

2013-08-06 Thread Gerhard Sittig
to existing code since the PSC and MSCAN CCR fields declared here aren't referenced anywhere Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/include/asm/mpc5121.h | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/arch/powerpc/include/asm/mpc5121.h

[PATCH v4 14/31] dts: mpc512x: prepare for preprocessor support

2013-08-06 Thread Gerhard Sittig
prepare C preprocessor support when processing MPC512x DTS files - switch from DTS syntax to CPP syntax for include specs - create a symlink such that DTS processing can reference includes Signed-off-by: Gerhard Sittig g...@denx.de --- arch/powerpc/boot/dts/ac14xx.dts |2 +- arch

[PATCH v4 13/31] clk: wrap I/O access for improved portability

2013-08-06 Thread Gerhard Sittig
the common clock drivers were motivated/initiated by ARM development and apparently assume little endian peripherals wrap register/peripherals access in the common code (div, gate, mux) in preparation of adding COMMON_CLK support for other platforms Signed-off-by: Gerhard Sittig g...@denx.de

  1   2   3   >