Re: [PATCH v8 0/3] generic and PowerPC SED Opal keystore

2023-10-17 Thread Greg Joyce
Hi Jens, I've addressed all the comments/issues on v7 of the patchset and haven't received any feedback on v8. Is there anything else that you'd like to see before this can be included? Thanks, Greg On Wed, 2023-10-04 at 15:19 -0500, gjo...@linux.vnet.ibm.com wrote: > From: Greg Jo

Re: [PATCH v7 1/3 RESEND] block:sed-opal: SED Opal keystore

2023-09-27 Thread Greg Joyce
On Wed, 2023-09-13 at 13:49 -0700, Nick Desaulniers wrote: > On Wed, Sep 13, 2023 at 9:56 AM Nathan Chancellor > wrote: > > Hi Greg, > > > > On Fri, Sep 08, 2023 at 10:30:54AM -0500, gjo...@linux.vnet.ibm.com > > wrote: > > > From: Greg Joyce &g

Re: [PATCH v7 3/3 RESEND] powerpc/pseries: PLPKS SED Opal keystore support

2023-09-27 Thread Greg Joyce
On Wed, 2023-09-13 at 13:15 -0600, Jens Axboe wrote: > On 9/13/23 12:59 PM, Nathan Chancellor wrote: > > Hi Greg, > > > > On Fri, Sep 08, 2023 at 10:30:56AM -0500, gjo...@linux.vnet.ibm.com > > wrote: > > > From: Greg Joyce > > > > >

Re: [PATCH v5 0/3 RESEND] sed-opal: keyrings, discovery, revert, key store

2023-08-21 Thread Greg Joyce
On Wed, 2023-08-16 at 23:41 +0300, Jarkko Sakkinen wrote: > On Wed Aug 16, 2023 at 10:45 PM EEST, Greg Joyce wrote: > > It's been almost 4 weeks since the last resend and there haven't > > been > > any comments. Is there anything that needs to be changed for > >

Re: [PATCH v7 1/3 RESEND] block:sed-opal: SED Opal keystore

2023-08-18 Thread Greg Joyce
On Thu, 2023-08-17 at 07:42 +0200, Hannes Reinecke wrote: > On 7/21/23 23:19, gjo...@linux.vnet.ibm.com wrote: > > From: Greg Joyce > > > > Add read and write functions that allow SED Opal keys to stored > > in a permanent keystore. > > > Probably state

Re: [PATCH v5 0/3 RESEND] sed-opal: keyrings, discovery, revert, key store

2023-08-16 Thread Greg Joyce
It's been almost 4 weeks since the last resend and there haven't been any comments. Is there anything that needs to be changed for acceptance? Thanks for your input. Greg On Fri, 2023-07-21 at 16:15 -0500, gjo...@linux.vnet.ibm.com wrote: > From: Greg Joyce > > This patchset has gon

Re: [PATCH v4 RESEND 0/3] sed-opal: keyrings, discovery, revert, key store

2023-06-08 Thread Greg Joyce
On Mon, 2023-06-05 at 15:14 -0600, Jens Axboe wrote: > On 6/1/23 4:37PM, gjo...@linux.vnet.ibm.com wrote: > > From: Greg Joyce > > > > This patchset has gone through numerous rounds of review and > > all comments/suggetions have been addressed. I believe that

Re: [PATCH 1/4] block:sed-opal: SED Opal keystore

2023-06-01 Thread Greg Joyce
On Thu, 2023-05-11 at 01:50 +0300, Jarkko Sakkinen wrote: > On Fri May 5, 2023 at 10:43 PM EEST, wrote: > > From: Greg Joyce > > > > Add read and write functions that allow SED Opal keys to stored > > in a permanent keystore. > > Please be more verbose starting

Re: [PATCH 4/4] powerpc/pseries: update SED for PLPKS api changes

2023-06-01 Thread Greg Joyce
On Mon, 2023-05-15 at 15:52 +1000, Andrew Donnellan wrote: > On Fri, 2023-05-05 at 14:44 -0500, gjo...@linux.vnet.ibm.com wrote: > > From: Greg Joyce > > > > Changes to the PLPKS API require minor updates to the SED Opal > > PLPKS keystore code. > > > > S

Re: [PATCH v3 05/24] powerpc/secvar: Handle max object size in the consumer

2023-01-19 Thread Greg Joyce
On Wed, 2023-01-18 at 17:10 +1100, Andrew Donnellan wrote: > From: Russell Currey > > Currently the max object size is handled in the core secvar code with > an > entirely OPAL-specific implementation, so create a new max_size() op > and > move the existing implementation into the powernv

Re: [PATCH v3 3/3] block: sed-opal: keyring support for SED keys

2022-12-02 Thread Greg Joyce
On Fri, 2022-12-02 at 07:56 +0100, Hannes Reinecke wrote: > On 12/1/22 19:03, Greg Joyce wrote: > > On Wed, 2022-11-30 at 08:00 +0100, Hannes Reinecke wrote: > > > On 11/30/22 00:25, gjo...@linux.vnet.ibm.com wrote: > > > > From: Greg Joyce > > > > >

Re: [PATCH v3 3/3] block: sed-opal: keyring support for SED keys

2022-12-01 Thread Greg Joyce
On Wed, 2022-11-30 at 08:00 +0100, Hannes Reinecke wrote: > On 11/30/22 00:25, gjo...@linux.vnet.ibm.com wrote: > > From: Greg Joyce > > > > Extend the SED block driver so it can alternatively > > obtain a key from a sed-opal kernel keyring. The SED > > ioctls wi

Re: [PATCH v3 3/3] block: sed-opal: keyring support for SED keys

2022-12-01 Thread Greg Joyce
On Thu, 2022-12-01 at 10:58 -0600, Greg Joyce wrote: > On Thu, 2022-12-01 at 11:12 -0500, Ben Boeckel wrote: > > On Thu, Dec 01, 2022 at 09:29:36 -0600, Greg Joyce wrote: > > > On Wed, 2022-11-30 at 22:46 -0500, Ben Boeckel wrote: > > > > Perhaps naming it `OPAL_M

Re: [PATCH v3 3/3] block: sed-opal: keyring support for SED keys

2022-12-01 Thread Greg Joyce
On Thu, 2022-12-01 at 11:12 -0500, Ben Boeckel wrote: > On Thu, Dec 01, 2022 at 09:29:36 -0600, Greg Joyce wrote: > > On Wed, 2022-11-30 at 22:46 -0500, Ben Boeckel wrote: > > > Perhaps naming it `OPAL_MAX_KEY_LEN` would help clarify this? > > > > I'm not averse t

Re: [PATCH v3 3/3] block: sed-opal: keyring support for SED keys

2022-12-01 Thread Greg Joyce
On Wed, 2022-11-30 at 22:46 -0500, Ben Boeckel wrote: > On Wed, Nov 30, 2022 at 09:19:25 -0600, Greg Joyce wrote: > > On Wed, 2022-11-30 at 08:00 +0100, Hannes Reinecke wrote: > > > On 11/30/22 00:25, gjo...@linux.vnet.ibm.com wrote: > > >

Re: [PATCH v3 3/3] block: sed-opal: keyring support for SED keys

2022-11-30 Thread Greg Joyce
On Wed, 2022-11-30 at 08:00 +0100, Hannes Reinecke wrote: > On 11/30/22 00:25, gjo...@linux.vnet.ibm.com wrote: > > From: Greg Joyce > > > > Extend the SED block driver so it can alternatively > > obtain a key from a sed-opal kernel keyring. The SED > > ioctls wi

Re: [PATCH v4 2/3] powerpc/pseries: PLPKS SED Opal keystore support

2022-11-16 Thread Greg Joyce
On Fri, 2022-10-07 at 19:09 +, Elliott, Robert (Servers) wrote: > > -Original Message- > > From: gjo...@linux.vnet.ibm.com > > Sent: Friday, August 19, 2022 5:32 PM > > To: linux-bl...@vger.kernel.org > > Cc: linuxppc-dev@lists.ozlabs.org; jonathan.derr...@linux.dev; > >

Re: [PATCH v4 3/3] block: sed-opal: keystore access for SED Opal keys

2022-11-16 Thread Greg Joyce
On Fri, 2022-10-07 at 12:21 -0600, Jonathan Derrick wrote: > LGTM besides comment below > > Reviewed-by: Jonathan Derrick > > On 8/19/2022 4:31 PM, gjo...@linux.vnet.ibm.com wrote: > > From: Greg Joyce > > > > Allow for permanent SED authentication keys by &g

Re: [PATCH v3 1/2] lib: generic accessor functions for arch keystore

2022-08-04 Thread Greg Joyce
On Mon, 2022-08-01 at 22:24 +0200, Michal Suchánek wrote: > > > > + > > > > +int __weak arch_read_variable(enum arch_variable_type type, > > > > char *varname, > > > > + void *varbuf, u_int *varlen) > > > > +{ > > > > + return -EOPNOTSUPP; > > > > +} > > > > + > >

Re: [PATCH v3 1/2] lib: generic accessor functions for arch keystore

2022-08-02 Thread Greg Joyce
Michael and Michal, On Tue, 2022-08-02 at 12:59 +1000, Michael Ellerman wrote: > I don't think "arch" is the right level of abstraction here. > > There isn't a standard way to get these variables across a given > arch, > they're not defined in the architecture specification etc. > > As

Re: [PATCH v2 1/3] powerpc/pseries: define driver for Platform KeyStore

2022-07-28 Thread Greg Joyce
Reviewed-by: Greg Joyce Tested-by: Greg Joyce On Sat, 2022-07-23 at 07:30 -0400, Nayna Jain wrote: > PowerVM provides an isolated Platform Keystore(PKS) storage > allocation > for each LPAR with individually managed access controls to store > sensitive information securely. It pr