Re: [PATCH] powerpc/boot: Convert more files to use SPDX tags

2022-08-19 Thread Greg KH
On Fri, Aug 19, 2022 at 09:04:30PM +1000, Michael Ellerman wrote: > These files are all plain GPL 2.0, with a second sentence about being > licensed as-is. > > Similar to the rule in commit 577b61cee5b2 ("treewide: Replace GPLv2 > boilerplate/reference with SPDX - gpl-2.0_398.RULE"). > >

Re: [PATCH] [backport for 4.14] powerpc/ptdump: Fix display of RW pages on FSL_BOOK3E

2022-08-19 Thread Greg KH
On Tue, Aug 16, 2022 at 10:45:29AM +0200, Christophe Leroy wrote: > [ Upstream commit dd8de84b57b02ba9c1fe530a6d916c0853f136bd ] > > On FSL_BOOK3E, _PAGE_RW is defined with two bits, one for user and one > for supervisor. As soon as one of the two bits is set, the page has > to be display as RW.

Re: [PATCH] macintosh:fix oob read in do_adb_query function

2022-07-13 Thread Greg KH
On Wed, Jul 13, 2022 at 11:37:34PM +0800, Ning Qiang wrote: > In do_adb_query function of drivers/macintosh/adb.c, req->data is copy > form userland. the parameter "req->data[2]" is Missing check, the > array size of adb_handler[] is 16, so "adb_handler[ > req->data[2]].original_address" and

Re: [PATCH] macintosh:fix oob read in do_adb_query function

2022-07-13 Thread Greg KH
On Wed, Jul 13, 2022 at 09:40:37PM +0800, NAME wrote: > From: sohu0106 For obvious reasons, we need a real name here, and in the signed-off-by line. > In do_adb_query function of drivers/macintosh/adb.c, > req->data is copy form userland. The parameter > "req->data[2]" is Missing check, the

Re: [linux-next:master] BUILD REGRESSION 088b9c375534d905a4d337c78db3b3bfbb52c4a0

2022-07-07 Thread Greg KH
org, net...@vger.kernel.org, k...@vger.kernel.org, da...@lists.linux.dev, linux...@kvack.org, accessrunner-gene...@lists.sourceforge.net, linux1394-de...@lists.sourceforge.net, linux-l...@vger.kernel.org, rds-de...@oss.oracle.com, linux-...@vger.kernel.org, d...@vger.kernel.org,

Re: [PATCH] cxl: drop unexpected word "the" in the comments

2022-07-01 Thread Greg KH
On Thu, Jun 30, 2022 at 11:10:13AM +1000, Andrew Donnellan wrote: > On Wed, 2022-06-29 at 22:15 +1000, Michael Ellerman wrote: > > On Tue, 21 Jun 2022 20:53:21 +0800, Jiang Jian wrote: > > > there is an unexpected word "the" in the comments that need to be > > > dropped > > > > > > file:

Re: [PATCH v4.9] kexec_file: drop weak attribute from arch_kexec_apply_relocations[_add]

2022-06-30 Thread Greg KH
On Tue, Jun 28, 2022 at 09:12:48PM +0530, Naveen N. Rao wrote: > commit 3e35142ef99fe6b4fe5d834ad43ee13cca10a2dc upstream. > > Since commit d1bcae833b32f1 ("ELF: Don't generate unused section > symbols") [1], binutils (v2.36+) started dropping section symbols that > it thought were unused. This

Re: [PATCH v5.18] powerpc/ftrace: Remove ftrace init tramp once kernel init is complete

2022-06-30 Thread Greg KH
On Mon, Jun 27, 2022 at 11:09:29PM +0530, Naveen N. Rao wrote: > commit 84ade0a6655bee803d176525ef457175cbf4df22 upstream. > > Stop using the ftrace trampoline for init section once kernel init is > complete. > > Fixes: 67361cf8071286 ("powerpc/ftrace: Handle large kernel configs") > Cc:

Re: [PATCH RFC] drivers/usb/ehci-fsl: Fix interrupt setup in host mode.

2022-06-22 Thread Greg KH
On Tue, Jun 21, 2022 at 11:09:41PM +0100, Darren Stevens wrote: > In patch a1a2b7125e1079 (Drop static setup of IRQ resource from DT > core) we stopped platform_get_resource() from returning the IRQ, as all > drivers were supposed to have switched to platform_get_irq() > Unfortunately the

Re: [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation

2022-06-14 Thread Greg KH
On Tue, Jun 14, 2022 at 07:53:46AM +, Wenhu Wang wrote: > >> >> + > >> >> +struct mpc85xx_l2ctlr { > >> >> + u32 ctl;/* 0x000 - L2 control */ > >> > > >> >What is the endian of these u32 values? You map them directly to > >> >memory, so they must be specified some way,

Re: 回复: [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation

2022-06-14 Thread Greg KH
On Tue, Jun 14, 2022 at 06:09:35AM +, Wenhu Wang wrote: > Hi Greg, thanks for the comments. > The questions are replied specifically below. > I have figured out and tested the patch v2, which is to be posted later. > >发件人: Greg KH > >发送时间: 2022年6月9日 21:17 >

Re: [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation

2022-06-09 Thread Greg KH
On Thu, Jun 09, 2022 at 03:28:55AM -0700, Wang Wenhu wrote: > The l2-cache could be optionally configured as SRAM partly or fully. > Users can make use of it as a block of independent memory that offers > special usage, such as for debuging or other cratical status info > storage which keeps

Re: [PATCH for v5.15] perf symbol: Remove arch__symbols__fixup_end()

2022-05-03 Thread Greg KH
On Mon, May 02, 2022 at 05:37:36PM -0700, Namhyung Kim wrote: > Now the generic code can handle kallsyms fixup properly so no need to > keep the arch-functions anymore. > > Signed-off-by: Namhyung Kim > Acked-by: Ian Rogers > Cc: Heiko Carstens > Cc: Ingo Molnar > Cc: Jiri Olsa > Cc: John

Re: [PATCH v4.19 0/2] Custom backports for powerpc SLB issues

2022-04-29 Thread Greg KH
On Thu, Apr 28, 2022 at 10:41:48PM +1000, Michael Ellerman wrote: > Hi Greg, > > Here are two custom backports to v4.19 for some powerpc issues we've > discovered. > Both were fixed upstream as part of a large non-backportable rewrite. Other > stable > kernel versions are not affected. > >

Re: [PATCH v5 05/10] serial: termbits: ADDRB to indicate 9th bit addressing mode

2022-04-26 Thread Greg KH
On Tue, Apr 26, 2022 at 05:01:31PM +0300, Ilpo Järvinen wrote: > One additional thing below I missed on the first read. > > On Tue, 26 Apr 2022, Ilpo Järvinen wrote: > > On Tue, 26 Apr 2022, Greg KH wrote: > > > > > On Tue, Apr 26, 2022 at 03:24:43PM +0300, Ilpo Jär

Re: [PATCH v5 06/10] serial: General support for multipoint addresses

2022-04-26 Thread Greg KH
On Tue, Apr 26, 2022 at 04:36:49PM +0300, Ilpo Järvinen wrote: > On Tue, 26 Apr 2022, Greg KH wrote: > > > On Tue, Apr 26, 2022 at 03:24:44PM +0300, Ilpo Järvinen wrote: > > > Add generic support for serial multipoint addressing. Two new ioctls > > > are added.

Re: [PATCH v5 06/10] serial: General support for multipoint addresses

2022-04-26 Thread Greg KH
On Tue, Apr 26, 2022 at 03:24:44PM +0300, Ilpo Järvinen wrote: > Add generic support for serial multipoint addressing. Two new ioctls > are added. TIOCSADDR is used to indicate the destination/receive > address. TIOCGADDR returns the current address in use. The driver > should implement set_addr

Re: [PATCH v5 05/10] serial: termbits: ADDRB to indicate 9th bit addressing mode

2022-04-26 Thread Greg KH
On Tue, Apr 26, 2022 at 03:24:43PM +0300, Ilpo Järvinen wrote: > Add ADDRB to termbits to indicate 9th bit addressing mode. This change > is necessary for supporting devices with RS485 multipoint addressing > [*]. A later patch in the patch series adds support for Synopsys > Designware UART

Re: [PATCH] [Rebased for 5.4] powerpc/kasan: Fix early region not updated correctly

2022-04-04 Thread Greg KH
On Sun, Apr 03, 2022 at 03:49:43PM +0200, Christophe Leroy wrote: > From: Chen Jingwen > > This is backport for 5.4 > > Upstream commit dd75080aa8409ce10d50fb58981c6b59bf8707d3 Now queued up, thanks. greg k-h

Re: [PATCH] [Rebased for 5.4] powerpc/kasan: Fix early region not updated correctly

2022-04-03 Thread Greg KH
On Sun, Apr 03, 2022 at 11:54:55AM +, Christophe Leroy wrote: > > > Le 03/04/2022 à 12:25, Greg KH a écrit : > > On Sat, Apr 02, 2022 at 06:13:31PM +0200, Christophe Leroy wrote: > >> From: Chen Jingwen > >> > >> This is

Re: [PATCH] [Rebased for 5.4] powerpc/kasan: Fix early region not updated correctly

2022-04-03 Thread Greg KH
On Sat, Apr 02, 2022 at 06:13:31PM +0200, Christophe Leroy wrote: > From: Chen Jingwen > > This is backport for 5.4 > > Upstream commit 5647a94a26e352beed61788b46e035d9d12664cd This is not a commit in Linus's tree :(

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-01 Thread Greg KH
On Tue, Mar 01, 2022 at 06:40:04PM +0100, Jakob Koschel wrote: > > > > On 1. Mar 2022, at 18:36, Greg KH wrote: > > > > On Tue, Mar 01, 2022 at 12:28:15PM +0100, Jakob Koschel wrote: > >> > >> > >>> On 1. Mar 2022, at 01:41, Linus Tor

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-01 Thread Greg KH
On Tue, Mar 01, 2022 at 12:28:15PM +0100, Jakob Koschel wrote: > > > > On 1. Mar 2022, at 01:41, Linus Torvalds > > wrote: > > > > On Mon, Feb 28, 2022 at 1:47 PM Jakob Koschel > > wrote: > >> > >> The goal of this is to get compiler warnings right? This would indeed be > >> great. > > >

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-01 Thread Greg KH
On Mon, Feb 28, 2022 at 01:06:57PM +0100, Jakob Koschel wrote: > > > > On 28. Feb 2022, at 12:20, Greg KH wrote: > > > > On Mon, Feb 28, 2022 at 12:08:18PM +0100, Jakob Koschel wrote: > >> If the list does not contain the expected element, the value of &g

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Greg KH
On Mon, Feb 28, 2022 at 12:08:18PM +0100, Jakob Koschel wrote: > If the list does not contain the expected element, the value of > list_for_each_entry() iterator will not point to a valid structure. > To avoid type confusion in such case, the list iterator > scope will be limited to

Re: [PATCH 03/14] nds32: fix access_ok() checks in get/put_user

2022-02-15 Thread Greg KH
On Tue, Feb 15, 2022 at 10:18:15AM +0100, Arnd Bergmann wrote: > On Mon, Feb 14, 2022 at 6:01 PM Christoph Hellwig wrote: > > > > On Mon, Feb 14, 2022 at 05:34:41PM +0100, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > The get_user()/put_user() functions are meant to check for > > >

Re: [PATCH] Styleguide fix: Removed un-needed whitespaces and formatting errors in drivers/tty

2022-02-06 Thread Greg KH
On Mon, Feb 07, 2022 at 12:33:07AM +0530, Ankit Kumar Pandey wrote: > There were lot of styleguide errors raised by checkpatch.pl against > drivers/tty/* which I have fixed. There is zero code change apart from > changes related to styleguide. checkpatch.pl returns 0 error for > style guide now. >

Re: [PATCH v2 3/3] vstatus: Display an informational message when the VSTATUS character is pressed or TIOCSTAT ioctl is called.

2022-02-06 Thread Greg KH
On Sun, Feb 06, 2022 at 07:48:54AM -0800, Walt Drummond wrote: > When triggered by pressing the VSTATUS key or calling the TIOCSTAT > ioctl, the n_tty line discipline will display a message on the user's > tty that provides basic information about the system and an > 'interesting' process in the

Re: [PATCH v2 2/3] status: Add user space API definitions for VSTATUS, NOKERNINFO and TIOCSTAT

2022-02-06 Thread Greg KH
On Sun, Feb 06, 2022 at 07:48:53AM -0800, Walt Drummond wrote: > Add definitions for the VSTATUS control character, and the NOKERNINFO > local control flag in the termios struct, and add an ioctl number for > the ioctl TIOCSTAT. Also add a default VSTATUS character (Ctrl-T) > default valuses in

Re: [PATCH v7 0/5] Allow guest access to EFI confidential computing secret area

2022-02-02 Thread Greg KH
On Wed, Feb 02, 2022 at 08:04:01AM +, Matthew Garrett wrote: > On Wed, Feb 02, 2022 at 08:22:03AM +0100, Ard Biesheuvel wrote: > > On Wed, 2 Feb 2022 at 08:10, Matthew Garrett wrote: > > > Which other examples are you thinking of? I think this conversation may > > > have accidentally become

Re: [PATCH v7 0/5] Allow guest access to EFI confidential computing secret area

2022-02-01 Thread Greg KH
On Wed, Feb 02, 2022 at 06:54:43AM +, Matthew Garrett wrote: > On Wed, Feb 02, 2022 at 07:10:02AM +0100, Greg KH wrote: > > On Wed, Feb 02, 2022 at 04:01:57AM +, Matthew Garrett wrote: > > > We're talking about things that have massively different semantics. &

Re: [PATCH v7 0/5] Allow guest access to EFI confidential computing secret area

2022-02-01 Thread Greg KH
On Wed, Feb 02, 2022 at 04:01:57AM +, Matthew Garrett wrote: > On Tue, Feb 01, 2022 at 09:24:50AM -0500, James Bottomley wrote: > > On Tue, 2022-02-01 at 14:50 +0100, Greg KH wrote: > > > You all need to work together to come up with a unified place for > > > this

Re: [PATCH v7 0/5] Allow guest access to EFI confidential computing secret area

2022-02-01 Thread Greg KH
On Tue, Feb 01, 2022 at 09:24:50AM -0500, James Bottomley wrote: > [cc's added] > On Tue, 2022-02-01 at 14:50 +0100, Greg KH wrote: > > On Tue, Feb 01, 2022 at 12:44:08PM +, Dov Murik wrote: > [...] > > > # ls -la /sys/kernel/security/coco/efi_secret > > > tot

Re: [RFC PATCH 0/2] powerpc/pseries: add support for local secure storage called Platform Keystore(PKS)

2022-02-01 Thread Greg KH
On Mon, Jan 24, 2022 at 11:25:17AM +1100, Daniel Axtens wrote: > Hi Greg, > > > Ok, this is like the 3rd or 4th different platform-specific proposal for > > this type of functionality. I think we need to give up on > > platform-specific user/kernel apis on this (random sysfs/securityfs > > files

Re: [PATCH 0/3] status: TTY status message request

2022-01-26 Thread Greg KH
On Mon, Jan 17, 2022 at 08:42:57PM -0800, Walt Drummond wrote: > This patchset adds TTY status message request feature to the n_tty > line dicipline. This feature prints a brief message containing basic > system and process group information to a user's TTY in response to a > new control

Re: [RFC PATCH 0/2] powerpc/pseries: add support for local secure storage called Platform Keystore(PKS)

2022-01-21 Thread Greg KH
On Fri, Jan 21, 2022 at 07:56:35PM -0500, Nayna Jain wrote: > PowerVM provides an isolated Platform Keystore(PKS) storage allocation > for each partition with individually managed access controls to store > sensitive information securely. Linux Kernel can access this storage by > interfacing with

Re: [PATCH stable 4.19 1/1] arch: pgtable: define MAX_POSSIBLE_PHYSMEM_BITS where needed

2021-11-04 Thread Greg KH
On Wed, Nov 03, 2021 at 01:56:56PM -0700, Florian Fainelli wrote: > From: Arnd Bergmann > > [ Upstream commit cef397038167ac15d085914493d6c86385773709 ] > > Stefan Agner reported a bug when using zsram on 32-bit Arm machines > with RAM above the 4GB address boundary: > > Unable to handle

Re: [PATCH v11 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-26 Thread Greg KH
On Tue, Oct 26, 2021 at 02:11:51PM +0800, Xianting Tian wrote: > > 在 2021/10/26 下午2:10, Greg KH 写道: > > On Tue, Oct 26, 2021 at 02:02:21PM +0800, Xianting Tian wrote: > > > 在 2021/10/26 下午1:10, Jiri Slaby 写道: > > > > On 15. 10. 21, 4:46, Xianting Tian wrote: >

Re: [PATCH v11 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-26 Thread Greg KH
On Tue, Oct 26, 2021 at 02:02:21PM +0800, Xianting Tian wrote: > 在 2021/10/26 下午1:10, Jiri Slaby 写道: > > On 15. 10. 21, 4:46, Xianting Tian wrote: > > > @@ -151,9 +142,11 @@ static uint32_t vtermnos[MAX_NR_HVC_CONSOLES] = > > >   static void hvc_console_print(struct console *co, const char *b, > >

Re: Stable backport request

2021-10-24 Thread Greg KH
On Sun, Oct 24, 2021 at 09:21:09AM +1100, Michael Ellerman wrote: > Hi Greg, > > Please backport the following commit to v5.4 and v5.10: > > 73287caa9210ded6066833195f4335f7f688a46b > ("powerpc64/idle: Fix SP offsets when saving GPRs") > > > And please backport the following commits to

Re: [PATCH v11 0/3] make hvc pass dma capable memory to its backend

2021-10-21 Thread Greg KH
On Fri, Oct 15, 2021 at 10:46:55AM +0800, Xianting Tian wrote: > Dear all, > > This patch series make hvc framework pass DMA capable memory to > put_chars() of hvc backend(eg, virtio-console), and revert commit > c4baad5029 ("virtio-console: avoid DMA from stack”) Thanks for sticking with this,

Re: [PATCH v11 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-20 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I

Re: [PATCH v10 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-14 Thread Greg KH
On Thu, Oct 14, 2021 at 04:34:59PM +0800, Xianting Tian wrote: > > 在 2021/10/10 下午1:33, Greg KH 写道: > > On Sat, Oct 09, 2021 at 11:45:23PM +0800, Xianting Tian wrote: > > > 在 2021/10/9 下午7:58, Greg KH 写道: > > > > Did you look at the placement using pa

Re: [PATCH v10 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-09 Thread Greg KH
On Sat, Oct 09, 2021 at 11:45:23PM +0800, Xianting Tian wrote: > > 在 2021/10/9 下午7:58, Greg KH 写道: > > Did you look at the placement using pahole as to how this structure now > > looks? > > thanks for all your commnts. for this one, do you mean I need to remove the > b

Re: [PATCH v10 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-09 Thread Greg KH
On Sat, Oct 09, 2021 at 07:48:28PM +0800, Xianting Tian wrote: > --- a/drivers/tty/hvc/hvc_console.h > +++ b/drivers/tty/hvc/hvc_console.h > @@ -32,13 +32,21 @@ > */ > #define HVC_ALLOC_TTY_ADAPTERS 8 > > +/* > + * These sizes are most efficient for vio, because they are the > + *

Re: [PATCH v10 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-10-09 Thread Greg KH
On Sat, Oct 09, 2021 at 07:48:28PM +0800, Xianting Tian wrote: > As well known, hvc backend can register its opertions to hvc backend. > the operations contain put_chars(), get_chars() and so on. > > Some hvc backend may do dma in its operations. eg, put_chars() of > virtio-console. But in the

Re: [PATCH v8 1/2] powerpc/pseries: Interface to represent PAPR firmware attributes

2021-09-28 Thread Greg KH
On Tue, Sep 28, 2021 at 06:13:18PM +0530, Pratik Sampat wrote: > Hello Greg, > > Thank you for your review. > > On 28/09/21 5:38 pm, Greg KH wrote: > > On Tue, Sep 28, 2021 at 05:21:01PM +0530, Pratik R. Sampat wrote: > > > Adds a generic interface to represent th

Re: [PATCH v8 1/2] powerpc/pseries: Interface to represent PAPR firmware attributes

2021-09-28 Thread Greg KH
On Tue, Sep 28, 2021 at 05:21:01PM +0530, Pratik R. Sampat wrote: > Adds a generic interface to represent the energy and frequency related > PAPR attributes on the system using the new H_CALL > "H_GET_ENERGY_SCALE_INFO". > > H_GET_EM_PARMS H_CALL was previously responsible for exporting this >

Re: [PATCH v8 2/3] tty: hvc: pass DMA capable memory to put_chars()

2021-09-18 Thread Greg KH
On Sat, Sep 18, 2021 at 08:32:01PM +0800, Xianting Tian wrote: > hi > > Will you consider to continue the disscussion of this patch? thanks I do not see a newer version of this series. thanks, greg k-h

Re: [PATCH v7 1/2] tty: hvc: pass DMA capable memory to put_chars()

2021-08-17 Thread Greg KH
On Tue, Aug 17, 2021 at 09:22:59PM +0800, Xianting Tian wrote: > We tested the patch, it worked normally. Who is "we"? > Signed-off-by: Xianting Tian Like I said before, I need another developer from your company to review and sign-off on this patch (and the other one), before I am willing to

Re: [PATCH v6 1/2] tty: hvc: pass DMA capable memory to put_chars()

2021-08-13 Thread Greg KH
On Thu, Aug 12, 2021 at 05:45:31PM +0800, Xianting Tian wrote: > As well known, hvc backend can register its opertions to hvc backend. > the opertions contain put_chars(), get_chars() and so on. > > Some hvc backend may do dma in its opertions. eg, put_chars() of > virtio-console. But in the code

Re: [PATCH v3 1/2] tty: hvc: pass DMA capable memory to put_chars()

2021-08-05 Thread Greg KH
On Thu, Aug 05, 2021 at 04:08:46PM +0800, Xianting Tian wrote: > > 在 2021/8/5 下午3:58, Jiri Slaby 写道: > > Hi, > > > > On 04. 08. 21, 4:54, Xianting Tian wrote: > > > @@ -933,6 +949,16 @@ struct hvc_struct *hvc_alloc(uint32_t vtermno, > > > int data, > > >   hp->outbuf_size = outbuf_size; > >

Re: [PATCH] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting

2021-06-29 Thread Greg KH
On Tue, Jun 29, 2021 at 12:45:20PM +0530, kajoljain wrote: > > > On 6/28/21 3:47 PM, Kajol Jain wrote: > > The performance reporting driver added cpu hotplug > > feature but it didn't add pmu migration call in cpu > > offline function. > > This can create an issue incase the current designated >

Re: [PATCH] powerpc/udbg_hvc: retry putc on -EAGAIN

2021-05-27 Thread Greg KH
On Sun, May 23, 2021 at 08:51:09PM +1000, Michael Ellerman wrote: > Greg KH writes: > > On Fri, May 14, 2021 at 04:44:22PM -0500, Nathan Lynch wrote: > >> hvterm_raw_put_chars() calls hvc_put_chars(), which may return -EAGAIN > >> when the underlying hc

Re: [PATCH] powerpc/udbg_hvc: retry putc on -EAGAIN

2021-05-21 Thread Greg KH
On Fri, May 14, 2021 at 04:44:22PM -0500, Nathan Lynch wrote: > hvterm_raw_put_chars() calls hvc_put_chars(), which may return -EAGAIN > when the underlying hcall returns a "busy" status, but udbg_hvc_putc() > doesn't handle this. When using xmon on a PowerVM guest, this can > result in incomplete

Re: [PATCH 0/9] tty: hvc_console: Fix some coding style issues

2021-05-20 Thread Greg KH
On Mon, May 17, 2021 at 02:37:04PM +0800, Xiaofei Tan wrote: > Fix some issues reported by checkpatch.pl. All of them are > coding style issues, no function changes. > > Xiaofei Tan (9): > tty: hvc_console: Fix spaces required around that '=' > tty: hvc_console: Fix "foo * bar" should be "foo

Re: Conflict between arch/powerpc/include/asm/disassemble.h and drivers/staging/rtl8723bs/include/wifi.h

2021-05-19 Thread Greg KH
On Thu, May 20, 2021 at 07:30:49AM +0200, Christophe Leroy wrote: > Hello, > > I was trying to include powerpc asm/disassemble.h in some more widely used > headers in order to reduce open coding, and I'm facing the following > problem: > > drivers/staging/rtl8723bs/include/wifi.h:237:30: error:

Re: [PATCH] cxl: Fix an error message

2021-05-14 Thread Greg KH
On Wed, May 05, 2021 at 09:38:49PM +0200, Christophe JAILLET wrote: > 'rc' is known to be 0 here. > Initialize 'rc' with the expected error code before using it. > > While at it, avoid the affectation of 'rc' in a 'if' to make things more > obvious and linux style. > > Fixes: f204e0b8ce ("cxl:

Re: [PATCH v2] kbuild: replace LANG=C with LC_ALL=C

2021-04-30 Thread Greg KH
On Fri, Apr 30, 2021 at 10:56:27AM +0900, Masahiro Yamada wrote: > LANG gives a weak default to each LC_* in case it is not explicitly > defined. LC_ALL, if set, overrides all other LC_* variables. > > LANG < LC_CTYPE, LC_COLLATE, LC_MONETARY, LC_NUMERIC, ... < LC_ALL > > This is why

Re: [PATCH 00/30] DMA: Mundane typo fixes

2021-03-29 Thread Greg KH
On Mon, Mar 29, 2021 at 11:25:11AM +0530, Bhaskar Chowdhury wrote: > On 07:29 Mon 29 Mar 2021, Christoph Hellwig wrote: > > I really don't think these typo patchbomb are that useful. I'm all > > for fixing typos when working with a subsystem, but I'm not sure these > > patchbombs help anything. >

Re: [PATCH] [backport for 5.10] powerpc/603: Fix protection of user pages mapped with PROT_NONE

2021-03-12 Thread Greg KH
On Thu, Mar 11, 2021 at 06:24:30PM +, Christophe Leroy wrote: > (cherry picked from commit c119565a15a628efdfa51352f9f6c5186e506a1c) > > On book3s/32, page protection is defined by the PP bits in the PTE > which provide the following protection depending on the access > keys defined in the

Re: linux-next: manual merge of the tty tree with the powerpc-fixes tree

2021-03-04 Thread Greg KH
On Fri, Mar 05, 2021 at 12:05:23PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the tty tree got a conflict in: > > drivers/tty/hvc/hvcs.c > > between commit: > > 386a966f5ce7 ("vio: make remove callback return void") > > from the powerpc-fixes tree and commit:

Re: [PATCH for 5.10] powerpc/32: Preserve cr1 in exception prolog stack check to fix build error

2021-03-01 Thread Greg KH
On Tue, Feb 23, 2021 at 03:39:20PM +0100, Christophe Leroy wrote: > > > Le 15/02/2021 à 15:30, Greg KH a écrit : > > On Fri, Feb 12, 2021 at 08:57:14AM +, Christophe Leroy wrote: > > > This is backport of 3642eb21256a ("powerpc/32: Preserve cr1 in > > &g

Re: [PATCH for 5.10] powerpc/32: Preserve cr1 in exception prolog stack check to fix build error

2021-02-15 Thread Greg KH
On Fri, Feb 12, 2021 at 08:57:14AM +, Christophe Leroy wrote: > This is backport of 3642eb21256a ("powerpc/32: Preserve cr1 in > exception prolog stack check to fix build error") for kernel 5.10 > > It fixes the build failure on v5.10 reported by kernel test robot > and by David Michael. > >

Re: [PATCH v2 2/2] ima: Free IMA measurement buffer after kexec syscall

2021-02-05 Thread Greg KH
On Thu, Feb 04, 2021 at 09:49:51AM -0800, Lakshmi Ramasubramanian wrote: > IMA allocates kernel virtual memory to carry forward the measurement > list, from the current kernel to the next kernel on kexec system call, > in ima_add_kexec_buffer() function. This buffer is not freed before >

Re: [PATCH v2 1/2] ima: Free IMA measurement buffer on error

2021-02-05 Thread Greg KH
On Thu, Feb 04, 2021 at 09:49:50AM -0800, Lakshmi Ramasubramanian wrote: > IMA allocates kernel virtual memory to carry forward the measurement > list, from the current kernel to the next kernel on kexec system call, > in ima_add_kexec_buffer() function. In error code paths this memory > is not

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-13 Thread Greg KH
On Wed, Jan 13, 2021 at 12:51:26PM +0100, Christoph Hellwig wrote: > On Wed, Jan 06, 2021 at 08:50:03AM +0100, Greg KH wrote: > > > --- a/include/linux/device.h > > > +++ b/include/linux/device.h > > > @@ -413,6 +413,7 @@ struct dev_links_info { > > > * @dm

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-05 Thread Greg KH
On Wed, Jan 06, 2021 at 11:41:20AM +0800, Claire Chang wrote: > Add the initialization function to create restricted DMA pools from > matching reserved-memory nodes in the device tree. > > Signed-off-by: Claire Chang > --- > include/linux/device.h | 4 ++ > include/linux/swiotlb.h | 7 +- >

Re: [PATCH v3 5/6] mm/mmu_gather: invalidate TLB correctly on batch allocation failure and flush

2021-01-05 Thread Greg KH
On Thu, Mar 12, 2020 at 06:57:39PM +0530, Santosh Sivaraj wrote: > From: Peter Zijlstra > > commit 0ed1325967ab5f7a4549a2641c6ebe115f76e228 upstream. > > Architectures for which we have hardware walkers of Linux page table > should flush TLB on mmu gather batch allocation failures and batch

Re: [PATCH v3 0/6] Memory corruption may occur due to incorrent tlb flush

2021-01-04 Thread Greg KH
On Thu, Mar 12, 2020 at 06:57:34PM +0530, Santosh Sivaraj wrote: > The TLB flush optimisation (a46cc7a90f: powerpc/mm/radix: Improve TLB/PWC > flushes) may result in random memory corruption. Any concurrent page-table > walk > could end up with a Use-after-Free. Even on UP this might give issues,

Re: [PATCH] powerpc: Stop exporting __clear_user which is now inlined.

2020-12-06 Thread Greg KH
On Sat, Dec 05, 2020 at 09:58:23PM +1100, Michael Ellerman wrote: > Michal Suchanek writes: > > Stable commit 452e2a83ea23 ("powerpc: Fix __clear_user() with KUAP > > enabled") redefines __clear_user as inline function but does not remove > > the export. > > > > Fixes: 452e2a83ea23 ("powerpc: Fix

Re: [PATCH] powerpc/hotplug: assign hot added LMB to the right node

2020-12-03 Thread Greg KH
On Thu, Dec 03, 2020 at 11:15:14AM +0100, Laurent Dufour wrote: > This patch applies to 5.9 and earlier kernels only. > > Since 5.10, this has been fortunately fixed by the commit > e5e179aa3a39 ("pseries/drmem: don't cache node id in drmem_lmb struct"). Why can't we just backport that patch

Re: [PATCH for 5.4] powerpc/8xx: Always fault when _PAGE_ACCESSED is not set

2020-11-20 Thread Greg KH
On Thu, Nov 19, 2020 at 08:47:54AM +, Christophe Leroy wrote: > [This is backport for 5.4 of 29daf869cbab69088fe1755d9dd224e99ba78b56] > > The kernel expects pte_young() to work regardless of CONFIG_SWAP. All backports now queued up, thanks. greg k-h

Re: [PATCH for 5.4] powerpc/603: Always fault when _PAGE_ACCESSED is not set

2020-11-17 Thread Greg KH
On Mon, Nov 09, 2020 at 05:40:52PM +, Christophe Leroy wrote: > [That is backport of 11522448e641e8f1690c9db06e01985e8e19b401 to linux 5.4] > > The kernel expects pte_young() to work regardless of CONFIG_SWAP. > > Make sure a minor fault is taken to set _PAGE_ACCESSED when it > is not

Re: [PATCH 4.19] mm: fix exec activate_mm vs TLB shootdown and lazy tlb switching race

2020-11-04 Thread Greg KH
On Wed, Nov 04, 2020 at 12:14:06PM +1100, Michael Ellerman wrote: > From: Nicholas Piggin > > commit d53c3dfb23c45f7d4f910c3a3ca84bf0a99c6143 upstream. > > Reading and modifying current->mm and current->active_mm and switching > mm should be done with irqs off, to prevent races seeing an

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-11-02 Thread 'Greg KH'
On Mon, Nov 02, 2020 at 09:06:38AM +, David Laight wrote: > From: 'Greg KH' > > Sent: 23 October 2020 15:47 > > > > On Fri, Oct 23, 2020 at 02:39:24PM +, David Laight wrote: > > > From: David Hildenbrand > > > > Sent: 23 October 2020 15:33 > &g

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-23 Thread 'Greg KH'
On Fri, Oct 23, 2020 at 02:39:24PM +, David Laight wrote: > From: David Hildenbrand > > Sent: 23 October 2020 15:33 > ... > > I just checked against upstream code generated by clang 10 and it > > properly discards the upper 32bit via a mov w23 w2. > > > > So at least clang 10 indeed properly

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 04:28:20PM +0200, Arnd Bergmann wrote: > On Thu, Oct 22, 2020 at 3:50 PM Greg KH wrote: > > On Thu, Oct 22, 2020 at 02:57:59PM +0200, Greg KH wrote: > > > On Thu, Oct 22, 2020 at 02:42:24PM +0200, David Hildenbrand wrote: > > > > > st

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 02:57:59PM +0200, Greg KH wrote: > On Thu, Oct 22, 2020 at 02:42:24PM +0200, David Hildenbrand wrote: > > On 22.10.20 14:18, Greg KH wrote: > > > On Thu, Oct 22, 2020 at 12:48:05PM +0200, Greg KH wrote: > > >> On Thu, Oct 22, 2020 at 11:36

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 02:42:24PM +0200, David Hildenbrand wrote: > On 22.10.20 14:18, Greg KH wrote: > > On Thu, Oct 22, 2020 at 12:48:05PM +0200, Greg KH wrote: > >> On Thu, Oct 22, 2020 at 11:36:40AM +0200, David Hildenbrand wrote: > >>> On 22.10.20 11:32, D

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 12:48:05PM +0200, Greg KH wrote: > On Thu, Oct 22, 2020 at 11:36:40AM +0200, David Hildenbrand wrote: > > On 22.10.20 11:32, David Laight wrote: > > > From: David Hildenbrand > > >> Sent: 22 October 2020 10:25 > > > ... > >

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 11:36:40AM +0200, David Hildenbrand wrote: > On 22.10.20 11:32, David Laight wrote: > > From: David Hildenbrand > >> Sent: 22 October 2020 10:25 > > ... > >> ... especially because I recall that clang and gcc behave slightly > >> differently: > >> > >>

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 10:48:59AM +0200, David Hildenbrand wrote: > On 22.10.20 10:40, David Laight wrote: > > From: David Hildenbrand > >> Sent: 22 October 2020 09:35 > >> > >> On 22.10.20 10:26, Greg KH wrote: > >>> On Thu, Oct 22, 2020 at 12:39:

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 12:39:14AM +0100, Al Viro wrote: > On Wed, Oct 21, 2020 at 06:13:01PM +0200, Greg KH wrote: > > On Fri, Sep 25, 2020 at 06:51:39AM +0200, Christoph Hellwig wrote: > > > From: David Laight > > > > > > This lets the compiler inli

Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-21 Thread Greg KH
On Fri, Sep 25, 2020 at 06:51:39AM +0200, Christoph Hellwig wrote: > From: David Laight > > This lets the compiler inline it into import_iovec() generating > much better code. > > Signed-off-by: David Laight > Signed-off-by: Christoph Hellwig > --- > fs/read_write.c | 179

Re: [PATCH] serial: pmac_zilog: don't init if zilog is not available

2020-10-20 Thread Greg KH
On Tue, Oct 20, 2020 at 08:19:26PM +0200, Laurent Vivier wrote: > Le 20/10/2020 à 19:37, Greg KH a écrit : > > On Tue, Oct 20, 2020 at 06:37:41PM +0200, Laurent Vivier wrote: > >> Le 20/10/2020 à 18:28, Greg KH a écrit : > >>> On Tue, Oct 20, 2020 at 06:23:03

Re: [PATCH] serial: pmac_zilog: don't init if zilog is not available

2020-10-20 Thread Greg KH
On Tue, Oct 20, 2020 at 06:37:41PM +0200, Laurent Vivier wrote: > Le 20/10/2020 à 18:28, Greg KH a écrit : > > On Tue, Oct 20, 2020 at 06:23:03PM +0200, Laurent Vivier wrote: > >> We can avoid to probe for the Zilog device (and generate ugly kernel > >> warning) >

Re: [PATCH] serial: pmac_zilog: don't init if zilog is not available

2020-10-20 Thread Greg KH
On Tue, Oct 20, 2020 at 06:23:03PM +0200, Laurent Vivier wrote: > We can avoid to probe for the Zilog device (and generate ugly kernel warning) > if kernel is built for Mac but not on a Mac. > > Signed-off-by: Laurent Vivier > --- > drivers/tty/serial/pmac_zilog.c | 11 +++ > 1 file

Re: linux-next: manual merge of the char-misc tree with the powerpc tree

2020-10-06 Thread Greg KH
On Tue, Oct 06, 2020 at 06:35:06PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the char-misc tree got a conflict in: > > drivers/misc/ocxl/Kconfig > > between commit: > > dde6f18a8779 ("ocxl: Don't return trigger page when allocating an > interrupt") > > from

Re: [PATCH -next] tty: hvc: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n

2020-09-18 Thread Greg KH
On Sat, Sep 19, 2020 at 10:48:41AM +0800, Yang Yingliang wrote: > > On 2020/9/18 19:17, Greg KH wrote: > > On Fri, Sep 18, 2020 at 05:20:30PM +0800, Yang Yingliang wrote: > > > Fix the link error by selecting SERIAL_CORE_CONSOLE. > > > > > > aarch64-

Re: [PATCH -next] tty: hvc: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n

2020-09-18 Thread Greg KH
On Fri, Sep 18, 2020 at 05:20:30PM +0800, Yang Yingliang wrote: > Fix the link error by selecting SERIAL_CORE_CONSOLE. > > aarch64-linux-gnu-ld: drivers/tty/hvc/hvc_dcc.o: in function > `dcc_early_write': > hvc_dcc.c:(.text+0x164): undefined reference to `uart_console_write' > > Reported-by:

Re: Please apply commit 0828137e8f16 ("powerpc/64s: Don't init FSCR_DSCR in __init_FSCR()") to v4.14.y, v4.19.y, v5.4.y, v5.7.y

2020-08-26 Thread Greg KH
On Tue, Aug 25, 2020 at 07:44:08PM -0300, Thadeu Lima de Souza Cascardo wrote: > After commit 912c0a7f2b5daa3cbb2bc10f303981e493de73bd ("powerpc/64s: Save FSCR > to init_task.thread.fscr after feature init"), which has been applied to the > referred branches, when userspace sets the user DSCR MSR,

Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe

2020-08-24 Thread Greg KH
On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote: > Signed-off-by: Ye Bin I can't take patches without any changelog text, sorry. greg k-h

Re: [PATCH v2] powerpc/vio: drop bus_type from parent device

2020-07-29 Thread Greg KH
On Thu, Jul 30, 2020 at 11:28:38AM +1000, Michael Ellerman wrote: > [ Added Peter & Greg to Cc ] > > Thadeu Lima de Souza Cascardo writes: > > Commit df44b479654f62b478c18ee4d8bc4e9f897a9844 ("kobject: return error > > code if writing /sys/.../uevent fails") started returning failure when > >

Re: [PATCH v2 30/30] misc: cxl: flash: Remove unused pointer

2020-07-01 Thread Greg KH
On Wed, Jul 01, 2020 at 09:31:18AM +0100, Lee Jones wrote: > The DRC index pointer us updated on an OPCODE_ADD, but never > actually read. Remove the used pointer and shift up OPCODE_ADD > to group with OPCODE_DELETE which also provides a noop. > > Fixes the following W=1 kernel build warning: >

Re: [PATCH 11/13] random: simplify sysctl declaration with register_sysctl_subdir()

2020-05-29 Thread Greg KH
On Fri, May 29, 2020 at 07:41:06AM +, Luis Chamberlain wrote: > From: Xiaoming Ni > > Move random_table sysctl from kernel/sysctl.c to drivers/char/random.c > and use register_sysctl_subdir() to help remove the clutter out of > kernel/sysctl.c. > > Signed-off-by: Xiaoming Ni >

Re: [PATCH 09/13] firmware_loader: simplify sysctl declaration with register_sysctl_subdir()

2020-05-29 Thread Greg KH
On Fri, May 29, 2020 at 07:41:04AM +, Luis Chamberlain wrote: > From: Xiaoming Ni > > Move the firmware config sysctl table to fallback_table.c and use the > new register_sysctl_subdir() helper. This removes the clutter from > kernel/sysctl.c. > > Signed-off-by: Xiaoming Ni >

Re: [PATCH v4 3/6] asm-generic/tlb, arch: Invert CONFIG_HAVE_RCU_TABLE_INVALIDATE

2020-05-26 Thread Greg KH
On Wed, May 20, 2020 at 02:00:22PM +0530, Santosh Sivaraj wrote: > From: Peter Zijlstra > > commit 96bc9567cbe112e9320250f01b9c060c882e8619 upstream > > Make issuing a TLB invalidate for page-table pages the normal case. > > The reason is twofold: > > - too many invalidates is safer than too

Re: [PATCH] tty: hvc: Fix data abort due to race in hvc_open

2020-05-15 Thread Greg KH
On Thu, May 14, 2020 at 04:22:10PM -0700, rana...@codeaurora.org wrote: > On 2020-05-13 00:04, Greg KH wrote: > > On Tue, May 12, 2020 at 02:39:50PM -0700, rana...@codeaurora.org wrote: > > > On 2020-05-12 01:25, Greg KH wrote: > > > > On Tue, May 12, 2020 at 09:2

Re: [PATCH] tty: hvc: Fix data abort due to race in hvc_open

2020-05-13 Thread Greg KH
On Tue, May 12, 2020 at 02:39:50PM -0700, rana...@codeaurora.org wrote: > On 2020-05-12 01:25, Greg KH wrote: > > On Tue, May 12, 2020 at 09:22:15AM +0200, Jiri Slaby wrote: > > > On 11. 05. 20, 9:39, Greg KH wrote: > > > > On Mon, May 11, 2020 at 12:23:58AM -0700

  1   2   3   4   5   >