Re: [PATCH] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting

2021-06-29 Thread Greg KH
On Tue, Jun 29, 2021 at 12:45:20PM +0530, kajoljain wrote: > > > On 6/28/21 3:47 PM, Kajol Jain wrote: > > The performance reporting driver added cpu hotplug > > feature but it didn't add pmu migration call in cpu > > offline function. > > This can create an issue incase the current designated >

Re: [PATCH] powerpc/udbg_hvc: retry putc on -EAGAIN

2021-05-27 Thread Greg KH
On Sun, May 23, 2021 at 08:51:09PM +1000, Michael Ellerman wrote: > Greg KH writes: > > On Fri, May 14, 2021 at 04:44:22PM -0500, Nathan Lynch wrote: > >> hvterm_raw_put_chars() calls hvc_put_chars(), which may return -EAGAIN > >> when the underlying hc

Re: [PATCH] powerpc/udbg_hvc: retry putc on -EAGAIN

2021-05-21 Thread Greg KH
On Fri, May 14, 2021 at 04:44:22PM -0500, Nathan Lynch wrote: > hvterm_raw_put_chars() calls hvc_put_chars(), which may return -EAGAIN > when the underlying hcall returns a "busy" status, but udbg_hvc_putc() > doesn't handle this. When using xmon on a PowerVM guest, this can > result in incomplete

Re: [PATCH 0/9] tty: hvc_console: Fix some coding style issues

2021-05-20 Thread Greg KH
On Mon, May 17, 2021 at 02:37:04PM +0800, Xiaofei Tan wrote: > Fix some issues reported by checkpatch.pl. All of them are > coding style issues, no function changes. > > Xiaofei Tan (9): > tty: hvc_console: Fix spaces required around that '=' > tty: hvc_console: Fix "foo * bar" should be "foo

Re: Conflict between arch/powerpc/include/asm/disassemble.h and drivers/staging/rtl8723bs/include/wifi.h

2021-05-19 Thread Greg KH
On Thu, May 20, 2021 at 07:30:49AM +0200, Christophe Leroy wrote: > Hello, > > I was trying to include powerpc asm/disassemble.h in some more widely used > headers in order to reduce open coding, and I'm facing the following > problem: > > drivers/staging/rtl8723bs/include/wifi.h:237:30: error:

Re: [PATCH] cxl: Fix an error message

2021-05-14 Thread Greg KH
On Wed, May 05, 2021 at 09:38:49PM +0200, Christophe JAILLET wrote: > 'rc' is known to be 0 here. > Initialize 'rc' with the expected error code before using it. > > While at it, avoid the affectation of 'rc' in a 'if' to make things more > obvious and linux style. > > Fixes: f204e0b8ce ("cxl:

Re: [PATCH v2] kbuild: replace LANG=C with LC_ALL=C

2021-04-30 Thread Greg KH
On Fri, Apr 30, 2021 at 10:56:27AM +0900, Masahiro Yamada wrote: > LANG gives a weak default to each LC_* in case it is not explicitly > defined. LC_ALL, if set, overrides all other LC_* variables. > > LANG < LC_CTYPE, LC_COLLATE, LC_MONETARY, LC_NUMERIC, ... < LC_ALL > > This is why

Re: [PATCH 00/30] DMA: Mundane typo fixes

2021-03-29 Thread Greg KH
On Mon, Mar 29, 2021 at 11:25:11AM +0530, Bhaskar Chowdhury wrote: > On 07:29 Mon 29 Mar 2021, Christoph Hellwig wrote: > > I really don't think these typo patchbomb are that useful. I'm all > > for fixing typos when working with a subsystem, but I'm not sure these > > patchbombs help anything. >

Re: [PATCH] [backport for 5.10] powerpc/603: Fix protection of user pages mapped with PROT_NONE

2021-03-12 Thread Greg KH
On Thu, Mar 11, 2021 at 06:24:30PM +, Christophe Leroy wrote: > (cherry picked from commit c119565a15a628efdfa51352f9f6c5186e506a1c) > > On book3s/32, page protection is defined by the PP bits in the PTE > which provide the following protection depending on the access > keys defined in the

Re: linux-next: manual merge of the tty tree with the powerpc-fixes tree

2021-03-04 Thread Greg KH
On Fri, Mar 05, 2021 at 12:05:23PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the tty tree got a conflict in: > > drivers/tty/hvc/hvcs.c > > between commit: > > 386a966f5ce7 ("vio: make remove callback return void") > > from the powerpc-fixes tree and commit:

Re: [PATCH for 5.10] powerpc/32: Preserve cr1 in exception prolog stack check to fix build error

2021-03-01 Thread Greg KH
On Tue, Feb 23, 2021 at 03:39:20PM +0100, Christophe Leroy wrote: > > > Le 15/02/2021 à 15:30, Greg KH a écrit : > > On Fri, Feb 12, 2021 at 08:57:14AM +, Christophe Leroy wrote: > > > This is backport of 3642eb21256a ("powerpc/32: Preserve cr1 in > > &g

Re: [PATCH for 5.10] powerpc/32: Preserve cr1 in exception prolog stack check to fix build error

2021-02-15 Thread Greg KH
On Fri, Feb 12, 2021 at 08:57:14AM +, Christophe Leroy wrote: > This is backport of 3642eb21256a ("powerpc/32: Preserve cr1 in > exception prolog stack check to fix build error") for kernel 5.10 > > It fixes the build failure on v5.10 reported by kernel test robot > and by David Michael. > >

Re: [PATCH v2 2/2] ima: Free IMA measurement buffer after kexec syscall

2021-02-05 Thread Greg KH
On Thu, Feb 04, 2021 at 09:49:51AM -0800, Lakshmi Ramasubramanian wrote: > IMA allocates kernel virtual memory to carry forward the measurement > list, from the current kernel to the next kernel on kexec system call, > in ima_add_kexec_buffer() function. This buffer is not freed before >

Re: [PATCH v2 1/2] ima: Free IMA measurement buffer on error

2021-02-05 Thread Greg KH
On Thu, Feb 04, 2021 at 09:49:50AM -0800, Lakshmi Ramasubramanian wrote: > IMA allocates kernel virtual memory to carry forward the measurement > list, from the current kernel to the next kernel on kexec system call, > in ima_add_kexec_buffer() function. In error code paths this memory > is not

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-13 Thread Greg KH
On Wed, Jan 13, 2021 at 12:51:26PM +0100, Christoph Hellwig wrote: > On Wed, Jan 06, 2021 at 08:50:03AM +0100, Greg KH wrote: > > > --- a/include/linux/device.h > > > +++ b/include/linux/device.h > > > @@ -413,6 +413,7 @@ struct dev_links_info { > > > * @dm

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-05 Thread Greg KH
On Wed, Jan 06, 2021 at 11:41:20AM +0800, Claire Chang wrote: > Add the initialization function to create restricted DMA pools from > matching reserved-memory nodes in the device tree. > > Signed-off-by: Claire Chang > --- > include/linux/device.h | 4 ++ > include/linux/swiotlb.h | 7 +- >

Re: [PATCH v3 5/6] mm/mmu_gather: invalidate TLB correctly on batch allocation failure and flush

2021-01-05 Thread Greg KH
On Thu, Mar 12, 2020 at 06:57:39PM +0530, Santosh Sivaraj wrote: > From: Peter Zijlstra > > commit 0ed1325967ab5f7a4549a2641c6ebe115f76e228 upstream. > > Architectures for which we have hardware walkers of Linux page table > should flush TLB on mmu gather batch allocation failures and batch

Re: [PATCH v3 0/6] Memory corruption may occur due to incorrent tlb flush

2021-01-04 Thread Greg KH
On Thu, Mar 12, 2020 at 06:57:34PM +0530, Santosh Sivaraj wrote: > The TLB flush optimisation (a46cc7a90f: powerpc/mm/radix: Improve TLB/PWC > flushes) may result in random memory corruption. Any concurrent page-table > walk > could end up with a Use-after-Free. Even on UP this might give issues,

Re: [PATCH] powerpc: Stop exporting __clear_user which is now inlined.

2020-12-06 Thread Greg KH
On Sat, Dec 05, 2020 at 09:58:23PM +1100, Michael Ellerman wrote: > Michal Suchanek writes: > > Stable commit 452e2a83ea23 ("powerpc: Fix __clear_user() with KUAP > > enabled") redefines __clear_user as inline function but does not remove > > the export. > > > > Fixes: 452e2a83ea23 ("powerpc: Fix

Re: [PATCH] powerpc/hotplug: assign hot added LMB to the right node

2020-12-03 Thread Greg KH
On Thu, Dec 03, 2020 at 11:15:14AM +0100, Laurent Dufour wrote: > This patch applies to 5.9 and earlier kernels only. > > Since 5.10, this has been fortunately fixed by the commit > e5e179aa3a39 ("pseries/drmem: don't cache node id in drmem_lmb struct"). Why can't we just backport that patch

Re: [PATCH for 5.4] powerpc/8xx: Always fault when _PAGE_ACCESSED is not set

2020-11-20 Thread Greg KH
On Thu, Nov 19, 2020 at 08:47:54AM +, Christophe Leroy wrote: > [This is backport for 5.4 of 29daf869cbab69088fe1755d9dd224e99ba78b56] > > The kernel expects pte_young() to work regardless of CONFIG_SWAP. All backports now queued up, thanks. greg k-h

Re: [PATCH for 5.4] powerpc/603: Always fault when _PAGE_ACCESSED is not set

2020-11-17 Thread Greg KH
On Mon, Nov 09, 2020 at 05:40:52PM +, Christophe Leroy wrote: > [That is backport of 11522448e641e8f1690c9db06e01985e8e19b401 to linux 5.4] > > The kernel expects pte_young() to work regardless of CONFIG_SWAP. > > Make sure a minor fault is taken to set _PAGE_ACCESSED when it > is not

Re: [PATCH 4.19] mm: fix exec activate_mm vs TLB shootdown and lazy tlb switching race

2020-11-04 Thread Greg KH
On Wed, Nov 04, 2020 at 12:14:06PM +1100, Michael Ellerman wrote: > From: Nicholas Piggin > > commit d53c3dfb23c45f7d4f910c3a3ca84bf0a99c6143 upstream. > > Reading and modifying current->mm and current->active_mm and switching > mm should be done with irqs off, to prevent races seeing an

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-11-02 Thread 'Greg KH'
On Mon, Nov 02, 2020 at 09:06:38AM +, David Laight wrote: > From: 'Greg KH' > > Sent: 23 October 2020 15:47 > > > > On Fri, Oct 23, 2020 at 02:39:24PM +, David Laight wrote: > > > From: David Hildenbrand > > > > Sent: 23 October 2020 15:33 > &g

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-23 Thread 'Greg KH'
On Fri, Oct 23, 2020 at 02:39:24PM +, David Laight wrote: > From: David Hildenbrand > > Sent: 23 October 2020 15:33 > ... > > I just checked against upstream code generated by clang 10 and it > > properly discards the upper 32bit via a mov w23 w2. > > > > So at least clang 10 indeed properly

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 04:28:20PM +0200, Arnd Bergmann wrote: > On Thu, Oct 22, 2020 at 3:50 PM Greg KH wrote: > > On Thu, Oct 22, 2020 at 02:57:59PM +0200, Greg KH wrote: > > > On Thu, Oct 22, 2020 at 02:42:24PM +0200, David Hildenbrand wrote: > > > > > st

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 02:57:59PM +0200, Greg KH wrote: > On Thu, Oct 22, 2020 at 02:42:24PM +0200, David Hildenbrand wrote: > > On 22.10.20 14:18, Greg KH wrote: > > > On Thu, Oct 22, 2020 at 12:48:05PM +0200, Greg KH wrote: > > >> On Thu, Oct 22, 2020 at 11:36

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 02:42:24PM +0200, David Hildenbrand wrote: > On 22.10.20 14:18, Greg KH wrote: > > On Thu, Oct 22, 2020 at 12:48:05PM +0200, Greg KH wrote: > >> On Thu, Oct 22, 2020 at 11:36:40AM +0200, David Hildenbrand wrote: > >>> On 22.10.20 11:32, D

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 12:48:05PM +0200, Greg KH wrote: > On Thu, Oct 22, 2020 at 11:36:40AM +0200, David Hildenbrand wrote: > > On 22.10.20 11:32, David Laight wrote: > > > From: David Hildenbrand > > >> Sent: 22 October 2020 10:25 > > > ... > >

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 11:36:40AM +0200, David Hildenbrand wrote: > On 22.10.20 11:32, David Laight wrote: > > From: David Hildenbrand > >> Sent: 22 October 2020 10:25 > > ... > >> ... especially because I recall that clang and gcc behave slightly > >> differently: > >> > >>

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 10:48:59AM +0200, David Hildenbrand wrote: > On 22.10.20 10:40, David Laight wrote: > > From: David Hildenbrand > >> Sent: 22 October 2020 09:35 > >> > >> On 22.10.20 10:26, Greg KH wrote: > >>> On Thu, Oct 22, 2020 at 12:39:

Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-22 Thread Greg KH
On Thu, Oct 22, 2020 at 12:39:14AM +0100, Al Viro wrote: > On Wed, Oct 21, 2020 at 06:13:01PM +0200, Greg KH wrote: > > On Fri, Sep 25, 2020 at 06:51:39AM +0200, Christoph Hellwig wrote: > > > From: David Laight > > > > > > This lets the compiler inli

Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-21 Thread Greg KH
On Fri, Sep 25, 2020 at 06:51:39AM +0200, Christoph Hellwig wrote: > From: David Laight > > This lets the compiler inline it into import_iovec() generating > much better code. > > Signed-off-by: David Laight > Signed-off-by: Christoph Hellwig > --- > fs/read_write.c | 179

Re: [PATCH] serial: pmac_zilog: don't init if zilog is not available

2020-10-20 Thread Greg KH
On Tue, Oct 20, 2020 at 08:19:26PM +0200, Laurent Vivier wrote: > Le 20/10/2020 à 19:37, Greg KH a écrit : > > On Tue, Oct 20, 2020 at 06:37:41PM +0200, Laurent Vivier wrote: > >> Le 20/10/2020 à 18:28, Greg KH a écrit : > >>> On Tue, Oct 20, 2020 at 06:23:03

Re: [PATCH] serial: pmac_zilog: don't init if zilog is not available

2020-10-20 Thread Greg KH
On Tue, Oct 20, 2020 at 06:37:41PM +0200, Laurent Vivier wrote: > Le 20/10/2020 à 18:28, Greg KH a écrit : > > On Tue, Oct 20, 2020 at 06:23:03PM +0200, Laurent Vivier wrote: > >> We can avoid to probe for the Zilog device (and generate ugly kernel > >> warning) >

Re: [PATCH] serial: pmac_zilog: don't init if zilog is not available

2020-10-20 Thread Greg KH
On Tue, Oct 20, 2020 at 06:23:03PM +0200, Laurent Vivier wrote: > We can avoid to probe for the Zilog device (and generate ugly kernel warning) > if kernel is built for Mac but not on a Mac. > > Signed-off-by: Laurent Vivier > --- > drivers/tty/serial/pmac_zilog.c | 11 +++ > 1 file

Re: linux-next: manual merge of the char-misc tree with the powerpc tree

2020-10-06 Thread Greg KH
On Tue, Oct 06, 2020 at 06:35:06PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the char-misc tree got a conflict in: > > drivers/misc/ocxl/Kconfig > > between commit: > > dde6f18a8779 ("ocxl: Don't return trigger page when allocating an > interrupt") > > from

Re: [PATCH -next] tty: hvc: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n

2020-09-18 Thread Greg KH
On Sat, Sep 19, 2020 at 10:48:41AM +0800, Yang Yingliang wrote: > > On 2020/9/18 19:17, Greg KH wrote: > > On Fri, Sep 18, 2020 at 05:20:30PM +0800, Yang Yingliang wrote: > > > Fix the link error by selecting SERIAL_CORE_CONSOLE. > > > > > > aarch64-

Re: [PATCH -next] tty: hvc: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n

2020-09-18 Thread Greg KH
On Fri, Sep 18, 2020 at 05:20:30PM +0800, Yang Yingliang wrote: > Fix the link error by selecting SERIAL_CORE_CONSOLE. > > aarch64-linux-gnu-ld: drivers/tty/hvc/hvc_dcc.o: in function > `dcc_early_write': > hvc_dcc.c:(.text+0x164): undefined reference to `uart_console_write' > > Reported-by:

Re: Please apply commit 0828137e8f16 ("powerpc/64s: Don't init FSCR_DSCR in __init_FSCR()") to v4.14.y, v4.19.y, v5.4.y, v5.7.y

2020-08-26 Thread Greg KH
On Tue, Aug 25, 2020 at 07:44:08PM -0300, Thadeu Lima de Souza Cascardo wrote: > After commit 912c0a7f2b5daa3cbb2bc10f303981e493de73bd ("powerpc/64s: Save FSCR > to init_task.thread.fscr after feature init"), which has been applied to the > referred branches, when userspace sets the user DSCR MSR,

Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe

2020-08-24 Thread Greg KH
On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote: > Signed-off-by: Ye Bin I can't take patches without any changelog text, sorry. greg k-h

Re: [PATCH v2] powerpc/vio: drop bus_type from parent device

2020-07-29 Thread Greg KH
On Thu, Jul 30, 2020 at 11:28:38AM +1000, Michael Ellerman wrote: > [ Added Peter & Greg to Cc ] > > Thadeu Lima de Souza Cascardo writes: > > Commit df44b479654f62b478c18ee4d8bc4e9f897a9844 ("kobject: return error > > code if writing /sys/.../uevent fails") started returning failure when > >

Re: [PATCH v2 30/30] misc: cxl: flash: Remove unused pointer

2020-07-01 Thread Greg KH
On Wed, Jul 01, 2020 at 09:31:18AM +0100, Lee Jones wrote: > The DRC index pointer us updated on an OPCODE_ADD, but never > actually read. Remove the used pointer and shift up OPCODE_ADD > to group with OPCODE_DELETE which also provides a noop. > > Fixes the following W=1 kernel build warning: >

Re: [PATCH 11/13] random: simplify sysctl declaration with register_sysctl_subdir()

2020-05-29 Thread Greg KH
On Fri, May 29, 2020 at 07:41:06AM +, Luis Chamberlain wrote: > From: Xiaoming Ni > > Move random_table sysctl from kernel/sysctl.c to drivers/char/random.c > and use register_sysctl_subdir() to help remove the clutter out of > kernel/sysctl.c. > > Signed-off-by: Xiaoming Ni >

Re: [PATCH 09/13] firmware_loader: simplify sysctl declaration with register_sysctl_subdir()

2020-05-29 Thread Greg KH
On Fri, May 29, 2020 at 07:41:04AM +, Luis Chamberlain wrote: > From: Xiaoming Ni > > Move the firmware config sysctl table to fallback_table.c and use the > new register_sysctl_subdir() helper. This removes the clutter from > kernel/sysctl.c. > > Signed-off-by: Xiaoming Ni >

Re: [PATCH v4 3/6] asm-generic/tlb, arch: Invert CONFIG_HAVE_RCU_TABLE_INVALIDATE

2020-05-26 Thread Greg KH
On Wed, May 20, 2020 at 02:00:22PM +0530, Santosh Sivaraj wrote: > From: Peter Zijlstra > > commit 96bc9567cbe112e9320250f01b9c060c882e8619 upstream > > Make issuing a TLB invalidate for page-table pages the normal case. > > The reason is twofold: > > - too many invalidates is safer than too

Re: [PATCH] tty: hvc: Fix data abort due to race in hvc_open

2020-05-15 Thread Greg KH
On Thu, May 14, 2020 at 04:22:10PM -0700, rana...@codeaurora.org wrote: > On 2020-05-13 00:04, Greg KH wrote: > > On Tue, May 12, 2020 at 02:39:50PM -0700, rana...@codeaurora.org wrote: > > > On 2020-05-12 01:25, Greg KH wrote: > > > > On Tue, May 12, 2020 at 09:2

Re: [PATCH] tty: hvc: Fix data abort due to race in hvc_open

2020-05-13 Thread Greg KH
On Tue, May 12, 2020 at 02:39:50PM -0700, rana...@codeaurora.org wrote: > On 2020-05-12 01:25, Greg KH wrote: > > On Tue, May 12, 2020 at 09:22:15AM +0200, Jiri Slaby wrote: > > > On 11. 05. 20, 9:39, Greg KH wrote: > > > > On Mon, May 11, 2020 at 12:23:58AM -0700

Re: [PATCH] tty: hvc: Fix data abort due to race in hvc_open

2020-05-12 Thread Greg KH
On Tue, May 12, 2020 at 09:22:15AM +0200, Jiri Slaby wrote: > On 11. 05. 20, 9:39, Greg KH wrote: > > On Mon, May 11, 2020 at 12:23:58AM -0700, rana...@codeaurora.org wrote: > >> On 2020-05-09 23:48, Greg KH wrote: > >>> On Sat, May 09, 2020 at 06:30:56PM -0700

Re: [PATCH] tty: hvc: Fix data abort due to race in hvc_open

2020-05-11 Thread Greg KH
On Mon, May 11, 2020 at 12:34:44AM -0700, rana...@codeaurora.org wrote: > On 2020-05-11 00:23, rana...@codeaurora.org wrote: > > On 2020-05-09 23:48, Greg KH wrote: > > > On Sat, May 09, 2020 at 06:30:56PM -0700, rana...@codeaurora.org > > > wrote: > > >

Re: [PATCH] tty: hvc: Fix data abort due to race in hvc_open

2020-05-11 Thread Greg KH
On Mon, May 11, 2020 at 12:23:58AM -0700, rana...@codeaurora.org wrote: > On 2020-05-09 23:48, Greg KH wrote: > > On Sat, May 09, 2020 at 06:30:56PM -0700, rana...@codeaurora.org wrote: > > > On 2020-05-06 02:48, Greg KH wrote: > > > > On Mon, Apr 27, 2020 at 08:

Re: [PATCH] tty: hvc: Fix data abort due to race in hvc_open

2020-05-10 Thread Greg KH
On Sat, May 09, 2020 at 06:30:56PM -0700, rana...@codeaurora.org wrote: > On 2020-05-06 02:48, Greg KH wrote: > > On Mon, Apr 27, 2020 at 08:26:01PM -0700, Raghavendra Rao Ananta wrote: > > > Potentially, hvc_open() can be called in parallel when two tasks calls > &g

Re: [PATCH] tty: hvc: Fix data abort due to race in hvc_open

2020-05-06 Thread Greg KH
On Mon, Apr 27, 2020 at 08:26:01PM -0700, Raghavendra Rao Ananta wrote: > Potentially, hvc_open() can be called in parallel when two tasks calls > open() on /dev/hvcX. In such a scenario, if the hp->ops->notifier_add() > callback in the function fails, where it sets the tty->driver_data to > NULL,

Re: [PATCH v2, RESEND] misc: new driver sram_uapi for user level SRAM access

2020-04-21 Thread Greg KH
On Tue, Apr 21, 2020 at 05:09:47PM +0800, 王文虎 wrote: > Hi, Greg, Arnd, > > Thank you for your comments first, and then really very very very sorry > for driving Greg to sigh and I hope there would be chance to share Moutai > (rather than whisky, we drink it much, a kind of Baijiu), after the

Re: [PATCH v2, RESEND] misc: new driver sram_uapi for user level SRAM access

2020-04-20 Thread Greg KH
On Sun, Apr 19, 2020 at 08:05:38PM -0700, Wang Wenhu wrote: > A generic User-Kernel interface that allows a misc device created > by it to support file-operations of ioctl and mmap to access SRAM > memory from user level. Different kinds of SRAM alloction and free > APIs could be registered by

Re: [PATCH v4,4/4] drivers: uio: new driver for fsl_85xx_cache_sram

2020-04-17 Thread Greg KH
On Thu, Apr 16, 2020 at 11:58:29PM -0500, Scott Wood wrote: > On Fri, 2020-04-17 at 10:31 +0800, 王文虎 wrote: > > > > On Thu, 2020-04-16 at 08:35 -0700, Wang Wenhu wrote: > > > > > +#define UIO_INFO_VER "devicetree,pseudo" > > > > > > > > What does this mean? Changing a number into a non-obvious

Re: [PATCH v2,5/5] drivers: uio: new driver for fsl_85xx_cache_sram

2020-04-16 Thread Greg KH
> > + info->version = "0.1.0"; > > > > Could you define some DRIVER_VERSION in the top of the file next to > > DRIVER_NAME instead of hard coding in the middle on a function ? > > That's what v1 had, and Greg KH said to remove it. I'm guessing that he > tho

Re: [PATCH v2,5/5] drivers: uio: new driver for fsl_85xx_cache_sram

2020-04-16 Thread Greg KH
On Wed, Apr 15, 2020 at 02:26:55PM -0500, Scott Wood wrote: > Instead, have module parameters that take the sizes and alignments you'd like > to allocate and expose to userspace. Better still would be some sort of > dynamic allocation (e.g. open a fd, ioctl to set the requested size/alignment, >

Re: [PATCH 4.19] powerpc/powernv/idle: Restore AMR/UAMOR/AMOR after idle

2020-04-15 Thread Greg KH
On Wed, Apr 15, 2020 at 10:40:05PM +1000, Andrew Donnellan wrote: > From: Michael Ellerman > > commit 53a712bae5dd919521a58d7bad773b949358add0 upstream. > > In order to implement KUAP (Kernel Userspace Access Protection) on > Power9 we will be using the AMR, and therefore indirectly the >

Re: [PATCH 5/5] drivers: uio: new driver for fsl_85xx_cache_sram

2020-04-15 Thread Greg KH
On Wed, Apr 15, 2020 at 05:33:46AM -0700, Wang Wenhu wrote: > A driver for freescale 85xx platforms to access the Cache-Sram form > user level. This is extremely helpful for some user-space applications > that require high performance memory accesses. > > Cc: Greg Kroah-Hartman > Cc: Christophe

Re: [PATCH v2] Fix: buffer overflow during hvc_alloc().

2020-04-15 Thread Greg KH
On Tue, Apr 14, 2020 at 10:15:03PM +0300, and...@daynix.com wrote: > From: Andrew Melnychenko > > If there is a lot(more then 16) of virtio-console devices > or virtio_console module is reloaded > - buffers 'vtermnos' and 'cons_ops' are overflowed. > In older kernels it overruns spinlock which

Re: [PATCH 02/28] staging: android: ion: use vmap instead of vm_map_ram

2020-04-08 Thread Greg KH
On Wed, Apr 08, 2020 at 01:59:00PM +0200, Christoph Hellwig wrote: > vm_map_ram can keep mappings around after the vm_unmap_ram. Using that > with non-PAGE_KERNEL mappings can lead to all kinds of aliasing issues. > > Signed-off-by: Christoph Hellwig Acked-by: Greg Kroah-Hartman

Re: [PATCH 0/6] Memory corruption may occur due to incorrent tlb flush

2020-02-19 Thread Greg KH
On Thu, Feb 20, 2020 at 11:04:51AM +0530, Santosh Sivaraj wrote: > The TLB flush optimisation (a46cc7a90f: powerpc/mm/radix: Improve TLB/PWC > flushes) may result in random memory corruption. Any concurrent page-table > walk > could end up with a Use-after-Free. Even on UP this might give issues,

Re: [PATCH v5 3/6] powerpc/fadump: reorganize /sys/kernel/fadump_* sysfs files

2019-12-09 Thread Greg KH
On Mon, Dec 09, 2019 at 10:28:23AM +0530, Sourabh Jain wrote: > +#define CREATE_SYMLINK(target, symlink_name) do {\ > + rc = compat_only_sysfs_link_entry_to_kobj(kernel_kobj, fadump_kobj, \ > + target, symlink_name); \ > + if (rc) \ > +

Re: [PATCH v4 2/6] sysfs: wrap __compat_only_sysfs_link_entry_to_kobj function to change the symlink name

2019-12-06 Thread Greg KH
On Fri, Dec 06, 2019 at 11:57:53PM +0530, Sourabh Jain wrote: > > > On 12/6/19 6:16 PM, Greg KH wrote: > > On Fri, Dec 06, 2019 at 05:54:30PM +0530, Sourabh Jain wrote: > >> The __compat_only_sysfs_link_entry_to_kobj function creates a symlink to a > >> kobj

Re: [PATCH v4 6/6] powerpc/fadump: sysfs for fadump memory reservation

2019-12-06 Thread Greg KH
On Fri, Dec 06, 2019 at 05:54:34PM +0530, Sourabh Jain wrote: > Add a sys interface to allow querying the memory reserved by FADump for > saving the crash dump. > > Also added Documentation/ABI for the new sysfs file. > > Signed-off-by: Sourabh Jain > --- >

Re: [PATCH v4 4/6] powerpc/powernv: move core and fadump_release_opalcore under new kobject

2019-12-06 Thread Greg KH
On Fri, Dec 06, 2019 at 05:54:32PM +0530, Sourabh Jain wrote: > The /sys/firmware/opal/core and /sys/kernel/fadump_release_opalcore sysfs > files are used to export and release the OPAL memory on PowerNV platform. > let's organize them into a new kobject under /sys/firmware/opal/mpipl/ >

Re: [PATCH v4 1/6] Documentation/ABI: add ABI documentation for /sys/kernel/fadump_*

2019-12-06 Thread Greg KH
On Fri, Dec 06, 2019 at 05:54:29PM +0530, Sourabh Jain wrote: > Add missing ABI documentation for existing FADump sysfs files. > > Signed-off-by: Sourabh Jain > --- > Documentation/ABI/testing/sysfs-kernel-fadump_enabled | 7 +++ >

Re: [PATCH v4 2/6] sysfs: wrap __compat_only_sysfs_link_entry_to_kobj function to change the symlink name

2019-12-06 Thread Greg KH
On Fri, Dec 06, 2019 at 05:54:30PM +0530, Sourabh Jain wrote: > The __compat_only_sysfs_link_entry_to_kobj function creates a symlink to a > kobject but doesn't provide an option to change the symlink file name. > > This patch adds a wrapper function create_sysfs_symlink_entry_to_kobj that >

Re: [PATCH v4 3/6] powerpc/fadump: reorganize /sys/kernel/fadump_* sysfs files

2019-12-06 Thread Greg KH
On Fri, Dec 06, 2019 at 05:54:31PM +0530, Sourabh Jain wrote: > +static struct kobj_attribute release_attr = __ATTR(release_mem, > 0200, NULL, > fadump_release_memory_store); > -static struct kobj_attribute

Re: [4.14] Backport request: powerpc/perf: Fix IMC_MAX_PMU macro

2019-11-14 Thread Greg KH
On Fri, Nov 15, 2019 at 04:43:05PM +1100, Andrew Donnellan wrote: > On 15/11/19 4:37 pm, Andrew Donnellan wrote: > > Dear stable team > > > > Please backport the following patch. > > > > Commit: 7029d1eb0c2c7ee093dc625c679fc277c8eb623b > > ("powerpc/perf: Fix IMC_MAX_PMU macro") > >

Re: [PATCH stable 4.4] powerpc/boot: Request no dynamic linker for boot wrapper

2019-11-13 Thread Greg KH
On Tue, Nov 12, 2019 at 05:59:41PM +1100, Andrew Donnellan wrote: > From: Nicholas Piggin > > Commit ff45000fcb56b5b0f1a14a865d3541746d838a0a upstream. > > The boot wrapper performs its own relocations and does not require > PT_INTERP segment. However currently we don't tell the linker that. >

Re: [4.4] Backport request: powerpc: Fix compiling a BE kernel with a powerpc64le toolchain

2019-11-13 Thread Greg KH
On Tue, Nov 12, 2019 at 07:52:24PM +1100, Andrew Donnellan wrote: > Dear stable team > > Please backport the following patches. > > Commits: > > - 164af597ce945751e2dcd53d0a86e84203a6d117 > ("powerpc/Makefile: Use cflags-y/aflags-y for setting endian options") > > -

Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware

2019-10-15 Thread Greg KH
On Tue, Oct 15, 2019 at 06:40:29PM +0800, Yunsheng Lin wrote: > On 2019/10/14 17:25, Greg KH wrote: > > On Mon, Oct 14, 2019 at 04:00:46PM +0800, Yunsheng Lin wrote: > >> On 2019/10/12 18:47, Greg KH wrote: > >>> On Sat, Oct 12, 2019 at 12:40:01PM +0200, Greg KH wrot

Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware

2019-10-14 Thread Greg KH
On Mon, Oct 14, 2019 at 11:49:12AM +0200, Peter Zijlstra wrote: > On Mon, Oct 14, 2019 at 11:25:09AM +0200, Greg KH wrote: > > Good luck, I don't really think that most, if any, of this is needed, > > but hey, it's nice to clean it up where it can be :) > > Some of the vi

Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware

2019-10-14 Thread Greg KH
On Mon, Oct 14, 2019 at 04:00:46PM +0800, Yunsheng Lin wrote: > On 2019/10/12 18:47, Greg KH wrote: > > On Sat, Oct 12, 2019 at 12:40:01PM +0200, Greg KH wrote: > >> On Sat, Oct 12, 2019 at 05:47:56PM +0800, Yunsheng Lin wrote: > >>> On 2019/10/12 15:40, Greg KH wrot

Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware

2019-10-12 Thread Greg KH
On Sat, Oct 12, 2019 at 12:40:01PM +0200, Greg KH wrote: > On Sat, Oct 12, 2019 at 05:47:56PM +0800, Yunsheng Lin wrote: > > On 2019/10/12 15:40, Greg KH wrote: > > > On Sat, Oct 12, 2019 at 02:17:26PM +0800, Yunsheng Lin wrote: > > >> add pci and a

Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware

2019-10-12 Thread Greg KH
On Sat, Oct 12, 2019 at 05:47:56PM +0800, Yunsheng Lin wrote: > On 2019/10/12 15:40, Greg KH wrote: > > On Sat, Oct 12, 2019 at 02:17:26PM +0800, Yunsheng Lin wrote: > >> add pci and acpi maintainer > >> cc linux-...@vger.kernel.org and linux-a...@vger.kernel.org &g

Re: [PATCH v6] numa: make node_to_cpumask_map() NUMA_NO_NODE aware

2019-10-12 Thread Greg KH
On Sat, Oct 12, 2019 at 02:17:26PM +0800, Yunsheng Lin wrote: > add pci and acpi maintainer > cc linux-...@vger.kernel.org and linux-a...@vger.kernel.org > > On 2019/10/11 19:15, Peter Zijlstra wrote: > > On Fri, Oct 11, 2019 at 11:27:54AM +0800, Yunsheng Lin wrote: > >> But I failed to see why

Re: [PATCH] powerpc/xive: Fix bogus error code returned by OPAL

2019-09-23 Thread Greg KH
On Mon, Sep 23, 2019 at 08:29:40AM +0200, Greg Kurz wrote: > There's a bug in skiboot that causes the OPAL_XIVE_ALLOCATE_IRQ call > to return the 32-bit value 0x when OPAL has run out of IRQs. > Unfortunatelty, OPAL return values are signed 64-bit entities and > errors are supposed to be

Re: [WIP RFC PATCH 0/6] Generic Firmware Variable Filesystem

2019-06-05 Thread Greg KH
On Tue, Jun 04, 2019 at 01:05:45PM -0700, Matthew Garrett wrote: > On Tue, Jun 4, 2019 at 1:01 PM Nayna wrote: > > It seems efivars were first implemented in sysfs and then later > > separated out as efivarfs. > > Refer - Documentation/filesystems/efivarfs.txt. > > > > So, the reason wasn't that

Re: [WIP RFC PATCH 0/6] Generic Firmware Variable Filesystem

2019-06-05 Thread Greg KH
On Tue, Jun 04, 2019 at 04:33:14PM -0400, Nayna wrote: > > > On 06/03/2019 03:29 AM, Greg KH wrote: > > On Mon, Jun 03, 2019 at 04:04:32PM +1000, Daniel Axtens wrote: > > > Hi Nayna, > > > > > > > > As PowerNV moves towards secure boot, we nee

Re: [PATCH BACKPORTv2 4.19, 5.0, 5.1] crypto: vmx - ghash: do nosimd fallback manually

2019-06-03 Thread Greg KH
On Mon, Jun 03, 2019 at 12:08:48PM +1000, Daniel Axtens wrote: > commit 357d065a44cdd77ed5ff35155a989f2a763e96ef upstream. > [backported: the VMX driver did not use crypto_simd_usable() until > after 5.1] > > VMX ghash was using a fallback that did not support interleaving simd > and nosimd

Re: [WIP RFC PATCH 0/6] Generic Firmware Variable Filesystem

2019-06-03 Thread Greg KH
On Mon, Jun 03, 2019 at 04:04:32PM +1000, Daniel Axtens wrote: > Hi Nayna, > > >> As PowerNV moves towards secure boot, we need a place to put secure > >> variables. One option that has been canvassed is to make our secure > >> variables look like EFI variables. This is an early sketch of another

Re: Linux 5.1-rc5

2019-05-20 Thread Greg KH
On Thu, May 02, 2019 at 05:10:55PM +0200, Martin Schwidefsky wrote: > On Thu, 2 May 2019 16:31:10 +0200 > Greg KH wrote: > > > On Thu, May 02, 2019 at 04:17:58PM +0200, Martin Schwidefsky wrote: > > > On Thu, 2 May 2019 14:21:28 +0200 > > > Greg KH wrote: >

Re: [PATCH] kbuild: do not check name uniqueness of builtin modules

2019-05-20 Thread Greg KH
On Mon, May 20, 2019 at 11:54:37AM +0900, Masahiro Yamada wrote: > I just thought it was a good idea to scan builtin.modules in the name > uniqueness checking, but Stephen reported a false positive. > > ppc64_defconfig produces: > > warning: same basename if the following are built as modules:

Re: [PATCH stable 4.4] powerpc/lib: fix book3s/32 boot failure due to code patching

2019-05-15 Thread Greg KH
On Wed, May 15, 2019 at 01:30:42PM +, Christophe Leroy wrote: > [Backport of upstream commit b45ba4a51cde29b2939365ef0c07ad34c8321789] > > On powerpc32, patch_instruction() is called by apply_feature_fixups() > which is called from early_init() > > There is the following note in front of

Re: [PATCH stable 4.9] powerpc/lib: fix book3s/32 boot failure due to code patching

2019-05-15 Thread Greg KH
On Wed, May 15, 2019 at 02:35:36PM +0200, Christophe Leroy wrote: > > > Le 15/05/2019 à 10:29, Greg KH a écrit : > > On Wed, May 15, 2019 at 06:40:47AM +, Christophe Leroy wrote: > > > [Backport of upstream commit b45ba4a51cde29b2939365ef0c07ad34c8321789] &

Re: [PATCH stable 4.9] powerpc/lib: fix book3s/32 boot failure due to code patching

2019-05-15 Thread Greg KH
On Wed, May 15, 2019 at 06:40:47AM +, Christophe Leroy wrote: > [Backport of upstream commit b45ba4a51cde29b2939365ef0c07ad34c8321789] > > On powerpc32, patch_instruction() is called by apply_feature_fixups() > which is called from early_init() > > There is the following note in front of

Re: [Bug 203597] New: kernel 4.9.175 fails to boot on a PowerMac G4 3,6 at early stage

2019-05-14 Thread Greg KH
On Tue, May 14, 2019 at 06:56:03AM +0200, Christophe Leroy wrote: > Hi Greg, > > Could you please apply b45ba4a51cde29b2939365ef0c07ad34c8321789 to 4.9 since > 51c3c62b58b357e8d35e4cc32f7b4ec907426fe3 was applied allthought marked for > #4.13+ It does not apply there (nor to the 4.4.y queue,

Re: [PATCH 03/16] lib,treewide: add new match_string() helper/macro

2019-05-08 Thread Greg KH
On Wed, May 08, 2019 at 04:11:28PM +0300, Andy Shevchenko wrote: > On Wed, May 08, 2019 at 02:28:29PM +0300, Alexandru Ardelean wrote: > > This change re-introduces `match_string()` as a macro that uses > > ARRAY_SIZE() to compute the size of the array. > > The macro is added in all the places

Re: [PATCH v2] powerpc/powernv: Restrict OPAL symbol map to only be readable by root

2019-05-03 Thread Greg KH
On Fri, May 03, 2019 at 06:27:18PM +1000, Andrew Donnellan wrote: > On 3/5/19 5:59 pm, Greg KH wrote:>> -static BIN_ATTR_RO(symbol_map, 0); > > > +static struct bin_attribute symbol_map_attr = { > > > + .attr = {.name = "symbol_map", .mode = 0

Re: [PATCH v2] powerpc/powernv: Restrict OPAL symbol map to only be readable by root

2019-05-03 Thread Greg KH
On Fri, May 03, 2019 at 05:52:53PM +1000, Andrew Donnellan wrote: > Currently the OPAL symbol map is globally readable, which seems bad as it > contains physical addresses. > > Restrict it to root. > > Suggested-by: Michael Ellerman > Cc: Jordan Niethe > Cc: Stewart Smith > Fixes:

Re: [PATCH] powerpc/powernv: Restrict OPAL symbol map to only be readable by root

2019-05-03 Thread Greg KH
On Fri, May 03, 2019 at 05:44:05PM +1000, Andrew Donnellan wrote: > Currently the OPAL symbol map is globally readable, which seems bad as it > contains physical addresses. > > Restrict it to root. > > Suggested-by: Michael Ellerman > Cc: Jordan Niethe > Cc: Stewart Smith > Fixes:

Re: Linux 5.1-rc5

2019-05-02 Thread Greg KH
On Thu, May 02, 2019 at 04:17:58PM +0200, Martin Schwidefsky wrote: > On Thu, 2 May 2019 14:21:28 +0200 > Greg KH wrote: > > > On Mon, Apr 15, 2019 at 09:17:10AM -0700, Linus Torvalds wrote: > > > On Sun, Apr 14, 2019 at 10:19 PM Christoph Hellwig > > > wrote

Re: Linux 5.1-rc5

2019-05-02 Thread Greg KH
On Mon, Apr 15, 2019 at 09:17:10AM -0700, Linus Torvalds wrote: > On Sun, Apr 14, 2019 at 10:19 PM Christoph Hellwig wrote: > > > > Can we please have the page refcount overflow fixes out on the list > > for review, even if it is after the fact? > > They were actually on a list for review long

Re: [PATCH v2 stable v4.4 2/2] Documentation: Add nospectre_v1 parameter

2019-04-30 Thread Greg KH
On Tue, Apr 30, 2019 at 03:42:27PM +0300, Diana Craciun wrote: > commit 26cb1f36c43ee6e89d2a9f48a5a7500d5248f836 upstream. > > Currently only supported on powerpc. > > Signed-off-by: Diana Craciun > Signed-off-by: Michael Ellerman > --- > Documentation/kernel-parameters.txt | 4 > 1 file

Re: [PATCH v2 stable v4.4 2/2] Documentation: Add nospectre_v1 parameter

2019-04-30 Thread Greg KH
On Tue, Apr 30, 2019 at 03:42:27PM +0300, Diana Craciun wrote: > commit 26cb1f36c43ee6e89d2a9f48a5a7500d5248f836 upstream. > > Currently only supported on powerpc. > > Signed-off-by: Diana Craciun > Signed-off-by: Michael Ellerman > --- > Documentation/kernel-parameters.txt | 4 > 1 file

Re: [PATCH stable v4.4 0/8] missing powerpc spectre backports for 4.4

2019-04-30 Thread Greg KH
On Mon, Apr 29, 2019 at 06:49:00PM +0300, Diana Craciun wrote: > Hi Greg, > > These are missing patches from the initial powerpc spectre backports for 4.4. > Please queue them as well if you don't have any objections. I applied the first 6 of these now. If you could fix up the last two and

Re: [PATCH stable v4.4 8/8] Documentation: Add nospectre_v1 parameter

2019-04-30 Thread Greg KH
On Mon, Apr 29, 2019 at 06:49:08PM +0300, Diana Craciun wrote: > Currently only supported on powerpc. No upstream git commit id for this one? thanks, greg k-h

  1   2   3   4   5   >