Re: [PATCH] crypto: talitos - Fix sparse warnings

2020-10-07 Thread Herbert Xu
On Sat, Oct 03, 2020 at 07:15:53PM +0200, Christophe Leroy wrote: > > The following changes fix the sparse warnings with less churn: Yes that works too. Can you please submit this patch? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key

Re: [PATCH] soc: fsl: Remove bogus packed attributes from qman.h

2020-09-01 Thread Herbert Xu
which is not good. I think the following changes > are a better fix for the warnings: This works for me. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] soc: fsl: Remove bogus packed attributes from qman.h

2020-08-31 Thread Herbert Xu
ts contain no holes. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] soc: fsl: Remove bogus packed attributes from qman.h

2020-08-31 Thread Herbert Xu
On Thu, Jul 30, 2020 at 10:52:59PM +1000, Herbert Xu wrote: > There are two __packed attributes in qman.h that are both unnecessary > and causing compiler warnings because they're conflicting with > explicit alignment requirements set on members within the structure. > > This pat

Re: [PATCH 19/22] crypto: inside-secure - add check for xts input length equal to zero

2020-08-11 Thread Herbert Xu
everal other algorithms > mentioned in the cover letter. CTR accepts any input size. > What's the rule in these cases? What input size is accepted depends on the algorithm. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 19/22] crypto: inside-secure - add check for xts input length equal to zero

2020-08-10 Thread Herbert Xu
On Mon, Aug 10, 2020 at 10:20:20AM +, Van Leeuwen, Pascal wrote: > > With all due respect, but this makes no sense. I agree. This is a lot of churn for no gain. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~h

[PATCH] soc: fsl: Remove bogus packed attributes from qman.h

2020-07-30 Thread Herbert Xu
There are two __packed attributes in qman.h that are both unnecessary and causing compiler warnings because they're conflicting with explicit alignment requirements set on members within the structure. This patch removes them both. Signed-off-by: Herbert Xu diff --git a/include/soc/fsl/qman.h

[v2 PATCH] crypto: af_alg - Fix regression on empty requests

2020-07-01 Thread Herbert Xu
g ctx->init as long as one sendmsg(2) has been made, with or without a control message. Reported-by: Sachin Sant Reported-by: Naresh Kamboju Fixes: f3c802a1f300 ("crypto: algif_aead - Only wake up when...") Signed-off-by: Herbert Xu diff --git a/crypto/af_alg.c b/crypto/af_alg.c index 9fcb91

[PATCH] crypto: af_alg - Fix regression on empty requests

2020-06-26 Thread Herbert Xu
do not distinguish the case of no metadata as opposed to an empty request. IOW it is always assumed that if you call recv(2) before sending metadata that you are working with an empty request. Reported-by: Sachin Sant Reported-by: Naresh Kamboju Fixes: f3c802a1f300 ("crypto: algif_aead - Onl

Re: [next-20200621] LTP tests af_alg02/05 failure on POWER9 PowerVM LPAR

2020-06-22 Thread Herbert Xu
rough recvmsg(2). Setting the MSG_MORE flag indicates that your request has not been sent in full. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/7] sha1 library cleanup

2020-05-08 Thread Herbert Xu
pto/chacha.c | 1 - > lib/sha1.c | 24 --- > net/core/secure_seq.c | 1 - > net/ipv6/addrconf.c | 10 +++ > net/ipv6/seg6_hmac.c| 1 - > net/mptcp/crypto.c

Re: [PATCH] lib/mpi: Fix building for powerpc with clang

2020-04-15 Thread Herbert Xu
ported-by: kbuild test robot > Link: https://github.com/ClangBuiltLinux/linux/issues/991 > Signed-off-by: Nathan Chancellor Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 8/9] crypto/nx: Remove 'pid' in vas_tx_win_attr struct

2020-03-23 Thread Herbert Xu
owerpc/include/asm/vas.h| 1 - > drivers/crypto/nx/nx-common-powernv.c | 1 - > 2 files changed, 2 deletions(-) Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 7/9] crypto/nx: Enable and setup GZIP compression type

2020-03-23 Thread Herbert Xu
f-by: Haren Myneni > --- > drivers/crypto/nx/nx-common-powernv.c | 43 > ++- > 1 file changed, 37 insertions(+), 6 deletions(-) Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 6/9] crypto/NX: Make enable code generic to add new GZIP compression type

2020-03-23 Thread Herbert Xu
t; instead of 0 for per_cpu send window in nx_delete_coprocs(). > > Signed-off-by: Haren Myneni > --- > drivers/crypto/nx/nx-common-powernv.c | 161 > +- > 1 file changed, 101 insertions(+), 60 deletions(-) Acked-by: Herbert Xu -- E

Re: [PATCH v4 5/9] crypto/nx: Rename nx-842-powernv file name to nx-common-powernv

2020-03-23 Thread Herbert Xu
elete mode 100644 drivers/crypto/nx/nx-842-powernv.c > create mode 100644 drivers/crypto/nx/nx-common-powernv.c Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 4/9] crypto/nx: Initialize coproc entry with kzalloc

2020-03-23 Thread Herbert Xu
c->vas.rxwin > is not initialized. > > This patch replaces kmalloc with kzalloc in nx842_powernv_probe() > > Signed-off-by: Haren Myneni > --- > drivers/crypto/nx/nx-842-powernv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Herbert Xu -- Email: Herbert Xu

Re: [PATCH] crypto: Replace zero-length array with flexible-array member

2020-03-05 Thread Herbert Xu
rypto/omap-sham.c | 4 ++-- > include/crypto/if_alg.h| 2 +- > 10 files changed, 14 insertions(+), 14 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: vmx/xts - reject inputs that are too short

2020-01-15 Thread Herbert Xu
r.kernel.org # v5.4+ > Signed-off-by: Michael Ellerman > [dja: commit message] > Signed-off-by: Daniel Axtens > --- > drivers/crypto/vmx/aes_xts.c | 3 +++ > 1 file changed, 3 insertions(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 08/10] crypto/NX: Add NX GZIP user space API

2019-12-19 Thread Herbert Xu
to the underlying implementation. That is, even when the hardware is absent it would seamlessly switch over to a software implementation. I say normally because there can be exceptions, e.g., with paes and hardware keys. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 08/10] crypto/NX: Add NX GZIP user space API

2019-12-17 Thread Herbert Xu
insertions(+), 3 deletions(-) > create mode 100644 drivers/crypto/nx/nx-gzip-powernv.c We already have a kernel compress API which could be exposed to user-space through af_alg. If every driver created their own user-space API it would be unmanageable. Cheers, -- Email: Herbert Xu Home Pag

Re: [PATCH] crypto: vmx - Avoid weird build failures

2019-11-22 Thread Herbert Xu
lerman > --- > drivers/crypto/vmx/Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/5] crypto: nx - Improve debugfs_create_u{32,64}() handling for atomics

2019-10-25 Thread Herbert Xu
d-off-by: Geert Uytterhoeven > --- > drivers/crypto/nx/nx_debugfs.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/3] crypto: powerpc - convert SPE AES algorithms to skcipher API

2019-10-25 Thread Herbert Xu
s to skcipher API > > arch/powerpc/crypto/aes-spe-glue.c | 389 ++++++++- > crypto/Kconfig | 1 + > 2 files changed, 166 insertions(+), 224 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code

2019-10-25 Thread Herbert Xu
c | 4 +--- > drivers/char/hw_random/st-rng.c | 4 +--- > drivers/char/hw_random/tx4939-rng.c | 4 +--- > drivers/char/hw_random/xgene-rng.c | 4 +--- > 13 files changed, 13 insertions(+), 40 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/4] crypto: nx - convert to skcipher API

2019-10-18 Thread Herbert Xu
7 files changed, 176 insertions(+), 215 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: talitos - fix hash result for VMAP_STACK

2019-10-04 Thread Herbert Xu
> --- > drivers/crypto/talitos.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: nx - remove unused variables 'nx_driver_string' and 'nx_driver_version'

2019-08-30 Thread Herbert Xu
gt; They are never used, so just remove it. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > drivers/crypto/nx/nx.h | 3 --- > 1 file changed, 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [PATCH] crypto: vmx/xts - use fallback for ciphertext stealing

2019-08-21 Thread Herbert Xu
xts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] hwrng: Use device-managed registration API

2019-08-01 Thread Herbert Xu
ers/char/hw_random/powernv-rng.c | 10 +- > drivers/char/hw_random/st-rng.c| 4 +--- > drivers/char/hw_random/xgene-rng.c | 4 +--- > 9 files changed, 9 insertions(+), 36 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.

Re: [PATCH v2] crypto: nx: nx-842-powernv: Add of_node_put() before return

2019-08-01 Thread Herbert Xu
Issue found with Coccinelle. > > Acked-by: Stewart Smith > Signed-off-by: Nishka Dasgupta > > --- > Changes in v2: > - Fixed commit message to match the loop in question. > > drivers/crypto/nx/nx-842-powernv.c | 1 + > 1 file changed, 1 insertion(+) Patch applied.

Re: [PATCH v5 0/4] *** SUBJECT HERE ***

2019-07-03 Thread Herbert Xu
EC1. > crypto: talitos - drop icv_ool > > drivers/crypto/talitos.c | 102 > +++ > drivers/crypto/talitos.h | 28 + > lib/scatterlist.c| 9 +++-- > 3 files changed, 74 insertions(+), 65 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH V2] crypto/NX: Set receive window credits to max number of CRBs in RxFIFO

2019-06-27 Thread Herbert Xu
> CRBs from FIFO size and set it to receive window credits. > > Fixes: b0d6c9bab5e4 ("crypto/nx: Add P9 NX support for 842 compression > engine") > CC: sta...@vger.kernel.org # v4.14+ > Signed-off-by:Haren Myneni Patch applied. Thanks. -- Email: Herbert Xu Home P

Re: [PATCH] crypto: talitos - eliminate unneeded 'done' functions at build time

2019-06-27 Thread Herbert Xu
+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH V2] crypto/NX: Set receive window credits to max number of CRBs in RxFIFO

2019-06-27 Thread Herbert Xu
On Fri, Jun 28, 2019 at 11:43:16AM +1000, Michael Ellerman wrote: > > No. I assumed you'd take it because it's in drivers/crypto. > > If you want me to take it that's fine, just let me know. No that's fine Michael. I'll pick it up. Thanks, -- Email: Herbert Xu Hom

Re: [PATCH V2] crypto/NX: Set receive window credits to max number of CRBs in RxFIFO

2019-06-27 Thread Herbert Xu
receive window credits. > > Fixes: b0d6c9bab5e4 ("crypto/nx: Add P9 NX support for 842 compression > engine") > CC: sta...@vger.kernel.org # v4.14+ > Signed-off-by:Haren Myneni I presume this is being picked up by the powerpc tree? Thanks, -- Email: Herbert Xu Home P

Re: [PATCH v4 1/4] lib/scatterlist: Fix mapping iterator when sg->offset is greater than PAGE_SIZE

2019-06-24 Thread Herbert Xu
On Mon, Jun 24, 2019 at 08:35:33PM +0300, Imre Deak wrote: > Hi, > > On Thu, Jun 20, 2019 at 02:02:21PM +0800, Herbert Xu wrote: > > On Mon, Jun 17, 2019 at 09:15:02PM +, Christophe Leroy wrote: > > > All mapping iterator logic is based on the assumption that sg->o

Re: [PATCH v2] crypto: nx: no need to check return value of debugfs_create functions

2019-06-20 Thread Herbert Xu
ugfs file names, > especially as the whole directiry is deleted at once, so remove the > unneeded structure entirely. > > Cc: "Breno Leitão" > Cc: Nayna Jain > Cc: Paulo Flabiano Smorigo > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > C

Re: [PATCH] crypto: talitos - fix max key size for sha384 and sha512

2019-06-20 Thread Herbert Xu
alitos - reduce max key size for SEC1") > Signed-off-by: Christophe Leroy > --- > drivers/crypto/talitos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: vmx - Document CTR mode counter width quirks

2019-06-20 Thread Herbert Xu
ers/crypto/vmx/aesp8-ppc.pl | 22 -- > 1 file changed, 20 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 1/4] lib/scatterlist: Fix mapping iterator when sg->offset is greater than PAGE_SIZE

2019-06-20 Thread Herbert Xu
set ? 0 : sg->offset; > + offset = pgoffset ? 0 : sg->offset; > + while (offset >= PAGE_SIZE) { > + miter->piter.sg_pgoffset = ++pgoffset; > + offset -= PAGE_SIZE; > + } How about

Re: [PATCH v2 4/4] crypto: talitos - drop icv_ool

2019-06-13 Thread Herbert Xu
y tree before it got merged. > > Do I have to resend it or can Herbert just drop the wrong reference and take > the following one: Please resend since you're going to change the other patches too. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v1 00/15] Fixing selftests failure on Talitos driver

2019-05-30 Thread Herbert Xu
pto/talitos.c | 281 > ++- > drivers/crypto/talitos.h | 45 ++-- > 2 files changed, 139 insertions(+), 187 deletions(-) Patch 1 was already applied. 2-15 applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: testmgr - fix length truncation with large page size

2019-05-30 Thread Herbert Xu
nst their generic > implementation") > Signed-off-by: Eric Biggers > --- > crypto/testmgr.h | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: vmx - convert to skcipher API

2019-05-30 Thread Herbert Xu
--- > drivers/crypto/vmx/aes_ctr.c | 165 + > drivers/crypto/vmx/aes_xts.c | 175 ++- > drivers/crypto/vmx/aesp8-ppc.h | 2 - > drivers/crypto/vmx/vmx.c | 72 +++-- > 5 files changed, 252 inse

Re: [PATCH] crypto: vmx - convert to SPDX license identifiers

2019-05-30 Thread Herbert Xu
-- > drivers/crypto/vmx/aes_cbc.c | 14 +- > drivers/crypto/vmx/aes_ctr.c | 14 +- > drivers/crypto/vmx/aes_xts.c | 14 +- > drivers/crypto/vmx/vmx.c | 14 +- > 5 files changed, 5 insertions(+), 65 deletions(-) Patch applied. T

Re: [PATCH] crypto: talitos - fix skcipher failure due to wrong output IV

2019-05-23 Thread Herbert Xu
that. > > Signed-off-by: Christophe Leroy > --- > drivers/crypto/talitos.c | 4 > 1 file changed, 4 insertions(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: vmx - CTR: always increment IV as quadword

2019-05-17 Thread Herbert Xu
s well. > --- > drivers/crypto/vmx/aesp8-ppc.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: vmx - ghash: do nosimd fallback manually

2019-05-17 Thread Herbert Xu
, 86 insertions(+), 125 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: vmx - ghash: do nosimd fallback manually

2019-05-16 Thread Herbert Xu
you > merge it? I can add this when applying the patch. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: vmx - fix copy-paste error in CTR mode

2019-05-14 Thread Herbert Xu
ou think you will need? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: vmx - fix copy-paste error in CTR mode

2019-05-12 Thread Herbert Xu
On Mon, May 06, 2019 at 08:53:17AM -0700, Eric Biggers wrote: > > Any progress on this? Someone just reported this again here: > https://bugzilla.kernel.org/show_bug.cgi?id=203515 Guys if I don't get a fix for this soon I'll have to disable CTR in vmx. Cheers, -- Email: Herbert Xu

Re: [PATCH] crypto: caam/jr - Remove extra memory barrier during job ring dequeue

2019-05-08 Thread Herbert Xu
would work both for ARM and PPC, and avoid ifdeffery etc.? Since no fix has been found I'm reverting the commit in question. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: powerpc - convert to use crypto_simd_usable()

2019-04-18 Thread Herbert Xu
ypto/vmx/aes_xts.c| 5 +++-- > drivers/crypto/vmx/ghash.c | 9 - > 8 files changed, 25 insertions(+), 17 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: nx842 - remove set but not used variables 'dpadding' and 'max_sync_size'

2019-04-08 Thread Herbert Xu
es.c | 6 ++ > drivers/crypto/nx/nx-842.c | 3 +-- > 2 files changed, 3 insertions(+), 6 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: vmx - Make p8_init and p8_exit static

2019-03-28 Thread Herbert Xu
8_exit' was not declared. Should it be static? > > Signed-off-by: YueHaibing > --- > drivers/crypto/vmx/vmx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: vmx - fix copy-paste error in CTR mode

2019-03-22 Thread Herbert Xu
ed3 ("crypto: vmx - Add support for VMS instructions by ASM") > Cc: sta...@vger.kernel.org > Signed-off-by: Daniel Axtens > --- > drivers/crypto/vmx/aesp8-ppc.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert X

Re: [PATCH v4 1/2] crypto: talitos - reorder code in talitos_edesc_alloc()

2019-01-10 Thread Herbert Xu
rs/crypto/talitos.c | 25 +++-- > 1 file changed, 7 insertions(+), 18 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3] crypto: talitos - fix ablkcipher for CONFIG_VMAP_STACK

2019-01-07 Thread Herbert Xu
5] alg: skcipher: encryption failed on test 1 for > ecb-aes-talitos: ret=22 > > IV cannot be on stack when CONFIG_VMAP_STACK is selected because the stack > cannot be DMA mapped anymore. > > This patch copies the IV into the extended descriptor when iv is not > a valid

Re: [PATCH] crypto: talitos - fix ablkcipher for CONFIG_VMAP_STACK

2018-12-11 Thread Herbert Xu
ctx->iv, 0, areq->nbytes, 0, ivsize, 0, > areq->base.flags, encrypt); > } Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto/testmgr: fix skcipher test with CONFIG_VMAP_STACK

2018-12-10 Thread Herbert Xu
test 1 for > > ecb-aes-talitos: ret=22 > > > > IV cannot be on stack when CONFIG_VMAP_STACK is selected because the stack > > cannot be DMA mapped anymore. > > > > This patch allocates it with kmalloc() > > > > This looks like a driver bug to me. Ot

Re: [PATCH v2] crypto: vmx - Fix sleep-in-atomic bugs

2018-08-25 Thread Herbert Xu
0] [c0b02bb8] __sys_recvmsg+0x68/0xe0 > [ 891.866631] [c00338757e30] [c000bbe4] system_call+0x5c/0x70 > > Fixes: 8c755ace357c ("crypto: vmx - Adding CBC routines for VMX module") > Fixes: c07f5d3da643 ("crypto: vmx - Adding support for XTS&qu

Re: [PATCH 0/6] lib/crc32: treewide: Use existing define with polynomial

2018-07-27 Thread Herbert Xu
| 11 ++- > lib/crc32defs.h | 14 -- > lib/decompress_bunzip2.c | 3 ++- > lib/gen_crc32table.c | 5 +++-- > lib/xz/xz_crc32.c| 3 ++- >

Re: [PATCH] crypto: reorder paes test lexicographically

2018-05-18 Thread Herbert Xu
for hardware keys") > Reported-by: Abdul Haleem <abdha...@linux.vnet.ibm.com> > Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: nx: fix spelling mistake: "seqeunce" -> "sequence"

2018-05-18 Thread Herbert Xu
On Wed, May 09, 2018 at 10:16:36AM +0100, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistake in CSB_ERR error message text > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Patch applied. Thanks.

Re: [PATCH 2/2] crypto: vmx - Remove overly verbose printk from AES XTS init

2018-05-11 Thread Herbert Xu
gt; > Fixes: c07f5d3da643 ("crypto: vmx - Adding support for XTS") > Cc: sta...@vger.kernel.org # v4.8+ > Signed-off-by: Michael Ellerman <m...@ellerman.id.au> > --- > drivers/crypto/vmx/aes_xts.c | 2 -- > 1 file changed, 2 deletions(-) Patch applied. Thanks. -- Email:

Re: [PATCH 1/2] crypto: vmx - Remove overly verbose printk from AES init routines

2018-05-11 Thread Herbert Xu
m_call+0x58/0x6c > > > Is it normal for init to be called on every system call? This is the tfm init function, so yes it is called every time you allocate a tfm. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: talitos - fix IPsec cipher in length

2018-03-30 Thread Herbert Xu
: <sta...@vger.kernel.org> # 4.8+ > Fixes: 549bd8bc5987 ("crypto: talitos - Implement AEAD for SEC1 using > HMAC_SNOOP_NO_AFEU") > Reported-by: Horia Geantă <horia.gea...@nxp.com> > Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr> Patch applied. Than

Re: [PATCH 1/2] crypto: talitos - don't persistently map req_ctx->hw_context and req_ctx->buf

2018-03-09 Thread Herbert Xu
chain in buffered data for ahash on > SEC1") > Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 2/2] crypto: talitos - do not perform unnecessary dma synchronisation

2018-03-09 Thread Herbert Xu
t; to necessary situations. > > Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: nx-842: Delete an error message for a failed memory allocation in nx842_pseries_init()

2018-02-22 Thread Herbert Xu
by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 16/18] crypto: talitos - do hw_context DMA mapping outside the requests

2018-02-22 Thread Herbert Xu
do batching in drivers. Such optimisations should instead be done at a higher level. For example, for disk encryption we want to do the aggregation at the block layer rather than the crypto API because that has innate knowledge of the data layout which we can only guess. Cheers, -- Email: Herb

Re: [PATCH 16/18] crypto: talitos - do hw_context DMA mapping outside the requests

2018-02-22 Thread Herbert Xu
t; > .init() -> .update() -> .finup() > ^| | > '' '---> HASH > >.digest() >| >'---> HASH The documentation is simply incomplete in this regard. Cheers, -- Email: Herbert Xu <herb...@

Re: [PATCH 16/18] crypto: talitos - do hw_context DMA mapping outside the requests

2018-02-20 Thread Herbert Xu
curs is unacceptable, both from user-space and the kernel. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: talitos: fix Kernel Oops on hashing an empty file

2018-02-09 Thread Herbert Xu
t Oops by checking if src is NULL. > > Fixes: 6a1e8d14156d4 ("crypto: talitos - making mapping helpers more generic") > Cc: <sta...@vger.kernel.org> > Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 00/18] crypto: talitos - fixes and performance improvement

2017-12-11 Thread Herbert Xu
On Fri, Dec 08, 2017 at 03:20:40PM +, Horia Geantă wrote: > On 10/12/2017 6:20 PM, Herbert Xu wrote: > > On Fri, Oct 06, 2017 at 03:04:31PM +0200, Christophe Leroy wrote: > >> This serie fixes and improves the talitos crypto driver. > >> > >> First 6 p

Re: [PATCH][V2] crypto/nx: fix spelling mistake: "availavle" -> "available"

2017-11-28 Thread Herbert Xu
.k...@canonical.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: vmx - Use skcipher for ctr fallback

2017-11-03 Thread Herbert Xu
On Mon, Oct 16, 2017 at 08:54:19PM -0200, Paulo Flabiano Smorigo wrote: > Signed-off-by: Paulo Flabiano Smorigo <pfsmor...@linux.vnet.ibm.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert

Re: [PATCH 00/18] crypto: talitos - fixes and performance improvement

2017-10-12 Thread Herbert Xu
rypto: talitos - remove to_talitos_ptr_len() > crypto: talitos - simplify tests in ipsec_esp() > crypto: talitos - DMA map key in setkey() > crypto: talitos - do hw_context DMA mapping outside the requests > crypto: talitos - chain in buffered data for ahash on SEC1 >

Re: [PATCH 00/11] crypto: gcm - add GCM IV size constant

2017-09-22 Thread Herbert Xu
nstant > crypto: chelsio - Use GCM IV size constant > crypto: omap - Use GCM IV size constant > crypto: gcm - Use GCM IV size constant > crypto: aesni - Use GCM IV size constant All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home

Re: [PATCH] crypto: nx: 842: constify vio_device_id

2017-09-22 Thread Herbert Xu
v <arvind.yadav...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] hwrng: pseries: constify vio_device_id

2017-09-22 Thread Herbert Xu
v <arvind.yadav...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: nx: constify vio_device_id

2017-09-22 Thread Herbert Xu
v <arvind.yadav...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: talitos - Don't provide setkey for non hmac hashing algs.

2017-09-21 Thread Herbert Xu
t;Generation of hash for file kcap"..., 50) = 50 > munmap(0x77f5, 378880) = 0 > > This patch ensures that setkey() function is set only > for hmac hashing. > > Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr> Patch applied.

Re: [PATCH] crypto: talitos - fix hashing

2017-09-21 Thread Herbert Xu
test > > This patch fixes this issue > > Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: talitos - fix sha224

2017-09-21 Thread Herbert Xu
6c a5 f9 55 ea fd 0e 72 05 22 > > This patch fixes it > > Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH V3 2/6] crypto/nx: Create nx842_configure_crb function

2017-08-03 Thread Herbert Xu
On Thu, Aug 03, 2017 at 07:53:16PM +1000, Michael Ellerman wrote: > Herbert Xu <herb...@gondor.apana.org.au> writes: > > > On Fri, Jul 21, 2017 at 09:57:39PM -0700, Haren Myneni wrote: > >> > >> Configure CRB is moved to nx842_configure_crb() so that it can

Re: [PATCH V3 2/6] crypto/nx: Create nx842_configure_crb function

2017-08-03 Thread Herbert Xu
com> Your patch does not apply against cryptodev. Please rebase. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: talitos: Extend max key length for SHA384/512-HMAC and AEAD

2017-06-19 Thread Herbert Xu
size for the > AEAD size for AES256 + HMAC(SHA512). > > Cc: <sta...@vger.kernel.org> # 3.6+ > Fixes: 357fb60502ede ("crypto: talitos - add sha224, sha384 and sha512 to > existing AEAD algorithms") > Signed-off-by: Martin Hicks <m...@bork.org> Patch applied.

Re: [PATCH v2] powerpc/crypto/crct10dif-vpmsum: Fix missing preempt_disable()

2017-04-21 Thread Herbert Xu
eration") > Acked-by: Daniel Axtens <d...@axtens.net> > Signed-off-by: Michael Ellerman <m...@ellerman.id.au> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/4] crypto: powerpc - Factor out the core CRC vpmsum algorithm

2017-03-24 Thread Herbert Xu
ser simply > provides constants, defines the name of their CRC function, > and then #includes the core algorithm file. > > Cc: Anton Blanchard <an...@samba.org> > Signed-off-by: Daniel Axtens <d...@axtens.net> All patches applied. Thanks. -- Email: Herbert

Re: [PATCH] crypto: powerpc - Fix initialisation of crc32c context

2017-03-08 Thread Herbert Xu
> Fixes: 6dd7a82cc54e ("crypto: powerpc - Add POWER8 optimised crc32c") > Cc: Anton Blanchard <an...@samba.org> > Cc: sta...@vger.kernel.org > Signed-off-by: Daniel Axtens <d...@axtens.net> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au>

Re: [PATCH v3 1/2] crypto: vmx - Use skcipher for cbc fallback

2017-03-02 Thread Herbert Xu
On Wed, Mar 01, 2017 at 10:58:20AM -0300, Paulo Flabiano Smorigo wrote: > Signed-off-by: Paulo Flabiano Smorigo <pfsmor...@linux.vnet.ibm.com> > --- Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herb

Re: [PATCH v3 2/2] crypto: vmx - Use skcipher for xts fallback

2017-03-02 Thread Herbert Xu
On Wed, Mar 01, 2017 at 11:00:00AM -0300, Paulo Flabiano Smorigo wrote: > Signed-off-by: Paulo Flabiano Smorigo <pfsmor...@linux.vnet.ibm.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert

Re: [PATCH 1/2] crypto: vmx - Use skcipher for cbc fallback

2017-02-23 Thread Herbert Xu
in order to ensure that you get a sync algorithm. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] powerpc: crypto/vmx: various build fixes

2016-11-17 Thread Herbert Xu
w > files in the build tree, rather than the source tree. > > Signed-off-by: Michael Ellerman <m...@ellerman.id.au> > Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http:

Re: [PATCH] powerpc: crypto/vmx: various build fixes

2016-11-17 Thread Herbert Xu
On Thu, Nov 17, 2016 at 11:51:56AM +1100, Michael Ellerman wrote: > > But maybe Herbert can fix it up for you when he applies this. Sure I can fix it up. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.

Re: [PATCH 0/3] Fix crypto/vmx/p8_ghash memory corruption

2016-10-02 Thread Herbert Xu
versions, please add the lines in the sign off to > get it into the stable kernels. I have added them to patches 1 and 2. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/3] Fix crypto/vmx/p8_ghash memory corruption

2016-10-02 Thread Herbert Xu
to a new header file > crypto: vmx - Fix memory corruption caused by p8_ghash > crypto: vmx - Ensure ghash-generic is enabled Patch 1/2 applied to crypto. I have changed patch 3 to use select instead of depend and have applied it to cryptodev. Thanks. -- Email: Herbert Xu <herb...@g

Re: [PATCH] crypto: sha1-powerpc: little-endian support

2016-10-02 Thread Herbert Xu
On Fri, Sep 23, 2016 at 04:31:56PM -0300, Marcelo Cerri wrote: > The driver does not handle endianness properly when loading the input > data. > > Signed-off-by: Marcelo Cerri <marcelo.ce...@canonical.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.ap

  1   2   3   >