Re: [PATCH 13/13] ASoC: sunxi: Use snd_soc_substream_to_rtd() for accessing private_data

2024-04-30 Thread Jernej Škrabec
Dne torek, 30. april 2024 ob 16:02:22 GMT +2 je Krzysztof Kozlowski napisal(a):
> Do not open-code snd_soc_substream_to_rtd().
> 
> Signed-off-by: Krzysztof Kozlowski 

Reviewed-by: Jernej Skrabec 

Best regards,
Jernej

> ---
>  sound/soc/sunxi/sun50i-dmic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sunxi/sun50i-dmic.c b/sound/soc/sunxi/sun50i-dmic.c
> index c76628bc86c6..fedfa4fc95fb 100644
> --- a/sound/soc/sunxi/sun50i-dmic.c
> +++ b/sound/soc/sunxi/sun50i-dmic.c
> @@ -74,7 +74,7 @@ static const struct dmic_rate dmic_rate_s[] = {
>  static int sun50i_dmic_startup(struct snd_pcm_substream *substream,
>  struct snd_soc_dai *cpu_dai)
>  {
> - struct snd_soc_pcm_runtime *rtd = substream->private_data;
> + struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
>   struct sun50i_dmic_dev *host = 
> snd_soc_dai_get_drvdata(snd_soc_rtd_to_cpu(rtd, 0));
>  
>   /* only support capture */
> 
> 






Re: [PATCH 9/9] mmc: Convert from tasklet to BH workqueue

2024-03-27 Thread Jernej Škrabec
Dne sreda, 27. marec 2024 ob 17:03:14 CET je Allen Pais napisal(a):
> The only generic interface to execute asynchronously in the BH context is
> tasklet; however, it's marked deprecated and has some design flaws. To
> replace tasklets, BH workqueue support was recently added. A BH workqueue
> behaves similarly to regular workqueues except that the queued work items
> are executed in the BH context.
> 
> This patch converts drivers/infiniband/* from tasklet to BH workqueue.

infiniband -> mmc

Best regards,
Jernej

> 
> Based on the work done by Tejun Heo 
> Branch: https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-6.10
> 
> Signed-off-by: Allen Pais 





Re: [PATCH RESEND 1/5] ASoC: Explicitly include correct DT includes

2023-10-03 Thread Jernej Škrabec
Dne torek, 03. oktober 2023 ob 20:13:10 CEST je Rob Herring napisal(a):
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it was merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
> 
> Signed-off-by: Rob Herring 
> ---
>  sound/soc/atmel/atmel_wm8904.c | 1 -
>  sound/soc/atmel/mchp-i2s-mcc.c | 2 +-
>  sound/soc/atmel/tse850-pcm5142.c   | 1 -
>  sound/soc/bcm/cygnus-ssp.c | 2 +-
>  sound/soc/codecs/adau1701.c| 1 -
>  sound/soc/codecs/adau1977-spi.c| 1 -
>  sound/soc/codecs/ak4104.c  | 2 +-
>  sound/soc/codecs/ak4118.c  | 2 +-
>  sound/soc/codecs/ak4375.c  | 2 +-
>  sound/soc/codecs/ak4458.c  | 2 +-
>  sound/soc/codecs/ak4613.c  | 2 +-
>  sound/soc/codecs/ak4642.c  | 2 +-
>  sound/soc/codecs/ak5558.c  | 2 +-
>  sound/soc/codecs/cs35l32.c | 2 +-
>  sound/soc/codecs/cs35l33.c | 2 --
>  sound/soc/codecs/cs35l34.c | 2 +-
>  sound/soc/codecs/cs35l35.c | 3 +--
>  sound/soc/codecs/cs35l36.c | 3 +--
>  sound/soc/codecs/cs35l41-i2c.c | 2 +-
>  sound/soc/codecs/cs35l41.c | 1 -
>  sound/soc/codecs/cs4270.c  | 2 +-
>  sound/soc/codecs/cs42l42.c | 1 -
>  sound/soc/codecs/cs42l56.c | 2 +-
>  sound/soc/codecs/cs42xx8-i2c.c | 2 +-
>  sound/soc/codecs/cs43130.c | 3 +--
>  sound/soc/codecs/cs4349.c  | 2 +-
>  sound/soc/codecs/da7213.c  | 2 +-
>  sound/soc/codecs/da7219.c  | 2 +-
>  sound/soc/codecs/da9055.c  | 1 -
>  sound/soc/codecs/es8328.c  | 1 -
>  sound/soc/codecs/gtm601.c  | 2 +-
>  sound/soc/codecs/lpass-macro-common.c  | 2 +-
>  sound/soc/codecs/mt6351.c  | 2 +-
>  sound/soc/codecs/mt6358.c  | 2 +-
>  sound/soc/codecs/mt6359-accdet.c   | 4 
>  sound/soc/codecs/mt6359.c  | 2 +-
>  sound/soc/codecs/nau8540.c | 2 +-
>  sound/soc/codecs/pcm1681.c | 2 --
>  sound/soc/codecs/rt715.c   | 2 --
>  sound/soc/codecs/sgtl5000.c| 2 +-
>  sound/soc/codecs/sma1303.c | 2 +-
>  sound/soc/codecs/sta32x.c  | 3 +--
>  sound/soc/codecs/sta350.c  | 3 +--
>  sound/soc/codecs/tas571x.c | 2 +-
>  sound/soc/codecs/uda1334.c | 2 +-
>  sound/soc/codecs/wm8510.c  | 2 +-
>  sound/soc/codecs/wm8523.c  | 2 +-
>  sound/soc/codecs/wm8524.c  | 2 +-
>  sound/soc/codecs/wm8580.c  | 2 +-
>  sound/soc/codecs/wm8711.c  | 2 +-
>  sound/soc/codecs/wm8728.c  | 2 +-
>  sound/soc/codecs/wm8731-i2c.c  | 2 +-
>  sound/soc/codecs/wm8731-spi.c  | 2 +-
>  sound/soc/codecs/wm8737.c  | 2 +-
>  sound/soc/codecs/wm8741.c  | 2 +-
>  sound/soc/codecs/wm8750.c  | 2 +-
>  sound/soc/codecs/wm8753.c  | 2 +-
>  sound/soc/codecs/wm8770.c  | 2 +-
>  sound/soc/codecs/wm8776.c  | 2 +-
>  sound/soc/codecs/wm8804.c  | 1 -
>  sound/soc/fsl/efika-audio-fabric.c | 4 ++--
>  sound/soc/fsl/fsl_aud2htx.c| 3 +--
>  sound/soc/fsl/fsl_mqs.c| 2 

Re: [PATCH 15/19] cpufreq: sun50i: Add explicit include for cpu.h

2023-03-29 Thread Jernej Škrabec
Dne sreda, 29. marec 2023 ob 17:52:12 CEST je Rob Herring napisal(a):
> Removing the include of cpu.h from of_device.h causes an error:
> 
> drivers/cpufreq/sun50i-cpufreq-nvmem.c:42:19: error: implicit declaration of
> function ‘get_cpu_device’; did you mean ‘get_device’?
> [-Werror=implicit-function-declaration]
> 
> As of_device.h is not otherwise needed, it can be replaced with of.h
> (also implicitly included).
> 
> Signed-off-by: Rob Herring 
> ---

Acked-by: Jernej Skrabec 

Best regards,
Jernej




Re: [PATCH 2/5] arm: dts: remove label = "cpu" from DSA dt-binding

2022-12-05 Thread Jernej Škrabec
Dne sreda, 30. november 2022 ob 15:10:37 CET je Arınç ÜNAL napisal(a):
> This is not used by the DSA dt-binding, so remove it from all devicetrees.
> 
> Signed-off-by: Arınç ÜNAL 
> ---
>  arch/arm/boot/dts/armada-370-rd.dts   | 1 -
>  arch/arm/boot/dts/armada-381-netgear-gs110emx.dts | 1 -
>  arch/arm/boot/dts/armada-385-clearfog-gtr-l8.dts  | 1 -
>  arch/arm/boot/dts/armada-385-clearfog-gtr-s4.dts  | 1 -
>  arch/arm/boot/dts/armada-385-linksys.dtsi | 1 -
>  arch/arm/boot/dts/armada-385-turris-omnia.dts | 1 -
>  arch/arm/boot/dts/armada-388-clearfog.dts | 1 -
>  arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 1 -
>  arch/arm/boot/dts/at91-sama5d2_icp.dts| 1 -
>  arch/arm/boot/dts/at91-sama5d3_ksz9477_evb.dts| 1 -
>  arch/arm/boot/dts/bcm-cygnus.dtsi | 1 -
>  arch/arm/boot/dts/bcm4708-buffalo-wzr-1166dhp-common.dtsi | 1 -
>  arch/arm/boot/dts/bcm4708-luxul-xap-1510.dts  | 1 -
>  arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts  | 1 -
>  arch/arm/boot/dts/bcm4708-netgear-r6250.dts   | 1 -
>  arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts | 1 -
>  arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts| 1 -
>  arch/arm/boot/dts/bcm47081-luxul-xap-1410.dts | 1 -
>  arch/arm/boot/dts/bcm47081-luxul-xwr-1200.dts | 1 -
>  arch/arm/boot/dts/bcm4709-netgear-r8000.dts   | 1 -
>  arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts  | 3 ---
>  arch/arm/boot/dts/bcm47094-dlink-dir-885l.dts | 1 -
>  arch/arm/boot/dts/bcm47094-linksys-panamera.dts   | 4 
>  arch/arm/boot/dts/bcm47094-luxul-abr-4500.dts | 1 -
>  arch/arm/boot/dts/bcm47094-luxul-xap-1610.dts | 1 -
>  arch/arm/boot/dts/bcm47094-luxul-xbr-4500.dts | 1 -
>  arch/arm/boot/dts/bcm47094-luxul-xwc-2000.dts | 1 -
>  arch/arm/boot/dts/bcm47094-luxul-xwr-3100.dts | 1 -
>  arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts  | 1 -
>  arch/arm/boot/dts/bcm47189-tenda-ac9.dts  | 1 -
>  arch/arm/boot/dts/bcm53015-meraki-mr26.dts| 1 -
>  arch/arm/boot/dts/bcm53016-meraki-mr32.dts| 1 -
>  arch/arm/boot/dts/bcm953012er.dts | 1 -
>  arch/arm/boot/dts/bcm958622hr.dts | 1 -
>  arch/arm/boot/dts/bcm958623hr.dts | 1 -
>  arch/arm/boot/dts/bcm958625hr.dts | 1 -
>  arch/arm/boot/dts/bcm958625k.dts  | 1 -
>  arch/arm/boot/dts/bcm988312hr.dts | 1 -
>  arch/arm/boot/dts/gemini-dlink-dir-685.dts| 1 -
>  arch/arm/boot/dts/gemini-sl93512r.dts | 1 -
>  arch/arm/boot/dts/gemini-sq201.dts| 1 -
>  arch/arm/boot/dts/imx51-zii-rdu1.dts  | 1 -
>  arch/arm/boot/dts/imx51-zii-scu2-mezz.dts | 1 -
>  arch/arm/boot/dts/imx51-zii-scu3-esb.dts  | 1 -
>  arch/arm/boot/dts/imx53-kp-hsc.dts| 1 -
>  arch/arm/boot/dts/imx6dl-yapp4-common.dtsi| 1 -
>  arch/arm/boot/dts/imx6q-b450v3.dts| 1 -
>  arch/arm/boot/dts/imx6q-b650v3.dts| 1 -
>  arch/arm/boot/dts/imx6q-b850v3.dts| 1 -
>  arch/arm/boot/dts/imx6qdl-gw5904.dtsi | 1 -
>  arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi   | 1 -
>  arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi   | 1 -
>  arch/arm/boot/dts/imx6qp-prtwd3.dts   | 1 -
>  arch/arm/boot/dts/imx7d-zii-rpu2.dts  | 1 -
>  arch/arm/boot/dts/kirkwood-dir665.dts | 1 -
>  arch/arm/boot/dts/kirkwood-l-50.dts   | 1 -
>  arch/arm/boot/dts/kirkwood-linksys-viper.dts  | 1 -
>  arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts| 1 -
>  arch/arm/boot/dts/kirkwood-rd88f6281.dtsi | 1 -
>  arch/arm/boot/dts/mt7623a-rfb-emmc.dts| 1 -
>  arch/arm/boot/dts/mt7623a-rfb-nand.dts| 1 -
>  arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 1 -
>  arch/arm/boot/dts/mt7623n-rfb-emmc.dts| 1 -
>  arch/arm/boot/dts/orion5x-netgear-wnr854t.dts | 1 -
>  arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 2 --
>  arch/arm/boot/dts/r9a06g032.dtsi  | 1 -
>  arch/arm/boot/dts/stm32mp151a-prtt1c.dts  | 1 -
>  arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts | 1 -

For sun7i:

Acked-by: Jernej Skrabec 

Best regards,
Jernej

>  arch/arm/boot/dts/vf610-zii-cfu1.dts  | 1 -
>  arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 1 -
>  arch/arm/boot/dts/vf610-zii-dev-rev-c.dts