Re: [PATCH v15 09/10] arm64: Call kmalloc() to allocate DTB buffer

On Thu, 2021-01-28 at 00:52 -0300, Thiago Jung Bauermann wrote: > The problem is that this patch implements only part of the suggestion, > which isn't useful in itself. So the patch series should either drop > this patch or consolidate the FDT allocation between the arches. > > I just tested on

Re: [PATCH] powerpc/xmon: Change printk() to pr_cont()

On Fri, 2020-12-04 at 21:56 +1100, Michael Ellerman wrote: > Christophe Leroy writes: > > Since some time now, printk() adds carriage return, leading to > > unusable xmon output: > > > > [ 54.288722] sysrq: Entering xmon > > [ 54.292209] Vector: 0 at [cace3d2c] > > [ 54.292274] pc: >

Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

On Fri, 2020-10-23 at 08:08 +0200, Miguel Ojeda wrote: > On Thu, Oct 22, 2020 at 4:36 AM Joe Perches wrote: > > > > Use a more generic form for __section that requires quotes to avoid > > complications with clang and gcc differences. > > I performed vi

Re: [PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

On Thu, 2020-10-22 at 13:42 -0700, Nick Desaulniers wrote: > .On Wed, Oct 21, 2020 at 7:36 PM Joe Perches wrote: > > Use a more generic form for __section that requires quotes to avoid > > complications with clang and gcc differences. [] > > a quick test of x86_64 and s390 w

[PATCH] treewide: Convert macro and uses of __section(foo) to __section("foo")

ction("foo"))) uses to __section("foo") even if the __attribute__ has multiple list entry forms. Conversion done using a script: Link: https://lore.kernel.org/lkml/75393e5ddc272dc7403de74d645e6c6e0f4e70eb.ca...@perches.com/2-convert_section.pl Signed-off-by: Joe Perches ---

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

On Tue, 2020-10-06 at 00:34 +, Joel Stanley wrote: > arch/powerpc/boot is the powerpc wrapper, and it's not built with the > same includes or flags as the rest of the kernel. It doesn't include > any of the headers in the top level include/ directory for hysterical > raisins. > > The

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

On Mon, 2020-10-05 at 11:36 -0700, Nick Desaulniers wrote: > I don't think there's anything wrong with manually including it and adding `-I > ` (capital i) if needed. All of this is secondary to the actual change to use quoted __section("foo") rather than __section(foo) I'd rather get that done

Re: Where is the declaration of buffer used in kernel_param_ops .get functions?

On Sun, 2020-10-04 at 02:36 +0100, Matthew Wilcox wrote: > On Sat, Oct 03, 2020 at 06:19:18PM -0700, Joe Perches wrote: > > These patches came up because I was looking for > > the location of the declaration of the buffer used > > in kernel/params.c struct kernel_param_o

Where is the declaration of buffer used in kernel_param_ops .get functions?

These patches came up because I was looking for the location of the declaration of the buffer used in kernel/params.c struct kernel_param_ops .get functions. I didn't find it. I want to see if it's appropriate to convert the sprintf family of functions used in these .get functions to sysfs_emit.

[PATCH 1/4] KVM: PPC: Book3S HV: Make struct kernel_param_ops definition const

This should be const, so make it so. Signed-off-by: Joe Perches --- arch/powerpc/kvm/book3s_hv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c index 4ba06a2a306c..2b215852cdc9 100644 --- a/arch/powerpc/kvm

[PATCH 0/4] treewide: Make definitions of struct kernel_param_ops const

Using const is good as it reduces data size. Joe Perches (4): KVM: PPC: Book3S HV: Make struct kernel_param_ops definition const kvm x86/mmu: Make struct kernel_param_ops definitions const rcu/tree: Make struct kernel_param_ops definitions const mm/zswap: Make struct kernel_param_ops

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

On Thu, 2020-10-01 at 14:39 -0500, Segher Boessenkool wrch/ote: > Hi! > > On Thu, Oct 01, 2020 at 12:15:39PM +0200, Miguel Ojeda wrote: > > > So it looks like the best option is to exclude these > > > 2 files from conversion. > > > > Agreed. Nevertheless, is there any reason arch/powerpc/*

Re: [RFC PATCH next-20200930] treewide: Convert macro and uses of __section(foo) to __section("foo")

On Thu, 2020-10-01 at 12:15 +0200, Miguel Ojeda wrote: > Hi Joe, Buenas Miguel. > On Thu, Oct 1, 2020 at 12:56 AM Joe Perches wrote: > > So I installed the powerpc cross compiler, and > > nope, that doesn't work, it makes a mess. > > Thanks a lot for revivin

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

On Thu, 2020-09-10 at 15:21 +0100, Robin Murphy wrote: > On 2020-09-09 21:06, Joe Perches wrote: > > fallthrough to a separate case/default label break; isn't very readable. > > > > Convert pseudo-keyword fallthrough; statements to a simple break; when > > the ne

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

On Wed, 2020-09-09 at 19:36 -0300, Jason Gunthorpe wrote: > On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote: > > fallthrough to a separate case/default label break; isn't very readable. > > > > Convert pseudo-keyword fallthrough; statements to a simple break; wh

[trivial PATCH] treewide: Convert switch/case fallthrough; to break;

"fallthrough;(\s*(case\s+\w+|default)\s*:\s*){1,7}break;" * Miscellanea: o Move or coalesce a couple label blocks above a default: block. Signed-off-by: Joe Perches --- Compiled allyesconfig x86-64 only. A few files for other arches were not compiled. arch/arm/mach-mmp/p

[PATCH 17/29] fs_enet: Avoid comma separated statements

Use semicolons and braces. Signed-off-by: Joe Perches --- drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet

[PATCH 00/29] treewide: Convert comma separated statements

are changes for another day. Joe Perches (29): coding-style.rst: Avoid comma statements alpha: Avoid comma separated statements ia64: Avoid comma separated statements sparc: Avoid comma separated statements ata: Avoid comma separated statements drbd: Avoid comma separated statements lp

Re: [PATCH v2 11/25] powerpc/signal: Refactor bad frame logging

On Tue, 2020-08-18 at 17:19 +, Christophe Leroy wrote: > The logging of bad frame appears half a dozen of times > and is pretty similar. [] > diff --git a/arch/powerpc/kernel/signal.c b/arch/powerpc/kernel/signal.c [] > @@ -355,3 +355,14 @@ static unsigned long get_tm_stackpointer(struct >

Re: [PATCH 0/9] powerpc: delete duplicated words

On Sun, 2020-07-26 at 12:08 -0700, Randy Dunlap wrote: > v0.1 of this script also found lots of repeated numbers and strings of > special characters (ASCII art etc.), so now it ignores duplicated numbers > or special characters -- since it is really looking for duplicate words. > > Anyway, I

Re: [PATCH 0/9] powerpc: delete duplicated words

On 2020-07-26 12:08, Randy Dunlap wrote: On 7/26/20 10:49 AM, Joe Perches wrote: On Sun, 2020-07-26 at 10:23 -0700, Randy Dunlap wrote: On 7/26/20 7:29 AM, Christophe Leroy wrote: Randy Dunlap a écrit : Drop duplicated words in arch/powerpc/ header files. How did you detect them ? Do you

Re: [PATCH 0/9] powerpc: delete duplicated words

On Sun, 2020-07-26 at 10:23 -0700, Randy Dunlap wrote: > On 7/26/20 7:29 AM, Christophe Leroy wrote: > > Randy Dunlap a écrit : > > > > > Drop duplicated words in arch/powerpc/ header files. > > > > How did you detect them ? Do you have some script for tgat, or you just > > read all comments ?

Re: [PATCH] pci: pcie: AER: Fix logging of Correctable errors

On Fri, 2020-06-19 at 13:17 -0400, Sinan Kaya wrote: > On 6/18/2020 11:55 AM, Matt Jolly wrote: > > > + pci_warn(dev, " device [%04x:%04x] error > > status/mask=%08x/%08x\n", > > + dev->vendor, dev->device, > > + info->status, info->mask); > > + }

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

On Thu, 2020-06-18 at 00:31 +0300, Denis Efremov wrote: > > On 6/16/20 9:53 PM, Joe Perches wrote: > > On Mon, 2020-06-15 at 21:57 -0400, Waiman Long wrote: > > > v4: > > > - Break out the memzero_explicit() change as suggested by Dan Carpenter > > >

Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive()

On Mon, 2020-06-15 at 21:57 -0400, Waiman Long wrote: > v4: > - Break out the memzero_explicit() change as suggested by Dan Carpenter > so that it can be backported to stable. > - Drop the "crypto: Remove unnecessary memzero_explicit()" patch for > now as there can be a bit more

Re: [PATCH] pwm: Add missing "CONFIG_" prefix

On Thu, 2020-06-04 at 14:52 -0700, Kees Cook wrote: > On Wed, Jun 03, 2020 at 04:04:31PM -0700, Joe Perches wrote: > > On Wed, 2020-06-03 at 15:40 -0700, Kees Cook wrote: > > > The IS_ENABLED() use was missing the CONFIG_ prefix which would have > > > lead to skipping th

Re: [PATCH] pwm: Add missing "CONFIG_" prefix

On Wed, 2020-06-03 at 15:40 -0700, Kees Cook wrote: > The IS_ENABLED() use was missing the CONFIG_ prefix which would have > lead to skipping this code. > > Fixes: 3ad1f3a33286 ("pwm: Implement some checks for lowlevel drivers") > Signed-off-by: Kees Cook > --- > drivers/pwm/core.c | 2 +- > 1

Re: [PATCH v7 2/5] seq_buf: Export seq_buf_printf() to external modules

On Fri, 2020-05-08 at 17:30 +0530, Vaibhav Jain wrote: > Hi Boris, > > Borislav Petkov writes: > > > On Fri, May 08, 2020 at 04:19:19PM +0530, Vaibhav Jain wrote: > > > 'seq_buf' provides a very useful abstraction for writing to a string > > > buffer without needing to worry about it

Re: [PATCH v2 2/2] crypto: Remove unnecessary memzero_explicit()

On Tue, 2020-04-14 at 15:37 -0400, Waiman Long wrote: > OK, I can change it to clear the key length when the allocation failed > which isn't likely. Perhaps: kfree_sensitive(op->key); op->key = NULL; op->keylen = 0; but I don't know that it impacts any possible state.

Re: [PATCH 2/2] crypto: Remove unnecessary memzero_explicit()

On Mon, 2020-04-13 at 17:15 -0400, Waiman Long wrote: > Since kfree_sensitive() will do an implicit memzero_explicit(), there > is no need to call memzero_explicit() before it. Eliminate those > memzero_explicit() and simplify the call sites. 2 bits of trivia: > diff --git

Re: [PATCH v4 08/25] ocxl: Emit a log message showing how much LPC memory was detected

On Wed, 2020-04-01 at 01:49 -0700, Dan Williams wrote: > On Sun, Mar 29, 2020 at 10:23 PM Alastair D'Silva > wrote: > > This patch emits a message showing how much LPC memory & special purpose > > memory was detected on an OCXL device. [] > > diff --git a/drivers/misc/ocxl/config.c

Re: [PATCH v12 8/8] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry.

(removed a bunch of cc's) On Fri, 2020-03-20 at 18:31 +0200, Andy Shevchenko wrote: > On Fri, Mar 20, 2020 at 07:42:03AM -0700, Joe Perches wrote: > > On Fri, 2020-03-20 at 14:42 +0200, Andy Shevchenko wrote: > > > On Fri, Mar 20, 2020 at 12:23:38PM +0100, Michal Suchánek wro

Re: [PATCH v12 8/8] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry.

On Fri, 2020-03-20 at 14:42 +0200, Andy Shevchenko wrote: > On Fri, Mar 20, 2020 at 12:23:38PM +0100, Michal Suchánek wrote: > > On Fri, Mar 20, 2020 at 12:33:50PM +0200, Andy Shevchenko wrote: > > > On Fri, Mar 20, 2020 at 11:20:19AM +0100, Michal Suchanek wrote: > > > > While at it also simplify

Re: [PATCH v11 8/8] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry.

On Thu, 2020-03-19 at 13:19 +0100, Michal Suchanek wrote: > Signed-off-by: Michal Suchanek > --- > v10: new patch > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index bc8dbe4fe4c9..329bf4a31412 100644 > --- a/MAINTAINERS > +++

Re: [PATCH -next 016/491] KERNEL VIRTUAL MACHINE FOR POWERPC (KVM/powerpc): Use fallthrough;

On Thu, 2020-03-19 at 12:18 +1100, Paul Mackerras wrote: > On Tue, Mar 10, 2020 at 09:51:30PM -0700, Joe Perches wrote: > > Convert the various uses of fallthrough comments to fallthrough; > > > > Done via script > > Link: > > https://lore.kernel.org/lkml/b56602f

Re: [PATCH] treewide: Rename "unencrypted" to "decrypted"

On Tue, 2020-03-17 at 14:24 -0700, Dave Hansen wrote: > On 3/17/20 2:06 PM, Borislav Petkov wrote: > > On Tue, Mar 17, 2020 at 01:35:12PM -0700, Dave Hansen wrote: > > > On 3/17/20 4:18 AM, Borislav Petkov wrote: > > > > Back then when the whole SME machinery started getting mainlined, it > > > >

[PATCH -next 000/491] treewide: use fallthrough;

ough.commit_msg") or die "$0: can't create temporary file: $!\n"; print $fh <https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git@perches.com/ EOF ; close $fh; `git commit -s -a -F cvt_fallthrough.commit_msg`; } Joe Perches (491): MELLANOX ETHERNET INNOV

[PATCH -next 017/491] CELL BROADBAND ENGINE ARCHITECTURE: Use fallthrough;

Convert the various uses of fallthrough comments to fallthrough; Done via script Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ Signed-off-by: Joe Perches --- arch/powerpc/platforms/cell/spufs/switch.c | 2 +- 1 file changed, 1 insertion

[PATCH -next 016/491] KERNEL VIRTUAL MACHINE FOR POWERPC (KVM/powerpc): Use fallthrough;

Convert the various uses of fallthrough comments to fallthrough; Done via script Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ Signed-off-by: Joe Perches --- arch/powerpc/kvm/book3s_32_mmu.c | 2 +- arch/powerpc/kvm/book3s_64_mmu.c | 2

Re: [PATCH -next] powerpc/maple: fix comparing pointer to 0

On Tue, 2020-01-21 at 01:47 -0600, Segher Boessenkool wrote: > On Mon, Jan 20, 2020 at 05:52:15PM -0800, Joe Perches wrote: > > On Tue, 2020-01-21 at 09:31 +0800, Chen Zhou wrote: > > > Fixes coccicheck warning: > > > ./arch/powerpc/platforms/maple/setup.c:232:15-16

Re: [PATCH -next] powerpc/maple: fix comparing pointer to 0

On Tue, 2020-01-21 at 09:31 +0800, Chen Zhou wrote: > Fixes coccicheck warning: > ./arch/powerpc/platforms/maple/setup.c:232:15-16: > WARNING comparing pointer to 0 Does anyone have or use these powerpc maple boards anymore? Maybe the whole codebase should just be deleted instead. If not,

Re: [PATCH v2 00/33] Kill pr_warning in the whole linux code

(Adding Stephen Rothwell) On Fri, 2019-10-18 at 17:22 +0200, Christoph Hellwig wrote: > As I said before: please just send Linus a scripted conversion after > the next -rc1. There is no point in creating all this churn. I again ask for a scripted mechanism to be added to -next to allow these

Re: [EXTERNAL][PATCH 1/5] PCI: Convert pci_resource_to_user to a weak function

On Sun, 2019-07-28 at 22:49 +, Paul Burton wrote: > Hi Denis, > > On Sun, Jul 28, 2019 at 11:22:09PM +0300, Denis Efremov wrote: > > diff --git a/include/linux/pci.h b/include/linux/pci.h > > index 9e700d9f9f28..1a19d0151b0a 100644 > > --- a/include/linux/pci.h > > +++ b/include/linux/pci.h >

[PATCH 7/8] tty: hvcs: Fix odd use of strlcpy

Use the typical style of array, not the equivalent [0]. Signed-off-by: Joe Perches --- drivers/tty/hvc/hvcs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c index cb4db1b3ca3c..b6c1c1be06f9 100644 --- a/drivers/tty/hvc

[PATCH 0/8] treewide: correct misuses of strscpy/strlcpy

These are all likely copy/paste defects where the field size of the 'copied to' array is incorrect. Each patch in this series is independent. Joe Perches (8): Input: synaptics: Fix misuse of strlcpy leds: as3645a: Fix misuse of strlcpy media: m2m-deinterlace: Fix misuse of strscpy media

Re: [PATCH v2] powerpc/setup_64: fix -Wempty-body warnings

On Thu, 2019-06-27 at 15:52 -0400, Qian Cai wrote: > On Wed, 2019-06-05 at 16:53 -0400, Qian Cai wrote: > > At the beginning of setup_64.c, it has, > > > > #ifdef DEBUG > > #define DBG(fmt...) udbg_printf(fmt) > > #else > > #define DBG(fmt...) > > #endif > > > > where DBG() could be

Re: [PATCH 7/7] powerpc/kprobes: Allow probing on any ftrace address

On Fri, 2019-06-21 at 23:50 +0900, Masami Hiramatsu wrote: > On Tue, 18 Jun 2019 20:17:06 +0530 > "Naveen N. Rao" wrote: trivia: > > diff --git a/arch/powerpc/kernel/kprobes-ftrace.c > > b/arch/powerpc/kernel/kprobes-ftrace.c [] > > @@ -57,6 +82,11 @@ NOKPROBE_SYMBOL(kprobe_ftrace_handler); >

[PATCH] powerpc/powernv: Rename pe_level_printk to pe_printk and embed KERN_LEVEL in format

Remove the separate KERN_ from each pe_level_printk and instead add the KERN_ to the format. pfix in pe_level_printk could also be used uninitialized so add a new else and set pfx to the hex value of pe->flags. Rename pe_level_printk to pe_printk and update the pe_ macros. Signed-off-by:

Re: [PATCH v1 02/15] crypto: talitos - rename alternative AEAD algos.

On Tue, 2019-05-21 at 17:54 +, Christophe Leroy wrote: > Hi Joe & Andy [] > diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c [] > > @@ -2356,7 +2356,7 @@ static struct talitos_alg_template driver_algs[] = { > > .base = { > >

Re: [PATCH] powerpc/mm: mark more tlb functions as __always_inline

On Tue, 2019-05-21 at 16:27 +0900, Masahiro Yamada wrote: > On Tue, May 21, 2019 at 3:54 PM Christophe Leroy > > powerpc accepts lines up to 90 chars, see arch/powerpc/tools/checkpatch.pl > > Ugh, I did not know this. Horrible. > > The Linux coding style should be global in the kernel tree. > No

Re: [PATCH] powerpc/mm: mark more tlb functions as __always_inline

On Tue, 2019-05-21 at 08:53 +0200, Christophe Leroy wrote: > powerpc accepts lines up to 90 chars, see arch/powerpc/tools/checkpatch.pl arch/powerpc/tools/checkpatch.sh

Re: [PATCH] powerpc/powernv/ioda2: Add __printf format/argument verification

On Fri, 2019-05-03 at 16:59 +1000, Michael Ellerman wrote: > On Thu, 2017-03-30 at 10:19:25 UTC, Joe Perches wrote: > > Fix fallout too. > > > > Signed-off-by: Joe Perches > > Applied to powerpc next, thanks. > > https://git.kernel.org/powerpc/c/1e496391a8452101308a23b7395cdd49 2+ years later.

Re: [PATCH] MAINTAINERS: Update remaining @linux.vnet.ibm.com addresses

On Thu, 2019-04-11 at 06:12 -0700, Paul E. McKenney wrote: > If my email address were > to change again, I would instead go with the "(IBM)" approach and let > the git log and MAINTAINERS file keep the contact information. Not that > we get to update the git log, of course. ;-) Add entries to

Re: [PATCH] MAINTAINERS: Update remaining @linux.vnet.ibm.com addresses

On Thu, 2019-04-11 at 22:07 +1000, Michael Ellerman wrote: > Joe Perches writes: > > On Thu, 2019-04-11 at 06:27 +0200, Lukas Bulwahn wrote: > > > Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com > > > to @linux.ibm.com in commit 1dfddcdb95c4

Re: [PATCH] MAINTAINERS: Update remaining @linux.vnet.ibm.com addresses

On Thu, 2019-04-11 at 06:27 +0200, Lukas Bulwahn wrote: > Paul McKenney attempted to update all email addresses @linux.vnet.ibm.com > to @linux.ibm.com in commit 1dfddcdb95c4 > ("MAINTAINERS: Update from @linux.vnet.ibm.com to @linux.ibm.com"), but > some still remained. > > We update the

Re: Bad file pattern in MAINTAINERS section 'IBM Power Virtual Accelerator Switchboard'

On Mon, 2019-03-25 at 16:35 -0700, Joe Perches wrote: > A file pattern line in this section of the MAINTAINERS file in linux-next > does not have a match in the linux source files. > > This could occur because a matching filename was never added, was deleted > or renamed in so

Bad file pattern in MAINTAINERS section 'IBM Power Virtual Accelerator Switchboard'

A file pattern line in this section of the MAINTAINERS file in linux-next does not have a match in the linux source files. This could occur because a matching filename was never added, was deleted or renamed in some other commit. The commits that added and if found renamed or removed the file

Re: [PATCH v3 2/5] ocxl: Clean up printf formats

On Wed, 2019-03-20 at 16:34 +1100, Alastair D'Silva wrote: > From: Alastair D'Silva > > Use %# instead of using a literal '0x' I do not suggest this as reasonable. There are 10's of thousands of uses of 0x%x in the kernel and converting them to save a byte seems unnecessary. $ git grep -P

Re: [PATCH 2/5] ocxl: Clean up printf formats

On Wed, 2019-02-27 at 15:57 +1100, Alastair D'Silva wrote: > From: Alastair D'Silva > > Use %# instead of using a literal '0x' I think it's better not to change this unless the compilation unit already uses a mix of styles. Overall, the kernel uses "0x%" over "%#" by ~8:1 $ git grep -P

Re: [PATCH] arch/powerpc: Use dma_zalloc_coherent

On Sat, 2018-11-17 at 12:40 +0530, Souptick Joarder wrote: > Hi Joe, Hi back. > On Fri, Nov 16, 2018 at 12:55 AM Joe Perches wrote: > > On Thu, 2018-11-15 at 23:29 +0530, Sabyasachi Gupta wrote: > > > On Mon, Nov 5, 2018 at 8:58 AM Sabyasachi Gupta > >

Re: [PATCH] arch/powerpc: Use dma_zalloc_coherent

On Thu, 2018-11-15 at 23:29 +0530, Sabyasachi Gupta wrote: > On Mon, Nov 5, 2018 at 8:58 AM Sabyasachi Gupta > wrote: > > Replaced dma_alloc_coherent + memset with dma_zalloc_coherent > > > > Signed-off-by: Sabyasachi Gupta > > Any comment on this patch? It's obviously correct. You might

Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic.

On Mon, 2018-10-22 at 22:53 +0530, Arun KS wrote: > Remove managed_page_count_lock spinlock and instead use atomic > variables. Perhaps better to define and use macros for the accesses instead of specific uses of atomic_long_ Something like: #define totalram_pages()(unsigned

Re: [PATCH v3 13/18] of: overlay: check prevents multiple fragments touching same property

On Sun, 2018-10-14 at 18:52 -0700, Frank Rowand wrote: > On 10/14/18 18:06, Joe Perches wrote: > > On Sun, 2018-10-14 at 17:24 -0700, frowand.l...@gmail.com wrote: > > > From: Frank Rowand > > > > > > Add test case of two fragments updating the same propert

Re: [PATCH v3 13/18] of: overlay: check prevents multiple fragments touching same property

On Sun, 2018-10-14 at 17:24 -0700, frowand.l...@gmail.com wrote: > From: Frank Rowand > > Add test case of two fragments updating the same property. After > adding the test case, the system hangs at end of boot, after > after slub stack dumps from kfree() in crypto modprobe code. [] > -static

Re: [PATCH v2 12/18] of: overlay: check prevents multiple fragments add or delete same node

On Fri, 2018-10-12 at 21:53 -0700, frowand.l...@gmail.com wrote: > From: Frank Rowand > > Multiple overlay fragments adding or deleting the same node is not > supported. Replace code comment of such, with check to detect the > attempt and fail the overlay apply. > > Devicetree unittest where

Re: [PATCH 15/36] dt-bindings: arm: Convert Actions Semi bindings to jsonschema

On Sat, 2018-10-06 at 12:40 +0200, Andreas Färber wrote: > > +++ b/Documentation/devicetree/bindings/arm/actions.yaml [] > > + > > +title: Actions Semi platforms device tree bindings > > + > > +maintainers: > > + - Andreas Färber > > Mani is now officially reviewer and the closest I have to a >

Re: [PATCH] powerpc/xmon/ppc-opc: Use ARRAY_SIZE macro

On Tue, 2018-10-09 at 14:43 +1100, Michael Ellerman wrote: > Joe Perches writes: > > > On Thu, 2018-10-04 at 19:10 +0200, Gustavo A. R. Silva wrote: > > > Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element. > > [] > > > diff --git a/arch/p

Re: [PATCH] powerpc/xmon/ppc-opc: Use ARRAY_SIZE macro

On Thu, 2018-10-04 at 19:10 +0200, Gustavo A. R. Silva wrote: > Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element. [] > diff --git a/arch/powerpc/xmon/ppc-opc.c b/arch/powerpc/xmon/ppc-opc.c [] > @@ -966,8 +966,7 @@ const struct powerpc_operand powerpc_operands[] = >{

Re: Checkpatch bad Warning (Re: [PATCH] powerpc/kgdb: add kgdb_arch_set/remove_breakpoint())

On Tue, 2018-09-18 at 09:33 +, Christophe Leroy wrote: > On the below patch, checkpatch reports > > WARNING: struct kgdb_arch should normally be const > #127: FILE: arch/powerpc/kernel/kgdb.c:480: > +struct kgdb_arch arch_kgdb_ops; > > But when I add 'const', I get compilation failure So

Re: [PATCH 2/2] powerpc: Use ARRAY_SIZE to replace its implementation

On Tue, 2018-08-14 at 10:46 +0800, zhong jiang wrote: > Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element. > So just replace it. Better to remove the extern and the const altogether here as well. $ git grep -w powerpc_num_opcodes arch/powerpc/xmon/ppc-dis.c: opcode_end =

Re: [PATCH 1/2] ia64: Use ARRAY_SIZE to replace its implementation

On Tue, 2018-08-14 at 10:46 +0800, zhong jiang wrote: > We prefer to ARRAY_SIZE rather than duplicating its implementation. > So just replace it. [] > diff --git a/arch/ia64/kernel/perfmon.c b/arch/ia64/kernel/perfmon.c [] > @@ -4645,7 +4645,7 @@ static char *pfmfs_dname(struct dentry *dentry,

Re: [PATCH v4 5/6] powerpc: Add show_user_instructions()

On Thu, 2018-08-02 at 21:42 -0300, Murilo Opsfelder Araujo wrote: > > > diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c [] > > > @@ -1299,6 +1299,46 @@ static void show_instructions(struct pt_regs *regs) > > > pr_cont("\n"); > > > } > > > +void

Re: [PATCH v3 5/9] powerpc/traps: Print signal name for unhandled signals

On Wed, 2018-08-01 at 08:37 +0200, Christophe LEROY wrote: > Le 31/07/2018 à 16:50, Murilo Opsfelder Araujo a écrit : > > This adds a human-readable name in the unhandled signal message. > > Before this patch, a page fault looked like: > >pandafault[6303]: unhandled signal 11 at 17d0 nip

Re: [PATCH v2 04/10] powerpc/traps: Use REG_FMT in show_signal_msg()

On Fri, 2018-07-27 at 18:40 +0200, LEROY Christophe wrote: > Murilo Opsfelder Araujo a écrit : > > > Simplify the message format by using REG_FMT as the register format. This > > avoids having two different formats and avoids checking for MSR_64BIT. > > Are you sure it is what we want ? > >

Re: [PATCH 1/4] treewide: convert ISO_8859-1 text comments to utf-8

On Wed, 2018-07-25 at 15:12 +0200, Arnd Bergmann wrote: > tools/perf/tests/.gitignore: > LLVM byte-codes, uncompressed > On Wed, Jul 25, 2018 at 2:55 AM, Andrew Morton > wrote: > > On Tue, 24 Jul 2018 17:13:20 -0700 Joe Perches wrote: > >

Re: [PATCH 1/4] treewide: convert ISO_8859-1 text comments to utf-8

On Tue, 2018-07-24 at 14:00 -0700, Andrew Morton wrote: > On Tue, 24 Jul 2018 13:13:25 +0200 Arnd Bergmann wrote: > > Almost all files in the kernel are either plain text or UTF-8 > > encoded. A couple however are ISO_8859-1, usually just a few > > characters in a C comments, for historic

Re: [PATCH v3 1/2] powerpc: Detect the presence of big-cores via "ibm, thread-groups"

On Sun, 2018-07-08 at 13:03 -0300, Murilo Opsfelder Araujo wrote: > On Fri, Jul 06, 2018 at 02:35:48PM +0530, Gautham R. Shenoy wrote: > > From: "Gautham R. Shenoy" > > > > On IBM POWER9, the device tree exposes a property array identifed by > > "ibm,thread-groups" which will indicate which

Re: [PATCH] powerpc/64s: Enhance the information in cpu_show_spectre_v1()

On Tue, 2018-05-29 at 15:24 +, Christophe Leroy wrote: > On 05/29/2018 02:46 PM, Michal Suchánek wrote: > > On Tue, 29 May 2018 16:13:49 +0200 Christophe LEROY > > wrote: [] > > diff --git a/arch/powerpc/kernel/security.c > > > > b/arch/powerpc/kernel/security.c index

[PATCH] sound: Use octal not symbolic permissions

Miscellanea: o Wrapped one multi-line call to a single line Signed-off-by: Joe Perches <j...@perches.com> --- sound/core/compress_offload.c | 2 +- sound/core/info.c | 6 +++--- sound/core/init.c | 4 ++-- sound/core/oss/mixer

Re: [PATCH 00/21] i2c: make use of i2c_8bit_addr_from_msg

On Mon, 2018-05-14 at 16:53 +0200, Peter Rosin wrote: > Hi! > > The nice little inline i2c_8bit_addr_from_msg is not getting > enough use. This series improves the situation and drops a > bunch of lines in the process. Perhaps the inline should test for I2C_M_REV_DIR_ADDR as there is at least

Re: [PATCH v4 14/16] powerpc: Use generic free_initrd_mem.

On Wed, 2018-03-28 at 16:36 -0400, Shea Levy wrote: > Signed-off-by: Shea Levy Most people seem to want some form of commit message and not just your sign-off. And btw: It seems you used get_maintainer to determine who to send these patches to. I suggest you add --nogit and

Re: [PATCH script] hwmon: Use octal not symbolic permissions

On Tue, 2018-03-27 at 08:44 -0700, Guenter Roeck wrote: > On 03/27/2018 04:48 AM, Joe Perches wrote: > > On Tue, 2018-03-27 at 03:28 -0700, Guenter Roeck wrote: > > > On 03/27/2018 12:35 AM, Joe Perches wrote: > > > > On Mon, 2018-03-26 at 23:33 -0700, Guente

Re: [PATCH script] hwmon: Use octal not symbolic permissions

On Tue, 2018-03-27 at 03:28 -0700, Guenter Roeck wrote: > On 03/27/2018 12:35 AM, Joe Perches wrote: > > On Mon, 2018-03-26 at 23:33 -0700, Guenter Roeck wrote: > > > Since the hwmon subsystem has been labeled as both "obsolete" and > > > "obsc

Re: [PATCH script] hwmon: Use octal not symbolic permissions

On Mon, 2018-03-26 at 23:33 -0700, Guenter Roeck wrote: > Since the hwmon subsystem has been labeled as both "obsolete" and "obscure", fyi: It's marked Maintained in MAINTAINERS HARDWARE MONITORING M: Jean Delvare M: Guenter Roeck L:

Re: [PATCH script] hwmon: Use octal not symbolic permissions

On Mon, 2018-03-26 at 23:33 -0700, Guenter Roeck wrote: > On 03/26/2018 01:28 PM, Joe Perches wrote: > > drivers/hwmon is the most frequent user of symbolic permissions > > like S_IRUGO in the kernel tree. [] > I have something similar using coccinelle, Please post the script. I

[PATCH script] hwmon: Use octal not symbolic permissions

drivers/hwmon is the most frequent user of symbolic permissions like S_IRUGO in the kernel tree. $ git grep -w -P "S_[A-Z]{5,5}" | \ cut -f1 -d: | cut -f1-2 -d"/" | sed -r 's/[A-Za-z0-9_-]+\.[ch]$//' | \ sort | uniq -c | sort -rn | head 3862 drivers/hwmon 814 drivers/scsi 763

[PATCH 1/4] ethernet: Use octal not symbolic permissions

Prefer the direct use of octal for permissions. Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace and some typing. Miscellanea: o Whitespace neatening around these conversions. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/8390/

[PATCH 0/4] net: drivers/net: Use octal permissions

Using octal and not symbolic permissions is preferred by many as more readable. https://lkml.org/lkml/2016/8/2/1945 Rather than getting these piecemeal, just do them all. Done with checkpatch and some typing. Joe Perches (4): ethernet: Use octal not symbolic permissions wireless: Use octal

[trivial PATCH V2] treewide: Align function definition open/close braces

Some functions definitions have either the initial open brace and/or the closing brace outside of column 1. Move those braces to column 1. This allows various function analyzers like gnu complexity to work properly for these modified functions. Signed-off-by: Joe Perches <j...@perches.

Re: [PATCH] powerpc: Use common error handling code in setup_new_fdt()

On Thu, 2018-03-15 at 14:57 +0300, Dan Carpenter wrote: > On Wed, Mar 14, 2018 at 06:22:07PM -0300, Thiago Jung Bauermann wrote: > > > > SF Markus Elfring writes: > > > > > From: Markus Elfring > > > Date: Sun, 11 Mar 2018 09:03:42

Re: [PATCH] fix double ;;s in code

On Tue, 2018-02-20 at 17:19 +1100, Michael Ellerman wrote: > Daniel Vetter writes: > > On Sun, Feb 18, 2018 at 11:00:56AM +0100, Christophe LEROY wrote: > > > Le 17/02/2018 à 22:19, Pavel Machek a écrit : > > > > > > > > Fix double ;;'s in code. > > > > > > > > Signed-off-by:

usleep_range without a range

scheduling can generally be better when these values are not identical. Perhaps these ranges should be expanded. $ git grep -P -n "usleep_range\s*\(\s*([\w\.\>\-]+)\s*,\s*\1\s*\)" drivers/clk/ux500/clk-sysctrl.c:45: usleep_range(clk->enable_delay_us, clk->enable_delay_us);

Re: [-next PATCH 4/4] treewide: Use DEVICE_ATTR_WO

On Tue, 2017-12-19 at 19:44 +0100, Borislav Petkov wrote: > On Tue, Dec 19, 2017 at 10:15:09AM -0800, Joe Perches wrote: > > Convert DEVICE_ATTR uses to DEVICE_ATTR_WO where possible. > > > > Done with perl script: > > > > $ git grep -w --name-only DEVICE_ATTR

[-next PATCH 4/4] treewide: Use DEVICE_ATTR_WO

(\1)/g; print;}' Signed-off-by: Joe Perches <j...@perches.com> --- arch/s390/kernel/smp.c | 2 +- arch/x86/kernel/cpu/microcode/core.c | 2 +- drivers/input/touchscreen/elants_i2c.c | 2 +- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- drivers/net/wimax/i2400m/sysfs.c | 3

[-next PATCH 0/4] sysfs and DEVICE_ATTR_

Joe Perches (4): sysfs.h: Use octal permissions treewide: Use DEVICE_ATTR_RW treewide: Use DEVICE_ATTR_RO treewide: Use DEVICE_ATTR_WO arch/arm/mach-pxa/sharpsl_pm.c | 4 +- arch/s390/kernel/smp.c | 2 +- arch/s390/kernel/topology.c

Re: [PATCH 13/13] ocxl: add MAINTAINERS entry

On Mon, 2017-12-18 at 16:21 +0100, Frederic Barrat wrote: > Signed-off-by: Frederic Barrat > Signed-off-by: Andrew Donnellan > --- > MAINTAINERS | 12 > 1 file changed, 12 insertions(+) > > diff --git a/MAINTAINERS

[trivial PATCH] treewide: Align function definition open/close braces

line from xfs_agf_verify Signed-off-by: Joe Perches <j...@perches.com> --- git diff -w shows no difference other than the above 'Miscellanea' (this is against -next, but it applies against Linus' tree with a couple offsets) arch/x86/include/asm/atomic64_32.h | 2 +- d

Re: powerpc: Use pr_warn instead of pr_warning

On Tue, 2017-12-12 at 22:39 +1100, Michael Ellerman wrote: > On Tue, 2016-10-25 at 04:00:08 UTC, Joe Perches wrote: > > At some point, pr_warning will be removed so all logging messages use > > a consistent _warn style. > > > > Update arch/powerpc/ > > >

Re: [PATCH] powerpc/xmon: use ARRAY_SIZE on various array sizing calculations

On Fri, 2017-12-08 at 22:51 +1100, Michael Ellerman wrote: > Balbir Singh writes: > > > On Thu, Dec 7, 2017 at 10:01 PM, Colin King > > wrote: > > > From: Colin Ian King > > > > > > Use the ARRAY_SIZE macro on several

Re: [PATCH v2 1/2] KVM: PPC: Book3S HV: Drop prepare_done from struct kvm_resize_hpt and cleanups

On Mon, 2017-12-04 at 09:36 -0500, Serhii Popovych wrote: > Change comparison against zero to make checkpatch.pl happy. Huh? Either I'm confused or you are incorrect here. checkpatch should or does not warn against comparisons to zero. There is a test for comparison to NULL. > diff --git

  1   2   3   4   >