Re: [PATCH] vdso: Fix powerpc build U64_MAX undeclared error

2024-04-09 Thread John Stultz
ork just as well and is in > include/vdso/limits.h. > > Reported-by: Stephen Rothwell > Closes: https://lore.kernel.org/all/20240409124905.6816d...@canb.auug.org.au/ > Fixes: c8e3a8b6f2e6 ("vdso: Consolidate vdso_calc_delta()") > Signed-off-by: Adrian Hunter Acked-by: John Stultz

Re: [PATCH 01/19] vdso: Consolidate vdso_calc_delta()

2024-03-09 Thread John Stultz
On Fri, Mar 8, 2024 at 5:15 AM Adrian Hunter wrote: > > Consolidate vdso_calc_delta(), in preparation for further simplification. > > Suggested-by: Thomas Gleixner > Signed-off-by: Adrian Hunter > --- > arch/powerpc/include/asm/vdso/gettimeofday.h | 17 ++--- >

Re: [alsa-devel] [PATCH V6 3/4] ASoC: pcm_dmaengine: Extract snd_dmaengine_pcm_refine_runtime_hwparams

2020-01-17 Thread John Stultz
On Thu, Jan 16, 2020 at 11:11 PM Shengjiu Wang wrote: > > Hi > > On Thu, Jan 16, 2020 at 1:56 PM John Stultz wrote: > > > > On Wed, Jan 8, 2020 at 8:58 PM John Stultz wrote: > > > On Thu, Sep 26, 2019 at 6:50 PM Shengjiu Wang > > > wrote: >

Re: [PATCH V6 3/4] ASoC: pcm_dmaengine: Extract snd_dmaengine_pcm_refine_runtime_hwparams

2020-01-15 Thread John Stultz
On Wed, Jan 8, 2020 at 8:58 PM John Stultz wrote: > On Thu, Sep 26, 2019 at 6:50 PM Shengjiu Wang wrote: > > > > When set the runtime hardware parameters, we may need to query > > the capability of DMA to complete the parameters. > > > > This patch

Re: [PATCH V6 3/4] ASoC: pcm_dmaengine: Extract snd_dmaengine_pcm_refine_runtime_hwparams

2020-01-08 Thread John Stultz
On Thu, Sep 26, 2019 at 6:50 PM Shengjiu Wang wrote: > > When set the runtime hardware parameters, we may need to query > the capability of DMA to complete the parameters. > > This patch is to Extract this operation from > dmaengine_pcm_set_runtime_hwparams function to a separate function >

Re: [PATCH] powerpc: Convert VDSO update function to use new update_vsyscall interface

2017-06-21 Thread John Stultz
<pau...@ozlabs.org> Apologies again for missing this earlier. So no objections from me. I can't say I really worked the whole thing out, but you're handling the xtime_nsec field properly and the rest looks reasonable and is well documented. So for what its worth: Acked-by: John Stultz <john.stu...@linaro.org> Thanks again for making this update! -john

Re: [PATCH] tick-broadcast: Fix the printing of broadcast masks

2015-05-13 Thread John Stultz
On Sun, May 3, 2015 at 10:51 PM, Preeti U Murthy pre...@linux.vnet.ibm.com wrote: Ping. Any comments on this patch ? Got this queued for testing, and hopefully 4.2 thanks -john ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: [tip:timers/core] timekeeping: Fixup typo in update_vsyscall_old definition

2014-08-12 Thread John Stultz
On 08/10/2014 09:19 PM, Benjamin Herrenschmidt wrote: On Wed, 2014-07-30 at 00:31 -0700, tip-bot for John Stultz wrote: Commit-ID: 953dec21aed4038464fec02f96a2f1b8701a5bce Gitweb: http://git.kernel.org/tip/953dec21aed4038464fec02f96a2f1b8701a5bce Author: John Stultz john.stu

Re: [PATCH v2] NTP: Add a CONFIG_RTC_SYSTOHC configuration

2012-12-14 Thread John Stultz
On 12/14/2012 03:19 PM, Jason Gunthorpe wrote: The purpose of this option is to allow ARM/etc systems that rely on the class RTC subsystem to have the same kind of automatic NTP based synchronization that we have on PC platforms. Today ARM does not implement update_persistent_clock and makes

Re: [PATCH 4/8] time: Condense timekeeper.xtime into xtime_sec

2012-08-21 Thread John Stultz
On 08/21/2012 12:14 AM, Andreas Schwab wrote: John Stultz john.stu...@linaro.org writes: @@ -115,6 +115,7 @@ static void tk_xtime_add(struct timekeeper *tk, const struct timespec *ts) { tk-xtime_sec += ts-tv_sec; tk-xtime_nsec += (u64)ts-tv_nsec tk-shift

Re: [PATCH 4/8] time: Condense timekeeper.xtime into xtime_sec

2012-08-20 Thread John Stultz
On 08/19/2012 02:02 PM, Andreas Schwab wrote: John Stultz john.stu...@linaro.org writes: The timekeeper struct has a xtime_nsec, which keeps the sub-nanosecond remainder. This ends up being somewhat duplicative of the timekeeper.xtime.tv_nsec value, and we have to do extra work to keep them

Re: [PATCH 4/8] time: Condense timekeeper.xtime into xtime_sec

2012-08-20 Thread John Stultz
On 08/20/2012 12:45 PM, Andreas Schwab wrote: John Stultz john.stu...@linaro.org writes: I'm not very familiar w/ the iBook hardware, but does it use a clocksource, or does it use arch_gettimeoffset()? clocksource: timebase mult[3640e38e] shift[24] registered I suspect that the casting has

Re: [PATCH 4/8] time: Condense timekeeper.xtime into xtime_sec

2012-08-20 Thread John Stultz
On 08/20/2012 01:04 PM, Andreas Schwab wrote: John Stultz john.stu...@linaro.org writes: Huh. Yea, that looks fine. And without the __timekeeping_inject_sleeptime() call, the system resumed ok? Yes, it does. So I'm mostly still stumped on this. But I did find one possible related bugfix

Re: [PATCH 3/6] powerpc/time: Use clocksource_register_hz

2011-11-28 Thread john stultz
On Thu, 2011-11-24 at 17:07 +1100, Anton Blanchard wrote: plain text document attachment (clock3) Use clocksource_register_hz which calculates the shift/mult factors for us. Also remove the shift = 22 assumption in vsyscall_update - thanks to Paul Mackerras and John Stultz for catching

Re: [PATCH 2/4] powerpc/time: Use clocksource_register_hz

2011-11-07 Thread john stultz
On Sat, 2011-11-05 at 11:55 +1100, Paul Mackerras wrote: On Thu, Nov 03, 2011 at 09:14:44AM -0400, John Stultz wrote: On Thu, 2011-11-03 at 11:59 +1100, Anton Blanchard wrote: plain text document attachment (clock3) Use clocksource_register_hz which calculates the shift/mult factors

Re: [PATCH 2/4] powerpc/time: Use clocksource_register_hz

2011-11-03 Thread John Stultz
On Thu, 2011-11-03 at 11:59 +1100, Anton Blanchard wrote: plain text document attachment (clock3) Use clocksource_register_hz which calculates the shift/mult factors for us. Signed-off-by: Anton Blanchard an...@samba.org --- Index: linux-build/arch/powerpc/kernel/time.c

Re: [PATCH V13 1/4] ptp: Added a brand new class driver for ptp clocks.

2011-03-28 Thread John Stultz
POSIX clock. The ancillary clock features are exposed in two different ways, via the sysfs and by a character device. Signed-off-by: Richard Cochran richard.coch...@omicron.at Acked-by: John Stultz john.stu...@linaro.org thanks -john ___ Linuxppc

Re: [PATCH V13 2/4] ptp: Added a clock that uses the eTSEC found on the MPC85xx.

2011-03-28 Thread John Stultz
...@omicron.at Acked-by: John Stultz john.stu...@linaro.org ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH V13 3/4] ptp: Added a clock driver for the IXP46x.

2011-03-28 Thread John Stultz
On Sun, 2011-03-27 at 08:39 +0200, Richard Cochran wrote: This patch adds a driver for the hardware time stamping unit found on the IXP465. The basic clock operations and an external trigger are implemented. Signed-off-by: Richard Cochran richard.coch...@omicron.at Acked-by: John Stultz

Re: [PATCH V13 4/4] ptp: Added a clock driver for the National Semiconductor PHYTER.

2011-03-28 Thread John Stultz
On Sun, 2011-03-27 at 08:39 +0200, Richard Cochran wrote: This patch adds support for the PTP clock found on the DP83640. The basic clock operations and one external time stamp have been implemented. Signed-off-by: Richard Cochran richard.coch...@omicron.at Acked-by: John Stultz john.stu

Re: [PATCH V12 1/4] ptp: Added a brand new class driver for ptp clocks.

2011-03-23 Thread John Stultz
On Mon, 2011-02-28 at 08:57 +0100, Richard Cochran wrote: This patch adds an infrastructure for hardware clocks that implement IEEE 1588, the Precision Time Protocol (PTP). A class driver offers a registration method to particular hardware clock drivers. Each clock is presented as a standard

Re: [PATCH V12 3/4] ptp: Added a clock driver for the IXP46x.

2011-03-23 Thread John Stultz
On Mon, 2011-02-28 at 08:58 +0100, Richard Cochran wrote: This patch adds a driver for the hardware time stamping unit found on the IXP465. The basic clock operations and an external trigger are implemented. Signed-off-by: Richard Cochran richard.coch...@omicron.at Acked-by: John Stultz

Re: [PATCH V12 4/4] ptp: Added a clock driver for the National Semiconductor PHYTER.

2011-03-23 Thread John Stultz
On Mon, 2011-02-28 at 08:58 +0100, Richard Cochran wrote: This patch adds support for the PTP clock found on the DP83640. The basic clock operations and one external time stamp have been implemented. Just locking rule comment nits here. +static int tdr_write(int bc, struct phy_device *dev,

Re: [PATCH 1/8] posix clocks: introduce a syscall for clock tuning.

2010-09-24 Thread john stultz
On Fri, 2010-09-24 at 09:29 +0200, Richard Cochran wrote: On Thu, Sep 23, 2010 at 12:48:51PM -0700, john stultz wrote: So I'd still split this patch up a little bit more. 1) Patch that implements the ADJ_SETOFFSET (*and its implementation*) in do_adjtimex. 2) Patch that adds

Re: [PATCH v6 0/8] ptp: IEEE 1588 hardware clock support

2010-09-23 Thread john stultz
On Thu, 2010-09-23 at 12:53 -0500, Christoph Lameter wrote: On Thu, 23 Sep 2010, Richard Cochran wrote: In contrast to the standard Linux system clock, a PHC is adjustable in hardware, for example using frequency compensation registers or a VCO. The ability to directly tune the

Re: [PATCH v6 0/8] ptp: IEEE 1588 hardware clock support

2010-09-23 Thread john stultz
On Thu, 2010-09-23 at 19:30 +0200, Richard Cochran wrote: Here is the sixth version of my patch set adding PTP hardware clock support to the Linux kernel. The main difference to v5 is that the character device interface has been replaced with one based on the posix clock system calls. The

Re: [PATCH 1/8] posix clocks: introduce a syscall for clock tuning.

2010-09-23 Thread john stultz
On Thu, 2010-09-23 at 19:31 +0200, Richard Cochran wrote: A new syscall is introduced that allows tuning of a POSIX clock. The syscall is implemented for four architectures: arm, blackfin, powerpc, and x86. The new syscall, clock_adjtime, takes two parameters, the clock ID, and a pointer to

Re: [PATCH v6 0/8] ptp: IEEE 1588 hardware clock support

2010-09-23 Thread john stultz
On Thu, 2010-09-23 at 14:15 -0500, Christoph Lameter wrote: On Thu, 23 Sep 2010, john stultz wrote: This was my initial gut reaction as well, but in the end, I agree with Richard that in the case of one or multiple PTP hardware clocks, we really can't abstract over the different time

Re: [PATCH v6 0/8] ptp: IEEE 1588 hardware clock support

2010-09-23 Thread john stultz
On Thu, 2010-09-23 at 21:36 +0100, Alan Cox wrote: So as far as the POSIX standard is concerned, offering a clock id to represent the PHC would be acceptable. But completely useless as you may have more than one entirely different time managed by PTP and in which you are not master

Re: [PATCH v6 0/8] ptp: IEEE 1588 hardware clock support

2010-09-23 Thread john stultz
On Thu, 2010-09-23 at 15:49 -0500, Christoph Lameter wrote: On Thu, 23 Sep 2010, john stultz wrote: The HPET or pit timesource are also quite slow these days. You only need access periodically to essentially tune the TSC ratio. If we're using the TSC, then we're not using the PTP

Re: [PATCH v6 0/8] ptp: IEEE 1588 hardware clock support

2010-09-23 Thread john stultz
On Thu, 2010-09-23 at 22:30 +0100, Alan Cox wrote: O I don't see how this is a problem, as it exposes the multiple hardware clocks via different posix clock ids. So in the boundary clock case, you can configure which side is the client and which side is the master in a config file and the

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-27 Thread John Stultz
On Fri, 2010-08-27 at 13:08 +0200, Richard Cochran wrote: On Mon, Aug 23, 2010 at 01:21:39PM -0700, john stultz wrote: On Thu, 2010-08-19 at 17:38 +0200, Richard Cochran wrote: On Thu, Aug 19, 2010 at 02:28:04PM +0200, Arnd Bergmann wrote: My point was that a syscall is better than

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-27 Thread John Stultz
On Fri, 2010-08-27 at 14:03 +0200, Arnd Bergmann wrote: On Friday 27 August 2010, Richard Cochran wrote: On Mon, Aug 23, 2010 at 01:21:39PM -0700, john stultz wrote: On Thu, 2010-08-19 at 17:38 +0200, Richard Cochran wrote: On Thu, Aug 19, 2010 at 02:28:04PM +0200, Arnd Bergmann wrote

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-27 Thread John Stultz
On Fri, 2010-08-27 at 14:38 +0200, Richard Cochran wrote: On Mon, Aug 23, 2010 at 01:08:45PM -0700, john stultz wrote: On Thu, 2010-08-19 at 07:55 +0200, Richard Cochran wrote: The clockid_t CLOCK_PTP will be arch-neutral. Sure, but are they conceptually neutral? There are other clock

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-26 Thread john stultz
On Wed, 2010-08-25 at 11:40 +0200, Christian Riesch wrote: What you describe here is only one of the use cases. If the hardware has a single network port and operates as a PTP slave, it timestamps the PTP packets that are sent and received and subsequently uses these timestamps and the

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-23 Thread john stultz
Sorry for the slow response here, I got busy with other work at the end of last week. On Thu, 2010-08-19 at 07:55 +0200, Richard Cochran wrote: On Wed, Aug 18, 2010 at 05:12:56PM -0700, john stultz wrote: On Wed, 2010-08-18 at 09:19 +0200, Richard Cochran wrote: The timer/alarm stuff

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-23 Thread john stultz
On Thu, 2010-08-19 at 17:38 +0200, Richard Cochran wrote: On Thu, Aug 19, 2010 at 02:28:04PM +0200, Arnd Bergmann wrote: My point was that a syscall is better than an ioctl based interface here, which I definitely still think. Given that John knows much more about clocks than I do, we still

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-18 Thread john stultz
On Wed, 2010-08-18 at 09:19 +0200, Richard Cochran wrote: On Tue, Aug 17, 2010 at 05:22:43PM -0700, john stultz wrote: So while to me, it think it would be more ideal (or maybe just less different) to have a read-only interface (like the RTC), leaving PTPd to manage offset calculations

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-17 Thread john stultz
On Tue, 2010-08-17 at 10:53 +0200, Richard Cochran wrote: On Mon, Aug 16, 2010 at 12:24:48PM -0700, john stultz wrote: 3) I'm not sure I see the benefit of being able to have multiple frequency corrected time domains. In other words, what benefit would you get from adjusting a PTP clock's

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-17 Thread john stultz
On Tue, 2010-08-17 at 13:36 +0200, Arnd Bergmann wrote: On Tuesday 17 August 2010, Richard Cochran wrote: On Tue, Aug 17, 2010 at 09:25:55AM +, Arnd Bergmann wrote: Another difference is that we generally use ioctl for devices that can be enumerated, while syscalls are for system

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-16 Thread john stultz
On Mon, Aug 16, 2010 at 4:17 AM, Richard Cochran richardcoch...@gmail.com wrote: This patch adds an infrastructure for hardware clocks that implement IEEE 1588, the Precision Time Protocol (PTP). A class driver offers a registration method to particular hardware clock drivers. Each clock is

Re: [PATCH 1/5] ptp: Added a brand new class driver for ptp clocks.

2010-08-16 Thread john stultz
On Mon, Aug 16, 2010 at 12:24 PM, john stultz johns...@us.ibm.com wrote: On Mon, Aug 16, 2010 at 4:17 AM, Richard Cochran A few comments below +** PTP user space API + +   The class driver creates a character device for each registered PTP +   clock. User space programs may control

Re: [PATCH 04/11] powerpc: Simplify update_vsyscall

2010-07-27 Thread john stultz
On Wed, 2010-07-28 at 09:41 +1000, Paul Mackerras wrote: On Tue, Jul 13, 2010 at 05:56:21PM -0700, John Stultz wrote: Currently powerpc's update_vsyscall calls an inline update_gtod. However, both are straightforward, and there are no other users, so this patch merges update_gtod

Re: [PATCH 2/5] Implement generic time of day clocksource for powerpc machines.

2007-09-20 Thread john stultz
On Thu, 2007-09-20 at 10:52 +1000, Paul Mackerras wrote: Daniel Walker writes: If you switch to the rtc do the shift and mult need to change? You can't switch; any given CPU chip will have either the RTC or the timebase but not both. I think what Daniel is pointing out is that the