Re: [PATCH 00/10] Remove obsolete and orphaned wifi drivers

2023-10-31 Thread Kalle Valo
Arnd Bergmann writes: > From: Arnd Bergmann > > As discussed previously, a lot of the older wifi drivers are likely > entirely unused, Though we can't know for sure. > > As suggested by both Greg and Jakub, let's remove the ones that look > are most likely to have no users left and also get in

Re: [PATCH 00/10] Remove obsolete and orphaned wifi drivers

2023-10-30 Thread Kalle Valo
John Paul Adrian Glaubitz writes: > There is some non-x86 hardware like the Amiga that still uses > PCMCIA-style networking cards on machines like the A600 and A1200. So, > unless these drivers are actually causing problems, I would rather not > see them go yet. There is a cost maintaining

Re: [PATCH 10/10] [RFC] wifi: remove ipw2100/ipw2200 drivers

2023-10-26 Thread Kalle Valo
Philipp Hortmann writes: > On 10/26/23 00:27, Witold Baryluk wrote: >> I might be interested in modernizing the driver, but I have no idea >> how much effort it would be (in terms of changed fraction of code). >> 20k LOC is neither small or big, and not obvious (a lot of it would >> be

Re: [PATCH 10/10] [RFC] wifi: remove ipw2100/ipw2200 drivers

2023-10-26 Thread Kalle Valo
Witold Baryluk writes: >> From: Arnd Bergmann >> >> These two drivers were used for the earliest "Centrino" branded Intel >> laptops during the late 32-bit Pentium-M era, roughly 2003 to 2005, which >> probably makes it the most modern platform that still uses the wireless >> extension

Re: [PATCH 10/10] [RFC] wifi: remove ipw2100/ipw2200 drivers

2023-10-24 Thread Kalle Valo
Stefan Lippers-Hollmann writes: > On 2023-10-23, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> These two drivers were used for the earliest "Centrino" branded Intel >> laptops during the late 32-bit Pentium-M era, roughly 2003 to 2005, which >> probably makes it the most modern platform

Re: [PATCH 00/10] Remove obsolete and orphaned wifi drivers

2023-10-23 Thread Kalle Valo
"Arnd Bergmann" writes: > On Mon, Oct 23, 2023, at 15:45, Kalle Valo wrote: >> Arnd Bergmann writes: >> >>> From: Arnd Bergmann >>> >>> As discussed previously, a lot of the older wifi drivers are likely >>> entirely unused, Tho

Re: [PATCH 10/10] [RFC] wifi: remove ipw2100/ipw2200 drivers

2023-10-23 Thread Kalle Valo
Arnd Bergmann writes: > From: Arnd Bergmann > > These two drivers were used for the earliest "Centrino" branded Intel > laptops during the late 32-bit Pentium-M era, roughly 2003 to 2005, which > probably makes it the most modern platform that still uses the wireless > extension interface

Re: [PATCH 04/10] wifi: remove obsolete hostap driver

2023-10-23 Thread Kalle Valo
Arnd Bergmann writes: > From: Arnd Bergmann > > HostAP is an ISA/PCMCIA style 802.11b driver supporting only > wireless extensions, and some custom ioctls (already removed). > Some devices include a legacy PCI bridge but no DMA. > > The driver was marked obsolete in 2016 and is highly unlikely

Re: [PATCH 00/10] Remove obsolete and orphaned wifi drivers

2023-10-23 Thread Kalle Valo
Arnd Bergmann writes: > From: Arnd Bergmann > > As discussed previously, a lot of the older wifi drivers are likely > entirely unused, Though we can't know for sure. > > As suggested by both Greg and Jakub, let's remove the ones that look > are most likely to have no users left and also get in

Re: [PATCH] net: Use of_property_read_bool() for boolean properties

2023-03-13 Thread Kalle Valo
et/xilinx/ll_temac_main.c | 9 - > drivers/net/wan/fsl_ucc_hdlc.c | 11 +++ > drivers/net/wireless/ti/wlcore/spi.c| 3 +-- > net/ncsi/ncsi-manage.c | 4 ++-- > 17 files changed, 35 insertions(+), 47 deletions(-) For

Re: [PATCH v1 1/3] coding-style.rst: document BUG() and WARN() rules ("do not crash the kernel")

2022-09-26 Thread Kalle Valo
David Hildenbrand writes: >>> +Use WARN_ON_ONCE() rather than WARN() or WARN_ON() >>> +** >>> + >>> +WARN_ON_ONCE() is generally preferred over WARN() or WARN_ON(), because it >>> +is common for a given warning condition, if it occurs at all, to

Re: [PATCH v1 1/3] coding-style.rst: document BUG() and WARN() rules ("do not crash the kernel")

2022-09-20 Thread Kalle Valo
David Hildenbrand writes: > Linus notes [1] that the introduction of new code that uses VM_BUG_ON() > is just as bad as BUG_ON(), because it will crash the kernel on > distributions that enable CONFIG_DEBUG_VM (like Fedora): > > VM_BUG_ON() has the exact same semantics as BUG_ON. It is

Re: [PATCH net-next] orinoco: Prepare cleanup of powerpc's asm/prom.h

2022-04-06 Thread Kalle Valo
Christophe Leroy wrote: > powerpc's asm/prom.h brings some headers that it doesn't > need itself. > > In order to clean it up, first add missing headers in > users of asm/prom.h > > Signed-off-by: Christophe Leroy Patch applied to wireless-next.git, thanks. 3223e922ccf8 orinoco: Prepare

Re: [PATCH net-next] orinoco: Prepare cleanup of powerpc's asm/prom.h

2022-04-02 Thread Kalle Valo
Christophe Leroy writes: > powerpc's asm/prom.h brings some headers that it doesn't > need itself. > > In order to clean it up, first add missing headers in > users of asm/prom.h > > Signed-off-by: Christophe Leroy > --- > drivers/net/wireless/intersil/orinoco/airport.c | 1 + > 1 file

Re: [PATCH 20/22] wireless: Replace comments with C99 initializers

2022-03-28 Thread Kalle Valo
Benjamin Stürz wrote: > This replaces comments with C99's designated > initializers because the kernel supports them now. > > Signed-off-by: Benjamin Stürz The title prefix should be "ray_cs: ". Patch set to Changes Requested. --

Re: [PATCH 00/22] Replace comments with C99 initializers

2022-03-28 Thread Kalle Valo
Benjamin Stürz writes: > On 28.03.22 11:33, Kalle Valo wrote: >> Benjamin Stürz writes: >> >>> This patch series replaces comments with C99's designated initializers >>> in a few places. It also adds some enum initializers. This is my first >>> time c

Re: [PATCH 00/22] Replace comments with C99 initializers

2022-03-28 Thread Kalle Valo
Benjamin Stürz writes: > This patch series replaces comments with C99's designated initializers > in a few places. It also adds some enum initializers. This is my first > time contributing to the Linux kernel, therefore I'm probably doing a > lot of things the wrong way. I'm sorry for that.

Re: [PATCH 21/22] rtw89: Replace comments with C99 initializers

2022-03-28 Thread Kalle Valo
Larry Finger writes: > On 3/26/22 11:59, Benjamin Stürz wrote: >> This replaces comments with C99's designated >> initializers because the kernel supports them now. >> >> Signed-off-by: Benjamin Stürz >> --- >> drivers/net/wireless/realtek/rtw89/coex.c | 40 +++ >> 1 file

Re: [patch 10/22] genirq/msi, treewide: Use a named struct for PCI/MSI attributes

2021-11-29 Thread Kalle Valo
|6 - > arch/sparc/kernel/pci_msi.c |4 - > arch/x86/kernel/apic/msi.c|2 > arch/x86/pci/xen.c|6 - > drivers/net/wireless/ath/ath11k/pci.c |2 For ath11k: Acked-by: Kalle Valo -- https:/

Re: [PATCH v4 4/8] PCI: replace pci_dev::driver usage that gets the driver name

2021-09-28 Thread Kalle Valo
the > driver name by dev_driver_string() which implicitly makes use of struct > pci_dev::dev->driver. > > Signed-off-by: Uwe Kleine-König > --- > arch/powerpc/include/asm/ppc-pci.h | 9 - > drivers/bcma/host_pci.c | 7 --- F

Re: [patch V3 04/20] orinoco_usb: Use the regular completion interfaces

2020-03-22 Thread Kalle Valo
gt; open coded wait/poll to regular completion interfaces. > > This changes the wait to exclusive wait mode. But that does not make any > difference because the wakers use complete_all() which ignores the > exclusive mode. > > Reported-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas

Re: [PATCH] Documentation: Clarify better about the rwsem non-owner release issue

2020-03-22 Thread Kalle Valo
i and linux-usb addresses: "linux-...@vger.kernel.org Felipe Balbi" , "linux-...@vger.kernel.org Kalle Valo" , -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-26 Thread Kalle Valo
Krzysztof Kozlowski wrote: > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version

Re: [PATCH v2 9/9] net: wireless: ath5k: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-10 Thread Kalle Valo
"const" version for const-safety and > consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/net/wireless/ath/ath5k/ahb.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) No need to have "net: wireless: "

Re: [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-10 Thread Kalle Valo
rtl8180.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) No need to have "net: wireless: " in the title, this is enough. rtl818x: Constify ioreadX() iomem argument (as in generic implementation) I assume someone else will take this so here's my ack: Acked-by: Kalle

Re: ssb: Remove SSB_WARN_ON, SSB_BUG_ON and SSB_DEBUG

2018-08-09 Thread Kalle Valo
ch Applied manually: 209b43759d65 ssb: Remove SSB_WARN_ON, SSB_BUG_ON and SSB_DEBUG -- Kalle Valo

Re: [PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER

2017-10-08 Thread Kalle Valo
mer.h) > > Signed-off-by: Kees Cook <keesc...@chromium.org> > Acked-by: Geert Uytterhoeven <ge...@linux-m68k.org> # for m68k parts [...] > drivers/net/wireless/atmel/at76c50x-usb.c | 2 +- For wireless: Acked-by: Kalle Valo <kv...@codeaurora.org> -- Kalle Valo