Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string()

2024-06-10 Thread Linus Walleij
us but long. I think I stayed off it because changing stuff like that all over the place creates churn and churn is bad. Yours, Linus Walleij

Re: [PATCH 64/64] i2c: reword i2c_algorithm in drivers according to newest specification

2024-04-02 Thread Linus Walleij
needed. For the others more work needs to be done but this will be > performed incrementally along with API changes/improvements. All these > changes here are simple search/replace results. > > Signed-off-by: Wolfram Sang Acked-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 2/9] dma: Convert from tasklet to BH workqueue

2024-04-02 Thread Linus Walleij
tem_bh_wq, &d40c->work); Why is "my" driver not allowed to use system_bh_highpri_wq? I can't see the reasoning between some drivers using system_bh_wq and others being highpri? Given the DMA usecase I would expect them all to be high prio. Yours, Linus Walleij

Re: [PATCH 9/9] mmc: Convert from tasklet to BH workqueue

2024-03-28 Thread Linus Walleij
of elaborate code and test it (preferably on real hardware). Yours, Linus Walleij

Re: [PATCH] powerpc: Split PAGE_SHIFT/SIZE into vdso/page.h

2023-12-21 Thread Linus Walleij
ot;) > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202311061940.4pbrm44u-...@intel.com/ > Signed-off-by: Michael Ellerman Clearly a working solution! Acked-by: Linus Walleij Just a note: > diff --git a/arch/powerpc/include/asm/page.h b/arch/p

Re: [PATCH] powerpc: Fix signature of pfn_to_kaddr()

2023-11-07 Thread Linus Walleij
what actually causes that. > Is it the right bug report link? Yeah I'm just bad at understanding these reports. > The current signature of: > > static inline const void *pfn_to_kaddr(unsigned long pfn) ... > > seems OK to me. OK then, drop this patch. Yours, Linus Walleij

[PATCH] powerpc: Fix signature of pfn_to_kaddr()

2023-11-06 Thread Linus Walleij
https://lore.kernel.org/oe-kbuild-all/202311061940.4pbrm44u-...@intel.com/ Fixes: 58b6fed89ab0 ("powerpc: Make virt_to_pfn() a static inline") Signed-off-by: Linus Walleij --- The remaining warnings from the test robot appear a bit bogus. If someone knows what to do about them, please hel

Re: [PATCH v5 28/31] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-09-12 Thread Linus Walleij
On Tue, Sep 12, 2023 at 4:31 PM Mark Brown wrote: > On Tue, Sep 12, 2023 at 01:04:56PM +0200, Linus Walleij wrote: > > On Tue, Sep 12, 2023 at 12:15 PM Herve Codina > > wrote: > > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > +/* > > > I think

Re: [PATCH v5 29/31] MAINTAINERS: Add the Lantiq PEF2256 driver entry

2023-09-12 Thread Linus Walleij
Just use a glob expression: F: drivers/pinctrl/pinctrl-pef2256-* Yours, Linus Walleij

Re: [PATCH v5 28/31] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-09-12 Thread Linus Walleij
dev_err(pef2256->dev, "pinctrl driver registration failed\n"); > + return PTR_ERR(pctrl); > + } > + > + return 0; You could use return dev_err_probe(...); > + pef2256_reset_pinmux(pef2256_pinctrl); > + ret = pef2256_register_pinctrl(pef2256_pinctrl); > + if (ret) > + return ret; Or you could use it down here. With or without these changes (because they are nitpicks) Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v5 27/31] net: wan: framer: Add support for the Lantiq PEF2256 framer

2023-09-12 Thread Linus Walleij
> Reviewed-by: Christophe Leroy > Signed-off-by: Christophe Leroy Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v4 21/28] net: wan: Add framer framework support

2023-08-21 Thread Linus Walleij
On Mon, Aug 21, 2023 at 7:19 AM Christophe Leroy wrote: > Le 20/08/2023 à 23:06, Linus Walleij a écrit : > > On Fri, Aug 18, 2023 at 6:41 PM Christophe Leroy > > wrote: > > > >> From: Herve Codina > >> > >> A framer is a component in charge of an

Re: [PATCH v4 21/28] net: wan: Add framer framework support

2023-08-20 Thread Linus Walleij
had these review comments, you must have missed them? https://lore.kernel.org/netdev/cacrpkdzq9_f6+9csev1l_wgphhujfpayxmjjfjurzszrako...@mail.gmail.com/ Yours, Linus Walleij

Re: [PATCH] powerpc: Make virt_to_pfn() a static inline

2023-08-15 Thread Linus Walleij
On Tue, Aug 15, 2023 at 9:30 AM Michael Ellerman wrote: > Linus Walleij writes: > > - return ((unsigned long)__va(pmd_val(pmd) & ~PMD_MASKED_BITS)); > > + return (const void *)((unsigned long)__va(pmd_val(pmd) & > > ~PMD_MASKED_BITS)); > > This can al

Re: [PATCH] powerpc: Make virt_to_pfn() a static inline

2023-08-14 Thread Linus Walleij
return __va(pfn << PAGE_SHIFT); > > Seems to be equivalent and much cleaner? I was afraid of changing the semantic in the original macro which converts to a virtual address before shifting, instead of shifting first, but you're right, I'm too cautious. I'll propose th

Re: [PATCH v3 21/28] net: wan: Add framer framework support

2023-08-10 Thread Linus Walleij
. Is "long distance link time division multiplexing (TDM) framer" more to the point for example? Or is the ambition to frame other multiplexing techniques as well with this subsystem? Such as FDM? Then mention that. Yours, Linus Walleij

Re: [PATCH v3 22/28] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

2023-08-10 Thread Linus Walleij
GPI, GPOH, GPOL ] > + > +required: > + - pins > + - function Because those are certainly defined in that file. Yours, Linus Walleij

[PATCH] powerpc: Make virt_to_pfn() a static inline

2023-08-09 Thread Linus Walleij
ng an unsigned int to virt_to_phys() so fix that up with a cast so the result compiles. Signed-off-by: Linus Walleij --- arch/powerpc/include/asm/nohash/32/pgtable.h | 2 +- arch/powerpc/include/asm/nohash/64/pgtable.h | 2 +- arch/powerpc/include/asm/page.h

Re: [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-08-08 Thread Linus Walleij
On Mon, Aug 7, 2023 at 3:10 PM Mark Brown wrote: > On Mon, Aug 07, 2023 at 03:05:15PM +0200, Linus Walleij wrote: > > On Wed, Jul 26, 2023 at 5:04 PM Herve Codina > > wrote: > > > > +#include "linux/bitfield.h" > > > Really? I don't think ther

Re: [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-08-07 Thread Linus Walleij
On Mon, Aug 7, 2023 at 3:05 PM Linus Walleij wrote: > > Signed-off-by: Herve Codina > > So it is a bridge chip? Please use that terminology since Linux > DRM often talks about bridges. Replying to self: no it's not a bridge, it's a WAN thingy. So perhaps write tha

Re: [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

2023-08-07 Thread Linus Walleij
t pef2256_function_desc *functions; > + unsigned int nfunctions; > + } pinctrl; Uh anonymous struct... can't you just define the struct separately with a name? Or fold it into struct pef2256_pinctrl without the additional struct? Thanks. Otherwise it looks neat! Yours, Linus Walleij

Re: [PATCH 0/7] Expect immutable pointer in virt_to_phys/isa_virt_to_bus prototypes

2023-05-03 Thread Linus Walleij
he maintainers side. > > The following series implements... This is nice. Reviewed-by: Linus Walleij I am working with an adjacent task, which is to make virt_to_pfn() and pfn_to_virt() into static inlines. I might need to rebase my work on top of this but it should be doable, I am currentl

Re: [PATCH 17/21] ARM: dma-mapping: use arch_sync_dma_for_{device,cpu}() internally

2023-03-31 Thread Linus Walleij
ctoring alone makes the patch highly valuable. Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 15/21] ARM: dma-mapping: always invalidate WT caches before DMA

2023-03-31 Thread Linus Walleij
rms. This > should have no user visible effect. > > Signed-off-by: Arnd Bergmann Looks good to me. Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 18/21] ARM: drop SMP support for ARM11MPCore

2023-03-30 Thread Linus Walleij
ACHE_RWFO option and the cache > management implementation for it. This also helps with other ARMv6 > issues, but for the moment leaves the ability to build a kernel that > can run on both ARMv7 SMP and single-processor ARMv6, which we probably > want to stop supporting as well, but not a

Re: [PATCH v10 03/13] dt-bindings: Convert gpio-mmio to yaml

2023-03-13 Thread Linus Walleij
if I should wait on Sean's patch being accepted and > then I could re-submit the driver changes. > What's the consensus ? Sean picked it up for shepherding, it looks very good, as soon as the DT maintainers give it a nod Bartosz can merge it. Yours, Linus Walleij

Re: [PATCH v11 03/13] dt-bindings: Convert gpio-mmio to yaml

2023-03-13 Thread Linus Walleij
ted from the comments in the source. There is no set order for the > registers, so I have not specified one. > > Rename brcm,bcm6345-gpio to brcm,bcm63xx-gpio to reflect that bcm6345 > has moved. > > Signed-off-by: Sean Anderson > Reviewed-by: Linus Walleij > --- > Linus or Ba

Re: [PATCH v10 03/13] dt-bindings: Convert gpio-mmio to yaml

2023-03-09 Thread Linus Walleij
clude Sean on the reviewer list! Yours, Linus Walleij

Re: [PATCH v10 03/13] dt-bindings: Convert gpio-mmio to yaml

2023-03-06 Thread Linus Walleij
ts, however IIRC you have to use oneOf and const: to do it, like I do in Documentation/devicetree/bindings/input/touchscreen/cypress,cy8ctma340.yaml but don't overinvest in this if it is cumbersome. Either way: Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v4 02/18] ARM: s3c24xx: Use the right include

2023-02-09 Thread Linus Walleij
On Wed, Feb 8, 2023 at 6:39 PM Krzysztof Kozlowski wrote: > On 08/02/2023 18:33, Andy Shevchenko wrote: > > From: Linus Walleij > > > > The file s3c64xx.c is including despite using no > > symbols from the file, however it needs it to implicitly bring in > >

Re: [PATCH v4 18/18] gpiolib: Clean up headers

2023-02-09 Thread Linus Walleij
- sort each group alphabetically > > Signed-off-by: Andy Shevchenko Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v4 13/18] gpio: reg: Add missing header(s)

2023-02-09 Thread Linus Walleij
Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v4 12/18] gpio: aggregator: Add missing header(s)

2023-02-09 Thread Linus Walleij
; Signed-off-by: Andy Shevchenko > Reviewed-by: Geert Uytterhoeven Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v4 17/18] gpiolib: Group forward declarations in consumer.h

2023-02-09 Thread Linus Walleij
On Wed, Feb 8, 2023 at 6:34 PM Andy Shevchenko wrote: > For better maintenance group the forward declarations together. > > Signed-off-by: Andy Shevchenko Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v4 16/18] gpiolib: Deduplicate forward declarations in consumer.h

2023-02-09 Thread Linus Walleij
On Wed, Feb 8, 2023 at 6:34 PM Andy Shevchenko wrote: > The struct fwnode_handle pointer is used in both branches of ifdeffery, > no need to have a copy of the same in each of them, just make it global. > > Signed-off-by: Andy Shevchenko Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v4 14/18] gpio: regmap: Add missing header(s)

2023-02-09 Thread Linus Walleij
Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH v3 06/12] gpiolib: split linux/gpio/driver.h out of linux/gpio.h

2023-02-08 Thread Linus Walleij
On Wed, Feb 8, 2023 at 3:51 PM Andy Shevchenko wrote: > On Wed, Feb 08, 2023 at 12:55:06AM +0200, Andy Shevchenko wrote: > > On Tue, Feb 07, 2023 at 03:55:23PM +0100, Linus Walleij wrote: > > > On Tue, Feb 7, 2023 at 3:29 PM Andy Shevchenko > > > wrote: > &

Re: [PATCH v3 06/12] gpiolib: split linux/gpio/driver.h out of linux/gpio.h

2023-02-07 Thread Linus Walleij
s directly from where they are used. > > Reviewed-by: Andy Shevchenko > Signed-off-by: Arnd Bergmann > Reviewed-by: Linus Walleij > Signed-off-by: Andy Shevchenko Make sure you push this to the kernel.org build servers (zeroday builds), I think this patch needs to hit some more fil

Re: [PATCH RESEND 0/8] Resend LED patches

2023-01-26 Thread Linus Walleij
, so that's why we didn't notice. By all means, pick it up! Yours, Linus Walleij

Re: [PATCH 2/5] arm: dts: remove label = "cpu" from DSA dt-binding

2022-12-04 Thread Linus Walleij
On Wed, Nov 30, 2022 at 3:13 PM Arınç ÜNAL wrote: > This is not used by the DSA dt-binding, so remove it from all devicetrees. > > Signed-off-by: Arınç ÜNAL Acked-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH] soc: fsl: qe: request pins non-exclusively

2022-11-08 Thread Linus Walleij
;) > Signed-off-by: Dmitry Torokhov Wow! Thanks for fixing this! Reviewed-by: Linus Walleij I just sent that patch into the SoC patch tracker (s...@kernel.org) with a not to apply it directly, I suggest you do the same (or ask me to sign it off and send it). Yours, Linus Walleij

[PATCH v3] soc: fsl: qe: Avoid using gpio_to_desc()

2022-10-27 Thread Linus Walleij
_chip. Cc: Bartosz Golaszewski Cc: linux-g...@vger.kernel.org Signed-off-by: Linus Walleij --- SoC folks: please apply this directly for -next if it seems OK. ChangeLog v2->v3: - Realize what the driver is trying to do and make a deeper refactoring to get at gpiolib internals. ChangeLog v1-&g

[PATCH v2] soc: fsl: qe: Avoid using gpio_to_desc()

2022-10-26 Thread Linus Walleij
...@vger.kernel.org Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Add back the include: we are using the mm_of_gpio_chip, which should be fixed, but not now. --- drivers/soc/fsl/qe/gpio.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/

[PATCH] soc: fsl: qe: Avoid using gpio_to_desc()

2022-10-24 Thread Linus Walleij
...@vger.kernel.org Signed-off-by: Linus Walleij --- drivers/soc/fsl/qe/gpio.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/soc/fsl/qe/gpio.c b/drivers/soc/fsl/qe/gpio.c index 99f7de43c3c6..cc5602b679fe 100644 --- a/drivers/soc/fsl/qe/gpio.c +++ b

[PATCH] USB: FHCI: Switch to GPIO descriptors

2022-08-31 Thread Linus Walleij
This driver for the PPC Freescale SoC is using device tree accessors and imperative GPIO semantics control using the old GPIO API, switch it over to use GPIO descriptors. Cc: Li Yang Cc: linuxppc-dev@lists.ozlabs.org Cc: Zhao Qiang Cc: Guilherme Maciel Ferreira Signed-off-by: Linus Walleij

Re: [PATCH v1 1/1] powerpc/83xx/mpc8349emitx: Get rid of of_node assignment

2022-04-19 Thread Linus Walleij
On Wed, Apr 6, 2022 at 3:02 PM Andy Shevchenko wrote: > On Mon, Mar 28, 2022 at 03:16:08PM +0200, Linus Walleij wrote: > > On Wed, Mar 23, 2022 at 6:43 PM Andy Shevchenko > > wrote: > > > > > Let GPIO library to assign of_node from the parent device. > > &g

Re: [PATCH v1 1/1] powerpc/83xx/mpc8349emitx: Get rid of of_node assignment

2022-03-28 Thread Linus Walleij
's a nice patch. Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 09/22] gpio-winbond: Use C99 initializers

2022-03-27 Thread Linus Walleij
On Sat, Mar 26, 2022 at 6:00 PM Benjamin Stürz wrote: > This replaces comments with C99's designated > initializers because the kernel supports them now. > > Signed-off-by: Benjamin Stürz Reviewed-by: Linus Walleij Yours, Linus Walleij

[PATCH] RFC: powerpc: wii.dts: Fix up GPIO I2C bus

2022-03-03 Thread Linus Walleij
Belloni Signed-off-by: Linus Walleij --- arch/powerpc/boot/dts/wii.dts | 43 ++- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/arch/powerpc/boot/dts/wii.dts b/arch/powerpc/boot/dts/wii.dts index e46143c32308..2e51100d2dab 100644 --- a/arch/powerpc

[PATCH] spi: mpc512x-psc: Fix compile errors

2022-02-01 Thread Linus Walleij
My patch created compilation bugs in the MPC512x-PSC driver. Fix them up. Cc: Uwe Kleine-König Cc: Anatolij Gustschin Cc: linuxppc-dev@lists.ozlabs.org Reported-by: kernel test robot Fixes: 2818824ced4b (" spi: mpc512x-psc: Convert to use GPIO descriptors") Signed-off-by: Lin

[PATCH v2] spi: mpc512x-psc: Convert to use GPIO descriptors

2022-01-19 Thread Linus Walleij
ode the gpiod setting instead, this is easier to read. The only platform that overrides the cs_control callback is the mpc832x_rdb. Cc: Uwe Kleine-König Cc: Anatolij Gustschin Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Stop trying to use the co

Re: [PATCH v5 00/14] PCI: Add support for Apple M1

2021-10-04 Thread Linus Walleij
t until -rc1 or months later on those old systems. Lets page the PPC lists to see if someone can test on some powermac. Linus Walleij

Re: [PATCH 02/17] rtc: pl031: use RTC_FEATURE_ALARM

2021-01-11 Thread Linus Walleij
On Mon, Jan 11, 2021 at 12:18 AM Alexandre Belloni wrote: > Clear RTC_FEATURE_ALARM instead of setting set_alarm, read_alarm and > alarm_irq_enable to NULL. > > Signed-off-by: Alexandre Belloni Acked-by: Linus Walleij Yours, Linus Walleij

[PATCH 2/2] spi: mpc512x-psc: Convert to use GPIO descriptors

2020-07-29 Thread Linus Walleij
ine-König Cc: Anatolij Gustschin Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Linus Walleij --- drivers/spi/spi-mpc512x-psc.c | 33 +++-- 1 file changed, 7 insertions(+), 26 deletions(-) diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c in

[PATCH 1/2] spi: mpc512x-psc: Use the framework .set_cs()

2020-07-29 Thread Linus Walleij
-König Cc: Anatolij Gustschin Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Linus Walleij --- drivers/spi/spi-mpc512x-psc.c | 30 -- 1 file changed, 8 insertions(+), 22 deletions(-) diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c index

[PATCH] spi: ppc4xx: Convert to use GPIO descriptors

2020-07-14 Thread Linus Walleij
so we need to add a new exception to the gpiolib OF parser to allow this for this driver's compatibles. Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Linus Walleij --- drivers/gpio/gpiolib-of.c | 10 ++-- drivers/spi/spi-ppc4xx.c | 106 -- 2 fil

Re: [PATCH v2] tty: serial: cpm_uart: Fix behaviour for non existing GPIOs

2020-06-20 Thread Linus Walleij
ptional() instead. > > At the same time, handle the error case and properly exit > with an error. > > Fixes: 97cbaf2c829b ("tty: serial: cpm_uart: Convert to use GPIO descriptors") > Cc: sta...@vger.kernel.org > Cc: Linus Walleij > Signed-off-by: Christophe Leroy

Re: [PATCH] tty: serial: cpm_uart: Fix behaviour for non existing GPIOs

2020-06-10 Thread Linus Walleij
o us properly exiting with an error. Yours, Linus Walleij

Re: [PATCH] powerpc/devicetrees: Change 'gpios' to 'cs-gpios' on fsl,spi nodes

2019-11-28 Thread Linus Walleij
ty. > > Signed-off-by: Christophe Leroy Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH] gpio: max7301: fix driver for use with CONFIG_VMAP_STACK

2018-12-15 Thread Linus Walleij
_then_read() which doesn't require DMA-safe buffers. > > Fixes: 0c36ec314735 ("gpio: gpio driver for max7301 SPI GPIO expander") > Cc: > Signed-off-by: Christophe Leroy Patch applied for fixes. Yours, Linus Walleij

Re: [PATCH v1 1/1] misc: IBM Virtual Management Channel Driver

2018-04-25 Thread Linus Walleij
rtunately. If some specific domain knowledge is needed to read and understand the document, you need to state these prerequisites at the beginning of the document. Something like: "if you don't know a lot about virtualization already, then don't even bother trying to read this document". Yours, Linus Walleij

Re: [PATCH v3 2/4] gpio: Add GPIO driver for Nintendo Wii

2018-02-22 Thread Linus Walleij
needed we can just patch on top of this. It's a very pretty driver, good work! Yours, Linus Walleij

Re: [PATCH v2 3/6] gpio: Add GPIO driver for Nintendo Wii

2018-02-07 Thread Linus Walleij
gt; > v2: All looks very good to me, Andy had some additional comments, once addressed in v3 I will apply this. You only need to resend this patch as I already applied the DT bindings. Yours, Linus Walleij

Re: [PATCH v2 4/6] dt-bindings: gpio: Add binding for Wii GPIO controller

2018-02-07 Thread Linus Walleij
> Reviewed-by: Rob Herring > --- > > v2: Patch applied for 4.17. Yours, Linus Walleij

Re: [PATCH 3/6] gpio: Add GPIO driver for Nintendo Wii

2018-01-16 Thread Linus Walleij
d IRQ support you should probably have your own file for this driver, but it will be just a few lines of wrapper using bgpio_init() and BGPIOF_BIG_ENDIAN and/or possibly BGPIOF_BIG_ENDIAN_BYTE_ORDER. See the other drivers. Yours, Linus Walleij

Re: [PATCH 4/6] dt-bindings: gpio: Add binding for Wii GPIO controller

2018-01-16 Thread Linus Walleij
On Mon, Jan 15, 2018 at 4:13 AM, Jonathan Neuschäfer wrote: maybe some small blurb here? > Signed-off-by: Jonathan Neuschäfer It looks good, very standard bindings. Yours, Linus Walleij

Re: [PATCH] machintosh: select defaults for cooling

2017-07-15 Thread Linus Walleij
On Sat, Jul 15, 2017 at 12:53 AM, Benjamin Herrenschmidt wrote: > On Fri, 2017-07-14 at 13:46 +0200, Linus Walleij wrote: >> I have this pretty nasty problem when trying to boot up a fresh >> openSuSE DVD on a PowerMac G5: the kernel by default does not have >> CONFIG_WINDFA

[PATCH] machintosh: select defaults for cooling

2017-07-14 Thread Linus Walleij
PPC_PMAC64, WINDFARM by default on PPC_PMAC and all the WINDFARM thermal managers by default if CPU_FREQ_PMAC64 is selected. I think this will make install images work in the G5 Macs. Cc: sta...@vger.kernel.org Signed-off-by: Linus Walleij --- drivers/macintosh/Kconfig | 6 ++ 1 file changed, 6

Re: [PATCH] powerpc: sysdev: simple_gpio: fix Oops in gpio save_regs function

2017-05-29 Thread Linus Walleij
gt; Fixes: 937daafca774b ("powerpc: simple-gpio: use gpiochip data pointer") > Cc: sta...@vger.kernel.org > > Signed-off-by: Christophe Leroy Reviewed-by: Linus Walleij Sorry for any screwups I've caused... Yours, Linus Walleij

Re: [PATCH] soc: fsl/qe: fix gpio save_regs functions

2016-09-07 Thread Linus Walleij
("powerpc: qe_lib-gpio: use gpiochip data pointer") > Signed-off-by: Christophe Leroy > Cc: Aha sorry for my regular screwups. :( Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH] powerpc: sysdev: cpm: fix gpio save_regs functions

2016-08-11 Thread Linus Walleij
3ee21d72ffa ]--- > > fixes: e65078f1f3490 ("powerpc: sysdev: cpm1: use gpiochip data pointer") > fixes: a14a2d484b386 ("powerpc: cpm_common: use gpiochip data pointer") > Cc: sta...@vger.kernel.org > Signed-off-by: Christophe Leroy Reviewed-by: Linus Walleij Sorry for screwing stuff up :( Yours, Linus Walleij

Re: [PATCH 01/12] gpio: Only descend into gpio directory when CONFIG_GPIOLIB is set

2016-06-14 Thread Linus Walleij
-off-by: Andrew F. Davis Patch applied. Strange that this went unnoticed for years. Yours, Linus Walleij ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 5/8] dmaengine: ste_dma40: Only calculate residue if txstate exists.

2016-06-08 Thread Linus Walleij
On Tue, Jun 7, 2016 at 7:38 PM, Peter Griffin wrote: > There is no point calculating the residue if there is > no txstate to store the value. > > Signed-off-by: Peter Griffin Acked-by: Linus Walleij Yours, Linus Walleij ___ Linuxppc

Re: [PATCH 3/8] dmaengine: coh901318: Only calculate residue if txstate exists.

2016-06-08 Thread Linus Walleij
On Tue, Jun 7, 2016 at 7:38 PM, Peter Griffin wrote: > There is no point in calculating the residue if there is no > txstate to store the value. > > Signed-off-by: Peter Griffin Acked-by: Linus Walleij Yours, Linus Walleij ___ Linuxppc

Re: [PATCH 8/8] dmaengine: Remove site specific OOM error messages on kzalloc

2016-06-08 Thread Linus Walleij
On Tue, Jun 7, 2016 at 7:38 PM, Peter Griffin wrote: > If kzalloc() fails it will issue it's own error message including > a dump_stack(). So remove the site specific error messages. > > Signed-off-by: Peter Griffin Acked-by: Linus Walleij A few subsystems may use a clean

Re: [PATCH] gpio: dt-bindings: add ibm,ppc4xx-gpio binding

2016-05-24 Thread Linus Walleij
the PowerPC 4XX series and compatible SoCs. (...) >> Acked-by: Rob Herring > > As this is just a binding doc, I've applied it. OK less work on my part :) Acked-by: Linus Walleij Yours, Linus Walleij ___ Linuxppc-dev mail

[PATCH 12/23] powerpc: do away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB

2016-04-20 Thread Linus Walleij
Cc: Michael Büsch Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Linus Walleij --- Various arch maintainers: either ACK this and I will merge it into the GPIO tree for v4.7 anticipating no clashes, or you wait until I have t

Re: [PATCH] powerpc: ppc4xx: drop unused variable

2016-04-01 Thread Linus Walleij
On Fri, Apr 1, 2016 at 4:31 AM, Michael Ellerman wrote: > On Thu, 2016-03-31 at 14:57 +0200, Linus Walleij wrote: >> On Thu, Mar 31, 2016 at 12:09 PM, Michael Ellerman >> wrote: >> >> > If you feel like cross building powerpc in future it should be as simple >

Re: [PATCH] powerpc: ppc4xx: drop unused variable

2016-03-31 Thread Linus Walleij
... Ah hm yeah I guess everyone "should", it's just that these days I mainly rely on Fenguang's kautobuild to do this job for me and get back with the result from a plethora of arches. Sometimes a buggy bit slips through the cracks though, sorr

[PATCH] powerpc: ppc4xx: drop unused variable

2016-03-31 Thread Linus Walleij
in Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Linus Walleij --- I've applied this to the GPIO tree where the offending commit is now merged. --- arch/powerpc/sysdev/ppc4xx_gpio.c | 1 - 1 file changed, 1 deletion(-

Re: [PATCH RESENT] powerpc: dts: don't fall back to fsl, pq3-gpio for fsl,mpc8572-gpio devices

2015-08-03 Thread Linus Walleij
ore explicit remove fsl,pq3-gpio from the list of > compatibles for mpc8572 machines. > > Signed-off-by: Uwe Kleine-König Acked-by: Linus Walleij Yours, Linus Walleij ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://list

Re: [PATCH 10/15] gpio: kconfig: replace PPC_OF with PPC

2015-02-04 Thread Linus Walleij
o sense to keep a such option in the current kernel. > Replace it with PPC. > > Signed-off-by: Kevin Hao Patch applied. Yours, Linus Walleij ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2] gpio: ge: Convert to platform driver

2014-04-22 Thread Linus Walleij
On Sat, Apr 12, 2014 at 7:41 AM, Alexander Shiyan wrote: > This patch converts GE I/O FPGA GPIO driver to platform driver. > > Signed-off-by: Alexander Shiyan No further comments, so this v2 patch is applied. Yours, Linus Walleij ___ Lin

Re: [PATCH] gpio: ge: Convert to platform driver

2014-04-10 Thread Linus Walleij
latform device or in their device trees? Yours, Linus Walleij ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2] powerpc/gpio: Fix the wrong GPIO input data on MPC8572/MPC8536

2013-11-29 Thread Linus Walleij
me scenarios: (...) > Signed-off-by: Liu Gang > --- > changes in v2: > - Added more description of the problem. > - Reduced one in_be32() call. > - Do not modify the shadow data. Applied this v2 version, added ACKs and tagged for

Re: [PATCH v2] powerpc/gpio: Fix the wrong GPIO input data on MPC8572/MPC8536

2013-11-29 Thread Linus Walleij
the status of those pins should be > read directly from GPDAT. > > Signed-off-by: Liu Gang > --- > changes in v2: > - Added more description of the problem. > - Reduced one in_be32() call. > - Do not modify the shadow data. I'm waiting f

Re: [PATCH] powerpc/gpio: Fix the wrong GPIO input data on MPC8572/MPC8536

2013-11-19 Thread Linus Walleij
pc8xxx_gc = to_mpc8xxx_gpio_chip(mm); > > val = in_be32(mm->regs + GPIO_DAT) & ~in_be32(mm->regs + GPIO_DIR); > + mpc8xxx_gc->data &= in_be32(mm->regs + GPIO_DIR); > > return (val | mpc8xxx_gc->data) & mpc8xxx_gpio2mask(gpio);

Re: [RFC 10/10] irqchip: Make versatile fpga irq driver a generic chip

2013-06-15 Thread Linus Walleij
On Sat, Jun 15, 2013 at 11:19 PM, Linus Walleij wrote: > On Mon, Jun 10, 2013 at 12:50 PM, Grant Likely > wrote: >> On Mon, Jun 10, 2013 at 8:40 AM, Linus Walleij >> wrote: >>> On Mon, Jun 10, 2013 at 2:49 AM, Grant Likely >>> wrote: >>> >&

Re: [RFC 10/10] irqchip: Make versatile fpga irq driver a generic chip

2013-06-15 Thread Linus Walleij
On Mon, Jun 10, 2013 at 12:50 PM, Grant Likely wrote: > On Mon, Jun 10, 2013 at 8:40 AM, Linus Walleij > wrote: >> On Mon, Jun 10, 2013 at 2:49 AM, Grant Likely >> wrote: >> >>> This is an RFC patch to convert the versatile FPGA irq controller driver >>

Re: [RFC 10/10] irqchip: Make versatile fpga irq driver a generic chip

2013-06-10 Thread Linus Walleij
atile FPGA driver. > > Tested on QEMU, but not on real hardware. Is this the same as the one I tested previously? If it need re-testing please push a branch and I'll take it for a spin. Yours. Linus Walleij ___ Linuxppc-dev mailing list Linuxp

Re: [PATCH 2/2] net: mv643xx_eth: proper initialization for Kirkwood SoCs

2013-05-24 Thread Linus Walleij
or a broken driver. We > could hack the whole register setup in DT as it would still accurately > describe HW. Don't get me wrong, but I don't like it. > > Haven't checked how happy Linus Walleij is about pinctrl drivers with > reg values hacked in lately. One of the t

Re: [PATCH v7 3/3] of/pci: mips: convert to common of_pci_range_parser

2013-04-17 Thread Linus Walleij
On Tue, Apr 16, 2013 at 12:18 PM, Andrew Murray wrote: > This patch converts the pci_load_of_ranges function to use the new common > of_pci_range_parser. > > Signed-off-by: Andrew Murray > Signed-off-by: Liviu Dudau > Reviewed-by: Rob Herring Tested-by: Linus Walleij Yo

Re: [PATCH 08/25] gpio/mpc8xxx: add a const qualifier

2012-07-29 Thread Linus Walleij
pio/gpio-mpc8xxx.c:360:30: warning: assignment discards > 'const' qualifier from pointer target type [enabled by default] > > Signed-off-by: Uwe Kleine-König Acked-by: Linus Walleij Yours, Linus Walleij ___ Linuxppc-dev mail

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-14 Thread Linus Walleij
On Wed, Jun 13, 2012 at 11:12 PM, Wolfram Sang wrote: > Currently, every driver has to do it on its own, but it should be done > in the core, like we already do with board_info structs. > > Signed-off-by: Wolfram Sang Acked-by: Linus Walleij Lee might be able to test this

Re: [PATCH] gpiolib/arches: Centralise bolierplate asm/gpio.h

2012-04-16 Thread Linus Walleij
On Mon, Apr 16, 2012 at 10:15 AM, Mark Brown wrote: > On Mon, Apr 16, 2012 at 09:21:58AM +0200, Linus Walleij wrote: > >> This looks good but I think we need to page the alpha, ia64, m68k, >> microblaze, >> openrisc etc subarch maintainers on this patch so they have the

Re: [PATCH] gpiolib/arches: Centralise bolierplate asm/gpio.h

2012-04-16 Thread Linus Walleij
- >  drivers/gpio/Kconfig               |    8 >  include/linux/gpio.h               |   34 + >  17 files changed, 81 insertions(+), 426 deletions(-) This looks good but I think we need to page the alpha, ia64, m

Re: [PATCH v3 4/4] powerpc: Board support for GE IMP3A

2012-03-13 Thread Linus Walleij
2012/3/13 Martyn Welch : > On 13/03/12 11:51, Linus Walleij wrote: >> This habit of changing a lot of defconfig stuff in a patch dealing with other >> stuff is alien in the ARM world. Especially when changing a horde of stuff >> that has nothing to do with the patch subject.

Re: [PATCH v3 4/4] powerpc: Board support for GE IMP3A

2012-03-13 Thread Linus Walleij
when changing a horde of stuff that has nothing to do with the patch subject. But I don't really know how PPC does these things so who am I to speak ... BTW: doesn't the "make saveconfig" reduce defconfigs on PPC? Paging Uwe on this. Yours, Linus Walleij ___

Re: [PATCH v2 0/9] DMA engine cookie handling cleanups

2012-03-07 Thread Linus Walleij
with some stressy MMC operations on the U300 and Ux500. (I had some minor hell since patch 8/9 and 9/9 were uuencoded but managed to fix it...) It works like a charm! The patches look good too. Tested-by: Linus Walleij Reviewed-by: Linus Walleij Yours, Linu

Re: [PATCH V2 1/2] powerpc: Move GE GPIO and PIC drivers

2012-03-06 Thread Linus Walleij
t; separate patch for Grant & Linus to review as part of the GPIO subsystem Yes please. It will get a good home there, Grant knows everything about PPC... Yours, Linus Walleij ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

  1   2   >