Re: [PATCH 01/16] ASoC: eureka-tlv320: Update to modern clocking terminology

2021-09-22 Thread Mark Brown
On Tue, 21 Sep 2021 22:10:25 +0100, Mark Brown wrote: > As part of moving to remove the old style defines for the bus clocks update > the eureka-tlv320 driver to use more modern terminology for clocking. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broon

Re: [PATCH v2 01/16] ASoC: eureka-tlv320: Update to modern clocking terminology

2021-09-22 Thread Mark Brown
On Tue, 21 Sep 2021 22:35:27 +0100, Mark Brown wrote: > As part of moving to remove the old style defines for the bus clocks update > the eureka-tlv320 driver to use more modern terminology for clocking. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broon

[PATCH v2 16/16] ASoC: pl1022_rdk: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the pl1022_rdk driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/p1022_rdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/p1022_rdk.c b

[PATCH v2 15/16] ASoC: pl1022_ds: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the pl1022_ds driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/p1022_ds.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/fsl

[PATCH v2 14/16] ASoC: mpc8610_hpcd: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the mpc8610_hpcd driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/mpc8610_hpcd.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound

[PATCH v2 13/16] ASoC: imx-sgtl5000: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the imx-sgtl5000 driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/imx-sgtl5000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/imx

[PATCH v2 12/16] ASoC: imx-rpmsg: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the imx-rpmsg driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/imx-rpmsg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/imx-rpmsg.c b

[PATCH v2 11/16] ASoC: imx-hdmi: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the imx-hdmi driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/imx-hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/imx-hdmi.c b

[PATCH v2 10/16] ASoC: imx-es8328: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the imx-es8328 driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/imx-es8328.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/imx-es8328.c

[PATCH v2 09/16] ASoC: imx-card: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the imx-card driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/imx-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/imx-card.c b

[PATCH v2 08/16] ASoC: imx-audmix: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the imx-audmix driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/imx-audmix.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/fsl/imx

[PATCH v2 07/16] ASoC: fsl_ssi: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the fsl_ssi driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_ssi.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff

[PATCH v2 06/16] ASoC: fsl_sai: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the fsl_sai driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_sai.c | 34 +- sound/soc/fsl/fsl_sai.h | 2 +- 2 files changed, 18

[PATCH v2 05/16] ASoC: fsl-mqs: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the fsl-mqs driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_mqs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_mqs.c b

[PATCH v2 04/16] ASoC: fsl-esai: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the fsl-esai driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_esai.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git

[PATCH v2 03/16] ASoC: fsl-audmix: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the fsl-audmix driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_audmix.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/fsl

[PATCH v2 02/16] ASoC: fsl-asoc-card: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the fsl-asoc-card driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/fsl-asoc-card.c | 54 +-- 1 file changed, 27 insertions(+), 27 deletions

[PATCH v2 01/16] ASoC: eureka-tlv320: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the eureka-tlv320 driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/eukrea-tlv320.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/eukrea

Re: [PATCH 03/16] ASoC: fsl-audmix: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
On Tue, Sep 21, 2021 at 06:22:51PM -0300, Fabio Estevam wrote: > On Tue, Sep 21, 2021 at 6:11 PM Mark Brown wrote: > > - /* For playback the AUDMIX is slave, and for record is master */ > > + /* For playback the AUDMIX is provider, and for record is consumer &g

[PATCH 16/16] ASoC: pl1022_rdk: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the pl1022_rdk driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/p1022_rdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/p1022_rdk.c b

[PATCH 15/16] ASoC: pl1022_ds: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the pl1022_ds driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/p1022_ds.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/fsl

[PATCH 14/16] ASoC: mpc8610_hpcd: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the mpc8610_hpcd driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/mpc8610_hpcd.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound

[PATCH 13/16] ASoC: imx-sgtl5000: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the imx-sgtl5000 driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/imx-sgtl5000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/imx

[PATCH 12/16] ASoC: imx-rpmsg: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the imx-rpmsg driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/imx-rpmsg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/imx-rpmsg.c b

[PATCH 11/16] ASoC: imx-hdmi: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the imx-hdmi driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/imx-hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/imx-hdmi.c b

[PATCH 10/16] ASoC: imx-es8328: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the imx-es8328 driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/imx-es8328.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/imx-es8328.c

[PATCH 09/16] ASoC: imx-card: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the imx-card driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/imx-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/imx-card.c b

[PATCH 08/16] ASoC: imx-audmix: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the imx-audmix driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/imx-audmix.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/fsl/imx

[PATCH 07/16] ASoC: fsl_ssi: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the fsl_ssi driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_ssi.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff

[PATCH 06/16] ASoC: fsl_sai: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the fsl_sai driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_sai.c | 34 +- sound/soc/fsl/fsl_sai.h | 2 +- 2 files changed, 18

[PATCH 05/16] ASoC: fsl-mqs: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the fsl-mqs driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_mqs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_mqs.c b

[PATCH 04/16] ASoC: fsl-esai: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the fsl-esai driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_esai.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git

[PATCH 03/16] ASoC: fsl-audmix: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the fsl-audmix driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_audmix.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/fsl

[PATCH 02/16] ASoC: fsl-asoc-card: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the fsl-asoc-card driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/fsl-asoc-card.c | 54 +-- 1 file changed, 27 insertions(+), 27 deletions

[PATCH 01/16] ASoC: eureka-tlv320: Update to modern clocking terminology

2021-09-21 Thread Mark Brown
As part of moving to remove the old style defines for the bus clocks update the eureka-tlv320 driver to use more modern terminology for clocking. Signed-off-by: Mark Brown --- sound/soc/fsl/eukrea-tlv320.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/eukrea

Re: [PATCH] ASoC: fsl: Constify static snd_soc_ops

2021-09-21 Thread Mark Brown
On Mon, 20 Sep 2021 21:39:47 +0200, Rikard Falkeborn wrote: > These are only assigned to the ops field in the snd_soc_dai_link struct > which is a pointer to const struct snd_soc_ops. Make them const to allow > the compiler to put them in read-only memory. > > Applied to

Re: [PATCH] ASoC: fsl_xcvr: Omit superfluous error message in fsl_xcvr_probe()

2021-07-12 Thread Mark Brown
On Thu, 24 Jun 2021 18:45:05 +0800, Tang Bin wrote: > In the function fsl_xcvr__probe(), when get irq failed, > the function platform_get_irq() logs an error message, so remove > redundant message here. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Re: [PATCH] bus: Make remove callback return void

2021-07-06 Thread Mark Brown
On Tue, Jul 06, 2021 at 11:50:37AM +0200, Uwe Kleine-König wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. Acked-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH 1/1] ASoC: fsl: remove unnecessary oom message

2021-06-23 Thread Mark Brown
On Thu, 17 Jun 2021 18:31:41 +0800, Zhen Lei wrote: > Fixes scripts/checkpatch.pl warning: > WARNING: Possible unnecessary 'out of memory' message > > Remove it can help us save a bit of memory. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks!

Re: [PATCH -next v2 0/9] ASoC: fsl: Use devm_platform_get_and_ioremap_resource()

2021-06-21 Thread Mark Brown
On Tue, 15 Jun 2021 09:39:13 +0800, Yang Yingliang wrote: > patch #1 ~ #8: > Use devm_platform_get_and_ioremap_resource() > > patch #9 > check return value of platform_get_resource_byname() > > v2: > change error message in patch #9 > > [...] Applied to

Re: [PATCH] ASoC:fsl_easrc:Remove superfluous error message around platform_get_irq()

2021-06-14 Thread Mark Brown
On Thu, 10 Jun 2021 20:50:52 +0800, Zhongjun Tan wrote: > Clean up the check for irq.dev_err is superfluous as platform_get_irq() > already prints an error.Remove curly braces to confirm to styling > requirements. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

Re: [PATCH] ASoC:fsl_spdif:Remove superfluous error message around platform_get_irq()

2021-06-14 Thread Mark Brown
On Thu, 10 Jun 2021 12:00:37 +0800, Zhongjun Tan wrote: > The platform_get_irq() prints error message telling that interrupt is > missing, hence there is no need to duplicated that message. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1]

Re: [PATCH] ASoC: fsl-asoc-card: Set .owner attribute when registering card.

2021-06-01 Thread Mark Brown
On Thu, 27 May 2021 18:34:09 +0200, Nicolas Cavallari wrote: > Otherwise, when compiled as module, a WARN_ON is triggered: > > WARNING: CPU: 0 PID: 5 at sound/core/init.c:208 snd_card_new+0x310/0x39c [snd] > [...] > CPU: 0 PID: 5 Comm: kworker/0:0 Not tainted 5.10.39 #1 > Hardware name: Freescale

Re: [PATCH -next] ASoC: imx-rpmsg: fix platform_no_drv_owner.cocci warnings

2021-05-28 Thread Mark Brown
From: Mark Brown,,, On Thu, 27 May 2021 19:07:32 +0800, Zou Wei wrote: > ./sound/soc/fsl/imx-rpmsg.c:140:3-8: No need to set .owner here. The core > will do it. > > Remove .owner field if calls are used which set it automatically > > Generated by: scri

Re: [PATCH] ASoC: fsl_xcvr: Remove unneeded semicolon

2021-05-11 Thread Mark Brown
On Thu, 6 May 2021 10:24:52 +0800, Wan Jiabing wrote: > Fix the following coccicheck warning: > > ./sound/soc/fsl/fsl_xcvr.c:739:2-3: Unneeded semicolon Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_xcvr: Remove unneeded

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2021-04-21 Thread Mark Brown
On Wed, Apr 21, 2021 at 07:43:18PM +0200, Lucas Stach wrote: > If your driver code drops the rpm refcount to 0 and starts the > autosuspend timer while a cyclic transfer is still in flight this is > clearly a bug. Autosuspend is not there to paper over driver bugs, but > to amortize cost of

Re: [PATCH] ASoC: fsl: sunxi: remove redundant dev_err call

2021-04-08 Thread Mark Brown
On Wed, 7 Apr 2021 14:56:34 +0500, Muhammad Usama Anjum wrote: > devm_ioremap_resource() prints error message in itself. Remove the > dev_err call to avoid redundant error message. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl:

Re: [PATCH v2] ASoC: imx-hdmi: fix platform_no_drv_owner.cocci warnings

2021-03-16 Thread Mark Brown
On Thu, 4 Mar 2021 17:08:01 +0800, Yang Li wrote: > ./sound/soc/fsl/imx-hdmi.c:226:3-8: No need to set .owner here. The core > will do it. > > Remove .owner field if calls are used which set it automatically Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

Re: [PATCH] ASoC: hdmi-codec: fix platform_no_drv_owner.cocci warnings

2021-03-16 Thread Mark Brown
On Wed, 3 Mar 2021 16:54:11 +0800, Yang Li wrote: > ./sound/soc/fsl/imx-hdmi.c:226:3-8: No need to set .owner here. The core > will do it. > > Remove .owner field if calls are used which set it automatically Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

Re: [PATCH] ASoC: fsl_xcvr: Use devm_platform_ioremap_resource_byname() to simplify code

2021-03-08 Thread Mark Brown
On Tue, 2 Mar 2021 20:50:02 +0800, Tang Bin wrote: > In this function, devm_platform_ioremap_resource_byname() should be > suitable to simplify code. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_xcvr: Use

Re: [PATCH][next] ASoC: fsl: fsl_easrc: Fix uninitialized variable st2_mem_alloc

2021-03-03 Thread Mark Brown
On Wed, 3 Mar 2021 09:18:35 +, Colin King wrote: > A previous cleanup commit removed the ininitialization of st2_mem_alloc. > Fix this by restoring the original behaviour by initializing it to zero. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Re: linux-next: manual merge of the spi tree with the powerpc tree

2021-02-12 Thread Mark Brown
On Fri, Feb 12, 2021 at 03:31:42PM +1100, Stephen Rothwell wrote: > BTW Mark: the author's address in 258ea99fe25a uses a non existent domain :-( Ugh, I think that's something gone wrong with b4 :( A bit late now to try to fix it up. signature.asc Description: PGP signature

Re: [PATCH 1/3] spi: mpc52xx: Avoid using get_tbl()

2021-02-09 Thread Mark Brown
On Tue, Feb 09, 2021 at 10:26:21AM +, Christophe Leroy wrote: > get_tbl() is confusing as it returns the content TBL register > on PPC32 but the concatenation of TBL and TBU on PPC64. > > Use mftb() instead. > > This will allow the removal of get_tbl() in a following patc

Re: [PATCH] ASoC: fsl: constify static snd_soc_dai_ops structs

2021-02-08 Thread Mark Brown
On Sat, 6 Feb 2021 23:58:49 +0100, Rikard Falkeborn wrote: > The only usage of these is to assign their address to the 'ops' field in > the snd_soc_dai_driver struct, which is a pointer to const. Make them > const to allow the compiler to put them in read-only memory. Applied to

Re: [PATCH] ASoC: fsl_spdif: Utilize the defined parameter to clear code

2021-02-02 Thread Mark Brown
On Thu, 28 Jan 2021 19:27:14 +0800, Tang Bin wrote: > Utilize the defined parameter 'dev' to make the code cleaner. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_spdif: Utilize the defined parameter to clear code commit:

Re: [PATCH] spi: fsl: Fix driver breakage when SPI_CS_HIGH is not set in spi->mode

2021-01-14 Thread Mark Brown
On Thu, 14 Jan 2021 13:09:37 + (UTC), Christophe Leroy wrote: > Commit 766c6b63aa04 ("spi: fix client driver breakages when using GPIO > descriptors") broke fsl spi driver. > > As now we fully rely on gpiolib for handling the polarity of > chip selects, the driver shall not alter the GPIO

Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-14 Thread Mark Brown
On Thu, Jan 14, 2021 at 02:42:26PM +0100, Christophe Leroy wrote: > Le 14/01/2021 à 14:22, Mark Brown a écrit : > > For GPIO chipselects you should really fix the driver to just hand the > > GPIO off to the core rather than trying to implement this itself, that > > will

Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-14 Thread Mark Brown
On Thu, Jan 14, 2021 at 01:33:50PM +0100, Christophe Leroy wrote: > Le 14/01/2021 à 12:59, Mark Brown a écrit : > > On Thu, Jan 14, 2021 at 12:27:42PM +0100, Christophe Leroy wrote: > > > Today I have in the DTS the CS GPIOs declared as ACTIVE_LOW. > > > If I declare

Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-14 Thread Mark Brown
On Thu, Jan 14, 2021 at 12:27:42PM +0100, Christophe Leroy wrote: > Today I have in the DTS the CS GPIOs declared as ACTIVE_LOW. > If I declare them as ACTIVE_HIGH instead, then I also have to set > spi-cs-high property, otherwise of_gpio_flags_quirks() is not happy and > forces the GPIO ACTIVE

Re: SPI not working on 5.10 and 5.11, bisected to 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

2021-01-13 Thread Mark Brown
On Wed, Jan 13, 2021 at 09:49:12AM +0100, Christophe Leroy wrote: > With commit 766c6b63aa04 ("spi: fix client driver breakages when using GPIO > descriptors") reverted, it is back to work: ... > What shall I do ? I would guess that there's an error with the chip select polarity configuration

Re: [PATCH] ASoC: fsl_xcvr: fix potential resource leak

2020-11-25 Thread Mark Brown
On Tue, 24 Nov 2020 16:19:57 +0200, Viorel Suman (OSS) wrote: > "fw" variable must be relased before return. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_xcvr: fix potential resource leak commit:

Re: [PATCH] ASoC: fsl_xcvr: fix break condition

2020-11-10 Thread Mark Brown
On Mon, 2 Nov 2020 18:18:10 +0200, Viorel Suman (OSS) wrote: > The break condition copied by mistake as same > as loop condition in the previous version, but must > be the opposite. So fix it. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks!

Re: [PATCH v4 0/2] DAI driver for new XCVR IP

2020-10-26 Thread Mark Brown
On Tue, 13 Oct 2020 15:17:31 +0300, Viorel Suman (OSS) wrote: > DAI driver for new XCVR IP found in i.MX8MP. > > Viorel Suman (2): > ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver > ASoC: dt-bindings: fsl_xcvr: Add document for XCVR > > Changes since v1: > - improved 6- and 12-ch layout

Re: [PATCH] ASoC: fsl_spdif: Fix unnecessary check in fsl_spdif_probe()

2020-10-01 Thread Mark Brown
On Wed, 26 Aug 2020 23:09:18 +0800, Tang Bin wrote: > The function fsl_spdif_probe() is only called with an openfirmware > platform device. Therefore there is no need to check that the passed > in device is NULL. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

Re: [PATCH -next] ASoC: fsl: imx-mc13783: use devm_snd_soc_register_card()

2020-10-01 Thread Mark Brown
On Tue, 29 Sep 2020 19:29:30 +0800, Qinglang Miao wrote: > Using devm_snd_soc_register_card() can make the code > shorter and cleaner. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl: imx-mc13783: use devm_snd_soc_register_card()

Re: [PATCH] fsl: imx-audmix : Use devm_kcalloc() instead of devm_kzalloc()

2020-09-25 Thread Mark Brown
On Mon, 21 Sep 2020 01:59:18 +, Xu Wang wrote: > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc". Applied to

Re: [PATCH] fsl: imx-audmix : Replace seq_printf with seq_puts

2020-09-25 Thread Mark Brown
On Wed, 16 Sep 2020 06:14:20 +, Xu Wang wrote: > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc". Applied to

Re: [PATCH] spi: fsl-espi: Only process interrupts for expected events

2020-09-21 Thread Mark Brown
On Fri, 4 Sep 2020 12:28:12 +1200, Chris Packham wrote: > The SPIE register contains counts for the TX FIFO so any time the irq > handler was invoked we would attempt to process the RX/TX fifos. Use the > SPIM value to mask the events so that we only process interrupts that > were expected. > >

Re: [PATCH 1/2] ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver

2020-09-18 Thread Mark Brown
On Fri, Sep 18, 2020 at 03:02:39PM +, Viorel Suman (OSS) wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > > > + regmap_read(regmap, FSL_XCVR_EXT_ISR, ); > > >

Re: [PATCH] ASoC: fsl_audmix: make clock and output src write only

2020-09-17 Thread Mark Brown
On Mon, 14 Sep 2020 20:24:34 +0300, Viorel Suman (OSS) wrote: > "alsactl -f state.conf store/restore" sequence fails because setting > "mixing clock source" and "output source" requires active TDM clock > being started for configuration propagation. Make these two controls > write only so that

Re: [PATCH 1/2] ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver

2020-09-17 Thread Mark Brown
On Wed, Sep 16, 2020 at 12:17:55PM +0300, Viorel Suman (OSS) wrote: This looks mostly good, a few smallish things below but nothing major. > +static int fsl_xcvr_load_firmware(struct fsl_xcvr *xcvr) > +{ > + struct device *dev = >pdev->dev; > + const struct firmware *fw; > + int ret

Re: [PATCH] fsl: imx-audmix : Replace seq_printf with seq_puts

2020-09-17 Thread Mark Brown
On Wed, Sep 16, 2020 at 06:14:20AM +, Xu Wang wrote: > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc". This looks fine but the subject says it's about

Re: [PATCH V2] ASoC: fsl: imx-es8328: add missing put_device() call in imx_es8328_probe()

2020-09-08 Thread Mark Brown
On Tue, 25 Aug 2020 21:02:24 +0800, Yu Kuai wrote: > if of_find_device_by_node() succeed, imx_es8328_probe() doesn't have > a corresponding put_device(). Thus add a jump target to fix the exception > handling for this function implementation. Applied to

Re: [PATCH] ASoC: fsl_spdif: Fix unnecessary check in fsl_spdif_probe()

2020-08-26 Thread Mark Brown
On Wed, Aug 26, 2020 at 11:09:18PM +0800, Tang Bin wrote: > The function fsl_spdif_probe() is only called with an openfirmware > platform device. Therefore there is no need to check that the passed > in device is NULL. Why is this an issue - the check will make things more robust if someone

Re: [PATCH 1/2] ASoC: fsl: imx-es8328: add missing kfree() call in imx_es8328_probe()

2020-08-25 Thread Mark Brown
On Tue, Aug 25, 2020 at 08:05:30PM +0800, Yu Kuai wrote: > If memory allocation for 'data' or 'comp' succeed, imx_es8328_probe() > doesn't have corresponding kfree() in exception handling. Thus add > kfree() for this function implementation. > @@ -151,7 +151,7 @@ static int

Re: [PATCH 00/10] sound: convert tasklets to use new tasklet_setup()

2020-08-19 Thread Mark Brown
On Wed, Aug 19, 2020 at 04:21:58PM +0530, Allen wrote: > > These patches which I wasn't CCed on and which need their subject lines > > fixing :( . With the subject lines fixed I guess so so > Extremely sorry. I thought I had it covered. How would you like it > worded? ASoC: In general you

Re: [PATCH 00/10] sound: convert tasklets to use new tasklet_setup()

2020-08-18 Thread Mark Brown
hose changes. These patches which I wasn't CCed on and which need their subject lines fixing :( . With the subject lines fixed I guess so so Acked-by: Mark Brown but judging from some of the other threads about similar patches that I was randomly CCed on I'm not sure people like from_tasklet(

Re: [PATCH 1/2] spi: mpc512x-psc: Use the framework .set_cs()

2020-07-30 Thread Mark Brown
On Wed, Jul 29, 2020 at 11:48:16PM +0200, Linus Walleij wrote: > The mpc512x-psc is rolling its own chip select control code, > but the SPI master framework can handle this. It was also > evaluating the CS status for each transfer but the CS change > should be per-message not per-transfer. No, CS

Re: [PATCH] ASoC: fsl: Replace HTTP links with HTTPS ones

2020-07-23 Thread Mark Brown
On Sat, 18 Jul 2020 13:12:09 +0200, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't

Re: [PATCH] spi: ppc4xx: Convert to use GPIO descriptors

2020-07-22 Thread Mark Brown
On Tue, 14 Jul 2020 09:22:26 +0200, Linus Walleij wrote: > This converts the PPC4xx SPI driver to use GPIO descriptors. > > The driver is already just picking some GPIOs from the device > tree so the conversion is pretty straight forward. However > this driver is looking form a pure "gpios"

Re: [PATCH 1/1] ASoC: fsl: fsl-asoc-card: Trivial: Fix misspelling of 'exists'

2020-07-16 Thread Mark Brown
On Wed, 15 Jul 2020 10:44:47 +0100, Lee Jones wrote: > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl: fsl-asoc-card: Trivial: Fix misspelling of 'exists' commit: 1b58214113481616b74ee4d196e5b1cb683758ee All being well

Re: [PATCH v2 1/1] ASoC: fsl: fsl-asoc-card: Trivial: Fix misspelling of 'exists'

2020-07-16 Thread Mark Brown
On Wed, 15 Jul 2020 16:00:09 +0100, Lee Jones wrote: > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl: fsl-asoc-card: Trivial: Fix misspelling of 'exists' commit: 1b58214113481616b74ee4d196e5b1cb683758ee All being well

Re: [PATCH 1/1] ASoC: fsl: fsl-asoc-card: Trivial: Fix misspelling of 'exists'

2020-07-15 Thread Mark Brown
On Wed, Jul 15, 2020 at 10:44:47AM +0100, Lee Jones wrote: > /* > - * This dapm route map exits for DPCM link only. > + * This dapm route map exists for DPCM link only. > * The other routes shall go through Device Tree. This doesn't apply against current code, please check and resend.

Re: [PATCH 0/2] ASoC: fsl_spdif: Clear the validity bit for TX

2020-07-10 Thread Mark Brown
On Tue, 7 Jul 2020 16:54:24 +0800, Shengjiu Wang wrote: > Clear the validity bit for TX > Add kctl for configuring TX validity bit > > Shengjiu Wang (2): > ASoC: fsl_spdif: Clear the validity bit for TX > ASoC: fsl_spdif: Add kctl for configuring TX validity bit > > [...] Applied to

Re: [PATCH v2] MAINTAINERS: Add Shengjiu to reviewer list of sound/soc/fsl

2020-07-07 Thread Mark Brown
On Mon, 6 Jul 2020 21:58:29 -0700, Nicolin Chen wrote: > Add Shengjiu who's actively working on the latest fsl/nxp audio drivers. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] MAINTAINERS: Add Shengjiu to reviewer list of sound/soc/fsl

Re: [PATCH] MAINTAINERS: Add Shengjiu to reviewer list of sound/soc/fsl

2020-07-07 Thread Mark Brown
On Thu, 2 Jul 2020 12:31:02 -0700, Nicolin Chen wrote: > Add Shengjiu who's actively working on the latest fsl/nxp audio drivers. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] MAINTAINERS: Add Shengjiu to reviewer list of sound/soc/fsl

Re: [PATCH] ASoC: fsl: mpc8610_hpcd: Add missing of_node_put()

2020-07-07 Thread Mark Brown
On Tue, 7 Jul 2020 19:47:47 +0800, Yi Wang wrote: > After finishing using device node got from of_find_compatible_node(), > of_node_put() needs to be called. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl: mpc8610_hpcd: Add

Re: [PATCH v2] ASoC: fsl_asrc: Add an option to select internal ratio mode

2020-07-03 Thread Mark Brown
On Fri, Jul 03, 2020 at 03:46:58PM -0700, Nicolin Chen wrote: > > [1/1] ASoC: fsl_asrc: Add an option to select internal ratio mode > > commit: d0250cf4f2abfbea64ed247230f08f5ae23979f0 > You already applied v3 of this change: >

Re: [PATCH v2] ASoC: fsl_asrc: Add an option to select internal ratio mode

2020-07-03 Thread Mark Brown
On Tue, 30 Jun 2020 16:47:56 +0800, Shengjiu Wang wrote: > The ASRC not only supports ideal ratio mode, but also supports > internal ratio mode. > > For internal rato mode, the rate of clock source should be divided > with no remainder by sample rate, otherwise there is sound > distortion. > >

Re: [PATCH v2] ASoC: fsl_asrc: Add an option to select internal ratio mode

2020-07-03 Thread Mark Brown
On Tue, Jun 30, 2020 at 04:47:56PM +0800, Shengjiu Wang wrote: > The ASRC not only supports ideal ratio mode, but also supports > internal ratio mode. This doesn't apply against current code, please check and resend. signature.asc Description: PGP signature

Re: [PATCH 1/2] dt-bindings: sound: fsl-asoc-card: add new compatible for I2S slave

2020-07-02 Thread Mark Brown
On Thu, Jul 02, 2020 at 05:28:03PM +0200, Arnaud Ferraris wrote: > Le 02/07/2020 à 16:31, Mark Brown a écrit : > > Why require that the CODEC be clock master here - why not make this > > configurable, reusing the properties from the generic and audio graph > > cards? > Th

Re: [PATCH 1/2] dt-bindings: sound: fsl-asoc-card: add new compatible for I2S slave

2020-07-02 Thread Mark Brown
On Thu, Jul 02, 2020 at 04:11:14PM +0200, Arnaud Ferraris wrote: > fsl-asoc-card currently doesn't support generic codecs with the SoC > acting as I2S slave. > > This commit adds a new `fsl,imx-audio-i2s-slave` for this use-case, as > well as the following mandatory properties: Why require that

Re: [PATCH] ASoC: fsl_sai: Refine regcache usage with pm runtime

2020-07-01 Thread Mark Brown
On Mon, 29 Jun 2020 14:42:33 +0800, Shengjiu Wang wrote: > When there is dedicated power domain bound with device, after probing > the power will be disabled, then registers are not accessible in > fsl_sai_dai_probe(), so regcache only need to be enabled in end of > probe() and regcache_mark_dirty

Re: [PATCH v3] ASoC: fsl_asrc: Add an option to select internal ratio mode

2020-07-01 Thread Mark Brown
On Tue, 30 Jun 2020 21:56:07 +0800, Shengjiu Wang wrote: > The ASRC not only supports ideal ratio mode, but also supports > internal ratio mode. > > For internal rato mode, the rate of clock source should be divided > with no remainder by sample rate, otherwise there is sound > distortion. > >

Re: [PATCH 1/2] ASoC: fsl-asoc-card: Add WM8524 support

2020-06-24 Thread Mark Brown
On Tue, 23 Jun 2020 14:52:46 +0800, Shengjiu Wang wrote: > WM8524 only supports playback mode, and only works at > slave mode. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] ASoC: fsl-asoc-card: Add WM8524 support commit:

Re: [PATCH] ASoC: fsl_easrc: Fix uninitialized scalar variable in fsl_easrc_set_ctx_format

2020-06-23 Thread Mark Brown
On Mon, 22 Jun 2020 17:03:31 +0800, Shengjiu Wang wrote: > The "ret" in fsl_easrc_set_ctx_format is not initialized, then > the unknown value maybe returned by this function. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_easrc:

Re: [PATCH v2 0/2] Fix unchecked return value for clk_prepare_enable

2020-06-23 Thread Mark Brown
On Tue, 23 Jun 2020 14:01:10 +0800, Shengjiu Wang wrote: > First patch is to remove the check of clock pointer before calling > clk API. > > Second patch is to fix the issue that the return value of > clk_prepare_enable is not checked. > > changes in v2: > - split the patch to separate patches >

Re: [PATCH v2] ASoC: fsl_spdif: Add pm runtime function

2020-06-19 Thread Mark Brown
On Fri, 19 Jun 2020 15:54:33 +0800, Shengjiu Wang wrote: > Add pm runtime support and move clock handling there. > Close the clocks at suspend to reduce the power consumption. > > fsl_spdif_suspend is replaced by pm_runtime_force_suspend. > fsl_spdif_resume is replaced by pm_runtime_force_resume.

Re: [PATCH v2 1/2] ASoC: bindings: fsl-asoc-card: Add compatible string for MQS

2020-06-17 Thread Mark Brown
On Wed, 17 Jun 2020 12:48:24 +0800, Shengjiu Wang wrote: > Add compatible string "fsl,imx-audio-mqs" for MQS, and move > "audio-routing" property to be optional for MQS doesn't need > such property. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks!

Re: [PATCH v3 1/2] ASoC: bindings: fsl_spdif: Add new compatible string for imx6sx

2020-06-17 Thread Mark Brown
On Wed, 17 Jun 2020 14:58:00 +0800, Shengjiu Wang wrote: > Add new compatible string "fsl,imx6sx-spdif" in the binding document. > And add compatible string "fsl,vf610-spdif" which was missed before. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

  1   2   3   4   5   6   7   8   >