Re: [PATCH v4 0/2] DAI driver for new XCVR IP

2020-10-26 Thread Mark Brown
On Tue, 13 Oct 2020 15:17:31 +0300, Viorel Suman (OSS) wrote: > DAI driver for new XCVR IP found in i.MX8MP. > > Viorel Suman (2): > ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver > ASoC: dt-bindings: fsl_xcvr: Add document for XCVR > > Changes since v1: > - improved 6- and 12-ch layout

Re: [PATCH] ASoC: fsl_spdif: Fix unnecessary check in fsl_spdif_probe()

2020-10-01 Thread Mark Brown
On Wed, 26 Aug 2020 23:09:18 +0800, Tang Bin wrote: > The function fsl_spdif_probe() is only called with an openfirmware > platform device. Therefore there is no need to check that the passed > in device is NULL. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

Re: [PATCH -next] ASoC: fsl: imx-mc13783: use devm_snd_soc_register_card()

2020-10-01 Thread Mark Brown
On Tue, 29 Sep 2020 19:29:30 +0800, Qinglang Miao wrote: > Using devm_snd_soc_register_card() can make the code > shorter and cleaner. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl: imx-mc13783: use devm_snd_soc_register_card()

Re: [PATCH] fsl: imx-audmix : Use devm_kcalloc() instead of devm_kzalloc()

2020-09-25 Thread Mark Brown
On Mon, 21 Sep 2020 01:59:18 +, Xu Wang wrote: > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc". Applied to

Re: [PATCH] fsl: imx-audmix : Replace seq_printf with seq_puts

2020-09-25 Thread Mark Brown
On Wed, 16 Sep 2020 06:14:20 +, Xu Wang wrote: > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc". Applied to

Re: [PATCH] spi: fsl-espi: Only process interrupts for expected events

2020-09-21 Thread Mark Brown
On Fri, 4 Sep 2020 12:28:12 +1200, Chris Packham wrote: > The SPIE register contains counts for the TX FIFO so any time the irq > handler was invoked we would attempt to process the RX/TX fifos. Use the > SPIM value to mask the events so that we only process interrupts that > were expected. > >

Re: [PATCH 1/2] ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver

2020-09-18 Thread Mark Brown
On Fri, Sep 18, 2020 at 03:02:39PM +, Viorel Suman (OSS) wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > > > + regmap_read(regmap, FSL_XCVR_EXT_ISR, ); > > >

Re: [PATCH] ASoC: fsl_audmix: make clock and output src write only

2020-09-17 Thread Mark Brown
On Mon, 14 Sep 2020 20:24:34 +0300, Viorel Suman (OSS) wrote: > "alsactl -f state.conf store/restore" sequence fails because setting > "mixing clock source" and "output source" requires active TDM clock > being started for configuration propagation. Make these two controls > write only so that

Re: [PATCH 1/2] ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver

2020-09-17 Thread Mark Brown
On Wed, Sep 16, 2020 at 12:17:55PM +0300, Viorel Suman (OSS) wrote: This looks mostly good, a few smallish things below but nothing major. > +static int fsl_xcvr_load_firmware(struct fsl_xcvr *xcvr) > +{ > + struct device *dev = >pdev->dev; > + const struct firmware *fw; > + int ret

Re: [PATCH] fsl: imx-audmix : Replace seq_printf with seq_puts

2020-09-17 Thread Mark Brown
On Wed, Sep 16, 2020 at 06:14:20AM +, Xu Wang wrote: > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc". This looks fine but the subject says it's about

Re: [PATCH V2] ASoC: fsl: imx-es8328: add missing put_device() call in imx_es8328_probe()

2020-09-08 Thread Mark Brown
On Tue, 25 Aug 2020 21:02:24 +0800, Yu Kuai wrote: > if of_find_device_by_node() succeed, imx_es8328_probe() doesn't have > a corresponding put_device(). Thus add a jump target to fix the exception > handling for this function implementation. Applied to

Re: [PATCH] ASoC: fsl_spdif: Fix unnecessary check in fsl_spdif_probe()

2020-08-26 Thread Mark Brown
On Wed, Aug 26, 2020 at 11:09:18PM +0800, Tang Bin wrote: > The function fsl_spdif_probe() is only called with an openfirmware > platform device. Therefore there is no need to check that the passed > in device is NULL. Why is this an issue - the check will make things more robust if someone

Re: [PATCH 1/2] ASoC: fsl: imx-es8328: add missing kfree() call in imx_es8328_probe()

2020-08-25 Thread Mark Brown
On Tue, Aug 25, 2020 at 08:05:30PM +0800, Yu Kuai wrote: > If memory allocation for 'data' or 'comp' succeed, imx_es8328_probe() > doesn't have corresponding kfree() in exception handling. Thus add > kfree() for this function implementation. > @@ -151,7 +151,7 @@ static int

Re: [PATCH 00/10] sound: convert tasklets to use new tasklet_setup()

2020-08-19 Thread Mark Brown
On Wed, Aug 19, 2020 at 04:21:58PM +0530, Allen wrote: > > These patches which I wasn't CCed on and which need their subject lines > > fixing :( . With the subject lines fixed I guess so so > Extremely sorry. I thought I had it covered. How would you like it > worded? ASoC: In general you

Re: [PATCH 00/10] sound: convert tasklets to use new tasklet_setup()

2020-08-18 Thread Mark Brown
hose changes. These patches which I wasn't CCed on and which need their subject lines fixing :( . With the subject lines fixed I guess so so Acked-by: Mark Brown but judging from some of the other threads about similar patches that I was randomly CCed on I'm not sure people like from_tasklet(

Re: [PATCH 1/2] spi: mpc512x-psc: Use the framework .set_cs()

2020-07-30 Thread Mark Brown
On Wed, Jul 29, 2020 at 11:48:16PM +0200, Linus Walleij wrote: > The mpc512x-psc is rolling its own chip select control code, > but the SPI master framework can handle this. It was also > evaluating the CS status for each transfer but the CS change > should be per-message not per-transfer. No, CS

Re: [PATCH] ASoC: fsl: Replace HTTP links with HTTPS ones

2020-07-23 Thread Mark Brown
On Sat, 18 Jul 2020 13:12:09 +0200, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't

Re: [PATCH] spi: ppc4xx: Convert to use GPIO descriptors

2020-07-22 Thread Mark Brown
On Tue, 14 Jul 2020 09:22:26 +0200, Linus Walleij wrote: > This converts the PPC4xx SPI driver to use GPIO descriptors. > > The driver is already just picking some GPIOs from the device > tree so the conversion is pretty straight forward. However > this driver is looking form a pure "gpios"

Re: [PATCH 1/1] ASoC: fsl: fsl-asoc-card: Trivial: Fix misspelling of 'exists'

2020-07-16 Thread Mark Brown
On Wed, 15 Jul 2020 10:44:47 +0100, Lee Jones wrote: > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl: fsl-asoc-card: Trivial: Fix misspelling of 'exists' commit: 1b58214113481616b74ee4d196e5b1cb683758ee All being well

Re: [PATCH v2 1/1] ASoC: fsl: fsl-asoc-card: Trivial: Fix misspelling of 'exists'

2020-07-16 Thread Mark Brown
On Wed, 15 Jul 2020 16:00:09 +0100, Lee Jones wrote: > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl: fsl-asoc-card: Trivial: Fix misspelling of 'exists' commit: 1b58214113481616b74ee4d196e5b1cb683758ee All being well

Re: [PATCH 1/1] ASoC: fsl: fsl-asoc-card: Trivial: Fix misspelling of 'exists'

2020-07-15 Thread Mark Brown
On Wed, Jul 15, 2020 at 10:44:47AM +0100, Lee Jones wrote: > /* > - * This dapm route map exits for DPCM link only. > + * This dapm route map exists for DPCM link only. > * The other routes shall go through Device Tree. This doesn't apply against current code, please check and resend.

Re: [PATCH 0/2] ASoC: fsl_spdif: Clear the validity bit for TX

2020-07-10 Thread Mark Brown
On Tue, 7 Jul 2020 16:54:24 +0800, Shengjiu Wang wrote: > Clear the validity bit for TX > Add kctl for configuring TX validity bit > > Shengjiu Wang (2): > ASoC: fsl_spdif: Clear the validity bit for TX > ASoC: fsl_spdif: Add kctl for configuring TX validity bit > > [...] Applied to

Re: [PATCH v2] MAINTAINERS: Add Shengjiu to reviewer list of sound/soc/fsl

2020-07-07 Thread Mark Brown
On Mon, 6 Jul 2020 21:58:29 -0700, Nicolin Chen wrote: > Add Shengjiu who's actively working on the latest fsl/nxp audio drivers. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] MAINTAINERS: Add Shengjiu to reviewer list of sound/soc/fsl

Re: [PATCH] MAINTAINERS: Add Shengjiu to reviewer list of sound/soc/fsl

2020-07-07 Thread Mark Brown
On Thu, 2 Jul 2020 12:31:02 -0700, Nicolin Chen wrote: > Add Shengjiu who's actively working on the latest fsl/nxp audio drivers. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] MAINTAINERS: Add Shengjiu to reviewer list of sound/soc/fsl

Re: [PATCH] ASoC: fsl: mpc8610_hpcd: Add missing of_node_put()

2020-07-07 Thread Mark Brown
On Tue, 7 Jul 2020 19:47:47 +0800, Yi Wang wrote: > After finishing using device node got from of_find_compatible_node(), > of_node_put() needs to be called. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl: mpc8610_hpcd: Add

Re: [PATCH v2] ASoC: fsl_asrc: Add an option to select internal ratio mode

2020-07-03 Thread Mark Brown
On Fri, Jul 03, 2020 at 03:46:58PM -0700, Nicolin Chen wrote: > > [1/1] ASoC: fsl_asrc: Add an option to select internal ratio mode > > commit: d0250cf4f2abfbea64ed247230f08f5ae23979f0 > You already applied v3 of this change: >

Re: [PATCH v2] ASoC: fsl_asrc: Add an option to select internal ratio mode

2020-07-03 Thread Mark Brown
On Tue, 30 Jun 2020 16:47:56 +0800, Shengjiu Wang wrote: > The ASRC not only supports ideal ratio mode, but also supports > internal ratio mode. > > For internal rato mode, the rate of clock source should be divided > with no remainder by sample rate, otherwise there is sound > distortion. > >

Re: [PATCH v2] ASoC: fsl_asrc: Add an option to select internal ratio mode

2020-07-03 Thread Mark Brown
On Tue, Jun 30, 2020 at 04:47:56PM +0800, Shengjiu Wang wrote: > The ASRC not only supports ideal ratio mode, but also supports > internal ratio mode. This doesn't apply against current code, please check and resend. signature.asc Description: PGP signature

Re: [PATCH 1/2] dt-bindings: sound: fsl-asoc-card: add new compatible for I2S slave

2020-07-02 Thread Mark Brown
On Thu, Jul 02, 2020 at 05:28:03PM +0200, Arnaud Ferraris wrote: > Le 02/07/2020 à 16:31, Mark Brown a écrit : > > Why require that the CODEC be clock master here - why not make this > > configurable, reusing the properties from the generic and audio graph > > cards? > Th

Re: [PATCH 1/2] dt-bindings: sound: fsl-asoc-card: add new compatible for I2S slave

2020-07-02 Thread Mark Brown
On Thu, Jul 02, 2020 at 04:11:14PM +0200, Arnaud Ferraris wrote: > fsl-asoc-card currently doesn't support generic codecs with the SoC > acting as I2S slave. > > This commit adds a new `fsl,imx-audio-i2s-slave` for this use-case, as > well as the following mandatory properties: Why require that

Re: [PATCH] ASoC: fsl_sai: Refine regcache usage with pm runtime

2020-07-01 Thread Mark Brown
On Mon, 29 Jun 2020 14:42:33 +0800, Shengjiu Wang wrote: > When there is dedicated power domain bound with device, after probing > the power will be disabled, then registers are not accessible in > fsl_sai_dai_probe(), so regcache only need to be enabled in end of > probe() and regcache_mark_dirty

Re: [PATCH v3] ASoC: fsl_asrc: Add an option to select internal ratio mode

2020-07-01 Thread Mark Brown
On Tue, 30 Jun 2020 21:56:07 +0800, Shengjiu Wang wrote: > The ASRC not only supports ideal ratio mode, but also supports > internal ratio mode. > > For internal rato mode, the rate of clock source should be divided > with no remainder by sample rate, otherwise there is sound > distortion. > >

Re: [PATCH 1/2] ASoC: fsl-asoc-card: Add WM8524 support

2020-06-24 Thread Mark Brown
On Tue, 23 Jun 2020 14:52:46 +0800, Shengjiu Wang wrote: > WM8524 only supports playback mode, and only works at > slave mode. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] ASoC: fsl-asoc-card: Add WM8524 support commit:

Re: [PATCH] ASoC: fsl_easrc: Fix uninitialized scalar variable in fsl_easrc_set_ctx_format

2020-06-23 Thread Mark Brown
On Mon, 22 Jun 2020 17:03:31 +0800, Shengjiu Wang wrote: > The "ret" in fsl_easrc_set_ctx_format is not initialized, then > the unknown value maybe returned by this function. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_easrc:

Re: [PATCH v2 0/2] Fix unchecked return value for clk_prepare_enable

2020-06-23 Thread Mark Brown
On Tue, 23 Jun 2020 14:01:10 +0800, Shengjiu Wang wrote: > First patch is to remove the check of clock pointer before calling > clk API. > > Second patch is to fix the issue that the return value of > clk_prepare_enable is not checked. > > changes in v2: > - split the patch to separate patches >

Re: [PATCH v2] ASoC: fsl_spdif: Add pm runtime function

2020-06-19 Thread Mark Brown
On Fri, 19 Jun 2020 15:54:33 +0800, Shengjiu Wang wrote: > Add pm runtime support and move clock handling there. > Close the clocks at suspend to reduce the power consumption. > > fsl_spdif_suspend is replaced by pm_runtime_force_suspend. > fsl_spdif_resume is replaced by pm_runtime_force_resume.

Re: [PATCH v2 1/2] ASoC: bindings: fsl-asoc-card: Add compatible string for MQS

2020-06-17 Thread Mark Brown
On Wed, 17 Jun 2020 12:48:24 +0800, Shengjiu Wang wrote: > Add compatible string "fsl,imx-audio-mqs" for MQS, and move > "audio-routing" property to be optional for MQS doesn't need > such property. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks!

Re: [PATCH v3 1/2] ASoC: bindings: fsl_spdif: Add new compatible string for imx6sx

2020-06-17 Thread Mark Brown
On Wed, 17 Jun 2020 14:58:00 +0800, Shengjiu Wang wrote: > Add new compatible string "fsl,imx6sx-spdif" in the binding document. > And add compatible string "fsl,vf610-spdif" which was missed before. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Re: [PATCH v3] ASoC: fsl_ssi: Fix bclk calculation for mono channel

2020-06-16 Thread Mark Brown
On Tue, 16 Jun 2020 10:53:48 +0800, Shengjiu Wang wrote: > For mono channel, SSI will switch to Normal mode. > > In Normal mode and Network mode, the Word Length Control bits > control the word length divider in clock generator, which is > different with I2S Master mode (the word length is fixed

Re: [PATCH 00/17] spelling.txt: /decriptors/descriptors/

2020-06-15 Thread Mark Brown
On Tue, 9 Jun 2020 13:45:53 +0100, Kieran Bingham wrote: > I wouldn't normally go through spelling fixes, but I caught sight of > this typo twice, and then foolishly grepped the tree for it, and saw how > pervasive it was. > > so here I am ... fixing a typo globally... but with an addition in >

Re: [PATCH 0/3] ASoC: fsl_easrc: Fix several warnings

2020-06-15 Thread Mark Brown
On Wed, 3 Jun 2020 11:39:38 +0800, Shengjiu Wang wrote: > Fix several warnings with "make W=1" > > Shengjiu Wang (3): > ASoC: fsl_easrc: Fix -Wmissing-prototypes warning > ASoC: fsl_easrc: Fix -Wunused-but-set-variable > ASoC: fsl_easrc: Fix "Function parameter not described" warnings > >

Re: [RFC PATCH v3 0/4] Reuse the dma channel if available in Back-End

2020-06-12 Thread Mark Brown
On Fri, 12 Jun 2020 15:37:47 +0800, Shengjiu Wang wrote: > Reuse the dma channel if available in Back-End > > Shengjiu Wang (4): > ASoC: soc-card: export snd_soc_lookup_component_nolocked > ASoC: dmaengine_pcm: export soc_component_to_pcm > ASoC: fsl_asrc_dma: Reuse the dma channel if

Re: [RFC PATCH] ASoC: fsl_asrc_dma: Fix warning "Cannot create DMA dma:tx symlink"

2020-06-09 Thread Mark Brown
On Mon, Jun 08, 2020 at 03:07:00PM +0800, Shengjiu Wang wrote: > The issue log is: > > [ 48.021506] CPU: 0 PID: 664 Comm: aplay Not tainted > 5.7.0-rc1-13120-g12b434cbbea0 #343 > [ 48.031063] Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree) > [ 48.037638] [] (unwind_backtrace)

Re: [PATCH] ASoC: fsl-asoc-card: Defer probe when fail to find codec device

2020-06-04 Thread Mark Brown
On Thu, 4 Jun 2020 14:25:30 +0800, Shengjiu Wang wrote: > Defer probe when fail to find codec device, because the codec > device maybe probed later than machine driver. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl-asoc-card:

Re: [PATCH] ASoC: fsl_asrc_dma: Fix dma_chan leak when config DMA channel failed

2020-05-29 Thread Mark Brown
On Mon, 25 May 2020 22:12:46 +0800, Xiyu Yang wrote: > fsl_asrc_dma_hw_params() invokes dma_request_channel() or > fsl_asrc_get_dma_channel(), which returns a reference of the specified > dma_chan object to "pair->dma_chan[dir]" with increased refcnt. > > The reference counting issue happens in

Re: [PATCH] ASoC: fsl: imx-audmix: Fix unused assignment to variable 'ret'

2020-05-25 Thread Mark Brown
On Wed, 13 May 2020 19:14:08 +0800, Tang Bin wrote: > Omit unused initialized value, because 'ret' will be assigined > by the function snd_soc_component_read(). Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl: imx-audmix: Fix

Re: [PATCH] ASoC: fsl_asrc: Fix -Wmissing-prototypes warning

2020-05-25 Thread Mark Brown
On Mon, 25 May 2020 17:03:32 +0800, Shengjiu Wang wrote: > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > > sound/soc/fsl/fsl_asrc.c:557:18: warning: no previous prototype for function > 'fsl_asrc_get_dma_channel' [-Wmissing-prototypes] > struct dma_chan

Re: [PATCH] ASoC: fsl_asrc: Merge suspend/resume function to runtime_suspend/resume

2020-05-25 Thread Mark Brown
On Fri, 22 May 2020 17:57:24 +0800, Shengjiu Wang wrote: > With dedicated power domain for asrc, power can be disabled after > probe and pm runtime suspend, then the value of all registers need to > be restored in pm runtime resume. So we can merge suspend/resume function > to

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-22 Thread Mark Brown
On Thu, May 21, 2020 at 07:30:04PM +0800, Shengjiu Wang wrote: > On Wed, May 20, 2020 at 8:38 PM Mark Brown wrote: > > Other drivers having problems means those drivers should be fixed, not > > that we should copy the problems. In the case of the PXA driver that's > >

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-20 Thread Mark Brown
On Wed, May 20, 2020 at 07:22:19PM +0800, Shengjiu Wang wrote: > I see some driver also request dma channel in open() or hw_params(). > how can they avoid the defer probe issue? > for example: > sound/arm/pxa2xx-pcm-lib.c > sound/soc/sprd/sprd-pcm-dma.c Other drivers having problems means those

Re: [PATCH] ASoC: fsl_asrc: Set ASR76K and ASR56K based on processing clock

2020-05-19 Thread Mark Brown
On Tue, 12 May 2020 18:22:59 +0800, Shengjiu Wang wrote: > The processing clock is different for platforms, so it is better > to set ASR76K and ASR56K based on processing clock, rather than > hard coding the value for them. Applied to

Re: [PATCH] ASoC: fsl_micfil: Fix unused assignment in fsl_set_clock_params()

2020-05-18 Thread Mark Brown
On Mon, 18 May 2020 19:00:40 +0800, Tang Bin wrote: > Delete unused initialized value of 'ret', because it will > be assigned by the function fsl_micfil_set_mclk_rate(). Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.8 Thanks! [1/1] ASoC: fsl_micfil: Fix

Re: [PATCH] ASoC: fsl_micfil: Fix indentation to put on one line affected code

2020-05-18 Thread Mark Brown
On Mon, 18 May 2020 18:59:51 +0800, Tang Bin wrote: > In the function fsl_micfil_startup(), the two lines of dev_err() > can be shortened to one line. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.8 Thanks! [1/1] ASoC: fsl_micfil: Fix indentation to put

Re: [PATCH] ASoC: fsl_micfil: Fix format and unused assignment

2020-05-18 Thread Mark Brown
On Mon, May 18, 2020 at 03:44:05PM +0800, Tang Bin wrote: > In the function fsl_micfil_startup(), the two lines of dev_err() > can be shortened to one line. And delete unused initialized value > of 'ret', because it will be assigned by the function > fsl_micfil_set_mclk_rate(). This is two

Re: [PATCH v2 0/2] ASoC: fsl_esai: Add support for imx8qm

2020-05-15 Thread Mark Brown
On Fri, 15 May 2020 18:10:49 +0800, Shengjiu Wang wrote: > Add support for imx8qm. > > Shengjiu Wang (2): > ASoC: fsl_esai: introduce SoC specific data > ASoC: fsl_esai: Add new compatible string for imx8qm > > Changes in v2 > - drop the 0002 patch in v1, the dma relate limitation should >

Re: [PATCH 2/3] ASoC: fsl_esai: Add support for imx8qm

2020-05-12 Thread Mark Brown
On Tue, May 12, 2020 at 10:48:41AM +0800, Shengjiu Wang wrote: > On Wed, May 6, 2020 at 10:33 AM Shengjiu Wang wrote: > > On Fri, May 1, 2020 at 6:23 PM Mark Brown wrote: > > > > EDMA requires the period size to be multiple of maxburst. Otherwise > > > > the re

Re: [PATCH -next] soc: fsl_asrc: Make some functions static

2020-05-07 Thread Mark Brown
On Thu, 7 May 2020 10:29:59 +0800, ChenTao wrote: > Fix the following warning: > > sound/soc/fsl/fsl_asrc.c:157:5: warning: > symbol 'fsl_asrc_request_pair' was not declared. Should it be static? > sound/soc/fsl/fsl_asrc.c:200:6: warning: > symbol 'fsl_asrc_release_pair' was not declared. Should

Re: [PATCH 2/3] ASoC: fsl_esai: Add support for imx8qm

2020-05-01 Thread Mark Brown
On Fri, May 01, 2020 at 04:12:05PM +0800, Shengjiu Wang wrote: > The difference for esai on imx8qm is that DMA device is EDMA. > > EDMA requires the period size to be multiple of maxburst. Otherwise > the remaining bytes are not transferred and thus noise is produced. If this constraint comes

Re: [PATCH] ASoC: fsl_easrc: Check NULL pinter before dereference

2020-04-29 Thread Mark Brown
On Fri, 24 Apr 2020 20:30:04 +0800, Shengjiu Wang wrote: > The patch 955ac624058f: "ASoC: fsl_easrc: Add EASRC ASoC CPU DAI > drivers" from Apr 16, 2020, leads to the following Smatch complaint: > > sound/soc/fsl/fsl_easrc.c:1529 fsl_easrc_hw_free() > warn: variable dereferenced before check

Re: [PATCH] ASoC: fsl_easrc: Check NULL pinter before dereference

2020-04-29 Thread Mark Brown
On Fri, Apr 24, 2020 at 08:30:04PM +0800, Shengjiu Wang wrote: > The patch 955ac624058f: "ASoC: fsl_easrc: Add EASRC ASoC CPU DAI > drivers" from Apr 16, 2020, leads to the following Smatch complaint: This doesn't apply against current code, please check and resend. signature.asc Description:

Re: [PATCH v2] ASoC: fsl_easrc: Check for null pointer before dereferencing "ctx" in fsl_easrc_hw_free()

2020-04-27 Thread Mark Brown
On Sat, 25 Apr 2020 15:19:29 +0800, Shengjiu Wang wrote: > The patch 955ac624058f: "ASoC: fsl_easrc: Add EASRC ASoC CPU DAI > drivers" from Apr 16, 2020, leads to the following Smatch complaint: > > sound/soc/fsl/fsl_easrc.c:1529 fsl_easrc_hw_free() > warn: variable dereferenced before check

Re: [PATCH v2] ASoC: fsl_esai: Disable exception interrupt before scheduling tasklet

2020-04-27 Thread Mark Brown
On Mon, 27 Apr 2020 14:23:21 +0800, Shengjiu Wang wrote: > Disable exception interrupt before scheduling tasklet, otherwise if > the tasklet isn't handled immediately, there will be endless xrun > interrupt. > > Fixes: 7ccafa2b3879 ("ASoC: fsl_esai: recover the channel swap after xrun") >

Re: [PATCH][next] ASoC: fsl_easrc: fix spelling mistake "prefitler" -> "prefilter"

2020-04-23 Thread Mark Brown
On Thu, 23 Apr 2020 09:39:22 +0100, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a deb_dbg message, fix it. > > Signed-off-by: Colin Ian King > --- > sound/soc/fsl/fsl_easrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > [...] Applied to

Re: [PATCH v9 0/7] ASoC: Add new module driver for new ASRC

2020-04-21 Thread Mark Brown
On Thu, 16 Apr 2020 20:25:30 +0800, Shengjiu Wang wrote: > Add new module driver for new ASRC in i.MX8MN, several commits > are added for new property fsl,asrc-format > > Shengjiu Wang (7): > ASoC: fsl_asrc: rename asrc_priv to asrc > ASoC: dt-bindings: fsl_asrc: Add new property

Re: [PATCH v8 0/7] ASoC: Add new module driver for new ASRC

2020-04-21 Thread Mark Brown
On Tue, 14 Apr 2020 14:56:00 +0800, Shengjiu Wang wrote: > Add new module driver for new ASRC in i.MX8MN, several commits > are added for new property fsl,asrc-format > > Shengjiu Wang (7): > ASoC: fsl_asrc: rename asrc_priv to asrc > ASoC: dt-bindings: fsl_asrc: Add new property

Re: [PATCH] ASoC: fsl_esai: Remove expensive print in irq handler

2020-04-21 Thread Mark Brown
On Tue, Apr 21, 2020 at 04:41:23PM +0800, Shengjiu Wang wrote: > Use dev_dbg instead of dev_err in irq handler, the dev_err > is expensive, we don't need the message to be printed everytime, > which is almost a debug option. > if (esr & ESAI_ESR_RFF_MASK) > - dev_warn(>dev,

Applied "ASoC: fsl_micfil: Omit superfluous error message in fsl_micfil_probe()" to the asoc tree

2020-04-15 Thread Mark Brown
ion fsl_micfil_probe(), when get irq failed, the function platform_get_irq() logs an error message, so remove redundant message here. Signed-off-by: Tang Bin Signed-off-by: Shengju Zhang Link: https://lore.kernel.org/r/20200415044513.17492-1-tang...@cmss.chinamobile.com Signed-off-by: Mark Br

Re: [PATCH v5 4/7] ASoC: fsl_asrc: rename asrc_priv to asrc

2020-03-12 Thread Mark Brown
On Mon, Mar 09, 2020 at 02:30:17PM -0700, Nicolin Chen wrote: > On Mon, Mar 09, 2020 at 11:58:31AM +0800, Shengjiu Wang wrote: > > In order to move common structure to fsl_asrc_common.h > > we change the name of asrc_priv to asrc, the asrc_priv > > will be used by new struct fsl_asrc_priv. > This

Re: [PATCH v4 1/8] ASoC: dt-bindings: fsl_asrc: Change asrc-width to asrc-format

2020-03-03 Thread Mark Brown
On Tue, Mar 03, 2020 at 11:59:30AM +0800, Shengjiu Wang wrote: > On Tue, Mar 3, 2020 at 9:43 AM Rob Herring wrote: > > > - - fsl,asrc-width : Defines a mutual sample width used by DPCM Back > > > Ends. > > > + - fsl,asrc-format : Defines a mutual sample format used by DPCM Back > > > +

Applied "ASoC: fsl_sai: Fix exiting path on probing failure" to the asoc tree

2020-02-06 Thread Mark Brown
xes: 812ad463e089 ("ASoC: fsl_sai: Add support for runtime pm") Signed-off-by: Oleksandr Suvorov Link: https://lore.kernel.org/r/20200205160436.3813642-1-oleksandr.suvo...@toradex.com Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_sai.c | 22 +- 1 file changed,

Re: [PATCH V12] mm/debug: Add tests validating architecture page table helpers

2020-01-28 Thread Mark Brown
On Tue, Jan 28, 2020 at 02:12:56AM -0500, Qian Cai wrote: > > On Jan 28, 2020, at 1:13 AM, Christophe Leroy > > wrote: > > ppc32 an indecent / legacy platform ? Are you kidying ? > > Powerquicc II PRO for instance is fully supported by the > > manufacturer and widely used in many small

Re: [PATCH v2 00/10] Impveovements for random.h/archrandom.h

2020-01-20 Thread Mark Brown
On Fri, Jan 10, 2020 at 12:05:59PM -0500, Theodore Y. Ts'o wrote: > On Fri, Jan 10, 2020 at 04:51:53PM +0100, Borislav Petkov wrote: > > On Fri, Jan 10, 2020 at 02:54:12PM +0000, Mark Brown wrote: > > > This is a resend of a series from Richard Henderson last posted back

Re: [PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe()

2020-01-14 Thread Mark Brown
On Tue, Jan 14, 2020 at 04:26:18PM +, Joakim Tjernlund wrote: > Don't you need to "undo" ioremap, irq etc. in case of later errors? Better, convert to devm_ signature.asc Description: PGP signature

Re: [PATCH v2 2/2] spi: fsl: simplify error path in of_fsl_spi_probe()

2020-01-14 Thread Mark Brown
On Tue, Dec 10, 2019 at 03:17:16PM +, Christophe Leroy wrote: > No need to 'goto err;' for just doing a return. > return directly from where the error happens. This doesn't apply against current code, please check and resend. signature.asc Description: PGP signature

Applied "spi: fsl: simplify error path in of_fsl_spi_probe()" to the spi tree

2020-01-14 Thread Mark Brown
urn. return directly from where the error happens. Signed-off-by: Christophe Leroy Link: https://lore.kernel.org/r/2a4a7e11b37cfa0558d68f0d35e90d6da858b059.1579017697.git.christophe.le...@c-s.fr Signed-off-by: Mark Brown --- drivers/spi/spi-fsl-spi.c | 27 --- 1 file chan

Applied "ASoC: dt-bindings: fsl_asrc: add compatible string for imx8qm & imx8qxp" to the asoc tree

2020-01-14 Thread Mark Brown
Signed-off-by: Shengjiu Wang Acked-by: Rob Herring Link: https://lore.kernel.org/r/b9352edb014c1ee8530c0fd8829c2b044b3da649.1575452454.git.shengjiu.w...@nxp.com Signed-off-by: Mark Brown --- Documentation/devicetree/bindings/sound/fsl,asrc.txt | 12 +++- 1 file changed, 11 insertions(

Applied "ASoC: fsl_asrc: Add support for imx8qm & imx8qxp" to the asoc tree

2020-01-14 Thread Mark Brown
channel. So we need to request dma channel with dma request of asrc module. Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen Link: https://lore.kernel.org/r/f33dfe3157b5ab200e09ccbf9ab73d31fac6664b.1575452454.git.shengjiu.w...@nxp.com Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_a

[PATCH v2 10/10] s390x: Mark archrandom.h functions __must_check

2020-01-10 Thread Mark Brown
From: Richard Henderson We must not use the pointer output without validating the success of the random read. Reviewed-by: Harald Freudenberger Reviewed-by: Ard Biesheuvel Signed-off-by: Richard Henderson Signed-off-by: Mark Brown --- arch/s390/include/asm/archrandom.h | 8 1 file

[PATCH v2 09/10] powerpc: Mark archrandom.h functions __must_check

2020-01-10 Thread Mark Brown
From: Richard Henderson We must not use the pointer output without validating the success of the random read. Acked-by: Michael Ellerman Reviewed-by: Ard Biesheuvel Signed-off-by: Richard Henderson Signed-off-by: Mark Brown --- arch/powerpc/include/asm/archrandom.h | 8 1 file

[PATCH v2 08/10] powerpc: Use bool in archrandom.h

2020-01-10 Thread Mark Brown
From: Richard Henderson The generic interface uses bool not int; match that. Reviewed-by: Ard Biesheuvel Signed-off-by: Richard Henderson Signed-off-by: Mark Brown --- arch/powerpc/include/asm/archrandom.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[PATCH v2 07/10] x86: Mark archrandom.h functions __must_check

2020-01-10 Thread Mark Brown
From: Richard Henderson We must not use the pointer output without validating the success of the random read. Reviewed-by: Ard Biesheuvel Signed-off-by: Richard Henderson Signed-off-by: Mark Brown --- arch/x86/include/asm/archrandom.h | 16 1 file changed, 8 insertions

[PATCH v2 06/10] linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check

2020-01-10 Thread Mark Brown
From: Richard Henderson We must not use the pointer output without validating the success of the random read. Reviewed-by: Ard Biesheuvel Signed-off-by: Richard Henderson Signed-off-by: Mark Brown --- include/linux/random.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH v2 05/10] linux/random.h: Use false with bool

2020-01-10 Thread Mark Brown
From: Richard Henderson Keep the generic fallback versions in sync with the other architecture specific implementations and use the proper name for false. Suggested-by: Ard Biesheuvel Signed-off-by: Richard Henderson Signed-off-by: Mark Brown --- include/linux/random.h | 8 1 file

[PATCH v2 04/10] linux/random.h: Remove arch_has_random, arch_has_random_seed

2020-01-10 Thread Mark Brown
Signed-off-by: Mark Brown --- include/linux/random.h | 8 1 file changed, 8 deletions(-) diff --git a/include/linux/random.h b/include/linux/random.h index f189c927fdea..7fd0360908d2 100644 --- a/include/linux/random.h +++ b/include/linux/random.h @@ -175,10 +175,6 @@ static inline bool

[PATCH v2 03/10] s390: Remove arch_has_random, arch_has_random_seed

2020-01-10 Thread Mark Brown
From: Richard Henderson These symbols are currently part of the generic archrandom.h interface, but are currently unused and can be removed. Signed-off-by: Richard Henderson Signed-off-by: Mark Brown --- arch/s390/include/asm/archrandom.h | 12 1 file changed, 12 deletions

[PATCH v2 01/10] x86: Remove arch_has_random, arch_has_random_seed

2020-01-10 Thread Mark Brown
From: Richard Henderson Use the expansion of these macros directly in arch_get_random_*. These symbols are currently part of the generic archrandom.h interface, but are currently unused and can be removed. Signed-off-by: Richard Henderson Signed-off-by: Mark Brown --- arch/x86/include/asm

[PATCH v2 02/10] powerpc: Remove arch_has_random, arch_has_random_seed

2020-01-10 Thread Mark Brown
From: Richard Henderson These symbols are currently part of the generic archrandom.h interface, but are currently unused and can be removed. Signed-off-by: Richard Henderson Signed-off-by: Mark Brown --- arch/powerpc/include/asm/archrandom.h | 10 -- 1 file changed, 10 deletions

[PATCH v2 00/10] Impveovements for random.h/archrandom.h

2020-01-10 Thread Mark Brown
This is a resend of a series from Richard Henderson last posted back in November: https://lore.kernel.org/linux-arm-kernel/20191106141308.30535-1-...@twiddle.net/ Back then Borislav said they looked good and asked if he should take them through the tip tree but things seem to have got lost

Applied "spi: fsl: use platform_get_irq() instead of of_irq_to_resource()" to the spi tree

2019-12-16 Thread Mark Brown
ike irq_of_parse_and_map() which has a dummy definition on SPARC, of_irq_to_resource() hasn't. But as platform_get_irq() can be used instead and is generic, use it. Reported-by: kbuild test robot Suggested-by: Mark Brown Fixes: 3194d2533eff ("spi: fsl: don't map irq during probe") Cc: sta...@vg

Re: [PATCH v2 1/2] spi: fsl: don't map irq during probe

2019-12-10 Thread Mark Brown
On Tue, Dec 10, 2019 at 03:17:15PM +, Christophe Leroy wrote: > With lastest kernel, the following warning is observed at startup: Please do not submit new versions of already applied patches, please submit incremental updates to the existing code. Modifying existing commits creates problems

Applied "spi: fsl: don't map irq during probe" to the spi tree

2019-12-09 Thread Mark Brown
.christophe.le...@c-s.fr Signed-off-by: Mark Brown --- drivers/spi/spi-fsl-spi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-fsl-spi.c b/drivers/spi/spi-fsl-spi.c index 4b70887cf443..d0ad9709f4a6 100644 --- a/drivers/spi/spi-fsl-spi.c +++ b/driver

Applied "ASoC: fsl_sai: add IRQF_SHARED" to the asoc tree

2019-12-09 Thread Mark Brown
ble to use these SAIs simultaneously. Signed-off-by: Michael Walle Reviewed-by: Fabio Estevam Acked-by: Nicolin Chen Acked-by: Daniel Baluta Link: https://lore.kernel.org/r/20191128223802.18228-1-mich...@walle.cc Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_sai.c | 3 ++- 1 file changed

Applied "ASoC: fsl: fsl_dma: fix build failure" to the asoc tree

2019-10-28 Thread Mark Brown
rg/r/20191025051353.2878-1-...@ellerman.id.au Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_dma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c index a092726510d4..2868c4f97cb2 100644 --- a/sound/soc/fsl/fsl_dma.c +++ b/sound/soc/fsl/fsl_dma.c

Applied "ASoC: fsl_asrc: refine the setting of internal clock divider" to the asoc tree

2019-10-28 Thread Mark Brown
ode, the clock rate should divide the sample rate with no remainder, and the quotient should be less than 1024. Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen Link: https://lore.kernel.org/r/23c634e4bf58afce5b3ae67f5f42e8d1cae2639a.1572252307.git.shengjiu.w...@nxp.com Signed-off-by: Mark Br

Applied "ASoC: fsl_esai: Add spin lock to protect reset, stop and start" to the asoc tree

2019-10-28 Thread Mark Brown
s. Fixes: 7ccafa2b3879 ("ASoC: fsl_esai: recover the channel swap after xrun") Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen Link: https://lore.kernel.org/r/52e92c4221a83e39a84a6cd92fc3d5479b44894c.1572252321.git.shengjiu.w...@nxp.com Signed-off-by: Mark Brown --- sound/soc/

Applied "ASoC: fsl_mqs: Move static keyword to the front of declarations" to the asoc tree

2019-10-14 Thread Mark Brown
out this: sound/soc/fsl/fsl_mqs.c:146:1: warning: static is not at beginning of declaration [-Wold-style-declaration] Signed-off-by: YueHaibing Acked-by: Nicolin Chen Link: https://lore.kernel.org/r/20191011143538.15300-1-yuehaib...@huawei.com Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_mqs.c | 2 +-

Applied "ASoC: fsl_mqs: Fix error handling in probe" to the asoc tree

2019-10-07 Thread Mark Brown
iver") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/20191004102208.GB823@mwanda Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_mqs.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c in

Applied "ASoC: fsl_mqs: remove set but not used variable 'bclk'" to the asoc tree

2019-10-07 Thread Mark Brown
560-1-yuehaib...@huawei.com Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_mqs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c index c1619a553514..7b9cab3a62e7 100644 --- a/sound/soc/fsl/fsl_mqs.c +++ b/sound/soc/fsl/fsl_mq

Applied "ASoC: fsl_asrc: Use in(out)put_format instead of in(out)put_word_width" to the asoc tree

2019-10-01 Thread Mark Brown
tps://lore.kernel.org/r/7937c1404ee327ce141cb03b3575b02ea01a740c.1569493933.git.shengjiu.w...@nxp.com Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_asrc.c | 56 +++- sound/soc/fsl/fsl_asrc.h | 4 +-- 2 files changed, 40 insertions(+), 20 deletions(-) diff --git a/so

Applied "ASoC: fsl_asrc: update supported sample format" to the asoc tree

2019-10-01 Thread Mark Brown
TX supported list Signed-off-by: Shengjiu Wang Acked-by: Nicolin Chen Link: https://lore.kernel.org/r/45a7c383f43cc1dd9d0934846447aee653278c03.1569493933.git.shengjiu.w...@nxp.com Signed-off-by: Mark Brown --- sound/soc/fsl/fsl_asrc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) d

  1   2   3   4   5   6   7   >