Re: [PATCH] vsprintf: Do not break early boot with probing addresses

2019-05-10 Thread Martin Schwidefsky
On Fri, 10 May 2019 12:40:58 -0400 Steven Rostedt wrote: > On Fri, 10 May 2019 18:32:58 +0200 > Martin Schwidefsky wrote: > > > On Fri, 10 May 2019 12:24:01 -0400 > > Steven Rostedt wrote: > > > > > On Fri, 10 May 2019 10:42:13 +0200 > > > P

Re: [PATCH] vsprintf: Do not break early boot with probing addresses

2019-05-10 Thread Martin Schwidefsky
On Fri, 10 May 2019 12:24:01 -0400 Steven Rostedt wrote: > On Fri, 10 May 2019 10:42:13 +0200 > Petr Mladek wrote: > > > static const char *check_pointer_msg(const void *ptr) > > { > > - char byte; > > - > > if (!ptr) > > return "(null)"; > > > > - if

Re: Linux 5.1-rc5

2019-05-02 Thread Martin Schwidefsky
On Thu, 2 May 2019 16:31:10 +0200 Greg KH wrote: > On Thu, May 02, 2019 at 04:17:58PM +0200, Martin Schwidefsky wrote: > > On Thu, 2 May 2019 14:21:28 +0200 > > Greg KH wrote: > > > > > On Mon, Apr 15, 2019 at 09:17:10AM -0700, Linus Torvalds wrote: > >

Re: Linux 5.1-rc5

2019-05-02 Thread Martin Schwidefsky
On Thu, 2 May 2019 14:21:28 +0200 Greg KH wrote: > On Mon, Apr 15, 2019 at 09:17:10AM -0700, Linus Torvalds wrote: > > On Sun, Apr 14, 2019 at 10:19 PM Christoph Hellwig > > wrote: > > > > > > Can we please have the page refcount overflow fixes out on the list > > > for review, even if it is

Re: Linux 5.1-rc5

2019-04-23 Thread Martin Schwidefsky
On Fri, 19 Apr 2019 10:27:17 -0700 Linus Torvalds wrote: > On Fri, Apr 19, 2019 at 6:33 AM Martin Schwidefsky > wrote: > > > > That problem got stuck in my head and I thought more about it. Why not > > emulate the static folding sequence in the s390 page table code?

Re: Linux 5.1-rc5

2019-04-19 Thread Martin Schwidefsky
On Thu, 18 Apr 2019 20:41:44 +0200 Martin Schwidefsky wrote: > On Thu, 18 Apr 2019 08:49:32 -0700 > Linus Torvalds wrote: > > > On Thu, Apr 18, 2019 at 1:02 AM Martin Schwidefsky > > wrote: > > > > > > The problematic lines in the generic gup code ar

Re: Linux 5.1-rc5

2019-04-18 Thread Martin Schwidefsky
On Thu, 18 Apr 2019 08:49:32 -0700 Linus Torvalds wrote: > On Thu, Apr 18, 2019 at 1:02 AM Martin Schwidefsky > wrote: > > > > The problematic lines in the generic gup code are these three: > > > > 1845: pmdp = pmd_offset(, addr); > > 1888: pudp =

Re: Linux 5.1-rc5

2019-04-18 Thread Martin Schwidefsky
On Wed, 17 Apr 2019 09:57:01 -0700 Linus Torvalds wrote: > On Wed, Apr 17, 2019 at 1:02 AM Martin Schwidefsky > wrote: > > > > Grumpf, that does *not* work. For gup the table entries may be read only > > once. Now I remember why I open-coded p4d_offset, pud_offset an

Re: Linux 5.1-rc5

2019-04-17 Thread Martin Schwidefsky
On Wed, 17 Apr 2019 09:46:37 +0200 Martin Schwidefsky wrote: > On Tue, 16 Apr 2019 09:49:46 -0700 > Linus Torvalds wrote: > > > On Tue, Apr 16, 2019 at 9:16 AM Linus Torvalds > > wrote: > > > > > > We actually already *have* this function. >

Re: Linux 5.1-rc5

2019-04-17 Thread Martin Schwidefsky
On Tue, 16 Apr 2019 09:49:46 -0700 Linus Torvalds wrote: > On Tue, Apr 16, 2019 at 9:16 AM Linus Torvalds > wrote: > > > > We actually already *have* this function. > > > > It's called "gup_fast_permitted()" and it's used by x86-64 to verify > > the proper address range. Exactly like s390

Re: Linux 5.1-rc5

2019-04-16 Thread Martin Schwidefsky
On Tue, 16 Apr 2019 11:09:06 +0200 Martin Schwidefsky wrote: > On Mon, 15 Apr 2019 09:17:10 -0700 > Linus Torvalds wrote: > > > On Sun, Apr 14, 2019 at 10:19 PM Christoph Hellwig > > wrote: > > > > > > Can we please have the page refcount overflow

Re: Linux 5.1-rc5

2019-04-16 Thread Martin Schwidefsky
On Mon, 15 Apr 2019 09:17:10 -0700 Linus Torvalds wrote: > On Sun, Apr 14, 2019 at 10:19 PM Christoph Hellwig wrote: > > > > Can we please have the page refcount overflow fixes out on the list > > for review, even if it is after the fact? > > They were actually on a list for review long

Re: [PATCH 3/5] s390: Fix vDSO clock_getres()

2019-04-03 Thread Martin Schwidefsky
er_resolution depends on the enablement of the high > resolution timers that can happen either at compile or at run time. > > Fix the s390 vdso implementation of clock_getres keeping a copy of > hrtimer_resolution in vdso data and using that directly. > > Cc: Martin Schwidefsky > Cc:

Re: Kconfig label updates

2019-01-09 Thread Martin Schwidefsky
Partitioning > @@ -157,7 +158,7 @@ config HOTPLUG_PCI_SGI > When in doubt, say N. > > config HOTPLUG_PCI_S390 > - bool "System z PCI Hotplug Support" > + bool "IBM System z PCI Hotplug Support" > depends on S390 && 64BIT > help > Say Y here if you want to use the System z PCI Hotplug > The rewording of the HOTPLUG_PCI_S390 entry is fine with me. Acked-by: Martin Schwidefsky -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.

Re: [PATCH v2 2/2] mm: speed up mremap by 500x on large regions

2018-10-15 Thread Martin Schwidefsky
cks because exclusive mmap_sem prevents deadlock. > > +*/ > > + old_ptl = pmd_lock(vma->vm_mm, old_pmd); > > + if (old_ptl) { > > + pmd_t pmd; > > + > > + new_ptl = pmd_lockptr(mm, new_pmd); > > + if (new_ptl != old_

Re: [PATCH 3/4] cputime/powerpc/s390: make scaled cputime arch specific

2016-11-02 Thread Martin Schwidefsky
On Wed, 2 Nov 2016 10:38:20 +0100 Stanislaw Gruszka wrote: > On Wed, Nov 02, 2016 at 10:11:22AM +0100, Christian Borntraeger wrote: > > On 10/31/2016 01:36 PM, Stanislaw Gruszka wrote: > > > Only s390 and powerpc have hardware facilities allowing to measure > > > cputimes

Re: [PATCH 11/14] s390/ptrace: run seccomp after ptrace

2016-06-10 Thread Martin Schwidefsky
On Thu, 9 Jun 2016 14:02:01 -0700 Kees Cook <keesc...@chromium.org> wrote: > Close the hole where ptrace can change a syscall out from under seccomp. > > Signed-off-by: Kees Cook <keesc...@chromium.org> > Cc: Heiko Carstens <heiko.carst...@de.ibm.com> >

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-24 Thread Martin Schwidefsky
On Tue, 23 Feb 2016 22:33:45 +0300 "Kirill A. Shutemov" wrote: > On Tue, Feb 23, 2016 at 07:19:07PM +0100, Gerald Schaefer wrote: > > I'll check with Martin, maybe it is actually trivial, then we can > > do a quick test it to rule that one out. > > Oh. I found a bug in

Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM)

2016-02-24 Thread Martin Schwidefsky
On Tue, 23 Feb 2016 19:19:07 +0100 Gerald Schaefer wrote: > On Tue, 23 Feb 2016 13:32:21 +0300 > "Kirill A. Shutemov" wrote: > > > On Fri, Feb 12, 2016 at 06:16:40PM +0100, Gerald Schaefer wrote: > > > On Fri, 12 Feb 2016 16:57:27 +0100 > > >

Re: [PATCH v2 06/32] s390: reuse asm-generic/barrier.h

2016-01-05 Thread Martin Schwidefsky
On Mon, 4 Jan 2016 22:42:44 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Mon, Jan 04, 2016 at 04:03:39PM +0100, Martin Schwidefsky wrote: > > On Mon, 4 Jan 2016 14:20:42 +0100 > > Peter Zijlstra <pet...@infradead.org> wrote: > > > > &g

Re: [PATCH v2 22/32] s390: define __smp_xxx

2016-01-05 Thread Martin Schwidefsky
On Mon, 4 Jan 2016 22:18:58 +0200 "Michael S. Tsirkin" wrote: > On Mon, Jan 04, 2016 at 02:45:25PM +0100, Peter Zijlstra wrote: > > On Thu, Dec 31, 2015 at 09:08:38PM +0200, Michael S. Tsirkin wrote: > > > This defines __smp_xxx barriers for s390, > > > for use by

Re: [PATCH v2 22/32] s390: define __smp_xxx

2016-01-05 Thread Martin Schwidefsky
On Tue, 5 Jan 2016 15:04:43 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Tue, Jan 05, 2016 at 01:08:52PM +0100, Martin Schwidefsky wrote: > > On Tue, 5 Jan 2016 11:30:19 +0200 > > "Michael S. Tsirkin" <m...@redhat.com> wrote: > > &

Re: [PATCH v2 22/32] s390: define __smp_xxx

2016-01-05 Thread Martin Schwidefsky
On Tue, 5 Jan 2016 11:30:19 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Tue, Jan 05, 2016 at 09:13:19AM +0100, Martin Schwidefsky wrote: > > On Mon, 4 Jan 2016 22:18:58 +0200 > > "Michael S. Tsirkin" <m...@redhat.com> wrote: > >

Re: [PATCH v2 06/32] s390: reuse asm-generic/barrier.h

2016-01-04 Thread Martin Schwidefsky
On Mon, 4 Jan 2016 14:20:42 +0100 Peter Zijlstra wrote: > On Thu, Dec 31, 2015 at 09:06:30PM +0200, Michael S. Tsirkin wrote: > > On s390 read_barrier_depends, smp_read_barrier_depends > > smp_store_mb(), smp_mb__before_atomic and smp_mb__after_atomic match the > >

Re: Ping Re: [PATCH 0/8] math-emu: Update kernel math-emu code from current glibc soft-fp

2015-08-27 Thread Martin Schwidefsky
if the s390 and sparc maintainers want to send me acks I'll rebase and add them. For the s390 parts: Acked-by: Martin Schwidefsky schwidef...@de.ibm.com -- blue skies, Martin. Reality continues to ruin my life. - Calvin. ___ Linuxppc-dev mailing list

Re: [PATCH 0/2] Consolidate redundant register/stack access code

2015-06-16 Thread Martin Schwidefsky
On Mon, 15 Jun 2015 12:42:57 -0400 David Long dave.l...@linaro.org wrote: From: David A. Long dave.l...@linaro.org Move duplicate and functionally equivalent code for accessing registers and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into common kernel files. Note:

Re: [PATCH v4 06/10] s390: standardize mmap_rnd() usage

2015-03-09 Thread Martin Schwidefsky
--- arch/s390/mm/mmap.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) Patch series including this patch works fine Acked-by: Martin Schwidefsky schwidef...@de.ibm.com -- blue skies, Martin. Reality continues to ruin my life. - Calvin

Re: [PATCH v4 08/10] s390: redefine randomize_et_dyn for ELF_ET_DYN_BASE

2015-03-09 Thread Martin Schwidefsky
in the same ET_DYN randomization on s390. Signed-off-by: Kees Cook keesc...@chromium.org --- arch/s390/include/asm/elf.h | 8 +--- arch/s390/mm/mmap.c | 11 ++- 2 files changed, 7 insertions(+), 12 deletions(-) Patch series including this patch works fine Acked-by: Martin

Re: [PATCH] srcu: Isolate srcu sections using CONFIG_SRCU

2014-12-29 Thread Martin Schwidefsky
On Sat, 27 Dec 2014 12:17:43 -0500 Pranith Kumar bobby.pr...@gmail.com wrote: @@ -65,10 +65,13 @@ #include asm/kexec.h #include asm/mmu_context.h #include asm/code-patching.h -#include asm/kvm_ppc.h #include asm/hugetlb.h #include asm/epapr_hcalls.h +#if IS_ENABLED(CONFIG_KVM)

Re: [PATCH RFC 04/77] PCI/MSI/s390: Remove superfluous check of MSI type

2013-10-04 Thread Martin Schwidefsky
; pr_debug(%s: requesting %d MSI-X interrupts..., __func__, nvec); - if (type != PCI_CAP_ID_MSIX type != PCI_CAP_ID_MSI) - return -EINVAL; if (type == PCI_CAP_ID_MSI nvec 1) return 1; msi_vecs = min(nvec, ZPCI_MSI_VEC_MAX); Acked-by: Martin Schwidefsky

Re: [PATCH RFC 03/77] PCI/MSI/s390: Fix single MSI only check

2013-10-04 Thread Martin Schwidefsky
, msi_vecs, CONFIG_PCI_NR_MSI); Acked-by: Martin Schwidefsky schwidef...@de.ibm.com -- blue skies, Martin. Reality continues to ruin my life. - Calvin. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo

Re: [BUG] rebuild_sched_domains considered dangerous

2011-03-09 Thread Martin Schwidefsky
On Wed, 09 Mar 2011 12:33:49 +0100 Peter Zijlstra pet...@infradead.org wrote: On Wed, 2011-03-09 at 11:19 +0100, Peter Zijlstra wrote: It appears that this corresponds to one CPU deciding to rebuild the sched domains. There's various reasons why that can happen, the typical one in our

Re: [BUG] rebuild_sched_domains considered dangerous

2011-03-09 Thread Martin Schwidefsky
On Wed, 09 Mar 2011 14:19:29 +0100 Peter Zijlstra pet...@infradead.org wrote: On Wed, 2011-03-09 at 14:15 +0100, Martin Schwidefsky wrote: On Wed, 09 Mar 2011 12:33:49 +0100 Peter Zijlstra pet...@infradead.org wrote: On Wed, 2011-03-09 at 11:19 +0100, Peter Zijlstra wrote

Re: [BUG] rebuild_sched_domains considered dangerous

2011-03-09 Thread Martin Schwidefsky
On Wed, 09 Mar 2011 14:33:56 +0100 Peter Zijlstra pet...@infradead.org wrote: On Wed, 2011-03-09 at 14:31 +0100, Martin Schwidefsky wrote: But if you don't also update the cpu-node memory mappings (which I think it near impossible) what good is it to change the scheduler topology

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Martin Schwidefsky
On Mon, 17 Jan 2011 12:07:13 +0100 Peter Zijlstra pet...@infradead.org wrote: I visited existing smp_send_reschedule() implementations and tried to add a call to scheduler_ipi() in their handler part, but esp. for MIPS I'm not quite sure I actually got all of them. diff --git

Re: [PATCH] math-emu: correct test for downshifting fraction in _FP_FROM_INT()

2010-07-20 Thread Martin Schwidefsky
On Tue, 20 Jul 2010 00:12:02 +0200 Mikael Pettersson mi...@it.uu.se wrote: Unfortunately it seems difficult to write a generic module which uses math-emu: - math-emu/soft-fp.h includes asm/sfp-machine.h, but only a handful of archs have it - asm/sfp-machine.h isn't always self-contained

Re: [RFC/PATCH] mm: Pass virtual address to [__]p{te,ud,md}_free_tlb()

2009-07-20 Thread Martin Schwidefsky
On Mon, 20 Jul 2009 17:11:13 +1000 Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2009-07-15 at 15:56 +0200, Nick Piggin wrote: I would like to merge the new support that depends on this in 2.6.32, so unless there's major objections, I'd like this to go in early during

Re: [PATCH] Restore deterministic CPU accounting on powerpc

2007-11-02 Thread Martin Schwidefsky
tested on s390 with CONFIG_VIRT_CPU_ACCOUNTING=y. Works fine and it is a nice cleanup of the s390 timer code. Thanks Paul. Acked-by: Martin Schwidefsky [EMAIL PROTECTED] -- blue skies, Martin. Reality continues to ruin my life. - Calvin

Re: 2.6.23-rc2-mm2 build error on MIPS and ARM

2007-08-11 Thread Martin Schwidefsky
-compilers.. -- blue skies, Martin. Reality continues to ruin my life. - Calvin. --- Subject: [PATCH] move mm_struct and vm_area_struct, compile fix. From: Martin Schwidefsky [EMAIL PROTECTED] Include asm/page.h in linux/mm_types.h to make mips and arm compile again after mm_struct

Re: 2.6.23-rc2-mm2 build error on MIPS and ARM

2007-08-11 Thread Martin Schwidefsky
On Sat, 2007-08-11 at 11:56 +0200, Sam Ravnborg wrote: That attached patch should fix it for arm and mips. I'll try a few more architectures until I'm fed up with compiling cross-compilers.. http://userweb.kernel.org/~akpm/cross-compilers/ Thanks for the hint but I prefer to compile them on