Re: 5.2.7 kernel doesn't boot on G5

2019-08-26 Thread Mathieu Malaterre
Christian, On Fri, Aug 16, 2019 at 4:52 PM Christian Marillat wrote: > > On 16 août 2019 16:05, Andreas Schwab wrote: > > > On Aug 16 2019, Christian Marillat wrote: > > > >> On 15 août 2019 19:50, christophe leroy wrote: > >> > >> [...] > >> > >>> Can you test with latest stable version, ie

5.2.7 kernel doesn't boot on G5

2019-08-15 Thread Mathieu Malaterre
Does that ring a bell to anyone here ? Thanks -- Forwarded message - To: Hi, No log only a photo : https://www.deb-multimedia.org/tests/20190812_143628.jpg Christian

Re: [RFC PATCH v1 11/13] powerpc/ptrace: create ppc_gethwdinfo()

2019-06-25 Thread Mathieu Malaterre
On Tue, Jun 25, 2019 at 1:22 PM Christophe Leroy wrote: > > Create ippc_gethwdinfo() to handle PPC_PTRACE_GETHWDBGINFO and s/ippc_gethwdinfo/ppc_gethwdinfo/ > reduce ifdef mess > > Signed-off-by: Christophe Leroy > --- > arch/powerpc/kernel/ptrace/ptrace-adv.c | 15 +++ >

[PATCH] powerpc/lib/xor_vmx: Relax frame size for clang

2019-06-21 Thread Mathieu Malaterre
ot;) until a proper fix is implemented upstream in clang and relax requirement for clang. Link: https://github.com/ClangBuiltLinux/linux/issues/563 Cc: Joel Stanley Signed-off-by: Mathieu Malaterre --- arch/powerpc/lib/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/arch/powerpc/li

Re: [PATCH] powerpc: enable a 30-bit ZONE_DMA for 32-bit pmac

2019-06-19 Thread Mathieu Malaterre
On Wed, Jun 19, 2019 at 4:18 PM Benjamin Herrenschmidt wrote: > > On Wed, 2019-06-19 at 22:32 +1000, Michael Ellerman wrote: > > Christoph Hellwig writes: > > > Any chance this could get picked up to fix the regression? > > > > Was hoping Ben would Ack it. He's still powermac maintainer :) > > >

Re: [PATCH] powerpc: enable a 30-bit ZONE_DMA for 32-bit pmac

2019-06-14 Thread Mathieu Malaterre
On Thu, Jun 13, 2019 at 10:27 AM Christoph Hellwig wrote: > > With the strict dma mask checking introduced with the switch to > the generic DMA direct code common wifi chips on 32-bit powerbooks > stopped working. Add a 30-bit ZONE_DMA to the 32-bit pmac builds > to allow them to reliably

Re: [PATCH] powerpc/32s: fix booting with CONFIG_PPC_EARLY_DEBUG_BOOTX

2019-06-07 Thread Mathieu Malaterre
On Wed, Jun 5, 2019 at 1:32 PM Mathieu Malaterre wrote: > > On Mon, Jun 3, 2019 at 3:00 PM Christophe Leroy > wrote: > > > > When booting through OF, setup_disp_bat() does nothing because > > disp_BAT are not set. By change, it used to work because BOOTX > >

[PATCH] powerpc/32: Add .data..LASAN* sections explicitly

2019-06-05 Thread Mathieu Malaterre
-gnu-ld: warning: orphan section `.data..LASANLOC1' from `net/core/filter.o' being placed in section `.data..LASANLOC1' This commit remove those warnings produced at W=1. Reported-by: Christophe Leroy Signed-off-by: Mathieu Malaterre --- arch/powerpc/kernel/vmlinux.lds.S | 3 +++ 1 file changed

Re: [PATCH] powerpc/32s: fix booting with CONFIG_PPC_EARLY_DEBUG_BOOTX

2019-06-05 Thread Mathieu Malaterre
nel Userspace Access Protection (KUAP) because it is within user > address space. > > This patch fixes those issues by properly setting disp_BAT through > a call to btext_prepare_BAT(), allowing setup_disp_bat() to > properly setup BAT3 for early bootx screen buffer access. > > Reported

Re: kmemleak: 1157 new suspected memory leaks (see /sys/kernel/debug/kmemleak)

2019-05-28 Thread Mathieu Malaterre
Hi Michael ! Thanks for the kind help. On Tue, May 28, 2019 at 7:21 AM Michael Ellerman wrote: > > Mathieu Malaterre writes: > > Hi there, > > > > Is there a way to dump more context (somewhere in of tree > > flattening?). I cannot make sense of the follo

Re: [PATCH v2] powerpc/32: sstep: Move variable `rc` within CONFIG_PPC64 sentinels

2019-05-28 Thread Mathieu Malaterre
On Tue, May 28, 2019 at 1:40 PM Michael Ellerman wrote: > > Mathieu Malaterre writes: > > > Fix warnings treated as errors with W=1: > > > > arch/powerpc/lib/sstep.c:1172:31: error: variable 'rc' set but not used > > [-Werror=unused-but-set-variable] >

[PATCH v2] powerpc/power: Expose pfn_is_nosave prototype

2019-05-24 Thread Mathieu Malaterre
prototype for 'pfn_is_nosave' [-Werror=missing-prototypes] This moves the declaration into a globally visible header file and add missing include to avoid a warning on powerpc. Also remove the duplicated prototypes since not required anymore. Cc: Christophe Leroy Signed-off-by: Mathieu Malaterre

Re: Failure to boot G4: dt_headr_start=0x01501000

2019-05-24 Thread Mathieu Malaterre
On Thu, May 23, 2019 at 8:12 PM Christophe Leroy wrote: > > > > On 05/23/2019 10:16 AM, Mathieu Malaterre wrote: > > On Thu, May 23, 2019 at 11:45 AM Christophe Leroy > > wrote: > >> > >> > >> > >> Le 23/05/2019 à 10:53, Mathieu

Re: [PATCH v2] powerpc/32: sstep: Move variable `rc` within CONFIG_PPC64 sentinels

2019-05-23 Thread Mathieu Malaterre
ping ? On Tue, Mar 12, 2019 at 10:23 PM Mathieu Malaterre wrote: > > Fix warnings treated as errors with W=1: > > arch/powerpc/lib/sstep.c:1172:31: error: variable 'rc' set but not used > [-Werror=unused-but-set-variable] > > Suggested-by: Christophe Leroy > Signed-o

[PATCH] powerpc/power: Expose pfn_is_nosave prototype

2019-05-23 Thread Mathieu Malaterre
prototype for 'pfn_is_nosave' [-Werror=missing-prototypes] This moves the declaration into a globally visible header file and add missing include to avoid a warning in powerpc. Signed-off-by: Mathieu Malaterre --- arch/powerpc/kernel/suspend.c | 1 + include/linux/suspend.h | 1 + 2 files

[PATCH] powerpc: Remove variable ‘path’ since not used

2019-05-23 Thread Mathieu Malaterre
e original patch and simplify the code, by removing the variable ‘path’ completely. Fix line over 90 characters. Suggested-by: Michael Ellerman Signed-off-by: Mathieu Malaterre --- arch/powerpc/kernel/prom_init.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/ar

Re: Failure to boot G4: dt_headr_start=0x01501000

2019-05-23 Thread Mathieu Malaterre
On Thu, May 23, 2019 at 11:45 AM Christophe Leroy wrote: > > > > Le 23/05/2019 à 10:53, Mathieu Malaterre a écrit : > > On Thu, May 23, 2019 at 10:29 AM Mathieu Malaterre wrote: > >> > >> On Thu, May 23, 2019 at 8:39 AM Christophe Leroy > >> wrote:

Re: Failure to boot G4: dt_headr_start=0x01501000

2019-05-23 Thread Mathieu Malaterre
On Thu, May 23, 2019 at 10:29 AM Mathieu Malaterre wrote: > > On Thu, May 23, 2019 at 8:39 AM Christophe Leroy > wrote: > > > > Salut Mathieu, > > > > Le 23/05/2019 à 08:24, Mathieu Malaterre a écrit : > > > Salut Christophe, > > > >

Re: Failure to boot G4: dt_headr_start=0x01501000

2019-05-23 Thread Mathieu Malaterre
On Thu, May 23, 2019 at 10:29 AM Mathieu Malaterre wrote: > > On Thu, May 23, 2019 at 8:39 AM Christophe Leroy > wrote: > > > > Salut Mathieu, > > > > Le 23/05/2019 à 08:24, Mathieu Malaterre a écrit : > > > Salut Christophe, > > > >

kmemleak: 1157 new suspected memory leaks (see /sys/kernel/debug/kmemleak)

2019-05-23 Thread Mathieu Malaterre
Hi there, Is there a way to dump more context (somewhere in of tree flattening?). I cannot make sense of the following: kmemleak: 1157 new suspected memory leaks (see /sys/kernel/debug/kmemleak) Where: # head -40 /sys/kernel/debug/kmemleak unreferenced object 0xdf44d180 (size 8): comm

Re: Failure to boot G4: dt_headr_start=0x01501000

2019-05-23 Thread Mathieu Malaterre
On Thu, May 23, 2019 at 8:39 AM Christophe Leroy wrote: > > Salut Mathieu, > > Le 23/05/2019 à 08:24, Mathieu Malaterre a écrit : > > Salut Christophe, > > > > On Wed, May 22, 2019 at 2:20 PM Christophe Leroy > > wrote: > >> > >> >

[PATCH] powerpc/32s: Include header file to fix a warning

2019-05-23 Thread Mathieu Malaterre
pes] Make sure to include to provide the following prototype: module_alloc. Signed-off-by: Mathieu Malaterre --- arch/powerpc/mm/kasan/kasan_init_32.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/mm/kasan/kasan_init_32.c b/arch/powerpc/mm/kasan/kasan_init_32.c index 0d

Re: Failure to boot G4: dt_headr_start=0x01501000

2019-05-23 Thread Mathieu Malaterre
Salut Christophe, On Wed, May 22, 2019 at 2:20 PM Christophe Leroy wrote: > > > > Le 22/05/2019 à 14:15, Mathieu Malaterre a écrit : > > Hi all, > > > > I have not boot my G4 in a while, today using master here is what I see: > > > > done >

Failure to boot G4: dt_headr_start=0x01501000

2019-05-22 Thread Mathieu Malaterre
Hi all, I have not boot my G4 in a while, today using master here is what I see: done Setting btext ! W=640 H=488 LB=768 addr=0x9c008000 copying OF device tree... starting device tree allocs at 01401000 otloc_up(0010, 0013d948) trying: 0x01401000 trying: 0x01501000 -› 01501000

[PATCH v2] powerpc: silence a -Wcast-function-type warning in dawr_write_file_bool

2019-05-15 Thread Mathieu Malaterre
he warning. Fixes: c1fe190c0672 ("powerpc: Add force enable of DAWR on P9 option") Suggested-by: Christoph Hellwig Cc: Michael Neuling Signed-off-by: Mathieu Malaterre --- v2: do not hide warning using a hack arch/powerpc/kernel/hw_breakpoint.c | 7 ++- 1 file changed, 6 insertions(+),

Re: [PATCH] powerpc: silence a -Wcast-function-type warning in dawr_write_file_bool

2019-05-15 Thread Mathieu Malaterre
Hi Christoph, On Wed, May 15, 2019 at 3:14 PM Christoph Hellwig wrote: > > On Wed, May 15, 2019 at 02:09:42PM +0200, Mathieu Malaterre wrote: > > In commit c1fe190c0672 ("powerpc: Add force enable of DAWR on P9 > > option") the following piece of code was added:

[PATCH] powerpc: Include header file to fix a warning

2019-05-15 Thread Mathieu Malaterre
move __find_linux_pte() out of hugetlbpage.c") Cc: Christophe Leroy Signed-off-by: Mathieu Malaterre --- arch/powerpc/mm/pgtable.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c index db4a6253df92..2aa042193ace 100644 --- a/arch/powerpc/mm

[PATCH] powerpc: silence a -Wcast-function-type warning in dawr_write_file_bool

2019-05-15 Thread Mathieu Malaterre
dd force enable of DAWR on P9 option") Cc: Michael Neuling Signed-off-by: Mathieu Malaterre --- arch/powerpc/kernel/hw_breakpoint.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c index f70fb8

Re: [PATCH] powerpc/powernv/ioda2: Add __printf format/argument verification

2019-05-03 Thread Mathieu Malaterre
On Fri, May 3, 2019 at 10:21 AM Joe Perches wrote: > > On Fri, 2019-05-03 at 16:59 +1000, Michael Ellerman wrote: > > On Thu, 2017-03-30 at 10:19:25 UTC, Joe Perches wrote: > > > Fix fallout too. > > > > > > Signed-off-by: Joe Perches > > > > Applied to powerpc next, thanks. > > > >

Re: [PATCH v2 06/11] MIPS: mark __fls() as __always_inline

2019-04-19 Thread Mathieu Malaterre
Hi, On Fri, Apr 19, 2019 at 12:06 PM Masahiro Yamada wrote: > > This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common > place. We need to eliminate potential issues beforehand. > > If it is enabled for mips, the following errors are reported: > > arch/mips/mm/sc-mips.o: In function

Re: [PATCH] powerpc: config: skiroot: Add (back) MLX5 ethernet support

2019-04-03 Thread Mathieu Malaterre
On Wed, Apr 3, 2019 at 2:51 AM Joel Stanley wrote: > > It turns out that some defconfig changes and kernel config option > changes meant we accidentally dropped Ethernet support for Mellanox CLX5 > cards. > > Reported-by: Carol L Soto > Suggested-by: Carol L Soto > Signed-off-by: Stewart Smith

[PATCH v2 1/2] powerpc: Make some functions static

2019-03-26 Thread Mathieu Malaterre
or=missing-prototypes] Signed-off-by: Mathieu Malaterre --- v2: Split the patch in two operations arch/powerpc/platforms/embedded6xx/holly.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/embedded6xx/holly.c b/arch/powerpc/platforms/embedded6

[PATCH v2 2/2] Remove functions holly_power_off and holly_halt since unused

2019-03-26 Thread Mathieu Malaterre
=missing-prototypes] Signed-off-by: Mathieu Malaterre --- arch/powerpc/platforms/embedded6xx/holly.c | 12 1 file changed, 12 deletions(-) diff --git a/arch/powerpc/platforms/embedded6xx/holly.c b/arch/powerpc/platforms/embedded6xx/holly.c index 9d2eefef7b7b..829bf3697dc9 100644

Re: Mac Mini G4 hang on boot with git master

2019-03-15 Thread Mathieu Malaterre
Mark, On Fri, Mar 15, 2019 at 3:08 PM Mark Cave-Ayland wrote: > > Hi all, > > I've just done a git pull and rebuilt master on my Mac Mini G4 in order to > test > Michael's merge of my KVM PR fix, and unfortunately my kernel now hangs on > boot :( Ouch :( > My last working git checkout was

Re: [PATCH] powerpc: use $(origin ARCH) to select KBUILD_DEFCONFIG

2019-03-13 Thread Mathieu Malaterre
On Sat, Feb 16, 2019 at 3:26 AM Masahiro Yamada wrote: > > On Sat, Feb 16, 2019 at 1:11 AM Mathieu Malaterre wrote: > > > > On Fri, Feb 15, 2019 at 10:41 AM Masahiro Yamada > > wrote: > > > > > > I often test all Kconfig commands for all architecture

Re: [PATCH] powerpc: Make some functions static

2019-03-13 Thread Mathieu Malaterre
On Tue, Mar 12, 2019 at 10:14 PM Christophe Leroy wrote: > > > > Le 12/03/2019 à 21:31, Mathieu Malaterre a écrit : > > In commit cb9e4d10c448 ("[POWERPC] Add support for 750CL Holly board") > > new functions were added. Since these functions can be made stat

Re: [PATCH] powerpc: sstep: Mark variable `rc` as unused in function 'analyse_instr'

2019-03-13 Thread Mathieu Malaterre
On Tue, Mar 12, 2019 at 10:26 PM Christophe Leroy wrote: > > > > Le 12/03/2019 à 22:12, Mathieu Malaterre a écrit : > > On Tue, Mar 12, 2019 at 9:56 PM Christophe Leroy > > wrote: > >> > >> > >> > >> Le 12/03/2019 à 21:20, Mathie

[PATCH v2] powerpc/64s: Remove 'dummy_copy_buffer'

2019-03-13 Thread Mathieu Malaterre
opy_buffer' defined but not used [-Werror=unused-const-variable=] Cc: Nicholas Piggin Suggested-by: Christophe Leroy Signed-off-by: Mathieu Malaterre --- v2: complely remove dummy_copy_buffer instead of marking it as used (since not anymore) arch/powerpc/kernel/process.c | 5 - 1 file changed, 5

[PATCH v2] powerpc/32: sstep: Move variable `rc` within CONFIG_PPC64 sentinels

2019-03-12 Thread Mathieu Malaterre
Fix warnings treated as errors with W=1: arch/powerpc/lib/sstep.c:1172:31: error: variable 'rc' set but not used [-Werror=unused-but-set-variable] Suggested-by: Christophe Leroy Signed-off-by: Mathieu Malaterre --- v2: as suggested prefer CONFIG_PPC64 sentinel instead of unused keyword

Re: [PATCH] powerpc: sstep: Mark variable `rc` as unused in function 'analyse_instr'

2019-03-12 Thread Mathieu Malaterre
On Tue, Mar 12, 2019 at 9:56 PM Christophe Leroy wrote: > > > > Le 12/03/2019 à 21:20, Mathieu Malaterre a écrit : > > Add gcc attribute unused for `rc` variable. > > > > Fix warnings treated as errors with W=1: > > > >arch/powerpc/lib/sstep.c:1172

[PATCH] powerpc: Make some functions static

2019-03-12 Thread Mathieu Malaterre
3:6: error: no previous prototype for 'holly_halt' [-Werror=missing-prototypes] Signed-off-by: Mathieu Malaterre --- arch/powerpc/platforms/embedded6xx/holly.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/arch/powerpc/platforms/embedded6xx/holly.c b/ar

[PATCH] powerpc/64s: Mark 'dummy_copy_buffer' as used

2019-03-12 Thread Mathieu Malaterre
'__aligned' to get passed line over 80 characters warning in checkpatch. This remove the following warning: arch/powerpc/kernel/process.c:1156:17: error: 'dummy_copy_buffer' defined but not used [-Werror=unused-const-variable=] Cc: Nicholas Piggin Signed-off-by: Mathieu Malaterre --- ar

[PATCH] powerpc: sstep: Mark variable `rc` as unused in function 'analyse_instr'

2019-03-12 Thread Mathieu Malaterre
Add gcc attribute unused for `rc` variable. Fix warnings treated as errors with W=1: arch/powerpc/lib/sstep.c:1172:31: error: variable 'rc' set but not used [-Werror=unused-but-set-variable] Signed-off-by: Mathieu Malaterre --- arch/powerpc/lib/sstep.c | 2 +- 1 file changed, 1 insertion

[PATCH] powerpc/64s: Include header file to fix a warning

2019-03-12 Thread Mathieu Malaterre
Make sure to include to provide the following prototype: hv_nmi_check_nonrecoverable. Remove the following warning treated as error (W=1): arch/powerpc/kernel/traps.c:393:6: error: no previous prototype for 'hv_nmi_check_nonrecoverable' [-Werror=missing-prototypes] Signed-off-by: Mathieu

Re: PROBLEM: monotonic clock going backwards on ppc64

2019-02-27 Thread Mathieu Malaterre
On Tue, Feb 26, 2019 at 9:36 PM Jakub Drnec wrote: > > Hi all, > > I think I observed a potential problem, is this the correct place to report > it? (CC me, not on list) > > [1.] One line summary: monotonic clock can be made to decrease on ppc64 > [2.] Full description: > Setting the realtime

Re: [PATCH] powerpc: use $(origin ARCH) to select KBUILD_DEFCONFIG

2019-02-15 Thread Mathieu Malaterre
On Fri, Feb 15, 2019 at 10:41 AM Masahiro Yamada wrote: > > I often test all Kconfig commands for all architectures. To ease my > workflow, I want 'make defconfig' at least working without any cross > compiler. > > Currently, arch/powerpc/Makefile checks CROSS_COMPILE to decide the > default

Re: [PATCH] powerpc/ptrace: Add prototype for function pt_regs_check

2019-02-15 Thread Mathieu Malaterre
On Fri, Feb 15, 2019 at 9:21 AM Christophe Leroy wrote: > > > > Le 15/02/2019 à 09:11, Mathieu Malaterre a écrit : > > On Sat, Dec 8, 2018 at 4:46 PM Mathieu Malaterre wrote: > >> > >> `pt_regs_check` is a dummy function, its purpose is to break the bui

Re: [PATCH] powerpc/ptrace: Add prototype for function pt_regs_check

2019-02-15 Thread Mathieu Malaterre
On Sat, Dec 8, 2018 at 4:46 PM Mathieu Malaterre wrote: > > `pt_regs_check` is a dummy function, its purpose is to break the build > if struct pt_regs and struct user_pt_regs don't match. > > This function has no functionnal purpose, and will get eliminated at > link time or af

Re: [PATCH] powerpc/ptrace: Simplify vr_get/set() to avoid GCC warning

2019-02-15 Thread Mathieu Malaterre
exposure/overwrite on our > hands. > > Rather than relying on that we can pass an explict end_pos based on > the sizeof(vrsave). The result should be exactly the same but it's > more obviously not over-reading/writing the stack and it avoids the > compiler warning. > maybe: Li

Re: [PATCH 2/2] powerpc: Fix defconfig choice logic when cross compiling

2019-02-07 Thread Mathieu Malaterre
On Thu, Feb 7, 2019 at 6:20 AM Michael Ellerman wrote: > > Our logic for choosing defconfig doesn't work well in some situations. > > For example if you're on a ppc64le machine but you specify a non-empty > CROSS_COMPILE, in order to use a non-default toolchain, then defconfig > will give you

Re: [PATCH 1/2] powerpc/32: Add ppc_defconfig

2019-02-07 Thread Mathieu Malaterre
fconfig:358:warning: symbol value 'm' invalid for NF_TABLES_BRIDGE arch/powerpc/configs/ppc_defconfig:1427:warning: symbol value 'm' invalid for LIRC # # configuration written to .config # Tested-by: Mathieu Malaterre > This config is mostly intended for build testing but if someone want

[PATCH] Move static keyword at beginning of declaration

2019-02-02 Thread Mathieu Malaterre
of declaration [-Werror=old-style-declaration] Signed-off-by: Mathieu Malaterre --- arch/powerpc/platforms/ps3/os-area.c| 4 ++-- arch/powerpc/platforms/ps3/system-bus.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/platforms/ps3/os-area.c b/arch/powerpc

[PATCH] powerpc: Remove trailing semicolon after curly brace

2019-02-02 Thread Mathieu Malaterre
There is not point in having a trailing semicolon after a closing curly brace. Remove it. Signed-off-by: Mathieu Malaterre --- arch/powerpc/sysdev/tsi108_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/sysdev/tsi108_dev.c b/arch/powerpc/sysdev/tsi108_dev.c

Re: G5 Quad hangs early on 4.20.2 / 5.0-rc2+

2019-01-18 Thread Mathieu Malaterre
On Fri, Jan 18, 2019 at 1:53 AM Tobias Ulmer wrote: > > On Fri, Jan 18, 2019 at 09:32:07AM +1100, Benjamin Herrenschmidt wrote: > > On Thu, 2019-01-17 at 10:42 +0100, Tobias Ulmer wrote: > > > On Wed, Jan 16, 2019 at 12:15:14PM +1100, Benjamin Herrenschmidt wrote: > > > > On Tue, 2019-01-15 at

Re: ptrace compile failure with gcc-8.2 on 32-bit powerpc

2019-01-18 Thread Mathieu Malaterre
> Yeah I noticed this just yesterday. Just FYI this has been accepted as regression in gcc, and fixed is provided for GCC 9.0: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88273

Re: gcc 6.3 vs 8.2 Re: [RFC PATCH] powerpc: Enable kcov

2019-01-15 Thread Mathieu Malaterre
On Wed, Jan 16, 2019 at 6:09 AM Michael Ellerman wrote: > > Christophe Leroy writes: > > Le 15/01/2019 à 08:26, Mathieu Malaterre a écrit : > ... > >> > >> I did check that `custom_defconfig` is the minimal defconfig generated > >> by `savedefconfig`

Re: [PATCH] kbuild: mark prepare0 as PHONY to fix external module build

2019-01-15 Thread Mathieu Malaterre
On Tue, Jan 15, 2019 at 8:22 AM Masahiro Yamada wrote: > > Commit c3ff2a5193fa ("powerpc/32: add stack protector support") > caused kernel panic on PowerPC if an external module is used with > CONFIG_STACKPROTECTOR because the 'prepare' target was not executed > for the external module build. > >

gcc 6.3 vs 8.2 Re: [RFC PATCH] powerpc: Enable kcov

2019-01-14 Thread Mathieu Malaterre
[Sorry to hijack this thread. ] On Tue, Jan 15, 2019 at 5:22 AM Andrew Donnellan wrote: > > kcov provides kernel coverage data that's useful for fuzzing tools like > syzkaller. > > Wire up kcov support on powerpc. Disable kcov instrumentation on the same > files where we currently disable gcov

[PATCH] powerpc: Allow CPU selection of G4/74xx variant

2019-01-14 Thread Mathieu Malaterre
GCC supports -mcpu=G4 This patch gives the opportunity to select ALTIVEC for this variant. Signed-off-by: Mathieu Malaterre --- arch/powerpc/platforms/Kconfig.cputype | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms

[PATCH] Remove 'type' argument from access_ok() function

2019-01-04 Thread Mathieu Malaterre
oved. Revert commit 05a4ab823983 ("powerpc/uaccess: fix warning/error with access_ok()") to fix the following compilation error: arch/powerpc/include/asm/uaccess.h:66:32: error: ‘type’ undeclared (first use in this function) Signed-off-by: Mathieu Malaterre --- arch/powerpc/include/asm/ua

[PATCH] powerpc/ptrace: fix empty-body warning

2018-12-18 Thread Mathieu Malaterre
ch/powerpc/kernel/ptrace.c:3281:4: error: suggest braces around empty body in an ‘if’ statement [-Werror=empty-body] Fixes: a225f1567405 ("powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call") Signed-off-by: Mathieu Malaterre --- arch/powerpc/kernel/ptrace.c | 4 ++-

[PATCH] powerpc/ptrace: Add prototype for function pt_regs_check

2018-12-08 Thread Mathieu Malaterre
a prototype to fix warning at W=1: arch/powerpc/kernel/ptrace.c:3339:13: error: no previous prototype for ‘pt_regs_check’ [-Werror=missing-prototypes] Suggested-by: Christophe Leroy Signed-off-by: Mathieu Malaterre --- arch/powerpc/kernel/ptrace.c | 4 1 file changed, 4 insertions(+) diff --git

error: no previous prototype for ‘pt_regs_check’

2018-12-07 Thread Mathieu Malaterre
Michael, I have been wondering for a while now, but I failed to make sense of this function: pt_regs_check (commit 002af9391bfbe). What is this function meant for ? Background, it breaks my W=1 build with: ../arch/powerpc/kernel/ptrace.c:3339:13: error: no previous prototype for ‘pt_regs_check’

[PATCH v2] powerpc/32: Move the old 6xx -mcpu logic before the TARGET_CPU logic

2018-12-05 Thread Mathieu Malaterre
... -mcpu=e300c2 ... -mcpu=powerpc ... ../init/do_mounts.c Cc: Christophe Leroy Fixes: 0e00a8c9fd92 ("powerpc: Allow CPU selection also on PPC32") Suggested-by: Michael Ellerman Link: https://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg142315.html Signed-off-by: Mathieu M

Re: [PATCH] powerpc/32: Move the old 6xx -mcpu logic before the TARGET_CPU logic

2018-12-04 Thread Mathieu Malaterre
On Tue, Dec 4, 2018 at 10:28 PM Christophe LEROY wrote: > > > > Le 04/12/2018 à 21:53, Mathieu Malaterre a écrit : > > The code: > > > >ifdef CONFIG_6xx > >KBUILD_CFLAGS += -mcpu=powerpc > >endif > > > > was added in 20

[PATCH] powerpc/32: Move the old 6xx -mcpu logic before the TARGET_CPU logic

2018-12-04 Thread Mathieu Malaterre
... -mcpu=e300c2 ... -mcpu=powerpc ... ../init/do_mounts.c Cc: Christophe Leroy Fixes: 0e00a8c9fd92 ("powerpc: Allow CPU selection also on PPC32") Suggested-by: Michael Ellerman Link: https://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg142315.html Signed-off-by: Mathie

Re: ppc440gp "ebony" board manual/specs

2018-12-04 Thread Mathieu Malaterre
On Tue, Dec 4, 2018 at 12:09 PM Benjamin Herrenschmidt wrote: > > Hi folks ! > > Does anybody still has the manual or schematics (or both!) of the old > "ebony" ppc440gp eval board around by any chance ? A google search for: IBM/AMCC "PPC440GP" Evaluation Board datasheet leads to:

Re: [PATCH 2/7] powerpc: change CONFIG_6xx to CONFIG_PPC_BOOK3S_32

2018-12-03 Thread Mathieu Malaterre
On Sat, Nov 17, 2018 at 11:29 AM Christophe Leroy wrote: > > Today we have: > > config PPC_BOOK3S_32 > bool "512x/52xx/6xx/7xx/74xx/82xx/83xx/86xx" > [depends on PPC32 within a choice] > > config PPC_BOOK3S > def_bool y > depends on PPC_BOOK3S_32 || PPC_BOOK3S_64 >

Re: [PATCH] powerpc: Mark variable `cpumsr` as unused

2018-11-07 Thread Mathieu Malaterre
On Thu, Nov 8, 2018 at 7:09 AM Christophe Leroy wrote: > > > > On 11/07/2018 08:26 PM, Mathieu Malaterre wrote: > > Add gcc attribute unused for `cpumsr` variable. > > > > Fix warnings treated as errors with W=1: > > > >arch/powerpc/kernel/proc

[PATCH] powerpc: Mark variable `cpumsr` as unused

2018-11-07 Thread Mathieu Malaterre
[-Werror=unused-but-set-variable] Signed-off-by: Mathieu Malaterre --- arch/powerpc/kernel/process.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c index 96f34730010f..b9f1a2408738 100644 --- a/arch/powerpc/kernel

[PATCH] powerpc/32: Add .data..Lubsan_data*/.data..Lubsan_type* sections explicitly

2018-10-31 Thread Mathieu Malaterre
`init/main.o' being placed in section `.data..Lubsan_type12'. ... This commit remove those warnings produced at W=1. Link: https://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg135407.html Suggested-by: Nicholas Piggin Signed-off-by: Mathieu Malaterre --- arch/powerpc/kernel

[PATCH] powerpc/mm: remove const type qualifier from function ‘pud_pfn’

2018-10-31 Thread Mathieu Malaterre
Type qualifier on return type is ignored. Remove warning in W=1: arch/powerpc/include/asm/book3s/64/pgtable.h:1268:25: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers] Signed-off-by: Mathieu Malaterre --- arch/powerpc/include/asm/book3s/64/pgtable.h | 2

Re: [PATCH] powerpc: Add missing include

2018-10-18 Thread Mathieu Malaterre
On Thu, Oct 18, 2018 at 6:37 AM Christophe LEROY wrote: > > > > Le 17/10/2018 à 21:25, Mathieu Malaterre a écrit : > > In commit 88b0fe175735 ("powerpc: Add show_user_instructions()") the > > function show_user_instructions was added. > > > > This com

[PATCH] powerpc: Add missing include

2018-10-17 Thread Mathieu Malaterre
/process.c:1302:6: error: no previous prototype for ‘show_user_instructions’ [-Werror=missing-prototypes] Signed-off-by: Mathieu Malaterre --- arch/powerpc/kernel/process.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c index bb

Re: [RFT] powerpc/boot: Fix missing crc32poly.h when building with KERNEL_XZ

2018-08-29 Thread Mathieu Malaterre
On Wed, Aug 29, 2018 at 9:59 AM Krzysztof Kozlowski wrote: > > On Wed, 29 Aug 2018 at 09:32, Krzysztof Kozlowski wrote: > > > > After commit faa16bc404d7 ("lib: Use existing define with > > polynomial") the lib/xz/xz_crc32.c includes a header from include/linux > > directory thus any other user

Re: cxl: remove a dead branch

2018-08-13 Thread Mathieu Malaterre
Frederic, Could you double check with Michael what is now best to do. Thanks On Mon, Aug 13, 2018 at 1:23 PM Michael Ellerman wrote: > > On Thu, 2018-03-22 at 21:05:28 UTC, Mathieu Malaterre wrote: > > In commit 14baf4d9c739 ("cxl: Add guest-specific code") the follow

Re: Build regressions/improvements in v4.17-rc1

2018-08-08 Thread Mathieu Malaterre
On Wed, Aug 8, 2018 at 12:34 PM Michael Ellerman wrote: > > Andrew Morton writes: > > On Mon, 6 Aug 2018 12:39:21 +0200 Geert Uytterhoeven > > wrote: > > > >> CC Dan, Michael, AKPM, powerpc > >> > >> On Mon, Apr 16, 2018 at 3:10 PM Geert Uytterhoeven > >> wrote: > >> > Below is the list of

CONFIG_ANDROID_BINDER_IPC=y (Re: powerpc: 32BIT vs. 64BIT (PPC32 vs. PPC64))

2018-07-13 Thread Mathieu Malaterre
Randy, On Mon, Jul 9, 2018 at 2:00 PM Mathieu Malaterre wrote: > > On Sun, Jul 8, 2018 at 1:53 PM Michael Ellerman wrote: > > > > Randy Dunlap writes: > > > Hi, > > > > > > Is there a good way (or a shortcut) to do something like: > > > &g

Re: [PATCH 1/2] powerpc: Add ppc32_allmodconfig defconfig target

2018-07-11 Thread Mathieu Malaterre
On Tue, Jul 10, 2018 at 3:47 PM Michael Ellerman wrote: > > Mathieu Malaterre writes: > > On Mon, Jul 9, 2018 at 4:24 PM Michael Ellerman wrote: > >> > >> Because the allmodconfig logic just sets every symbol to M or Y, it > >> has the effect of alw

Re: [PATCH 1/2] powerpc: Add ppc32_allmodconfig defconfig target

2018-07-10 Thread Mathieu Malaterre
On Mon, Jul 9, 2018 at 4:24 PM Michael Ellerman wrote: > > Because the allmodconfig logic just sets every symbol to M or Y, it > has the effect of always generating a 64-bit config, because > CONFIG_PPC64 becomes Y. > > So to make it easier for folks to test 32-bit code, provide a phony >

Re: powerpc: 32BIT vs. 64BIT (PPC32 vs. PPC64)

2018-07-09 Thread Mathieu Malaterre
On Sun, Jul 8, 2018 at 1:53 PM Michael Ellerman wrote: > > Randy Dunlap writes: > > Hi, > > > > Is there a good way (or a shortcut) to do something like: > > The best I know of is: > > > $ make ARCH=powerpc O=PPC32 [other_options] allmodconfig > > to get a PPC32/32BIT allmodconfig > > $ echo

Re: CONFIG_LD_DEAD_CODE_DATA_ELIMINATION: Section mismatch in reference from the variable via_pmu_driver to the function .init.text:pmu_init()

2018-07-03 Thread Mathieu Malaterre
On Tue, Jul 3, 2018 at 11:40 AM Mathieu Malaterre wrote: > > Hi Nick, > > Would you consider this a bug: > > $ touch drivers/macintosh/via-pmu.c > $ CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=n make ARCH=powerpc > CROSS_COMPILE=powerpc-linux-gnu- > ... > LD v

CONFIG_LD_DEAD_CODE_DATA_ELIMINATION: Section mismatch in reference from the variable via_pmu_driver to the function .init.text:pmu_init()

2018-07-03 Thread Mathieu Malaterre
Hi Nick, Would you consider this a bug: $ touch drivers/macintosh/via-pmu.c $ CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=n make ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- ... LD vmlinux.o MODPOST vmlinux.o WARNING: vmlinux.o(.data+0x216018): Section mismatch in reference from the variable

Re: 83a092cf95f28: powerpc: Link warning for orphan sections

2018-07-03 Thread Mathieu Malaterre
On Tue, Jul 3, 2018 at 9:23 AM Nicholas Piggin wrote: > > On Tue, 3 Jul 2018 09:03:46 +0200 > Mathieu Malaterre wrote: > > > Hi Nick, > > > > I am building my kernel (ppc32) with both > > CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=y and CONFIG_UBSAN=y

83a092cf95f28: powerpc: Link warning for orphan sections

2018-07-03 Thread Mathieu Malaterre
Hi Nick, I am building my kernel (ppc32) with both CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=y and CONFIG_UBSAN=y. This leads to ~316428 warnings such as: + powerpc-linux-gnu-ld -EB -m elf32ppc -Bstatic --orphan-handling=warn --build-id --gc-sections -X -o .tmp_vmlinux1 -T

Re: [PATCH v4 01/11] macintosh/via-pmu: Fix section mismatch warning

2018-07-02 Thread Mathieu Malaterre
On Mon, Jul 2, 2018 at 10:25 AM Finn Thain wrote: > > The pmu_init() function has the __init qualifier, but the ops struct > that holds a pointer to it does not. This causes a build warning. > The driver works fine because the pointer is only dereferenced early. > > The function is so small that

Re: [PATCH] powerpc/xmon: avoid warnings about variables that might be clobbered by ‘longjmp’

2018-06-26 Thread Mathieu Malaterre
On Sat, Jun 23, 2018 at 9:47 PM Segher Boessenkool wrote: > > On Sat, Jun 23, 2018 at 06:59:27PM +0200, christophe leroy wrote: > > > > > > Le 22/06/2018 à 21:27, Mathieu Malaterre a écrit : > > >Move initialization of variables after data definitions. This silen

Re: [PATCH] powerpc/mm: remove warning about ‘type’ being set

2018-06-26 Thread Mathieu Malaterre
On Sat, Jun 23, 2018 at 7:12 PM christophe leroy wrote: > > > > Le 22/06/2018 à 21:27, Mathieu Malaterre a écrit : > > ‘type’ is only used when CONFIG_DEBUG_HIGHMEM is set. So add a possibly > > unused tag to variable. Remove warning treated as error with W=1: > > &g

[PATCH] powerpc/mm: remove warning about ‘type’ being set

2018-06-22 Thread Mathieu Malaterre
‘type’ is only used when CONFIG_DEBUG_HIGHMEM is set. So add a possibly unused tag to variable. Remove warning treated as error with W=1: arch/powerpc/mm/highmem.c:59:6: error: variable ‘type’ set but not used [-Werror=unused-but-set-variable] Signed-off-by: Mathieu Malaterre --- arch

[PATCH] powerpc/xmon: avoid warnings about variables that might be clobbered by ‘longjmp’

2018-06-22 Thread Mathieu Malaterre
be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered] Signed-off-by: Mathieu Malaterre --- arch/powerpc/xmon/xmon.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index 47166ad2a669..982848c784ff 100644 --- a/arch

[PATCH] powerpc: include setup.h header file to fix warnings

2018-06-22 Thread Mathieu Malaterre
=missing-prototypes] arch/powerpc/kernel/setup_32.c:238:13: error: no previous prototype for ‘setup_power_save’ [-Werror=missing-prototypes] arch/powerpc/kernel/setup_32.c:253:13: error: no previous prototype for ‘initialize_cache_info’ [-Werror=missing-prototypes] Signed-off-by: Mathieu Malaterre

Re: [PATCH] powerpc/mm: fix always true/false warning in slice.c

2018-06-22 Thread Mathieu Malaterre
On Fri, Jun 22, 2018 at 3:49 PM Christophe Leroy wrote: > > This patch fixes the following warnings (obtained with make W=1). > > arch/powerpc/mm/slice.c: In function 'slice_range_to_mask': > arch/powerpc/mm/slice.c:73:12: error: comparison is always true due to > limited range of data type

Re: [PATCH v2 07/19] powerpc/powermac: Make some functions static

2018-06-22 Thread Mathieu Malaterre
This one should also be good to go. On Wed, Mar 28, 2018 at 9:39 PM Mathieu Malaterre wrote: > > These functions can all be static, make it so. Fix warnings treated as > errors with W=1: > > arch/powerpc/platforms/powermac/pci.c:1022:6: error: no previous prototype > for ‘p

Re: [PATCH 16/19] powerpc/powermac: Add missing include of header pmac.h

2018-06-22 Thread Mathieu Malaterre
This one is also ok. On Thu, Mar 22, 2018 at 9:21 PM Mathieu Malaterre wrote: > > The header `pmac.h` was not included, leading to the following warnings, > treated as error with W=1: > > arch/powerpc/platforms/powermac/time.c:69:13: error: no previous prototype > f

Re: [PATCH v3 03/19] powerpc: Move `path` variable inside DEBUG_PROM

2018-06-22 Thread Mathieu Malaterre
This one should be ok. On Wed, Apr 4, 2018 at 10:08 PM Mathieu Malaterre wrote: > > Add gcc attribute unused for two variables. Fix warnings treated as errors > with W=1: > > arch/powerpc/kernel/prom_init.c:1388:8: error: variable ‘path’ set but not > used [-Werror=unuse

Re: [PATCH v2 02/19] powerpc/powermac: Mark variable x as unused

2018-06-22 Thread Mathieu Malaterre
On Thu, Mar 29, 2018 at 6:09 PM LEROY Christophe wrote: > > Mathieu Malaterre a écrit : > > > Since the value of x is never intended to be read, remove it. Fix warning > > treated as error with W=1: > > > > arch/powerpc/platforms/powermac/udbg_scc.c:

Re: [PATCH v3] powerpc/32: Remove left over function prototypes

2018-06-22 Thread Mathieu Malaterre
On Thu, Jun 21, 2018 at 1:27 PM Michael Ellerman wrote: > > Mathieu Malaterre writes: > > > In commit 4aea909eeba3 ("powerpc: Add missing prototypes in setup_32.c") > > I don't have that commit ^ ? > > That might be because I squashed some of your fix

[PATCH v3] powerpc/32: Remove left over function prototypes

2018-06-20 Thread Mathieu Malaterre
40:19: error: static declaration of ‘ppc_setup_l3cr’ follows non-static declaration arch/powerpc/kernel/setup_32.c:186:19: error: static declaration of ‘ppc_init’ follows non-static declaration Signed-off-by: Mathieu Malaterre --- v3: correct subject line to be less confusing v2: Previous version co

arch/powerpc/boot/addnote.c:75:47: warning: right shift count >= width of type [-Wshift-count-overflow]

2018-06-20 Thread Mathieu Malaterre
Hi there, For some reason I am seeing some new warning (W=0) on some old code. Anyone else seeing them ? HOSTCC arch/powerpc/boot/addnote arch/powerpc/boot/addnote.c: In function ‘main’: arch/powerpc/boot/addnote.c:75:47: warning: right shift count >= width of type [-Wshift-count-overflow]

Re: [PATCH 1/3] [v2] powerpc: mac: fix rtc read/write functions

2018-06-20 Thread Mathieu Malaterre
> The same code exists in arch/m68k/ and is patched in an identical way now > in a separate patch. > > Fixes: 5bfd643583b2 ("powerpc: use time64_t in read_persistent_clock") > Reported-by: Mathieu Malaterre > Reported-by: Andreas Schwab > Signed-off-by: Arnd Bergmann Doin

  1   2   3   4   >