Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Matthias Brugger
default: dev_err_ratelimited(dev->dev, "tx urb failed: %d\n", urb->status); - fallthrough; - case 0: break; } Reviewed-by: Matthias Brugger

Re: [PATCHv2] kernel/crash: make parse_crashkernel()'s return value more indicant

2019-04-24 Thread Matthias Brugger
On 24/04/2019 08:33, Pingfan Liu wrote: > At present, both return and crash_size should be checked to guarantee the > success of parse_crashkernel(). > > Take a close look at the cases, which causes crash_size=0. Beside syntax > error, three cases cause parsing to get crash_size=0. > -1st. in

Re: [PATCH v1 6/9] arm64: kexec: no need to ClearPageReserved()

2018-12-16 Thread Matthias Brugger
; Cc: Michal Hocko > Cc: Matthew Wilcox > Acked-by: James Morse > Signed-off-by: David Hildenbrand Reviewed-by: Matthias Brugger > --- > arch/arm64/kernel/machine_kexec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/kernel/machine_kexec.c &

Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem

2018-02-20 Thread Matthias Brugger
b/drivers/watchdog/mtk_wdt.c > index 7ed417a765c7..498e7d4e1b66 100644 > --- a/drivers/watchdog/mtk_wdt.c > +++ b/drivers/watchdog/mtk_wdt.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0+ > /* > * Mediatek Watchdog Driver > * > @@ -5,16 +6,6 @@ &g

Re: [PATCH] soc: Convert to using %pOF instead of full_name

2017-07-19 Thread Matthias Brugger
ood <o...@buserror.net> Cc: Qiang Zhao <qiang.z...@nxp.com> Cc: Matthias Brugger <matthias@gmail.com> Cc: Simon Horman <ho...@verge.net.au> Cc: Magnus Damm <magnus.d...@gmail.com> Cc: Kukjin Kim <kg...@kernel.org> Cc: Krzysztof Kozlowski <k...@kernel.org> Cc: Javi

Re: [RFC 02/11] i2c: add quirk checks to core

2015-01-12 Thread Matthias Brugger
2015-01-09 18:21 GMT+01:00 Wolfram Sang w...@the-dreams.de: Let the core do the checks if HW quirks prevent a transfer. Saves code from drivers and adds consistency. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/i2c-core.c | 53