Please add powerpc topic/kdump-hotplug branch to linux-next

2024-04-23 Thread Michael Ellerman
Hi Stephen, Can you please add the topic/kdump-hotplug branch of the powerpc tree to linux-next. It contains a series that touches generic kexec code as well as x86 and powerpc code. The hope is to have to get it merged for v6.10, so it should go along with the powerpc next branch in the merge

Re: [PATCH] selftests/powerpc: Install tests in sub-directories

2024-04-22 Thread Michael Ellerman
Michael Ellerman writes: > The sources for the powerpc selftests are arranged into sub-directories. > However when the tests are built and installed, the sub-directories are > squashed, losing the structure. This is missing a preparatory patch, new version coming. cheers

[PATCH v2 2/2] selftests/powerpc: Install tests in sub-directories

2024-04-22 Thread Michael Ellerman
with: $ ./run_kselftest.sh -c powerpc After the change it's necessary to pass a regex that matches all powerpc entries, eg: $ ./run_kselftest.sh -c "powerpc.*" The latter form also works before and after the change. Signed-off-by: Michael Ellerman --- tools/testing/selftests/powerpc/Makefi

[PATCH v2 1/2] selftests/powerpc: Convert pmu Makefile to for loop style

2024-04-22 Thread Michael Ellerman
The pmu Makefile has grown more sub directories over the years. Rather than open coding the rules for each subdir, use for loops. Signed-off-by: Michael Ellerman --- tools/testing/selftests/powerpc/pmu/Makefile | 43 ++-- 1 file changed, 22 insertions(+), 21 deletions(-) v2

[PATCH] selftests/powerpc: Install tests in sub-directories

2024-04-22 Thread Michael Ellerman
with: $ ./run_kselftest.sh -c powerpc After the change it's necessary to pass a regex that matches all powerpc entries, eg: $ ./run_kselftest.sh -c "powerpc.*" The latter form also works before and after the change. Signed-off-by: Michael Ellerman --- tools/testing/selftests/powerpc/Makefi

[PATCH] powerpc: Mark memory_limit as initdata

2024-04-22 Thread Michael Ellerman
The `memory_limit` variable should only be used during boot, enforce that by marking it initdata. Signed-off-by: Michael Ellerman --- arch/powerpc/mm/mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c index 3a440004b97d

Re: [PATCH] powerpc: Split PAGE_SHIFT/SIZE into vdso/page.h

2024-04-22 Thread Michael Ellerman
Michael Ellerman writes: > The VDSO needs PAGE_SHIFT/SIZE defined, so it includes asm/page.h. For the archives, this was superseeded by Arnd's rework: https://lore.kernel.org/all/20240320180228.136371-1-a...@kernel.org/ cheers

Re: [PATCH] powerpc/iommu: Refactor spapr_tce_platform_iommu_attach_dev()

2024-04-22 Thread Michael Ellerman
On Thu, 15 Feb 2024 07:52:32 -0600, Shivaprasad G Bhat wrote: > The patch makes the iommu_group_get() call only when using it > thereby avoiding the unnecessary get & put for domain already > being set case. > > Applied to powerpc/fixes. [1/1] powerpc/iommu: Refactor

Re: [PATCH] powerpc/crypto/chacha-p10: Fix failure on non Power10

2024-04-22 Thread Michael Ellerman
On Fri, 29 Mar 2024 00:02:00 +1100, Michael Ellerman wrote: > The chacha-p10-crypto module provides optimised chacha routines for > Power10. It also selects CRYPTO_ARCH_HAVE_LIB_CHACHA which says it > provides chacha_crypt_arch() to generic code. > > Notably the module n

Re: [PATCH v2] selftests/powerpc/papr-vpd: Fix missing variable initialization

2024-04-22 Thread Michael Ellerman
On Thu, 04 Apr 2024 17:02:09 -0500, Nathan Lynch wrote: > The "close handle without consuming VPD" testcase has inconsistent > results because it fails to initialize the location code object it > passes to ioctl() to create a VPD handle. Initialize the location code > to the empty string as

Re: (subset) [PATCH 00/34] address all -Wunused-const warnings

2024-04-22 Thread Michael Ellerman
On Wed, 03 Apr 2024 10:06:18 +0200, Arnd Bergmann wrote: > Compilers traditionally warn for unused 'static' variables, but not > if they are constant. The reason here is a custom for C++ programmers > to define named constants as 'static const' variables in header files > instead of using macros

Re: [PATCH] powerpc: Use str_plural() to fix Coccinelle warning

2024-04-22 Thread Michael Ellerman
On Mon, 01 Apr 2024 00:22:50 +0200, Thorsten Blum wrote: > Fixes the following Coccinelle/coccicheck warning reported by > string_choices.cocci: > > opportunity for str_plural(tpc) > > Applied to powerpc/next. [1/1] powerpc: Use str_plural() to fix Coccinelle warning

Re: [PATCH] powerpc/ptdump: Fix walk_vmemmap to also print first vmemmap entry

2024-04-22 Thread Michael Ellerman
On Wed, 17 Apr 2024 20:37:40 +0530, Ritesh Harjani (IBM) wrote: > walk_vmemmap() was skipping the first vmemmap entry pointed by > vmemmap_list pointer itself. This patch fixes that. > > With this we should see the vmemmap entry at 0xc00c for hash > which wasn't getting printed on

Re: [PATCH v2] Add static_key_feature_checks_initialized flag

2024-04-22 Thread Michael Ellerman
On Mon, 08 Apr 2024 05:23:58 +, Nicholas Miehlbradt wrote: > JUMP_LABEL_FEATURE_CHECK_DEBUG used static_key_intialized to determine > whether {cpu,mmu}_has_feature() is used before static keys were > initialized. However, {cpu,mmu}_has_feature() should not be used before > setup_feature_keys()

Re: [PATCH] powerpc: Fix fatal warnings flag for LLVM's integrated assembler

2024-04-22 Thread Michael Ellerman
On Fri, 05 Apr 2024 12:31:22 -0700, Nathan Chancellor wrote: > When building with LLVM_IAS=1, there is an error because > '-fatal-warnings' is not recognized as a valid flag: > > clang: error: unsupported argument '-fatal-warnings' to option '-Wa,' > > Use the double hyphen version of the

Re: [PATCH v5] powerpc: Avoid nmi_enter/nmi_exit in real mode interrupt.

2024-04-22 Thread Michael Ellerman
On Wed, 10 Apr 2024 10:00:06 +0530, Mahesh Salgaonkar wrote: > nmi_enter()/nmi_exit() touches per cpu variables which can lead to kernel > crash when invoked during real mode interrupt handling (e.g. early HMI/MCE > interrupt handler) if percpu allocation comes from vmalloc area. > > Early

Re: [PATCH v2] powerpc: Fix PS3 allmodconfig warning

2024-04-22 Thread Michael Ellerman
On Mon, 01 Apr 2024 16:08:31 +0900, Geoff Levand wrote: > The struct ps3_notification_device in the ps3_probe_thread routine > is too large to be on the stack, causing a warning for an > allmodconfig build with clang. > > Change the struct ps3_notification_device from a variable on the stack > to

Re: [PATCH v1] powerpc: Error on assembly warnings

2024-04-22 Thread Michael Ellerman
On Tue, 26 Mar 2024 15:44:20 +1100, Benjamin Gray wrote: > We currently enable -Werror on the arch/powerpc subtree. However this > only catches C warnings. Assembly warnings are logged, but the make > invocation will still succeed. This can allow incorrect syntax such as > > ori r3, r4, r5 > >

Re: [PATCH v1 1/1] powerpc/52xx: Replace of_gpio.h by proper one

2024-04-22 Thread Michael Ellerman
On Wed, 13 Mar 2024 15:56:45 +0200, Andy Shevchenko wrote: > of_gpio.h is deprecated and subject to remove. > The driver doesn't use it directly, replace it > with what is really being used. > > Applied to powerpc/next. [1/1] powerpc/52xx: Replace of_gpio.h by proper one

Re: [PATCH] powerpc/pseries/iommu: LPAR panics when rebooted with a frozen PE

2024-04-21 Thread Michael Ellerman
Gaurav Batra writes: > You are right. I think, the "reboot" should be replaced with just "boot > up". If there are no other comments, or code changes, I can re-word the > commit message and submit for review. Yeah thanks. The change looks fine, just the change log needs a tweak. It's fine to

Re: [PATCH] powerpc/pseries/iommu: LPAR panics when rebooted with a frozen PE

2024-04-21 Thread Michael Ellerman
Michal Suchánek writes: > Hello, > > On Fri, Apr 19, 2024 at 04:12:46PM +1000, Michael Ellerman wrote: >> Gaurav Batra writes: >> > At the time of LPAR reboot, partition firmware provides Open Firmware >> > property ibm,dma-window for the PE. This property is pr

Re: [PATCH 1/6] driver core: Add device_show_string() helper for sysfs attributes

2024-04-21 Thread Michael Ellerman
re.c | 9 + > include/linux/device.h | 15 +++ > 3 files changed, 24 insertions(+), 10 deletions(-) Acked-by: Michael Ellerman (powerpc) cheers

[GIT PULL] Please pull powerpc/linux.git powerpc-6.9-3 tag

2024-04-19 Thread Michael Ellerman
Gunthorpe, Michal Suchánek, Nathan Lynch, Shivaprasad G Bhat. - -- Michael Ellerman (1): powerpc/crypto/chacha-p10: Fix failure on non Power10 Nathan Lynch (1): selftests/powerpc/papr-vpd: Fix missing variable initialization

[PATCH] powerpc/dart: Drop unnecessary call to kmemleak_no_scan()

2024-04-19 Thread Michael Ellerman
ng. Given that kmemleak_alloc_phys() is ignoring the allocation to begin with, there's no need to call kmemleak_no_scan() at all, which avoids the warning. Reported-by: Erhard Furtner Closes: https://lore.kernel.org/all/bug-216156-206...@https.bugzilla.kernel.org%2F/ Signed-off-by: Michael Ellerman --- ar

Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup

2024-04-19 Thread Michael Ellerman
Chris Packham writes: > On 16/04/24 08:54, Andi Shyti wrote: >> Hi Abhinav, >> >>> /* Enable I2C interrupts for mpc5121 */ >>> - node_ctrl = of_find_compatible_node(NULL, NULL, >>> - "fsl,mpc5121-i2c-ctrl"); >>> + struct device_node *node_ctrl

Re: [PATCH] powerpc/pseries/iommu: LPAR panics when rebooted with a frozen PE

2024-04-19 Thread Michael Ellerman
Gaurav Batra writes: > At the time of LPAR reboot, partition firmware provides Open Firmware > property ibm,dma-window for the PE. This property is provided on the PCI > bus the PE is attached to. AFAICS you're actually describing a bug that happens during boot *up*? Describing it as "reboot"

Re: [PATCH] powerpc: drop port I/O helpers for CONFIG_HAS_IOPORT=n

2024-04-18 Thread Michael Ellerman
Michael Ellerman writes: > "Arnd Bergmann" writes: >> On Thu, Apr 18, 2024, at 08:26, Michael Ellerman wrote: >>> Arnd Bergmann writes: >> >>> @@ -692,6 +692,7 @@ static inline void name at >>> \ >&

Re: [PATCH net] MAINTAINERS: eth: mark IBM eHEA as an Orphan

2024-04-18 Thread Michael Ellerman
David Christensen > Reviewed-by: Pradeep Satyanarayana > --- > MAINTAINERS | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Acked-by: Michael Ellerman (powerpc) cheers > diff --git a/MAINTAINERS b/MAINTAINERS > index b5b89687680b..bcbbc240e51d 100644 > --- a/MAINTAINERS &

Re: [PATCH] powerpc: drop port I/O helpers for CONFIG_HAS_IOPORT=n

2024-04-18 Thread Michael Ellerman
"Arnd Bergmann" writes: > On Thu, Apr 18, 2024, at 08:26, Michael Ellerman wrote: >> Arnd Bergmann writes: > >> @@ -692,6 +692,7 @@ static inline void name at >> \ >> #define writesw writesw >> #define w

Re: [PATCH] powerpc: drop port I/O helpers for CONFIG_HAS_IOPORT=n

2024-04-18 Thread Michael Ellerman
Michael Ellerman writes: > Arnd Bergmann writes: >> From: Arnd Bergmann >> >> Calling inb()/outb() on powerpc when CONFIG_PCI is disabled causes >> a NULL pointer dereference, which is bad for a number of reasons. >> >> After my patch to turn on -Werror i

Re: [PATCH] powerpc: drop port I/O helpers for CONFIG_HAS_IOPORT=n

2024-04-18 Thread Michael Ellerman
Arnd Bergmann writes: > From: Arnd Bergmann > > Calling inb()/outb() on powerpc when CONFIG_PCI is disabled causes > a NULL pointer dereference, which is bad for a number of reasons. > > After my patch to turn on -Werror in linux-next, this caused a > compiler-time warning with clang: > > In

Re: [PATCH v2 RESEND 0/5] sched/vtime: vtime.h headers cleanup

2024-04-17 Thread Michael Ellerman
Frederic Weisbecker writes: > Le Wed, Apr 10, 2024 at 05:09:43PM +0200, Alexander Gordeev a écrit : >> Hi All, >> >> There are no changes since the last post, just a re-send. >> >> v2: >> - patch 4: commit message reworded (Heiko) >> - patch 5: vtime.h is removed from Kbuild scripts (PowerPC

Re: [0/2] powerpc/powernv/vas: Adjustments for two function implementations

2024-04-16 Thread Michael Ellerman
Markus Elfring writes: >> A few update suggestions were taken into account >> from static source code analysis. >> >> Markus Elfring (2): > > I would appreciate a bit more information about the reasons > why this patch series was rejected. > > >> One function call less in vas_window_alloc()

Re: [PATCH 1/3] x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n

2024-04-16 Thread Michael Ellerman
Sean Christopherson writes: > On Mon, Apr 15, 2024, Geert Uytterhoeven wrote: >> On Sat, Apr 13, 2024 at 11:38 AM Michael Ellerman >> wrote: >> > Michael Ellerman writes: >> > > Stephen Rothwell writes: >> > ... >> > >> On Tue, 9

Re: [PATCH v2] KVM: PPC: Book3S HV nestedv2: Cancel pending DEC exception

2024-04-15 Thread Michael Ellerman
Vaibhav Jain writes: > This reverts commit 180c6b072bf3 ("KVM: PPC: Book3S HV nestedv2: Do not > cancel pending decrementer exception") [1] which prevented canceling a > pending HDEC exception for nestedv2 KVM guests. It was done to avoid > overhead of a H_GUEST_GET_STATE hcall to read the 'DEC

Re: [PATCH] bug: Fix no-return-statement warning with !CONFIG_BUG

2024-04-14 Thread Michael Ellerman
"Arnd Bergmann" writes: > On Thu, Apr 11, 2024, at 11:27, Adrian Hunter wrote: >> On 11/04/24 11:22, Christophe Leroy wrote: >>> Le 11/04/2024 à 10:12, Christophe Leroy a écrit : Looking at the report, I think the correct fix should be to use BUILD_BUG() instead of BUG() >>> >>>

Re: [RFC PATCH] powerpc: Optimise barriers for fully ordered atomics

2024-04-13 Thread Michael Ellerman
Nicholas Piggin writes: > "Fully ordered" atomics (RMW that return a value) are said to have a > full barrier before and after the atomic operation. This is implemented > as: > > hwsync > larx > ... > stcx. > bne- > hwsync > > This is slow on POWER processors because hwsync and stcx.

Re: [PATCH 1/3] x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n

2024-04-13 Thread Michael Ellerman
Michael Ellerman writes: > Stephen Rothwell writes: ... >> On Tue, 9 Apr 2024 10:51:05 -0700 Sean Christopherson >> wrote: ... >>> diff --git a/kernel/cpu.c b/kernel/cpu.c >>> index 8f6affd051f7..07ad53b7f119 100644 >>> --- a/kernel/cpu.c >>>

Re: [PATCH 1/3] x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n

2024-04-13 Thread Michael Ellerman
Stephen Rothwell writes: > Hi Sean, > > I noticed this commit in linux-next. > > On Tue, 9 Apr 2024 10:51:05 -0700 Sean Christopherson > wrote: >> >> Initialize cpu_mitigations to CPU_MITIGATIONS_OFF if the kernel is built >> with CONFIG_SPECULATION_MITIGATIONS=n, as the help text quite

Re: [PATCH 1/1] Replace macro "ARCH_HAVE_EXTRA_ELF_NOTES" with kconfig

2024-04-12 Thread Michael Ellerman
lasubramanian > --- > arch/Kconfig | 9 + > arch/powerpc/Kconfig | 1 + > arch/powerpc/include/asm/elf.h | 2 -- > include/linux/elf.h| 2 +- > 4 files changed, 11 insertions(+), 3 deletions(-) Acked-by: Michael Ellerman (powerp

Re: linux-next: duplicate patch in the driver-core.current tree

2024-04-11 Thread Michael Ellerman
Stephen Rothwell writes: > Hi all, > > The following commit is also in the powerpc-fixes tree as a different > commit (but the same patch): > > 156539fd6501 ("Documentation: embargoed-hardware-issues.rst: Add myself for > Power") > > This is commit > > 36627111b568 ("Documentation:

Re: [PATCH 2/2] MAINTAINERS: Make cxl obsolete

2024-04-10 Thread Michael Ellerman
Christophe Leroy writes: > Le 09/04/2024 à 06:37, Michael Ellerman a écrit : >> Andrew Donnellan writes: >>> The cxl driver is no longer actively maintained and we intend to remove it >>> in a future kernel release. Change its status to obsolete, and update the

Re: [PATCH] powerpc/eeh: Permanently disable the removed device

2024-04-09 Thread Michael Ellerman
Hi Ganesh, Ganesh Goudar writes: > When a device is hot removed on powernv, the hotplug > driver clears the device's state. However, on pseries, > if a device is removed by phyp after reaching the error > threshold, the kernel remains unaware, leading to the > device not being torn down. This

Re: [PATCH] powerpc: Fix fatal warnings flag for LLVM's integrated assembler

2024-04-09 Thread Michael Ellerman
Nathan Chancellor writes: > When building with LLVM_IAS=1, there is an error because > '-fatal-warnings' is not recognized as a valid flag: > > clang: error: unsupported argument '-fatal-warnings' to option '-Wa,' > > Use the double hyphen version of the flag, '--fatal-warnings', which > works

Re: [PATCH v2 4/7] powerpc: mm: accelerate pagefault when badaccess

2024-04-09 Thread Michael Ellerman
a pain to integrate into this series. So anyway, if the series goes ahead: Acked-by: Michael Ellerman (powerpc) cheers > diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c > index 53335ae21a40..215690452495 100644 > --- a/arch/powerpc/mm/fault.c > +++ b/arch/powerpc/mm/f

Re: [PATCH] powerpc/pseries: Enforce hcall result buffer validity and size

2024-04-09 Thread Michael Ellerman
Nathan Lynch via B4 Relay writes: > From: Nathan Lynch > > plpar_hcall(), plpar_hcall9(), and related functions expect callers to > provide valid result buffers of certain minimum size. Currently this > is communicated only through comments in the code and the compiler has > no idea. > > For

Re: [PATCH] powerpc/pseries: remove returning ENODEV when uevent is triggered

2024-04-09 Thread Michael Ellerman
Hi Lidong, Thanks for the patch. I'm not an expert on udev etc. so apologies if any of these questions are stupid. Lidong Zhong writes: > We have noticed the following nuisance messages during boot > > [7.120610][ T1060] vio vio: uevent: failed to send synthetic uevent > [7.122281][

Re: [PATCH 2/2] MAINTAINERS: Make cxl obsolete

2024-04-08 Thread Michael Ellerman
Andrew Donnellan writes: > The cxl driver is no longer actively maintained and we intend to remove it > in a future kernel release. Change its status to obsolete, and update the > sysfs ABI documentation accordingly. > > Signed-off-by: Andrew Donnellan > --- > Documentation/ABI/{testing =>

Re: [FSL P50x0] Kernel 6.9-rc1 compiling issue

2024-04-08 Thread Michael Ellerman
Christophe Leroy writes: > Hi Christian, hi Hari, > > Le 04/04/2024 à 19:44, Christian Zigotzky a écrit : >> Shall we use CONFIG_CRASH_DUMP to get int crashing_cpu = -1;? >> >> Further information: >> https://lists.ozlabs.org/pipermail/linuxppc-dev/2024-March/269985.html >>

Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-04-08 Thread Michael Ellerman
ch/powerpc/kvm/book3s_hv.c | 1 - > arch/powerpc/kvm/book3s_pr.c | 7 > arch/powerpc/kvm/e500_mmu_host.c | 6 --- LGTM. Acked-by: Michael Ellerman (powerpc) cheers

Re: [PATCH 2/2] treewide: Use sysfs_bin_attr_simple_read() helper

2024-04-08 Thread Michael Ellerman
; > + attr->read = sysfs_bin_attr_simple_read; > attr->private = __va(vals[0]); > attr->size = vals[1]; I gave it a quick boot and checked I could still read the attributes, everything seems fine. Acked-by: Michael Ellerman (powerpc) cheers

Re: [PATCH v2] Add static_key_feature_checks_initialized flag

2024-04-08 Thread Michael Ellerman
Nicholas Miehlbradt writes: > JUMP_LABEL_FEATURE_CHECK_DEBUG used static_key_intialized to determine > whether {cpu,mmu}_has_feature() is used before static keys were > initialized. However, {cpu,mmu}_has_feature() should not be used before > setup_feature_keys() is called but

Re: [PATCH v2] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-07 Thread Michael Ellerman
Finn Thain writes: > On Fri, 5 Apr 2024, Michael Ellerman wrote: > >> I assume you have tested this on an actual pmac, as well as qemu? >> > > I tested the patched driver and its console functionality using Zilog SCC > hardware in a Mac IIci, as well as

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-07 Thread Michael Ellerman
Finn Thain writes: > On Fri, 5 Apr 2024, Michael Ellerman wrote: >> >> > > --- >> >> > (here is a good location for Cc:) >> >> >> >> Documentation/process/submitting-patches.rst indicats that it should >> >> be above th

Re: [PATCH] KVM: PPC: Book3S HV nestedv2: Cancel pending HDEC exception

2024-04-07 Thread Michael Ellerman
Thorsten Leemhuis writes: > On 05.04.24 05:20, Michael Ellerman wrote: >> "Linux regression tracking (Thorsten Leemhuis)" >> writes: >>> Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting >>> for once, to make this easily accessib

Re: [PATCH] MAINTAINERS: Drop Li Yang as their email address stopped working

2024-04-07 Thread Michael Ellerman
Uwe Kleine-König writes: > When sending a patch to (among others) Li Yang the nxp MTA replied that > the address doesn't exist and so the mail couldn't be delivered. The > error code was 550, so at least technically that's not a temporal issue. > > Signed-off-by: Uwe Kleine-König > --- > Hello,

Re: [PATCH -next 1/3] powerpc: boot: Fix a typo in partial_decompress() comment

2024-04-07 Thread Michael Ellerman
Yang Li writes: > This commit adds kernel-doc style comments with complete parameter > descriptions for the function partial_decompress(). This change log doesn't match the subject or the patch. cheers > Signed-off-by: Yang Li > --- > arch/powerpc/boot/decompress.c | 2 +- > 1 file changed,

Re: [PATCH] KVM: PPC: Book3S HV nestedv2: Cancel pending HDEC exception

2024-04-04 Thread Michael Ellerman
"Linux regression tracking (Thorsten Leemhuis)" writes: > Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting > for once, to make this easily accessible to everyone. > > Was this regression ever resolved? Doesn't look like it, but maybe I > just missed something. I'm not sure

Re: [PATCH v2] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-04 Thread Michael Ellerman
Finn Thain writes: > The mitigation was intended to stop the irq completely. That may be > better than a hard lock-up but it turns out that you get a crash anyway > if you're using pmac_zilog as a serial console: > > ttyPZ0: pmz: rx irq flood ! > BUG: spinlock recursion on CPU#0, swapper/0 > >

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-04 Thread Michael Ellerman
Andy Shevchenko writes: > On Thu, Apr 4, 2024 at 2:57 AM Finn Thain wrote: >> On Thu, 4 Apr 2024, Andy Shevchenko wrote: > >> > > Cc: Benjamin Herrenschmidt >> > > Cc: Michael Ellerman >> > > Cc: Nicholas Piggin >> > > Cc: Christoph

Re: [PATCH v1 1/1] powerpc/52xx: Replace of_gpio.h by proper one

2024-04-04 Thread Michael Ellerman
Andy Shevchenko writes: > On Wed, Mar 13, 2024 at 03:56:45PM +0200, Andy Shevchenko wrote: >> of_gpio.h is deprecated and subject to remove. >> The driver doesn't use it directly, replace it >> with what is really being used. > > Any comments on this? No comment :) I'll take it for 6.10, or do

Re: [PATCH v3 15/15] powerpc: Add support for suppressing warning backtraces

2024-04-03 Thread Michael Ellerman
fine but a virtual variable). > > Tested-by: Linux Kernel Functional Testing > Acked-by: Dan Carpenter > Cc: Michael Ellerman > Signed-off-by: Guenter Roeck > --- > v2: > - Rebased to v6.9-rc1 > - Added Tested-by:, Acked-by:, and Reviewed-by: tags > - Introduced KUNIT_SUPPRESS

Re: [PATCH] serial: pmac_zilog: Drop usage of platform_driver_probe()

2024-04-02 Thread Michael Ellerman
t; > Signed-off-by: Uwe Kleine-König > --- > drivers/tty/serial/pmac_zilog.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) I gave it a quick spin in qemu, no issues. Tested-by: Michael Ellerman cheers > diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/ser

Re: Appropriate liburcu cache line size for Power

2024-04-02 Thread Michael Ellerman
Mathieu Desnoyers writes: > On 2024-03-26 03:19, Michael Ellerman wrote: >> Mathieu Desnoyers writes: >>> In the powerpc architecture support within the liburcu project [1] >>> we have a cache line size defined as 256 bytes with the following >>> comment: &

[PATCH] powerpc/crypto/chacha-p10: Fix failure on non Power10

2024-03-28 Thread Michael Ellerman
/20240315122005.gg20...@kitsune.suse.cz/ Signed-off-by: Michael Ellerman --- arch/powerpc/crypto/chacha-p10-glue.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/crypto/chacha-p10-glue.c b/arch/powerpc/crypto/chacha-p10-glue.c index 74fb86b0d209..7c728755852e 100644

Re: Appropriate liburcu cache line size for Power

2024-03-26 Thread Michael Ellerman
Mathieu Desnoyers writes: > Hi, Hi Mathieu, > In the powerpc architecture support within the liburcu project [1] > we have a cache line size defined as 256 bytes with the following > comment: > > /* Include size of POWER5+ L3 cache lines: 256 bytes */ > #define CAA_CACHE_LINE_SIZE 256 > > I

[GIT PULL] Please pull powerpc/linux.git powerpc-6.9-2 tag

2024-03-22 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull some more powerpc updates for 6.9. These were posted before the merge window but had complicated dependencies and/or conflicts with other content that has gone into 6.9. cheers The following changes since commit

Re: [PATCH linux-next v2 0/3] powerpc/kexec: split CONFIG_CRASH_DUMP out from CONFIG_KEXEC_CORE

2024-03-22 Thread Michael Ellerman
On Mon, 26 Feb 2024 16:00:07 +0530, Hari Bathini wrote: > This patch series is a follow-up to [1] based on discussions at [2] > about additional work needed to get it working on powerpc. > > The first patch in the series makes struct crash_mem available with or > without CONFIG_CRASH_DUMP

Re: [PATCH v2] powerpc: Handle error in mark_rodata_ro() and mark_initmem_nx()

2024-03-22 Thread Michael Ellerman
On Sat, 16 Mar 2024 12:18:21 +0100, Christophe Leroy wrote: > mark_rodata_ro() and mark_initmem_nx() use functions that can > fail like set_memory_nx() and set_memory_ro(), leading to a not > protected kernel. > > In case of failure, panic. > > > [...] Applied to powerpc/next. [1/1] powerpc:

Re: Cannot load wireguard module

2024-03-22 Thread Michael Ellerman
Herbert Xu writes: > On Wed, Mar 20, 2024 at 11:41:32PM +1100, Michael Ellerman wrote: >> >> This diff fixes it for me: > > Yes I think this is the correct fix. Thanks, I'll send a proper patch next week. cheers

[PATCH] Documentation: embargoed-hardware-issues.rst: Add myself for Power

2024-03-22 Thread Michael Ellerman
Unfortunately Anton has left IBM. Add myself as the contact for Power, until someone else volunteers. Signed-off-by: Michael Ellerman --- Documentation/process/embargoed-hardware-issues.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/process/embargoed

Re: [RFC PATCH 1/3] powerpc/pseries/iommu: Bring back userspace view for single level TCE tables

2024-03-21 Thread Michael Ellerman
Jason Gunthorpe writes: > On Tue, Mar 12, 2024 at 01:14:20PM -0500, Shivaprasad G Bhat wrote: >> The commit 090bad39b237a ("powerpc/powernv: Add indirect levels to >> it_userspace") which implemented the tce indirect levels >> support for PowerNV ended up removing the single level support >>

Re: Cannot load wireguard module

2024-03-21 Thread Michael Ellerman
Michal Suchánek writes: > On Wed, Mar 20, 2024 at 11:41:32PM +1100, Michael Ellerman wrote: >> Michal Suchánek writes: >> > On Mon, Mar 18, 2024 at 06:08:55PM +0100, Michal Suchánek wrote: >> >> On Mon, Mar 18, 2024 at 10:50:49PM +1100, Michael Ellerman wrote: &g

Re: [PATCH] vdso: use CONFIG_PAGE_SHIFT in vdso/datapage.h

2024-03-21 Thread Michael Ellerman
clude/asm/bug.h:88:25: note: expanded from macro 'WARN_ON' >88 | int __ret_warn_on = !!(x); \ > |^ > > Cc: Michael Ellerman > Cc: linuxppc-dev@lists.ozlabs.org > Cc: Andy Lutomirski > Cc: Thomas Gleixner > Cc: Vincenzo Frascino > Cc: Anna-Maria Behnsen >

Re: Cannot load wireguard module

2024-03-20 Thread Michael Ellerman
Michal Suchánek writes: > On Mon, Mar 18, 2024 at 06:08:55PM +0100, Michal Suchánek wrote: >> On Mon, Mar 18, 2024 at 10:50:49PM +1100, Michael Ellerman wrote: >> > Michael Ellerman writes: >> > > Michal Suchánek writes: >> > >> Hello, >&

Re: linux-next: manual merge of the powerpc tree with the mm-stable tree

2024-03-18 Thread Michael Ellerman
Christophe Leroy writes: > Le 29/02/2024 à 07:37, Michael Ellerman a écrit : >> Stephen Rothwell writes: >>> Hi all, >>> >>> Today's linux-next merge of the powerpc tree got a conflict in: >>> >>>arch/powerpc/mm/pgtable_32.c >>&g

Re: Cannot load wireguard module

2024-03-18 Thread Michael Ellerman
Michael Ellerman writes: > Michal Suchánek writes: >> Hello, >> >> I cannot load the wireguard module. >> >> Loading the module provides no diagnostic other than 'No such device'. >> >> Please provide maningful diagnostics for loading software-o

Re: [PATCH 00/14] Add support for suppressing warning backtraces

2024-03-17 Thread Michael Ellerman
Guenter Roeck writes: > On 3/14/24 07:37, Guenter Roeck wrote: >> On 3/14/24 06:36, Geert Uytterhoeven wrote: >>> Hi Günter, >>> >>> On Tue, Mar 12, 2024 at 6:03 PM Guenter Roeck wrote: Some unit tests intentionally trigger warning backtraces by passing bad parameters to kernel API

Re: [PATCH v1 1/3] powerpc/code-patching: Test patch_instructions() during boot

2024-03-17 Thread Michael Ellerman
Benjamin Gray writes: > On Mon, 2024-03-18 at 08:38 +1100, Benjamin Gray wrote: >> On Fri, 2024-03-15 at 07:14 +, Christophe Leroy wrote: >> > Le 15/03/2024 à 03:57, Benjamin Gray a écrit : >> > > diff --git a/arch/powerpc/lib/test-code-patching.c >> > >

[GIT PULL] Please pull powerpc/linux.git powerpc-6.9-1 tag

2024-03-15 Thread Michael Ellerman
ation failure in simple_realloc() Madhavan Srinivasan (2): powerpc: Add Power11 architected and raw mode powerpc/perf: Power11 Performance Monitoring support Masahiro Yamada (1): powerpc: remove unused KCSAN_SANITIZE_early_64.o in Makefile Michael Ellerman (22): powerp

Re: Cannot load wireguard module

2024-03-15 Thread Michael Ellerman
Michal Suchánek writes: > Hello, > > I cannot load the wireguard module. > > Loading the module provides no diagnostic other than 'No such device'. > > Please provide maningful diagnostics for loading software-only driver, > clearly there is no particular device needed. Presumably it's just

Re: [PATCH 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files

2024-03-14 Thread Michael Ellerman
Hi Vignesh, Vignesh Balasubramanian writes: > Add a new .note section containing type, size, offset and flags of > every xfeature that is present. > > This information will be used by the debuggers to understand the XSAVE > layout of the machine where the core file is dumped, and to read XSAVE >

Re: [PATCH v7 1/5] net: wan: Add support for QMC HDLC

2024-03-14 Thread Michael Ellerman
Herve Codina writes: > Hi Michael, > > On Thu, 14 Mar 2024 10:05:37 +1100 > Michael Ellerman wrote: > >> Hi Herve, >> >> Herve Codina writes: > .. >> This breaks when building as a module (eg. ppc32_allmodconfig): >> >> In

Re: [PATCH v7 1/5] net: wan: Add support for QMC HDLC

2024-03-13 Thread Michael Ellerman
Hi Herve, Herve Codina writes: > The QMC HDLC driver provides support for HDLC using the QMC (QUICC > Multichannel Controller) to transfer the HDLC data. ... > > diff --git a/drivers/net/wan/fsl_qmc_hdlc.c b/drivers/net/wan/fsl_qmc_hdlc.c > new file mode 100644 > index

Re: [PATCH v3 07/12] powerpc: Use initializer for struct vm_unmapped_area_info

2024-03-13 Thread Michael Ellerman
"Edgecombe, Rick P" writes: > On Wed, 2024-03-13 at 06:44 +, Christophe Leroy wrote: >> I understand from this text that, as agreed, this patch removes the >> pointless/redundant zero-init of individual members. But it is not >> what >> is done, see below ? > > Err, right. I think I decided

Re: [PATCH] boot: simple_alloc: check after increasing memory allocation

2024-03-13 Thread Michael Ellerman
On Mon, 19 Dec 2022 10:18:16 +0800, Li zeming wrote: > The pointer new adds judgment and should help with program robustness. > > Applied to powerpc/next. [1/1] boot: simple_alloc: check after increasing memory allocation

Re: [PATCH] powerpc/32: Curb objtool unannotated intra-function call warning

2024-03-13 Thread Michael Ellerman
On Thu, 15 Dec 2022 17:22:58 +0530, Sathvika Vasireddy wrote: > objtool throws the following warning: > arch/powerpc/kexec/relocate_32.o: warning: objtool: .text+0x2bc: unannotated > intra-function call > > Fix this warning by annotating intra-function call, using > ANNOTATE_INTRA_FUNCTION_CALL

Re: [PATCH v3] powerpc: macio: Make remove callback of macio driver void returned

2024-03-13 Thread Michael Ellerman
On Wed, 01 Feb 2023 22:36:19 +0800, Dawei Li wrote: > Commit fc7a6209d571 ("bus: Make remove callback return void") forces > bus_type::remove be void-returned, it doesn't make much sense for any > bus based driver implementing remove callbalk to return non-void to > its caller. > > This change is

Re: [PATCH] macintosh: adb: make adb_dev_class constant

2024-03-13 Thread Michael Ellerman
On Tue, 05 Mar 2024 17:13:48 -0300, Ricardo B. Marliere wrote: > Since commit 43a7206b0963 ("driver core: class: make class_register() take > a const *"), the driver core allows for struct class to be in read-only > memory, so move the adb_dev_class structure to be declared at build time > placing

Re: [PATCH] powerpc: xor_vmx: Add '-mhard-float' to CFLAGS

2024-03-13 Thread Michael Ellerman
On Sat, 27 Jan 2024 11:07:43 -0700, Nathan Chancellor wrote: > arch/powerpc/lib/xor_vmx.o is built with '-msoft-float' (from the main > powerpc Makefile) and '-maltivec' (from its CFLAGS), which causes an > error when building with clang after a recent change in main: > > error: option

Re: [PATCH v2 1/5] of: Add of_machine_compatible_match()

2024-03-13 Thread Michael Ellerman
On Thu, 14 Dec 2023 21:31:48 +1100, Michael Ellerman wrote: > We have of_machine_is_compatible() to check if a machine is compatible > with a single compatible string. However some code is able to support > multiple compatible boards, and so wants to check for one of many > compat

Re: [PATCH] powerpc/irq: Allow softirq to hardirq stack transition

2024-03-13 Thread Michael Ellerman
On Thu, 30 Nov 2023 23:50:45 +1100, Michael Ellerman wrote: > Allow a transition from the softirq stack to the hardirq stack when > handling a hardirq. Doing so means a hardirq received while deep in > softirq processing is less likely to cause a stack overflow of the > s

Re: [PATCH] powerpc/boot: Only free if realloc() succeeds

2024-03-13 Thread Michael Ellerman
On Thu, 29 Feb 2024 22:51:49 +1100, Michael Ellerman wrote: > simple_realloc() frees the original buffer (ptr) even if the > reallocation failed. > > Fix it to behave like standard realloc() and only free the original > buffer if the reallocation succeeded. > > > [...]

Re: [PATCH] powerpc: Add allmodconfig for all 32-bit sub-arches

2024-03-13 Thread Michael Ellerman
On Thu, 29 Feb 2024 22:41:08 +1100, Michael Ellerman wrote: > 32-bit powerpc kernels can be built for one of 5 sub-arches, see > Kconfig.cputype: > > PPC_BOOK3S_32: "512x/52xx/6xx/7xx/74xx/82xx/83xx/86xx" > PPC_85xx: "Freescale 85xx" > PPC_8xx: "

Re: [PATCH] powerpc: Enable support for 32 bit MSI-X vectors

2024-03-13 Thread Michael Ellerman
On Wed, 17 Jan 2024 15:46:32 -0600, Brian King wrote: > Some devices are not capable of addressing 64 bits > via DMA, which includes MSI-X vectors. This allows > us to ensure these devices use MSI-X vectors in > 32 bit space. > > Applied to powerpc/next. [1/1] powerpc: Enable support for 32

Re: [PATCH] powerpc/kprobes: Handle error returned by set_memory_rox()

2024-03-13 Thread Michael Ellerman
On Fri, 16 Feb 2024 11:13:28 +0100, Christophe Leroy wrote: > set_memory_rox() can fail. > > In case it fails, free allocated memory and return NULL. > > Applied to powerpc/next. [1/1] powerpc/kprobes: Handle error returned by set_memory_rox()

Re: [PATCH] powerpc/85xx: Make some pic_init functions static

2024-03-13 Thread Michael Ellerman
On Thu, 29 Feb 2024 22:42:16 +1100, Michael Ellerman wrote: > These functions can all be static, make them so, which also fixes no > previous prototype warnings. > > Applied to powerpc/next. [1/1] powerpc/85xx: Make some pic_init functions static https://git.kernel.o

Re: [PATCH 1/5] powerpc/64s: Move dcbt/dcbtst sequence into a macro

2024-03-13 Thread Michael Ellerman
On Thu, 29 Feb 2024 23:25:17 +1100, Michael Ellerman wrote: > There's an almost identical code sequence to specify load/store access > hints in __copy_tofrom_user_power7(), copypage_power7() and > memcpy_power7(). > > Move the sequence into a common macro, which is passed the reg

Re: [PATCH 1/3] powerpc/embedded6xx: Fix no previous prototype for avr_uart_send() etc.

2024-03-13 Thread Michael Ellerman
On Tue, 05 Mar 2024 23:34:08 +1100, Michael Ellerman wrote: > Move the prototypes into mpc10x.h which is included by all the relevant > C files, fixes: > > arch/powerpc/platforms/embedded6xx/ls_uart.c:59:6: error: no previous > prototype for 'avr_uart_configure' > arch

Re: (subset) [PATCH 1/3] powerpc/64s: Fix get_hugepd_cache_index() build failure

2024-03-13 Thread Michael Ellerman
On Wed, 06 Mar 2024 23:58:51 +1100, Michael Ellerman wrote: > With CONFIG_BUG=n, the 64-bit Book3S build fails with: > > arch/powerpc/include/asm/book3s/64/pgtable-64k.h: In function > 'get_hugepd_cache_index': > arch/powerpc/include/asm/book3s/64/pgtable-64k.h:51:1: e

  1   2   3   4   5   6   7   8   9   10   >