Re: (subset) [PATCH 00/17] -Wmissing-prototype warning fixes

2023-08-28 Thread Michael Schmitz
Hi Geert, Am 28.08.2023 um 18:42 schrieb Geert Uytterhoeven: On Sat, Aug 26, 2023 at 12:44 AM Michael Schmitz wrote: (Incidentally - did you ever publish the m68k full history tree anywhere in git?) You mean the gitified version of the Linux/m68k CVS tree Ralf created for me because my

Re: (subset) [PATCH 00/17] -Wmissing-prototype warning fixes

2023-08-25 Thread Michael Schmitz
Hi Geert, Am 25.08.23 um 19:39 schrieb Geert Uytterhoeven: > Hi Michael, > > On Fri, Aug 25, 2023 at 3:31 AM Michael Schmitz wrote: >> On 25/08/23 13:12, Martin K. Petersen wrote: >>> [11/17] scsi: gvp11: remove unused gvp11_setup() function >>>

Re: (subset) [PATCH 00/17] -Wmissing-prototype warning fixes

2023-08-24 Thread Michael Schmitz
Hi Martin, Arnd, On 25/08/23 13:12, Martin K. Petersen wrote: On Thu, 10 Aug 2023 16:19:18 +0200, Arnd Bergmann wrote: Most of the patches I sent so far for the -Wmissing-prototype warnings have made it into linux-next now. There are a few that I'm resending now as nobody has picked them up,

Re: [FSL P50x0] [PASEMI] The Access to partitions on disks with an Amiga partition table doesn't work anymore after the block updates 2023-06-23

2023-06-30 Thread Michael Schmitz
Hi Martin, Christian, Am 01.07.2023 um 09:17 schrieb Michael Schmitz: By reverting my patch, you just reintroduce the old bug, which could result in mis-parsing the partition table in a way that is not detected by inane values of partition sizes as above, and as far as I recall this bug

Re: [FSL P50x0] [PASEMI] The Access to partitions on disks with an Amiga partition table doesn't work anymore after the block updates 2023-06-23

2023-06-30 Thread Michael Schmitz
Hi Martin, Am 30.06.2023 um 20:35 schrieb Martin Steigerwald: Hi Michael, hi Christian. Michael Schmitz - 29.06.23, 22:27:59 CEST: […] On 29/06/23 16:59, Christian Zigotzky wrote: Hello, The access to partitions on disks with an Amiga partition table (via the Rigid Disk Block RDB) doesn't

Re: [FSL P50x0] [PASEMI] The Access to partitions on disks with an Amiga partition table doesn't work anymore after the block updates 2023-06-23

2023-06-29 Thread Michael Schmitz
the 'blk>0' test in the partition block loop if a     value of (signed int) -1 is used to mark the end of the     partition block list.     Explicitly cast 'blk' to signed int to catch this.     Signed-off-by: Michael Schmitz diff --git a/block/partitions/amiga.c b/block/partitions/amiga.c in

Re: [PATCH] MAINTAINERS: Exclude m68k-only drivers from powerpc entry

2023-05-31 Thread Michael Schmitz
Hi Geert, On 1/06/23 00:59, Geert Uytterhoeven wrote: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11916,6 +11916,8 @@ L: linuxppc-dev@lists.ozlabs.org S: Odd Fixes F: arch/powerpc/platforms/powermac/ F: drivers/macintosh/ +X: drivers/macintosh/adb-iop.c +X:

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-30 Thread Michael Schmitz
Hi Christoph, On 29/06/22 18:25, Christoph Hellwig wrote: On Wed, Jun 29, 2022 at 09:38:00AM +1200, Michael Schmitz wrote: That's one of the 'liberties' I alluded to. The reason I left these in is that I'm none too certain what device feature the DMA API uses to decide a device isn't cache

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-30 Thread Michael Schmitz
Hi Christoph, On 29/06/22 18:21, Christoph Hellwig wrote: On Wed, Jun 29, 2022 at 11:09:00AM +1200, Michael Schmitz wrote: And all SCSI buffers are allocated using kmalloc? No way at all for user space to pass unaligned data? Most that you will see actually comes from the page allocator

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-28 Thread Michael Schmitz
Hi Bart, On 29/06/22 12:01, Michael Schmitz wrote: An example of a user space application that passes an SG I/O data buffer to the kernel that is aligned to a four byte boundary but not to an eight byte boundary if the -s (scattered) command line option is used: https://github.com/osandov

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-28 Thread Michael Schmitz
Hi Bart, On 29/06/22 11:50, Bart Van Assche wrote: On 6/28/22 16:09, Michael Schmitz wrote: On 29/06/22 09:50, Arnd Bergmann wrote: On Tue, Jun 28, 2022 at 11:03 PM Michael Schmitz wrote: On 28/06/22 19:03, Geert Uytterhoeven wrote: The driver allocates bounce buffers using kmalloc

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-28 Thread Michael Schmitz
Hi Arnd, On 29/06/22 09:55, Arnd Bergmann wrote: On Tue, Jun 28, 2022 at 11:38 PM Michael Schmitz wrote: On 28/06/22 19:08, Arnd Bergmann wrote: I see two other problems with your patch though: a) you still duplicate the cache handling: the cache_clear()/cache_push() is supposed to already

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-28 Thread Michael Schmitz
Hi Arnd, On 29/06/22 09:50, Arnd Bergmann wrote: On Tue, Jun 28, 2022 at 11:03 PM Michael Schmitz wrote: On 28/06/22 19:03, Geert Uytterhoeven wrote: The driver allocates bounce buffers using kmalloc if it hits an unaligned data buffer - can such buffers still even happen these days

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-28 Thread Michael Schmitz
Hi Arnd, On 28/06/22 19:08, Arnd Bergmann wrote: On Tue, Jun 28, 2022 at 5:25 AM Michael Schmitz wrote: Am 28.06.2022 um 09:12 schrieb Michael Schmitz: Leaving the bounce buffer handling in place, and taking a few other liberties - this is what converting the easiest case (a3000 SCSI) might

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-28 Thread Michael Schmitz
Hi Geert, On 28/06/22 19:03, Geert Uytterhoeven wrote: Leaving the bounce buffer handling in place, and taking a few other liberties - this is what converting the easiest case (a3000 SCSI) might look like. Any obvious mistakes? The mvme147 driver would be very similar to handle (after

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-27 Thread Michael Schmitz
Hii Geert Am 28.06.2022 um 09:12 schrieb Michael Schmitz: Hi Geert, On 27/06/22 20:26, Geert Uytterhoeven wrote: Hi Michael, On Sat, Jun 18, 2022 at 3:06 AM Michael Schmitz wrote: Am 18.06.2022 um 00:57 schrieb Arnd Bergmann: From: Arnd Bergmann All architecture-independent users

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-27 Thread Michael Schmitz
Hi Geert, On 27/06/22 20:26, Geert Uytterhoeven wrote: Hi Michael, On Sat, Jun 18, 2022 at 3:06 AM Michael Schmitz wrote: Am 18.06.2022 um 00:57 schrieb Arnd Bergmann: From: Arnd Bergmann All architecture-independent users of virt_to_bus() and bus_to_virt() have been fixed to use the dma

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-27 Thread Michael Schmitz
Arnd, Am 26.06.2022 um 20:36 schrieb Arnd Bergmann: There are no platform specific header files other than asm/amigahw.h and asm/mvme147hw.h, currently only holding register address definitions. Would it be OK to add m68k_virt_to_bus() in there if it can't remain in asm/virtconvert.h, Geert?

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-25 Thread Michael Schmitz
Arnd, Am 24.06.2022 um 21:10 schrieb Arnd Bergmann: On Sat, Jun 18, 2022 at 3:06 AM Michael Schmitz wrote: Am 18.06.2022 um 00:57 schrieb Arnd Bergmann: All architecture-independent users of virt_to_bus() and bus_to_virt() have been fixed to use the dma mapping interfaces or have been

Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS

2022-06-17 Thread Michael Schmitz
Arnd, Am 18.06.2022 um 00:57 schrieb Arnd Bergmann: From: Arnd Bergmann All architecture-independent users of virt_to_bus() and bus_to_virt() have been fixed to use the dma mapping interfaces or have been removed now. This means the definitions on most architectures, and the

Re: [RFC 02/32] Kconfig: introduce HAS_IOPORT option and select it as necessary

2021-12-31 Thread Michael Schmitz
Hi Arnd, Am 01.01.2022 um 05:04 schrieb Arnd Bergmann: On Wed, Dec 29, 2021 at 10:44 PM Michael Schmitz wrote: Am 30.12.2021 um 14:48 schrieb Arnd Bergmann: On Tue, Dec 28, 2021 at 11:15 PM Michael Schmitz wrote: What some other architectures do is to rely on inb()/outb() to have a zero

Re: [RFC 02/32] Kconfig: introduce HAS_IOPORT option and select it as necessary

2021-12-30 Thread Michael Schmitz
Hi Arnd, Am 30.12.2021 um 14:48 schrieb Arnd Bergmann: On Tue, Dec 28, 2021 at 11:15 PM Michael Schmitz wrote: Am 29.12.2021 um 16:41 schrieb Arnd Bergmann: On Tue, Dec 28, 2021 at 8:20 PM Michael Schmitz wrote: I'd hope not - we spent some effort to make sure setting ATARI_ROM_ISA does

Re: [RFC 02/32] Kconfig: introduce HAS_IOPORT option and select it as necessary

2021-12-30 Thread Michael Schmitz
Hi Arnd, Am 29.12.2021 um 16:41 schrieb Arnd Bergmann: On Tue, Dec 28, 2021 at 8:20 PM Michael Schmitz wrote: Am 28.12.2021 um 23:08 schrieb Geert Uytterhoeven: On Mon, Dec 27, 2021 at 5:44 PM Niklas Schnelle wrote: We introduce a new HAS_IOPORT Kconfig option to gate support for I/O port

Re: [RFC 02/32] Kconfig: introduce HAS_IOPORT option and select it as necessary

2021-12-30 Thread Michael Schmitz
Hi Geert, Niklas, Am 28.12.2021 um 23:08 schrieb Geert Uytterhoeven: Hi Niklas, On Mon, Dec 27, 2021 at 5:44 PM Niklas Schnelle wrote: We introduce a new HAS_IOPORT Kconfig option to gate support for I/O port access. In a future patch HAS_IOPORT=n will disable compilation of the I/O

Re: [PATCH v8 01/25] scsi/atari_scsi: Don't select CONFIG_NVRAM

2018-12-29 Thread Michael Schmitz
Christophe, Am 30.12.2018 um 05:55 schrieb LEROY Christophe: Michael Schmitz a écrit : Hi Finn, Am 29.12.2018 um 14:06 schrieb Finn Thain: On Fri, 28 Dec 2018, LEROY Christophe wrote: diff --git a/drivers/scsi/atari_scsi.c b/drivers/scsi/atari_scsi.c index 89f5154c40b6..99e5729d910d

Re: [PATCH v8 01/25] scsi/atari_scsi: Don't select CONFIG_NVRAM

2018-12-28 Thread Michael Schmitz
in Tested-by: Christian T. Steigies Acked-by: Michael Schmitz --- This patch temporarily disables CONFIG_NVRAM on Atari, to prevent build failures when bisecting the rest of this patch series. It gets enabled again with the introduction of CONFIG_HAVE_ARCH_NVRAM_OPS, once the nvram_* global functions

Re: [PATCH v8 01/25] scsi/atari_scsi: Don't select CONFIG_NVRAM

2018-12-28 Thread Michael Schmitz
Hi Finn, Am 29.12.2018 um 15:34 schrieb Finn Thain: On Sat, 29 Dec 2018, Michael Schmitz wrote: IS_BUILTIN(CONFIG_NVRAM) is probably what Christophe really meant to suggest. Or (really going out on a limb here): IS_BUILTIN(CONFIG_NVRAM) || ( IS_MODULE(CONFIG_ATARI_SCSI) && IS

Re: [PATCH v8 01/25] scsi/atari_scsi: Don't select CONFIG_NVRAM

2018-12-28 Thread Michael Schmitz
Hi Finn, Am 29.12.2018 um 14:06 schrieb Finn Thain: On Fri, 28 Dec 2018, LEROY Christophe wrote: diff --git a/drivers/scsi/atari_scsi.c b/drivers/scsi/atari_scsi.c index 89f5154c40b6..99e5729d910d 100644 --- a/drivers/scsi/atari_scsi.c +++ b/drivers/scsi/atari_scsi.c @@ -755,9 +755,10 @@

Re: [PATCH v4 00/11] macintosh: Resolve various PMU driver problems

2018-07-28 Thread Michael Schmitz
No regressions on my PowerBook G4, so for this series: Tested-by: Michael Schmitz Am 02.07.2018 um 20:21 schrieb Finn Thain: This series of patches has the following aims. 1) Eliminate duplicated code. Linux presently has two drivers for the 68HC05-based PMU devices found in Macs: via-pmu

Re: [PATCH v3 00/12] macintosh: Resolve various PMU driver problems

2018-06-27 Thread Michael Schmitz
Gabriel, Am 27.06.2018 um 21:00 schrieb Gabriel Paubert: On Wed, Jun 27, 2018 at 05:39:15PM +1200, Michael Schmitz wrote: Ben, Am 27.06.2018 um 15:27 schrieb Benjamin Herrenschmidt: On Wed, 2018-06-27 at 13:08 +1000, Michael Ellerman wrote: I will rewrite patch 10/12 after Arnd's fixes

Re: [PATCH v3 00/12] macintosh: Resolve various PMU driver problems

2018-06-26 Thread Michael Schmitz
Ben, Am 27.06.2018 um 15:27 schrieb Benjamin Herrenschmidt: On Wed, 2018-06-27 at 13:08 +1000, Michael Ellerman wrote: I will rewrite patch 10/12 after Arnd's fixes and this series have all made their way through both powerpc and m68k trees, and submit it separately. drivers/macintosh is

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

2018-06-12 Thread Michael Schmitz
Hi, On Tue, Jun 12, 2018 at 6:53 PM, Laurent Vivier wrote: > On 12/06/2018 01:47, Finn Thain wrote: >> On Sun, 10 Jun 2018, Benjamin Herrenschmidt wrote: > ... >> I don't know what the bootloader situation is, but it looks messy... >> http://nubus-pmac.sourceforge.net/#booters >> >> Laurent,

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

2018-06-10 Thread Michael Schmitz
: > On Sun, 2018-06-10 at 21:12 +1200, Michael Schmitz wrote: >> Hi Geert, > > Top posting, sorry ... > > We are painting that bike shed with way too many coats.. > > We can keep the existing definitions, stick a comment on them stating > "obsolete" an

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

2018-06-10 Thread Michael Schmitz
Hi Geert, Am 10.06.2018 um 20:29 schrieb Geert Uytterhoeven: Hi Finn, On Sat, Jun 9, 2018 at 2:20 PM Finn Thain wrote: Is this enum used by any user space code? If so, perhaps rather leave the PMU_68K_V1 in there to avoid upsetting that? It also changes the value of PMU_68K_V2, which is an

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

2018-06-09 Thread Michael Schmitz
Hi Andreas, Am 09.06.2018 um 19:14 schrieb Andreas Schwab: On Jun 09 2018, Michael Schmitz wrote: Hi Finn, Am 08.06.2018 um 14:24 schrieb Finn Thain: Don't load the via-pmu68k driver on early PowerBooks. The M50753 PMU device found in those models was never supported by this driver

Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware

2018-06-09 Thread Michael Schmitz
, version 1 */ PMU_68K_V2, /* 68K PMU, version 2 */ }; Is this enum used by any user space code? If so, perhaps rather leave the PMU_68K_V1 in there to avoid upsetting that? Otherwise, Reviewed-by: Michael Schmitz Cheers, Michael

Re: [RFC v4 03/25] m68k/atari: Move Atari-specific code out of drivers/char/nvram.c

2015-07-26 Thread Michael Schmitz
00 00 00 00 || That video mode is indeed the one set in the NVRAM (by ARAnyM config, if running emulated) Cheers, Michael On Sun, Jul 26, 2015 at 1:19 PM, Finn Thain fth...@telegraphics.com.au wrote: On Sun, 26 Jul 2015, Michael Schmitz wrote: Hi Finn, For the sake

Re: [RFC v4 03/25] m68k/atari: Move Atari-specific code out of drivers/char/nvram.c

2015-07-25 Thread Michael Schmitz
|| 0030 de 21 |.!| 0032 d640bf7d535b54e39582fabdc016d7ca /dev/nvram d640bf7d535b54e39582fabdc016d7ca /tmp/nvram Happy to help ... Cheers, Michael On Sat, 25 Jul 2015, Michael Schmitz wrote: Hi Christian, good to know

Re: [RFC v4 03/25] m68k/atari: Move Atari-specific code out of drivers/char/nvram.c

2015-07-24 Thread Michael Schmitz
. Steigies: Moin, On Fri, Jul 24, 2015 at 02:56:26PM +1200, Michael Schmitz wrote: here's what Finn asked me to run as tests: # dmesg | grep this_id nvram.out # cat /proc/driver/nvram nvram.out # hexdump -C /dev/nvram nvram.out # cp /dev/nvram /tmp/nvram # cp /tmp/nvram /dev/nvram # md5sum /dev/nvram

Re: [RFC v4 03/25] m68k/atari: Move Atari-specific code out of drivers/char/nvram.c

2015-07-23 Thread Michael Schmitz
Hi Christian, here's what Finn asked me to run as tests: # dmesg | grep this_id nvram.out # cat /proc/driver/nvram nvram.out # hexdump -C /dev/nvram nvram.out # cp /dev/nvram /tmp/nvram # cp /tmp/nvram /dev/nvram # md5sum /dev/nvram /tmp/nvram nvram.out What you sent so far looks OK. I've

Re: [RFC v4 03/25] m68k/atari: Move Atari-specific code out of drivers/char/nvram.c

2015-07-22 Thread Michael Schmitz
: On Wed, 22 Jul 2015, Michael Schmitz wrote: Hi Finn, I'm afraid I cannot test anything on Atari hardware at present - my Falcon ate it's IDE disk partition table with all the fun that entails. That doesn't sound good. Haven't even begun to try and recover that yet. If you send

Re: [RFC v4 03/25] m68k/atari: Move Atari-specific code out of drivers/char/nvram.c

2015-07-21 Thread Michael Schmitz
Hi Finn, I'm afraid I cannot test anything on Atari hardware at present - my Falcon ate it's IDE disk partition table with all the fun that entails. Haven't even begun to try and recover that yet. If you send a patch I could build a kernel and send that to Christian for testing (if he's got

Re: [patch 10/10] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-08-13 Thread Michael Schmitz
From: Geert Uytterhoeven [EMAIL PROTECTED] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible With buttons emulation being available via uinput event devices, do we still need the kernel mouse button emulation? At least on powerpc, it was declared deprecated long ago ...