[PATCH net-next 02/10] net: mdio: i2c: Separate C22 and C45 transactions

2023-01-12 Thread Michael Walle
From: Andrew Lunn The MDIO over I2C bus driver can perform both C22 and C45 transfers. Create separate functions for each and register the C45 versions using the new API calls. Signed-off-by: Andrew Lunn Signed-off-by: Michael Walle --- drivers/net/mdio/mdio-i2c.c | 32

[PATCH net-next 01/10] net: mdio: cavium: Separate C22 and C45 transactions

2023-01-12 Thread Michael Walle
From: Andrew Lunn The cavium IP can perform both C22 and C45 transfers. Create separate functions for each and register the C45 versions in both the octeon and thunder bus driver. Signed-off-by: Andrew Lunn Signed-off-by: Michael Walle --- drivers/net/mdio/mdio-cavium.c | 111

[PATCH net-next 04/10] net: mdio: aspeed: Separate C22 and C45 transactions

2023-01-12 Thread Michael Walle
Signed-off-by: Michael Walle --- drivers/net/mdio/mdio-aspeed.c | 47 +++--- 1 file changed, 12 insertions(+), 35 deletions(-) diff --git a/drivers/net/mdio/mdio-aspeed.c b/drivers/net/mdio/mdio-aspeed.c index 944d005d2bd1..2f4bbda5e56c 100644 --- a/drivers

[PATCH net-next 09/10] net: stmmac: Separate C22 and C45 transactions for xgmac

2023-01-12 Thread Michael Walle
From: Andrew Lunn The stmmac MDIO bus driver in variant gmac4 can perform both C22 and C45 transfers. Create separate functions for each and register the C45 versions using the new API calls where appropriate. Signed-off-by: Andrew Lunn Signed-off-by: Michael Walle --- drivers/net/ethernet

[PATCH net-next 05/10] net: mdio: ipq4019: Separate C22 and C45 transactions

2023-01-12 Thread Michael Walle
From: Andrew Lunn The ipq4019 driver can perform both C22 and C45 transfers. Create separate functions for each and register the C45 versions using the new driver API calls. Signed-off-by: Andrew Lunn Signed-off-by: Michael Walle --- drivers/net/mdio/mdio-ipq4019.c | 154

[PATCH net-next 03/10] net: mdio: mux-bcm-iproc: Separate C22 and C45 transactions

2023-01-12 Thread Michael Walle
From: Andrew Lunn The MDIO mux broadcom iproc can perform both C22 and C45 transfers. Create separate functions for each and register the C45 versions using the new API calls. Signed-off-by: Andrew Lunn Signed-off-by: Michael Walle --- Apparently, in the c45 case, the reg value including

[PATCH net-next 06/10] net: ethernet: mtk_eth_soc: Separate C22 and C45 transactions

2023-01-12 Thread Michael Walle
From: Andrew Lunn The mediatek bus driver can perform both C22 and C45 transfers. Create separate functions for each and register the C45 versions using the new API calls. Signed-off-by: Andrew Lunn Signed-off-by: Michael Walle --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 178

[PATCH net-next 07/10] net: lan743x: Separate C22 and C45 transactions

2023-01-12 Thread Michael Walle
From: Andrew Lunn The microchip lan743x MDIO bus driver can perform both C22 and C45 transfers in some variants. Create separate functions for each and register the C45 versions using the new API calls where appropriate. Signed-off-by: Andrew Lunn Signed-off-by: Michael Walle --- drivers/net

[PATCH net-next 10/10] enetc: Separate C22 and C45 transactions

2023-01-12 Thread Michael Walle
-by: Andrew Lunn Signed-off-by: Michael Walle --- drivers/net/dsa/ocelot/felix_vsc9959.c | 6 +- drivers/net/ethernet/freescale/enetc/enetc_mdio.c | 119 +++-- .../net/ethernet/freescale/enetc/enetc_pci_mdio.c | 6 +- drivers/net/ethernet/freescale/enetc/enetc_pf.c

[PATCH net-next 08/10] net: stmmac: Separate C22 and C45 transactions for xgmac2

2023-01-12 Thread Michael Walle
From: Andrew Lunn The stmicro stmmac xgmac2 MDIO bus driver can perform both C22 and C45 transfers. Create separate functions for each and register the C45 versions using the new API calls where appropriate. Signed-off-by: Andrew Lunn Signed-off-by: Michael Walle --- drivers/net/ethernet

[PATCH net-next 00/10] net: mdio: Continue separating C22 and C45

2023-01-12 Thread Michael Walle
I've picked this older series from Andrew up and rebased it onto the latest net-next. This is the second patch set in the series which separates the C22 and C45 MDIO bus transactions at the API level to the MDIO bus drivers. Signed-off-by: Michael Walle  To: Heiner Kallweit To: Russell King

Re: [PATCH] soc: fsl: guts: fix IS_ERR() vs NULL bug

2022-07-04 Thread Michael Walle
Am 2022-07-04 12:55, schrieb Dan Carpenter: The of_iomap() function returns NULL on failure, it never returns error pointers. Fixes: ab4988d6a393 ("soc: fsl: guts: embed fsl_guts_get_svr() in probe()") Signed-off-by: Dan Carpenter --- drivers/soc/fsl/guts.c | 4 ++-- 1 file changed, 2

Re: [PATCH -next 2/2] soc: fsl: guts: check return value after calling of_iomap() in fsl_guts_get_soc_uid()

2022-06-28 Thread Michael Walle
Am 2022-06-28 16:02, schrieb Yang Yingliang: of_iomap() may return NULL, so we need check the return value. Fixes: 786dde1e59d7 ("soc: fsl: guts: add serial_number support") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Reviewed-by: Michael Walle

Re: [PATCH -next 1/2] soc: fsl: guts: fix return value check in fsl_guts_init()

2022-06-28 Thread Michael Walle
probe()") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Thanks! Reviewed-by: Michael Walle

Re: [PATCH RESEND v2 0/7] soc: fsl: guts: cleanups and serial_number support

2022-06-22 Thread Michael Walle
Am 2022-04-04 11:56, schrieb Michael Walle: [Resend because of new development cycle. Shawn, can this series get through your tree? Sorry you weren't on CC on the former submissions.] This series converts the guts driver from a platform driver to just an core_initcall. The driver itself cannot

[PATCH v3 0/4] dt-bindings: convert freescale extirq and scfg schemas

2022-04-27 Thread Michael Walle
The first two patches will be resend to the soc tree once the schema is approved/picked up. Please note, I'm still getting these weird "is too short" errors for for interrupt-map entries, but it seems to work for you, so.. ;) Michael Walle (4): ARM: dts: ls1021a: reduce the interrup

[PATCH v3 1/4] ARM: dts: ls1021a: reduce the interrupt-map-mask

2022-04-27 Thread Michael Walle
Reduce the interrupt-map-mask of the external interrupt controller to 7 to align with the devicetree schema. Signed-off-by: Michael Walle --- arch/arm/boot/dts/ls1021a.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts

[PATCH v3 2/4] arm64: dts: freescale: reduce the interrup-map-mask

2022-04-27 Thread Michael Walle
Reduce the interrupt-map-mask of the external interrupt controller to 0xf to align with the devicetree schema. Signed-off-by: Michael Walle --- arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +- arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +- arch/arm64/boot/dts/freescale/fsl

[PATCH v3 3/4] dt-bindings: interrupt-controller: fsl, ls-extirq: convert to YAML

2022-04-27 Thread Michael Walle
6, the interrupt-map-mask was reduced from 0x to 0xf and 0x7 respectively and the number of interrupt-map entries have to match. Signed-off-by: Michael Walle --- changes since v2: - drop $ref to interrupt-controller.yaml - use a more strict interrupt-map-mask and make it conditional on So

[PATCH v3 4/4] dt-bindings: fsl: convert fsl,layerscape-scfg to YAML

2022-04-27 Thread Michael Walle
m/boot/dts/ls1021a.dtsi as well as the litte-endian and big-endian properties. Signed-off-by: Michael Walle Reviewed-by: Krzysztof Kozlowski --- changes since v2: - none changes since v1: - moved to soc/fsl/fsl,layerscape-scfg.yaml - generic name for node in example - mention added "sys

Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: fsl, ls-extirq: convert to YAML

2022-04-26 Thread Michael Walle
Am 2022-04-26 08:53, schrieb Krzysztof Kozlowski: On 25/04/2022 23:58, Michael Walle wrote: + reg: +maxItems: 1 +description: + Specifies the Interrupt Polarity Control Register (INTPCR) in the + SCFG or the External Interrupt Control Register (IRQCR) in the ISC

Re: [PATCH v2 1/2] dt-bindings: interrupt-controller: fsl, ls-extirq: convert to YAML

2022-04-25 Thread Michael Walle
Am 2022-04-25 20:36, schrieb Krzysztof Kozlowski: On 25/04/2022 16:02, Michael Walle wrote: Convert the fsl,ls-extirq binding to the new YAML format. (...) diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.yaml b/Documentation/devicetree/bindings/interrupt

[PATCH v2 2/2] dt-bindings: fsl: convert fsl,layerscape-scfg to YAML

2022-04-25 Thread Michael Walle
m/boot/dts/ls1021a.dtsi as well as the litte-endian and big-endian properties. Signed-off-by: Michael Walle --- changes since v1: - moved to soc/fsl/fsl,layerscape-scfg.yaml - generic name for node in example - mention added "syscon" compatible in commit message - reference specific

[PATCH v2 1/2] dt-bindings: interrupt-controller: fsl, ls-extirq: convert to YAML

2022-04-25 Thread Michael Walle
xtirq", "fsl,ls1043a-extirq" - "fsl,ls2080a-extirq", "fsl,ls1088a-extirq" - "fsl,lx2160a-extirq", "fsl,ls1088a-extirq" Signed-off-by: Michael Walle --- changes since v1: - new patch, because it's reference in patch 2/2 .../interrupt-con

[PATCH RESEND v2 6/7] soc: fsl: guts: drop platform driver

2022-04-04 Thread Michael Walle
This driver cannot be unloaded and it will be needed very early in the boot process because other driver (weakly) depend on it (eg. for chip errata handling). Drop all the platform driver and devres stuff and simply make it a core_initcall. Signed-off-by: Michael Walle Acked-by: Arnd Bergmann

[PATCH RESEND v2 7/7] soc: fsl: guts: add serial_number support

2022-04-04 Thread Michael Walle
support for the LS1028A SoC. Signed-off-by: Michael Walle Acked-by: Arnd Bergmann --- drivers/soc/fsl/guts.c | 48 -- 1 file changed, 46 insertions(+), 2 deletions(-) diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c index 370be923aa0f

[PATCH RESEND v2 4/7] soc: fsl: guts: allocate soc_dev_attr on the heap

2022-04-04 Thread Michael Walle
This is the last global static variable. Drop it and allocate the memory on the heap instead. Signed-off-by: Michael Walle Acked-by: Arnd Bergmann --- drivers/soc/fsl/guts.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/drivers

[PATCH RESEND v2 2/7] soc: fsl: guts: remove module_exit() and fsl_guts_remove()

2022-04-04 Thread Michael Walle
This driver will never be unloaded. Firstly, it is not available as a module, but more importantly, other drivers will depend on this one to apply possible chip errata. Signed-off-by: Michael Walle Acked-by: Arnd Bergmann --- drivers/soc/fsl/guts.c | 15 +-- 1 file changed, 1

[PATCH RESEND v2 3/7] soc: fsl: guts: embed fsl_guts_get_svr() in probe()

2022-04-04 Thread Michael Walle
-off-by: Michael Walle Acked-by: Arnd Bergmann --- drivers/soc/fsl/guts.c | 42 +++--- 1 file changed, 11 insertions(+), 31 deletions(-) diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c index 0bea43770d51..4e5675ab5f73 100644 --- a/drivers/soc/fsl

[PATCH RESEND v2 5/7] soc: fsl: guts: use of_root instead of own reference

2022-04-04 Thread Michael Walle
There is already a global of_root reference. Use that instead of getting one on our own. We don't need to care about the reference count either this way. Signed-off-by: Michael Walle Acked-by: Arnd Bergmann --- drivers/soc/fsl/guts.c | 12 1 file changed, 4 insertions(+), 8

[PATCH RESEND v2 0/7] soc: fsl: guts: cleanups and serial_number support

2022-04-04 Thread Michael Walle
/nvmem/fsl,layerscape-sfp.yaml changes since v1: - call kfree() in error case, thanks Dan - add missing of_node_put(np), thanks Dan Michael Walle (7): soc: fsl: guts: machine variable might be unset soc: fsl: guts: remove module_exit() and fsl_guts_remove() soc: fsl: guts: embed

[PATCH RESEND v2 1/7] soc: fsl: guts: machine variable might be unset

2022-04-04 Thread Michael Walle
If both the model and the compatible properties are missing, then machine will not be set. Initialize it with NULL. Fixes: 34c1c21e94ac ("soc: fsl: fix section mismatch build warnings") Signed-off-by: Michael Walle Acked-by: Arnd Bergmann --- drivers/soc/fsl/guts.c | 2 +- 1 file

Re: [PATCH v2 0/7] soc: fsl: guts: cleanups and serial_number support

2022-02-21 Thread Michael Walle
Hi, any news here? Through which tree is this supposed to go? Am 2022-02-09 17:32, schrieb Michael Walle: This series converts the guts driver from a platform driver to just an core_initcall. The driver itself cannot (or rather should never) be unloaded because others depends on detecting

[PATCH v2 6/7] soc: fsl: guts: drop platform driver

2022-02-09 Thread Michael Walle
This driver cannot be unloaded and it will be needed very early in the boot process because other driver (weakly) depend on it (eg. for chip errata handling). Drop all the platform driver and devres stuff and simply make it a core_initcall. Signed-off-by: Michael Walle --- drivers/soc/fsl

[PATCH v2 5/7] soc: fsl: guts: use of_root instead of own reference

2022-02-09 Thread Michael Walle
There is already a global of_root reference. Use that instead of getting one on our own. We don't need to care about the reference count either this way. Signed-off-by: Michael Walle --- drivers/soc/fsl/guts.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git

[PATCH v2 7/7] soc: fsl: guts: add serial_number support

2022-02-09 Thread Michael Walle
support for the LS1028A SoC. Signed-off-by: Michael Walle --- drivers/soc/fsl/guts.c | 48 -- 1 file changed, 46 insertions(+), 2 deletions(-) diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c index 370be923aa0f..27035de062f8 100644 --- a/drivers

[PATCH v2 1/7] soc: fsl: guts: machine variable might be unset

2022-02-09 Thread Michael Walle
If both the model and the compatible properties are missing, then machine will not be set. Initialize it with NULL. Fixes: 34c1c21e94ac ("soc: fsl: fix section mismatch build warnings") Signed-off-by: Michael Walle --- drivers/soc/fsl/guts.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH v2 4/7] soc: fsl: guts: allocate soc_dev_attr on the heap

2022-02-09 Thread Michael Walle
This is the last global static variable. Drop it and allocate the memory on the heap instead. Signed-off-by: Michael Walle --- drivers/soc/fsl/guts.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/drivers/soc/fsl/guts.c b/drivers/soc

[PATCH v2 0/7] soc: fsl: guts: cleanups and serial_number support

2022-02-09 Thread Michael Walle
: - call kfree() in error case, thanks Dan - add missing of_node_put(np), thanks Dan Michael Walle (7): soc: fsl: guts: machine variable might be unset soc: fsl: guts: remove module_exit() and fsl_guts_remove() soc: fsl: guts: embed fsl_guts_get_svr() in probe() soc: fsl: guts: allocate

[PATCH v2 2/7] soc: fsl: guts: remove module_exit() and fsl_guts_remove()

2022-02-09 Thread Michael Walle
This driver will never be unloaded. Firstly, it is not available as a module, but more importantly, other drivers will depend on this one to apply possible chip errata. Signed-off-by: Michael Walle --- drivers/soc/fsl/guts.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions

[PATCH v2 3/7] soc: fsl: guts: embed fsl_guts_get_svr() in probe()

2022-02-09 Thread Michael Walle
-off-by: Michael Walle --- drivers/soc/fsl/guts.c | 42 +++--- 1 file changed, 11 insertions(+), 31 deletions(-) diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c index 0bea43770d51..4e5675ab5f73 100644 --- a/drivers/soc/fsl/guts.c +++ b/drivers/soc

[PATCH v1 5/7] soc: fsl: guts: use of_root instead of own reference

2022-01-27 Thread Michael Walle
There is already a global of_root reference. Use that instead of getting one on our own. We don't need to care about the reference count either this way. Signed-off-by: Michael Walle --- drivers/soc/fsl/guts.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git

[PATCH v1 6/7] soc: fsl: guts: drop platform driver

2022-01-27 Thread Michael Walle
This driver cannot be unloaded and it will be needed very early in the boot process because other driver (weakly) depend on it (eg. for chip errata handling). Drop all the platform driver and devres stuff and simply make it a core_initcall. Signed-off-by: Michael Walle --- drivers/soc/fsl

[PATCH v1 2/7] soc: fsl: guts: remove module_exit() and fsl_guts_remove()

2022-01-27 Thread Michael Walle
This driver will never be unloaded. Firstly, it is not available as a module, but more importantly, other drivers will depend on this one to apply possible chip errata. Signed-off-by: Michael Walle --- drivers/soc/fsl/guts.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions

[RFC PATCH v1 7/7] soc: fsl: guts: add serial_number support

2022-01-27 Thread Michael Walle
support for the LS1028A SoC. Signed-off-by: Michael Walle --- RFC because SFP binding is still pending and needs Rob's ack: https://lore.kernel.org/linux-devicetree/20220127163728.3650648-2-mich...@walle.cc/ drivers/soc/fsl/guts.c | 48 -- 1 file changed, 46

[PATCH v1 3/7] soc: fsl: guts: embed fsl_guts_get_svr() in probe()

2022-01-27 Thread Michael Walle
-off-by: Michael Walle --- drivers/soc/fsl/guts.c | 41 +++-- 1 file changed, 11 insertions(+), 30 deletions(-) diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c index 0bea43770d51..536377988fb4 100644 --- a/drivers/soc/fsl/guts.c +++ b/drivers/soc

[PATCH v1 4/7] soc: fsl: guts: allocate soc_dev_attr on the heap

2022-01-27 Thread Michael Walle
This is the last global static variable. Drop it and allocate the memory on the heap instead. Signed-off-by: Michael Walle --- drivers/soc/fsl/guts.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/drivers/soc/fsl/guts.c b/drivers/soc

[PATCH v1 1/7] soc: fsl: guts: machine variable might be unset

2022-01-27 Thread Michael Walle
If both the model and the compatible properties are missing, then machine will not be set. Initialize it with NULL. Fixes: 34c1c21e94ac ("soc: fsl: fix section mismatch build warnings") Signed-off-by: Michael Walle --- drivers/soc/fsl/guts.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH v1 0/7] soc: fsl: guts: cleanups and serial_number support

2022-01-27 Thread Michael Walle
the global static variables. The last patch finally adds unique id support to the guts driver. But because the binding for the security fuse processor is still pending, it is marked as RFC. Michael Walle (7): soc: fsl: guts: machine variable might be unset soc: fsl: guts: remove module_exit

Re: [PATCH net-next v4 2/2] of: net: fix of_get_mac_addr_nvmem() for non-platform devices

2021-04-28 Thread Michael Walle
Am 2021-04-27 01:44, schrieb Benjamin Herrenschmidt: On Mon, 2021-04-26 at 12:54 +0200, Michael Walle wrote: (2) What do you think of eth_get_mac_address(ndev). That is, the Not sure what you mean, eth_platform_get_mac_address() takes the address as an argument. I think what you want

Re: [PATCH net-next v4 2/2] of: net: fix of_get_mac_addr_nvmem() for non-platform devices

2021-04-26 Thread Michael Walle
Am 2021-04-16 17:19, schrieb Rob Herring: On Fri, Apr 16, 2021 at 2:30 AM Michael Walle wrote: Am 2021-04-16 05:24, schrieb Benjamin Herrenschmidt: > On Mon, 2021-04-12 at 19:47 +0200, Michael Walle wrote: >> >> /** >> * of_get_phy_mode - Get phy mode for given dev

Re: [PATCH net-next v4 2/2] of: net: fix of_get_mac_addr_nvmem() for non-platform devices

2021-04-16 Thread Michael Walle
Am 2021-04-16 05:24, schrieb Benjamin Herrenschmidt: On Mon, 2021-04-12 at 19:47 +0200, Michael Walle wrote: /** * of_get_phy_mode - Get phy mode for given device_node @@ -59,15 +60,39 @@ static int of_get_mac_addr(struct device_node *np, const char *name, u8 *addr) static int

Re: [PATCH net-next v2 1/2] of: net: pass the dst buffer to of_get_mac_address()

2021-04-14 Thread Michael Walle
Hi Dan, Am 2021-04-14 07:33, schrieb Dan Carpenter: url: https://github.com/0day-ci/linux/commits/Michael-Walle/of-net-support-non-platform-devices-in-of_get_mac_address/20210406-234030 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git

[PATCH net-next v4 0/2] of: net: support non-platform devices in of_get_mac_address()

2021-04-12 Thread Michael Walle
Carpenter - changed subject of patch 2/2, as suggested by Florian Fainelli changes since v2: - fixed of_get_mac_addr_nvmem() signature, which was accidentially fixed in patch 2/2 again changes since v1: - fixed stmmac_probe_config_dt() for !CONFIG_OF - added missing queue in patch subje

[PATCH net-next v4 1/2] of: net: pass the dst buffer to of_get_mac_address()

2021-04-12 Thread Michael Walle
x ...+>@e) - {} - else + if (!(e)) {...} @@ expression x, y, z; @@ - x = of_get_mac_address(y, z); + of_get_mac_address(y, z); ... when != x All drivers, except drivers/net/ethernet/aeroflex/greth.c, were compile-time tested. Suggested-by: Andrew Lunn Signed-off-by: Michael Walle --- arch/arm/m

[PATCH net-next v4 2/2] of: net: fix of_get_mac_addr_nvmem() for non-platform devices

2021-04-12 Thread Michael Walle
complexes. Use the nvmem of_* binding to fetch the nvmem cells by a struct device_node. We still have to try to read the cell by device first because there might be a nvmem_cell_lookup associated with that device. Signed-off-by: Michael Walle --- drivers/of/of_net.c | 35

Re: [PATCH net-next v3 1/2] of: net: pass the dst buffer to of_get_mac_address()

2021-04-07 Thread Michael Walle
Am 2021-04-07 00:09, schrieb Michael Walle: [..] diff --git a/drivers/of/of_net.c b/drivers/of/of_net.c index bc0a27de69d4..2d5d5e59aea5 100644 --- a/drivers/of/of_net.c +++ b/drivers/of/of_net.c @@ -45,42 +45,35 @@ int of_get_phy_mode(struct device_node *np, phy_interface_t *interface

[PATCH net-next v3 1/2] of: net: pass the dst buffer to of_get_mac_address()

2021-04-06 Thread Michael Walle
x ...+>@e) - {} - else + if (!(e)) {...} @@ expression x, y, z; @@ - x = of_get_mac_address(y, z); + of_get_mac_address(y, z); ... when != x All drivers, except drivers/net/ethernet/aeroflex/greth.c, were compile-time tested. Suggested-by: Andrew Lunn Signed-off-by: Michael Walle --- arch/arm/m

[PATCH net-next v3 2/2] of: net: fix of_get_mac_addr_nvmem() for PCI and DSA nodes

2021-04-06 Thread Michael Walle
complexes. Use the nvmem of_* binding to fetch the nvmem cells by a struct device_node. We still have to try to read the cell by device first because there might be a nvmem_cell_lookup associated with that device. Signed-off-by: Michael Walle --- Please note, that I've kept

[PATCH net-next v3 0/2] of: net: support non-platform devices in of_get_mac_address()

2021-04-06 Thread Michael Walle
led before of_get_mac_address(). No driver does it this way. changes since v2: - fixed of_get_mac_addr_nvmem() signature, which was accidentially fixed in patch 2/2 again changes since v1: - fixed stmmac_probe_config_dt() for !CONFIG_OF - added missing queue in patch subject Michael Walle (2):

[PATCH net-next v2 1/2] of: net: pass the dst buffer to of_get_mac_address()

2021-04-06 Thread Michael Walle
x ...+>@e) - {} - else + if (!(e)) {...} @@ expression x, y, z; @@ - x = of_get_mac_address(y, z); + of_get_mac_address(y, z); ... when != x All drivers, except drivers/net/ethernet/aeroflex/greth.c, were compile-time tested. Suggested-by: Andrew Lunn Signed-off-by: Michael Walle --- arch/arm/m

[PATCH net-next v2 2/2] of: net: fix of_get_mac_addr_nvmem() for PCI and DSA nodes

2021-04-06 Thread Michael Walle
complexes. Use the nvmem of_* binding to fetch the nvmem cells by a struct device_node. We still have to try to read the cell by device first because there might be a nvmem_cell_lookup associated with that device. Signed-off-by: Michael Walle --- Please note, that I've kept

[PATCH net-next v2 0/2] of: net: support non-platform devices in of_get_mac_address()

2021-04-06 Thread Michael Walle
led before of_get_mac_address(). No driver does it this way. changes since v1: - fixed stmmac_probe_config_dt() for !CONFIG_OF - added missing queue in patch subject Michael Walle (2): of: net: pass the dst buffer to of_get_mac_address() of: net: fix of_get_mac_addr_nvmem() for PCI and DSA no

[PATCH 2/2] of: net: fix of_get_mac_addr_nvmem() for PCI and DSA nodes

2021-04-05 Thread Michael Walle
complexes. Use the nvmem of_* binding to fetch the nvmem cells by a struct device_node. We still have to try to read the cell by device first because there might be a nvmem_cell_lookup associated with that device. Signed-off-by: Michael Walle --- Please note, that I've kept

[PATCH 1/2] of: net: pass the dst buffer to of_get_mac_address()

2021-04-05 Thread Michael Walle
x ...+>@e) - {} - else + if (!(e)) {...} @@ expression x, y, z; @@ - x = of_get_mac_address(y, z); + of_get_mac_address(y, z); ... when != x All drivers, except drivers/net/ethernet/aeroflex/greth.c, were compile-time tested. Suggested-by: Andrew Lunn Signed-off-by: Michael Walle --- arch/arm/m

[PATCH 0/2] of: net: support non-platform devices in of_get_mac_address()

2021-04-05 Thread Michael Walle
led before of_get_mac_address(). No driver does it this way. Michael Walle (2): of: of_net: pass the dst buffer to of_get_mac_address() of: net: fix of_get_mac_address_nvmem() for PCI and DSA nodes arch/arm/mach-mvebu/kirkwood.c| 3 +- arch/powerpc/sysdev/tsi108_dev.c

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-26 Thread Michael Walle
Am 2021-01-26 11:02, schrieb Lorenzo Pieralisi: On Wed, Jan 20, 2021 at 11:52:46AM +0100, Michael Walle wrote: fw_devlink will defer the probe until all suppliers are ready. We can't use builtin_platform_driver_probe() because it doesn't retry after probe deferral. Convert

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-25 Thread Michael Walle
Am 2021-01-21 12:01, schrieb Geert Uytterhoeven: Hi Saravana, On Thu, Jan 21, 2021 at 1:05 AM Saravana Kannan wrote: On Wed, Jan 20, 2021 at 3:53 PM Michael Walle wrote: > Am 2021-01-20 20:47, schrieb Saravana Kannan: > > On Wed, Jan 20, 2021 at 11:28 AM Michael Walle

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-25 Thread Michael Walle
Am 2021-01-25 19:58, schrieb Saravana Kannan: On Mon, Jan 25, 2021 at 8:50 AM Lorenzo Pieralisi wrote: On Wed, Jan 20, 2021 at 08:28:36PM +0100, Michael Walle wrote: > [RESEND, fat-fingered the buttons of my mail client and converted > all CCs to BCCs :(] > > Am 2021-01-20 20

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-20 Thread Michael Walle
Am 2021-01-20 20:47, schrieb Saravana Kannan: On Wed, Jan 20, 2021 at 11:28 AM Michael Walle wrote: [RESEND, fat-fingered the buttons of my mail client and converted all CCs to BCCs :(] Am 2021-01-20 20:02, schrieb Saravana Kannan: > On Wed, Jan 20, 2021 at 6:24 AM Rob Herring wr

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-20 Thread Michael Walle
Am 2021-01-20 20:02, schrieb Saravana Kannan: On Wed, Jan 20, 2021 at 6:24 AM Rob Herring wrote: On Wed, Jan 20, 2021 at 4:53 AM Michael Walle wrote: > > fw_devlink will defer the probe until all suppliers are ready. We can't > use builtin_platform_driver_probe() because it does

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-20 Thread Michael Walle
[RESEND, fat-fingered the buttons of my mail client and converted all CCs to BCCs :(] Am 2021-01-20 20:02, schrieb Saravana Kannan: On Wed, Jan 20, 2021 at 6:24 AM Rob Herring wrote: On Wed, Jan 20, 2021 at 4:53 AM Michael Walle wrote: > > fw_devlink will defer the probe unt

Re: [PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-20 Thread Michael Walle
Am 2021-01-20 15:23, schrieb Rob Herring: On Wed, Jan 20, 2021 at 4:53 AM Michael Walle wrote: fw_devlink will defer the probe until all suppliers are ready. We can't use builtin_platform_driver_probe() because it doesn't retry after probe deferral. Convert it to builtin_platform_driver

[PATCH] PCI: dwc: layerscape: convert to builtin_platform_driver()

2021-01-20 Thread Michael Walle
fw_devlink will defer the probe until all suppliers are ready. We can't use builtin_platform_driver_probe() because it doesn't retry after probe deferral. Convert it to builtin_platform_driver(). Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Signed-off-by: Mic

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-10 Thread Michael Walle
Am 2020-12-10 18:38, schrieb Bjorn Helgaas: On Wed, Dec 09, 2020 at 10:29:04PM +0200, Vladimir Oltean wrote: On Wed, Dec 09, 2020 at 04:40:52PM +0100, Michael Walle wrote: > Hopefully my mail client won't mess up the output that much. I can reproduce on my LS1028A as well. The following fi

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Michael Walle
Am 2020-12-09 15:57, schrieb Bjorn Helgaas: [..] Can you try the following just to get started? diff --git a/drivers/pci/access.c b/drivers/pci/access.c index 46935695cfb9..569a45727bc7 100644 --- a/drivers/pci/access.c +++ b/drivers/pci/access.c @@ -79,6 +79,7 @@ int

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-09 Thread Michael Walle
[+ Vladimir and Alex] Am 2020-12-09 13:36, schrieb Bjorn Helgaas: On Tue, Dec 08, 2020 at 04:41:50PM +0100, Michael Walle wrote: >On Sun, 29 Nov 2020 23:07:38 +, Krzysztof Wilczyński wrote: >> Unify ECAM-related constants into a single set of standard constants >> defining

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-08 Thread Michael Walle
Am 2020-12-08 22:06, schrieb Bjorn Helgaas: [+cc Qian] On Tue, Dec 08, 2020 at 04:41:50PM +0100, Michael Walle wrote: Hi Lorenzo, Krzysztof, >On Sun, 29 Nov 2020 23:07:38 +, Krzysztof Wilczyński wrote: >> Unify ECAM-related constants into a single set of standard constants &g

Re: [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers

2020-12-08 Thread Michael Walle
Hi Lorenzo, Krzysztof, >On Sun, 29 Nov 2020 23:07:38 +, Krzysztof Wilczyński wrote: >> Unify ECAM-related constants into a single set of standard constants >> defining memory address shift values for the byte-level address that can >> be used when accessing the PCI Express Configuration

Re: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller DT nodes

2020-02-26 Thread Michael Walle
Am 2020-02-24 10:22, schrieb Z.q. Hou: Hi Michael and Shawn, I'll update the patch with iommu-map property. friendly ping :) -michael Thanks, Zhiqiang -Original Message- From: Michael Walle Sent: 2020年2月24日 16:54 To: Shawn Guo Cc: Xiaowei Bao ; Z.q. Hou ; bhelg...@google.com

Re: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller DT nodes

2020-02-24 Thread Michael Walle
Hi Shawn, all, Am 2020-02-24 09:43, schrieb Shawn Guo: On Mon, Feb 24, 2020 at 09:11:05AM +0100, Michael Walle wrote: Hi Xiaowei, Hi Shawn, > LS1028a implements 2 PCIe 3.0 controllers. Patch 1/3 and 3/3 are in Linus' tree but nobody seems to care about this patch anymore :( This does

Re: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller DT nodes

2020-02-24 Thread Michael Walle
, > + ; > + interrupt-names = "pme", "aer"; > + #address-cells = <3>; > + #size-cells = <2>; > + device_type = "pci"; > +

Re: [PATCH v1 3/4] arm64: dts: ls1028a: fix little-big endian issue for dcfg

2019-12-09 Thread Michael Walle
> dcfg use little endian that SoC register value will be correct > > Signed-off-by: Yinbo Zhu > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This patch is still missing. Any news? Tested-by: Michael Walle &

Re: [PATCH] ASoC: fsl_sai: add IRQF_SHARED

2019-12-05 Thread Michael Walle
Hi Daniel, Am 2019-12-05 09:43, schrieb Daniel Baluta: On Fri, Nov 29, 2019 at 12:40 AM Michael Walle wrote: The LS1028A SoC uses the same interrupt line for adjacent SAIs. Use IRQF_SHARED to be able to use these SAIs simultaneously. Hi Michael, Thanks for the patch. We have a similar

[PATCH] ASoC: fsl_sai: add IRQF_SHARED

2019-11-28 Thread Michael Walle
The LS1028A SoC uses the same interrupt line for adjacent SAIs. Use IRQF_SHARED to be able to use these SAIs simultaneously. Signed-off-by: Michael Walle --- sound/soc/fsl/fsl_sai.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl