Re: [PATCH v2 2/3] lkdtm/powerpc: Add SLB multihit test

2020-09-29 Thread Michal Suchánek
orking on integrating this. > > > > > Based on work by Mahesh Salgaonkar and Michal Suchánek. > > > > Cc: Mahesh Salgaonkar > > Cc: Michal Suchánek > > Should these be Co-developed-by: with S-o-b? I don't think I wrote any of this code. I packaged it for SUSE and

Re: [PATCH 0/3] powerpc/mce: Fix mce handler and add selftest

2020-09-17 Thread Michal Suchánek
Hello, On Wed, Sep 16, 2020 at 10:52:25PM +0530, Ganesh Goudar wrote: > This patch series fixes mce handling for pseries, provides debugfs > interface for mce injection and adds selftest to test mce handling > on pseries/powernv machines running in hash mmu mode. > debugfs interface and sleftest

Re: [PATCH 2/3] powerpc/mce: Add debugfs interface to inject MCE

2020-09-17 Thread Michal Suchánek
Hello, On Wed, Sep 16, 2020 at 10:52:27PM +0530, Ganesh Goudar wrote: > To test machine check handling, add debugfs interface to inject > slb multihit errors. > > To inject slb multihit: > #echo 1 > /sys/kernel/debug/powerpc/mce_error_inject/inject_slb_multihit > > Signed-off-by: Ganesh Goudar

Re: [PATCH 1/3] powerpc/mce: remove nmi_enter/exit from real mode handler

2020-09-17 Thread Michal Suchánek
Hello, On Wed, Sep 16, 2020 at 10:52:26PM +0530, Ganesh Goudar wrote: > Use of nmi_enter/exit in real mode handler causes the kernel to panic > and reboot on injecting slb mutihit on pseries machine running in hash > mmu mode, As these calls try to accesses memory outside RMO region in > real

Re: [PATCH] Revert "powerpc/64s: machine check interrupt update NMI accounting"

2020-09-16 Thread Michal Suchánek
On Tue, Sep 15, 2020 at 08:16:42PM +0200, pet...@infradead.org wrote: > On Tue, Sep 15, 2020 at 08:06:59PM +0200, Michal Suchanek wrote: > > This reverts commit 116ac378bb3ff844df333e7609e7604651a0db9d. > > > > This commit causes the kernel to oops and reboot when injecting a SLB > > multihit

Injecting SLB miltihit crashes kernel 5.9.0-rc5

2020-09-15 Thread Michal Suchánek
Hello, Using the SLB mutihit injection test module (which I did not write so I do not want to post it here) to verify updates on my 5.3 frankernekernel I found that the kernel crashes with Oops: kernel bad access. I tested on latest upstream kernel build that I have at hand and the result is te

Re: [PATCH] powerpc/traps: fix recoverability of machine check handling on book3s/32

2020-09-14 Thread Michal Suchánek
On Fri, Sep 11, 2020 at 11:23:57PM +1000, Michael Ellerman wrote: > Michal Suchánek writes: > > Hello, > > > > does this logic apply to "Unrecoverable System Reset" as well? > > Which logic do you mean? > > We do call die() befor

Re: [PATCH] powerpc/traps: fix recoverability of machine check handling on book3s/32

2020-09-11 Thread Michal Suchánek
Hello, does this logic apply to "Unrecoverable System Reset" as well? Thanks Michal On Tue, Jan 22, 2019 at 02:11:24PM +, Christophe Leroy wrote: > Looks like book3s/32 doesn't set RI on machine check, so > checking RI before calling die() will always be fatal > allthought this is not an

Re: [PATCH] KVM: PPC: Book3S HV: Do not allocate HPT for a nested guest

2020-09-11 Thread Michal Suchánek
On Fri, Sep 11, 2020 at 10:01:33AM +0200, Greg Kurz wrote: > On Fri, 11 Sep 2020 09:45:36 +0200 > Greg Kurz wrote: > > > On Fri, 11 Sep 2020 01:16:07 -0300 > > Fabiano Rosas wrote: > > > > > The current nested KVM code does not support HPT guests. This is > > > informed/enforced in some ways:

Re: KVM on POWER8 host lock up since 10d91611f426 ("powerpc/64s: Reimplement book3s idle code in C")

2020-09-07 Thread Michal Suchánek
On Mon, Sep 07, 2020 at 11:13:47PM +1000, Nicholas Piggin wrote: > Excerpts from Michael Ellerman's message of August 31, 2020 8:50 pm: > > Michal Suchánek writes: > >> On Mon, Aug 31, 2020 at 11:14:18AM +1000, Nicholas Piggin wrote: > >>> Excerpts from Michal S

Re: [PATCH v11] Fixup for "powerpc/vdso: Provide __kernel_clock_gettime64() on vdso32"

2020-09-01 Thread Michal Suchánek
Hello, can you add Fixes: ? Thanks Michal On Tue, Sep 01, 2020 at 05:28:57AM +, Christophe Leroy wrote: > Signed-off-by: Christophe Leroy > --- > arch/powerpc/include/asm/vdso/gettimeofday.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: KVM on POWER8 host lock up since 10d91611f426 ("powerpc/64s: Reimplement book3s idle code in C")

2020-08-31 Thread Michal Suchánek
On Mon, Aug 31, 2020 at 11:14:18AM +1000, Nicholas Piggin wrote: > Excerpts from Michal Suchánek's message of August 31, 2020 6:11 am: > > Hello, > > > > on POWER8 KVM hosts lock up since commit 10d91611f426 ("powerpc/64s: > > Reimplement book3s idle code in C"). > > > > The symptom is host

Re: KVM on POWER8 host lock up since 10d91611f426 ("powerpc/64s: Reimplement book3s idle code in C")

2020-08-31 Thread Michal Suchánek
On Mon, Aug 31, 2020 at 11:14:18AM +1000, Nicholas Piggin wrote: > Excerpts from Michal Suchánek's message of August 31, 2020 6:11 am: > > Hello, > > > > on POWER8 KVM hosts lock up since commit 10d91611f426 ("powerpc/64s: > > Reimplement book3s idle code in C"). > > > > The symptom is host

Re: [PATCH v5 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

2020-08-07 Thread Michal Suchánek
On Fri, Aug 07, 2020 at 08:58:09AM +0200, David Hildenbrand wrote: > On 07.08.20 06:32, Andrew Morton wrote: > > On Fri, 3 Jul 2020 18:28:23 +0530 Srikar Dronamraju > > wrote: > > > >>> The memory hotplug changes that somehow because you can hotremove numa > >>> nodes and therefore make the

Re: [PATCH v3 4/6] powerpc/64s: implement queued spinlocks and rwlocks

2020-07-23 Thread Michal Suchánek
On Mon, Jul 06, 2020 at 02:35:38PM +1000, Nicholas Piggin wrote: > These have shown significantly improved performance and fairness when > spinlock contention is moderate to high on very large systems. > > [ Numbers hopefully forthcoming after more testing, but initial >results look good ] >

Re: [PATCH] powerpc/fault: kernel can extend a user process's stack

2020-07-20 Thread Michal Suchánek
Hello, On Wed, Dec 11, 2019 at 08:37:21PM +1100, Daniel Axtens wrote: > > Fixes: 14cf11af6cf6 ("powerpc: Merge enough to start building in > > arch/powerpc.") > > Wow, that's pretty ancient! I'm also not sure it's right - in that same > patch, arch/ppc64/mm/fault.c contains: > > ^1da177e4c3f4

Re: [PATCH v3] powerpc/pseries: detect secure and trusted boot state of the system.

2020-07-17 Thread Michal Suchánek
On Fri, Jul 17, 2020 at 03:58:01PM +1000, Daniel Axtens wrote: > Michal Suchánek writes: > > > On Wed, Jul 15, 2020 at 07:52:01AM -0400, Nayna Jain wrote: > >> The device-tree property to check secure and trusted boot state is > >> different for guests(pseries)

Re: [PATCH net-next] ibmvnic: Increase driver logging

2020-07-16 Thread Michal Suchánek
On Thu, Jul 16, 2020 at 10:59:58AM -0500, Thomas Falcon wrote: > > On 7/15/20 8:29 PM, David Miller wrote: > > From: Jakub Kicinski > > Date: Wed, 15 Jul 2020 17:06:32 -0700 > > > > > On Wed, 15 Jul 2020 18:51:55 -0500 Thomas Falcon wrote: > > > > free_netdev(netdev); > > > >

Re: [PATCH v3] powerpc/pseries: detect secure and trusted boot state of the system.

2020-07-16 Thread Michal Suchánek
On Wed, Jul 15, 2020 at 07:52:01AM -0400, Nayna Jain wrote: > The device-tree property to check secure and trusted boot state is > different for guests(pseries) compared to baremetal(powernv). > > This patch updates the existing is_ppc_secureboot_enabled() and > is_ppc_trustedboot_enabled()

Re: [PATCH v5 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline

2020-07-03 Thread Michal Suchánek
On Wed, Jul 01, 2020 at 02:21:10PM +0200, Michal Hocko wrote: > On Wed 01-07-20 13:30:57, David Hildenbrand wrote: > > On 01.07.20 13:06, David Hildenbrand wrote: > > > On 01.07.20 13:01, Srikar Dronamraju wrote: > > >> * David Hildenbrand [2020-07-01 12:15:54]: > > >> > > >>> On 01.07.20 12:04,

Re: [PATCH v6 6/8] powerpc/pmem: Avoid the barrier in flush routines

2020-06-30 Thread Michal Suchánek
On Mon, Jun 29, 2020 at 06:50:15PM -0700, Dan Williams wrote: > On Mon, Jun 29, 2020 at 1:41 PM Aneesh Kumar K.V > wrote: > > > > Michal Suchánek writes: > > > > > Hello, > > > > > > On Mon, Jun 29, 2020 at 07:27:20PM +0530, Aneesh Kumar K.V wro

Re: [PATCH v6 6/8] powerpc/pmem: Avoid the barrier in flush routines

2020-06-29 Thread Michal Suchánek
Hello, On Mon, Jun 29, 2020 at 07:27:20PM +0530, Aneesh Kumar K.V wrote: > nvdimm expect the flush routines to just mark the cache clean. The barrier > that mark the store globally visible is done in nvdimm_flush(). > > Update the papr_scm driver to a simplified nvdim_flush callback that do >

Re: [PATCH v2 3/5] libnvdimm/nvdimm/flush: Allow architecture to override the flush barrier

2020-06-26 Thread Michal Suchánek
On Fri, May 22, 2020 at 09:01:17AM -0400, Mikulas Patocka wrote: > > > On Fri, 22 May 2020, Aneesh Kumar K.V wrote: > > > On 5/22/20 3:01 PM, Michal Suchánek wrote: > > > On Thu, May 21, 2020 at 02:52:30PM -0400, Mikulas Patocka wrote: > > > > > > > > > > > > On Thu, 21 May 2020, Dan

Re: ppc64le and 32-bit LE userland compatibility

2020-06-02 Thread Michal Suchánek
On Tue, Jun 02, 2020 at 05:40:39PM +0200, Daniel Kolesa wrote: > > > On Tue, Jun 2, 2020, at 17:27, Michal Suchánek wrote: > > On Tue, Jun 02, 2020 at 05:13:25PM +0200, Daniel Kolesa wrote: > > > On Tue, Jun 2, 2020, at 16:23, Michal Suchánek wrote: > > > >

Re: ppc64le and 32-bit LE userland compatibility

2020-06-02 Thread Michal Suchánek
On Tue, Jun 02, 2020 at 05:13:25PM +0200, Daniel Kolesa wrote: > On Tue, Jun 2, 2020, at 16:23, Michal Suchánek wrote: > > On Tue, Jun 02, 2020 at 01:40:23PM +, Joseph Myers wrote: > > > On Tue, 2 Jun 2020, Daniel Kolesa wrote: > > > > > > > not b

Re: ppc64le and 32-bit LE userland compatibility

2020-06-02 Thread Michal Suchánek
On Tue, Jun 02, 2020 at 01:40:23PM +, Joseph Myers wrote: > On Tue, 2 Jun 2020, Daniel Kolesa wrote: > > > not be limited to being just userspace under ppc64le, but should be > > runnable on a native kernel as well, which should not be limited to any > > particular baseline other than just

Re: [RFC PATCH 1/2] libnvdimm: Add prctl control for disabling synchronous fault support.

2020-06-01 Thread Michal Suchánek
; > > > Thanks Michal. I also missed Jeff in this email thread. > > > > > > > > And I think you'll also need some of the sched maintainers for the prctl > > > > bits... > > > > > > > > > On 5/29/20 3:03 PM, Michal Suchánek wrote

Re: [RFC PATCH 1/2] libnvdimm: Add prctl control for disabling synchronous fault support.

2020-05-29 Thread Michal Suchánek
Adding Jan On Fri, May 29, 2020 at 11:11:39AM +0530, Aneesh Kumar K.V wrote: > With POWER10, architecture is adding new pmem flush and sync instructions. > The kernel should prevent the usage of MAP_SYNC if applications are not using > the new instructions on newer hardware. > > This patch adds

Re: [PATCH v2 3/5] libnvdimm/nvdimm/flush: Allow architecture to override the flush barrier

2020-05-22 Thread Michal Suchánek
On Thu, May 21, 2020 at 02:52:30PM -0400, Mikulas Patocka wrote: > > > On Thu, 21 May 2020, Dan Williams wrote: > > > On Thu, May 21, 2020 at 10:03 AM Aneesh Kumar K.V > > wrote: > > > > > > > Moving on to the patch itself--Aneesh, have you audited other persistent > > > > memory users in the

Re: crash in cpuidle_enter_state with 5.7-rc1

2020-04-21 Thread Michal Suchánek
On Tue, Apr 21, 2020 at 10:21:52PM +1000, Michael Ellerman wrote: > Michal Suchánek writes: > > On Mon, Apr 20, 2020 at 08:50:30AM +0200, Michal Suchánek wrote: > >> On Mon, Apr 20, 2020 at 04:15:39PM +1000, Michael Ellerman wrote: > >>

Re: crash in cpuidle_enter_state with 5.7-rc1

2020-04-20 Thread Michal Suchánek
On Mon, Apr 20, 2020 at 08:50:30AM +0200, Michal Suchánek wrote: > Hello, > > On Mon, Apr 20, 2020 at 04:15:39PM +1000, Michael Ellerman wrote: > > Michal Suchánek writes: ... > > > > > > And I've just hit it with your config on a machine here, but the cr

Re: crash in cpuidle_enter_state with 5.7-rc1

2020-04-20 Thread Michal Suchánek
Hello, On Mon, Apr 20, 2020 at 04:15:39PM +1000, Michael Ellerman wrote: > Michal Suchánek writes: > > Hello, > > > > I observe crash in cpuidle_enter_state in early boot on POWER9 pSeries > > machine with 5.7-rc1 kernel. The crash is not 100% reliable. Some

Re: CVE-2020-11669: Linux kernel 4.10 to 5.1: powerpc: guest can cause DoS on POWER9 KVM hosts

2020-04-15 Thread Michal Suchánek
On Wed, Apr 15, 2020 at 10:52:53PM +1000, Andrew Donnellan wrote: > The Linux kernel for powerpc from v4.10 to v5.1 has a bug where the > Authority Mask Register (AMR), Authority Mask Override Register (AMOR) and > User Authority Mask Override Register (UAMOR) are not correctly saved and >

Re: [PATCH v2 2/2] crypto: Remove unnecessary memzero_explicit()

2020-04-14 Thread Michal Suchánek
On Tue, Apr 14, 2020 at 12:24:36PM -0400, Waiman Long wrote: > On 4/14/20 2:08 AM, Christophe Leroy wrote: > > > > > > Le 14/04/2020 à 00:28, Waiman Long a écrit : > >> Since kfree_sensitive() will do an implicit memzero_explicit(), there > >> is no need to call memzero_explicit() before it.

Re: [PATCH] powerpcs: perf: consolidate perf_callchain_user_64 and perf_callchain_user_32

2020-04-09 Thread Michal Suchánek
On Tue, Apr 07, 2020 at 07:21:06AM +0200, Christophe Leroy wrote: > > > Le 06/04/2020 à 23:00, Michal Suchanek a écrit : > > perf_callchain_user_64 and perf_callchain_user_32 are nearly identical. > > Consolidate into one function with thin wrappers. > > > > Suggested-by: Nicholas Piggin > >

Re: [PATCH v12 5/8] powerpc/64: make buildable without CONFIG_COMPAT

2020-04-07 Thread Michal Suchánek
On Tue, Apr 07, 2020 at 07:50:30AM +0200, Christophe Leroy wrote: > > > Le 20/03/2020 à 11:20, Michal Suchanek a écrit : > > There are numerous references to 32bit functions in generic and 64bit > > code so ifdef them out. > > > > Signed-off-by: Michal Suchanek > > --- > > v2: > > - fix 32bit

Re: [PATCH v11 3/8] powerpc/perf: consolidate read_user_stack_32

2020-04-06 Thread Michal Suchánek
On Fri, Apr 03, 2020 at 05:13:25PM +1000, Nicholas Piggin wrote: > Michal Suchánek's on March 25, 2020 5:38 am: > > On Tue, Mar 24, 2020 at 06:48:20PM +1000, Nicholas Piggin wrote: > >> Michal Suchanek's on March 19, 2020 10:19 pm: > >> > There are two almost identical copies for 32bit and 64bit.

Re: [PATCH v11 3/8] powerpc/perf: consolidate read_user_stack_32

2020-04-03 Thread Michal Suchánek
On Fri, Apr 03, 2020 at 09:26:27PM +1000, Nicholas Piggin wrote: > Michal Suchánek's on April 3, 2020 8:52 pm: > > Hello, > > > > there are 3 variants of the function > > > > read_user_stack_64 > > > > 32bit read_user_stack_32 > > 64bit read_user_Stack_32 > > Right. > > > On Fri, Apr 03, 2020

Re: [PATCH v11 3/8] powerpc/perf: consolidate read_user_stack_32

2020-04-03 Thread Michal Suchánek
Hello, there are 3 variants of the function read_user_stack_64 32bit read_user_stack_32 64bit read_user_Stack_32 On Fri, Apr 03, 2020 at 05:13:25PM +1000, Nicholas Piggin wrote: > Michal Suchánek's on March 25, 2020 5:38 am: > > On Tue, Mar 24, 2020 at 06:48:20PM +1000, Nicholas Piggin wrote:

Re: [PATCH] powerpc/64: Fix section mismatch warnings.

2020-03-26 Thread Michal Suchánek
On Thu, Mar 26, 2020 at 11:22:03PM +0530, Naveen N. Rao wrote: > Michal Suchanek wrote: > > Fixes the following warnings: > > > > WARNING: vmlinux.o(.text+0x2d24): Section mismatch in reference from the > > variable __boot_from_prom to the function .init.text:prom_init() > > The function

Re: [PATCH v11 3/8] powerpc/perf: consolidate read_user_stack_32

2020-03-24 Thread Michal Suchánek
On Tue, Mar 24, 2020 at 06:48:20PM +1000, Nicholas Piggin wrote: > Michal Suchanek's on March 19, 2020 10:19 pm: > > There are two almost identical copies for 32bit and 64bit. > > > > The function is used only in 32bit code which will be split out in next > > patch so consolidate to one function.

Re: [PATCH v11 5/8] powerpc/64: make buildable without CONFIG_COMPAT

2020-03-24 Thread Michal Suchánek
On Tue, Mar 24, 2020 at 06:54:20PM +1000, Nicholas Piggin wrote: > Michal Suchanek's on March 19, 2020 10:19 pm: > > diff --git a/arch/powerpc/kernel/signal.c b/arch/powerpc/kernel/signal.c > > index 4b0152108f61..a264989626fd 100644 > > --- a/arch/powerpc/kernel/signal.c > > +++

Re: [PATCH v12 8/8] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry.

2020-03-20 Thread Michal Suchánek
On Fri, Mar 20, 2020 at 06:31:57PM +0200, Andy Shevchenko wrote: > On Fri, Mar 20, 2020 at 07:42:03AM -0700, Joe Perches wrote: > > On Fri, 2020-03-20 at 14:42 +0200, Andy Shevchenko wrote: > > > On Fri, Mar 20, 2020 at 12:23:38PM +0100, Michal Suchánek wrote: > > > >

Re: [PATCH v12 8/8] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry.

2020-03-20 Thread Michal Suchánek
On Fri, Mar 20, 2020 at 07:42:03AM -0700, Joe Perches wrote: > On Fri, 2020-03-20 at 14:42 +0200, Andy Shevchenko wrote: > > On Fri, Mar 20, 2020 at 12:23:38PM +0100, Michal Suchánek wrote: > > > On Fri, Mar 20, 2020 at 12:33:50PM +0200, Andy Shevchenko wrote: > > > >

Re: [PATCH v12 8/8] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry.

2020-03-20 Thread Michal Suchánek
On Fri, Mar 20, 2020 at 12:33:50PM +0200, Andy Shevchenko wrote: > On Fri, Mar 20, 2020 at 11:20:19AM +0100, Michal Suchanek wrote: > > While at it also simplify the existing perf patterns. > > > > And still missed fixes from parse-maintainers.pl. Oh, that script UX is truly ingenious. It

Re: [PATCH -v2] treewide: Rename "unencrypted" to "decrypted"

2020-03-19 Thread Michal Suchánek
On Thu, Mar 19, 2020 at 06:25:49PM +0100, Thomas Gleixner wrote: > Borislav Petkov writes: > > > On Thu, Mar 19, 2020 at 11:06:15AM +, Robin Murphy wrote: > >> Let me add another vote from a native English speaker that "unencrypted" is > >> the appropriate term to imply the *absence* of

Re: [PATCH v11 4/8] powerpc/perf: consolidate valid_user_sp

2020-03-19 Thread Michal Suchánek
On Thu, Mar 19, 2020 at 03:16:03PM +0100, Christophe Leroy wrote: > > > Le 19/03/2020 à 14:35, Andy Shevchenko a écrit : > > On Thu, Mar 19, 2020 at 1:54 PM Michal Suchanek wrote: > > > > > > Merge the 32bit and 64bit version. > > > > > > Halve the check constants on 32bit. > > > > > > Use

Re: [PATCH v11 4/8] powerpc/perf: consolidate valid_user_sp

2020-03-19 Thread Michal Suchánek
On Thu, Mar 19, 2020 at 03:35:03PM +0200, Andy Shevchenko wrote: > On Thu, Mar 19, 2020 at 1:54 PM Michal Suchanek wrote: > > > > Merge the 32bit and 64bit version. > > > > Halve the check constants on 32bit. > > > > Use STACK_TOP since it is defined. > > > > Passing is_64 is now redundant since

Re: [PATCH v11 0/8] Disable compat cruft on ppc64le v11

2020-03-19 Thread Michal Suchánek
On Thu, Mar 19, 2020 at 01:36:56PM +0100, Christophe Leroy wrote: > You sent it twice ? Any difference between the two dispatch ? Some headers were broken the first time around. Thanks Michal > > Christophe > > Le 19/03/2020 à 13:19, Michal Suchanek a écrit : > > Less code means less bugs so

Re: [PATCH v11 8/8] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry.

2020-03-19 Thread Michal Suchánek
On Thu, Mar 19, 2020 at 03:37:03PM +0200, Andy Shevchenko wrote: > On Thu, Mar 19, 2020 at 2:21 PM Michal Suchanek wrote: > > > > Signed-off-by: Michal Suchanek > > --- > > v10: new patch > > --- > > MAINTAINERS | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/MAINTAINERS

Re: [PATCH v11 0/8] Disable compat cruft on ppc64le v11

2020-03-19 Thread Michal Suchánek
Lost some headers so will resend. On Thu, Mar 19, 2020 at 12:52:20PM +0100, Michal Suchanek wrote: > Less code means less bugs so add a knob to skip the compat stuff. > > Changes in v2: saner CONFIG_COMPAT ifdefs > Changes in v3: > - change llseek to 32bit instead of builing it unconditionally

Re: [RFC PATCH v1] pseries/drmem: don't cache node id in drmem_lmb struct

2020-03-11 Thread Michal Suchánek
On Wed, Mar 11, 2020 at 06:08:15PM -0500, Scott Cheloha wrote: > At memory hot-remove time we can retrieve an LMB's nid from its > corresponding memory_block. There is no need to store the nid > in multiple locations. > > Signed-off-by: Scott Cheloha > --- > The linear search in powerpc's

Re: [PATCH rebased 1/2] powerpc: reserve memory for capture kernel after hugepages init

2020-03-05 Thread Michal Suchánek
Hello, This seems to cause crash with kdump reservation 1GB quite reliably. Thanks Michal On Tue, Feb 18, 2020 at 05:28:34PM +0100, Michal Suchanek wrote: > From: Hari Bathini > > Sometimes, memory reservation for KDump/FADump can overlap with memory > marked for hugepages. This overlap

Re: [PATCH 2/2] powerpc: avoid adjusting memory_limit for capture kernel memory reservation

2020-02-18 Thread Michal Suchánek
On Fri, Jun 28, 2019 at 12:51:19AM +0530, Hari Bathini wrote: > Currently, if memory_limit is specified and it overlaps with memory to > be reserved for capture kernel, memory_limit is adjusted to accommodate > capture kernel. With memory reservation for capture kernel moved later > (after

Re: [PATCH] powerpc/process: Remove unneccessary #ifdef CONFIG_PPC64 in copy_thread_tls()

2020-01-29 Thread Michal Suchánek
On Wed, Jan 29, 2020 at 07:50:07PM +, Christophe Leroy wrote: > is_32bit_task() exists on both PPC64 and PPC32, no need of an ifdefery. > > Signed-off-by: Christophe Leroy > --- > arch/powerpc/kernel/process.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git

Re: [PATCH] powerpc/64: system call implement the bulk of the logic in C fix

2020-01-28 Thread Michal Suchánek
On Tue, Jan 28, 2020 at 10:41:02AM +1000, Nicholas Piggin wrote: > Michal Suchánek's on January 28, 2020 4:08 am: > > On Tue, Jan 28, 2020 at 12:17:12AM +1000, Nicholas Piggin wrote: > >> This incremental patch fixes several soft-mask debug and unsafe > >> smp_processor_id messages due to tracing

Re: [PATCH] powerpc/64: system call implement the bulk of the logic in C fix

2020-01-27 Thread Michal Suchánek
On Tue, Jan 28, 2020 at 12:17:12AM +1000, Nicholas Piggin wrote: > This incremental patch fixes several soft-mask debug and unsafe > smp_processor_id messages due to tracing and false positives in > "unreconciled" code. > > It also fixes a bug with syscall tracing functions that set registers >

Re: [PATCH] powerpc: drmem: avoid NULL pointer dereference when drmem is unavailable

2020-01-23 Thread Michal Suchánek
On Thu, Jan 23, 2020 at 09:56:10AM -0600, Nathan Lynch wrote: > Hello and thanks for the patch. > > Libor Pechacek writes: > > In KVM guests drmem structure is only zero initialized. Trying to > > manipulate DLPAR parameters results in a crash in this environment. > > I think this statement

Re: [PATCH] powerpc: drmem: avoid NULL pointer dereference when drmem is unavailable

2020-01-22 Thread Michal Suchánek
On Thu, Jan 16, 2020 at 11:27:58AM +0100, Libor Pechacek wrote: > In KVM guests drmem structure is only zero initialized. Trying to > manipulate DLPAR parameters results in a crash in this environment. > > $ echo "memory add count 1" > /sys/kernel/dlpar > Oops: Kernel access of bad area, sig: 11

Re: [PATCH v6 3/6] powerpc/fadump: reorganize /sys/kernel/fadump_* sysfs files

2020-01-08 Thread Michal Suchánek
On Wed, Dec 11, 2019 at 09:39:07PM +0530, Sourabh Jain wrote: > As the number of FADump sysfs files increases it is hard to manage all of > them inside /sys/kernel directory. It's better to have all the FADump > related sysfs files in a dedicated directory /sys/kernel/fadump. But in > order to

Re: [PATCH 2/2] powerpc: avoid adjusting memory_limit for capture kernel memory reservation

2020-01-06 Thread Michal Suchánek
On Wed, Jul 24, 2019 at 11:26:59AM +0530, Mahesh Jagannath Salgaonkar wrote: > On 7/22/19 11:19 PM, Michal Suchánek wrote: > > On Fri, 28 Jun 2019 00:51:19 +0530 > > Hari Bathini wrote: > > > >> Currently, if memory_limit is specified and it overlaps with memory t

Re: [PATCH v15 06/23] selftests/vm/pkeys: Typecast the pkey register

2019-12-18 Thread Michal Suchánek
On Wed, Dec 18, 2019 at 01:01:46PM -0800, Dave Hansen wrote: > On 12/18/19 12:59 PM, Michal Suchánek wrote: > >> I'd really just rather do %016lx *everywhere* than sprinkle the > >> PKEY_REG_FMTs around. > > Does lx work with u32 without warnings? > > Either way,

Re: [PATCH v15 06/23] selftests/vm/pkeys: Typecast the pkey register

2019-12-18 Thread Michal Suchánek
On Wed, Dec 18, 2019 at 12:46:50PM -0800, Dave Hansen wrote: > On 12/17/19 11:51 PM, Sandipan Das wrote: > > write_pkey_reg(pkey_reg); > > - dprintf4("pkey_reg now: %08x\n", read_pkey_reg()); > > + dprintf4("pkey_reg now: "PKEY_REG_FMT"\n", read_pkey_reg()); > > } > > > > #define

Re: [PATCH] powerpc: Add barrier_nospec to raw_copy_in_user()

2019-12-15 Thread Michal Suchánek
On Thu, Sep 19, 2019 at 12:04:27AM +1000, Michael Ellerman wrote: > Michal Suchánek writes: > > On Wed, 6 Mar 2019 12:10:38 +1100 > > Suraj Jitindar Singh wrote: > > > >> Commit ddf35cf3764b ("powerpc: Use barrier_nospec in copy_from_user()") > >&

Re: [PATCH] powerpc/fault: kernel can extend a user process's stack

2019-12-10 Thread Michal Suchánek
On Wed, Dec 11, 2019 at 12:43:37PM +1100, Daniel Axtens wrote: > If a process page-faults trying to write beyond the end of its > stack, we attempt to grow the stack. > > However, if the kernel attempts to write beyond the end of a > process's stack, it takes a bad fault. This can occur when the

Re: [PATCH v2 29/35] powerpc/perf: remove current_is_64bit()

2019-11-27 Thread Michal Suchánek
On Wed, Nov 27, 2019 at 06:41:09AM +0100, Christophe Leroy wrote: > > > Le 26/11/2019 à 21:13, Michal Suchanek a écrit : > > Since commit ed1cd6deb013 ("powerpc: Activate CONFIG_THREAD_INFO_IN_TASK") > > current_is_64bit() is quivalent to !is_32bit_task(). > > Remove the redundant function. > >

Re: [PATCH v3 2/4] powerpc/fadump: reorganize /sys/kernel/fadump_* sysfs files

2019-11-24 Thread Michal Suchánek
On Sat, Nov 16, 2019 at 08:07:29PM +0530, Sourabh Jain wrote: > > > On 11/9/19 6:29 PM, Michal Suchánek wrote: > > On Sat, Nov 09, 2019 at 05:53:37PM +0530, Sourabh Jain wrote: > >> As the number of FADump sysfs files increases it is hard to manage all of > >>

Re: WARN_ONCE does not warn once

2019-11-15 Thread Michal Suchánek
On Fri, Nov 15, 2019 at 09:44:34AM +0100, Michal Suchánek wrote: > On Fri, Nov 15, 2019 at 03:43:24PM +1100, Michael Ellerman wrote: > > Michal Suchánek writes: > > > On Thu, Nov 14, 2019 at 05:46:55PM +0100, Michal Suchánek wrote: > > >> Hello, > > >>

Re: WARN_ONCE does not warn once

2019-11-14 Thread Michal Suchánek
On Thu, Nov 14, 2019 at 05:46:55PM +0100, Michal Suchánek wrote: > Hello, > > on powernv with 5.3.8 kernel I get flood of messages on boot. > > The messages match WARN_ONCE(1, "opal: OPAL_CONSOLE_FLUSH missing.\n"); Asking around it was pointed out that WARN_ONCE

WARN_ONCE does not warn once

2019-11-14 Thread Michal Suchánek
Hello, on powernv with 5.3.8 kernel I get flood of messages on boot. The messages match WARN_ONCE(1, "opal: OPAL_CONSOLE_FLUSH missing.\n"); [ cut here ] opal: OPAL_CONSOLE_FLUSH missing. WARNING: CPU: 0 PID: 0 at ../arch/powerpc/platforms/powernv/opal.c:435

Re: [PATCH] Fix wrong message when RFI Flush is disable

2019-11-14 Thread Michal Suchánek
On Thu, Nov 14, 2019 at 08:07:35PM +1100, Michael Ellerman wrote: > On Thu, 2019-05-02 at 21:09:07 UTC, Gustavo Walbon wrote: > > From: "Gustavo L. F. Walbon" > > > > The issue was showing "Mitigation" message via sysfs whatever the state of > > "RFI Flush", but it should show "Vulnerable" when

Re: [PATCH 31/33] powerpc/64: make buildable without CONFIG_COMPAT

2019-11-13 Thread Michal Suchánek
On Wed, Nov 13, 2019 at 01:02:34PM +1000, Nicholas Piggin wrote: > Michal Suchanek's on November 13, 2019 2:52 am: > > There are numerous references to 32bit functions in generic and 64bit > > code so ifdef them out. > > > > Signed-off-by: Michal Suchanek > > For the most part these seem okay

Re: [PATCH v3 2/4] powerpc/fadump: reorganize /sys/kernel/fadump_* sysfs files

2019-11-09 Thread Michal Suchánek
On Sat, Nov 09, 2019 at 05:53:37PM +0530, Sourabh Jain wrote: > As the number of FADump sysfs files increases it is hard to manage all of > them inside /sys/kernel directory. It's better to have all the FADump > related sysfs files in a dedicated directory /sys/kernel/fadump. But in > order to

Re: [PATCH] powerpc/fadump: Remove duplicate message.

2019-11-07 Thread Michal Suchánek
On Thu, Oct 24, 2019 at 01:16:51PM +0200, Michal Suchánek wrote: > On Thu, Oct 24, 2019 at 04:08:08PM +0530, Hari Bathini wrote: > > > > Michal, thanks for looking into this. > > > > On 23/10/19 11:26 PM, Michal Suchanek wrote: > > > There is duplicate messa

Re: [RFC PATCH 00/27] current interrupt series plus scv syscall

2019-10-30 Thread Michal Suchánek
Hello, On Wed, Oct 02, 2019 at 01:13:52PM +1000, Nicholas Piggin wrote: > Michal Suchánek's on September 24, 2019 7:33 pm: > > Hello, > > > > can you mark the individual patches with RFC rather than the wole > > series? > > Hey, thanks for the reviews. I'll resend all but the last two patches >

Re: [PATCH] powerpc/fadump: Remove duplicate message.

2019-10-24 Thread Michal Suchánek
On Thu, Oct 24, 2019 at 04:08:08PM +0530, Hari Bathini wrote: > > Michal, thanks for looking into this. > > On 23/10/19 11:26 PM, Michal Suchanek wrote: > > There is duplicate message about lack of support by firmware in > > fadump_reserve_mem and setup_fadump. Due to different capitalization it

Re: [RFC PATCH 23/27] powerpc/64: system call implement the bulk of the logic in C

2019-10-02 Thread Michal Suchánek
On Sun, Sep 15, 2019 at 11:28:09AM +1000, Nicholas Piggin wrote: > System call entry and particularly exit code is beyond the limit of what > is reasonable to implement in asm. > > This conversion moves all conditional branches out of the asm code, > except for the case that all GPRs should be

Re: [RFC PATCH 27/27] powerpc/64s: system call support for scv/rfscv instructions

2019-10-02 Thread Michal Suchánek
On Sun, Sep 15, 2019 at 11:28:13AM +1000, Nicholas Piggin wrote: > Add support for the scv instruction on POWER9 and later CPUs. > > For now this implements the zeroth scv vector 'scv 0', as identical > to 'sc' system calls, with the exception that lr is not preserved, and > it is 64-bit only.

Re: [RFC PATCH 24/27] powerpc/64s: interrupt return in C

2019-10-02 Thread Michal Suchánek
On Sun, Sep 15, 2019 at 11:28:10AM +1000, Nicholas Piggin wrote: > Implement the bulk of interrupt return logic in C. The asm return code > must handle a few cases: restoring full GPRs, and emulating stack store. > > The asm return code is moved into 64e for now. The new logic has made >

Re: [RFC PATCH 00/27] current interrupt series plus scv syscall

2019-10-02 Thread Michal Suchánek
Hello, can you mark the individual patches with RFC rather than the wole series? Thanks Michal On Sun, Sep 15, 2019 at 11:27:46AM +1000, Nicholas Piggin wrote: > My interrupt entry patches have finally collided with syscall and > interrupt exit patches, so I'll merge the series. Most patches

Re: [PATCH v7 5/6] powerpc/64: Make COMPAT user-selectable disabled on littleendian by default.

2019-09-14 Thread Michal Suchánek
On Tue, 03 Sep 2019 10:00:57 +1000 Michael Ellerman wrote: > Michal Suchánek writes: > > On Mon, 02 Sep 2019 12:03:12 +1000 > > Michael Ellerman wrote: > > > >> Michal Suchanek writes: > >> > On bigendian ppc64 it is common to have 32b

Re: [PATCH v8 5/7] powerpc/64: make buildable without CONFIG_COMPAT

2019-09-12 Thread Michal Suchánek
On Thu, 12 Sep 2019 21:36:11 +0200 Christophe Leroy wrote: > Le 12/09/2019 à 20:26, Michal Suchánek a écrit : > > On Thu, 12 Sep 2019 20:02:16 +0200 > > Christophe Leroy wrote: > > > >> Le 12/09/2019 à 19:26, Michal Suchanek a écrit : > >>> There

Re: [PATCH v8 5/7] powerpc/64: make buildable without CONFIG_COMPAT

2019-09-12 Thread Michal Suchánek
On Thu, 12 Sep 2019 20:02:16 +0200 Christophe Leroy wrote: > Le 12/09/2019 à 19:26, Michal Suchanek a écrit : > > There are numerous references to 32bit functions in generic and 64bit > > code so ifdef them out. > > > > Signed-off-by: Michal Suchanek > > --- > > v2: > > - fix 32bit ifdef

Re: [PATCH v3] powerpc/64: system call implement the bulk of the logic in C

2019-09-05 Thread Michal Suchánek
On Thu, 5 Sep 2019 15:25:31 + Christophe Leroy wrote: > On 09/05/2019 12:35 PM, Nicholas Piggin wrote: > > System call entry and particularly exit code is beyond the limit of what > > is reasonable to implement in asm. > > > > This conversion moves all conditional branches out of the asm

Re: [PATCH v2] powerpc/fadump: when fadump is supported register the fadump sysfs files.

2019-09-04 Thread Michal Suchánek
On Thu, 29 Aug 2019 10:58:16 +0530 Hari Bathini wrote: > On 28/08/19 10:57 PM, Michal Suchanek wrote: > > Currently it is not possible to distinguish the case when fadump is > > supported by firmware and disabled in kernel and completely unsupported > > using the kernel sysfs interface. User can

Re: [PATCH v7 5/6] powerpc/64: Make COMPAT user-selectable disabled on littleendian by default.

2019-09-02 Thread Michal Suchánek
On Mon, 02 Sep 2019 12:03:12 +1000 Michael Ellerman wrote: > Michal Suchanek writes: > > On bigendian ppc64 it is common to have 32bit legacy binaries but much > > less so on littleendian. > > I think the toolchain people will tell you that there is no 32-bit > little endian ABI defined at

Re: [PATCH v7 3/6] powerpc/perf: consolidate read_user_stack_32

2019-09-02 Thread Michal Suchánek
On Mon, 02 Sep 2019 14:01:17 +1000 Michael Ellerman wrote: > Michael Ellerman writes: > > Michal Suchanek writes: > ... > >> @@ -295,6 +279,12 @@ static inline int current_is_64bit(void) > >> } > >> > >> #else /* CONFIG_PPC64 */ > >> +static int read_user_stack_slow(void __user *ptr,

Re: [PATCH v7 6/6] powerpc/perf: split callchain.c by bitness

2019-08-31 Thread Michal Suchánek
On Fri, 30 Aug 2019 23:03:43 +0200 Michal Suchanek wrote: > Building callchain.c with !COMPAT proved quite ugly with all the > defines. Splitting out the 32bit and 64bit parts looks better. > > No code change intended. valid_user_sp is broken in compat. It needs to be ifdefed for the 32bit

Re: [PATCH v7 0/6] Disable compat cruft on ppc64le v7

2019-08-31 Thread Michal Suchánek
On Sat, 31 Aug 2019 08:41:58 +0200 Christophe Leroy wrote: > Le 30/08/2019 à 23:03, Michal Suchanek a écrit : > > Less code means less bugs so add a knob to skip the compat stuff. > > I guess on PPC64 you have Gigabytes of memory and thousands of bogomips, > hence you focus on bugs. > > My

Re: [PATCH v7 4/6] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-31 Thread Michal Suchánek
On Fri, 30 Aug 2019 23:03:41 +0200 Michal Suchanek wrote: > There are numerous references to 32bit functions in generic and 64bit > code so ifdef them out. > > Signed-off-by: Michal Suchanek > --- > v2: > - fix 32bit ifdef condition in signal.c > - simplify the compat ifdef condition in vdso.c

Re: [PATCH v6 4/6] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-30 Thread Michal Suchánek
On Fri, 30 Aug 2019 22:21:09 +0200 Christophe Leroy wrote: > Le 30/08/2019 à 20:57, Michal Suchanek a écrit : > > There are numerous references to 32bit functions in generic and 64bit > > code so ifdef them out. > > > > Signed-off-by: Michal Suchanek > > --- > > v2: > > - fix 32bit ifdef

Re: [PATCH] Revert "asm-generic: Remove unneeded __ARCH_WANT_SYS_LLSEEK macro"

2019-08-30 Thread Michal Suchánek
On Fri, 30 Aug 2019 21:54:43 +0200 Arnd Bergmann wrote: > On Fri, Aug 30, 2019 at 9:46 PM Michal Suchanek wrote: > > > > This reverts commit caf6f9c8a326cffd1d4b3ff3f1cfba75d159d70b. > > > > Maybe it was needed after all. > > > > When CONFIG_COMPAT is disabled on ppc64 the kernel does not

Re: [PATCH v2 4/4] powerpc/64: system call implement the bulk of the logic in C

2019-08-30 Thread Michal Suchánek
On Sat, 31 Aug 2019 02:48:26 +0800 kbuild test robot wrote: > Hi Nicholas, > > I love your patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [cannot apply to v5.3-rc6 next-20190830] > [if your patch is applied to the wrong git tree, please drop us a note to > help

Re: [PATCH v6 6/6] powerpc/perf: split callchain.c by bitness

2019-08-30 Thread Michal Suchánek
On Fri, 30 Aug 2019 20:57:57 +0200 Michal Suchanek wrote: > Building callchain.c with !COMPAT proved quite ugly with all the > defines. Splitting out the 32bit and 64bit parts looks better. > BTW the powerpc callchain.c does not match any of the patterns of PERF CORE in MAINTAINERS (unlike

Re: [PATCH v5 3/5] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-30 Thread Michal Suchánek
On Fri, 30 Aug 2019 06:35:13 + (UTC) Christophe Leroy wrote: > On 08/29/2019 10:28 PM, Michal Suchanek wrote: > > There are numerous references to 32bit functions in generic and 64bit > > code so ifdef them out. > > > > Signed-off-by: Michal Suchanek > > --- > > v2: > > - fix 32bit ifdef

Re: [PATCH v5 5/5] powerpc/perf: split callchain.c by bitness

2019-08-30 Thread Michal Suchánek
On Fri, 30 Aug 2019 08:42:25 +0200 Michal Suchánek wrote: > On Fri, 30 Aug 2019 06:35:11 + (UTC) > Christophe Leroy wrote: > > > On 08/29/2019 10:28 PM, Michal Suchanek wrote: > > obj-$(CONFIG_PPC_PERF_CTRS)+= core-book3s.o bhrb.o > > diff --git a/arc

Re: [PATCH v5 5/5] powerpc/perf: split callchain.c by bitness

2019-08-30 Thread Michal Suchánek
On Fri, 30 Aug 2019 06:35:11 + (UTC) Christophe Leroy wrote: > On 08/29/2019 10:28 PM, Michal Suchanek wrote: > > Building callchain.c with !COMPAT proved quite ugly with all the > > defines. Splitting out the 32bit and 64bit parts looks better. > > > > Also rewrite current_is_64bit as

Re: [PATCH 1/3] scsi: cxlflash: Fix fallthrough warnings.

2019-08-29 Thread Michal Suchánek
On Thu, 29 Aug 2019 15:34:08 -0500 Uma Krishnan wrote: > Below commit queued up for 5.4 includes these changes. > > commit 657bd277c162580674ddb86a90c4aeb62639bff5 > Author: Gustavo A. R. Silva > Date:   Sun Jul 28 19:21:19 2019 -0500 > > Thanks, > Uma Krishnan Works for me as well. Thanks

Re: [PATCH v4 1/4] powerpc: make llseek 32bit-only.

2019-08-29 Thread Michal Suchánek
On Thu, 29 Aug 2019 16:32:50 +0200 Arnd Bergmann wrote: > On Thu, Aug 29, 2019 at 4:19 PM Michal Suchánek wrote: > > On Thu, 29 Aug 2019 14:57:39 +0200 Arnd Bergmann wrote: > > > On Thu, Aug 29, 2019 at 2:37 PM Michal Suchánek > > > wrote: > > > >

Re: [PATCH v4 3/4] powerpc/64: make buildable without CONFIG_COMPAT

2019-08-29 Thread Michal Suchánek
On Thu, 29 Aug 2019 19:40:55 +0200 Christophe Leroy wrote: > Le 29/08/2019 à 12:23, Michal Suchanek a écrit : > > There are numerous references to 32bit functions in generic and 64bit > > code so ifdef them out. > > > > Signed-off-by: Michal Suchanek > > --- > > v2: > > - fix 32bit ifdef

  1   2   3   >