9089439 100644
> --- a/drivers/i2c/busses/i2c-uniphier-f.c
> +++ b/drivers/i2c/busses/i2c-uniphier-f.c
> @@ -550,15 +550,10 @@ static int uniphier_fi2c_probe(struct platform_device
> *pdev)
> }
>
> ret = i2c_add_adapter(>adap);
> - if (ret) {
> - dev_err(dev, "failed to add I2C adapter\n");
> - goto err;
> - }
> -
> -err:
> if (ret)
> clk_disable_unprepare(priv->clk);
>
> + err:
> return ret;
> }
>
> diff --git a/drivers/i2c/busses/i2c-uniphier.c
> b/drivers/i2c/busses/i2c-uniphier.c
> index 475a5eb514e215..94f64cccfdef08 100644
> --- a/drivers/i2c/busses/i2c-uniphier.c
> +++ b/drivers/i2c/busses/i2c-uniphier.c
> @@ -407,15 +407,10 @@ static int uniphier_i2c_probe(struct platform_device
> *pdev)
> }
>
> ret = i2c_add_adapter(>adap);
> - if (ret) {
> - dev_err(dev, "failed to add I2C adapter\n");
> - goto err;
> - }
> -
> -err:
> if (ret)
> clk_disable_unprepare(priv->clk);
>
> + err:
> return ret;
> }
>
> diff --git a/drivers/i2c/busses/i2c-wmt.c b/drivers/i2c/busses/i2c-wmt.c
> index e1e3a85596c562..fbd0fd59f31239 100644
> --- a/drivers/i2c/busses/i2c-wmt.c
> +++ b/drivers/i2c/busses/i2c-wmt.c
> @@ -432,10 +432,8 @@ static int wmt_i2c_probe(struct platform_device *pdev)
> }
>
> err = i2c_add_adapter(adap);
> - if (err) {
> - dev_err(>dev, "failed to add adapter\n");
> + if (err)
> return err;
> - }
>
> platform_set_drvdata(pdev, i2c_dev);
>
> diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c
> b/drivers/i2c/busses/i2c-xgene-slimpro.c
> index 4233f5695352fd..263685c7a51287 100644
> --- a/drivers/i2c/busses/i2c-xgene-slimpro.c
> +++ b/drivers/i2c/busses/i2c-xgene-slimpro.c
> @@ -418,7 +418,6 @@ static int xgene_slimpro_i2c_probe(struct platform_device
> *pdev)
> i2c_set_adapdata(adapter, ctx);
> rc = i2c_add_adapter(adapter);
> if (rc) {
> - dev_err(>dev, "Adapter registeration failed\n");
> mbox_free_channel(ctx->mbox_chan);
> return rc;
> }
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index 74f54f2f471fa7..66bce3b311a199 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -804,7 +804,6 @@ static int xiic_i2c_probe(struct platform_device *pdev)
> /* add i2c adapter to i2c tree */
> ret = i2c_add_adapter(>adap);
> if (ret) {
> - dev_err(>dev, "Failed to add adapter\n");
> xiic_deinit(i2c);
> goto err_clk_dis;
> }
> diff --git a/drivers/i2c/busses/i2c-xlp9xx.c b/drivers/i2c/busses/i2c-xlp9xx.c
> index 55a7bef1b2e1df..2a972ed7aa0df1 100644
> --- a/drivers/i2c/busses/i2c-xlp9xx.c
> +++ b/drivers/i2c/busses/i2c-xlp9xx.c
> @@ -400,10 +400,8 @@ static int xlp9xx_i2c_probe(struct platform_device *pdev)
> i2c_set_adapdata(>adapter, priv);
>
> err = i2c_add_adapter(>adapter);
> - if (err) {
> - dev_err(>dev, "failed to add I2C adapter!\n");
> + if (err)
> return err;
> - }
>
> platform_set_drvdata(pdev, priv);
> dev_dbg(>dev, "I2C bus:%d added\n", priv->adapter.nr);
> diff --git a/drivers/i2c/busses/i2c-xlr.c b/drivers/i2c/busses/i2c-xlr.c
> index 613c3a4f2c5142..0968f59b6df586 100644
> --- a/drivers/i2c/busses/i2c-xlr.c
> +++ b/drivers/i2c/busses/i2c-xlr.c
> @@ -432,10 +432,8 @@ static int xlr_i2c_probe(struct platform_device *pdev)
>
> i2c_set_adapdata(>adap, priv);
> ret = i2c_add_numbered_adapter(>adap);
> - if (ret < 0) {
> - dev_err(>adap.dev, "Failed to add i2c bus.\n");
> + if (ret < 0)
> return ret;
> - }
>
> platform_set_drvdata(pdev, priv);
> dev_info(>adap.dev, "Added I2C Bus.\n");
> --
> 2.8.1
>
>
Acked-by: Neil Horman <nhor...@tuxdriver.com>
On Tue, Apr 08, 2014 at 09:56:10AM +0200, Gerhard Sittig wrote:
[ removed cscope-devel from Cc:, non-subscriber mails get blocked anyway ]
On Mon, 2014-04-07 at 14:42 +0200, Gerhard Sittig wrote:
On Mon, 2014-04-07 at 06:42 -0400, Neil Horman wrote:
On Thu, Apr 03, 2014 at 03:16
On Thu, Apr 03, 2014 at 03:16:15PM +0200, Yann Droneaud wrote:
Hi,
I'm using cscope to browse kernel sources, but I'm facing warnings from
the tool since following commit:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=22d651dcef536c75f75537290bf3da5038e68b6b
On Mon, Apr 07, 2014 at 02:42:59PM +0200, Gerhard Sittig wrote:
On Mon, 2014-04-07 at 06:42 -0400, Neil Horman wrote:
On Thu, Apr 03, 2014 at 03:16:15PM +0200, Yann Droneaud wrote:
[ ... ]
cscope reports error when generating the cross-reference database:
$ make
tested a relocatable kernel forced to run at a non zero physical
address (ie basically kdump). I verified CRCs were bad with your
original patch backed out, and were good with this patch applied.
Anton
Perfect, sounds like a sufficient test to me.
Acked-by: Neil Horman nhor...@tuxdriver.com
On Thu, Jul 25, 2013 at 09:14:25AM +1000, Benjamin Herrenschmidt wrote:
On Thu, 2013-07-25 at 08:34 +1000, Anton Blanchard wrote:
Apart from the annoying colors, is there anything specific I should
be looking for? Some sort of error message, or output that actually
makes sense?
On Fri, Sep 24, 2010 at 04:56:34PM +1000, Michael Neuling wrote:
size_t size =3D 0;
FILE *file;
sprintf(buf, /proc/irq/%i/smp_affinity,
number);
- file =3D fopen(buf, r);
+
On Thu, Sep 23, 2010 at 08:57:20PM +1000, Michael Neuling wrote:
+ if (fwrite(line, strlen(line) - 1, 1, file) == 0)
if (fputs(line, file) == EOF)
Good point thanks... new patch below
Mikey
irqbalance, powerpc: add IRQs without settable SMP affinity to banned list
On
On Thu, Aug 05, 2010 at 12:04:26PM +1000, Benjamin Herrenschmidt wrote:
On Wed, 2010-08-04 at 10:49 -0400, Neil Horman wrote:
Ping yet again. Ben, This needs review/acceptance from you or Paul
Neil
Isn't it already in powerpc-next about to be pulled by Linus ?
Yes
On Tue, Jul 13, 2010 at 09:46:09AM -0400, Neil Horman wrote:
Hey all-
About 2 years ago now, I sent this patch upstream to allow makedumpfile
to properly filter cores on ppc64:
http://www.mail-archive.com/ke...@lists.infradead.org/msg02426.html
It got acks from the kexec folks so I
On Tue, Jul 13, 2010 at 09:46:09AM -0400, Neil Horman wrote:
Hey all-
About 2 years ago now, I sent this patch upstream to allow makedumpfile
to properly filter cores on ppc64:
http://www.mail-archive.com/ke...@lists.infradead.org/msg02426.html
It got acks from the kexec folks so I
on ppc64.
Neil
Signed-off-by: Neil Horman nhor...@tuxdriver.com
machine_kexec.c | 12
1 file changed, 12 insertions(+)
diff --git a/arch/powerpc/kernel/machine_kexec.c
b/arch/powerpc/kernel/machine_kexec.c
index bb3d893..0df7031 100644
--- a/arch/powerpc/kernel/machine_kexec.c
patch Rusty, it all works quite well, Thanks!
Will this be going in via your tree, or the ppc tree?
Acked-by: Neil Horman nhor...@tuxdriver.com
Neil
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Paul, Ben, given that Rusty hasn't come back with any opinion on this patch,
do you
feel comfortable merging it via the ppc tree? Currently the earlyinit
routine
is only compiled in and used for your arch, so I think its fairly benign.
Sorry, I *did* track down the archives for
On Thu, Nov 19, 2009 at 02:52:16PM -0500, Neil Horman wrote:
Hey there-
Before anyone flames me for what a oddball solution this is, let me just
say I'm trying to get the ball rolling here. I think there may be better
solutions that can be impemented in reloc_64.S, but I've yet to make
On Thu, Nov 19, 2009 at 02:52:16PM -0500, Neil Horman wrote:
Hey there-
Before anyone flames me for what a oddball solution this is, let me just
say I'm trying to get the ball rolling here. I think there may be better
solutions that can be impemented in reloc_64.S, but I've yet to make
Neil Horman writes:
Before anyone flames me for what a oddball solution this is, let me just
say I'm trying to get the ball rolling here. I think there may be better
solutions that can be impemented in reloc_64.S, but I've yet to make any of
the
ones I've tried work successfully. I'm
on ppc64 systems myself.
Signed-off-by: Neil Horman nhor...@tuxdriver.com
arch/powerpc/include/asm/local.h |6 ++
arch/powerpc/kernel/vmlinux.lds.S |4
kernel/module.c | 30 ++
3 files changed, 40 insertions(+)
diff --git a/arch
On Wed, Jun 17, 2009 at 10:26:35PM +1000, Michael Ellerman wrote:
On Wed, 2009-06-17 at 17:29 +0530, M. Mohan Kumar wrote:
Do not inline putprops function
With the recent kexec-tools git tree, both kexec and kdump kernels hang (i.e
kexec -l and kexec -p respectively). This happened after
On Wed, Jun 17, 2009 at 07:04:35PM +0530, M. Mohan Kumar wrote:
On Wed, Jun 17, 2009 at 09:04:13AM -0400, Neil Horman wrote:
On Wed, Jun 17, 2009 at 10:26:35PM +1000, Michael Ellerman wrote:
What compiler version are you using? Does the behaviour change if you
use a newer/older
On Wed, Jun 17, 2009 at 07:56:52PM +0530, M. Mohan Kumar wrote:
On Wed, Jun 17, 2009 at 10:05:14AM -0400, Neil Horman wrote:
On Wed, Jun 17, 2009 at 07:04:35PM +0530, M. Mohan Kumar wrote:
On Wed, Jun 17, 2009 at 09:04:13AM -0400, Neil Horman wrote:
On Wed, Jun 17, 2009 at 10:26:35PM
21 matches
Mail list logo
