Re: [PATCH] soc: fsl: guts: us devm_kstrdup_const() for RO data

On Thu, Jan 10, 2019 at 01:43:01PM -0600, Li Yang wrote: > On Sat, Dec 22, 2018 at 2:02 AM Nicholas Mc Guire wrote: > > > > On Fri, Dec 21, 2018 at 08:29:56PM -0600, Scott Wood wrote: > > > On Fri, 2018-12-07 at 09:22 +0100, Nicholas Mc Guire wrote: > > >

Re: [PATCH] soc: fsl: guts: us devm_kstrdup_const() for RO data

On Fri, Dec 21, 2018 at 08:29:56PM -0600, Scott Wood wrote: > On Fri, 2018-12-07 at 09:22 +0100, Nicholas Mc Guire wrote: > > devm_kstrdup() may return NULL if internal allocation failed, but > > as machine is from the device tree, and thus RO, devm_kstrdup_const() > > ca

[PATCH] soc: fsl: guts: us devm_kstrdup_const() for RO data

devm_kstrdup() may return NULL if internal allocation failed, but as machine is from the device tree, and thus RO, devm_kstrdup_const() can be used here, which will only copy the reference. Signed-off-by: Nicholas Mc Guire Fixes: a6fc3b698130 ("soc: fsl: add GUTS driver for QorIQ plat

Re: [RFC PATCH] soc: fsl: guts: handle devm_kstrdup() failure

On Wed, Dec 05, 2018 at 02:42:55PM -0600, Li Yang wrote: > On Sun, Dec 2, 2018 at 3:07 AM Nicholas Mc Guire wrote: > > > > devm_kstrdup() may return NULL if internal allocation failed. > > soc_dev_attr.machine should be checked (although its only use > > in p

[RFC PATCH] soc: fsl: guts: handle devm_kstrdup() failure

any allocation at all. Signed-off-by: Nicholas Mc Guire Fixes: a6fc3b698130 ("soc: fsl: add GUTS driver for QorIQ platforms") --- Problem located by experimental coccinelle script Patch was compile tested with: multi_v7_defconfig (implies FSL_GUTS=y) Patch is against 4.20-rc4 (localve

[PATCH 1/2] usb: gadget: fsl_udc_core: check allocation return value and cleanup on failure

_probe()) so reset it to 0 as well so that this function is side-effect free on failure. Not clear if this is necessary or sensible as fsl_udc_release() probably can not be called if fsl_udc_probe() failed - but it should not hurt. Signed-off-by: Nicholas Mc Guire Fixes: b504882da5 ("USB: ad

[PATCH 2/2] usb: gadget: fsl_udc_core: fixup struct_udc_setup documentation

ep number from DCCPARAMS register") only provides partial initialization as well as returning 0 on success and -1 on failures. The function documentation is updated accordingly. Signed-off-by: Nicholas Mc Guire Fixes: 4365831dadfe ("USB: fsl_usb2_udc: Get max ep number from DCCPARAMS

[PATCH] KVM: PPC: Book3S HV: fix constant size warning

The constants are 64bit but not explicitly declared UL resulting in sparse warnings. Fixed by declaring the constants UL. Signed-off-by: Nicholas Mc Guire --- sparse fallout from compile checking book3s_hv.c: arch/powerpc/kvm/book3s_hv.c:141:9: warning: constant 0x164520C62609AECA is so big

[PATCH] KVM: PPC: Book3S HV: add of_node_put() in success path

. Signed-off-by: Nicholas Mc Guire Fixes: commit f725758b899f ("KVM: PPC: Book3S HV: Use OPAL XICS emulation on POWER9") --- Problem found by experimental coccinelle script Patch was compiletested with: ppc64_defconfig (implies CONFIG_KVM=y, CONFIG_KVM_BOOK3S_64_HV=m) with many sparse warni

[PATCH] powerpc: icp-hv: fix missing of_node_put in success path

Both of_find_compatible_node() and of_find_node_by_type() will return a refcounted node on success - thus for the success path the node must be explicitly released with a of_node_put(). Signed-off-by: Nicholas Mc Guire Fixes: commit 0b05ac6e2480 ("powerpc/xics: Rewrite XICS driver") -

[PATCH] powerpc: hwrng; fix missing of_node_put()

The call to of_find_compatible_node() returns a node pointer with refcount incremented thus it must be explicitly decremented here before returning. Signed-off-by: Nicholas Mc Guire Fixes: commit a489043f4626 ("powerpc/pseries: Implement arch_get_random_long() based on H_RANDOM") -

[PATCH] ALSA: snd-aoa: add of_node_put() in error path

the of_get_next_child(gpio, np) in the while loop if we reached the error code path below, an x of_node_put(np) is needed. Signed-off-by: Nicholas Mc Guire Fixes: commit f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa") --- Problem located by an experimental coccinelle script Patch was com

Re: linux-next: build warnings after merge of the kbuild tree

On Fri, Aug 26, 2016 at 01:58:03PM +1000, Nicholas Piggin wrote: > On Mon, 22 Aug 2016 20:47:58 +1000 > Nicholas Piggin wrote: > > > On Fri, 19 Aug 2016 20:44:55 +1000 > > Nicholas Piggin wrote: > > > > > On Fri, 19 Aug 2016 10:37:00 +0200 > > > Michal

[PATCH] macintosh: ams: cleanup on stack DECLARE_COMPLETION

with ppc6xx_defconfig, CONFIG_SENSORS_AMS=m, CONFIG_SENSORS_AMS_PMU=y Signed-off-by: Nicholas Mc Guire der.h...@hofr.at --- drivers/macintosh/ams/ams-pmu.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/macintosh/ams/ams-pmu.c b/drivers/macintosh/ams/ams-pmu.c

[PATCH] cleanup on stack DECLARE_COMPLETIONs

tested Signed-off-by: Nicholas Mc Guire der.h...@hofr.at --- drivers/macintosh/ams/ams-pmu.c |4 ++-- drivers/misc/sgi-gru/grukservices.c |2 +- drivers/scsi/aha152x.c|2 +- drivers/usb/gadget/udc/fsl_qe_udc.c |2 +- drivers/usb/gadget/udc/fsl_udc_core.c

[PATCH] gadget: cleanup on stack DECLARE_COMPLETIONs

fixups for incorrect use of DECLARE_COMPLETION. see also commit 6e9a4738 (completions: lockdep annotate on stack completions) patch is against 3.18.0 linux-next This was only code reviewed and compile tested Signed-off-by: Nicholas Mc Guire der.h...@hofr.at --- drivers/usb/gadget/udc

Re: How to build the kernel without any optimization?

On Fri, 20 Aug 2010, Shawn Jin wrote: Hi, I'm tracing the execution of ds1307_probe() and find that some of variables or function arguments cannot be printed in gdb because they are optimized out or not in the current context. This really gives some headache. Is there a way to build the

Re: can the kernel show user task stack backtrace ?

On Thu, 30 Jul 2009, Alessandro Rubini wrote: We're dealing with some complex (3rd party) applications and I like to see a user task stack backtrace. (Of course the way to go here is to use a debugger (gdb) and do a backtrace (with the coredump file). Actually, you can intercept

Re: Memory usage of a process

On Fri, 10 Jul 2009, G?nter Leonhardt wrote: Hello, analysing the memory usage of a process, I found some questions. I'am using a system with 128 MB physical RAM, no disk, 2.6.27 kernel. Running top, I see 38 MB in use, 90 MB free, but a VSZ for my process of 158 MB. Looking at

Re: Device node - How does kernel know about it

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 * Ramdisk is also executing fine, just that prints are not coming out of serial. I can see the execution of various user programs with a printk in sys_execve() routine. Ramdisk has all the required files like /dev/console, /dev/ttyS0, etc. *

Re: rtlinux rtai interrupt latency

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Sun, 2007-10-21 at 10:45 +0800, Bai Shuwei wrote: all, hi does anyone knows RTLinux, RTAI interrupt latency and schedule latency on the PPC440, PPC405? You'd have to ask Wind River. There are free variants around as well - XtratuM/PPC

Re: ppc manual paging question

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I've got some qeustion about ppc(ppc44x) paging: how can I manually map a virtual address to a physical address through a specific pgd? How does ppc translate virt address to physical one? I think besides from tlb, the CPU will search the page