Re: [PATCH 0/5] cpuidle-pseries: Parse extended CEDE information for idle.

2020-07-27 Thread Rafael J. Wysocki
On Tue, Jul 7, 2020 at 1:32 PM Gautham R Shenoy wrote: > > Hi, > > On Tue, Jul 07, 2020 at 04:41:34PM +0530, Gautham R. Shenoy wrote: > > From: "Gautham R. Shenoy" > > > > Hi, > > > > > > > > > > Gautham R. Shenoy (5): > > cpuidle-pseries: Set the latency-hint before entering CEDE > >

Re: [PATCH v3 1/2] cpuidle: Trace IPI based and timer based wakeup latency from idle states

2020-07-27 Thread Rafael J. Wysocki
On Tue, Jul 21, 2020 at 2:43 PM Pratik Rajesh Sampat wrote: > > Fire directed smp_call_function_single IPIs from a specified source > CPU to the specified target CPU to reduce the noise we have to wade > through in the trace log. And what's the purpose of it? > The module is based on the idea

Re: [PATCH -next] cpuidle/pseries: Make symbol 'pseries_idle_driver' static

2020-07-15 Thread Rafael J. Wysocki
On Tue, Jul 14, 2020 at 4:14 PM Wei Yongjun wrote: > > The sparse tool complains as follows: > > drivers/cpuidle/cpuidle-pseries.c:25:23: warning: > symbol 'pseries_idle_driver' was not declared. Should it be static? > > 'pseries_idle_driver' is not used outside of this file, so marks > it

Re: [PATCH -next] cpufreq: powernv: Make some symbols static

2020-07-15 Thread Rafael J. Wysocki
On Tue, Jul 14, 2020 at 4:14 PM Wei Yongjun wrote: > > The sparse tool complains as follows: > > drivers/cpufreq/powernv-cpufreq.c:88:1: warning: > symbol 'pstate_revmap' was not declared. Should it be static? > drivers/cpufreq/powernv-cpufreq.c:383:18: warning: > symbol

Re: [PATCH V4 0/3] cpufreq: Allow default governor on cmdline and fix locking issues

2020-06-30 Thread Rafael J. Wysocki
On Mon, Jun 29, 2020 at 10:58 PM Viresh Kumar wrote: > > Hi, > > I have picked Quentin's series over my patch, modified both and tested. > > V3->V4: > - Do __module_get() for cpufreq_default_governor() case as well and get > rid of an extra variable. > - Use a single character array,

Re: [PATCH v2 2/2] cpufreq: Specify default governor on command line

2020-06-25 Thread Rafael J. Wysocki
On Thu, Jun 25, 2020 at 3:50 PM Quentin Perret wrote: > > On Thursday 25 Jun 2020 at 15:28:43 (+0200), Rafael J. Wysocki wrote: > > On Thu, Jun 25, 2020 at 1:53 PM Quentin Perret wrote: > > > > > > On Thursday 25 Jun 2020 at 13:44:34 (+0200), Rafael J. Wysocki wrote

Re: [PATCH v2 2/2] cpufreq: Specify default governor on command line

2020-06-25 Thread Rafael J. Wysocki
On Thu, Jun 25, 2020 at 1:53 PM Quentin Perret wrote: > > On Thursday 25 Jun 2020 at 13:44:34 (+0200), Rafael J. Wysocki wrote: > > On Thu, Jun 25, 2020 at 1:36 PM Viresh Kumar > > wrote: > > > This change is not right IMO. This part handles the s

Re: [PATCH v2 2/2] cpufreq: Specify default governor on command line

2020-06-25 Thread Rafael J. Wysocki
On Thu, Jun 25, 2020 at 1:36 PM Viresh Kumar wrote: > > After your last email (reply to my patch), I noticed a change which > isn't required. :) > > On 23-06-20, 15:21, Quentin Perret wrote: > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > > index

Re: [PATCH v2 2/2] cpufreq: Specify default governor on command line

2020-06-25 Thread Rafael J. Wysocki
On Thu, Jun 25, 2020 at 10:50 AM Viresh Kumar wrote: > > On 24-06-20, 16:32, Quentin Perret wrote: > > Right, but I must admit that, looking at this more, I'm getting a bit > > confused with the overall locking for governors :/ > > > > When in cpufreq_init_policy() we find a governor using > >

Re: [PATCH v2 2/2] cpufreq: Specify default governor on command line

2020-06-24 Thread Rafael J. Wysocki
On Wed, Jun 24, 2020 at 7:50 AM Viresh Kumar wrote: > > On 23-06-20, 15:21, Quentin Perret wrote: > > Currently, the only way to specify the default CPUfreq governor is via > > Kconfig options, which suits users who can build the kernel themselves > > perfectly. > > > > However, for those who use

Re: [PATCH] cpufreq: powernv: Fix frame-size-overflow in powernv_cpufreq_work_fn

2020-03-25 Thread Rafael J. Wysocki
On Tuesday, March 24, 2020 7:34:56 AM CET Michael Ellerman wrote: > "Rafael J. Wysocki" writes: > > On Monday, March 16, 2020 2:57:43 PM CET Pratik Rajesh Sampat wrote: > >> The patch avoids allocating cpufreq_policy on stack hence fixing frame > >> size

Re: [patch V3 05/20] acpi: Remove header dependency

2020-03-22 Thread Rafael J. Wysocki
> Signed-off-by: Thomas Gleixner > Cc: Darren Hart > Cc: Andy Shevchenko > Cc: platform-driver-...@vger.kernel.org > Cc: Greg Kroah-Hartman > Cc: Zhang Rui > Cc: "Rafael J. Wysocki" > Cc: linux...@vger.kernel.org > Cc: Len Brown > Cc: linux-a...

Re: [PATCH] cpufreq: powernv: Fix frame-size-overflow in powernv_cpufreq_work_fn

2020-03-19 Thread Rafael J. Wysocki
On Monday, March 16, 2020 2:57:43 PM CET Pratik Rajesh Sampat wrote: > The patch avoids allocating cpufreq_policy on stack hence fixing frame > size overflow in 'powernv_cpufreq_work_fn' > > Fixes: 227942809b52 ("cpufreq: powernv: Restore cpu frequency to policy->cur > on unthrottling") >

Re: [PATCH v5] reboot: support offline CPUs before reboot

2020-01-15 Thread Rafael J. Wysocki
On Wed, Jan 15, 2020 at 7:35 AM Hsin-Yi Wang wrote: > > Currently system reboots uses architecture specific codes (smp_send_stop) > to offline non reboot CPUs. Most architecture's implementation is looping > through all non reboot online CPUs and call ipi function to each of them. Some >

Re: [PATCH 12/23] y2038: syscalls: change remaining timeval to __kernel_old_timeval

2019-11-13 Thread Rafael J. Wysocki
timeval type in user space. > > Signed-off-by: Arnd Bergmann For the change in power/power.h Acked-by: Rafael J. Wysocki > --- > arch/powerpc/include/asm/asm-prototypes.h | 3 ++- > arch/powerpc/kernel/syscalls.c| 4 ++-- > fs/select.c

Re: [PATCH 4/5] power: avs: smartreflex: Remove superfluous cast in debugfs_create_file() call

2019-11-13 Thread Rafael J. Wysocki
On Monday, October 21, 2019 4:51:48 PM CET Geert Uytterhoeven wrote: > There is no need to cast a typed pointer to a void pointer when calling > a function that accepts the latter. Remove it, as the cast prevents > further compiler checks. > > Signed-off-by: Geert Uytterhoeven > --- >

Re: [PATCH 4/5] power: avs: smartreflex: Remove superfluous cast in debugfs_create_file() call

2019-11-08 Thread Rafael J. Wysocki
On Monday, October 21, 2019 4:51:48 PM CET Geert Uytterhoeven wrote: > There is no need to cast a typed pointer to a void pointer when calling > a function that accepts the latter. Remove it, as the cast prevents > further compiler checks. > > Signed-off-by: Geert Uytterhoeven Greg, have you

Re: [PATCH v3] cpufreq: powernv: fix stack bloat and hard limit on num cpus

2019-11-04 Thread Rafael J. Wysocki
e throttling due to Pmax > capping at chip level") > Cc: Michael Ellerman > Cc: Shilpasri G Bhat > Cc: Preeti U Murthy > Cc: Viresh Kumar > Cc: Rafael J. Wysocki > Cc: linux...@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: John Hubbard &g

Re: [PATCH v2] cpufreq: powernv: fix stack bloat and NR_CPUS limitation

2019-10-28 Thread Rafael J. Wysocki
has a bug: it fails with a stack > > overrun, if CONFIG_NR_CPUS > 256. > > > > Fix both problems by dynamically allocating based on CONFIG_NR_CPUS. > > > > Fixes: 053819e0bf840 ("cpufreq: powernv: Handle throttling due to Pmax > > capping at chip level&qu

Re: [PATCH v9 1/3] PM: wakeup: Add routine to help fetch wakeup source object.

2019-10-23 Thread Rafael J. Wysocki
ding on. So add this API to help walk through all registered > wakeup source objects on that list and return them one by one. > > Signed-off-by: Ran Wang > Tested-by: Leonard Crestez OK, thanks for making all of the requested changes: Reviewed-by: Rafael J. Wysocki and please fee

Re: [PATCH v9 3/3] soc: fsl: add RCPM driver

2019-10-23 Thread Rafael J. Wysocki
ontinue; > + > + /* We can only OR related bits */ > + if (rcpm->little_endian) { > + tmp |= ioread32(address); > + iowrite32(tmp, address); > + } else { > + tmp |= ioread32be(address); > + iowrite32be(tmp, address); > + } > + } > + } > + > + wakeup_sources_read_unlock(idx); > + > + return 0; > +} > + > +static const struct dev_pm_ops rcpm_pm_ops = { > + .prepare = rcpm_pm_prepare, > +}; For the above: Reviewed-by: Rafael J. Wysocki

Re: [PATCH 1/3] PM: wakeup: Add routine to help fetch wakeup source object.

2019-10-22 Thread Rafael J. Wysocki
On Tue, Oct 22, 2019 at 9:51 AM Ran Wang wrote: > > Some user might want to go through all registered wakeup sources > and doing things accordingly. For example, SoC PM driver might need to > do HW programming to prevent powering down specific IP which wakeup > source depending on. So add this

Re: [PATCH 3/3] soc: fsl: add RCPM driver

2019-10-22 Thread Rafael J. Wysocki
On Tue, Oct 22, 2019 at 9:52 AM Ran Wang wrote: > > The NXP's QorIQ Processors based on ARM Core have RCPM module > (Run Control and Power Management), which performs system level > tasks associated with power management such as wakeup source control. > > This driver depends on PM wakeup source

Re: [PATCH v7 1/3] PM: wakeup: Add routine to help fetch wakeup source object.

2019-10-21 Thread Rafael J. Wysocki
On Mon, Oct 21, 2019 at 5:49 AM Ran Wang wrote: > > Some user might want to go through all registered wakeup sources > and doing things accordingly. For example, SoC PM driver might need to > do HW programming to prevent powering down specific IP which wakeup > source depending on. So add this

Re: [PATCH v5 1/3] PM: wakeup: Add routine to help fetch wakeup source object.

2019-08-19 Thread Rafael J. Wysocki
On Monday, August 19, 2019 10:33:25 AM CEST Ran Wang wrote: > Hi Rafael, > > On Monday, August 19, 2019 16:20, Rafael J. Wysocki wrote: > > > > On Mon, Aug 19, 2019 at 10:15 AM Ran Wang wrote: > > > > > > Hi Rafael, > > > > > >

Re: [PATCH v5 1/3] PM: wakeup: Add routine to help fetch wakeup source object.

2019-08-19 Thread Rafael J. Wysocki
On Mon, Aug 19, 2019 at 10:15 AM Ran Wang wrote: > > Hi Rafael, > > On Monday, August 05, 2019 17:59, Rafael J. Wysocki wrote: > > > > On Wednesday, July 24, 2019 9:47:20 AM CEST Ran Wang wrote: > > > Some user might want to go through all registered wake

Re: [PATCH v5 1/3] PM: wakeup: Add routine to help fetch wakeup source object.

2019-08-05 Thread Rafael J. Wysocki
On Wednesday, July 24, 2019 9:47:20 AM CEST Ran Wang wrote: > Some user might want to go through all registered wakeup sources > and doing things accordingly. For example, SoC PM driver might need to > do HW programming to prevent powering down specific IP which wakeup > source depending on. So

Re: [PATCH V3] cpufreq: Make cpufreq_generic_init() return void

2019-07-18 Thread Rafael J. Wysocki
On Tuesday, July 16, 2019 6:06:08 AM CEST Viresh Kumar wrote: > It always returns 0 (success) and its return type should really be void. > Over that, many drivers have added error handling code based on its > return value, which is not required at all. > > change its return type to void and

Re: [PATCH 00/10] cpufreq: Migrate users of policy notifiers to QoS requests

2019-07-16 Thread Rafael J. Wysocki
On Tue, Jul 16, 2019 at 12:14 PM Viresh Kumar wrote: > > On 16-07-19, 12:06, Rafael J. Wysocki wrote: > > On Tue, Jul 16, 2019 at 11:49 AM Viresh Kumar > > wrote: > > > > > > Hello, > > > > > > Now that cpufreq core supports taking QoS re

Re: [PATCH 00/10] cpufreq: Migrate users of policy notifiers to QoS requests

2019-07-16 Thread Rafael J. Wysocki
On Tue, Jul 16, 2019 at 11:49 AM Viresh Kumar wrote: > > Hello, > > Now that cpufreq core supports taking QoS requests for min/max cpu > frequencies, lets migrate rest of the users to using them instead of the > policy notifiers. Technically, this still is linux-next only. :-) > The

Re: [PATCH v5] cpufreq/pasemi: fix an use-after-free in pas_cpufreq_cpu_init()

2019-07-10 Thread Rafael J. Wysocki
6b75f ("cpufreq/pasemi: fix possible object reference leak") > > Signed-off-by: Wen Yang > > Cc: "Rafael J. Wysocki" > > Cc: Viresh Kumar > > Cc: Michael Ellerman > > Cc: linuxppc-dev@lists.ozlabs.org > > Cc: linux...@vger.kernel.org > >

Re: [PATCH v2] powerpc/power: Expose pfn_is_nosave prototype

2019-06-27 Thread Rafael J. Wysocki
On Friday, May 24, 2019 12:44:18 PM CEST Mathieu Malaterre wrote: > The declaration for pfn_is_nosave is only available in > kernel/power/power.h. Since this function can be override in arch, > expose it globally. Having a prototype will make sure to avoid warning > (sometime treated as error with

Re: [PATCH v4 1/3] PM: wakeup: Add routine to help fetch wakeup source object.

2019-06-18 Thread Rafael J. Wysocki
On Monday, May 20, 2019 11:52:36 AM CEST Ran Wang wrote: > Some user might want to go through all registered wakeup sources > and doing things accordingly. For example, SoC PM driver might need to > do HW programming to prevent powering down specific IP which wakeup > source depending on. And is

Re: [PATCH 01/14] ABI: fix some syntax issues at the ABI database

2019-06-14 Thread Rafael J. Wysocki
t", they use "Where". > > Signed-off-by: Mauro Carvalho Chehab > Signed-off-by: Mauro Carvalho Chehab Acked-by: Rafael J. Wysocki > --- > Documentation/ABI/testing/pstore | 2 +- > .../sysfs-bus-event_source-devices-format | 2 +- >

Re: [PATCH v2] powerpc/power: Expose pfn_is_nosave prototype

2019-05-28 Thread Rafael J. Wysocki
On Tuesday, May 28, 2019 3:16:30 AM CEST Michael Ellerman wrote: > "Rafael J. Wysocki" writes: > > On Friday, May 24, 2019 12:44:18 PM CEST Mathieu Malaterre wrote: > >> The declaration for pfn_is_nosave is only available in > >> kernel/power/power.h. Since

Re: [PATCH v2] powerpc/power: Expose pfn_is_nosave prototype

2019-05-27 Thread Rafael J. Wysocki
On Friday, May 24, 2019 12:44:18 PM CEST Mathieu Malaterre wrote: > The declaration for pfn_is_nosave is only available in > kernel/power/power.h. Since this function can be override in arch, > expose it globally. Having a prototype will make sure to avoid warning > (sometime treated as error with

Re: [PATCH 10/10] docs: fix broken documentation links

2019-05-27 Thread Rafael J. Wysocki
On Mon, May 20, 2019 at 4:48 PM Mauro Carvalho Chehab wrote: > > Mostly due to x86 and acpi conversion, several documentation > links are still pointing to the old file. Fix them. > > Signed-off-by: Mauro Carvalho Chehab For the ACPI part: Acked-by: Rafael J. Wysocki

Re: [PATCH v5 00/23] Include linux ACPI docs into Sphinx TOC tree

2019-05-01 Thread Rafael J. Wysocki
On Thursday, April 25, 2019 5:20:35 PM CEST Changbin Du wrote: > On Thu, Apr 25, 2019 at 10:44:14AM +0200, Rafael J. Wysocki wrote: > > .On Wed, Apr 24, 2019 at 7:54 PM Changbin Du wrote: > > > > > > Hi All, > > > The kernel now uses Sphinx t

Re: Why is suspend with s2idle available on POWER8 systems?

2019-04-29 Thread Rafael J. Wysocki
On Mon, Apr 29, 2019 at 10:50 AM Paul Menzel wrote: > > Dear Rafael, > > > On 04/29/2019 09:17 AM, Rafael J. Wysocki wrote: > > On Sat, Apr 27, 2019 at 12:54 PM Paul Menzel wrote: > > >> Updating an IBM S822LC from Ubuntu 18.10 to 19.04 some user space stu

Re: Why is suspend with s2idle available on POWER8 systems?

2019-04-29 Thread Rafael J. Wysocki
On Sat, Apr 27, 2019 at 12:54 PM Paul Menzel wrote: > > Dear Linux folks, > > > Updating an IBM S822LC from Ubuntu 18.10 to 19.04 some user space stuff > seems to have changed, so that going into sleep/suspend is enabled. > > That raises two questions. > > 1. Is suspend actually supported on a

Re: [PATCH v5 00/23] Include linux ACPI docs into Sphinx TOC tree

2019-04-25 Thread Rafael J. Wysocki
.On Wed, Apr 24, 2019 at 7:54 PM Changbin Du wrote: > > Hi All, > The kernel now uses Sphinx to generate intelligent and beautiful documentation > from reStructuredText files. I converted all of the Linux ACPI/PCI/X86 docs to > reST format in this serias. > > The hieararchy of ACPI docs are based

Re: [PATCH v4 00/63] Include linux ACPI/PCI/X86 docs into Sphinx TOC tree

2019-04-23 Thread Rafael J. Wysocki
On Tue, Apr 23, 2019 at 6:30 PM Changbin Du wrote: > > Hi Corbet and All, > The kernel now uses Sphinx to generate intelligent and beautiful documentation > from reStructuredText files. I converted all of the Linux ACPI/PCI/X86 docs to > reST format in this serias. > > In this version I combined

Re: [PATCH] drivers: cpuidle: This patch fix the following checkpatch warning.

2019-04-18 Thread Rafael J. Wysocki
On Wednesday, April 17, 2019 4:52:34 PM CEST Mohan Kumar wrote: > Use pr_debug instead of printk > > WARNING: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then > dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... > > Signed-off-by: Mohan Kumar > --- >

Re: [PATCH v2 1/2] cpuidle : auto-promotion for cpuidle states

2019-04-09 Thread Rafael J. Wysocki
On Fri, Apr 5, 2019 at 11:17 AM Abhishek Goel wrote: > > Currently, the cpuidle governors (menu /ladder) determine what idle state There are three governors in 5.1-rc. > an idling CPU should enter into based on heuristics that depend on the > idle history on that CPU. Given that no predictive

Re: [PATCH v2 1/2] cpuidle : auto-promotion for cpuidle states

2019-04-09 Thread Rafael J. Wysocki
On Tue, Apr 9, 2019 at 11:29 AM Abhishek wrote: > > Hi Daniel, > > Thanks for such a descriptive review. I will include all the suggestions > made in my next iteration. Please give me some time to send comments before that.

Re: [PATCH 1/2] cpuidle : auto-promotion for cpuidle states

2019-03-22 Thread Rafael J. Wysocki
On Fri, Mar 22, 2019 at 8:31 AM Abhishek Goel wrote: > > Currently, the cpuidle governors (menu /ladder) determine what idle state > an idling CPU should enter into based on heuristics that depend on the > idle history on that CPU. Given that no predictive heuristic is perfect, > there are cases

Re: [PATCH v2] cpufreq: powernv: add of_node_put()

2018-12-11 Thread Rafael J. Wysocki
On Wednesday, November 21, 2018 5:02:04 AM CET Viresh Kumar wrote: > On 20-11-18, 11:05, Yangtao Li wrote: > > The of_find_node_by_path() returns a node pointer with refcount > > incremented,but there is the lack of use of the of_node_put() when > > done.Add the missing of_node_put() to release

Re: [PATCH v2] cpufreq: pmac64: add of_node_put()

2018-12-11 Thread Rafael J. Wysocki
On Monday, November 26, 2018 7:02:26 AM CET Viresh Kumar wrote: > On 23-11-18, 08:33, Yangtao Li wrote: > > of_find_node_by_path() acquires a reference to the node > > returned by it and that reference needs to be dropped by its caller. > > g5_neo2_cpufreq_init() doesn't do that, so fix it. > > >

Re: [PATCH] cpufreq: powernv: add of_node_put()

2018-11-20 Thread Rafael J. Wysocki
On Tue, Nov 20, 2018 at 1:57 PM Yangtao Li wrote: > > use of_node_put() to release the refcount. Again, this changelog is as good as no changelog at all. If you are adding a missing of_node_put(), please say that and explain why it is necessary. Thanks, Rafael

Re: [PATCH v1 2/6] mm/memory_hotplug: make add_memory() take the device_hotplug_lock

2018-09-18 Thread Rafael J. Wysocki
_hotplug_lock is never > exported). > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: Greg Kroah-Hartman > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: Nathan Fontenot >

Re: [PATCH v1 1/6] mm/memory_hotplug: make remove_memory() take the device_hotplug_lock

2018-09-18 Thread Rafael J. Wysocki
t; Apart from that, there are not other users in the tree. > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: Rashmica Gupta > Cc: Michael Neuling > Cc: Balbir Singh > Cc: Nathan Fontenot

Re: [RFC 08/15] x86: PCI: clean up pcibios_scan_root()

2018-08-20 Thread Rafael J. Wysocki
On Mon, Aug 20, 2018 at 1:17 PM Arnd Bergmann wrote: > > On Mon, Aug 20, 2018 at 10:31 AM Rafael J. Wysocki wrote: > > On Fri, Aug 17, 2018 at 12:32 PM Arnd Bergmann wrote: > > > > -static struct pci_bus *pci_scan_root_bus(struct device *parent, int bus, > > &g

Re: [RFC 07/15] PCI/ACPI: clean up acpi_pci_root_create()

2018-08-20 Thread Rafael J. Wysocki
On Mon, Aug 20, 2018 at 1:20 PM Arnd Bergmann wrote: > > On Mon, Aug 20, 2018 at 10:23 AM Rafael J. Wysocki wrote: > > On Fri, Aug 17, 2018 at 12:33 PM Arnd Bergmann wrote: > > > @@ -909,8 +881,7 @@ struct pci_bus *acpi_pci_root_create(struct > > > acpi_pci_roo

Re: [RFC 08/15] x86: PCI: clean up pcibios_scan_root()

2018-08-20 Thread Rafael J. Wysocki
On Fri, Aug 17, 2018 at 12:32 PM Arnd Bergmann wrote: > > pcibios_scan_root() is now just a wrapper around pci_scan_root_bus(), > and merging the two into one makes it shorter and more readable. > > We can also take advantage of pci_alloc_host_bridge() doing the > allocation of the sysdata for

Re: [RFC 07/15] PCI/ACPI: clean up acpi_pci_root_create()

2018-08-20 Thread Rafael J. Wysocki
On Fri, Aug 17, 2018 at 12:33 PM Arnd Bergmann wrote: > > The acpi_pci_create_root_bus() can be fully integrated into > acpi_pci_root_create(), improving a few things: > > * We can call pci_scan_root_bus_bridge(), which registers and > scans the bridge in one step. > * After a failure in

Re: [PATCH 8/9] PCI: hotplug: Embed hotplug_slot

2018-08-20 Thread Rafael J. Wysocki
struct. The "private" pointer in struct hotplug_slot thereby becomes > unused, so drop it. > > Signed-off-by: Lukas Wunner > Cc: Rafael J. Wysocki > Cc: Len Brown > Cc: Scott Murray > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman

Re: [PATCH 7/9] PCI: hotplug: Drop hotplug_slot_info

2018-08-20 Thread Rafael J. Wysocki
> once on probe. That seems unlikely to me, still maintainers should > review the changes carefully for this possibility. I'm not aware of any case in which it will break anything, so Reviewed-by: Rafael J. Wysocki but if that happens, it may be necessary to add the execution of the control methods in question directly to the initialization part.

Re: [PATCH 6/9] PCI: hotplug: Constify hotplug_slot_ops

2018-08-20 Thread Rafael J. Wysocki
const. It can be > converted to __write_rarely once that's mainlined: > http://www.openwall.com/lists/kernel-hardening/2016/11/16/3 > > Signed-off-by: Lukas Wunner > Cc: Rafael J. Wysocki > Cc: Len Brown > Cc: Scott Murray > Cc: Benjamin Herrenschmidt > Cc: Paul Macker

Re: [PATCH RFC 1/2] drivers/base: export lock_device_hotplug/unlock_device_hotplug

2018-08-17 Thread Rafael J. Wysocki
On Fri, Aug 17, 2018 at 10:56 AM David Hildenbrand wrote: > > On 17.08.2018 10:41, Greg Kroah-Hartman wrote: > > On Fri, Aug 17, 2018 at 09:59:00AM +0200, David Hildenbrand wrote: > >> From: Vitaly Kuznetsov > >> > >> Well require to call add_memory()/add_memory_resource() with > >>

Re: [PATCH RFC 1/2] drivers/base: export lock_device_hotplug/unlock_device_hotplug

2018-08-17 Thread Rafael J. Wysocki
On Fri, Aug 17, 2018 at 10:41 AM Greg Kroah-Hartman wrote: > > On Fri, Aug 17, 2018 at 09:59:00AM +0200, David Hildenbrand wrote: > > From: Vitaly Kuznetsov > > > > Well require to call add_memory()/add_memory_resource() with > > device_hotplug_lock held, to avoid a lock inversion. Allow

Re: [PATCH RFC 2/2] mm/memory_hotplug: fix online/offline_pages called w.o. mem_hotplug_lock

2018-08-17 Thread Rafael J. Wysocki
On Fri, Aug 17, 2018 at 9:59 AM David Hildenbrand wrote: > > There seem to be some problems as result of 30467e0b3be ("mm, hotplug: > fix concurrent memory hot-add deadlock"), which tried to fix a possible > lock inversion reported and discussed in [1] due to the two locks > a)

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-09 Thread Rafael J. Wysocki
On Mon, Jul 9, 2018 at 10:40 AM, Pingfan Liu wrote: > On Mon, Jul 9, 2018 at 3:48 PM Rafael J. Wysocki wrote: >> >> On Mon, Jul 9, 2018 at 8:48 AM, Pingfan Liu wrote: >> > On Sun, Jul 8, 2018 at 4:25 PM Rafael J. Wysocki wrote: [cut] >> >> I simpl

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-09 Thread Rafael J. Wysocki
On Mon, Jul 9, 2018 at 8:48 AM, Pingfan Liu wrote: > On Sun, Jul 8, 2018 at 4:25 PM Rafael J. Wysocki wrote: >> >> On Sat, Jul 7, 2018 at 6:24 AM, Pingfan Liu wrote: >> > On Fri, Jul 6, 2018 at 9:55 PM Pingfan Liu wrote: >> >> >> >>

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-08 Thread Rafael J. Wysocki
On Sat, Jul 7, 2018 at 6:24 AM, Pingfan Liu wrote: > On Fri, Jul 6, 2018 at 9:55 PM Pingfan Liu wrote: >> >> On Fri, Jul 6, 2018 at 4:47 PM Rafael J. Wysocki wrote: >> > >> > On Fri, Jul 6, 2018 at 10:36 AM, Lukas Wunner wrote: >> > > [cc += Kisho

Re: [PATCHv3 2/4] drivers/base: utilize device tree info to shutdown devices

2018-07-06 Thread Rafael J. Wysocki
On Friday, July 6, 2018 5:02:15 AM CEST Pingfan Liu wrote: > On Thu, Jul 5, 2018 at 6:13 PM Rafael J. Wysocki wrote: > > > > On Tuesday, July 3, 2018 8:50:40 AM CEST Pingfan Liu wrote: > > > commit 52cdbdd49853 ("driver core: correct device's shutdown order

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-06 Thread Rafael J. Wysocki
On Fri, Jul 6, 2018 at 10:36 AM, Lukas Wunner wrote: > [cc += Kishon Vijay Abraham] > > On Thu, Jul 05, 2018 at 11:18:28AM +0200, Rafael J. Wysocki wrote: >> OK, so calling devices_kset_move_last() from really_probe() clearly is >> a mistake. >> >> I'm n

Re: [PATCHv3 2/4] drivers/base: utilize device tree info to shutdown devices

2018-07-05 Thread Rafael J. Wysocki
ut all out-of-order item in > "affected range". To avoid such complicated code, this patch suggests > to utilize the info in device tree, instead of using the order of > devices_kset during shutdown. It iterates the device tree, and firstly > shutdown a device's children and

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-05 Thread Rafael J. Wysocki
On Thu, Jul 5, 2018 at 4:44 AM, Pingfan Liu wrote: > On Wed, Jul 4, 2018 at 6:23 PM Rafael J. Wysocki wrote: >> >> On Wednesday, July 4, 2018 4:47:07 AM CEST Pingfan Liu wrote: >> > On Tue, Jul 3, 2018 at 10:36 PM Rafael J. Wysocki >> > wrote: >> > &g

Re: [PATCH v3 0/2] powernv/cpuidle Device-tree parsing cleanup

2018-07-04 Thread Rafael J. Wysocki
On Tuesday, July 3, 2018 11:20:54 AM CEST Akshay Adiga wrote: > > Device-tree parsed multiple time in powernv cpuidle and powernv > hotplug code. > > First to identify supported flags. Second time, to identify deepest_state > and first deep state. Third time, during cpuidle init to find the

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-04 Thread Rafael J. Wysocki
On Wednesday, July 4, 2018 4:47:07 AM CEST Pingfan Liu wrote: > On Tue, Jul 3, 2018 at 10:36 PM Rafael J. Wysocki wrote: > > > > On Tuesday, July 3, 2018 8:50:38 AM CEST Pingfan Liu wrote: > > > commit 52cdbdd49853 ("driver core: correct device's shutdown order

Re: [PATCHv3 3/4] drivers/base: clean up the usage of devices_kset_move_last()

2018-07-04 Thread Rafael J. Wysocki
On Wednesday, July 4, 2018 6:40:09 AM CEST Pingfan Liu wrote: > On Tue, Jul 3, 2018 at 10:28 PM Rafael J. Wysocki wrote: > > > > On Tuesday, July 3, 2018 8:50:41 AM CEST Pingfan Liu wrote: > > > Clean up the referring to the code in commit 52cdbdd49853 ("driver

Re: [PATCHv3 0/4] drivers/base: bugfix for supplier<-consumer ordering in device_kset

2018-07-03 Thread Rafael J. Wysocki
On Tuesday, July 3, 2018 8:50:38 AM CEST Pingfan Liu wrote: > commit 52cdbdd49853 ("driver core: correct device's shutdown order") > places an assumption of supplier<-consumer order on the process of probe. > But it turns out to break down the parent <- child order in some scene. > E.g in pci, a

Re: [PATCHv3 3/4] drivers/base: clean up the usage of devices_kset_move_last()

2018-07-03 Thread Rafael J. Wysocki
On Tuesday, July 3, 2018 8:50:41 AM CEST Pingfan Liu wrote: > Clean up the referring to the code in commit 52cdbdd49853 ("driver core: > correct device's shutdown order"). So later we can revert it safely. > > Cc: Greg Kroah-Hartman > Cc: Rafael J. Wysocki >

Re: [trivial PATCH V2] treewide: Align function definition open/close braces

2018-03-21 Thread Rafael J. Wysocki
drew Morton picks this up. > > V2: Remove fs/xfs/libxfs/xfs_alloc.c as it's updated and remerge the rest > > arch/x86/include/asm/atomic64_32.h | 2 +- > drivers/acpi/custom_method.c | 2 +- > drivers/acpi/fan.c | 2 +- For the ACPI changes: Acked-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com>

Re: Linux 4.16: Reported regressions as of Monday, 2018-02-26 (Was: Linux 4.16-rc3)

2018-02-27 Thread Rafael J. Wysocki
On Monday, February 26, 2018 11:25:09 AM CET Thorsten Leemhuis wrote: > On 26.02.2018 04:05, Linus Torvalds wrote: > > We're on the normal schedule for 4.16 and everything still looks very > > regular. > > Hi! Find below my second regression report for Linux 4.16. It lists 8 > regressions I'm

Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

2018-02-26 Thread Rafael J. Wysocki
On Mon, Feb 12, 2018 at 11:33 AM, Shilpasri G Bhat wrote: > Hi, > > On 02/12/2018 03:59 PM, Viresh Kumar wrote: >> On 12-02-18, 15:51, Shilpasri G Bhat wrote: >>> This patch fixes the below Coverity warning: >>> >>> *** CID 182816: Memory - illegal accesses

Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

2018-02-21 Thread Rafael J. Wysocki
On Wed, Feb 21, 2018 at 2:13 PM, Michael Ellerman <m...@ellerman.id.au> wrote: > "Rafael J. Wysocki" <raf...@kernel.org> writes: > >> On Wed, Feb 21, 2018 at 6:54 AM, Viresh Kumar <viresh.ku...@linaro.org> >> wrote: >>> On 21-02-18, 16:3

Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

2018-02-21 Thread Rafael J. Wysocki
On Wed, Feb 21, 2018 at 11:02 AM, Viresh Kumar <viresh.ku...@linaro.org> wrote: > On 21-02-18, 10:27, Rafael J. Wysocki wrote: >> To be precise, ->init() should fail as that's where the table is >> created. The registration fails as a result then. >> >>

Re: [PATCH] cpufreq: powernv: Check negative value returned by cpufreq_table_find_index_dl()

2018-02-21 Thread Rafael J. Wysocki
On Wed, Feb 21, 2018 at 6:54 AM, Viresh Kumar wrote: > On 21-02-18, 16:39, Michael Ellerman wrote: >> Viresh Kumar writes: > >> > AFAICT, you will get -1 here only if the freq table had no valid >> > frequencies (or the freq table is empty). Why

Re: [PATCH v3] cpufreq: powernv: Add support of frequency domain

2018-02-09 Thread Rafael J. Wysocki
On Monday, January 22, 2018 9:17:34 AM CET Abhishek Goel wrote: > Frequency-domain indicates group of CPUs that would share same frequency. > It is detected using device-tree node "frequency-domain-indicator". > frequency-domain-indicator is a bitmask which will have different value > depending

Re: [v3 PATCH 2/3] powernv-cpufreq: Fix pstate_to_idx() to handle non-continguous pstates

2018-01-10 Thread Rafael J. Wysocki
On Wednesday, January 10, 2018 9:55:45 AM CET Gautham R Shenoy wrote: > Hi Rafael, > > On Wed, Jan 03, 2018 at 11:47:58PM +1100, Balbir Singh wrote: > > On Wed, Jan 3, 2018 at 11:07 PM, Rafael J. Wysocki <r...@rjwysocki.net> > > wrote: > > > On Monday, Decemb

Re: [v3 PATCH 2/3] powernv-cpufreq: Fix pstate_to_idx() to handle non-continguous pstates

2018-01-03 Thread Rafael J. Wysocki
On Monday, December 18, 2017 9:38:20 AM CET Gautham R Shenoy wrote: > Hi Balbir, > > On Sun, Dec 17, 2017 at 02:15:25PM +1100, Balbir Singh wrote: > > On Wed, Dec 13, 2017 at 5:57 PM, Gautham R. Shenoy > > wrote: > > > From: "Gautham R. Shenoy"

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

2017-12-22 Thread Rafael J. Wysocki
On Sat, Dec 23, 2017 at 12:57 AM, Dan Williams wrote: > On Fri, Dec 22, 2017 at 3:22 PM, Ross Zwisler > wrote: >> On Fri, Dec 22, 2017 at 02:53:42PM -0800, Dan Williams wrote: >>> On Thu, Dec 21, 2017 at 12:31 PM, Brice Goglin

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Rafael J. Wysocki
t raid6_calls raid6_sse2x2 = { > raid6_sse22_gen_syndrome, > @@ -366,9 +366,9 @@ static void raid6_sse24_gen_syndrome(int disks, size_t > bytes, void **ptrs) > kernel_fpu_end(); > } > > - static void raid6_sse24_xor_syndrome(int disks, int start, int stop, > +static void raid6_sse24_xor_syndrome(int disks, int start, int stop, >size_t bytes, void **ptrs) > - { > +{ > u8 **dptr = (u8 **)ptrs; > u8 *p, *q; > int d, z, z0; > @@ -471,7 +471,7 @@ static void raid6_sse24_gen_syndrome(int disks, size_t > bytes, void **ptrs) > } > asm volatile("sfence" : : : "memory"); > kernel_fpu_end(); > - } > +} > > > const struct raid6_calls raid6_sse2x4 = { > diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c > index 0c11f434a374..ec619f51d336 100644 > --- a/sound/soc/fsl/fsl_dma.c > +++ b/sound/soc/fsl/fsl_dma.c > @@ -879,7 +879,7 @@ static const struct snd_pcm_ops fsl_dma_ops = { > }; > > static int fsl_soc_dma_probe(struct platform_device *pdev) > - { > +{ > struct dma_object *dma; > struct device_node *np = pdev->dev.of_node; > struct device_node *ssi_np; > > -- Acked-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com> for the ACPI part. Thanks!

Re: [v2 PATCH] cpufreq: powernv: Correctly parse the sign of pstates on POWER8 vs POWER9

2017-12-08 Thread Rafael J. Wysocki
On Fri, Dec 8, 2017 at 12:47 PM, Michael Ellerman <m...@ellerman.id.au> wrote: > "Rafael J. Wysocki" <raf...@kernel.org> writes: > >> On Thu, Dec 7, 2017 at 6:59 AM, Gautham R. Shenoy >> <e...@linux.vnet.ibm.com> wrote: >>> From: "Gau

Re: [v2 PATCH] cpufreq: powernv: Correctly parse the sign of pstates on POWER8 vs POWER9

2017-12-07 Thread Rafael J. Wysocki
On Thu, Dec 7, 2017 at 6:59 AM, Gautham R. Shenoy wrote: > From: "Gautham R. Shenoy" > > On POWERNV platform, Pstates are 8-bit values. On POWER8 they are > negatively numbered while on POWER9 they are positively > numbered. Thus, on POWER9, the

Re: Linux 4.14: Reported regressions as of Sunday, 2017-10-08

2017-10-11 Thread Rafael J. Wysocki
On Sunday, October 8, 2017 2:37:41 PM CEST Thorsten Leemhuis wrote: > Hi! Find below my second regression report for Linux 4.14. It lists 8 > regressions I'm currently aware of. One regression was fixed since last > weeks report. One was in there that shouldn't have been there. > > As always: Are

Re: [PATCH 03/13] timer: Remove init_timer_on_stack() in favor of timer_setup_on_stack()

2017-10-05 Thread Rafael J. Wysocki
-to-one mapping > of parent structure to timer, those are switched to using timer_setup() > instead. All related callbacks were adjusted to use from_timer(). > > Cc: "Rafael J. Wysocki" <r...@rjwysocki.net> > Cc: Pavel Machek <pa...@ucw.cz> > Cc: Len Br

Re: [PATCH V3 0/9] cpufreq: transition-latency cleanups

2017-07-19 Thread Rafael J. Wysocki
On Wednesday, July 19, 2017 03:42:40 PM Viresh Kumar wrote: > Hi Rafael, > > This series tries to cleanup the code around transition-latency and its > users. Some of the old legacy code, which may not make much sense now, > is dropped as well. And some code consolidation is also done across >

Re: [1/3] cpuidle: powerpc: cpuidle set polling before enabling irqs

2017-06-30 Thread Rafael J. Wysocki
On Fri, Jun 30, 2017 at 5:45 AM, Michael Ellerman <m...@ellerman.id.au> wrote: > "Rafael J. Wysocki" <raf...@kernel.org> writes: > >> On Thu, Jun 29, 2017 at 2:21 PM, Michael Ellerman >> <patch-notificati...@ellerman.id.au> wrote: >>> On

Re: [1/3] cpuidle: powerpc: cpuidle set polling before enabling irqs

2017-06-29 Thread Rafael J. Wysocki
On Thu, Jun 29, 2017 at 2:21 PM, Michael Ellerman wrote: > On Wed, 2017-06-14 at 13:02:39 UTC, Nicholas Piggin wrote: >> local_irq_enable can cause interrupts to be taken which could >> take significant amount of processing time. The idle process >> should set

Re: [PATCH] kernel/power/suspend: use CONFIG_HAVE_SET_MEMORY for include condition

2017-06-26 Thread Rafael J. Wysocki
led on powerpc. We don't yet have ARCH_HAS_SET_MEMORY and ppc32 > >> saw a build failure. > >> > >> fixes(50327dd kernel/power/snapshot.c: use set_memory.h header) > >> > >> I've only done a basic compile test with a config that has > >> hiberna

Re: [PATCH v2 1/2] powerpc/powernv/cpuidle: Pass correct drv->cpumask for registration

2017-03-23 Thread Rafael J. Wysocki
On Thu, Mar 23, 2017 at 4:22 PM, Vaidyanathan Srinivasan wrote: > drv->cpumask defaults to cpu_possible_mask in __cpuidle_driver_init(). > On PowerNV platform cpu_present could be less than cpu_possible in cases > where firmware detects the cpu, but it is not available

Re: [PATCH v2 2/2] cpuidle: Validate cpu_dev in cpuidle_add_sysfs

2017-03-23 Thread Rafael J. Wysocki
On Thu, Mar 23, 2017 at 4:22 PM, Vaidyanathan Srinivasan wrote: > If a given cpu is not in cpu_present and cpu hotplug > is disabled, arch can skip setting up the cpu_dev. > > Arch cpuidle driver should pass correct cpu mask > for registration, but failing to do so by

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-17 Thread Rafael J. Wysocki
On Fri, Feb 17, 2017 at 8:11 AM, Joe Perches wrote: > There are ~4300 uses of pr_warn and ~250 uses of the older > pr_warning in the kernel source tree. > > Make the use of pr_warn consistent across all kernel files. > > This excludes all files in tools/ as there is a separate >

Re: [PATCH v6 3/5] cpuidle:powernv: Add helper function to populate powernv idle states.

2017-01-29 Thread Rafael J. Wysocki
On Mon, Jan 30, 2017 at 4:47 AM, Michael Ellerman wrote: > "Gautham R. Shenoy" writes: > >> From: "Gautham R. Shenoy" >> >> In the current code for powernv_add_idle_states, there is a lot of code >> duplication while

Re: [PATCH] cpuidle/powernv: staticise powernv_idle_driver

2016-11-28 Thread Rafael J. Wysocki
On Tue, Nov 22, 2016 at 6:08 AM, Andrew Donnellan wrote: > powernv_idle_driver isn't exported, it can be made static. Found by sparse. > > Signed-off-by: Andrew Donnellan Applied. Thanks, Rafael

Re: [PATCH v2] cpufreq, powernv: Disable preemption while checking CPU throttling state throttling state

2016-11-22 Thread Rafael J. Wysocki
On Tue, Nov 22, 2016 at 2:07 PM, Denis Kirjanov wrote: > With preemption turned on we can read incorrect throttling state while being > switched > to CPU on a different chip. > The following BUG_() was hit while running the 4.8-rc5 kernel compiled > with

Re: [PATCH -next] powernv: cpufreq: Fix uninitialized lpstate_idx in gpstates_timer_handler

2016-11-14 Thread Rafael J. Wysocki
On Monday, November 14, 2016 05:29:27 PM Akshay Adiga wrote: > lpstate_idx remains uninitialized in the case when elapsed_time > is greater than MAX_RAMP_DOWN_TIME. At the end of rampdown > global pstate should be equal to local pstate. > > Fixes: 20b15b766354 ("cpufreq: powernv: Use PMCR to

Re: [PATCH v2 0/3] powernv:stop: Use psscr_val, mask provided by firmware

2016-10-31 Thread Rafael J. Wysocki
On Thursday, October 27, 2016 02:05:04 PM Gautham R. Shenoy wrote: > From: "Gautham R. Shenoy" > > Hi, > > This is the second iteration of the patchset to use the psscr_val and > psscr_mask provided by the firmware for each of the stop states. > > The previous version

  1   2   3   >