Re: [PATCH] of: address: Unify resource bounds overflow checking

2024-09-13 Thread Rob Herring
On Fri, Sep 13, 2024 at 8:15 AM Michael Ellerman wrote: > > Thomas Weißschuh writes: > > The members "start" and "end" of struct resource are of type > > "resource_size_t" which can be 32bit wide. > > Values read from OF however are always 64bit wide. > > > > Refactor the diff overflow checks int

Re: [Patch v5 02/12] dt-bindings: dma: Add lpc32xx DMA mux binding

2024-09-10 Thread Rob Herring (Arm)
On Thu, 27 Jun 2024 17:00:20 +0200, Piotr Wojtaszczyk wrote: > LPC32XX SoCs use pl080 dma controller which have few request signals > multiplexed between peripherals. This binding describes how devices can > use the multiplexed request signals. > > Signed-off-by: Piotr Wojtaszczyk > --- > Changes

Re: [PATCH 1/1] dt-bindings: soc: fsl: cpm_qe: convert network.txt to yaml

2024-08-15 Thread Rob Herring (Arm)
On Mon, 12 Aug 2024 12:50:35 -0400, Frank Li wrote: > Convert binding doc newwork.txt to yaml format. > > HDLC part: > - Convert to "fsl,ucc-hdlc.yaml". > - Add missed reg and interrupt property. > - Update example to pass build. > > ethernet part: > - Convert to net/fsl,cpm-enet.yaml > - Add 0

Re: [PATCH v2 23/36] dt-bindings: soc: fsl: cpm_qe: Add QUICC Engine (QE) QMC controller

2024-08-13 Thread Rob Herring
On Thu, Aug 08, 2024 at 09:11:16AM +0200, Herve Codina wrote: > Add support for the QMC (QUICC Multichannel Controller) available in > some PowerQUICC SoC that uses a QUICC Engine (QE) block such as MPC8321. > > This QE QMC is similar to the CPM QMC except that it uses UCCs (Unified > Communicatio

Re: [PATCH v2 07/36] dt-bindings: soc: fsl: cpm_qe: Add QUICC Engine (QE) TSA controller

2024-08-13 Thread Rob Herring (Arm)
c/fsl/cpm_qe/fsl,qe-tsa.yaml | 210 ++ > include/dt-bindings/soc/qe-fsl,tsa.h | 13 ++ > 2 files changed, 223 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qe-tsa.yaml > create mode 100644 include/dt-bindings/soc/qe-fsl,tsa.h > Reviewed-by: Rob Herring (Arm)

Re: [PATCH v3] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-08-13 Thread Rob Herring (Arm)
out_destroy_cset’ defined but > not used [-Wunused-label] > 696 | out_destroy_cset: > | ^~~~ > * V1: > https://lore.kernel.org/all/20240703141634.2974589-1-amach...@linux.ibm.com/ > > drivers/pci/of.c | 3 ++- > include/linux/of.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring (Arm)

Re: [PATCH v3] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-08-13 Thread Rob Herring
On Tue, Aug 06, 2024 at 03:00:59PM -0500, Bjorn Helgaas wrote: > On Sat, Aug 03, 2024 at 12:03:25AM +0530, Amit Machhiwal wrote: > > With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence > > of a PCI device attached to a PCI-bridge causes following kernel Oops on > > a pseries KV

Re: [PATCH] dt-bindings: fsl: fsl,rcpm: fix unevaluated fsl,rcpm-wakeup property

2024-08-12 Thread Rob Herring (Arm)
On Sun, 11 Aug 2024 17:35:07 +0200, Krzysztof Kozlowski wrote: > Drop the RCPM consumer example from the binding (LPUART device node), > because: > 1. Using phandles is typical syntax, thus explaining it is not needed in >the provider binding, > 2. It has 'fsl,rcpm-wakeup' property which is n

Re: [PATCH v2 1/1] dt-bindings: soc: fsl: add missed compatible string fsl,ls*-isc

2024-08-06 Thread Rob Herring (Arm)
On Tue, 06 Aug 2024 12:21:21 -0400, Frank Li wrote: > Add compatible string, fsl,ls1088a-isc, fsl,ls2080a-isc, fsl,lx2160a-isc. > Fix the below warning: > arch/arm64/boot/dts/freescale/fsl-ls2080a-qds.dtb: /soc/syscon@1f7: > failed to match any schema with compatible: ['fsl,ls2080a-isc', 'sy

Re: [PATCH v4 1/1] dt-bindings: soc: fsl: Convert rcpm to yaml format

2024-08-06 Thread Rob Herring (Arm)
On Fri, 02 Aug 2024 11:22:19 -0400, Frank Li wrote: > Convert dt-binding rcpm from txt to yaml format. > Add fsl,ls1028a-rcpm compatible string. > > Additional changes: > - Add missed compatible string fsl,-rcpm. > - Remove map fsl,-rcpm to fsl,qoriq-rcpm-. > > Signed-off-by: Frank Li > --- >

Re: [PATCH] powerpc: dtc: update P2020RDB dts

2024-08-01 Thread Rob Herring
On Wed, Jul 31, 2024 at 11:14 PM Pawel Dembicki wrote: > On the subject, every patch is an 'update'. Please make it more specific. If you have a hard time coming up with something specific, that's a sign your patch is making too many separate changes. > P2020RDB contains multiple peripherals, wh

Re: [PATCH] powerpc: dtc: update P2020RDB dts

2024-08-01 Thread Rob Herring (Arm)
On Thu, 01 Aug 2024 07:14:01 +0200, Pawel Dembicki wrote: > P2020RDB contains multiple peripherals, which isn't added to > devicetree: > - Switch: Microchip VSC7385 > - PMIC: Renesas ZL2006 > - Temperature sensor: Analog Devices ADT7461 > - Two eeproms: 24C256 and 24C01 > - GPIO expande

Re: [PATCH v2 1/1] dt-bindings: soc: fsl: Convert rcpm to yaml format

2024-07-31 Thread Rob Herring
On Wed, Jul 31, 2024 at 11:04:20AM -0400, Frank Li wrote: > Convert dt-binding rcpm from txt to yaml format. > Add fsl,ls1028a-rcpm compatible string. > > Additional changes: > - Add missed compatible string fsl,-rcpm. > - Remove map fsl,-rcpm to fsl,qoriq-rcpm-. > > Signed-off-by: Frank Li > --

[PATCH] powerpc: Use of_property_present()

2024-07-31 Thread Rob Herring (Arm)
freed. Signed-off-by: Rob Herring (Arm) --- arch/powerpc/platforms/powernv/eeh-powernv.c | 2 +- arch/powerpc/platforms/powernv/opal-lpc.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c b/arch/powerpc/platforms/powernv/eeh

[PATCH] cpufreq: Use of_property_present()

2024-07-31 Thread Rob Herring (Arm)
allocated nodes which may be freed. Signed-off-by: Rob Herring (Arm) --- drivers/cpufreq/cpufreq-dt.c | 11 +++ drivers/cpufreq/pmac64-cpufreq.c | 2 +- drivers/cpufreq/sti-cpufreq.c | 2 +- drivers/cpufreq/sun50i-cpufreq-nvmem.c | 2 +- 4 files changed, 6 insertions

Re: [PATCH 1/1] dt-bindings: soc: fsl: Convert rcpm to yaml format

2024-07-30 Thread Rob Herring
On Mon, Jul 29, 2024 at 03:11:42PM -0400, Frank Li wrote: > Convert dt-binding rcpm from txt to yaml format. > Add fsl,ls1028a-rcpm compatible string. > > Signed-off-by: Frank Li > --- > .../bindings/rtc/fsl,ls-ftm-alarm.yaml| 2 +- > .../devicetree/bindings/soc/fsl/fsl,rcpm.yaml | 91 +

Re: [PATCH v1 23/36] dt-bindings: soc: fsl: cpm_qe: Add QUICC Engine (QE) QMC controller

2024-07-30 Thread Rob Herring
On Mon, Jul 29, 2024 at 04:20:52PM +0200, Herve Codina wrote: > Add support for the QMC (QUICC Multichannel Controller) available in > some PowerQUICC SoC that uses a QUICC Engine (QE) block such as MPC8321. > > This QE QMC is similar to the CPM QMC except that it uses UCCs (Unified > Communicatio

Re: [PATCH v1 07/36] dt-bindings: soc: fsl: cpm_qe: Add QUICC Engine (QE) TSA controller

2024-07-30 Thread Rob Herring
On Mon, Jul 29, 2024 at 04:20:36PM +0200, Herve Codina wrote: > Add support for the time slot assigner (TSA) available in some > PowerQUICC SoC that uses a QUICC Engine (QE) block such as MPC8321. > > This QE TSA is similar to the CPM TSA except that it uses UCCs (Unified > Communication Controlle

[PATCH 2/2] cxl: Use of_property_ accessor functions

2024-07-29 Thread Rob Herring (Arm)
property data. Signed-off-by: Rob Herring (Arm) --- drivers/misc/cxl/of.c | 106 ++--- drivers/misc/cxl/pci.c | 32 ++- 2 files changed, 33 insertions(+), 105 deletions(-) diff --git a/drivers/misc/cxl/of.c b/drivers/misc/cxl/of.c index

[PATCH 0/2] cxl: DT property accessor cleanups

2024-07-29 Thread Rob Herring (Arm)
remove DT functions leaking DT data (e.g. of_get_property()). Signed-off-by: Rob Herring (Arm) --- Rob Herring (Arm) (2): cxl: Drop printing of DT properties cxl: Use of_property_ accessor functions drivers/misc/cxl/of.c | 207

[PATCH 1/2] cxl: Drop printing of DT properties

2024-07-29 Thread Rob Herring (Arm)
There's little reason to dump DT property values when they can be read at any time from the DT in /proc/device-tree. If such a feature is needed, then it really should be implemented in the DT core such that any module/driver can use it. Signed-off-by: Rob Herring (Arm) --- drivers/mis

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-26 Thread Rob Herring
On Thu, Jul 25, 2024 at 6:06 PM Lizhi Hou wrote: > > Hi Amit, > > > I try to follow the option which add a OF flag. If Rob is ok with this, > I would suggest to use it instead of V1 patch > > diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c > index dda6092e6d3a..a401ed0463d9 100644 > --- a

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-26 Thread Rob Herring
+ Ubuntu kernel list, again On Thu, Jul 25, 2024 at 11:15:39PM +0530, Amit Machhiwal wrote: > Hi Lizhi, Rob, > > Sorry for responding late. I got busy with some other things. > > On 2024/07/23 02:08 PM, Lizhi Hou wrote: > > > > On 7/23/24 12:54, Rob Herring wrote: &g

Re: [PATCH v2] of: remove internal arguments from of_property_for_each_u32()

2024-07-24 Thread Rob Herring
On Thu, Jul 18, 2024 at 1:57 AM Luca Ceresoli wrote: > > Hello Stephen, > > On Wed, 17 Jul 2024 16:33:34 -0700 > Stephen Boyd wrote: > > > > @@ -1191,20 +1191,24 @@ static int si5351_dt_parse(struct i2c_client > > > *client, > > > * property silabs,pll-source : , [<..>] > > > *

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-23 Thread Rob Herring
On Tue, Jul 23, 2024 at 12:21 PM Lizhi Hou wrote: > > > On 7/23/24 09:21, Rob Herring wrote: > > On Mon, Jul 15, 2024 at 01:52:30PM -0700, Lizhi Hou wrote: > >> On 7/15/24 11:55, Rob Herring wrote: > >>> On Mon, Jul 15, 2024 at 2:08 AM Amit

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-23 Thread Rob Herring
On Mon, Jul 15, 2024 at 01:52:30PM -0700, Lizhi Hou wrote: > > On 7/15/24 11:55, Rob Herring wrote: > > On Mon, Jul 15, 2024 at 2:08 AM Amit Machhiwal > > wrote: > > > With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence > > > of a PCI de

Re: [PATCH] tpm: atmel: Drop PPC64 specific MMIO setup

2024-07-18 Thread Rob Herring
On Wed, Jul 17, 2024 at 6:14 AM Jarkko Sakkinen wrote: > > On Wed Jul 17, 2024 at 3:08 PM EEST, Jarkko Sakkinen wrote: > > On Tue Jul 2, 2024 at 7:10 PM EEST, Rob Herring (Arm) wrote: > > > The PPC64 specific MMIO setup open codes DT address functions rather > > &g

Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-15 Thread Rob Herring
On Mon, Jul 15, 2024 at 2:08 AM Amit Machhiwal wrote: > > With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence > of a PCI device attached to a PCI-bridge causes following kernel Oops on > a pseries KVM guest: > > RTAS: event: 2, Type: Hotplug Event (229), Severity: 1 > Kernel

Re: [PATCH] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-11 Thread Rob Herring
+Ubuntu kernel team On Thu, Jul 11, 2024 at 8:21 AM Amit Machhiwal wrote: > > Hi Rob, > > On 2024/07/11 06:20 AM, Rob Herring wrote: > > On Wed, Jul 3, 2024 at 8:17 AM Amit Machhiwal > > wrote: > > > > > > With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-p

Re: [PATCH] PCI: Fix crash during pci_dev hot-unplug on pseries KVM guest

2024-07-11 Thread Rob Herring
On Wed, Jul 3, 2024 at 8:17 AM Amit Machhiwal wrote: > > With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence > of a PCI device attached to a PCI-bridge causes following kernel Oops on > a pseries KVM guest: Can I ask why you have this option on in the first place? Do you have

Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

2024-07-10 Thread Rob Herring
On Tue, Jul 9, 2024 at 9:53 PM Christian Zigotzky wrote: > > Hi All, > > The RC7 of kernel 6.10 boots without any problems [1] if we use the > second irq patch [2]. Is it possible to add this patch to the mainline > kernel? Yes, sent it to Linus yesterday. Rob

Re: [PATCH 1/2] dt-bindings: soc: fsl: Add fsl,ls1028a-reset for reset syscon node

2024-07-08 Thread Rob Herring (Arm)
On Wed, 03 Jul 2024 14:08:11 -0400, Frank Li wrote: > ls1028a has a reset module that includes reboot, reset control word, and > service processor control. > > Add platform specific compatible string to fix the below warning. > > syscon@1e6: compatible: 'anyOf' conditional failed, one must

Re: [PATCH 1/2] dt-bindings: soc: fsl: cpm_qe: convert to yaml format

2024-07-08 Thread Rob Herring (Arm)
On Wed, 03 Jul 2024 12:49:39 -0400, Frank Li wrote: > Convert binding doc qe.txt to yaml format. Split it to > fsl,qe-firmware.yaml, fsl,qe-ic.yaml, fsl,qe-muram.yaml, fsl,qe-si.yaml > fsl,qe-siram.yaml, fsl,qe.yaml. > > Additional Changes: > - Fix error in example. > - Change to low case for he

Re: [PATCH v6 5/7] ASoC: dt-bindings: update fsl-asoc-card bindings after imx-spdif merge

2024-07-08 Thread Rob Herring (Arm)
pdif.yaml | 66 ------- > .../bindings/sound/fsl-asoc-card.yaml | 53 +-- > 2 files changed, 49 insertions(+), 70 deletions(-) > delete mode 100644 > Documentation/devicetree/bindings/sound/fsl,imx-audio-spdif.yaml > Reviewed-by: Rob Herring (Arm)

Re: [PATCH 00/20] Simplify of_property_for_each_u32()

2024-07-03 Thread Rob Herring
On Wed, Jul 03, 2024 at 12:36:44PM +0200, Luca Ceresoli wrote: > [Note: to reduce the noise I have trimmed the get_maintainers list > manually. Should you want to be removed, or someone else added, to future > versions, just tell me. Sorry for the noise.] > > This series aims at simplifying of_pro

Re: [PATCH 20/20] of: deprecate and rename of_property_for_each_u32()

2024-07-03 Thread Rob Herring
On Wed, Jul 03, 2024 at 12:37:04PM +0200, Luca Ceresoli wrote: > of_property_for_each_u32() is meant to disappear. All the call sites not > using the 3rd and 4th arguments have already been replaced by > of_property_for_each_u32_new(). > > Deprecate the old macro. Also rename it to minimize the nu

[PATCH] powerpc: kexec: Use of_property_read_reg()

2024-07-02 Thread Rob Herring (Arm)
Replace open-coded parsing of "reg" property with of_property_read_reg(). Signed-off-by: Rob Herring (Arm) --- arch/powerpc/kexec/file_load_64.c | 31 ++- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git a/arch/powerpc/kexec/file_load_64

Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

2024-07-02 Thread Rob Herring
On Tue, Jul 2, 2024 at 10:54 AM Marc Zyngier wrote: > > On Sun, 30 Jun 2024 11:21:55 +0100, > Christian Zigotzky wrote: > > > > Hello, > > > > There is an issue with the identification of ATA drives with our > > P.A. Semi Nemo boards [1] after the > > commit "of/irq: Factor out parsing of interru

[PATCH] tpm: atmel: Drop PPC64 specific MMIO setup

2024-07-02 Thread Rob Herring (Arm)
was a PPC405 platform, but that is 32-bit and PPC405 support is being removed as well. CONFIG_TCG_ATMEL is not enabled for any powerpc config and never was. The support was added in 2005 and hasn't been touched since. Rather than try to modernize and fix this code, just remove it. Signed-o

Re: [PATCH 1/2] ASoC: dt-bindings: fsl_rpmsg: Add compatible string for i.MX95

2024-06-28 Thread Rob Herring (Arm)
sg.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring (Arm)

Re: [PATCH v2 1/1] dt-bindings: soc: fsl: Convert q(b)man-* to yaml format

2024-06-28 Thread Rob Herring (Arm)
On Wed, 26 Jun 2024 15:37:53 -0400, Frank Li wrote: > Convert qman, bman, qman-portals, bman-portals to yaml format. > > Additional Change for fsl,q(b)man-portal: > - Only keep one example. > - Add fsl,qman-channel-id property. > - Use interrupt type macro. > - Remove top level qman-portals@ff42

Re: [PATCH 09/10] dt-bindings: sound: fsl,qmc-audio: Add support for multiple QMC channels per DAI

2024-06-27 Thread Rob Herring (Arm)
ions(+), 6 deletions(-) > Reviewed-by: Rob Herring (Arm)

Re: [PATCH 1/1] dt-bindings: soc: fsl: Convert q(b)man-* to yaml format

2024-06-24 Thread Rob Herring
On Fri, Jun 21, 2024 at 05:30:14PM -0400, Frank Li wrote: > Convert qman, bman, qman-portals, bman-portals to yaml format. > > Additional Chang for fsl,q(b)man-portal: typo > - Only keep one example. > - Add fsl,qman-channel-id property. > - Use interrupt type macro. > - Remove top level qman-po

Re: [PATCH 1/1] dt-bindings: soc: fsl: Convert q(b)man-* to yaml format

2024-06-21 Thread Rob Herring (Arm)
On Fri, 21 Jun 2024 17:30:14 -0400, Frank Li wrote: > Convert qman, bman, qman-portals, bman-portals to yaml format. > > Additional Chang for fsl,q(b)man-portal: > - Only keep one example. > - Add fsl,qman-channel-id property. > - Use interrupt type macro. > - Remove top level qman-portals@ff420

Re: [Patch v4 02/10] dt-bindings: dma: Add lpc32xx DMA mux binding

2024-06-20 Thread Rob Herring (Arm)
On Thu, 20 Jun 2024 19:56:33 +0200, Piotr Wojtaszczyk wrote: > LPC32XX SoCs use pl080 dma controller which have few request signals > multiplexed between peripherals. This binding describes how devices can > use the multiplexed request signals. > > Signed-off-by: Piotr Wojtaszczyk > --- > Chang

Re: [Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding

2024-06-11 Thread Rob Herring (Arm)
On Tue, 11 Jun 2024 11:47:52 +0200, Piotr Wojtaszczyk wrote: > Add nxp,lpc3220-i2s DT binding documentation. > > Signed-off-by: Piotr Wojtaszczyk > --- > Changes for v2: > - Added maintainers field > - Dropped clock-names > - Dropped unused unneded interrupts field > > .../bindings/sound/nxp,

Re: [PATCH v4 1/2] ASoC: dt-bindings: fsl,xcvr: Add compatible string for i.MX95

2024-06-03 Thread Rob Herring (Arm)
' configuration has the same constraint > as i.MX93. > > Only on i.MX8MP, the 'resets' is required, but for i.MX95 and i.MX93 > there is no such hardware setting. > > Signed-off-by: Shengjiu Wang > --- > .../devicetree/bindings/sound/fsl,xcvr.yaml | 32 ++- > 1 file changed, 31 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring (Arm)

Re: [PATCH v2 1/2] ASoC: dt-bindings: fsl,mqs: Add i.MX95 platform support

2024-05-28 Thread Rob Herring (Arm)
ound/fsl,mqs.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Rob Herring (Arm)

Re: [PATCH v3 1/2] ASoC: dt-bindings: fsl,xcvr: Add compatible string for i.MX95

2024-05-28 Thread Rob Herring
On Tue, May 21, 2024 at 06:13:35PM +0800, Shengjiu Wang wrote: > Add compatible string "fsl,imx95-xcvr" for i.MX95 platform. > > The difference between each platform is in below table. > > +-++--++ > | SOC | PHY | eARC/ARC | SPDIF | > +-+-

Re: [PATCHv4 9/9] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec

2024-05-20 Thread Rob Herring
On Wed, May 15, 2024 at 03:54:11PM +0200, Elinor Montmasson wrote: > Add documentation about new dts bindings following new support > for compatible "fsl,imx-audio-generic". > > Some CPU DAI don't require a real audio codec. The new compatible > "fsl,imx-audio-generic" allows using the driver with

Re: [PATCH v2 1/2] ASoC: dt-bindings: fsl,xcvr: Add compatible string for i.MX95

2024-05-20 Thread Rob Herring
On Tue, May 14, 2024 at 11:12:08AM +0800, Shengjiu Wang wrote: > Add compatible string "fsl,imx95-xcvr" for i.MX95 platform. > > The difference between each platform is in below table. > > +-++--++ > | SOC | PHY | eARC/ARC | SPDIF | > +-+-

Re: [PATCH 0/7] Remove 40x

2024-05-06 Thread Rob Herring (Arm)
On Mon, 06 May 2024 22:51:45 +1000, Michael Ellerman wrote: > The 40x platforms & CPUs are old and have been unmaintained for years, and as > far as we can tell have no users. > > Note 44x and 476 are not affected. > > Christophe first proposed removing 40x in 2020: > > https://lore.kernel.o

Re: [PATCH v2] ASoC: dt-bindings: fsl,ssi: Convert to YAML

2024-04-23 Thread Rob Herring
On Mon, Apr 22, 2024 at 01:48:14PM +0800, Shengjiu Wang wrote: > Convert the fsl,ssi binding to YAML. > > Add below compatible strings which were not listed > in document: > > fsl,imx50-ssi > fsl,imx53-ssi > fsl,imx25-ssi > fsl,imx27-ssi > fsl,imx6q-ssi > fsl,imx6sl-ssi > fsl,imx6sx-ssi > > Add

Re: [PATCH 5/5] dt-bindings: hwmon: ibm,p8-occ-hwmon: move to trivial devices

2024-03-21 Thread Rob Herring
occ-hwmon.txt | 25 > -- > .../devicetree/bindings/trivial-devices.yaml | 2 ++ > 2 files changed, 2 insertions(+), 25 deletions(-) > Reviewed-by: Rob Herring

Re: [PATCH 3/5] dt-bindings: hwmon: pwm-fan: drop text file

2024-03-21 Thread Rob Herring
On Thu, 21 Mar 2024 19:43:44 +0100, Javier Carrasco wrote: > This binding was converted to dtschema a year ago. > > Signed-off-by: Javier Carrasco > --- > Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 1 - > 1 file changed, 1 deletion(-) > Acked-by: Rob Herring

Re: [PATCH 1/5] dt-bindings: hwmon: as370: convert to dtschema

2024-03-21 Thread Rob Herring
hwmon/as370.txt | 11 > .../devicetree/bindings/hwmon/syna,as370.yaml | 32 > ++ > 2 files changed, 32 insertions(+), 11 deletions(-) > Reviewed-by: Rob Herring

Re: [PATCH 4/5] dt-bindings: hwmon: stts751: convert to dtschema

2024-03-21 Thread Rob Herring
On Thu, 21 Mar 2024 19:43:45 +0100, Javier Carrasco wrote: > Convert existing binding to support validation. > > This is a straightforward conversion with no new properties. > > Signed-off-by: Javier Carrasco > --- > .../devicetree/bindings/hwmon/st,stts751.yaml | 41 > +

Re: [PATCH 2/5] dt-bindings: hwmon: ibmpowernv: convert to dtschema

2024-03-21 Thread Rob Herring
On Thu, 21 Mar 2024 19:43:43 +0100, Javier Carrasco wrote: > Convert existing binding to support validation. > > This is a straightforward conversion with now new properties. > > Signed-off-by: Javier Carrasco > --- > .../devicetree/bindings/hwmon/ibm,powernv.yaml | 37 >

Re: [PATCH 1/2] powerpc/prom_init: Replace linux,sml-base/sml-size with linux,sml-log

2024-03-12 Thread Rob Herring
On Tue, Mar 12, 2024 at 09:32:50PM +1100, Michael Ellerman wrote: > Rob Herring writes: > > On Fri, Mar 08, 2024 at 07:23:35AM -0500, Stefan Berger wrote: > >> On 3/7/24 16:52, Rob Herring wrote: > >> > On Thu, Mar 07, 2024 at 09:41:31PM +1100, Michael Ellerman

Re: [PATCH 1/2] powerpc/prom_init: Replace linux,sml-base/sml-size with linux,sml-log

2024-03-08 Thread Rob Herring
On Fri, Mar 08, 2024 at 07:23:35AM -0500, Stefan Berger wrote: > > > On 3/7/24 16:52, Rob Herring wrote: > > On Thu, Mar 07, 2024 at 09:41:31PM +1100, Michael Ellerman wrote: > > > Stefan Berger writes: > > > > linux,sml-base holds the address of a buffer w

Re: [PATCH 1/2] powerpc/prom_init: Replace linux,sml-base/sml-size with linux,sml-log

2024-03-07 Thread Rob Herring
On Thu, Mar 07, 2024 at 09:41:31PM +1100, Michael Ellerman wrote: > Stefan Berger writes: > > linux,sml-base holds the address of a buffer with the TPM log. This > > buffer may become invalid after a kexec and therefore embed the whole TPM > > log in linux,sml-log. This helps to protect the log si

Re: [PATCH 0/2] Preserve TPM log across kexec

2024-03-07 Thread Rob Herring
On Wed, Mar 06, 2024 at 11:08:20AM -0500, Stefan Berger wrote: > > > On 3/6/24 10:55, Stefan Berger wrote: > > This series resolves an issue on PowerVM and KVM on Power where the memory > > the TPM log was held in may become inaccessible or corrupted after a kexec > > soft reboot. The solution on

Re: [PATCH] soc: fsl: qbman: Remove RESERVEDMEM_OF_DECLARE usage

2024-03-05 Thread Rob Herring
On Thu, 01 Feb 2024 13:29:30 -0600, Rob Herring wrote: > There is no reason to use RESERVEDMEM_OF_DECLARE() as the initialization > hook just saves off the base address and size. Use of > RESERVEDMEM_OF_DECLARE() is reserved for non-driver code and > initialization which must be don

[PATCH] soc: fsl: qbman: Remove RESERVEDMEM_OF_DECLARE usage

2024-02-01 Thread Rob Herring
as easily. Signed-off-by: Rob Herring --- drivers/soc/fsl/qbman/bman_ccsr.c | 27 +++- drivers/soc/fsl/qbman/dpaa_sys.c | 12 +++-- drivers/soc/fsl/qbman/dpaa_sys.h | 4 +- drivers/soc/fsl/qbman/qman_ccsr.c | 73 ++- 4 files changed, 38 insertions(+), 78

Re: [PATCH] dt-bindings: soc: fsl: narrow regex for unit address to hex numbers

2024-01-30 Thread Rob Herring
> .../devicetree/bindings/soc/fsl/fsl,layerscape-scfg.yaml| 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Acked-by: Rob Herring

Re: [PATCHv3 RESEND 10/10] ASoC: dt-bindings: fsl-asoc-card: add compatible for generic codec

2023-12-20 Thread Rob Herring
On Mon, Dec 18, 2023 at 01:40:58PM +0100, Elinor Montmasson wrote: > Add documentation about new dts bindings following new support > for compatible "fsl,imx-audio-generic". > > Some CPU DAI don't require a real audio codec. The new compatible > "fsl,imx-audio-generic" allows using the driver with

Re: [PATCH v1 2/4] of: Reimplement of_machine_is_compatible() using of_machine_compatible_match()

2023-12-07 Thread Rob Herring
; with a single string then using of_machine_compatible_match(). > > Suggested-by: Rob Herring > Signed-off-by: Christophe Leroy > --- > drivers/of/base.c | 22 +- > include/linux/of.h | 15 ++- > 2 files changed, 15 insertions(+), 22 deletions(-)

Re: [PATCH v1 1/4] of: Add of_machine_compatible_match()

2023-12-07 Thread Rob Herring
umenting, and also avoids the caller needing to juggle the root > node either directly or via of_find_node_by_path(). > > Signed-off-by: Michael Ellerman > Signed-off-by: Christophe Leroy > --- > drivers/of/base.c | 21 + > include/linux/of.h | 6 ++ > 2 files changed, 27 insertions(+) > Reviewed-by: Rob Herring

Re: [PATCH v1 4/4] powerpc: Stop using of_root

2023-12-07 Thread Rob Herring
cfg.c | 6 +- > arch/powerpc/platforms/pseries/setup.c | 12 +--- > 8 files changed, 40 insertions(+), 18 deletions(-) Reviewed-by: Rob Herring

Re: [PATCH v1 3/4] powerpc/machdep: Define 'compatibles' property in ppc_md and use it

2023-12-07 Thread Rob Herring
ns(+), 64 deletions(-) > -/* > - * Called very early, MMU is off, device-tree isn't unflattened > - */ Certainly an out of date comment as the unflattened API was being called. Reviewed-by: Rob Herring

Re: [PATCH] dt-bindings: fsl,dpaa2-console: drop unneeded quotes

2023-11-27 Thread Rob Herring
On Wed, 22 Nov 2023 15:44:19 -0700, Rob Herring wrote: > Drop unneeded quotes over simple string values to fix a soon to be > enabled yamllint warning: > > [error] string value is redundantly quoted with any quotes (quoted-strings) > > Signed-off-by: Rob Herring >

[PATCH] dt-bindings: fsl,dpaa2-console: drop unneeded quotes

2023-11-22 Thread Rob Herring
Drop unneeded quotes over simple string values to fix a soon to be enabled yamllint warning: [error] string value is redundantly quoted with any quotes (quoted-strings) Signed-off-by: Rob Herring --- Documentation/devicetree/bindings/misc/fsl,dpaa2-console.yaml | 2 +- 1 file changed, 1

Re: [PATCH 7/8] of: replace command line handling

2023-11-16 Thread Rob Herring
On Thu, Nov 09, 2023 at 05:38:11PM -0800, Daniel Walker wrote: > Rob Herring has complained about this section of code. I removed the > command line handling code to the cmdline.h header. This hopefully makes > it easier for Rob to maintain it (at least he doesn't have to look at

Re: [PATCH v8 00/30] Add support for QMC HDLC, framer infrastructure and PEF2256 framer

2023-10-30 Thread Rob Herring
On Wed, Oct 25, 2023 at 12:32:15PM -0700, Jakub Kicinski wrote: > On Wed, 25 Oct 2023 17:00:51 +0200 Herve Codina wrote: > > > Which way will those patches go? Via some FSL SoC tree? > > > > This series seems mature now. > > What is the plan next in order to have it applied ? > > > > Don't hesi

Re: Several kmemleak reports + "refcount_t: underflow; use-after-free" at boot when OF_UNITTEST + OF_OVERLAY is set (Kernel v6.6-rc6, PowerMac G5 11,2)

2023-10-30 Thread Rob Herring
On Wed, Oct 18, 2023 at 4:38 PM Erhard Furtner wrote: > > Greetings! > > Getting this at every boot on my G5 with kernel v6.6-rc6 with OF_UNITTEST and > OF_OVERLAY selected: > > [...] > ### dt-test ### EXPECT \ : OF: ERROR: of_node_release() detected bad > of_node_put() on /testcase-data/refcount

Re: [PATCH v4 1/2] ASoC: dt-bindings: sound-card-common: List sound widgets ignoring system suspend

2023-10-26 Thread Rob Herring
On Mon, Oct 23, 2023 at 10:07:17AM +0800, Chancel Liu wrote: > Add a property to list audio sound widgets which are marked ignoring > system suspend. Paths between these endpoints are still active over > suspend of the main application processor that the current operating > system is running. Perh

Re: [PATCH v3 1/2] ASoC: dt-bindings: sound-card-common: List DAPM endpoints ignoring system suspend

2023-10-12 Thread Rob Herring
On Wed, Oct 11, 2023 at 10:21:33PM +0100, Mark Brown wrote: > On Wed, Oct 11, 2023 at 07:47:58PM +0800, Chancel Liu wrote: > > > + lpa-widgets: > > +$ref: /schemas/types.yaml#/definitions/non-unique-string-array > > +description: | > > + A list of DAPM endpoints which mark paths betw

[PATCH] usb: Use device_get_match_data()

2023-10-09 Thread Rob Herring
Use preferred device_get_match_data() instead of of_match_device() to get the driver match data. With this, adjust the includes to explicitly include the correct headers. Signed-off-by: Rob Herring --- drivers/usb/chipidea/ci_hdrc_usb2.c | 11 +-- drivers/usb/dwc2/params.c

[PATCH net-next] net: ethernet: Use device_get_match_data()

2023-10-09 Thread Rob Herring
Use preferred device_get_match_data() instead of of_match_device() to get the driver match data. With this, adjust the includes to explicitly include the correct headers. Signed-off-by: Rob Herring --- drivers/net/ethernet/altera/altera_tse.h | 2 +- drivers/net/ethernet/altera

[PATCH] powerpc: fsl_msi: Use device_get_match_data()

2023-10-06 Thread Rob Herring
Use preferred device_get_match_data() instead of of_match_device() to get the driver match data. With this, adjust the includes to explicitly include the correct headers. Signed-off-by: Rob Herring --- arch/powerpc/sysdev/fsl_msi.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions

[PATCH v3 3/5] ASoC: da7218: Use i2c_get_match_data()

2023-10-06 Thread Rob Herring
Use preferred i2c_get_match_data() instead of of_match_device() and i2c_match_id() to get the driver match data. With this, adjust the includes to explicitly include the correct headers. Avoid using 0 for enum da7218_dev_id so that no match data can be distinguished. Signed-off-by: Rob Herring

[PATCH v3 4/5] ASoC: qcom/lpass: Constify struct lpass_variant

2023-10-06 Thread Rob Herring
'struct lpass_variant' is used for driver match data which is supposed to be constant. It's not modified anywhere, so it's just a matter of adding 'const' everywhere. Signed-off-by: Rob Herring --- sound/soc/qcom/lpass-apq8016.c | 6 +++--- sound/soc/qcom/lpass

[PATCH v3 5/5] ASoC: Use device_get_match_data()

2023-10-06 Thread Rob Herring
Use preferred device_get_match_data() instead of of_match_device() to get the driver match data. With this, adjust the includes to explicitly include the correct headers. Signed-off-by: Rob Herring --- v3: - Move some header changes from patch 1 to here for rockchip_i2s_tdm.c, rockchip_pdm.c

[PATCH v3 2/5] ASoC: Drop unnecessary of_match_device() calls

2023-10-06 Thread Rob Herring
If probe is reached, we've already matched the device and in the case of DT matching, the struct device_node pointer will be set. Therefore, there is no need to call of_match_device() in probe. Acked-by: Charles Keepax Signed-off-by: Rob Herring --- sound/soc/codecs/ak5386.c

[PATCH v3 1/5] ASoC: Explicitly include correct DT includes

2023-10-06 Thread Rob Herring
chino Del Regno Acked-by: Charles Keepax Reviewed-by: Claudiu Beznea # for at91 Signed-off-by: Rob Herring --- v3: - Move some header changes to patch 5 --- sound/soc/atmel/atmel_wm8904.c | 1 - sound/soc/atmel/mchp-i2s-mcc.c | 2 +- sound/s

[PATCH v3 0/5] ASoC: DT matching and header cleanups

2023-10-06 Thread Rob Herring
also generally want to get rid of of_match_device() as well, I've done that so we're not updating the includes twice. Signed-off-by: Rob Herring --- Changes in v3: - Move some include changes from patch #1 to #5 to fix build with just patch #1 applied. - Link to v2: https://lo

Re: [PATCH v2 1/5] ASoC: Explicitly include correct DT includes

2023-10-04 Thread Rob Herring
On Wed, Oct 4, 2023 at 12:39 PM Mark Brown wrote: > > On Wed, Oct 04, 2023 at 10:58:05AM -0500, Rob Herring wrote: > > The DT of_device.h and of_platform.h date back to the separate > > of_platform_bus_type before it was merged into the regular platform bus. > > As part of

[PATCH v2 3/5] ASoC: da7218: Use i2c_get_match_data()

2023-10-04 Thread Rob Herring
Use preferred i2c_get_match_data() instead of of_match_device() and i2c_match_id() to get the driver match data. With this, adjust the includes to explicitly include the correct headers. Avoid using 0 for enum da7218_dev_id so that no match data can be distinguished. Signed-off-by: Rob Herring

[PATCH v2 1/5] ASoC: Explicitly include correct DT includes

2023-10-04 Thread Rob Herring
chino Del Regno Acked-by: Charles Keepax Signed-off-by: Rob Herring --- sound/soc/atmel/atmel_wm8904.c | 1 - sound/soc/atmel/mchp-i2s-mcc.c | 2 +- sound/soc/atmel/tse850-pcm5142.c | 1 - sound/soc/b

[PATCH v2 5/5] ASoC: Use device_get_match_data()

2023-10-04 Thread Rob Herring
Use preferred device_get_match_data() instead of of_match_device() to get the driver match data. With this, adjust the includes to explicitly include the correct headers. Signed-off-by: Rob Herring --- sound/soc/intel/keembay/kmb_platform.c | 13 + sound/soc/qcom/lpass-cpu.c

[PATCH v2 4/5] ASoC: qcom/lpass: Constify struct lpass_variant

2023-10-04 Thread Rob Herring
'struct lpass_variant' is used for driver match data which is supposed to be constant. It's not modified anywhere, so it's just a matter of adding 'const' everywhere. Signed-off-by: Rob Herring --- sound/soc/qcom/lpass-apq8016.c | 6 +++--- sound/soc/qcom/lpass

[PATCH v2 2/5] ASoC: Drop unnecessary of_match_device() calls

2023-10-04 Thread Rob Herring
If probe is reached, we've already matched the device and in the case of DT matching, the struct device_node pointer will be set. Therefore, there is no need to call of_match_device() in probe. Acked-by: Charles Keepax Signed-off-by: Rob Herring --- sound/soc/codecs/ak5386.c

[PATCH v2 0/5] ASoC: DT matching and header cleanups

2023-10-04 Thread Rob Herring
also generally want to get rid of of_match_device() as well, I've done that so we're not updating the includes twice. Signed-off-by: Rob Herring --- Changes in v2: - Add tags - Link to v1: https://lore.kernel.org/r/20231003-dt-asoc-header-cleanups-v1-0-308666806...@kernel.org - Li

[PATCH RESEND 3/5] ASoC: da7218: Use i2c_get_match_data()

2023-10-03 Thread Rob Herring
Use preferred i2c_get_match_data() instead of of_match_device() and i2c_match_id() to get the driver match data. With this, adjust the includes to explicitly include the correct headers. Avoid using 0 for enum da7218_dev_id so that no match data can be distinguished. Signed-off-by: Rob Herring

[PATCH RESEND 5/5] ASoC: Use device_get_match_data()

2023-10-03 Thread Rob Herring
Use preferred device_get_match_data() instead of of_match_device() to get the driver match data. With this, adjust the includes to explicitly include the correct headers. Signed-off-by: Rob Herring --- sound/soc/intel/keembay/kmb_platform.c | 13 + sound/soc/qcom/lpass-cpu.c

[PATCH RESEND 2/5] ASoC: Drop unnecessary of_match_device() calls

2023-10-03 Thread Rob Herring
If probe is reached, we've already matched the device and in the case of DT matching, the struct device_node pointer will be set. Therefore, there is no need to call of_match_device() in probe. Signed-off-by: Rob Herring --- sound/soc/codecs/ak5386.c | 7 ++- sound/soc/codecs/cs4

[PATCH RESEND 4/5] ASoC: qcom/lpass: Constify struct lpass_variant

2023-10-03 Thread Rob Herring
'struct lpass_variant' is used for driver match data which is supposed to be constant. It's not modified anywhere, so it's just a matter of adding 'const' everywhere. Signed-off-by: Rob Herring --- sound/soc/qcom/lpass-apq8016.c | 6 +++--- sound/soc/qcom/lpass

[PATCH RESEND 1/5] ASoC: Explicitly include correct DT includes

2023-10-03 Thread Rob Herring
s a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by: Rob Herring --- sound/soc/atmel

[PATCH RESEND 0/5] ASoC: DT matching and header cleanups

2023-10-03 Thread Rob Herring
implicit includes and generally isn't needed any nore except for of_match_device(). As we also generally want to get rid of of_match_device() as well, I've done that so we're not updating the includes twice. Signed-off-by: Rob Herring --- Rob Herring (5): ASoC: Explicitly inc

[PATCH 1/5] ASoC: Explicitly include correct DT includes

2023-10-03 Thread Rob Herring
s a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by: Rob Herring --- sound/soc/atmel

  1   2   3   4   5   6   7   8   9   10   >