Re: [PATCH 06/11] ASoC: pxa: make snd_soc_platform_driver const
Bhumika Goyal <bhumi...@gmail.com> writes: > Make these const as they are only passed as the 2nd argument to the > function devm_snd_soc_register_platform, which is of type const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> > --- > sound/soc/pxa/mmp-pcm.c| 2 +- > sound/soc/pxa/pxa2xx-pcm.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) For sound/soc/pxa/pxa2xx-pcm.c : Acked-by: Robert Jarzmik <robert.jarz...@free.fr> Cheers. -- Robert
Re: [PATCH] usb: gadget: udc: constify usb_ep_ops structures
Bhumika Goyal <bhumi...@gmail.com> writes: > Declare usb_ep_ops structures as const as they are only stored in the > ops field of an usb_ep structure. This field is of type const, so > usb_ep_ops structures having this property can be made const too. > Done using Coccinelle( A smaller version of the script) For pxa27x_udc.c : Acked-by: Robert Jarzmik <robert.jarz...@free.fr> Cheers. -- Robert
Re: [PATCH] usb: Convert pr_warning to pr_warn
Joe Perches <j...@perches.com> writes: > Use the more common logging mechanism. > > Miscellanea: > > o Realign multiline statements > o Coalesce format > > Signed-off-by: Joe Perches <j...@perches.com> For pxa25x_udc.h: Acked-by: Robert Jarzmik <robert.jarz...@free.fr> Cheers. -- Robert
Re: [PATCH] [media] move media platform data to linux/platform_data/media
Mark Brown <broo...@kernel.org> writes: > On Tue, Nov 17, 2015 at 07:15:59AM -0200, Mauro Carvalho Chehab wrote: >> Now that media has its own subdirectory inside platform_data, >> let's move the headers that are already there to such subdir. > > Acked-by: Mark Brown <broo...@kernel.org> Acked-by: Robert Jarzmik <robert.jarz...@free.fr> Cheers. -- Robert ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 28/37] usb: gadget: pxa27x_udc: add ep capabilities support
Robert Baldyga r.bald...@samsung.com writes: Convert endpoint configuration to new capabilities model. The commit message is very short to judge the patch's correctness. I'll side up with Felipe's opinion. If it's fine by him, so it is by me. Cheers. -- Robert ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [RFC/PATCH 29/32] usb: gadget: pxa27x_udc: let udc-core manage gadget-dev
Felipe Balbi ba...@ti.com writes: By simply setting a flag, we can drop some boilerplate code. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/gadget/pxa27x_udc.c | 9 + Acked-by: Robert Jarzmik robert.jarz...@free.fr And I tested also your patch and it works in my environment. For next patches I'd like to be CCed for pxa27x_udc stuff as I'm maintaining that one since its beginning (and yes, I know, I didn't put that in MAINTAINERS ...). Cheers. -- Robert ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
