Re: [PATCH v2 00/25] iommu: Make default_domain's mandatory

2023-05-18 Thread Steven Price
On 16/05/2023 01:00, Jason Gunthorpe wrote: > This is on github: > https://github.com/jgunthorpe/linux/commits/iommu_all_defdom Tested-by: Steven Price Works fine on my Firefly-RK3288. Thanks, Steve

Re: [PATCH 6/7] KVM: arm64: Change return type of kvm_vm_ioctl_mte_copy_tags() to "int"

2023-02-08 Thread Steven Price
On 08/02/2023 08:49, Cornelia Huck wrote: > On Wed, Feb 08 2023, Gavin Shan wrote: > >> On 2/7/23 9:09 PM, Thomas Huth wrote: >>> Oh, drat, I thought I had checked all return statements ... this must have >>> fallen through the cracks, sorry! >>> >>> Anyway, this is already a problem now: The

Re: [PATCH v5 05/16] swiotlb: Add restricted DMA pool initialization

2021-04-28 Thread Steven Price
On 26/04/2021 17:37, Claire Chang wrote: On Fri, Apr 23, 2021 at 7:34 PM Steven Price wrote: [...] But even then if it's not and we have the situation where debugfs==NULL then the debugfs_create_dir() here will cause a subsequent attempt in swiotlb_create_debugfs() to fail (directory already

Re: [PATCH v5 05/16] swiotlb: Add restricted DMA pool initialization

2021-04-23 Thread Steven Price
On 22/04/2021 09:14, Claire Chang wrote: Add the initialization function to create restricted DMA pools from matching reserved-memory nodes. Signed-off-by: Claire Chang --- include/linux/device.h | 4 +++ include/linux/swiotlb.h | 3 +- kernel/dma/swiotlb.c| 80

Re: [PATCH v2 1/4] mm: pagewalk: Fix walk for hugepage tables

2021-04-19 Thread Steven Price
have a suitable system to test it. Reviewed-by: Steven Price --- v2: - Add a guard for NULL ops->pte_entry - Take mm->page_table_lock when walking hugepage table, as suggested by follow_huge_pd() --- mm/pagewalk.c | 58 ++- 1 file chang

Re: [PATCH v1 3/5] mm: ptdump: Provide page size to notepage()

2021-04-19 Thread Steven Price
On 19/04/2021 14:14, Christophe Leroy wrote: Le 16/04/2021 à 12:51, Steven Price a écrit : On 16/04/2021 11:38, Christophe Leroy wrote: Le 16/04/2021 à 11:28, Steven Price a écrit : On 15/04/2021 18:18, Christophe Leroy wrote: To be honest I don't fully understand why powerpc requires

Re: [PATCH v1 3/5] mm: ptdump: Provide page size to notepage()

2021-04-16 Thread Steven Price
On 16/04/2021 16:15, Christophe Leroy wrote: Le 16/04/2021 à 17:04, Christophe Leroy a écrit : Le 16/04/2021 à 16:40, Christophe Leroy a écrit : Le 16/04/2021 à 15:00, Steven Price a écrit : On 16/04/2021 12:08, Christophe Leroy wrote: Le 16/04/2021 à 12:51, Steven Price a écrit

Re: [PATCH v1 3/5] mm: ptdump: Provide page size to notepage()

2021-04-16 Thread Steven Price
On 16/04/2021 12:08, Christophe Leroy wrote: Le 16/04/2021 à 12:51, Steven Price a écrit : On 16/04/2021 11:38, Christophe Leroy wrote: Le 16/04/2021 à 11:28, Steven Price a écrit : On 15/04/2021 18:18, Christophe Leroy wrote: In order to support large pages on powerpc, notepage() needs

Re: [PATCH v1 3/5] mm: ptdump: Provide page size to notepage()

2021-04-16 Thread Steven Price
On 16/04/2021 11:38, Christophe Leroy wrote: Le 16/04/2021 à 11:28, Steven Price a écrit : On 15/04/2021 18:18, Christophe Leroy wrote: In order to support large pages on powerpc, notepage() needs to know the page size of the page. Add a page_size argument to notepage(). Signed-off

Re: [PATCH v1 3/5] mm: ptdump: Provide page size to notepage()

2021-04-16 Thread Steven Price
On 15/04/2021 18:18, Christophe Leroy wrote: In order to support large pages on powerpc, notepage() needs to know the page size of the page. Add a page_size argument to notepage(). Signed-off-by: Christophe Leroy --- arch/arm64/mm/ptdump.c | 2 +- arch/riscv/mm/ptdump.c |

Re: [PATCH] mm: ptdump: Fix build failure

2021-04-16 Thread Steven Price
/x86 implementations (where this happens to be safe). Fixes: 30d621f6723b ("mm: add generic ptdump") Cc: Steven Price Signed-off-by: Christophe Leroy Reviewed-by: Steven Price Thanks, Steve --- mm/ptdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m

Re: [PATCH V5 1/4] mm/debug_vm_pgtable: Add tests validating arch helpers for core MM features

2020-07-16 Thread Steven Price
On 13/07/2020 04:23, Anshuman Khandual wrote: This adds new tests validating arch page table helpers for these following core memory features. These tests create and test specific mapping types at various page table levels. 1. SPECIAL mapping 2. PROTNONE mapping 3. DEVMAP mapping 4. SOFTDIRTY

Re: [PATCH v17 06/23] powerpc: mm: Add p?d_leaf() definitions

2019-12-20 Thread Steven Price
On 19/12/2019 11:49, Michael Ellerman wrote: > Steven Price writes: >> walk_page_range() is going to be allowed to walk page tables other than >> those of user space. For this it needs to know when it has reached a >> 'leaf' entry in the page tables. This information is

[PATCH v17 06/23] powerpc: mm: Add p?d_leaf() definitions

2019-12-18 Thread Steven Price
them using the new p?d_leaf() name. CC: Benjamin Herrenschmidt CC: Paul Mackerras CC: Michael Ellerman CC: linuxppc-dev@lists.ozlabs.org CC: kvm-...@vger.kernel.org Signed-off-by: Steven Price --- arch/powerpc/include/asm/book3s/64/pgtable.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH v16 06/25] powerpc: mm: Add p?d_leaf() definitions

2019-12-09 Thread Steven Price
On 09/12/2019 11:08, Michael Ellerman wrote: > Steven Price writes: >> walk_page_range() is going to be allowed to walk page tables other than >> those of user space. For this it needs to know when it has reached a >> 'leaf' entry in the page tables. This information is

[PATCH v16 06/25] powerpc: mm: Add p?d_leaf() definitions

2019-12-06 Thread Steven Price
-by: Steven Price --- arch/powerpc/include/asm/book3s/64/pgtable.h | 30 ++-- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h index b01624e5c467..3dd7b6f5edd0 100644 --- a/arch

[PATCH v15 06/23] powerpc: mm: Add p?d_leaf() definitions

2019-11-01 Thread Steven Price
-by: Steven Price --- arch/powerpc/include/asm/book3s/64/pgtable.h | 30 ++-- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h index b01624e5c467..3dd7b6f5edd0 100644 --- a/arch

[PATCH v14 06/22] powerpc: mm: Add p?d_leaf() definitions

2019-10-28 Thread Steven Price
-by: Steven Price --- arch/powerpc/include/asm/book3s/64/pgtable.h | 30 ++-- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h index b01624e5c467..3dd7b6f5edd0 100644 --- a/arch

[PATCH v13 06/22] powerpc: mm: Add p?d_leaf() definitions

2019-10-24 Thread Steven Price
-by: Steven Price --- arch/powerpc/include/asm/book3s/64/pgtable.h | 30 ++-- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h index b01624e5c467..3dd7b6f5edd0 100644 --- a/arch

[PATCH v12 06/22] powerpc: mm: Add p?d_leaf() definitions

2019-10-18 Thread Steven Price
-by: Steven Price --- arch/powerpc/include/asm/book3s/64/pgtable.h | 30 ++-- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h index b01624e5c467..3dd7b6f5edd0 100644 --- a/arch

[PATCH v11 06/22] powerpc: mm: Add p?d_leaf() definitions

2019-10-07 Thread Steven Price
-by: Steven Price --- arch/powerpc/include/asm/book3s/64/pgtable.h | 30 ++-- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h index b01624e5c467..3dd7b6f5edd0 100644 --- a/arch

[PATCH v10 06/22] powerpc: mm: Add p?d_leaf() definitions

2019-07-31 Thread Steven Price
-by: Steven Price --- arch/powerpc/include/asm/book3s/64/pgtable.h | 30 ++-- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h index 8308f32e9782..84270666355c 100644 --- a/arch

[PATCH v9 05/21] powerpc: mm: Add p?d_leaf() definitions

2019-07-22 Thread Steven Price
-by: Steven Price --- arch/powerpc/include/asm/book3s/64/pgtable.h | 30 ++-- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h index 8308f32e9782..84270666355c 100644 --- a/arch

Re: Re: [PATCH 1/3] arm64: mm: Add p?d_large() definitions

2019-07-01 Thread Steven Price
On 01/07/2019 10:27, Will Deacon wrote: > Hi Nick, > > On Sun, Jun 23, 2019 at 07:44:44PM +1000, Nicholas Piggin wrote: >> walk_page_range() is going to be allowed to walk page tables other than >> those of user space. For this it needs to know when it has reached a >> 'leaf' entry in the page

Re: [PATCH v2 1/3] arm64: mm: Add p?d_large() definitions

2019-07-01 Thread Steven Price
ion. > > Cc: Catalin Marinas > Cc: Will Deacon > Signed-off-by: Steven Price Hi Nicolas, This appears to my patch which I originally posted as part of converting x86/arm64 to use a generic page walk code[1]. I'm not sure that this patch makes much sense on its own, in particula

Re: [PATCH v8 05/20] KVM: PPC: Book3S HV: Remove pmd_is_leaf()

2019-05-09 Thread Steven Price
On 29/04/2019 03:05, Paul Mackerras wrote: > On Wed, Apr 03, 2019 at 03:16:12PM +0100, Steven Price wrote: >> Since pmd_large() is now always available, pmd_is_leaf() is redundant. >> Replace all uses with calls to pmd_large(). > > NAK. I don't want to do this, because pm

Re: [PATCH RFC 5/5] arm64/speculation: Add support for 'cpu_spec_mitigations=' cmdline options

2019-04-05 Thread Steven Price
On 04/04/2019 17:44, Josh Poimboeuf wrote: > Configure arm64 runtime CPU speculation bug mitigations in accordance > with the 'cpu_spec_mitigations=' cmdline options. This affects > Meltdown and Speculative Store Bypass. > > The default behavior is unchanged. > > Signed-off-by: Josh Poimboeuf

[PATCH v8 05/20] KVM: PPC: Book3S HV: Remove pmd_is_leaf()

2019-04-03 Thread Steven Price
Since pmd_large() is now always available, pmd_is_leaf() is redundant. Replace all uses with calls to pmd_large(). CC: Benjamin Herrenschmidt CC: Michael Ellerman CC: Paul Mackerras CC: kvm-...@vger.kernel.org CC: linuxppc-dev@lists.ozlabs.org Signed-off-by: Steven Price --- arch/powerpc/kvm

[PATCH v8 04/20] powerpc: mm: Add p?d_large() definitions

2019-04-03 Thread Steven Price
it out of the CONFIG_TRANSPARENT_HUGEPAGE condition and implement the other levels. CC: Benjamin Herrenschmidt CC: Paul Mackerras CC: Michael Ellerman CC: linuxppc-dev@lists.ozlabs.org CC: kvm-...@vger.kernel.org Signed-off-by: Steven Price --- arch/powerpc/include/asm/book3s/64/pgtable.h

[PATCH v7 05/20] KVM: PPC: Book3S HV: Remove pmd_is_leaf()

2019-03-28 Thread Steven Price
Since pmd_large() is now always available, pmd_is_leaf() is redundant. Replace all uses with calls to pmd_large(). CC: Benjamin Herrenschmidt CC: Michael Ellerman CC: Paul Mackerras CC: kvm-...@vger.kernel.org CC: linuxppc-dev@lists.ozlabs.org Signed-off-by: Steven Price --- arch/powerpc/kvm

[PATCH v7 04/20] powerpc: mm: Add p?d_large() definitions

2019-03-28 Thread Steven Price
it out of the CONFIG_TRANSPARENT_HUGEPAGE condition and implement the other levels. CC: Benjamin Herrenschmidt CC: Paul Mackerras CC: Michael Ellerman CC: linuxppc-dev@lists.ozlabs.org CC: kvm-...@vger.kernel.org Signed-off-by: Steven Price --- arch/powerpc/include/asm/book3s/64/pgtable.h

Re: [PATCH v6 04/19] powerpc: mm: Add p?d_large() definitions

2019-03-28 Thread Steven Price
On 26/03/2019 16:58, Christophe Leroy wrote: > > > Le 26/03/2019 à 17:26, Steven Price a écrit : >> walk_page_range() is going to be allowed to walk page tables other than >> those of user space. For this it needs to know when it has reached a >> 'leaf' entry in the pa

[PATCH v6 04/19] powerpc: mm: Add p?d_large() definitions

2019-03-26 Thread Steven Price
-...@vger.kernel.org Signed-off-by: Steven Price --- arch/powerpc/include/asm/book3s/64/pgtable.h | 30 ++-- arch/powerpc/kvm/book3s_64_mmu_radix.c | 12 ++-- 2 files changed, 24 insertions(+), 18 deletions(-) diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch

[PATCH v5 04/19] powerpc: mm: Add p?d_large() definitions

2019-03-21 Thread Steven Price
-...@vger.kernel.org Signed-off-by: Steven Price --- arch/powerpc/include/asm/book3s/64/pgtable.h | 30 ++-- arch/powerpc/kvm/book3s_64_mmu_radix.c | 12 ++-- 2 files changed, 24 insertions(+), 18 deletions(-) diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch

Re: [PATCH v4 04/19] powerpc: mm: Add p?d_large() definitions

2019-03-08 Thread Steven Price
On 08/03/2019 08:37, Mike Rapoport wrote: > On Wed, Mar 06, 2019 at 03:50:16PM +0000, Steven Price wrote: >> walk_page_range() is going to be allowed to walk page tables other than >> those of user space. For this it needs to know when it has reached a >> 'leaf' ent

[PATCH v4 04/19] powerpc: mm: Add p?d_large() definitions

2019-03-06 Thread Steven Price
-...@vger.kernel.org Signed-off-by: Steven Price --- arch/powerpc/include/asm/book3s/64/pgtable.h | 30 ++-- arch/powerpc/kvm/book3s_64_mmu_radix.c | 12 ++-- 2 files changed, 24 insertions(+), 18 deletions(-) diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch

[PATCH v3 16/34] powerpc: mm: Add p?d_large() definitions

2019-02-27 Thread Steven Price
CC: linuxppc-dev@lists.ozlabs.org CC: kvm-...@vger.kernel.org Signed-off-by: Steven Price --- arch/powerpc/include/asm/book3s/32/pgtable.h | 1 + arch/powerpc/include/asm/book3s/64/pgtable.h | 27 --- arch/powerpc/include/asm/nohash/32/pgtable.h | 1 + .../include/asm/nohash/64