Re: [PATCH] Macintosh: fix brace and trailing statement coding style issues in adb-iop.c This is a patch to the adb-iop.c file that cleans up brace and trailing statement warnings found by the checkpa

2010-03-21 Thread fthain
On Tue, Mar 09, 2010 at 01:46:20PM -0800, Michael Beardsworth wrote: ... #ifdef DEBUG_ADB_IOP - printk(adb_iop_listen %p: rcvd packet, %d bytes: %02X %02X, req, - (uint) amsg-count + 2, (uint) amsg-flags, (uint) amsg-cmd); + printk(KERN_WARNING adb_iop_listen %p:

madness, was Re: [PATCH 2/2] Macintosh: fix coding style issues in adb.c This is a patch to the adb.c file that cleans up many warnings found by the checkpatch.pl tool

2010-03-09 Thread fthain
On Tue, 9 Mar 2010, Michael Beardsworth wrote: - /* If a probe is in progress or we are sleeping, wait for it to complete */ + /* If a probe is in progress or we are sleeping, wait until complete */ If you must fix what aint broke, please try not to damage it. I'm sorry if your

ping, was Re: [PATCH 1/2] pmac-zilog: add platform driver, version 3

2010-01-30 Thread fthain
Hi Geert, As I understand it, this patch needs Ben's ack before it (and the others) can be merged into linux-next (?) Finn On Thu, 14 Jan 2010, Geert Uytterhoeven wrote: Thanks, applied. Gr{oetje,eeting}s, Geert

[PATCH 1/2] pmac-zilog: add platform driver, version 2

2010-01-10 Thread fthain
Add platform driver support to the pmac-zilog driver, for m68k macs. Place the powermac-specific code inside #ifdef CONFIG_PPC_PMAC. This patch should be applied after [PATCH 3/13] pmac-zilog: cleanup. Signed-off-by: Finn Thain fth...@telegraphics.com.au --- Version 2 of this patch adopts

Re: [PATCH 1/2] pmac-zilog: add platform driver

2010-01-08 Thread fthain
On Fri, 8 Jan 2010, Geert Uytterhoeven wrote: On Sat, Jan 2, 2010 at 17:39, Finn Thain fth...@telegraphics.com.au wrote: On Sat, 2 Jan 2010, Geert Uytterhoeven wrote: On Tue, Nov 17, 2009 at 10:04, Finn Thain fth...@telegraphics.com.au wrote: BTW, there are a few other minor