Re: [PATCH v5 1/3] powerpc/bitops: Use immediate operand when possible

Hi Michael, Any chance to get this series merged this cycle ? Thanks Christophe Le 21/09/2021 à 17:09, Christophe Leroy a écrit : > Today we get the following code generation for bitops like > set or clear bit: > > c0009fe0: 39 40 08 00 li r10,2048 > c0009fe4:

Re: [PATCH] recordmcount: Support empty section from recent binutils

Le 24/11/2021 à 15:43, Christophe Leroy a écrit : > Looks like recent binutils (2.36 and over ?) may empty some section, > leading to failure like: > > Cannot find symbol for section 11: .text.unlikely. > kernel/kexec_file.o: failed > make[1]: *** [scripts/Makefile.build:287:

Re: [PATCH] powerpc/signal32: Use struct_group() to zero spe regs

Le 18/11/2021 à 21:36, Kees Cook a écrit : > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memset(), avoid intentionally writing across > neighboring fields. > > Add a struct_group() for the spe registers so that memset() can correctly >

Re: [RESEND PATCH v5 0/4] Add perf interface to expose nvdimm

Hi Le 16/11/2021 à 05:49, Kajol Jain a écrit : > Patchset adds performance stats reporting support for nvdimm. > Added interface includes support for pmu register/unregister > functions. A structure is added called nvdimm_pmu to be used for > adding arch/platform specific data such as cpumask,

Re: [PATCH v1 1/1] soc: fsl: Replace kernel.h with the necessary inclusions

Le 29/10/2021 à 17:55, Andy Shevchenko a écrit : > On Wed, Oct 27, 2021 at 06:33:54PM +0300, Andy Shevchenko wrote: >> When kernel.h is used in the headers it adds a lot into dependency hell, >> especially when there are circular dependencies are involved. >> >> Replace kernel.h inclusion with

Re: [PATCH] powerpc/64s: Default to 64K pages for 64 bit book3s

Le 14/10/2021 à 01:31, Joel Stanley a écrit : > For 64-bit book3s the default should be 64K as that's what modern CPUs > are designed for. > > The following defconfigs already set CONFIG_PPC_64K_PAGES: > > cell_defconfig > pasemi_defconfig > powernv_defconfig > ppc64_defconfig >

Re: [PATCH] powerpc: don't select KFENCE on platform PPC_FSL_BOOK3E

Le 12/10/2021 à 03:43, Liu Shixin a écrit : > kindly ping. Hi Based on the discussion we had, this patch is not enough. It should at least also de-activate DEBUG_PAGEALLOC, However I'm looking at fixing it the other way round. Give me one week or two. Christophe > > > On 2021/9/24

Re: [PATCH v2 02/10] powerpc/bpf: Validate branch ranges

Le 05/10/2021 à 22:25, Naveen N. Rao a écrit : > Add checks to ensure that we never emit branch instructions with > truncated branch offsets. > > Acked-by: Song Liu > Acked-by: Johan Almbladh > Tested-by: Johan Almbladh > Suggested-by: Michael Ellerman > Signed-off-by: Naveen N. Rao

Re: [PATCH v4 6/8] bpf ppc64: Access only if addr is kernel address

Le 29/09/2021 à 13:18, Hari Bathini a écrit : > From: Ravi Bangoria > > On PPC64 with KUAP enabled, any kernel code which wants to > access userspace needs to be surrounded by disable-enable KUAP. > But that is not happening for BPF_PROBE_MEM load instruction. > So, when BPF program tries to

Re: [PATCH v2 4/8] powerpc/ppc-opcode: introduce PPC_RAW_BRANCH() macro

Le 17/09/2021 à 17:30, Hari Bathini a écrit : > Define and use PPC_RAW_BRANCH() macro instead of open coding it. This > macro is used while adding BPF_PROBE_MEM support. > > Signed-off-by: Hari Bathini Reviewed-by: Christophe Leroy > --- > > Changes in v2: > * New patch to introduce

RE: [PATCH v3] ftrace: Cleanup ftrace_dyn_arch_init()

> -Message d'origine- > De : Linuxppc-dev bounces+christophe.leroy=csgroup...@lists.ozlabs.org> De la part de Weizhao > Ouyang > > Most of ARCHs use empty ftrace_dyn_arch_init(), introduce a weak common > ftrace_dyn_arch_init() to cleanup them. > > Signed-off-by: Weizhao Ouyang >

Re: [PATCH v3 31/41] powerpc/32: Dismantle EXC_XFER_STD/LITE/TEMPLATE

Le 01/08/2021 à 03:21, Finn Thain a écrit : On Sat, 31 Jul 2021, Christophe Leroy wrote: Stan Johnson contacted me about a regression in mainline that he observed on his G3 Powerbooks. Using 'git bisect' we determined that this patch was the cause of the regression, i.e. commit

Re: [BISECTED] kexec regression on PowerBook G4

Aaro Koskinen a écrit : Hi, On Wed, May 22, 2019 at 07:44:56AM +, Christophe Leroy wrote: On 05/22/2019 06:14 AM, Christophe Leroy wrote: >Le 22/05/2019 à 00:18, Aaro Koskinen a écrit : >>I was trying to upgrade from v5.0 -> v5.1 on PowerBook G4, but when >>trying >>to kexec a kernel the

Re: [PATCH] compiler: allow all arches to enable CONFIG_OPTIMIZE_INLINING

Masahiro Yamada a écrit : Commit 60a3cdd06394 ("x86: add optimized inlining") introduced CONFIG_OPTIMIZE_INLINING, but it has been available only for x86. The idea is obviously arch-agnostic although we need some code fixups. This commit moves the config entry from arch/x86/Kconfig.debug to

Re: [PATCH] compiler: allow all arches to enable CONFIG_OPTIMIZE_INLINING

Arnd Bergmann a écrit : On Wed, Mar 20, 2019 at 10:41 AM Arnd Bergmann wrote: I've added your patch to my randconfig test setup and will let you know if I see anything noticeable. I'm currently testing clang-arm32, clang-arm64 and gcc-x86. This is the only additional bug that has come up

Re: powerpc32 boot crash in 5.1-rc1

Meelis Roos a écrit : While 5.0.0 worked fine on my PowerMac G4, 5.0 + git (unknown rev as of Mar 13), 5.0.0-11520-gf261c4e and todays git all fail to boot. The problem seems to be in page fault handler in load_elf_binary() of init process. The patch at

Re: powerpc32 boot crash in 5.1-rc1

Meelis Roos a écrit : While 5.0.0 worked fine on my PowerMac G4, 5.0 + git (unknown rev as of Mar 13), 5.0.0-11520-gf261c4e and todays git all fail to boot. The problem seems to be in page fault handler in load_elf_binary() of init process. The patch at

Re: [PATCH v13 00/10] powerpc: Switch to CONFIG_THREAD_INFO_IN_TASK

Michael Ellerman a écrit : Christophe Leroy writes: The purpose of this serie is to activate CONFIG_THREAD_INFO_IN_TASK which moves the thread_info into task_struct. Moving thread_info into task_struct has the following advantages: - It protects thread_info from corruption in the case of

Re: [PATCH] Remove 'type' argument from access_ok() function

Mathieu Malaterre a écrit : In commit 05a4ab823983 ("powerpc/uaccess: fix warning/error with access_ok()") an attempt was made to remove a warning by referencing the variable `type`, however in commit 96d4f267e40f ("Remove 'type' argument from access_ok() function") the variable `type` has

Re: [PATCH v3 1/2] selftests/powerpc: Add MSR bits

Breno Leitao a écrit : This patch simply adds definitions for the MSR bits and some macros to test for MSR TM bits. This was copied from arch/powerpc/include/asm/reg.h generic MSR part. Can't we find a way to avoid duplicating such defines ? Christophe Signed-off-by: Breno Leitao ---

Re: [PATCH v5] soc/fsl/qe: fix err handling of ucc_of_parse_tdm

Peng Hao a écrit : From: Wen Yang Currently there are some issues with the ucc_of_parse_tdm function: 1, a possible null pointer dereference in ucc_of_parse_tdm, detected by the semantic patch deref_null.cocci, with the following warning: drivers/soc/fsl/qe/qe_tdm.c:177:21-24: ERROR: pdev is

Re: [PATCH 1/2] powerpc/4xx/ocm: Fix phys_addr_t printf warnings

Michael Ellerman a écrit : Currently the code produces several warnings, eg: arch/powerpc/platforms/4xx/ocm.c:240:38: error: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'phys_addr_t {aka unsigned int}' seq_printf(m, "PhysAddr :

Re: [PATCH v8 13/25] m68k: Dispatch nvram_ops calls to Atari or Mac functions

Finn Thain a écrit : On Sat, 29 Dec 2018, Arnd Bergmann wrote: On Wed, Dec 26, 2018 at 1:43 AM Finn Thain wrote: > + > +static ssize_t m68k_nvram_get_size(void) > +{ > + if (MACH_IS_ATARI) > + return atari_nvram_get_size(); > + else if (MACH_IS_MAC) > +

Re: [PATCH v8 01/25] scsi/atari_scsi: Don't select CONFIG_NVRAM

Arnd Bergmann a écrit : On Sat, Dec 29, 2018 at 3:51 AM Michael Schmitz wrote: Hi Finn, Am 29.12.2018 um 15:34 schrieb Finn Thain: > On Sat, 29 Dec 2018, Michael Schmitz wrote: > >> >> IS_BUILTIN(CONFIG_NVRAM) is probably what Christophe really meant to suggest. >> >> Or (really going

Re: [PATCH v8 20/25] powerpc, fbdev: Use arch_nvram_ops methods instead of nvram_read_byte() and nvram_write_byte()

Finn Thain a écrit : Make use of arch_nvram_ops in device drivers so that the nvram_* function exports can be removed. Since they are no longer global symbols, rename the PPC32 nvram_* functions appropriately. Signed-off-by: Finn Thain --- arch/powerpc/kernel/setup_32.c | 8

Re: [PATCH v8 01/25] scsi/atari_scsi: Don't select CONFIG_NVRAM

Michael Schmitz a écrit : Hi Finn, Am 29.12.2018 um 14:06 schrieb Finn Thain: On Fri, 28 Dec 2018, LEROY Christophe wrote: diff --git a/drivers/scsi/atari_scsi.c b/drivers/scsi/atari_scsi.c index 89f5154c40b6..99e5729d910d 100644 --- a/drivers/scsi/atari_scsi.c +++ b/drivers/scsi

Re: [PATCH v8 02/25] m68k/atari: Move Atari-specific code out of drivers/char/nvram.c

Finn Thain a écrit : Move the m68k-specific code out of the driver to make the driver generic. I've used 'SPDX-License-Identifier: GPL-2.0+' for the new file because the old file is covered by MODULE_LICENSE("GPL"). Signed-off-by: Finn Thain Tested-by: Christian T. Steigies Acked-by: Geert

Re: [PATCH v8 01/25] scsi/atari_scsi: Don't select CONFIG_NVRAM

Finn Thain a écrit : On powerpc, setting CONFIG_NVRAM=n builds a kernel with no NVRAM support. Setting CONFIG_NVRAM=m enables the /dev/nvram misc device module without enabling NVRAM support in drivers. Setting CONFIG_NVRAM=y enables the misc device (built-in) and also enables NVRAM support in

Re: [PATCH 5/5] powerpc/64s: Document that PPC supports nosmap

Russell Currey a écrit : On Fri, 2018-10-26 at 18:35 +0200, LEROY Christophe wrote: Why not call our new functionnality SMAP instead of calling it GUAP ? mpe wasn't a fan of using the same terminology as other architectures. I don't like too much the word 'guarded' because it means

Re: [PATCH 0/5] Guarded Userspace Access Prevention on Radix

Russell Currey a écrit : On Fri, 2018-10-26 at 18:29 +0200, LEROY Christophe wrote: Russell Currey a écrit : > Guarded Userspace Access Prevention is a security mechanism that > prevents > the kernel from being able to read and write userspace addresses > outside of > th

Re: [PATCH 1/5] powerpc/64s: Guarded Userspace Access Prevention

Russell Currey a écrit : On Sun, 2018-10-28 at 18:57 +0100, LEROY Christophe wrote: Russell Currey a écrit : > Guarded Userspace Access Prevention (GUAP) utilises a feature of > the Radix MMU which disallows read and write access to userspace > addresses. By utilising this, t

Re: NXP P50XX/e5500: SMP doesn't work anymore with the latest Git kernel

Christian Zigotzky a écrit : Hello, I figured out that the problem is in the OF source code of the commit: Merge tag devicetree-for-4.20. [1] That's a merge commit. Can you bisect the branch and identify the faulting commit ? Christophe I reverted the following OF files and SMP

Re: [PATCH 1/5] powerpc/64s: Guarded Userspace Access Prevention

Russell Currey a écrit : Guarded Userspace Access Prevention (GUAP) utilises a feature of the Radix MMU which disallows read and write access to userspace addresses. By utilising this, the kernel is prevented from accessing user data from outside of trusted paths that perform proper safety

Re: [PATCH 5/5] powerpc/64s: Document that PPC supports nosmap

Why not call our new functionnality SMAP instead of calling it GUAP ? Christophe Russell Currey a écrit : Signed-off-by: Russell Currey --- Documentation/admin-guide/kernel-parameters.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 3/5] powerpc/lib: checksum GUAP support

Same comment as for futex Christophe Russell Currey a écrit : Wrap the checksumming code in GUAP locks and unlocks. Signed-off-by: Russell Currey --- arch/powerpc/lib/checksum_wrappers.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/powerpc/lib/checksum_wrappers.c

Re: [PATCH 2/5] powerpc/futex: GUAP support for futex ops

Russell Currey a écrit : Wrap the futex operations in GUAP locks and unlocks. Does it means futex doesn't work anymore once only patch 1 is applied ? If so, then you should split patch 1 in two parts and reorder patches so that guap can only be activated once all necessary changes are

Re: [PATCH 0/5] Guarded Userspace Access Prevention on Radix

Russell Currey a écrit : Guarded Userspace Access Prevention is a security mechanism that prevents the kernel from being able to read and write userspace addresses outside of the allowed paths, most commonly copy_{to/from}_user(). At present, the only CPU that supports this is POWER9, and

Re: [PATCH 3/9] powerpc/mm: Remove extern from function definition

Breno Leitao a écrit : hi Christophe, On 10/23/2018 12:38 PM, LEROY Christophe wrote: Breno Leitao a écrit : This patch removes the keyword from the definition part, while keeps it in the declaration part. I think checkpatch also says that extern should be avoided in declarations

Re: [PATCH 3/9] powerpc/mm: Remove extern from function definition

Breno Leitao a écrit : Function huge_ptep_set_access_flags() has the 'extern' keyword in the function definition and also in the function declaration. This causes a warning in 'sparse' since the 'extern' storage class should be used only on symbol declarations.

Re: [PATCH v3 06/24] powerpc/mm: properly set PAGE_KERNEL flags in ioremap()

LEROY Christophe a écrit : Michael Ellerman a écrit : Christophe Leroy writes: Set PAGE_KERNEL directly in the caller and do not rely on a hack adding PAGE_KERNEL flags when _PAGE_PRESENT is not set. As already done for PPC64, use pgprot_cache() helpers instead of _PAGE_XXX flags

Re: [PATCH v3 06/24] powerpc/mm: properly set PAGE_KERNEL flags in ioremap()

Michael Ellerman a écrit : Michael Ellerman writes: Christophe Leroy writes: Set PAGE_KERNEL directly in the caller and do not rely on a hack adding PAGE_KERNEL flags when _PAGE_PRESENT is not set. As already done for PPC64, use pgprot_cache() helpers instead of _PAGE_XXX flags in PPC32

Re: [PATCH v3 06/24] powerpc/mm: properly set PAGE_KERNEL flags in ioremap()

Michael Ellerman a écrit : Christophe Leroy writes: Set PAGE_KERNEL directly in the caller and do not rely on a hack adding PAGE_KERNEL flags when _PAGE_PRESENT is not set. As already done for PPC64, use pgprot_cache() helpers instead of _PAGE_XXX flags in PPC32 ioremap() derived

Re: [PATCH net] powerpc: use big endian to hash len and proto in csum_ipv6_magic

Xin Long a écrit : The function csum_ipv6_magic doesn't convert len and proto to big endian before doing ipv6 csum hash, which is not consistent with RFC and other arches. Jianlin found it when ICMPv6 packets from other hosts were dropped in the powerpc64 system. This patch is to fix it by

Re: [PATCH v2] powerpc/tm: Print 64-bits MSR

Breno Leitao a écrit : Hi, On 08/07/2018 02:15 PM, Christophe LEROY wrote: Le 07/08/2018 à 15:35, Breno Leitao a écrit : On a kernel TM Bad thing program exception, the Machine State Register (MSR) is not being properly displayed. The exception code dumps a 32-bits value but MSR is a 64

Re: [PATCH v2 04/10] powerpc/traps: Use REG_FMT in show_signal_msg()

Murilo Opsfelder Araujo a écrit : Hi, Christophe. On Fri, Jul 27, 2018 at 06:40:23PM +0200, LEROY Christophe wrote: Murilo Opsfelder Araujo a écrit : > Simplify the message format by using REG_FMT as the register format. This > avoids having two different formats and avoids ch

Re: [PATCH v2 04/10] powerpc/traps: Use REG_FMT in show_signal_msg()

Murilo Opsfelder Araujo a écrit : Simplify the message format by using REG_FMT as the register format. This avoids having two different formats and avoids checking for MSR_64BIT. Are you sure it is what we want ? Won't it change the behaviour for a 32 bits app running on a 64bits kernel ?

Re: [PATCH v4 00/11] hugetlb: Factorize hugetlb architecture primitives

Alex Ghiti a écrit : Hi everyone, This is the result of the build for all arches tackled in this series rebased on 4.18-rc6: arm:     versatile_defconfig: without huge page OK     keystone_defconfig: with huge page OK arm64:     defconfig: with huge page OK ia64:    

Re: [PATCH 7/7] powerpc/traps: Show instructions on exceptions

Murilo Opsfelder Araujo a écrit : Move show_instructions() declaration to arch/powerpc/include/asm/stacktrace.h and include asm/stracktrace.h in arch/powerpc/kernel/process.c, which contains the implementation. Modify show_instructions() not to call __kernel_text_address(), allowing

Re: [PATCH 6/7] powerpc/traps: Print signal name for unhandled signals

Murilo Opsfelder Araujo a écrit : This adds a human-readable name in the unhandled signal message. Before this patch, a page fault looked like: Jul 11 16:04:11 localhost kernel: pandafault[6303]: unhandled signal 11 at 17d0 nip 161c lr 7fff93c55100 code 2

Re: [PATCH 2/7] powerpc/traps: Return early in show_signal_msg()

Murilo Opsfelder Araujo a écrit : Modify logic of show_signal_msg() to return early, if possible. Replace printk_ratelimited() by printk() and a default rate limit burst to limit displaying unhandled signals messages. Can you explain more the benefits of this change ? Christophe

Re: [PATCH v4 4/6] powerpc/fsl: Enable cpu vulnerabilities reporting for NXP PPC BOOK3E

Diana Madalina Craciun a écrit : On 7/17/2018 7:47 PM, LEROY Christophe wrote: Diana Craciun a écrit : The NXP PPC Book3E platforms are not vulnerable to meltdown and Spectre v4, so make them PPC_BOOK3S_64 specific. Signed-off-by: Diana Craciun --- History: v2-->v3 - used the exist

Re: [PATCH v4 4/6] powerpc/fsl: Enable cpu vulnerabilities reporting for NXP PPC BOOK3E

Diana Craciun a écrit : The NXP PPC Book3E platforms are not vulnerable to meltdown and Spectre v4, so make them PPC_BOOK3S_64 specific. Signed-off-by: Diana Craciun --- History: v2-->v3 - used the existing functions for spectre v1/v2 arch/powerpc/Kconfig | 7 ++-

Re: [PATCH v4 0/6] powerpc/fsl: Speculation barrier for NXP PowerPC Book3E

Diana Craciun a écrit : Implement barrier_nospec for NXP PowerPC Book3E processors. Diana Craciun (6): Disable the speculation barrier from the command line Document nospectre_v1 kernel parameter. Make stf barrier PPC_BOOK3S_64 specific. Enable cpu vulnerabilities reporting for NXP

Re: OOM killer invoked while still one forth of mem is available

Michal Hocko a écrit : On Thu 26-04-18 15:28:46, Christophe LEROY wrote: Le 26/04/2018 à 15:11, Michal Hocko a écrit : > On Thu 26-04-18 08:10:30, Christophe LEROY wrote: > > > > > > Le 25/04/2018 à 21:57, David Rientjes a écrit : > > > On Tue, 24 Apr 2018, christophe

Re: [PATCH v4 03/19] powerpc: Mark variable `l` as unused, remove `path`

Mathieu Malaterre a écrit : Add gcc attribute unused for `l` variable, replace `path` variable directly with prom_scratch. Fix warnings treated as errors with W=1: arch/powerpc/kernel/prom_init.c:607:6: error: variable ‘l’ set but not used

Re: [PATCH v2 03/19] powerpc: Mark variables as unused

Michael Ellerman <m...@ellerman.id.au> a écrit : LEROY Christophe <christophe.le...@c-s.fr> writes: Mathieu Malaterre <ma...@debian.org> a écrit : Add gcc attribute unused for two variables. Fix warnings treated as errors with W=1: arch/powerpc/kernel/prom_init.c:1388:

Re: [PATCH] powerpc/mm/hash: Move the slb_addr_limit check within PPC_MM_SLICES

Michael Ellerman a écrit : "Aneesh Kumar K.V" writes: Should not have any impact, because we always select PP_MM_SLICES these days. Nevertheless it is good to indicate that slb_addr_limit is available only with slice code. That file

Re: [PATCH v2 04/19] powerpc/kvm: Prefer fault_in_pages_readable function

Mathieu Malaterre a écrit : Directly use fault_in_pages_readable instead of manual __get_user code. Fix warning treated as error with W=1: arch/powerpc/kernel/kvm.c:675:6: error: variable ‘tmp’ set but not used [-Werror=unused-but-set-variable] Suggested-by: Christophe

Re: [PATCH v2 05/19] powerpc/chrp/setup: Add attribute unused and make some functions static

The subject of the patch should be updated as well Christophe Mathieu Malaterre a écrit : Remove variable declaration idu_size and associated code since not used. These functions can all be static, make it so. Fix warnings treated as errors with W=1:

Re: [PATCH v2 03/19] powerpc: Mark variables as unused

Mathieu Malaterre a écrit : Add gcc attribute unused for two variables. Fix warnings treated as errors with W=1: arch/powerpc/kernel/prom_init.c:1388:8: error: variable ‘path’ set but not used [-Werror=unused-but-set-variable] Suggested-by: Christophe Leroy

Re: [PATCH v2 02/19] powerpc/powermac: Mark variable x as unused

Mathieu Malaterre a écrit : Since the value of x is never intended to be read, remove it. Fix warning treated as error with W=1: arch/powerpc/platforms/powermac/udbg_scc.c:76:9: error: variable ‘x’ set but not used [-Werror=unused-but-set-variable] Suggested-by:

Re: [PATCH v2 01/19] powerpc/powermac: Mark variable x as unused

Mathieu Malaterre a écrit : Since the value of x is never intended to be read, declare it with gcc attribute as unused. Fix warning treated as error with W=1: arch/powerpc/platforms/powermac/bootx_init.c:471:21: error: variable ‘x’ set but not used

Re: [PATCH 15/19] powerpc: Add missing prototype

Mathieu Malaterre a écrit : On Fri, Mar 23, 2018 at 1:20 PM, christophe leroy wrote: Le 22/03/2018 à 21:20, Mathieu Malaterre a écrit : Add one missing prototype for function rh_dump_blk. Fix warning treated as error in W=1:

Re: [PATCH 11/19] powerpc/powermac: Move pmac_pfunc_base_install prototype to header file

Mathieu Malaterre a écrit : On Fri, Mar 23, 2018 at 1:13 PM, christophe leroy wrote: Le 22/03/2018 à 21:19, Mathieu Malaterre a écrit : The pmac_pfunc_base_install prototype was declared in powermac/smp.c since function was used there, move it

Re: [PATCH] powerpc/64: Fix checksum folding in csum_add

Paul Mackerras <pau...@ozlabs.org> a écrit : On Tue, Mar 27, 2018 at 05:22:32PM +0200, LEROY Christophe wrote: Shile Zhang <shile.zh...@nokia.com> a écrit : >fix the missed point in Paul's patch: >"powerpc/64: Fix checksum folding in csum_tcpudp_nofold and >ip_fast_

Re: [PATCH 14/19] powerpc/altivec: Add missing prototypes for altivec

LEROY Christophe <christophe.le...@c-s.fr> a écrit : Mathieu Malaterre <ma...@debian.org> a écrit : Christophe, On Sat, Mar 24, 2018 at 9:10 PM, LEROY Christophe <christophe.le...@c-s.fr> wrote: Mathieu Malaterre <ma...@debian.org> a écrit : On Fri, Mar 23, 201

Re: [PATCH 14/19] powerpc/altivec: Add missing prototypes for altivec

Mathieu Malaterre <ma...@debian.org> a écrit : Christophe, On Sat, Mar 24, 2018 at 9:10 PM, LEROY Christophe <christophe.le...@c-s.fr> wrote: Mathieu Malaterre <ma...@debian.org> a écrit : On Fri, Mar 23, 2018 at 1:19 PM, christophe leroy <christophe.le...@c-s.fr>

Re: [PATCH] powerpc/64: Fix checksum folding in csum_add

Shile Zhang a écrit : fix the missed point in Paul's patch: "powerpc/64: Fix checksum folding in csum_tcpudp_nofold and ip_fast_csum_nofold" Signed-off-by: Shile Zhang --- arch/powerpc/include/asm/checksum.h | 2 +- 1 file changed, 1

Re: [PATCH 01/16] initrd: Add generic code path for common initrd unloading logic.

Shea Levy a écrit : Signed-off-by: Shea Levy --- init/initramfs.c | 7 +++ usr/Kconfig | 4 2 files changed, 11 insertions(+) diff --git a/init/initramfs.c b/init/initramfs.c index 7e99a0038942..de5ce873eb5a 100644 --- a/init/initramfs.c

Re: [PATCH 14/19] powerpc/altivec: Add missing prototypes for altivec

Mathieu Malaterre a écrit : On Fri, Mar 23, 2018 at 1:19 PM, christophe leroy wrote: Le 22/03/2018 à 21:20, Mathieu Malaterre a écrit : Some functions prototypes were missing for the non-altivec code. Add the missing prototypes directly in

Re: STRICT_KERNEL_RWX on PPC32 is broken on PowerMac G4

Meelis Roos a écrit : > > How early does it hang ? Any oops or trace ? > > Very early - instead oif kernel emssages, I see some repeated gibberish > of some characteers, and the background turns white. > I am booting from yaboot, background is normally black. Ok, could you try

Re: STRICT_KERNEL_RWX on PPC32 is broken on PowerMac G4

Meelis Roos a écrit : Meelis Roos a écrit : > > > For me, 4.13 worked and 4.14 hangs early during boot. Bisecting led to > > > the following commit. I had STRICT_KERNEL_RWX enabled when I met the > > > option. When I disabled STRICT_KERNEL_RWX, the same kernel

Re: STRICT_KERNEL_RWX on PPC32 is broken on PowerMac G4

Meelis Roos a écrit : > For me, 4.13 worked and 4.14 hangs early during boot. Bisecting led to > the following commit. I had STRICT_KERNEL_RWX enabled when I met the > option. When I disabled STRICT_KERNEL_RWX, the same kernel booted fine. Can you please check that 4.13 boots

Re: STRICT_KERNEL_RWX on PPC32 is broken on PowerMac G4

Meelis Roos a écrit : For me, 4.13 worked and 4.14 hangs early during boot. Bisecting led to the following commit. I had STRICT_KERNEL_RWX enabled when I met the option. When I disabled STRICT_KERNEL_RWX, the same kernel booted fine. Can you please check that 4.13 boots

Re: [PATCH 23/24] powerpc/mm: Cleanup check for stack expansion

Michael Ellerman <m...@ellerman.id.au> a écrit : LEROY Christophe <christophe.le...@c-s.fr> writes: Benjamin Herrenschmidt <b...@kernel.crashing.org> a écrit : When hitting below a VM_GROWSDOWN vma (typically growing the stack), we check whether it's a valid stack-growing

Re: [PATCH 02/24] powerpc/mm: Pre-filter SRR1 bits before do_page_fault()

Benjamin Herrenschmidt a écrit : By filtering the relevant SRR1 bits in the assembly rather than in do_page_fault() itself, we avoid a conditional branch (since we already come from different path for data and instruction faults). This will allow more simplifications

Re: [PATCH 07/24] powerpc/mm: Move out definition of CPU specific is_write bits

Benjamin Herrenschmidt a écrit : Define a common page_fault_is_write() helper and use it Signed-off-by: Benjamin Herrenschmidt --- arch/powerpc/mm/fault.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff

Re: [PATCH 23/24] powerpc/mm: Cleanup check for stack expansion

Benjamin Herrenschmidt a écrit : When hitting below a VM_GROWSDOWN vma (typically growing the stack), we check whether it's a valid stack-growing instruction and we check the distance to GPR1. This is largely open coded with lots of comments, so move it out to a

Re: [RFC 0/2] Consolidate patch_instruction

Balbir Singh <bsinghar...@gmail.com> a écrit : On Tue, 2017-05-16 at 22:20 +0200, LEROY Christophe wrote: Balbir Singh <bsinghar...@gmail.com> a écrit : > patch_instruction is enhanced in this RFC to support > patching via a different virtual address (text_poke_ar

Re: [RFC 0/2] Consolidate patch_instruction

Balbir Singh a écrit : patch_instruction is enhanced in this RFC to support patching via a different virtual address (text_poke_area). The mapping of text_poke_area->addr is RW and not RWX. This way the mapping allows write for patching and then we tear down the mapping.

Re: [PATCH V3] powerpc/hugetlb: Add ABI defines for supported HugeTLB page sizes

Hi Anshuman Khandual a écrit : This just adds user space exported ABI definitions for 2MB, 16MB, 1GB, 16GB non default huge page sizes to be used with mmap() system call. Why not add all possible huge page sizes ? For instance the 8xx (only) supports 512k and 8M

Re: [PATCH] powerpc: Avoid taking a data miss on every userspace instruction miss

Anton Blanchard a écrit : From: Anton Blanchard Early on in do_page_fault() we call store_updates_sp(), regardless of the type of exception. For an instruction miss this doesn't make sense, because we only use this information to detect if a data miss is

_PAGE_PRESENT and _PAGE_ACCESSED

In ppc8xx tlbmiss handler, we consider a page valid if both _PAGE_PRESENT and _PAGE_ACCESSED are set. Is there any chance to have _PAGE_ACCESSED set and not _PAGE_PRESENT ? Otherwise we could simplify the handler by considering the page valid only when _PAGE_ACCESSED is set Christophe

Strange reports of perf events on powerpc 83xx

Hi, Has anybody already used 'perf' tool on powerpc MPC83xx ? I have been succesfully using perf on MPC8xx, but on MPC83xx I get something strange. perf record/report reports addresses on user stack, as if it was mixing up D accesses and I accesses. Any idea of what the problem can be ?

Re: [PATCH v2 2/2] powerpc32: optimise csum_partial() loop

Le 17/08/2015 12:56, leroy christophe a écrit : Le 07/08/2015 01:25, Segher Boessenkool a écrit : On Thu, Aug 06, 2015 at 05:45:45PM -0500, Scott Wood wrote: If this makes performance non-negligibly worse on other 32-bit chips, and is an important improvement on 8xx, then we can use

Re: [PATCH v2 2/2] powerpc32: optimise csum_partial() loop

Le 07/08/2015 01:25, Segher Boessenkool a écrit : On Thu, Aug 06, 2015 at 05:45:45PM -0500, Scott Wood wrote: If this makes performance non-negligibly worse on other 32-bit chips, and is an important improvement on 8xx, then we can use an ifdef since 8xx already requires its own kernel build.

Re: [PATCH v2 2/2] powerpc32: optimise csum_partial() loop

Le 17/08/2015 13:00, leroy christophe a écrit : Le 17/08/2015 12:56, leroy christophe a écrit : Le 07/08/2015 01:25, Segher Boessenkool a écrit : On Thu, Aug 06, 2015 at 05:45:45PM -0500, Scott Wood wrote: If this makes performance non-negligibly worse on other 32-bit chips

Re: Missing Linux patches

Le 02/08/2015 21:05, Markus Stockhausen a écrit : Hi Christophe, I saw that this patch from you is still missing in Linux mainline: https://lists.ozlabs.org/pipermail/linuxppc-dev/2014-September/121144.html Is there any reason for not using it? Markus Hi, I sent v3 of that Patch on 19 May

Re: [HELP/RFC] Moving ppc8xx microcode patch from micropatch.c to firmware

Le 30/06/2015 22:38, christophe leroy a écrit : I'm trying to move the 3 microcode patches included in arch/powerpc/sysdev/micropatch.c into the firmware directory in order to use request_firmware() and then be able to add additional micropatch that I need to relocate SMC2 on my MPC885. I've

Oops in 3.18.14 in destroy_inode()

[46796.501487] Unable to handle kernel paging request for data at address 0x02dd [46796.514365] Faulting instruction address: 0xc00c5978 [46796.524217] Oops: Kernel access of bad area, sig: 11 [#1] [46796.529351] PREEMPT CMPC885 [46796.532144] CPU: 0 PID: 1107 Comm: snmpd Not tainted 3.18.14

Re: [BUG] mpc8323_rdb platform doesn't boot since kernel 3.16

Le 10/06/2015 20:17, Rob Herring a écrit : On Wed, Jun 10, 2015 at 10:12 AM, leroy christophe christophe.le...@c-s.fr wrote: Le 06/06/2015 17:32, Rob Herring a écrit : On Sat, Jun 6, 2015 at 6:20 AM, christophe leroy christophe.le...@c-s.fr wrote: I've got a MPC8323 RDB evaluation platform

Re: [BUG] mpc8323_rdb platform doesn't boot since kernel 3.16

Le 06/06/2015 17:32, Rob Herring a écrit : On Sat, Jun 6, 2015 at 6:20 AM, christophe leroy christophe.le...@c-s.fr wrote: I've got a MPC8323 RDB evaluation platform from freescale kernel 4.0 doesn't boot kernel 3.16 doesn't boot kernel 3.15 boots ok I disected the issue down to your commit

Re: [v2,2/2] powerpc32: add support for csum_add()

Le 05/05/2015 00:10, Segher Boessenkool a écrit : On Fri, May 01, 2015 at 08:00:14PM -0500, Scott Wood wrote: On Tue, 2015-04-28 at 21:01 +0200, christophe leroy wrote: The generated code is most likely different on ppc64. I have no ppc64 compiler For reference: yes you do. Just add -m64.

Re: [PATCH 07/11] powerpc/8xx: macro for handling CPU15 errata

Le 20/04/2015 13:40, David Laight a écrit : From: Christophe Leroy Sent: 20 April 2015 06:27 Having a macro will help keep clear code. ... * We have to use the MD_xxx registers for the tablewalk because the * equivalent MI_xxx registers only perform the attribute functions. */ +

Re: [PATCH 00/11] powerpc8xx: Further optimisation of TLB handling

Le 20/04/2015 07:26, Christophe Leroy a écrit : This patchset provides a further optimisation of TLB handling in the 8xx. Main changes are based on: - Using processor handling of PGD/PTE Validity bits instead of testing ourselves the entries validity - Aligning PGD address to allow direct bit

Re: [PATCH v3 00/17] crypto: talitos - Add support for SEC1

Oops, this is the first time I use directly the output of git format-patch into sendmail, and it looks like the mails are dated with the commit date, not today's date. I will resend now with today's date. Sorry for the noise. Christophe Le 17/04/2015 15:47, Christophe Leroy a écrit : The

Re: [PATCH v3 03/17] crypto: talitos - talitos_ptr renamed ptr for more lisibility

Le 17/04/2015 17:14, David Laight a écrit : From: Christophe Leroy Linux CodyingStyle recommends to use short variables for local variables. ptr is just good enough for those 3 lines functions. It helps keep single lines shorter than 80 characters. ... -static void to_talitos_ptr(struct

Re: [v3, 01/11] powerpc/8xx: remove remaining unnecessary code in FixupDAR

Le 13/04/2015 22:26, Scott Wood a écrit : On Sun, 2015-04-12 at 18:16 +0200, leroy christophe wrote: Le 26/03/2015 22:32, Scott Wood a écrit : On Tue, Feb 03, 2015 at 12:38:16PM +0100, LEROY Christophe wrote: Since commit 33fb845a6f01 (powerpc/8xx: Don't use MD_TWC for walk), MD_EPN

Re: [v3, 01/11] powerpc/8xx: remove remaining unnecessary code in FixupDAR

Le 26/03/2015 22:32, Scott Wood a écrit : On Tue, Feb 03, 2015 at 12:38:16PM +0100, LEROY Christophe wrote: Since commit 33fb845a6f01 (powerpc/8xx: Don't use MD_TWC for walk), MD_EPN and MD_TWC are not writen anymore in FixupDAR so saving r3 has become useless. Signed-off-by: Christophe

Re: powerpc32: fix warning from include/linux/mm.h

Le 21/03/2015 00:52, Scott Wood a écrit : On Fri, Dec 05, 2014 at 12:20:20PM +0100, LEROY Christophe wrote: include/linux/mm.h: In function 'is_vmalloc_addr': include/linux/mm.h:367:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] return addr

  1   2   >