Re: [PATCH 2/2] powerpc: make 'boot_text_mapped' static

2021-04-08 Thread yukuai (C)
On 2021/04/08 13:04, Christophe Leroy wrote: Le 08/04/2021 à 03:18, Yu Kuai a écrit : The sparse tool complains as follow: arch/powerpc/kernel/btext.c:48:5: warning:   symbol 'boot_text_mapped' was not declared. Should it be static? This symbol is not used outside of btext.c, so this commit

Re: [PATCH 1/2] powerpc: remove set but not used variable 'force_printk_to_btext'

2021-04-08 Thread yukuai (C)
On 2021/04/08 13:01, Christophe Leroy wrote: Le 08/04/2021 à 03:18, Yu Kuai a écrit : Fixes gcc '-Wunused-but-set-variable' warning: arch/powerpc/kernel/btext.c:49:12: error: 'force_printk_to_btext' defined but not used. You don't get this error as it is now. You will get this error only if

Re: [PATCH] powerpc: Make some symbols static

2021-04-07 Thread yukuai (C)
On 2021/04/08 0:57, kernel test robot wrote: Hi Yu, Thank you for the patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v5.12-rc6 next-20210407] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH 1/2] ASoC: fsl: imx-es8328: add missing kfree() call in imx_es8328_probe()

2020-08-25 Thread yukuai (C)
On 2020/08/25 20:11, Mark Brown wrote: On Tue, Aug 25, 2020 at 08:05:30PM +0800, Yu Kuai wrote: If memory allocation for 'data' or 'comp' succeed, imx_es8328_probe() doesn't have corresponding kfree() in exception handling. Thus add kfree() for this function implementation. @@ -151,7 +151,7