Re: [PATCH] Disable kcov for slb routines.

2019-03-06 Thread Satheesh Rajendran
On Mon, Mar 04, 2019 at 01:55:51PM +0530, Mahesh J Salgaonkar wrote:
> From: Mahesh Salgaonkar 
> 
> The kcov instrumentation inside SLB routines causes duplicate SLB entries
> to be added resulting into SLB multihit machine checks.
> Disable kcov instrumentation on slb.o
> 
> Signed-off-by: Mahesh Salgaonkar 
> ---
>  arch/powerpc/mm/Makefile |1 +
>  1 file changed, 1 insertion(+)

Fixes: https://github.com/linuxppc/issues/issues/230

Tested-by: Satheesh Rajendran 

> 
> diff --git a/arch/powerpc/mm/Makefile b/arch/powerpc/mm/Makefile
> index d4d32e229ace..f9cb40684746 100644
> --- a/arch/powerpc/mm/Makefile
> +++ b/arch/powerpc/mm/Makefile
> @@ -60,3 +60,4 @@ obj-$(CONFIG_PPC_MEM_KEYS)  += pkeys.o
>  # This is necessary for booting with kcov enabled on book3e machines
>  KCOV_INSTRUMENT_tlb_nohash.o := n
>  KCOV_INSTRUMENT_fsl_booke_mmu.o := n
> +KCOV_INSTRUMENT_slb.o := n
> 



Re: [PATCH] Disable kcov for slb routines.

2019-03-04 Thread Andrew Donnellan

On 4/3/19 7:25 pm, Mahesh J Salgaonkar wrote:

From: Mahesh Salgaonkar 

The kcov instrumentation inside SLB routines causes duplicate SLB entries
to be added resulting into SLB multihit machine checks.
Disable kcov instrumentation on slb.o

Signed-off-by: Mahesh Salgaonkar 


Summary line needs a powerpc:


---
  arch/powerpc/mm/Makefile |1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/mm/Makefile b/arch/powerpc/mm/Makefile
index d4d32e229ace..f9cb40684746 100644
--- a/arch/powerpc/mm/Makefile
+++ b/arch/powerpc/mm/Makefile
@@ -60,3 +60,4 @@ obj-$(CONFIG_PPC_MEM_KEYS)+= pkeys.o
  # This is necessary for booting with kcov enabled on book3e machines
  KCOV_INSTRUMENT_tlb_nohash.o := n
  KCOV_INSTRUMENT_fsl_booke_mmu.o := n
+KCOV_INSTRUMENT_slb.o := n


The SLB stuff isn't related to the book3e issues, I'd appreciate a 
separate comment here.


Otherwise

Acked-by: Andrew Donnellan 



--
Andrew Donnellan  OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com  IBM Australia Limited



[PATCH] Disable kcov for slb routines.

2019-03-04 Thread Mahesh J Salgaonkar
From: Mahesh Salgaonkar 

The kcov instrumentation inside SLB routines causes duplicate SLB entries
to be added resulting into SLB multihit machine checks.
Disable kcov instrumentation on slb.o

Signed-off-by: Mahesh Salgaonkar 
---
 arch/powerpc/mm/Makefile |1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/mm/Makefile b/arch/powerpc/mm/Makefile
index d4d32e229ace..f9cb40684746 100644
--- a/arch/powerpc/mm/Makefile
+++ b/arch/powerpc/mm/Makefile
@@ -60,3 +60,4 @@ obj-$(CONFIG_PPC_MEM_KEYS)+= pkeys.o
 # This is necessary for booting with kcov enabled on book3e machines
 KCOV_INSTRUMENT_tlb_nohash.o := n
 KCOV_INSTRUMENT_fsl_booke_mmu.o := n
+KCOV_INSTRUMENT_slb.o := n