Re: [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest

2019-02-20 Thread Michael Ellerman
Mark Cave-Ayland writes: > On 19/02/2019 04:20, Michael Ellerman wrote: >> Mark Cave-Ayland writes: > unexpectedly removed the MSR_FE0 and MSR_FE1 bits from the bitmask used to > update the MSR of the previous thread in __giveup_fpu() causing a KVM-PR > MacOS > guest to lockup

Re: [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest

2019-02-19 Thread Mark Cave-Ayland
On 19/02/2019 04:55, Michael Ellerman wrote: > Mark Cave-Ayland writes: >> On 11/02/2019 00:30, Benjamin Herrenschmidt wrote: >> >>> On Fri, 2019-02-08 at 14:51 +, Mark Cave-Ayland wrote: Indeed, but there are still some questions to be asked here: 1) Why were these bits

Re: [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest

2019-02-18 Thread Mark Cave-Ayland
On 19/02/2019 04:20, Michael Ellerman wrote: Hi Michael, > Mark Cave-Ayland writes: >> On 08/02/2019 14:45, Christophe Leroy wrote: >> >>> Le 08/02/2019 à 15:33, Mark Cave-Ayland a écrit : Commit 8792468da5e1 "powerpc: Add the ability to save FPU without giving it up" >>> >>>

Re: [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest

2019-02-18 Thread Michael Ellerman
Mark Cave-Ayland writes: > On 11/02/2019 00:30, Benjamin Herrenschmidt wrote: > >> On Fri, 2019-02-08 at 14:51 +, Mark Cave-Ayland wrote: >>> >>> Indeed, but there are still some questions to be asked here: >>> >>> 1) Why were these bits removed from the original bitmask in the first place

Re: [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest

2019-02-18 Thread Michael Ellerman
Mark Cave-Ayland writes: > On 08/02/2019 14:45, Christophe Leroy wrote: > >> Le 08/02/2019 à 15:33, Mark Cave-Ayland a écrit : >>> Commit 8792468da5e1 "powerpc: Add the ability to save FPU without giving it >>> up" >> >> Expected format for the above is: >> >> Commit 123456789abc ("text") > >

Re: [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest

2019-02-11 Thread Mark Cave-Ayland
On 11/02/2019 00:30, Benjamin Herrenschmidt wrote: > On Fri, 2019-02-08 at 14:51 +, Mark Cave-Ayland wrote: >> >> Indeed, but there are still some questions to be asked here: >> >> 1) Why were these bits removed from the original bitmask in the first place >> without >> it being documented

Re: [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest

2019-02-10 Thread Benjamin Herrenschmidt
On Fri, 2019-02-08 at 14:51 +, Mark Cave-Ayland wrote: > > Indeed, but there are still some questions to be asked here: > > 1) Why were these bits removed from the original bitmask in the first place > without > it being documented in the commit message? > > 2) Is this the right fix? I'm

Re: [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest

2019-02-08 Thread Mark Cave-Ayland
On 08/02/2019 14:45, Christophe Leroy wrote: > Le 08/02/2019 à 15:33, Mark Cave-Ayland a écrit : >> Commit 8792468da5e1 "powerpc: Add the ability to save FPU without giving it >> up" > > Expected format for the above is: > > Commit 123456789abc ("text") Hi Christophe, Apologies - I'm fairly

Re: [PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest

2019-02-08 Thread Christophe Leroy
Le 08/02/2019 à 15:33, Mark Cave-Ayland a écrit : Commit 8792468da5e1 "powerpc: Add the ability to save FPU without giving it up" Expected format for the above is: Commit 123456789abc ("text") unexpectedly removed the MSR_FE0 and MSR_FE1 bits from the bitmask used to update the MSR of

[PATCH] powerpc: fix 32-bit KVM-PR lockup and panic with MacOS guest

2019-02-08 Thread Mark Cave-Ayland
Commit 8792468da5e1 "powerpc: Add the ability to save FPU without giving it up" unexpectedly removed the MSR_FE0 and MSR_FE1 bits from the bitmask used to update the MSR of the previous thread in __giveup_fpu() causing a KVM-PR MacOS guest to lockup and panic the kernel. Reinstate these bits to