Re: [PATCH] powerpc: sysdev: xive: Fix use true/false for bool type

[Gustavo A. R. Silva]

This is not actually a 'fix'

I suggest you to rephrase the subject in a different way and
remove the word 'fix' from it.

On 10/28/19 22:40, Saurav Girepunje wrote:
> Use true/false for bool return type in xive_spapr_cleanup_queue
> function.
> 

How do you find this?

If you used a tool to find this, please mention it.

Thanks
--
Gustavo

> Signed-off-by: Saurav Girepunje 
> ---
>  arch/powerpc/sysdev/xive/spapr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/sysdev/xive/spapr.c 
> b/arch/powerpc/sysdev/xive/spapr.c
> index 33c10749edec..74e3ffae0be6 100644
> --- a/arch/powerpc/sysdev/xive/spapr.c
> +++ b/arch/powerpc/sysdev/xive/spapr.c
> @@ -533,7 +533,7 @@ static void xive_spapr_cleanup_queue(unsigned int cpu, 
> struct xive_cpu *xc,
>  static bool xive_spapr_match(struct device_node *node)
>  {
>   /* Ignore cascaded controllers for the moment */
> - return 1;
> + return true;
>  }
>  
>  #ifdef CONFIG_SMP
> 

[PATCH] powerpc: sysdev: xive: Fix use true/false for bool type

[Saurav Girepunje]

Use true/false for bool return type in xive_spapr_cleanup_queue
function.

Signed-off-by: Saurav Girepunje 
---
 arch/powerpc/sysdev/xive/spapr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/sysdev/xive/spapr.c b/arch/powerpc/sysdev/xive/spapr.c
index 33c10749edec..74e3ffae0be6 100644
--- a/arch/powerpc/sysdev/xive/spapr.c
+++ b/arch/powerpc/sysdev/xive/spapr.c
@@ -533,7 +533,7 @@ static void xive_spapr_cleanup_queue(unsigned int cpu, 
struct xive_cpu *xc,
 static bool xive_spapr_match(struct device_node *node)
 {
/* Ignore cascaded controllers for the moment */
-   return 1;
+   return true;
 }
 
 #ifdef CONFIG_SMP
-- 
2.20.1