Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
On Tue, 2020-08-25 at 11:53 +0300, Felipe Balbi wrote: Joakim Tjernlund mailto:joakim.tjernl...@infinera.com>> writes: > On Mon, 2020-08-24 at 16:58 +0300, Felipe Balbi wrote: >> Joakim Tjernlund >> mailto:joakim.tjernl...@infinera.com>> writes: >> >> > On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote: >> > > >> > > On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote: >> > > > Signed-off-by: Ye Bin mailto:yebi...@huawei.com>> >> > > >> > > I can't take patches without any changelog text, sorry. >> > >> > Still taking patches for fsl_udc_core.c ? >> > I figured this driver was obsolete and should be moved to one of the >> > Chipidea drivers. >> >> Nobody sent any patches to switch over the users of this driver to >> chipidea. I would love to delete this driver :-) > > Me too, I got a few local patches here as the driver is quite buggy. > Got to little USB knowledge to switch it over though :( this wouldn't require USB knowledge. It only requires some minor DTS knowledge and HW for testing. hmm, OK. If it is that simple I may take a crack at it(but then why hasn't NXP already done that ?) I would need some guidance as to what the involved files are? Jocke
Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
Joakim Tjernlund writes: > On Mon, 2020-08-24 at 16:58 +0300, Felipe Balbi wrote: >> Joakim Tjernlund writes: >> >> > On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote: >> > > >> > > On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote: >> > > > Signed-off-by: Ye Bin >> > > >> > > I can't take patches without any changelog text, sorry. >> > >> > Still taking patches for fsl_udc_core.c ? >> > I figured this driver was obsolete and should be moved to one of the >> > Chipidea drivers. >> >> Nobody sent any patches to switch over the users of this driver to >> chipidea. I would love to delete this driver :-) > > Me too, I got a few local patches here as the driver is quite buggy. > Got to little USB knowledge to switch it over though :( this wouldn't require USB knowledge. It only requires some minor DTS knowledge and HW for testing. -- balbi signature.asc Description: PGP signature
Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
On Mon, 2020-08-24 at 16:58 +0300, Felipe Balbi wrote: > Joakim Tjernlund writes: > > > On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote: > > > > > > On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote: > > > > Signed-off-by: Ye Bin > > > > > > I can't take patches without any changelog text, sorry. > > > > Still taking patches for fsl_udc_core.c ? > > I figured this driver was obsolete and should be moved to one of the > > Chipidea drivers. > > Nobody sent any patches to switch over the users of this driver to > chipidea. I would love to delete this driver :-) Me too, I got a few local patches here as the driver is quite buggy. Got to little USB knowledge to switch it over though :( Jocke
Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
Joakim Tjernlund writes: > On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote: >> >> On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote: >> > Signed-off-by: Ye Bin >> >> I can't take patches without any changelog text, sorry. > > Still taking patches for fsl_udc_core.c ? > I figured this driver was obsolete and should be moved to one of the Chipidea > drivers. Nobody sent any patches to switch over the users of this driver to chipidea. I would love to delete this driver :-) -- balbi signature.asc Description: PGP signature
Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
On Mon, 2020-08-24 at 10:21 +0200, Greg KH wrote: > > On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote: > > Signed-off-by: Ye Bin > > I can't take patches without any changelog text, sorry. Still taking patches for fsl_udc_core.c ? I figured this driver was obsolete and should be moved to one of the Chipidea drivers. Jocke
[PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
Signed-off-by: Ye Bin
---
drivers/usb/gadget/udc/fsl_udc_core.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c
b/drivers/usb/gadget/udc/fsl_udc_core.c
index a6f7b2594c09..3e98740b8cfc 100644
--- a/drivers/usb/gadget/udc/fsl_udc_core.c
+++ b/drivers/usb/gadget/udc/fsl_udc_core.c
@@ -2439,11 +2439,12 @@ static int fsl_udc_probe(struct platform_device *pdev)
/* DEN is bidirectional ep number, max_ep doubles the number */
udc_controller->max_ep = (dccparams & DCCPARAMS_DEN_MASK) * 2;
- udc_controller->irq = platform_get_irq(pdev, 0);
- if (udc_controller->irq <= 0) {
- ret = udc_controller->irq ? : -ENODEV;
+ ret = platform_get_irq(pdev, 0);
+ if (ret <= 0) {
+ ret = ret ? : -ENODEV;
goto err_iounmap;
}
+ udc_controller->irq = ret;
ret = request_irq(udc_controller->irq, fsl_udc_irq, IRQF_SHARED,
driver_name, udc_controller);
--
2.25.4
Re: [PATCH] usb: gadget: fsl: Fix unsigned expression compared with zero in fsl_udc_probe
On Mon, Aug 24, 2020 at 04:04:37PM +0800, Ye Bin wrote: > Signed-off-by: Ye Bin I can't take patches without any changelog text, sorry. greg k-h
