Re: [PATCH 2/2] of: use platform_device_add

2013-02-19 Thread Jason Gunthorpe
On Sun, Feb 17, 2013 at 10:49:08AM +, Grant Likely wrote: The patch introduce a regression on imx6q boot. The IOMUXC block on imx6q is special. It acts not only a pin controller but also a system controller with a bunch of system level registers in there. That's why we currently

Re: [PATCH 2/2] of: use platform_device_add

2013-02-17 Thread Russell King - ARM Linux
On Sun, Feb 17, 2013 at 03:43:20PM +0800, Shawn Guo wrote: It also breaks all of_amba_device users. of_amba_device_create() -- amba_device_add() -- request_resource() and fails. Presumably that's because we no longer know what the parent resource is supposed to be?

Re: [PATCH 2/2] of: use platform_device_add

2013-02-17 Thread Grant Likely
On Sun, Feb 17, 2013 at 10:19 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Sun, Feb 17, 2013 at 03:43:20PM +0800, Shawn Guo wrote: The patch introduce a regression on imx6q boot. The IOMUXC block on imx6q is special. It acts not only a pin controller but also a system

Re: [PATCH 2/2] of: use platform_device_add

2013-02-17 Thread Fabio Estevam
On Sun, Feb 17, 2013 at 4:43 AM, Shawn Guo shawn@linaro.org wrote: On Sun, Feb 17, 2013 at 11:03:35AM +0800, Shawn Guo wrote: On Fri, Jan 18, 2013 at 01:40:00AM +, Grant Likely wrote: This allows platform_device_add a chance to call insert_resource on all of the resources from OF. At

Re: [PATCH 2/2] of: use platform_device_add

2013-02-16 Thread Shawn Guo
On Fri, Jan 18, 2013 at 01:40:00AM +, Grant Likely wrote: This allows platform_device_add a chance to call insert_resource on all of the resources from OF. At a minimum this fills in proc/iomem and presumably makes resource tracking and conflict detection work better. However, it has the

Re: [PATCH 2/2] of: use platform_device_add

2013-02-16 Thread Shawn Guo
On Sun, Feb 17, 2013 at 11:03:35AM +0800, Shawn Guo wrote: On Fri, Jan 18, 2013 at 01:40:00AM +, Grant Likely wrote: This allows platform_device_add a chance to call insert_resource on all of the resources from OF. At a minimum this fills in proc/iomem and presumably makes resource

[PATCH 2/2] of: use platform_device_add

2013-01-17 Thread Grant Likely
This allows platform_device_add a chance to call insert_resource on all of the resources from OF. At a minimum this fills in proc/iomem and presumably makes resource tracking and conflict detection work better. However, it has the side effect of moving all OF generated platform devices from