Re: [PATCH V2 0/3] Fix for shellcheck issues with latest scripts in tests/shell
On Fri, 13 Oct 2023 13:00:18 +0530, Athira Rajeev wrote: > shellcheck was run on perf tool shell scripts as a pre-requisite > to include a build option for shellcheck discussed here: > https://www.spinics.net/lists/linux-perf-users/msg25553.html > > And fixes were added for the coding/formatting issues in > two patchsets: > https://lore.kernel.org/linux-perf-users/20230613164145.50488-1-atraj...@linux.vnet.ibm.com/ > https://lore.kernel.org/linux-perf-users/20230709182800.53002-1-atraj...@linux.vnet.ibm.com/ > > [...] Applied to perf-tools-next, thanks!
Re: [PATCH V2 0/3] Fix for shellcheck issues with latest scripts in tests/shell
Hello, On Fri, Oct 13, 2023 at 12:31 AM Athira Rajeev wrote: > > shellcheck was run on perf tool shell scripts as a pre-requisite > to include a build option for shellcheck discussed here: > https://www.spinics.net/lists/linux-perf-users/msg25553.html > > And fixes were added for the coding/formatting issues in > two patchsets: > https://lore.kernel.org/linux-perf-users/20230613164145.50488-1-atraj...@linux.vnet.ibm.com/ > https://lore.kernel.org/linux-perf-users/20230709182800.53002-1-atraj...@linux.vnet.ibm.com/ > > Three additional issues were observed and fixes are part of: > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > > With recent commits in perf, other three issues are observed. > shellcheck version: 0.6.0 > The changes are with recent commits ( which is mentioned in each patch) > for lock_contention, record_sideband and stat_all_metricgroups test. > Patch series fixes these testcases and patches are on top of: > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > > The version 1 patchset had fix patch for test_arm_coresight.sh. > Dropping that in V2 based on discussion here: > https://lore.kernel.org/linux-perf-users/f265857d-0d37-4878-908c-d20732f21...@linux.vnet.ibm.com/T/#u > > Athira Rajeev (3): > tools/perf/tests Ignore the shellcheck SC2046 warning in > lock_contention > tools/perf/tests: Fix shellcheck warning in record_sideband.sh test > tools/perf/tests/shell: Fix shellcheck warning SC2112 with > stat_all_metricgroups For the series, Acked-by: Namhyung Kim Thanks, Namhyung
[PATCH V2 0/3] Fix for shellcheck issues with latest scripts in tests/shell
shellcheck was run on perf tool shell scripts as a pre-requisite to include a build option for shellcheck discussed here: https://www.spinics.net/lists/linux-perf-users/msg25553.html And fixes were added for the coding/formatting issues in two patchsets: https://lore.kernel.org/linux-perf-users/20230613164145.50488-1-atraj...@linux.vnet.ibm.com/ https://lore.kernel.org/linux-perf-users/20230709182800.53002-1-atraj...@linux.vnet.ibm.com/ Three additional issues were observed and fixes are part of: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git With recent commits in perf, other three issues are observed. shellcheck version: 0.6.0 The changes are with recent commits ( which is mentioned in each patch) for lock_contention, record_sideband and stat_all_metricgroups test. Patch series fixes these testcases and patches are on top of: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git The version 1 patchset had fix patch for test_arm_coresight.sh. Dropping that in V2 based on discussion here: https://lore.kernel.org/linux-perf-users/f265857d-0d37-4878-908c-d20732f21...@linux.vnet.ibm.com/T/#u Athira Rajeev (3): tools/perf/tests Ignore the shellcheck SC2046 warning in lock_contention tools/perf/tests: Fix shellcheck warning in record_sideband.sh test tools/perf/tests/shell: Fix shellcheck warning SC2112 with stat_all_metricgroups tools/perf/tests/shell/lock_contention.sh | 1 + tools/perf/tests/shell/record_sideband.sh | 2 +- tools/perf/tests/shell/stat_all_metricgroups.sh | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) -- 2.31.1
