Re: [RESEND] [PATCH v3] cxl: Prevent adapter reset if an active context exists

2016-11-06 Thread Andrew Donnellan
On 04/11/16 23:07, Frederic Barrat wrote: When I inject an EEH error, this patch causes the following WARN. Thoughts? mmm, hard to see a relation with that patch. I couldn't reproduce either. Could it bear any relation with the patch you're working on (lspci called while the capi device is

Re: [RESEND] [PATCH v3] cxl: Prevent adapter reset if an active context exists

2016-11-06 Thread Andrew Donnellan
On 05/11/16 00:15, Uma Krishnan wrote: Frederic/Andrew, Just recently this issue has been reported by system test without any of the two patches you are suspecting - this patch nor the lspci patch. I was hoping the lspci patch from Andrew can possibly solve it. System test CQ is SW370625. The

Re: [RESEND] [PATCH v3] cxl: Prevent adapter reset if an active context exists

2016-11-04 Thread Uma Krishnan
Frederic/Andrew, Just recently this issue has been reported by system test without any of the two patches you are suspecting - this patch nor the lspci patch. I was hoping the lspci patch from Andrew can possibly solve it. System test CQ is SW370625. The stack reported in that is same, [

Re: [RESEND] [PATCH v3] cxl: Prevent adapter reset if an active context exists

2016-11-04 Thread Frederic Barrat
Hi Andrew, Le 04/11/2016 à 07:27, Andrew Donnellan a écrit : On 14/10/16 20:38, Vaibhav Jain wrote: This patch prevents resetting the cxl adapter via sysfs in presence of one or more active cxl_context on it. This protects against an unrecoverable error caused by PSL owning a dirty cache line

Re: [RESEND] [PATCH v3] cxl: Prevent adapter reset if an active context exists

2016-11-04 Thread Andrew Donnellan
On 14/10/16 20:38, Vaibhav Jain wrote: This patch prevents resetting the cxl adapter via sysfs in presence of one or more active cxl_context on it. This protects against an unrecoverable error caused by PSL owning a dirty cache line even after reset and host tries to touch the same cache line.

[RESEND] [PATCH v3] cxl: Prevent adapter reset if an active context exists

2016-10-14 Thread Vaibhav Jain
This patch prevents resetting the cxl adapter via sysfs in presence of one or more active cxl_context on it. This protects against an unrecoverable error caused by PSL owning a dirty cache line even after reset and host tries to touch the same cache line. In case a force reset of the card is

Re: [PATCH v3] cxl: Prevent adapter reset if an active context exists

2016-10-14 Thread Vaibhav Jain
Hi Mpe, Michael Ellerman writes: > This is arguably a change to the ABI, but I assume we're OK with that as > it's arguably a bug in the existing implementation? Yes cross checked with Fred and he is ok with this. > > If so do we have a Fixes: ? and/or should this go to

Re: [PATCH v3] cxl: Prevent adapter reset if an active context exists

2016-10-14 Thread Andrew Donnellan
On 13/10/16 22:08, Vaibhav Jain wrote: This patch prevents resetting the cxl adapter via sysfs in presence of one or more active cxl_context on it. This protects against an unrecoverable error caused by PSL owning a dirty cache line even after reset and host tries to touch the same cache line.

Re: [PATCH v3] cxl: Prevent adapter reset if an active context exists

2016-10-13 Thread Michael Ellerman
Vaibhav Jain writes: > This patch prevents resetting the cxl adapter via sysfs in presence of > one or more active cxl_context on it. This protects against an > unrecoverable error caused by PSL owning a dirty cache line even after > reset and host tries to touch the

Re: [PATCH v3] cxl: Prevent adapter reset if an active context exists

2016-10-13 Thread Frederic Barrat
Hi Vaibhav, Le 13/10/2016 à 13:08, Vaibhav Jain a écrit : This patch prevents resetting the cxl adapter via sysfs in presence of one or more active cxl_context on it. This protects against an unrecoverable error caused by PSL owning a dirty cache line even after reset and host tries to touch

[PATCH v3] cxl: Prevent adapter reset if an active context exists

2016-10-13 Thread Vaibhav Jain
This patch prevents resetting the cxl adapter via sysfs in presence of one or more active cxl_context on it. This protects against an unrecoverable error caused by PSL owning a dirty cache line even after reset and host tries to touch the same cache line. In case a force reset of the card is