Re: [PATCH] ASoC: fsl_asrc: Add an option to select internal ratio mode

2020-06-30 Thread Shengjiu Wang
On Tue, Jun 30, 2020 at 8:38 PM Fabio Estevam wrote: > > Hi Shengjiu, > > On Mon, Jun 29, 2020 at 11:10 AM Shengjiu Wang wrote: > > > +/** > > "/**" notation may confuse 'make htmldocs". Since this is a single > line comment you could do: > > /* Select proper clock source for internal ratio mode

Re: [PATCH] ASoC: fsl_asrc: Add an option to select internal ratio mode

2020-06-30 Thread Fabio Estevam
Hi Shengjiu, On Mon, Jun 29, 2020 at 11:10 AM Shengjiu Wang wrote: > +/** "/**" notation may confuse 'make htmldocs". Since this is a single line comment you could do: /* Select proper clock source for internal ratio mode */ > + * Select proper clock source for internal ratio mode > + */ >

Re: [PATCH] ASoC: fsl_asrc: Add an option to select internal ratio mode

2020-06-29 Thread Shengjiu Wang
On Tue, Jun 30, 2020 at 4:09 AM Nicolin Chen wrote: > > On Mon, Jun 29, 2020 at 09:58:35PM +0800, Shengjiu Wang wrote: > > The ASRC not only supports ideal ratio mode, but also supports > > internal ratio mode. > > > > For internal rato mode, the rate of clock source should be divided > > with no

Re: [PATCH] ASoC: fsl_asrc: Add an option to select internal ratio mode

2020-06-29 Thread Nicolin Chen
On Mon, Jun 29, 2020 at 09:58:35PM +0800, Shengjiu Wang wrote: > The ASRC not only supports ideal ratio mode, but also supports > internal ratio mode. > > For internal rato mode, the rate of clock source should be divided > with no remainder by sample rate, otherwise there is sound > distortion.