Re: [PATCH v11 3/8] powerpc/perf: consolidate read_user_stack_32

2020-04-06 Thread Michal Suchánek
On Fri, Apr 03, 2020 at 05:13:25PM +1000, Nicholas Piggin wrote: > Michal Suchánek's on March 25, 2020 5:38 am: > > On Tue, Mar 24, 2020 at 06:48:20PM +1000, Nicholas Piggin wrote: > >> Michal Suchanek's on March 19, 2020 10:19 pm: > >> > There are two almost identical copies for 32bit and 64bit.

Re: [PATCH v11 3/8] powerpc/perf: consolidate read_user_stack_32

2020-04-03 Thread Michal Suchánek
On Fri, Apr 03, 2020 at 09:26:27PM +1000, Nicholas Piggin wrote: > Michal Suchánek's on April 3, 2020 8:52 pm: > > Hello, > > > > there are 3 variants of the function > > > > read_user_stack_64 > > > > 32bit read_user_stack_32 > > 64bit read_user_Stack_32 > > Right. > > > On Fri, Apr 03, 2020

Re: [PATCH v11 3/8] powerpc/perf: consolidate read_user_stack_32

2020-04-03 Thread Nicholas Piggin
Michal Suchánek's on April 3, 2020 8:52 pm: > Hello, > > there are 3 variants of the function > > read_user_stack_64 > > 32bit read_user_stack_32 > 64bit read_user_Stack_32 Right. > On Fri, Apr 03, 2020 at 05:13:25PM +1000, Nicholas Piggin wrote: [...] >> #endif /* CONFIG_PPC64 */ >> >>

Re: [PATCH v11 3/8] powerpc/perf: consolidate read_user_stack_32

2020-04-03 Thread Michal Suchánek
Hello, there are 3 variants of the function read_user_stack_64 32bit read_user_stack_32 64bit read_user_Stack_32 On Fri, Apr 03, 2020 at 05:13:25PM +1000, Nicholas Piggin wrote: > Michal Suchánek's on March 25, 2020 5:38 am: > > On Tue, Mar 24, 2020 at 06:48:20PM +1000, Nicholas Piggin wrote:

Re: [PATCH v11 3/8] powerpc/perf: consolidate read_user_stack_32

2020-04-03 Thread Nicholas Piggin
Michal Suchánek's on March 25, 2020 5:38 am: > On Tue, Mar 24, 2020 at 06:48:20PM +1000, Nicholas Piggin wrote: >> Michal Suchanek's on March 19, 2020 10:19 pm: >> > There are two almost identical copies for 32bit and 64bit. >> > >> > The function is used only in 32bit code which will be split

Re: [PATCH v11 3/8] powerpc/perf: consolidate read_user_stack_32

2020-03-24 Thread Michal Suchánek
On Tue, Mar 24, 2020 at 06:48:20PM +1000, Nicholas Piggin wrote: > Michal Suchanek's on March 19, 2020 10:19 pm: > > There are two almost identical copies for 32bit and 64bit. > > > > The function is used only in 32bit code which will be split out in next > > patch so consolidate to one function.

Re: [PATCH v11 3/8] powerpc/perf: consolidate read_user_stack_32

2020-03-24 Thread Nicholas Piggin
Michal Suchanek's on March 19, 2020 10:19 pm: > There are two almost identical copies for 32bit and 64bit. > > The function is used only in 32bit code which will be split out in next > patch so consolidate to one function. > > Signed-off-by: Michal Suchanek > Reviewed-by: Christophe Leroy >