Re: [1/2] cxl: Fix off by one error allowing subsequent mmap page to be accessed

2015-07-08 Thread Michael Ellerman
On Tue, 2015-07-07 at 05:45:45 UTC, Ian Munsie wrote:
 From: Ian Munsie imun...@au1.ibm.com
 
 It was discovered that if a process mmaped their problem state area they
 were able to access one page more than expected, potentially allowing
 them to access the problem state area of an unrelated process.
 
 This was due to a simple off by one error in the mmap fault handler
 introduced in 0712dc7e73e59d79bcead5d5520acf4e9e917e87 (cxl: Fix issues
 when unmapping contexts), which is fixed in this patch.
 
 Cc: sta...@vger.kernel.org
 Fixes: 0712dc7e73e5 (cxl: Fix issues when unmapping contexts)
 Signed-off-by: Ian Munsie imun...@au1.ibm.com

Applied to powerpc fixes, thanks.

https://git.kernel.org/cgit/linux/kernel/git/powerpc/linux.git/commit/?h=fixesid=10a5894f2dedd8a26b3132497445b314c0d952c4

cheers
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH 1/2] cxl: Fix off by one error allowing subsequent mmap page to be accessed

2015-07-06 Thread Ian Munsie
From: Ian Munsie imun...@au1.ibm.com

It was discovered that if a process mmaped their problem state area they
were able to access one page more than expected, potentially allowing
them to access the problem state area of an unrelated process.

This was due to a simple off by one error in the mmap fault handler
introduced in 0712dc7e73e59d79bcead5d5520acf4e9e917e87 (cxl: Fix issues
when unmapping contexts), which is fixed in this patch.

Cc: sta...@vger.kernel.org
Fixes: 0712dc7e73e5 (cxl: Fix issues when unmapping contexts)
Signed-off-by: Ian Munsie imun...@au1.ibm.com
---
 drivers/misc/cxl/context.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/cxl/context.c b/drivers/misc/cxl/context.c
index 2a4c80a..6c1ce51 100644
--- a/drivers/misc/cxl/context.c
+++ b/drivers/misc/cxl/context.c
@@ -113,11 +113,11 @@ static int cxl_mmap_fault(struct vm_area_struct *vma, 
struct vm_fault *vmf)
 
if (ctx-afu-current_mode == CXL_MODE_DEDICATED) {
area = ctx-afu-psn_phys;
-   if (offset  ctx-afu-adapter-ps_size)
+   if (offset = ctx-afu-adapter-ps_size)
return VM_FAULT_SIGBUS;
} else {
area = ctx-psn_phys;
-   if (offset  ctx-psn_size)
+   if (offset = ctx-psn_size)
return VM_FAULT_SIGBUS;
}
 
-- 
2.1.4

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev