Re: [GIT PULL 00/21] perf/core improvements and fixes
* Arnaldo Carvalho de Melo wrote:
> Hi Ingo,
>
> Please consider pulling, contains a recently merged
> tip/perf/urgent,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit c2586cfbb905939b79b49a9121fb0a59a5668fd6:
>
> Merge remote-tracking branch 'tip/perf/urgent' into perf/core (2018-07-31
> 09:55:45 -0300)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git
> tags/perf-core-for-mingo-4.19-20180801
>
> for you to fetch changes up to b912885ab75c7c8aa841c615108afd755d0b97f8:
>
> perf trace: Do not require --no-syscalls to suppress strace like output
> (2018-08-01 16:20:28 -0300)
>
>
> perf/core improvements and fixes:
>
> perf trace: (Arnaldo Carvalho de Melo)
>
> - Do not require --no-syscalls to suppress strace like output, i.e.
>
> # perf trace -e sched:*switch
>
> will show just sched:sched_switch events, not strace-like formatted
> syscall events, use --syscalls to get the previous behaviour.
>
> If instead:
>
> # perf trace
>
> is used, i.e. no events specified, then --syscalls is implied and
> system wide strace like formatting will be applied to all syscalls.
>
> The behaviour when just a syscall subset is used with '-e' is unchanged:
>
> # perf trace -e *sleep,sched:*switch
>
> will work as before: just the 'nanosleep' syscall will be strace-like
> formatted plus the sched:sched_switch tracepoint event, system wide.
>
> - Allow string table generators to use a default header dir, allowing
> use of them without parameters to see the table it generates on
> stdout, e.g.:
>
> $ tools/perf/trace/beauty/kvm_ioctl.sh
> static const char *kvm_ioctl_cmds[] = {
> [0x00] = "GET_API_VERSION",
> [0x01] = "CREATE_VM",
> [0x02] = "GET_MSR_INDEX_LIST",
> [0x03] = "CHECK_EXTENSION",
>
> [0xe0] = "CREATE_DEVICE",
> [0xe1] = "SET_DEVICE_ATTR",
> [0xe2] = "GET_DEVICE_ATTR",
> [0xe3] = "HAS_DEVICE_ATTR",
> };
> $
>
> See 'ls tools/perf/trace/beauty/*.sh' to see the available string
> table generators.
>
> - Add a generator for IPPROTO_ socket's protocol constants.
>
> perf record: (Kan Liang)
>
> - Fix error out while applying initial delay and using LBR, due to
> the use of a PERF_TYPE_SOFTWARE/PERF_COUNT_SW_DUMMY event to track
> PERF_RECORD_MMAP events while waiting for the initial delay. Such
> events fail when configured asking PERF_SAMPLE_BRANCH_STACK in
> perf_event_attr.sample_type.
>
> perf c2c: (Jiri Olsa)
>
> - Fix report crash for empty browser, when processing a perf.data file
> without events of interest, either because not asked for in
> 'perf record' or because the workload didn't triggered such events.
>
> perf list: (Michael Petlan)
>
> - Align metric group description format with PMU event description.
>
> perf tests: (Sandipan Das)
>
> - Fix indexing when invoking subtests, which caused BPF tests to
> get results for the next test in the list, with the last one
> reporting a failure.
>
> eBPF:
>
> - Fix installation directory for header files included from eBPF proggies,
> avoiding clashing with relative paths used to build other software projects
> such as glibc. (Thomas Richter)
>
> - Show better message when failing to load an object. (Arnaldo Carvalho de
> Melo)
>
> General: (Christophe Leroy)
>
> - Allow overriding MAX_NR_CPUS at compile time, to make the tooling
> usable in systems with less memory, in time this has to be changed
> to properly allocate based on _NPROCESSORS_ONLN.
>
> Architecture specific:
>
> - Update arm64's ThunderX2 implementation defined pmu core events (Ganapatrao
> Kulkarni)
>
> - Fix complex event name parsing in 'perf test' for PowerPC, where the
> 'umask' event
> modifier isn't present. (Sandipan Das)
>
> CoreSight ARM hardware tracing: (Leo Yan)
>
> - Fix start tracing packet handling.
>
> - Support dummy address value for CS_ETM_TRACE_ON packet.
>
> - Generate branch sample when receiving a CS_ETM_TRACE_ON packet.
>
> - Generate branch sample for CS_ETM_TRACE_ON packet.
>
> Signed-off-by: Arnaldo Carvalho de Melo
>
>
> Arnaldo Carvalho de Melo (9):
> perf trace beauty: Default header_dir to cwd to work without parms
> tools include uapi: Grab a copy of linux/in.h
> perf beauty: Add a generator for IPPROTO_ socket's protocol constants
> perf trace beauty: Do not print NULL strarray entries
> perf trace beauty: Add beautifiers for 'socket''s 'protocol' arg
> perf trace: Beautify the AF_INET & AF_INET6 'socket' syscall 'protocol'
> args
> perf bpf: Show better message when failing to load an object
> perf bpf: Include uapi/linux/bpf.h from the 'perf trace' script's
[GIT PULL 00/21] perf/core improvements and fixes
Hi Ingo,
Please consider pulling, contains a recently merged
tip/perf/urgent,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit c2586cfbb905939b79b49a9121fb0a59a5668fd6:
Merge remote-tracking branch 'tip/perf/urgent' into perf/core (2018-07-31
09:55:45 -0300)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git
tags/perf-core-for-mingo-4.19-20180801
for you to fetch changes up to b912885ab75c7c8aa841c615108afd755d0b97f8:
perf trace: Do not require --no-syscalls to suppress strace like output
(2018-08-01 16:20:28 -0300)
perf/core improvements and fixes:
perf trace: (Arnaldo Carvalho de Melo)
- Do not require --no-syscalls to suppress strace like output, i.e.
# perf trace -e sched:*switch
will show just sched:sched_switch events, not strace-like formatted
syscall events, use --syscalls to get the previous behaviour.
If instead:
# perf trace
is used, i.e. no events specified, then --syscalls is implied and
system wide strace like formatting will be applied to all syscalls.
The behaviour when just a syscall subset is used with '-e' is unchanged:
# perf trace -e *sleep,sched:*switch
will work as before: just the 'nanosleep' syscall will be strace-like
formatted plus the sched:sched_switch tracepoint event, system wide.
- Allow string table generators to use a default header dir, allowing
use of them without parameters to see the table it generates on
stdout, e.g.:
$ tools/perf/trace/beauty/kvm_ioctl.sh
static const char *kvm_ioctl_cmds[] = {
[0x00] = "GET_API_VERSION",
[0x01] = "CREATE_VM",
[0x02] = "GET_MSR_INDEX_LIST",
[0x03] = "CHECK_EXTENSION",
[0xe0] = "CREATE_DEVICE",
[0xe1] = "SET_DEVICE_ATTR",
[0xe2] = "GET_DEVICE_ATTR",
[0xe3] = "HAS_DEVICE_ATTR",
};
$
See 'ls tools/perf/trace/beauty/*.sh' to see the available string
table generators.
- Add a generator for IPPROTO_ socket's protocol constants.
perf record: (Kan Liang)
- Fix error out while applying initial delay and using LBR, due to
the use of a PERF_TYPE_SOFTWARE/PERF_COUNT_SW_DUMMY event to track
PERF_RECORD_MMAP events while waiting for the initial delay. Such
events fail when configured asking PERF_SAMPLE_BRANCH_STACK in
perf_event_attr.sample_type.
perf c2c: (Jiri Olsa)
- Fix report crash for empty browser, when processing a perf.data file
without events of interest, either because not asked for in
'perf record' or because the workload didn't triggered such events.
perf list: (Michael Petlan)
- Align metric group description format with PMU event description.
perf tests: (Sandipan Das)
- Fix indexing when invoking subtests, which caused BPF tests to
get results for the next test in the list, with the last one
reporting a failure.
eBPF:
- Fix installation directory for header files included from eBPF proggies,
avoiding clashing with relative paths used to build other software projects
such as glibc. (Thomas Richter)
- Show better message when failing to load an object. (Arnaldo Carvalho de Melo)
General: (Christophe Leroy)
- Allow overriding MAX_NR_CPUS at compile time, to make the tooling
usable in systems with less memory, in time this has to be changed
to properly allocate based on _NPROCESSORS_ONLN.
Architecture specific:
- Update arm64's ThunderX2 implementation defined pmu core events (Ganapatrao
Kulkarni)
- Fix complex event name parsing in 'perf test' for PowerPC, where the 'umask'
event
modifier isn't present. (Sandipan Das)
CoreSight ARM hardware tracing: (Leo Yan)
- Fix start tracing packet handling.
- Support dummy address value for CS_ETM_TRACE_ON packet.
- Generate branch sample when receiving a CS_ETM_TRACE_ON packet.
- Generate branch sample for CS_ETM_TRACE_ON packet.
Signed-off-by: Arnaldo Carvalho de Melo
Arnaldo Carvalho de Melo (9):
perf trace beauty: Default header_dir to cwd to work without parms
tools include uapi: Grab a copy of linux/in.h
perf beauty: Add a generator for IPPROTO_ socket's protocol constants
perf trace beauty: Do not print NULL strarray entries
perf trace beauty: Add beautifiers for 'socket''s 'protocol' arg
perf trace: Beautify the AF_INET & AF_INET6 'socket' syscall 'protocol'
args
perf bpf: Show better message when failing to load an object
perf bpf: Include uapi/linux/bpf.h from the 'perf trace' script's bpf.h
perf trace: Do not require --no-syscalls to suppress strace like output
Christophe Leroy (1):
perf tools: Allow overriding MAX_NR_CPUS at compile time
Ganapatrao Kulkarni (1):
perf vendor events arm64: Update ThunderX2 implementation defined pmu
core events
Jiri Olsa (1):
perf c2c report:
[GIT PULL 00/21] perf/core improvements and fixes
Hi Ingo, Besides these 21 patches there are 65 other patches, all present in the perf-core-for-mingo tag, that I sent a pull request for but had some issues building on older distros (got reports and fixes for OL6, CentOS6, tested it all on RHEL6), minor stuff, all noted on the comments just before my Signed-off-by lines. Please consider pulling, - Arnaldo The following changes since commit b64aa553d8430aabd24f303899cfa4de678e2c3a: perf bench numa: Show more stats of particular threads in verbose mode (2015-05-04 12:43:41 -0300) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-2 for you to fetch changes up to 0c160d495b5616e071bb4f873812e8f473128149: perf kmem: Add kmem.default config option (2015-05-04 13:34:48 -0300) perf/core improvements and fixes: User visible: - perf kmem improvements: (Namhyung Kim) - Support sort keys on page analysis - New --live option - Humand readable gfp flags - Allow setting the default in perfconfig files - perf probe --filter improvements (Masami Hiramatsu) - Improve detection of file/function name in the 'perf probe' pattern (Naveen Rao) Infrastructure: - Some more Intel PT prep patches (Adrian Hunter) - Fix ppc64 ABIv2 symbol decoding (Ananth N Mavinakayanahalli) Build fixes: - bison-related build failure on CentOS 6 (Namhyung Kim) - perf probe fixes for better support powerpc (Naveen Rao) Signed-off-by: Arnaldo Carvalho de Melo a...@redhat.com Adrian Hunter (3): perf evlist: Amend mmap ref counting for the AUX area mmap perf script: Always allow fields 'addr' and 'cpu' for auxtrace perf report: Add Instruction Tracing support Ananth N Mavinakayanahalli (1): perf probe ppc64le: Fix ppc64 ABIv2 symbol decoding Masami Hiramatsu (4): perf tools: Improve strfilter to append additional rules perf tools: Add strfilter__string to recover rules string perf probe: Accept multiple filter options perf probe: Accept filter argument for --list Namhyung Kim (6): perf tools: Fix bison-related build failure on CentOS 6 perf kmem: Implement stat --page --caller perf kmem: Support sort keys on page analysis perf kmem: Add --live option for current allocation stat perf kmem: Print gfp flags in human readable string perf kmem: Add kmem.default config option Naveen N. Rao (7): perf probe ppc: Fix symbol fixup issues due to ELF type perf probe ppc: Use the right prefix when ignoring SyS symbols on ppc perf probe ppc: Enable matching against dot symbols automatically perf probe ppc64le: Prefer symbol table lookup over DWARF perf probe ppc64le: Fixup function entry if using kallsyms lookup perf symbols: Warn on build id mismatch perf probe: Improve detection of file/function name in the probe pattern tools/perf/Documentation/perf-kmem.txt | 11 +- tools/perf/Documentation/perf-probe.txt | 6 +- tools/perf/Documentation/perf-report.txt| 27 + tools/perf/arch/powerpc/util/Build | 1 + tools/perf/arch/powerpc/util/sym-handling.c | 82 +++ tools/perf/builtin-kmem.c | 964 +--- tools/perf/builtin-probe.c | 64 +- tools/perf/builtin-report.c | 11 + tools/perf/builtin-script.c | 29 +- tools/perf/util/Build | 2 +- tools/perf/util/evlist.c| 2 +- tools/perf/util/map.c | 5 + tools/perf/util/map.h | 3 +- tools/perf/util/probe-event.c | 69 +- tools/perf/util/probe-event.h | 5 +- tools/perf/util/strfilter.c | 107 +++ tools/perf/util/strfilter.h | 35 + tools/perf/util/symbol-elf.c| 13 +- tools/perf/util/symbol.c| 25 +- tools/perf/util/symbol.h| 10 + 20 files changed, 1313 insertions(+), 158 deletions(-) create mode 100644 tools/perf/arch/powerpc/util/sym-handling.c ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [GIT PULL 00/21] perf/core improvements and fixes
* Arnaldo Carvalho de Melo a...@infradead.org wrote: Hi Ingo, Please consider pulling. Namhyung, Jiri, the 'group report' patches are at acme/perf/group, will send a pull req later if it survives further testing. - Arnaldo The following changes since commit a2d28d0c198b65fac28ea6212f5f8edc77b29c27: Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2013-01-25 11:34:00 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo for you to fetch changes up to 5809fde040de2afa477a6c593ce2e8fd2c11d9d3: perf header: Fix double fclose() on do_write(fd, xxx) failure (2013-01-30 10:40:44 -0300) perf/core improvements and fixes: . Fix some leaks in exit paths. . Use memdup where applicable . Remove some die() calls, allowing callers to handle exit paths gracefully. . Correct typo in tools Makefile, fix from Borislav Petkov. . Add 'perf bench numa mem' NUMA performance measurement suite, from Ingo Molnar. . Handle dynamic array's element size properly, fix from Jiri Olsa. . Fix memory leaks on evsel-counts, from Namhyung Kim. . Make numa benchmark optional, allowing the build in machines where required numa libraries are not present, fix from Peter Hurley. . Add interval printing in 'perf stat', from Stephane Eranian. . Fix compile warnings in tests/attr.c, from Sukadev Bhattiprolu. . Fix double free, pclose instead of fclose, leaks and double fclose errors found with the cppcheck tool, from Thomas Jarosch. Signed-off-by: Arnaldo Carvalho de Melo a...@redhat.com Arnaldo Carvalho de Melo (8): perf tools: Stop using 'self' in strlist perf tools: Stop using 'self' in map.[ch] perf tools: Use memdup in map__clone perf kmem: Use memdup() perf header: Stop using die() calls when processing tracing data perf ui browser: Free browser-helpline() on ui_browser__hide() perf tests: Call machine__exit in the vmlinux matches kallsyms test perf tests: Fix leaks on PERF_RECORD_* test Borislav Petkov (1): tools: Correct typo in tools Makefile Ingo Molnar (1): perf: Add 'perf bench numa mem' NUMA performance measurement suite Jiri Olsa (1): tools lib traceevent: Handle dynamic array's element size properly Namhyung Kim (1): perf evsel: Fix memory leaks on evsel-counts Peter Hurley (1): perf tools: Make numa benchmark optional Stephane Eranian (2): perf evsel: Add prev_raw_count field perf stat: Add interval printing Sukadev Bhattiprolu (1): perf tools, powerpc: Fix compile warnings in tests/attr.c Thomas Jarosch (5): perf tools: Fix possible double free on error perf sort: Use pclose() instead of fclose() on pipe stream perf tools: Fix memory leak on error perf header: Fix memory leak for the Not caching a kptr_restrict'ed /proc/kallsyms case perf header: Fix double fclose() on do_write(fd, xxx) failure tools/Makefile |2 +- tools/lib/traceevent/event-parse.c | 39 +- tools/perf/Documentation/perf-stat.txt |4 + tools/perf/Makefile | 13 + tools/perf/arch/common.c |1 + tools/perf/bench/bench.h |1 + tools/perf/bench/numa.c | 1731 ++ tools/perf/builtin-bench.c | 17 + tools/perf/builtin-kmem.c|6 +- tools/perf/builtin-stat.c| 158 ++- tools/perf/config/feature-tests.mak | 11 + tools/perf/tests/attr.c |5 + tools/perf/tests/open-syscall-all-cpus.c |1 + tools/perf/tests/perf-record.c | 12 +- tools/perf/tests/vmlinux-kallsyms.c |4 +- tools/perf/ui/browser.c |2 + tools/perf/util/event.c |4 +- tools/perf/util/evsel.c | 31 + tools/perf/util/evsel.h |2 + tools/perf/util/header.c | 25 +- tools/perf/util/map.c| 118 +- tools/perf/util/map.h| 24 +- tools/perf/util/sort.c |7 +- tools/perf/util/strlist.c| 54 +- tools/perf/util/strlist.h| 42 +- 25 files changed, 2154 insertions(+), 160 deletions(-) create mode 100644 tools/perf/bench/numa.c Pulled, thanks a lot Arnaldo! Ingo ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
[GIT PULL 00/21] perf/core improvements and fixes
Hi Ingo, Please consider pulling. Namhyung, Jiri, the 'group report' patches are at acme/perf/group, will send a pull req later if it survives further testing. - Arnaldo The following changes since commit a2d28d0c198b65fac28ea6212f5f8edc77b29c27: Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2013-01-25 11:34:00 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo for you to fetch changes up to 5809fde040de2afa477a6c593ce2e8fd2c11d9d3: perf header: Fix double fclose() on do_write(fd, xxx) failure (2013-01-30 10:40:44 -0300) perf/core improvements and fixes: . Fix some leaks in exit paths. . Use memdup where applicable . Remove some die() calls, allowing callers to handle exit paths gracefully. . Correct typo in tools Makefile, fix from Borislav Petkov. . Add 'perf bench numa mem' NUMA performance measurement suite, from Ingo Molnar. . Handle dynamic array's element size properly, fix from Jiri Olsa. . Fix memory leaks on evsel-counts, from Namhyung Kim. . Make numa benchmark optional, allowing the build in machines where required numa libraries are not present, fix from Peter Hurley. . Add interval printing in 'perf stat', from Stephane Eranian. . Fix compile warnings in tests/attr.c, from Sukadev Bhattiprolu. . Fix double free, pclose instead of fclose, leaks and double fclose errors found with the cppcheck tool, from Thomas Jarosch. Signed-off-by: Arnaldo Carvalho de Melo a...@redhat.com Arnaldo Carvalho de Melo (8): perf tools: Stop using 'self' in strlist perf tools: Stop using 'self' in map.[ch] perf tools: Use memdup in map__clone perf kmem: Use memdup() perf header: Stop using die() calls when processing tracing data perf ui browser: Free browser-helpline() on ui_browser__hide() perf tests: Call machine__exit in the vmlinux matches kallsyms test perf tests: Fix leaks on PERF_RECORD_* test Borislav Petkov (1): tools: Correct typo in tools Makefile Ingo Molnar (1): perf: Add 'perf bench numa mem' NUMA performance measurement suite Jiri Olsa (1): tools lib traceevent: Handle dynamic array's element size properly Namhyung Kim (1): perf evsel: Fix memory leaks on evsel-counts Peter Hurley (1): perf tools: Make numa benchmark optional Stephane Eranian (2): perf evsel: Add prev_raw_count field perf stat: Add interval printing Sukadev Bhattiprolu (1): perf tools, powerpc: Fix compile warnings in tests/attr.c Thomas Jarosch (5): perf tools: Fix possible double free on error perf sort: Use pclose() instead of fclose() on pipe stream perf tools: Fix memory leak on error perf header: Fix memory leak for the Not caching a kptr_restrict'ed /proc/kallsyms case perf header: Fix double fclose() on do_write(fd, xxx) failure tools/Makefile |2 +- tools/lib/traceevent/event-parse.c | 39 +- tools/perf/Documentation/perf-stat.txt |4 + tools/perf/Makefile | 13 + tools/perf/arch/common.c |1 + tools/perf/bench/bench.h |1 + tools/perf/bench/numa.c | 1731 ++ tools/perf/builtin-bench.c | 17 + tools/perf/builtin-kmem.c|6 +- tools/perf/builtin-stat.c| 158 ++- tools/perf/config/feature-tests.mak | 11 + tools/perf/tests/attr.c |5 + tools/perf/tests/open-syscall-all-cpus.c |1 + tools/perf/tests/perf-record.c | 12 +- tools/perf/tests/vmlinux-kallsyms.c |4 +- tools/perf/ui/browser.c |2 + tools/perf/util/event.c |4 +- tools/perf/util/evsel.c | 31 + tools/perf/util/evsel.h |2 + tools/perf/util/header.c | 25 +- tools/perf/util/map.c| 118 +- tools/perf/util/map.h| 24 +- tools/perf/util/sort.c |7 +- tools/perf/util/strlist.c| 54 +- tools/perf/util/strlist.h| 42 +- 25 files changed, 2154 insertions(+), 160 deletions(-) create mode 100644 tools/perf/bench/numa.c ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
