Re: [PATCH] ASoC: fsl_spdif: Fix unnecessary check in fsl_spdif_probe()

2020-10-01 Thread Mark Brown
On Wed, 26 Aug 2020 23:09:18 +0800, Tang Bin wrote: > The function fsl_spdif_probe() is only called with an openfirmware > platform device. Therefore there is no need to check that the passed > in device is NULL. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-

Re: [PATCH] ASoC: fsl_spdif: Fix unnecessary check in fsl_spdif_probe()

2020-08-26 Thread Mark Brown
On Wed, Aug 26, 2020 at 11:09:18PM +0800, Tang Bin wrote: > The function fsl_spdif_probe() is only called with an openfirmware > platform device. Therefore there is no need to check that the passed > in device is NULL. Why is this an issue - the check will make things more robust if someone manage

[PATCH] ASoC: fsl_spdif: Fix unnecessary check in fsl_spdif_probe()

2020-08-26 Thread Tang Bin
The function fsl_spdif_probe() is only called with an openfirmware platform device. Therefore there is no need to check that the passed in device is NULL. Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin --- sound/soc/fsl/fsl_spdif.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sou