RE: [PATCH] Correct printk %pF to work on all architectures

2008-09-09 Thread James Bottomley
OK, so could we get this in to -rc5 please? It's a bug fix for parisc since we're currently printing rubbish. James --- From: James Bottomley [EMAIL PROTECTED] Date: Wed, 3 Sep 2008 20:43:36 -0500 Subject: lib: Correct printk %pF to work on all architectures It was introduced by commit

Re: [PATCH] Correct printk %pF to work on all architectures

2008-09-09 Thread Kyle McMartin
On Tue, Sep 09, 2008 at 09:12:41AM -0500, James Bottomley wrote: OK, so could we get this in to -rc5 please? It's a bug fix for parisc since we're currently printing rubbish. While I suppose it's a parisc patch, I'm not going to try to push it unless either Linus just applies it, or we get

Re: [PATCH] Correct printk %pF to work on all architectures

2008-09-09 Thread Benjamin Herrenschmidt
On Tue, 2008-09-09 at 14:08 -0400, Kyle McMartin wrote: On Tue, Sep 09, 2008 at 09:12:41AM -0500, James Bottomley wrote: OK, so could we get this in to -rc5 please? It's a bug fix for parisc since we're currently printing rubbish. While I suppose it's a parisc patch, I'm not going to

Re: [PATCH] Correct printk %pF to work on all architectures

2008-09-04 Thread Benjamin Herrenschmidt
Make dereference_function_descriptor() more accommodating by allowing architecture overrides. I put the three overrides (for parisc64, ppc64 and ia64) in arch/kernel/module.c because that's where the kernel internal linker which knows how to deal with function descriptors sits.

RE: [PATCH] Correct printk %pF to work on all architectures

2008-09-04 Thread Luck, Tony
Make dereference_function_descriptor() more accommodating by allowing architecture overrides. I put the three overrides (for parisc64, ppc64 and ia64) in arch/kernel/module.c because that's where the kernel internal linker which knows how to deal with function descriptors sits.

[PATCH] Correct printk %pF to work on all architectures

2008-09-03 Thread James Bottomley
It was introduced by commit 0fe1ef24f7bd0020f29ffe287dfdb9ead33ca0b2 Author: Linus Torvalds [EMAIL PROTECTED] Date: Sun Jul 6 16:43:12 2008 -0700 vsprintf: add support for '%pS' and '%pF' pointer formats However, the current way its coded doesn't work on parisc64. For two reasons: 1)

Re: [PATCH] Correct printk %pF to work on all architectures

2008-09-03 Thread Linus Torvalds
On Wed, 3 Sep 2008, James Bottomley wrote: Make dereference_function_descriptor() more accommodating by allowing architecture overrides. Don't do it like this. We don't want some stupid useless weak function that is empty on all sane platforms. Just do .. declare or create an

Re: [PATCH] Correct printk %pF to work on all architectures

2008-09-03 Thread James Bottomley
On Wed, 2008-09-03 at 14:22 -0700, Linus Torvalds wrote: On Wed, 3 Sep 2008, James Bottomley wrote: Make dereference_function_descriptor() more accommodating by allowing architecture overrides. Don't do it like this. We don't want some stupid useless weak function that is empty on

Re: [PATCH] Correct printk %pF to work on all architectures

2008-09-03 Thread James Bottomley
On Wed, 2008-09-03 at 15:54 -0700, Linus Torvalds wrote: Anyway, it's easy to do (if a slightly larger diff) ... I have to move the prototype from include/kernel.h to include/module.h because I need an assured asm/xxx include before it to get the override. I don't really see what this has

Re: [PATCH] Correct printk %pF to work on all architectures

2008-09-03 Thread Linus Torvalds
On Wed, 3 Sep 2008, James Bottomley wrote: You want me to pull the elf header files into lib/vsprintf.c and have something like No. I want you to stop polluting linux/module.h with total and utter crap. Please tell my WHY the hell you have diff --git a/include/linux/module.h

Re: [PATCH] Correct printk %pF to work on all architectures

2008-09-03 Thread James Bottomley
On Wed, 2008-09-03 at 16:15 -0700, Linus Torvalds wrote: On Wed, 3 Sep 2008, James Bottomley wrote: You want me to pull the elf header files into lib/vsprintf.c and have something like No. I want you to stop polluting linux/module.h with total and utter crap. Please tell my WHY

Re: [PATCH] Correct printk %pF to work on all architectures

2008-09-03 Thread Linus Torvalds
On Wed, 3 Sep 2008, James Bottomley wrote: Oh ... because Arjan has a patch to export dereference_function_descriptor. I suppose I could make him do the heavy lifting, but it seemed sensible to make it easy for him (and me) by putting it in a header.