Re: [PATCH] Fixup for "[v2] powerpc/8xx: Allow disabling KUAP at boot time"

2021-06-07 Thread Michael Ellerman 
Christophe Leroy  writes:
> Le 06/06/2021 à 19:43, Christophe Leroy a écrit :
>
> Michael, I sent it as a Fixup because it's in next-test, but if you prefer I 
> can sent a v3.

That's fine, I squashed it in.

cheers

Re: [PATCH] Fixup for "[v2] powerpc/8xx: Allow disabling KUAP at boot time"

2021-06-06 Thread Christophe Leroy 

Le 06/06/2021 à 19:43, Christophe Leroy a écrit :

Michael, I sent it as a Fixup because it's in next-test, but if you prefer I 
can sent a v3.

Christophe


Kernel test robot reported:


ERROR: modpost: "disable_kuap_key" [net/phonet/pn_pep.ko] undefined!
ERROR: modpost: "disable_kuap_key" [net/phonet/phonet.ko] undefined!
ERROR: modpost: "disable_kuap_key" [net/decnet/decnet.ko] undefined!
ERROR: modpost: "disable_kuap_key" [drivers/tee/tee.ko] undefined!
ERROR: modpost: "disable_kuap_key" [drivers/input/evdev.ko] undefined!
ERROR: modpost: "disable_kuap_key" [drivers/input/joydev.ko] undefined!
ERROR: modpost: "disable_kuap_key" [drivers/input/mousedev.ko] undefined!
ERROR: modpost: "disable_kuap_key" [drivers/input/serio/serio_raw.ko] undefined!
ERROR: modpost: "disable_kuap_key" [drivers/fsi/fsi-scom.ko] undefined!
ERROR: modpost: "disable_kuap_key" [drivers/watchdog/mv64x60_wdt.ko] undefined!

WARNING: modpost: suppressed 13 unresolved symbol warnings because there were 
too many)

disable_kuap_key has to be exported. Use EXPORT_SYMBOL() as userspace
access function are not exported as GPL today.

Reported-by: kernel test robot 
Signed-off-by: Christophe Leroy 
---
  arch/powerpc/mm/nohash/8xx.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/mm/nohash/8xx.c b/arch/powerpc/mm/nohash/8xx.c
index a8d44e9342f3..fc663322ba58 100644
--- a/arch/powerpc/mm/nohash/8xx.c
+++ b/arch/powerpc/mm/nohash/8xx.c
@@ -257,6 +257,7 @@ void __init setup_kuep(bool disabled)
  
  #ifdef CONFIG_PPC_KUAP

  struct static_key_false disable_kuap_key;
+EXPORT_SYMBOL(disable_kuap_key);
  
  void __init setup_kuap(bool disabled)

  {

[PATCH] Fixup for "[v2] powerpc/8xx: Allow disabling KUAP at boot time"

2021-06-06 Thread Christophe Leroy 
Kernel test robot reported:

>> ERROR: modpost: "disable_kuap_key" [net/phonet/pn_pep.ko] undefined!
>> ERROR: modpost: "disable_kuap_key" [net/phonet/phonet.ko] undefined!
>> ERROR: modpost: "disable_kuap_key" [net/decnet/decnet.ko] undefined!
>> ERROR: modpost: "disable_kuap_key" [drivers/tee/tee.ko] undefined!
>> ERROR: modpost: "disable_kuap_key" [drivers/input/evdev.ko] undefined!
>> ERROR: modpost: "disable_kuap_key" [drivers/input/joydev.ko] undefined!
>> ERROR: modpost: "disable_kuap_key" [drivers/input/mousedev.ko] undefined!
>> ERROR: modpost: "disable_kuap_key" [drivers/input/serio/serio_raw.ko] 
>> undefined!
>> ERROR: modpost: "disable_kuap_key" [drivers/fsi/fsi-scom.ko] undefined!
>> ERROR: modpost: "disable_kuap_key" [drivers/watchdog/mv64x60_wdt.ko] 
>> undefined!
WARNING: modpost: suppressed 13 unresolved symbol warnings because there were 
too many)

disable_kuap_key has to be exported. Use EXPORT_SYMBOL() as userspace
access function are not exported as GPL today.

Reported-by: kernel test robot 
Signed-off-by: Christophe Leroy 
---
 arch/powerpc/mm/nohash/8xx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/mm/nohash/8xx.c b/arch/powerpc/mm/nohash/8xx.c
index a8d44e9342f3..fc663322ba58 100644
--- a/arch/powerpc/mm/nohash/8xx.c
+++ b/arch/powerpc/mm/nohash/8xx.c
@@ -257,6 +257,7 @@ void __init setup_kuep(bool disabled)
 
 #ifdef CONFIG_PPC_KUAP
 struct static_key_false disable_kuap_key;
+EXPORT_SYMBOL(disable_kuap_key);
 
 void __init setup_kuap(bool disabled)
 {
-- 
2.25.0